From nobody Sun Feb 8 10:43:56 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9762245003 for ; Mon, 24 Feb 2025 08:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740384883; cv=none; b=m5tS5rOYkwNc/cO5qYd3aUrSK0cL9BCDw8fA2tx32B2hwuMng1qkN71ZjHP0y8AnHpub0kXl+VCE0tQPPxe6Onzh97dn28ODQn888I87Lu0vNuv1bl7lDoloFeLBivpWlhxoa4Fd+1HBQsyt5LIjo30Dw6wpkxGSWHV29z4nYc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740384883; c=relaxed/simple; bh=oe2FyQpDi+XexZe/0gZrbR4F62iNxsAIMF/U5rlF8BM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=WdheEBJVg4xPmy8dZ+m7sAaoQukyG8//IjKwb7Ef6IAwPQt4KggQ7NcM0XtAdUMZ5gYq/q802dshBlLbCgnxGPE7TEZ8RBt9NyVfhK6BDMMZPO5CLIeygOFRQ4RDiyF6/q1XTlXuYF/eTT3r2OmMi066VFmhKZluu8g3R5adryY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=scylladb.com; spf=pass smtp.mailfrom=scylladb.com; dkim=pass (2048-bit key) header.d=scylladb.com header.i=@scylladb.com header.b=lByyWHai; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=scylladb.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=scylladb.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=scylladb.com header.i=@scylladb.com header.b="lByyWHai" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-220d601886fso59147205ad.1 for ; Mon, 24 Feb 2025 00:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb.com; s=google; t=1740384880; x=1740989680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=n59C1mxnlqsVZDv+OXEoyoWE/LCHOE1N8E2Z0O569dM=; b=lByyWHaiC+WiEErxkPqA0M74SH9tASd9NyfWsYUjzIW3LkBcvIvQ9YNU4DI9Y/D9nU uZMKgmGPDKmdkFhr/eQ2lwWZAcc3QnXEi+LGVrlEBIQG22pK7/EljwlDAp7b11FyA7FO S3uQCVxRCJ9Khpesug7glVI5morIO/PFaw2XFX46LUbhOR7LwfuEmAp3WbH1XmDdeQP1 kK0BBWKO7QFWc88Kvc7e1J7GHww50mU5ISjiGz2vlzu6rgfNp610OC9xwHUxQGPX2Q9k mrf3Sgb9W1Ij1VCpOJAq6T9uEXk/XCHMd1MlHXgH8kfhDtkUTGQmbLoSZNmEc2Wu5ufE j22w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740384880; x=1740989680; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n59C1mxnlqsVZDv+OXEoyoWE/LCHOE1N8E2Z0O569dM=; b=t1WIdSXAvtqu6jFkupykJO9Okwj/+ZT2blLfSsZiLVfYrrG+1dy5YpaOAoa915R8bD SULasxkDHXHTZI02dXEPuW1+Op/1z9BMX0efnYAhCHNpBWUJvW3cLi+iduXGPVPmVsXH JJaLaQrocx3pGz5TY4M6DbfSoUYm+pop/Ucz2B0ZlQyK1VszSVBTaXDY++PAVztxDTC/ Yo1TJOMOnhrmWSWsmD8gfVSpRLk9c3QgVBCEBaLWrPWyuEI21zsOuVf/4749W/+CA73A 5b3iOweGPv8k9XFwi1zVWxoxv05ASBwgidntmwbhd5qQ81hvJF31Jdymm41+JcKJYDxa PkCA== X-Gm-Message-State: AOJu0YwsRr669hJGu5nvN219zfxKqADS74F7AJajrd22lRY7ScYnajFj AU5NdDzw7kgqbtRP0QtN7qf57THAsyz6PUzmrkKfxDMZOiAOoF5PRUQwYGxI4WFD84J0wO0SAfa rHVhlbJlPZpfL/Lazb5aEdo7IHEohEYpZY7yiecHO7oQSGD/rZ0iL8go9NAs6X1TUM8j4/esIb9 mF80ep8x1ChfbPHCISeKG/KX9aOipzWcrbe0gipIGySHlcJ/uxAB2+yhgytkfdzYoOFXmhZU9Pz KSk7cZ07kxUdAVSahqv8yjfhdKxap2ac3oKkD7nSiHluotQnSav3o7t/cNtI2GIeFLOEGJOoxku LMxnPNevJK7zYeOn2tngIYlIVRqa48mkR4rO40PB5RxKrFuzTq1NkCz2+2s= X-Gm-Gg: ASbGncuGG1FA2Qo+4KcWlqlDNV4Qfn9rVEWh8vvADe4swiLjLP2V8kIPn3q4AUn5bz7 qQqZ6krWDrWRoxyjI6fMZxCi1FbGA3etw4wIS8Cx+RaxY9IJiT4L7LhpoFnW7i45MGkBYHQRaYu f4nHsd53s4nZMNjOemeR9JNu6ggV9lpjXKz+cxhUton1KLU30iO5AUNTj35o9GnLcBzup4EUXxl 6r0svVXQsG+oxBac8HBzEE00RxGY/cyj6PNlvt5NdN51JHPLK8wsKGl00pNAG6ge45hPGd2giu5 fWJ40dmarLqlzBTaGz0z8oE94WdM0g== X-Google-Smtp-Source: AGHT+IGZML+QeMBAJSjHG5iq0A0nDtnil2LVDOPQzKcK170nIopsu8yPUqb4/J1ur3vn2QrKyGEe6w== X-Received: by 2002:a05:6a20:7f85:b0:1ee:d6ff:5acd with SMTP id adf61e73a8af0-1eef3c568e9mr25167734637.6.1740384880406; Mon, 24 Feb 2025 00:14:40 -0800 (PST) Received: from localhost.localdomain ([2a09:bac5:7a2:24be::3a9:82]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ae1ee4febb2sm10280324a12.51.2025.02.24.00.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 00:14:39 -0800 (PST) From: "Raphael S. Carvalho" To: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: djwong@kernel.org, Dave Chinner , hch@lst.de, willy@infradead.org, "Raphael S. Carvalho" Subject: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT Date: Mon, 24 Feb 2025 05:13:28 -0300 Message-ID: <20250224081328.18090-1-raphaelsc@scylladb.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylladb,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylla,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 original report: https://lore.kernel.org/all/CAKhLTr1UL3ePTpYjXOx2AJfNk8Ku2EdcEfu+CH1sf3Asr= =3DB-Dw@mail.gmail.com/T/ When doing buffered writes with FGP_NOWAIT, under memory pressure, the syst= em returned ENOMEM despite there being plenty of available memory, to be recla= imed from page cache. The user space used io_uring interface, which in turn subm= its I/O with FGP_NOWAIT (the fast path). retsnoop pointed to iomap_get_folio: 00:34:16.180612 -> 00:34:16.180651 TID/PID 253786/253721 (reactor-1/combined_tests): entry_SYSCALL_64_after_hwframe+0x76 do_syscall_64+0x82 __do_sys_io_uring_enter+0x265 io_submit_sqes+0x209 io_issue_sqe+0x5b io_write+0xdd xfs_file_buffered_write+0x84 iomap_file_buffered_write+0x1a6 32us [-ENOMEM] iomap_write_begin+0x408 iter=3D&{.inode=3D0xffff8c67aa031138,.len=3D4096,.flags=3D33,.iomap=3D{.add= r=3D0xffffffffffffffff,.length=3D4096,.type=3D1,.flags=3D3,.bdev=3D0x=E2=80= =A6 pos=3D0 len=3D4096 foliop=3D0xffffb32c296b7b80 ! 4us [-ENOMEM] iomap_get_folio iter=3D&{.inode=3D0xffff8c67aa031138,.len=3D4096,.flags=3D33,.iomap=3D{.add= r=3D0xffffffffffffffff,.length=3D4096,.type=3D1,.flags=3D3,.bdev=3D0x=E2=80= =A6 pos=3D0 len=3D4096 This is likely a regression caused by 66dabbb65d67 ("mm: return an ERR_PTR from __filemap_get_folio"), which moved error handling from io_map_get_folio() to __filemap_get_folio(), but broke FGP_NOWAIT handling,= so ENOMEM is being escaped to user space. Had it correctly returned -EAGAIN wi= th NOWAIT, either io_uring or user space itself would be able to retry the request. It's not enough to patch io_uring since the iomap interface is the one responsible for it, and pwritev2(RWF_NOWAIT) and AIO interfaces must return the proper error too. The patch was tested with scylladb test suite (its original reproducer), and the tests all pass now when memory is pressured. Fixes: 66dabbb65d67 ("mm: return an ERR_PTR from __filemap_get_folio") Signed-off-by: Raphael S. Carvalho --- mm/filemap.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index 804d7365680c..d7646e73f481 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1986,8 +1986,12 @@ struct folio *__filemap_get_folio(struct address_spa= ce *mapping, pgoff_t index, =20 if (err =3D=3D -EEXIST) goto repeat; - if (err) + if (err) { + /* Prevents -ENOMEM from escaping to user space with FGP_NOWAIT */ + if ((fgp_flags & FGP_NOWAIT) && err =3D=3D -ENOMEM) + err =3D -EAGAIN; return ERR_PTR(err); + } /* * filemap_add_folio locks the page, and for mmap * we expect an unlocked page. --=20 2.48.1