From nobody Wed Dec 17 03:06:31 2025 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B09F4E2; Mon, 24 Feb 2025 03:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740366732; cv=none; b=JBq/EyQuXLSmkxKU1TNP4i8sT1dg79LV9vPSfC7gDD+P7O23eiUNQGRnqtSbwhP+17ivpQ7iWLnJ0/uS/j4KNvQ23GFGQiMrUxbb23UWQwaMBqXsc6ZTTcCtaOhzH3EKHND2vXNXoATXY/n205GM96+J0dniZFZqh8qNnfs4X84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740366732; c=relaxed/simple; bh=XWJMx12NbsBM+EgAyV5Uqf9FJjuPIfxva8iem+oY5tQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=iQlEKt2PAlOoRdu+FD5vPwIgGd0hqO/uqD6iNz/Cp67F7kXxBmzCwrtuXB1H14TAItAAMQEvikJGNPrz5MRVJFnngONj360uTZLLMhIJr/ewD+iyyNQIwzj224NEddB+Y9T2Gs+zCNeziTdg9bs5Siy2+vslsMxuo/v4eleCoNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Z1Qfn4TKxzCs7B; Mon, 24 Feb 2025 11:08:33 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id 426EE1402E2; Mon, 24 Feb 2025 11:11:59 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 24 Feb 2025 11:11:57 +0800 From: Tong Tiangen To: David Hildenbrand , Oleg Nesterov , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Peter Xu , Ian Rogers , Adrian Hunter , "Liang, Kan" , Masami Hiramatsu CC: , , , , , Tong Tiangen , , Guohanjun Subject: [PATCH -next v3] uprobes: reject the share zeropage in uprobe_write_opcode() Date: Mon, 24 Feb 2025 11:11:49 +0800 Message-ID: <20250224031149.1598949-1-tongtiangen@huawei.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemk500005.china.huawei.com (7.202.194.90) Content-Type: text/plain; charset="utf-8" We triggered the following error logs in syzkaller test: BUG: Bad page state in process syz.7.38 pfn:1eff3 page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1eff3 flags: 0x3fffff00004004(referenced|reserved|node=3D0|zone=3D1|lastcpupid= =3D0x1fffff) raw: 003fffff00004004 ffffe6c6c07bfcc8 ffffe6c6c07bfcc8 0000000000000000 raw: 0000000000000000 0000000000000000 00000000fffffffe 0000000000000000 page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubunt= u1.1 04/01/2014 Call Trace: dump_stack_lvl+0x32/0x50 bad_page+0x69/0xf0 free_unref_page_prepare+0x401/0x500 free_unref_page+0x6d/0x1b0 uprobe_write_opcode+0x460/0x8e0 install_breakpoint.part.0+0x51/0x80 register_for_each_vma+0x1d9/0x2b0 __uprobe_register+0x245/0x300 bpf_uprobe_multi_link_attach+0x29b/0x4f0 link_create+0x1e2/0x280 __sys_bpf+0x75f/0xac0 __x64_sys_bpf+0x1a/0x30 do_syscall_64+0x56/0x100 entry_SYSCALL_64_after_hwframe+0x78/0xe2 BUG: Bad rss-counter state mm:00000000452453e0 type:MM_FILEPAGES val:-1 The following syzkaller test case can be used to reproduce: r2 =3D creat(&(0x7f0000000000)=3D'./file0\x00', 0x8) write$nbd(r2, &(0x7f0000000580)=3DANY=3D[], 0x10) r4 =3D openat(0xffffffffffffff9c, &(0x7f0000000040)=3D'./file0\x00', 0x42= , 0x0) mmap$IORING_OFF_SQ_RING(&(0x7f0000ffd000/0x3000)=3Dnil, 0x3000, 0x0, 0x12= , r4, 0x0) r5 =3D userfaultfd(0x80801) ioctl$UFFDIO_API(r5, 0xc018aa3f, &(0x7f0000000040)=3D{0xaa, 0x20}) r6 =3D userfaultfd(0x80801) ioctl$UFFDIO_API(r6, 0xc018aa3f, &(0x7f0000000140)) ioctl$UFFDIO_REGISTER(r6, 0xc020aa00, &(0x7f0000000100)=3D{{&(0x7f0000ffc= 000/0x4000)=3Dnil, 0x4000}, 0x2}) ioctl$UFFDIO_ZEROPAGE(r5, 0xc020aa04, &(0x7f0000000000)=3D{{&(0x7f0000ffd= 000/0x1000)=3Dnil, 0x1000}}) r7 =3D bpf$PROG_LOAD(0x5, &(0x7f0000000140)=3D{0x2, 0x3, &(0x7f0000000200= )=3DANY=3D[@ANYBLOB=3D"1800000000120000000000000000000095"], &(0x7f00000000= 00)=3D'GPL\x00', 0x7, 0x0, 0x0, 0x0, 0x0, '\x00', 0x0, @fallback=3D0x30, 0x= ffffffffffffffff, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x= 10, 0x0, @void, @value}, 0x94) bpf$BPF_LINK_CREATE_XDP(0x1c, &(0x7f0000000040)=3D{r7, 0x0, 0x30, 0x1e, @= val=3D@uprobe_multi=3D{&(0x7f0000000080)=3D'./file0\x00', &(0x7f0000000100)= =3D[0x2], 0x0, 0x0, 0x1}}, 0x40) The cause is that zero pfn is set to the pte without increasing the rss count in mfill_atomic_pte_zeropage() and the refcount of zero folio does not increase accordingly. Then, the operation on the same pfn is performed in uprobe_write_opcode()->__replace_page() to unconditional decrease the rss count and old_folio's refcount. Therefore, two bugs are introduced: 1. The rss count is incorrect, when process exit, the check_mm() report error "Bad rss-count". 2. The reserved folio (zero folio) is freed when folio->refcount is zero, then free_pages_prepare->free_page_is_bad() report error "Bad page state". There is more, the following warn could also theoretically be triggered: __replace_page() -> ... -> folio_remove_rmap_pte() -> VM_WARN_ON_FOLIO(is_zero_folio(folio), folio) Considering that uprobe hit the zero folio is a very rare scene, just reject zero old folio immediately after get_user_page_vma_remote(). Fixes: 7396fa818d62 ("uprobes/core: Make background page replacement logic = account for rss_stat counters") Fixes: 2b1444983508 ("uprobes, mm, x86: Add the ability to install and remo= ve uprobes breakpoints") Signed-off-by: Tong Tiangen Reviewed-by: David Hildenbrand Reviewed-by: Oleg Nesterov --- v3: update the subject/changelog as David suggests. v2: Modified according to the comments of David and Oleg. --- kernel/events/uprobes.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 9372bfd0e8fc..ca1879c74158 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -506,6 +506,11 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, s= truct mm_struct *mm, if (ret <=3D 0) goto put_old; =20 + if (is_zero_page(old_page)) { + ret =3D -EINVAL; + goto put_old; + } + if (WARN(!is_register && PageCompound(old_page), "uprobe unregister should never work on compound page\n")) { ret =3D -EINVAL; --=20 2.25.1