From nobody Fri Dec 19 21:46:33 2025 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB0220B20A for ; Mon, 24 Feb 2025 07:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740380642; cv=none; b=sJfkkRIhi/Egj6mpQl8kaTwhJ+oM550tbxQJvm50ai1eTNqNu0I82jq1SkdKKZYc90dhFo+2U6lNAStZaY9bFKi3/Q0+YfN6HIi6oPGJ1xzcwguBWw7Rxjml29CaSIme+xvQT1ru2jt2NUpQgfeoZ6F3ugRO00PZAKEhBX0cKdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740380642; c=relaxed/simple; bh=gxhapjJ2V7VmgaU4ygU27WoYv9liMFZHBLfXA9uaLac=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m5AxCRZd4EtvbUYkAlPSSERuXl1mwu0Za1Ct5rbQxUupzRaDwn/6qapHs4Gg0+yMjYYn/w2ftKvPwLvX3OJj0nFLRx5pdCj8szQQ2Q+hTV/skbQBJyHgaqm+5pFFH1bR2IDPbRYVTH306dN5L8E9PYCQsqNnRAYO59Bi9Kfdxx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MrlsSQcZ; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MrlsSQcZ" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7c2303a56d6so58044485a.3 for ; Sun, 23 Feb 2025 23:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740380639; x=1740985439; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+zNBSiNN48vAuN3f6QiTHcLYM/YjS/mOVk8GlAcAGX0=; b=MrlsSQcZYiQPKGDyNH4bQfoY5eUpyg0fJk+ViixTJ8pRRnwQ6hQFWzK1U8yrVIMJ+H GUOsysBQGsWM2huhXAikce7Ne33qE9HoH0/7lh6EfNhMdhlp/8VdSpm13T+HevnEOEuB T+e5BrS7ntkCVfOY2qhPgK4IjT+TZitoNQV94= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740380639; x=1740985439; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+zNBSiNN48vAuN3f6QiTHcLYM/YjS/mOVk8GlAcAGX0=; b=jB8N/6kk0fgnJh3b02XNP99H1oS5iHmbq0pjm987iI05cBkFONZWgZU6OSJDaxcZO/ Vw/l1cRIiAMV0IAAojNF+eHrjnKPRLkvn27MXEwWzOYumHsCOA/n6EZOnoYExdVneRV+ JBPzbAufCQ/SFN9PaKpUHQZR+KKPU1hzS0EkFAMp1rOFo+IwfArPQequRrkcxJeYbsAV kEGdpEdH7vCtKdvLIOIIQZstwQ0M2mOiTMfZAvvDfsMPWwFyBus5zCBE9zRjiwixRD1C 1oTNBGDlB7PVOcdSBSbix7MZVO9GsoHLLPp1es19mmjp6RoGEG9KLVS/mHhcgZRS4gyA uArA== X-Forwarded-Encrypted: i=1; AJvYcCX19swoShZ8hWv9ivMHmvn+fQB615XEk8DgfsrmUI4XafaNj2MIW1ZfJPuq1d+9C9UNYnNgS6EIbtPwb0o=@vger.kernel.org X-Gm-Message-State: AOJu0YwdlrDHJQOkWGKNk1oIgWa/0klkC18gFhJ/yWEAH6JnDQuDzlqO 2UaKWgWD8gTzgwtPj02cKqQZGvUGRI7c04++nZklzWvfnUDTdA680zOfhViuTQ== X-Gm-Gg: ASbGnctpykMPZnf1DXqtHVtmDdYSo81T+5KXD32EHYzlOn98DX9YN4tIlpA6xjjEJ/5 mLVBo3VQ8TzAggLjeMNkMfsrvTuzDOB/3z3MLt71eJuV3pQU+8OyJFkJtn4HdzoHYAEDGYerGEK VHiHSl+nvisiiBGFf47vYA2L+ek07qmsnaod0mR7A4OnxQl12X1LuY8vEKj/zEWoguyaWjUt8Tg SOZjHjZFC3gyKcK4bPLw0QFqBALkU8EmCSgnjFmiZYesYdxg6PrQ40/dktkpsWBxMRcG6zZvNDw CloJTqVryxZeVom1AIPLehEttiv6j7Nt9cs3VEmiWntZyZdpKXntPxsmfP4SBZQjLT3tvyGdJ4T 8JH4= X-Google-Smtp-Source: AGHT+IHcm5l4vj+qLy5nO1kcV2ISxYp1Ig6V5tDSH+3S1QoU9rYnKzcGaZk0NeL01r9155s+2saw4Q== X-Received: by 2002:a05:620a:488f:b0:7c0:b018:5928 with SMTP id af79cd13be357-7c0cf96eeacmr1637963085a.47.1740380639403; Sun, 23 Feb 2025 23:03:59 -0800 (PST) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c09bf81253sm977920485a.47.2025.02.23.23.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 23:03:58 -0800 (PST) From: Ricardo Ribalda Date: Mon, 24 Feb 2025 07:03:54 +0000 Subject: [PATCH v2 1/2] media: nuvoton: Fix reference handling of ece_node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250224-nuvoton-v2-1-8faaa606be01@chromium.org> References: <20250224-nuvoton-v2-0-8faaa606be01@chromium.org> In-Reply-To: <20250224-nuvoton-v2-0-8faaa606be01@chromium.org> To: Joseph Liu , Marvin Lin , Mauro Carvalho Chehab , Hans Verkuil , Philipp Zabel Cc: Marvin Lin , linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , stable@vger.kernel.org X-Mailer: b4 0.14.1 Make sure all the code paths call of_node_put(). Instead of manually calling of_node_put, use the __free macros/helpers. Cc: stable@vger.kernel.org Fixes: 46c15a4ff1f4 ("media: nuvoton: Add driver for NPCM video capture and= encoding engine") Signed-off-by: Ricardo Ribalda --- drivers/media/platform/nuvoton/npcm-video.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/pl= atform/nuvoton/npcm-video.c index 024cd8ee1709..0547f119c38f 100644 --- a/drivers/media/platform/nuvoton/npcm-video.c +++ b/drivers/media/platform/nuvoton/npcm-video.c @@ -1648,8 +1648,8 @@ static int npcm_video_setup_video(struct npcm_video *= video) =20 static int npcm_video_ece_init(struct npcm_video *video) { + struct device_node *ece_node __free(device_node) =3D NULL; struct device *dev =3D video->dev; - struct device_node *ece_node; struct platform_device *ece_pdev; void __iomem *regs; =20 @@ -1669,7 +1669,6 @@ static int npcm_video_ece_init(struct npcm_video *vid= eo) dev_err(dev, "Failed to find ECE device\n"); return -ENODEV; } - of_node_put(ece_node); =20 regs =3D devm_platform_ioremap_resource(ece_pdev, 0); if (IS_ERR(regs)) { --=20 2.48.1.601.g30ceb7b040-goog From nobody Fri Dec 19 21:46:33 2025 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16DAC241679 for ; Mon, 24 Feb 2025 07:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740380644; cv=none; b=Vrw47mt9gPVbADay/JrJ27vc+p+f8gEaxEwFlM/GWjIe0hmOI4ibB/NU1TY2o5OAlw2VsvT+jrqzLTPADLmBVrwaovGBF/AHopGfxWZSfMwEHymUG1+Coi8909Rof0NlppYv4PkH9aC6fkEJDnv/8NFOFDjLaeyg0N2k1YW8F6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740380644; c=relaxed/simple; bh=8AyV0e0qRbEmKU/uCI50pjnIFt3/6pXpYJ2kgM0yvh0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pYf5HHuPkvd5sD2/s59SAhf2jZk94GR5N7bdXPyQUTnp/Fo280uxP2MEzqTr/er9MO/dzplUCXU7AiNteXkwGgPJTjJcDXlUQGfHRH6vzFzxySwvV4cRUgKxSXXWrA4YhNqr4ZV542DFsKI21jp0bbkcP1DS9qjRNI/3umx1ZNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DQvVUuRc; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DQvVUuRc" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7c0a1c4780bso423519285a.3 for ; Sun, 23 Feb 2025 23:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740380642; x=1740985442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5q6OzdDXgwAQxAxBQA745WK29nT03MLnpLkJ+gh1wVI=; b=DQvVUuRc07ODeb9F6NLOEkVhpDBAPELeUDxv+/BT3zMQuczi/VtdxMCERZa4NWORux I2WC3lDXCpx78wv7fLDoffJLGT+xxOta8dX9OR6Fxf6qi5FjYlU+JUIyJKlspy9hoblF dWeVt9pkXzmPifK0T1ZLsqAFBXBNAWGHm5m54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740380642; x=1740985442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5q6OzdDXgwAQxAxBQA745WK29nT03MLnpLkJ+gh1wVI=; b=MA4xKtDh9xe+q9sBTfNsCXoSnQYoY9BGXgch+ksGyAnT3NynECCNsgZTeBhTzl0VF6 vCn78qfTBn4UoRaGCxEKASzIkVoBg8N8Gcj1mrS/BbfGGaCNJn+bDfLQYcj09NjIfFvB foFuifzWE82RlI6c4QrtyGbdXUztMUix1xiCEpkxNu4Pfh3pzTCKA+pI7ceuzE3gwz2L 4zaJW5s9Wss4Kl5F0fmMRt1ZZZhZuSJydcQp7ylqvetfGxdMaYloo4zKzEVOb/cEspej ruZc52gaI/DgHOkFcf2sl8WhoPyZlKp6hFjyiwGBOmqsuBPrl5Vvzm71c/wt9irtkt7q spfQ== X-Forwarded-Encrypted: i=1; AJvYcCVMecajiWkQ8sWZbeQ4apDYHTXbq+r48QPlUSubH9CK+vQfTj+sDBkOO8uz4aYZ6uVSlDuMLPyfGJRoyxU=@vger.kernel.org X-Gm-Message-State: AOJu0YxjapLFCSK0fkKMKfeNSp4IlTJYGz2H/Yn8xD1Eh5PDsO/xEHuu Gvy+7otS4VeF08zZw/6kTa+tKMb4+uaPfQwWzqEiXYWmPW8yfqtCSe9QiwT0Nw== X-Gm-Gg: ASbGncs2OUu9bQvu6/wO5bi7WlEWXvm4RO8DLjQaXP6WmVPg7S54Aq15pebkZh+2RJE BHpXtJUxJ8JZ/ow/wnlIbLfKIg/BtWEY46Ax92OqNiNsqZca3pC/Bf/RbImTM4QD5lgV7uZa8o8 X0FaFW5rRBiI82wObG7e74B9jY9dSaLlwsdV2jgP2LLFn0FXUOQFCvrm7uhD3LFbl36gkROo+B3 SGhL+8fIOVdzz+CFiXXZr5iRuKhoK2CMctGWOz9lwqq1fCN+kIGbP62NDXWGSq+IZ4iaTEILQ/x wKa+4qgrO5bTZhkwSNwGHYxtxpiyMFizn1N4tZMA180gnA3JHyCBxfzTW4HFZbn7jCv+jhUMplu qfd4= X-Google-Smtp-Source: AGHT+IHgxFsGJ5AGKD2il9LAdTDxMgGFCz1Kjs7fo9qIU1XdeZFdKJmn66/YwmftLgDLOc15f+yjhQ== X-Received: by 2002:a05:620a:8006:b0:7c0:8175:3651 with SMTP id af79cd13be357-7c0cef5333fmr1704029285a.43.1740380641946; Sun, 23 Feb 2025 23:04:01 -0800 (PST) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c09bf81253sm977920485a.47.2025.02.23.23.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 23:04:00 -0800 (PST) From: Ricardo Ribalda Date: Mon, 24 Feb 2025 07:03:55 +0000 Subject: [PATCH v2 2/2] media: nuvoton: Fix reference handling of ece_pdev Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250224-nuvoton-v2-2-8faaa606be01@chromium.org> References: <20250224-nuvoton-v2-0-8faaa606be01@chromium.org> In-Reply-To: <20250224-nuvoton-v2-0-8faaa606be01@chromium.org> To: Joseph Liu , Marvin Lin , Mauro Carvalho Chehab , Hans Verkuil , Philipp Zabel Cc: Marvin Lin , linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , stable@vger.kernel.org X-Mailer: b4 0.14.1 When we obtain a reference to of a platform_device, we need to release it via put_device. Found by cocci: ./platform/nuvoton/npcm-video.c:1677:3-9: ERROR: missing put_device; call o= f_find_device_by_node on line 1667, but without a corresponding object rele= ase within this function. ./platform/nuvoton/npcm-video.c:1684:3-9: ERROR: missing put_device; call o= f_find_device_by_node on line 1667, but without a corresponding object rele= ase within this function. ./platform/nuvoton/npcm-video.c:1690:3-9: ERROR: missing put_device; call o= f_find_device_by_node on line 1667, but without a corresponding object rele= ase within this function. ./platform/nuvoton/npcm-video.c:1694:1-7: ERROR: missing put_device; call o= f_find_device_by_node on line 1667, but without a corresponding object rele= ase within this function. Instead of manually calling put_device, use the __free macros. Cc: stable@vger.kernel.org Fixes: 46c15a4ff1f4 ("media: nuvoton: Add driver for NPCM video capture and= encoding engine") Signed-off-by: Ricardo Ribalda --- drivers/media/platform/nuvoton/npcm-video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/pl= atform/nuvoton/npcm-video.c index 0547f119c38f..7a9d8928ae40 100644 --- a/drivers/media/platform/nuvoton/npcm-video.c +++ b/drivers/media/platform/nuvoton/npcm-video.c @@ -1669,6 +1669,7 @@ static int npcm_video_ece_init(struct npcm_video *vid= eo) dev_err(dev, "Failed to find ECE device\n"); return -ENODEV; } + struct device *ece_dev __free(put_device) =3D &ece_pdev->dev; =20 regs =3D devm_platform_ioremap_resource(ece_pdev, 0); if (IS_ERR(regs)) { @@ -1683,7 +1684,7 @@ static int npcm_video_ece_init(struct npcm_video *vid= eo) return PTR_ERR(video->ece.regmap); } =20 - video->ece.reset =3D devm_reset_control_get(&ece_pdev->dev, NULL); + video->ece.reset =3D devm_reset_control_get(ece_dev, NULL); if (IS_ERR(video->ece.reset)) { dev_err(dev, "Failed to get ECE reset control in DTS\n"); return PTR_ERR(video->ece.reset); --=20 2.48.1.601.g30ceb7b040-goog