From nobody Thu Dec 18 05:55:49 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7329E1B3927 for ; Thu, 20 Feb 2025 08:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740041682; cv=none; b=TAJ8GNoiBm0IbUxJ1o0B/5OACNOvzElfxJ+1s0dBQZdD2JhePPFoR9Kz6U325W7Np7J04mLXwTpXd407ZpArerlrgW2OQn2ng3kTfnRk0DZU7G0KWc81VlKWku8VP4gowUFk0Rmi740OvY63IFPG0xhZyYusfPEKmo34ZWgs/1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740041682; c=relaxed/simple; bh=XuBYkqKTh1TJ8ljtBKLvAKKsI9mJGYCYOnlqLVE2wdc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gNkU2PcAwdOD+pMS5LookwSEI4DpwES3/U+oNn58gC7ywSLch9r5IVsShQZ2KjyOnku3I7ya0jKpV9o2yG8/8+xbxTbFo6CffaCKZxtgKPAd+2hAUAsfgWINnVLgsGyqFRcs/ZiT3LPPCAWSmeo+NemrkYaP+ahbh8SznV2AUVk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=HVTauNK1; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="HVTauNK1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=tR6HK 7BPrCbBvCzg+WZMBSOfkdZaQhKpZsbhz6ow2Vs=; b=HVTauNK1y44q7bM8/Pohf BKz69UW8HYcPFVzf1WXvs9y0Ir2xzkbXbRwwJCu/jYMrMyGrdtY3jv7SgbiZ82GQ zp1TlyRu3Kpn5KosQWjAM4DC3xnhj8QsHbxjgjBzp88mzA74myaRtm6DlEKf+ghu TfzzptIPP5VFAiAguPouxo= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wDnLwmn7bZnUN9jNQ--.46079S2; Thu, 20 Feb 2025 16:54:01 +0800 (CST) From: oushixiong1025@163.com To: Liviu Dudau Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou Subject: [PATCH] drm/arm/komeda: Add a condition check before removing sysfs attribute Date: Thu, 20 Feb 2025 16:53:58 +0800 Message-Id: <20250220085358.232883-1-oushixiong1025@163.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnLwmn7bZnUN9jNQ--.46079S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WFyUWr1xGF4xAr1kKw17Jrb_yoW8ZF1Upa nrJ3WjqryUKanIyr9rAa1UuF1rGw4fWw4xGryUuw13u343AF18KF95XFWqyrZrJFWfCF1a qrs7XrW7WFs3Kr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jncTPUUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/1tbiXRD5D2e25TahOwAAsj Content-Type: text/plain; charset="utf-8" From: Shixiong Ou [WHY] If the call to sysfs_create_group() fails, there is no need to call function sysfs_remove_group(). [HOW] Add a condition check before removing sysfs attribute. Signed-off-by: Shixiong Ou --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 7 ++++++- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/= drm/arm/display/komeda/komeda_dev.c index 5ba62e637a61..7d646f978640 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -259,6 +259,8 @@ struct komeda_dev *komeda_dev_create(struct device *dev) goto err_cleanup; } =20 + mdev->sysfs_attr_enabled =3D true; + mdev->err_verbosity =3D KOMEDA_DEV_PRINT_ERR_EVENTS; =20 komeda_debugfs_init(mdev); @@ -278,7 +280,10 @@ void komeda_dev_destroy(struct komeda_dev *mdev) const struct komeda_dev_funcs *funcs =3D mdev->funcs; int i; =20 - sysfs_remove_group(&dev->kobj, &komeda_sysfs_attr_group); + if (mdev->sysfs_attr_enabled) { + sysfs_remove_group(&dev->kobj, &komeda_sysfs_attr_group); + mdev->sysfs_attr_enabled =3D false; + } =20 debugfs_remove_recursive(mdev->debugfs_root); =20 diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/= drm/arm/display/komeda/komeda_dev.h index 5b536f0cb548..af087540325c 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -216,6 +216,8 @@ struct komeda_dev { #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) /* Disable rate limiting of event prints (normally one per commit) */ #define KOMEDA_DEV_PRINT_DISABLE_RATELIMIT BIT(12) + + bool sysfs_attr_enabled; }; =20 static inline bool --=20 2.17.1