From nobody Thu Dec 18 16:16:08 2025 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF341E25FA; Thu, 20 Feb 2025 06:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740032090; cv=fail; b=B4YcsYjMtswJY0pcrRhofURT347WCz66qU6do4B1Gfx73E0X0CcDkwdAxdoR2XCaoPN7IBUhXVliCla97HkgT1tzDy+pdjt7S/6/rjIy1JIPCUnc3CpAiJ5obvFU7n7Icrruvq/SoAolmwrBPrEeGcqr4DJoPGM250co3pfvXJY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740032090; c=relaxed/simple; bh=GlR6eIZ2Zcy8IQY8ZY9EbUGt2DZPsZSOQxIzFYdhIvE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=KT4946hWqroVVG/kFuzK+F9pkAGoIVULF+JesfQ+5+HCVuiBkQtObER8T8HtFh0OpxiLGknOTArItSilVrKdxHcgoDT3oyZwaLwFpTNhjZx++Eo/xre76s7u83cmtqhQpPSFAxyHtGFNQpFc1qTmq+TmD2Wa1hNW7WJP9dcCdPw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=UC6c+cNQ; arc=fail smtp.client-ip=40.107.20.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="UC6c+cNQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MGXyvqrgyVAKYv+d2wC4AIJGxeAz9kbmzP5SClYDbhIDcFAa4OgwS+7idxPRTs+JJ4fPSxLn25znoPvknrAVWHPJ7aF9Z/8tDks+hMAeXFwTieXoIg6kv6zo0kEvO/f8H0GYtoALNADYBou8uZy5eZhv2Q8v8lu0ZCSzr6jtLOGvVuvCRzuprYVl+uCdFpuQdULAHRXBdxl1HbbB1GWKa1XA73/i0ZvlAzigHCJqnWgLzesHVatrn5e7zX4LreP+RdDdsPbkJz8727ebbvcQxsmOFmZcdpOf9KO/K0B3gxz3UENqhDjpbhTBAo848rz3S/PuAIf+xE1eUnLCRoxOvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ktyi36l/FLgD7kKRY5wjaUegUkWBr8R8cXtYD8KHUnA=; b=xs01Oev+7tMmOIdgG0Gvr6nV6CIhPoo2suzhQGOmmc8rfFbELykAN8iUR3STumfXYtTeIR2HENTneaz4yzjrYz0tHv2otcGh3hOSRR8MweevPDErTf+rs0vOugJW8h04pvEqHwhjHW8PC0N7VDBqRzsg0k/FsWkbvQt6mlzwOspQU+8qsn9IbhAmaINLKNxt7qwxAAfmQvh2RlaUPJYAqKyRodoaerGsSsAVe/lzEazVGTwBzvhzK1Fyip0v1C2l393TMHV7T2mGHf+04hkQ0DGHgz45LzmhJyQ0Q2YfBaFCRwEFoFq/ueyMppjAuowggb0FO+yYDI3KfSwJg+Lz7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ktyi36l/FLgD7kKRY5wjaUegUkWBr8R8cXtYD8KHUnA=; b=UC6c+cNQDJ3C75SQlHIPJr9xxhQB9mvKSXPmg/cowvx9oNYszNyYfzIZNIchnhUgJr0f3XgdYFqcMGpCZog2dykgx+NzNeQCo2r4cS7iaGAuWgaD5ICwOEaEyVIOpC6pE8idJSqKgxOoviFjsekYA1V09OIq7bRdxPM4lwXxfEPcd18r1ts8k2pYlnfoKcoVe0sGbc87CsapcawX3FmYJBPaEVeBhI9ROKKj6RV0vdHZp/cUKy9hJmdnZS7t4x1KPWB8qz2CnB2KVDsF8oJMeMpdGUNQAk1Ye3az+YQTMmJkBwXeakofMnl4mpmbBbCdP/vM16vzuv3Rm9/MP+bSDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAWPR04MB9910.eurprd04.prod.outlook.com (2603:10a6:102:380::7) by GVXPR04MB10047.eurprd04.prod.outlook.com (2603:10a6:150:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Thu, 20 Feb 2025 06:14:46 +0000 Received: from PAWPR04MB9910.eurprd04.prod.outlook.com ([fe80::24b9:b9fd:bcc0:4ee6]) by PAWPR04MB9910.eurprd04.prod.outlook.com ([fe80::24b9:b9fd:bcc0:4ee6%5]) with mapi id 15.20.8445.017; Thu, 20 Feb 2025 06:14:46 +0000 From: Jeff Chen To: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, johannes@sipsolutions.net, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com, s.hauer@pengutronix.de, Jeff Chen Subject: [PATCH v3 1/2] wifi: mwifiex: Part A of resolving the failure in downloading calibration data. Date: Thu, 20 Feb 2025 14:11:42 +0800 Message-Id: <20250220061143.1417420-2-jeff.chen_1@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250220061143.1417420-1-jeff.chen_1@nxp.com> References: <20250205012843.758714-1-jeff.chen_1@nxp.com> <20250220061143.1417420-1-jeff.chen_1@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P192CA0008.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::6) To PAWPR04MB9910.eurprd04.prod.outlook.com (2603:10a6:102:380::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAWPR04MB9910:EE_|GVXPR04MB10047:EE_ X-MS-Office365-Filtering-Correlation-Id: eed19c0b-7b4e-4ba7-e72e-08dd5175df6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?O59tLFoG0HMK4RtrR95/sheHCivOE/AwhUpcpTB0ODPsgrZb0Qxun7UxIhFg?= =?us-ascii?Q?MFHmsRp6neWRkcutWpjRjMmafWJH4BzvTTfUIxoHsXvRHSORJMNA77VHdS63?= =?us-ascii?Q?gpcIKgLuHE6yIYNCAdMqUHmHObXKjO/yL8feOJW3OkpK55GutOkCT6zQ02NI?= =?us-ascii?Q?S/Vnt4iruZ+Cxunl+qO3Uf6Fi4Cnjzu9RWZsEAZUrQSVZ2EHpFRRqnW4I8iP?= =?us-ascii?Q?Mk5t0vV7qNKDSP5Ow//5LX0DsNt1GhRkdL3w4Ksp3cZf0iWPPr0EJHEQN6yd?= =?us-ascii?Q?iqCv4NJ3/p+ighxC0qkeSWadDwXlHgpGdZWUnpxF7XKEVs0tGQUluVP1aLhe?= =?us-ascii?Q?ilOG0i5xQl+8uF7HsN9+lCl7FNJ0MekTttZPwzlRZk1OQ3PNH4uIG61KVEMo?= =?us-ascii?Q?9B4eXnOZnzFeXSVVlRgy0iDDHRer7u2YmD7cAc8DEz2UDN65G4gphQEQpMsK?= =?us-ascii?Q?WYqgjE15mF5Fs27ZFz+aBuQu0Jvu2BhmNIUPuyxtjAH8cXjFPk+kCPPWRZgJ?= =?us-ascii?Q?xcrwSbWMNqqFCZdnxId/nGD58X09fVkRITEYJyhVrq1+X6BmMZ8QNEigTEPH?= =?us-ascii?Q?AQiwOObXxYC1pyYQP9vEv5upC4GTi4EA5zLaTWWiHOzMsBVhhVIfTnRFfvM5?= =?us-ascii?Q?LpZLxgVGnYX//34bi8fbT12FKLEkxXtp2bEaSXdXIVqKfHljK508BzWn8IRC?= =?us-ascii?Q?d6TRTK2ImqQYvIag51tf8VRa1552j2wZRfLEy7vJQuWqn+teiE5DuaDQiJpl?= =?us-ascii?Q?kdzSy7oUQPJdVp3wnzlCv3UYrQrVyQosR4sV7pGTMyWtVqbsrEqRDDSu4vuF?= =?us-ascii?Q?V02xKoYTFopx5SFkzFK+E8Zz2RqQPsPuwNAuNSgcJnNhu7R7r2WH4TLk3F1j?= =?us-ascii?Q?07uZNvVN/+C4Z/XiYchMbGAXmZNR4tc9BymVVjRZi+kGqRxVYc4VCK4h8UvP?= =?us-ascii?Q?g/06kEkkp8/7uI8VHphPZmXyo4qPvjDygUYGwwFNIWKNv+RtUkHP3SI032vf?= =?us-ascii?Q?hIxqkKbqFduzaOsBEn//kLhGEVRycsM2lnjgpsnHcDJuSXjTtWOLtXAQcjSK?= =?us-ascii?Q?9b/F5N4kUKZ/RRcg6JQ/3LbY/RxGVWXaQoeLdz6b2kg42Xifs+ZpZLbNsssL?= =?us-ascii?Q?/zcD4ezg2pUJHf3GhfO6+eSlYFEOeACE5gNpv4JMIdxiOuigpEBcjCbMv4SU?= =?us-ascii?Q?Iyq+0Ow9FAMBOp3UIgiwZ5xZRVEw4jhedDwPwp7OyqWMkkWMEb5s/JHFVWUC?= =?us-ascii?Q?Jxkt+PKN7QZhBNyWRvMK65xcuzigq+uEoQ28NnvWz656yYOD0/IXwU2gv84H?= =?us-ascii?Q?ohMrdHTALaVQgNALdnxYk1YynUKw00tjF/HXAsoIHqEGox78dv1c0/ui3tP0?= =?us-ascii?Q?EfUPmKmepDVwAOdKShJqDZhxgZuZxOqX3t+G0W2Xx+wnsjxPXDazp3OCeod9?= =?us-ascii?Q?rs7YItpgJ1A=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR04MB9910.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gFxHZmaKB5nhhCIedf9vEeRpzwT55V8zQ5b0g3Meb22bbsNIf/UCUrxHJtYb?= =?us-ascii?Q?lTP2DlnavX9XrhvVebYUEvMjIvUq8FN7WCsI0u/lQ19qooENZP3ooiVMyTo2?= =?us-ascii?Q?3rrcMTpvbcMXFOgLxjVW0t8JUs/g2OpgroNq6XC9Uf4P+lth/VVAjW+kBPVl?= =?us-ascii?Q?cZdLxgiJbh2RI0fIAeQhBtMdk4wy5CtNCwye7fevMVo7f1kfRWNEZ+QvE85K?= =?us-ascii?Q?z10WRefZ273NW+EPkikrThvOL5v3R5euKNIFREPrT1ojilhnpRKFd24WJFuy?= =?us-ascii?Q?zjmW/Wq4QXsmn/A5T19mmepGaQsgJUdzFYs+rq7n9nqNmrQWGSMTSq73txqj?= =?us-ascii?Q?Bzs7qVVkjfK11YzaVpPZ8VwHeVeW8IGRnTyfY1DJ57RRtoLg21nUvY1EOmRv?= =?us-ascii?Q?bsfR2IuH1XnbWcL/Z/dff6n2vxx6fZVEw8WtSJrA+TEt+ErwyK86n7bDJaDv?= =?us-ascii?Q?26RqcOfoqvPoOCTB9jd/vy1UKxu7HFUTuT3Uu8SY1nVlHuAHiCkOFnlnEV3Q?= =?us-ascii?Q?GtlqnNyEJ1T8zv0CTYYkyJjVYsQ4gEAswl+rjTyNx0tcI5F8f0aQCK/g/RQ4?= =?us-ascii?Q?A4f7waPldKZ31rWp4uX81xUyfh9xl0c9y8R19Rq5T1AXaXMvSRFdQKwTFXqH?= =?us-ascii?Q?URynBA4ugBvQlTOXszHj1LmutWG5qvmYA6CP/yAP9RtcHElvdWWGkJXOtCbV?= =?us-ascii?Q?XXxO/gISRNSsrSZMjQFVv3Hm7yGKYbng99bNFctWiniD7DifEAShKwr2JtB4?= =?us-ascii?Q?FL97nh3yru9yx2BgdCErG3JEsYNmNtsJAcv081TLY0hY89e3M9YEW9PKJYMC?= =?us-ascii?Q?+XHQowqzTkbB3kWGu6FxygKZUS/6k9SFYOU2xwmOZvDvmCExphJ4tRbnbnkG?= =?us-ascii?Q?h+tHhfX4Yy7tUfD0LN1fe4heZIWtX+wtcN0hjuLEztWENux7uNg4hlyMKQjO?= =?us-ascii?Q?9o0tDRot6ERA0vrcqbqs2JaVW2COMhWkjC2rZtp8pfQR1f95tbJto2GkT/K/?= =?us-ascii?Q?huQv3nqQ45wFzM5ZBP95+YQSQ3JEQQXbGb62JbMxahL+pwwM+Ws2+v7TwuL8?= =?us-ascii?Q?nGcuYY6FmxY4/1+T6kwMr5eRU2Q1JeqjtDzzKpEGPjEiURiglKNBISN2vNFd?= =?us-ascii?Q?T/88Pg17+hQT4jke+HUNkzJuaFA38S7nz5UB/EDqdzeXqT6M6ofuYD/oRZpX?= =?us-ascii?Q?v8aCOt5ynPof0K1B6vxDearPsd9z6dUgFU5/C5UlCqpsKakZbOxnS6J4UTaG?= =?us-ascii?Q?auouy99IhlTQic7w25YuGM6zP718qOW76BH2aXoaPSWb/trIfuef66zEyZcL?= =?us-ascii?Q?3WVM8AeSM2mvOQWRb2frrIlKiwYz+9uh0tkJTQWEwChMzwIQ0zwPi5T8DuES?= =?us-ascii?Q?y07d2YjROxvyAlcbSYgH93IpzUZ55jGDQJHIKSdV1FYBdGY+wHvWp7L3klfA?= =?us-ascii?Q?8dvASoBHlHM4JvgygwrovF/eF46UjgahyrpVyX6ejNqruKqm8OYNDQW2ku8m?= =?us-ascii?Q?eTsIoiFbyrvFW4FRZTZPR5P6S+0cftxqLIh/dhGPyaqULIDbEiOkVfMAGMq3?= =?us-ascii?Q?wpb2cuNTfKExiEkolXhzjJW7knbZb/lRYHxVzvRR?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eed19c0b-7b4e-4ba7-e72e-08dd5175df6b X-MS-Exchange-CrossTenant-AuthSource: PAWPR04MB9910.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 06:14:46.1185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2z+0WQ+M/Mvo094PVPHUTjNQ7tMa0yJWYET8YR99BxO7BEgiVrtqGcopH3DfnpvHqL+4bM18boGNd0O8BkT18Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10047 Content-Type: text/plain; charset="utf-8" This patch corrects the command format used for downloading RF calibration data to the firmware. This patch is a split from the previous submission. Signed-off-by: Jeff Chen --- drivers/net/wireless/marvell/mwifiex/fw.h | 7 +++++++ drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 14 +++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wirele= ss/marvell/mwifiex/fw.h index 4a96281792cc..0c75a574a7ee 100644 --- a/drivers/net/wireless/marvell/mwifiex/fw.h +++ b/drivers/net/wireless/marvell/mwifiex/fw.h @@ -2352,6 +2352,12 @@ struct host_cmd_ds_add_station { u8 tlv[]; } __packed; =20 +struct host_cmd_ds_802_11_cfg_data { + __le16 action; + __le16 type; + __le16 data_len; +} __packed; + struct host_cmd_ds_command { __le16 command; __le16 size; @@ -2431,6 +2437,7 @@ struct host_cmd_ds_command { struct host_cmd_ds_pkt_aggr_ctrl pkt_aggr_ctrl; struct host_cmd_ds_sta_configure sta_cfg; struct host_cmd_ds_add_station sta_info; + struct host_cmd_ds_802_11_cfg_data cfg_data; } params; } __packed; =20 diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/w= ireless/marvell/mwifiex/sta_cmd.c index e2800a831c8e..6e7b2b5c7dc5 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c @@ -1500,18 +1500,19 @@ int mwifiex_dnld_dt_cfgdata(struct mwifiex_private = *priv, =20 /* This function prepares command of set_cfg_data. */ static int mwifiex_cmd_cfg_data(struct mwifiex_private *priv, - struct host_cmd_ds_command *cmd, void *data_buf) + struct host_cmd_ds_command *cmd, void *data_buf, u16 cmd_action) { struct mwifiex_adapter *adapter =3D priv->adapter; struct property *prop =3D data_buf; u32 len; u8 *data =3D (u8 *)cmd + S_DS_GEN; int ret; + struct host_cmd_ds_802_11_cfg_data *pcfg_data =3D &cmd->params.cfg_data; =20 if (prop) { len =3D prop->length; ret =3D of_property_read_u8_array(adapter->dt_node, prop->name, - data, len); + data + sizeof(*pcfg_data), len); if (ret) return ret; mwifiex_dbg(adapter, INFO, @@ -1519,15 +1520,18 @@ static int mwifiex_cmd_cfg_data(struct mwifiex_priv= ate *priv, prop->name); } else if (adapter->cal_data->data && adapter->cal_data->size > 0) { len =3D mwifiex_parse_cal_cfg((u8 *)adapter->cal_data->data, - adapter->cal_data->size, data); + adapter->cal_data->size, data + sizeof(*pcfg_data)); mwifiex_dbg(adapter, INFO, "download cfg_data from config file\n"); } else { return -1; } =20 + pcfg_data->action =3D cpu_to_le16(cmd_action); + pcfg_data->type =3D cpu_to_le16(2); + pcfg_data->data_len =3D cpu_to_le16(len); cmd->command =3D cpu_to_le16(HostCmd_CMD_CFG_DATA); - cmd->size =3D cpu_to_le16(S_DS_GEN + len); + cmd->size =3D cpu_to_le16(S_DS_GEN + sizeof(*pcfg_data) + len); =20 return 0; } @@ -1949,7 +1953,7 @@ int mwifiex_sta_prepare_cmd(struct mwifiex_private *p= riv, uint16_t cmd_no, ret =3D mwifiex_cmd_get_hw_spec(priv, cmd_ptr); break; case HostCmd_CMD_CFG_DATA: - ret =3D mwifiex_cmd_cfg_data(priv, cmd_ptr, data_buf); + ret =3D mwifiex_cmd_cfg_data(priv, cmd_ptr, data_buf, cmd_action); break; case HostCmd_CMD_MAC_CONTROL: ret =3D mwifiex_cmd_mac_control(priv, cmd_ptr, cmd_action, --=20 2.34.1 From nobody Thu Dec 18 16:16:08 2025 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F6A1E47A8; Thu, 20 Feb 2025 06:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740032096; cv=fail; b=KjhTmajbklCCgE0Nj1VqgS5BZCCSEoOJ/EW7TJXqeBs7UfOYZc1DobSR8lvaR0alKLEPkFS5+qDxhFl3YibTp0bilYReBrBcr/GnLefz/LthnS8GBbXi2CLr1j+Pq8QEclmeibnQamL2j2lsp3mu13FZH6YkQ53uWEHpURvltkM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740032096; c=relaxed/simple; bh=zeigNLkO7heE5VSHAVgElaDOcjJjlgNUHNAEaVrsTog=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=WGSuswgm9qHuvV73yE4DVKUc/755KRUxnCwYOQm61Bt9vgI34CATSUZ51/sM1KyovIxeJ0BuODlGCqDl5SExpn7yO87Vo7IeVjniS/W3Dxp6ZFI8mPNx2m5m0QyCwJmqHLnn4/SF6G7f7CXQ2C7UB+smlBi7f/GoAlH/47xfOJY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Jz/b5MpZ; arc=fail smtp.client-ip=40.107.21.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Jz/b5MpZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QQQX2XXQMG/+jSgZ+T6CrcpyejFC3z4KmBwBGC0c5nSAYCO/7x9+swpqUEbZMoo8pFzufttndcQjU1cUdREho4c+YfyPE55LLhtg0CkxE7AwRSTuhUdP82LMWYQ2tYgz5W+Wnb6ZqwA0cDbkK6Uz0Ahv4HT27IxZ4BMXGkXZdW3/89alTzdhzKMR1DY1b7ufRIOBpSjBAJ9d4XXNPfetR0+nhILXdxjcphFyK0UNHEfO5hjWTLsbMLY2ipQtTWvdMkbtuzUsdVKWYU0USE1BE2MX1sBBXmnLXAkjajlI7NaGZxR1n6EYX74f8K3v8b00Kd6h6zPa3r5H9QjA05DBpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bf1qmo/M/ZFuhT6hUPg8ykpyOoOhth80j0MRwnrylPY=; b=PBBXKeu3vKF+XDotqCOuXrGhay3Teu3GQB+2gDSglvcRbA6K2L3Mw8QhTCWeGy4C+Xg+P4ikFf0YMXHUNtwSztOXNtcUcZHfGVjkYzYTH3ufHXeDxJxDo3FC27Id2Rit66CbaZoVz1dA8DUwjdOKD15QGGggL0HodXNReArSuqyQZmwCX/dT1EMpK1t0FjToVDygMynaiJJ10U8kbY3jqXQZrPDYlxI6x3SfeqYHrfkRBt3nKe9A8Y0Z99EvQ/guTLDftfr7nnBX7DHBA9YsiBORNYHxmscVw4PhHcFd7r+7Md75XukI4Zb30ESyGGGCiOtkomrcxDPhrlwAhdOG6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bf1qmo/M/ZFuhT6hUPg8ykpyOoOhth80j0MRwnrylPY=; b=Jz/b5MpZAnLxqXH+ZomH4BeVKFq+XB7DmqRfMMnkRocICG4MUrtzwGn8xq8cySRoHFPkF7k0QISnfvaOOl3eVtfqKhjE1jXcDCf/khoHZp5d9sgQ51Y6hhdo29iJ2bk5w1pRyzLJQ9+44A6iRE9CpwY3GIRYNKOem07Dl05YUW2uORh3UKHwB3B4KUqtRanFF7xIR2rfWfa8gAhhwu7udqZZiehz2UkKpYIYNS3g2vXfWpJ9hukuv60JF0CO0edhzPQGLFsCuWZLwFUTE3aNlOrlyaS7oTxhK+2D16hGYre8IHGvR/0KnXlsLCOg/PmQ+XmVFEDnYRL7XAw3iCRXnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAWPR04MB9910.eurprd04.prod.outlook.com (2603:10a6:102:380::7) by GVXPR04MB10047.eurprd04.prod.outlook.com (2603:10a6:150:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Thu, 20 Feb 2025 06:14:52 +0000 Received: from PAWPR04MB9910.eurprd04.prod.outlook.com ([fe80::24b9:b9fd:bcc0:4ee6]) by PAWPR04MB9910.eurprd04.prod.outlook.com ([fe80::24b9:b9fd:bcc0:4ee6%5]) with mapi id 15.20.8445.017; Thu, 20 Feb 2025 06:14:52 +0000 From: Jeff Chen To: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, johannes@sipsolutions.net, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com, s.hauer@pengutronix.de, Jeff Chen Subject: [PATCH v3 2/2] wifi: mwifiex: Part B of resolving the failure in downloading calibration data. Date: Thu, 20 Feb 2025 14:11:43 +0800 Message-Id: <20250220061143.1417420-3-jeff.chen_1@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250220061143.1417420-1-jeff.chen_1@nxp.com> References: <20250205012843.758714-1-jeff.chen_1@nxp.com> <20250220061143.1417420-1-jeff.chen_1@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P192CA0008.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::6) To PAWPR04MB9910.eurprd04.prod.outlook.com (2603:10a6:102:380::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAWPR04MB9910:EE_|GVXPR04MB10047:EE_ X-MS-Office365-Filtering-Correlation-Id: 22c0ce23-26ea-4c6b-1207-08dd5175e323 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XFTpAGHH9nAJIoP2+Djwl49iU0FXbENlR35D/vK/6NzfMi2HvJwSfifJAMfs?= =?us-ascii?Q?3C9h9NgxjXTj1CL3d3MDHbEEhpkU4+o5TEP4ddRo/Nq1CR38YqF5OvqiBego?= =?us-ascii?Q?voH7y7zWsLmKet/GYQpjwNWnwvtUH/2TdVMwqSYFtKv1iaVkrthbVmLyxdF0?= =?us-ascii?Q?myqlQSDhE9zWrHPk32UjZJUeMtR5MtwZS90hRJcohInNlNB4NBawlrisfhvP?= =?us-ascii?Q?1J+ee5DUGqgbb0igQZZq0gAeZ/sfu1aOxlb+N0iVR7bcqoV4fHAlPvq+Elca?= =?us-ascii?Q?I0AfF3a6FssbPBKvcMUvjQfJrcqm1o9uceIJyfdXkMAKQH01rHrEKqUX9LcH?= =?us-ascii?Q?xJqYXYv7/JURvwOOG24QqldSSGzM8Ah3Zu83Y627BgEBzvhAEAxsmjOwwrdH?= =?us-ascii?Q?3dCmaISe7qyM2vYo2e29shkpXtuJqSp357ND85rHK75NA49pPO6NN7I/ykxY?= =?us-ascii?Q?/VjFQ9wihfwg6Zh/YR81Bc14ES5F8+vMcPgqhmGj+xoPCdAkv0QSbvW3vQty?= =?us-ascii?Q?rO+vgT+DWHv62bKAyPZjumWk0cTEu0kN+CuiGTPXtSHaynSC9j8qF4pcKCl4?= =?us-ascii?Q?mxUJ5jSHevLmIjuSqhjKj0b88+1SxLpxCRUTHAW8B0ugrQErGse8nEY1h87c?= =?us-ascii?Q?/KaTjV9Xh/2NOKR/LIcD3ePX154/LKUMfa9JTk/TYtvz6VcuBiLODzqD6CIY?= =?us-ascii?Q?3IrAC03dD4qBRVm+EFvl4NIaBLQY6ZtvAMT4BFmTf7gIHj7MQtGSQLr6t0BB?= =?us-ascii?Q?nGYwDAds/ZvAN9MnSH7Q4QGPu8buJ2KT7MpAiYb5HJBY98DcIDbZzl2I/WYn?= =?us-ascii?Q?87XHm4mL5X1k1xwoaFzvngxtb8Xq1pR6AgMNSerlrBjprSURwholWNPk0077?= =?us-ascii?Q?FA5prs/MsfkatdjIY5DyXu4AiUMYBq11M0TNFvbdMWPyv8F20+33anpmTOVf?= =?us-ascii?Q?joKqOI12Z4FSVBuJs5JbiXNR7XCOGUTezIhSgcCjmUlIzIz4wzph2Metzlo6?= =?us-ascii?Q?FVj0FOZoHFq15/z/ry6tUc/+AVDfPX4NR8yDTV0fHlRWgQbY1c+d3TPxxOo6?= =?us-ascii?Q?cBZs3hm7WX8uscTwyJRInee86/4aH+k2sbyikWChfwQn+KPSeHdILDKQjCrr?= =?us-ascii?Q?qGpAGVcilijqrf32XcmyE2L+a9PT3OGJ8N81XVyOSbWshBYv1XDsD1DXqi8B?= =?us-ascii?Q?BwuPuKvHYK5ng+LPJUxNxPN7IiyDGsAWUBUhnuq+emg9XtygX96PhO1LfsVn?= =?us-ascii?Q?d/DOlOaH3FufAz5MFHvaKrq9vjwQbL8JAbfcj84UyW0sJYj3hVU6NAVf7kfd?= =?us-ascii?Q?j/k3zpfVAHwxj6rDABgnb2m9Fz201tH90EYc1FtHhWzDMunb8Aa3ke6wULM2?= =?us-ascii?Q?lVCbaNZoKDAHj4IQ+a1hP1ssXWl/xSfrKHXH/g71p4hHL6TUHT0WV+g8VrUx?= =?us-ascii?Q?HigC4vrZVP+svSJNtxLPsBZ3IRNg0PTP?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR04MB9910.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1xOfm4X9kmdvPY4ZK1BO/B1hwxkEBkF+v9SqCWqDDMDiAD66OwDNVgWW3fhC?= =?us-ascii?Q?bQ3MyRD12gEbbB9B4TFnAm9DKpIv0HjoqzJ/iDQD3t2WOLqXKSSVar8EEnVz?= =?us-ascii?Q?877FY4sfeGfyeimboMs7WbJTCDH70r7X4KWDP1reZ7V8jfUYfP1OoMJcCO4R?= =?us-ascii?Q?H8NKAKybXDhuwyLKc38bi4I7CS00YSJR/sBySB4Fv+R6Vo4pzicr7uPG+8FP?= =?us-ascii?Q?aGthSus8sETP2xwr96IGEIJ7mLX2OFzyZfvgHm6ak1iUIBiTyMfqTfiz9kG5?= =?us-ascii?Q?BtF3NWKIg0yYLwfg+l7kxnyJNpE1B8ddVihldmtP6F+J26v3cScWsZu3jr+0?= =?us-ascii?Q?pqo6K4YOZx52UnhuuF7TDn4fAMq6Lp9B+jUXpRlt2wR8o/3TVau2AQMK3C5d?= =?us-ascii?Q?CawBzbQLCLFdOA25b67cKtMHl1MOUonKpU0+sEO6qF01aIaZ5Fl/sabFt5I+?= =?us-ascii?Q?AMwEzFZlQ3x+dQcxFLyhfmRrhnRnj2yzYBS6dPDjkEODUUoIGgkdJ9zybbjc?= =?us-ascii?Q?BvJgmpfwQ29nPUe/gVnpsuquScUm90w4O6ZXscAYWj5WRMzlqS+vwwToZiei?= =?us-ascii?Q?Ytm+OZee7OEU9BMsnqJlpWX1H8yK3f8hJZiNcaKeUoi3v5mOONo2FNJM4H1Y?= =?us-ascii?Q?5lpbbJNmVQHuEvPYP14b42oDuia19V0aqkTBWowCD33g/sjzK9dcj2jg2skl?= =?us-ascii?Q?Z/T2iRPWs18simx6Mmw4ipwzsoui8JenfrimpCU0iJ3eGPcIfgM+Ifm0W57Q?= =?us-ascii?Q?IDN0MKYT+DeNVjH7+Q6zcjSGE7IQZiOFHU5utUfJuGTh7LIiIdhTYM2Mo5CO?= =?us-ascii?Q?FkCXH9XLngv9vO9fD3Z9yPU6dcv3kfJ203o88FNQ8bwXVNsxSldGo0klE3vQ?= =?us-ascii?Q?Z0n70+dTmUunD4cR6UGDq6qpedJi9xUpFNmH9DV2cM9bcw3B7iOnzfgKFVdI?= =?us-ascii?Q?I1/TQDcMk8ejwJDOzAwBZ9mt7h+KzErkrsJVx+kkNaN1DQMn44g/QnT1E/XR?= =?us-ascii?Q?Kb9wM9ZdcTWR46bPCeiggKHYvhWH3CczY/qkyin6sHk3X4FLC8SQV5VPRQII?= =?us-ascii?Q?WcELqshWXs98PEn6uDuA32pxw1J8dxCFQgtpqcYO4SbZTjcXG1Rc8Zr3BOIh?= =?us-ascii?Q?arkM+Gb8PMQJXl7Gev+yjpnUn8SRNcYk4WEX7tkT7zujLoIjlPK5Z9Z6DEUR?= =?us-ascii?Q?4G61felxNEyTRWuFKvQabRcuLYOd7jHqWFEVM4iZOUk8UKROl1CNFjYEfF5R?= =?us-ascii?Q?O6iHMxpkNHezDBkUNjF95Ug83Y20FcUXwHPDMwMUzfpP4r8zAMXGlBNlNxjK?= =?us-ascii?Q?ZqRBSRobsGKX9Mj8WFA62GdtLmBBcuZDmeRvQ5PIknhprJq6VVCGJYJFNO9v?= =?us-ascii?Q?dgYYzuXyAWNIkyS92WMq6ZIhRk7oW6tWHulGAKVs+yIp/szNfBF5yb+pN3c0?= =?us-ascii?Q?OsOasOcmxStoexp1F6JVmUOjYA50vL9vBQILHnVhaVPXAnEEqk7VH8ARQJrB?= =?us-ascii?Q?h40JFgio799GAV8CCKrele5uodvWSWTjpZeg8+w+BnBOKgLXY1duHoxrlp3T?= =?us-ascii?Q?BW2hUX7Hb4KKNwuu42588UKhRb86zfsdLwJJ8fSS?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22c0ce23-26ea-4c6b-1207-08dd5175e323 X-MS-Exchange-CrossTenant-AuthSource: PAWPR04MB9910.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 06:14:52.3458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0bQ2PlVD1QJpSk29+pBXNHGeQZdf3zNJlQyoch21VKF/ZIX7xzJL6rDlJq734cgDquR8xrJkb74cuXUjzJa9tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10047 Content-Type: text/plain; charset="utf-8" This patch resolves an issue where calibration data was being released before the download process. Without this fix, the calibration data would not be downloaded at all. This patch is a split from the previous submission. Signed-off-by: Jeff Chen --- drivers/net/wireless/marvell/mwifiex/main.c | 4 ---- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wire= less/marvell/mwifiex/main.c index 45eecb5f643b..b07cb302a00c 100644 --- a/drivers/net/wireless/marvell/mwifiex/main.c +++ b/drivers/net/wireless/marvell/mwifiex/main.c @@ -691,10 +691,6 @@ static int _mwifiex_fw_dpc(const struct firmware *firm= ware, void *context) =20 init_failed =3D true; done: - if (adapter->cal_data) { - release_firmware(adapter->cal_data); - adapter->cal_data =3D NULL; - } if (adapter->firmware) { release_firmware(adapter->firmware); adapter->firmware =3D NULL; diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/w= ireless/marvell/mwifiex/sta_cmd.c index 6e7b2b5c7dc5..2ba5269b0f3a 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c @@ -2297,9 +2297,13 @@ int mwifiex_sta_init_cmd(struct mwifiex_private *pri= v, u8 first_sta, bool init) "marvell,caldata"); } =20 - if (adapter->cal_data) + if (adapter->cal_data) { mwifiex_send_cmd(priv, HostCmd_CMD_CFG_DATA, HostCmd_ACT_GEN_SET, 0, NULL, true); + release_firmware(adapter->cal_data); + adapter->cal_data =3D NULL; + } + =20 /* Read MAC address from HW */ ret =3D mwifiex_send_cmd(priv, HostCmd_CMD_GET_HW_SPEC, --=20 2.34.1