From nobody Tue Dec 16 11:09:24 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 427D01DE3A7 for ; Thu, 20 Feb 2025 15:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063824; cv=none; b=dxaDRsjAIyLbsoeopKQhUsnRhQO12v2jfqIwdCJOAtw+mydM53CHFFOv/okczYSuLllGIsJIFMioe3kJ5kl1ZHhfilF6eV0q58G1dUsqxKZiCzFy47Sao8U03jsIbNoEGKpHrQunwLxA34/kgpkuKSHd9VNCERHnpe2Z14VFLSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063824; c=relaxed/simple; bh=mvZIKYgOX6EYSfhAM5B9z6KMXjLDBBxNXjsjITMmL9I=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NUdpqcr4u5FU8R3eDLdDPhZoyb3uLRbU53Xr3eQ9foBp/5wF/kYzDJwrDz2339WzPMiai77+OS3XAvDF+EBrbQuUzL6jCItT6ISQP5gwsXmjFNaLZxC8WGM7gSQnEEB9XEn3sbCI6TaW7z+D2xZ5S1ZrsWwC9w9P5R8Kgzh/qs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LPU/PEhm; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LPU/PEhm" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-439a5c4dfb2so4157465e9.1 for ; Thu, 20 Feb 2025 07:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063820; x=1740668620; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=LPU/PEhm7n/FfaG2a39KA3/5WzgsyhiSvazMWkSojX9lSIsvjJ4YmS0YJFDEZP6KJg N3+1nYJXFzREtMr7HKJ1jcP/gsz0QJGIeZZkzUMtCsbVMildF1VEiENHvFyM+G1FlQLk xXbnx1QimeO1oTfvoJim5UvNE+9O40H+7s2A6SYX8LtI9Cum4VsLpYquzHcRJw3lptaF jzOVSoRCZN//IGccPHR4NXaYozJIaM2xKlaCBK2+PsfHr6oZaj73i+lz0txWW7/2eBPR vZCCNyybLGB+jKrfZ+rQDw1B+qa0/kfExAHQcAqEL203B3zWx9YQqvSargv/kaLkiz+i T0Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063820; x=1740668620; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=Hi3GxyPyCINP7kZWp9OL+mdX+ixuD4c3tH4tKiUibeVdaAQCkt+NdNp3COnk3wbk0k Uh+WNfLh5nvhpCfjXLinU+xliEGV2RgF5OJ4ocdkEQw3oMmTytncC93gKjNEsRjWKJ9G L1LxBicrsgcYksFO/3B+6ApsJiTq4ngqxwdpOIM69MvsPWiyZEMf+EJxd/eyc4U11236 KP2+U2dVHNVutz+XtmI1LcbTNRwQaoJNUk5JIqTKMwHyuWIKSJv7LycZdhJH+wQQ8Qzs ZVHpwXbizujCzqjrpViorHDweoMaVLrcqdjuep5b8sV2PyfnkoybmNCJyyjrEdC+OKgo s9uQ== X-Forwarded-Encrypted: i=1; AJvYcCWKM3AU5LmtDSbAL8hki71uabhCAty4mLenty8PXPRsLHn6JWaCcbJ1jWVFbHSX5oLQ2z2UlTFYkANLsi0=@vger.kernel.org X-Gm-Message-State: AOJu0YxcoklyuWVevo5BBSpAD3lWYg5gSKcaC6/rPqtBXZ4yB1eWG0qr e7V021msxPYWpe+GeRAPkDWiYuDepmCr8Xia+9VdtTPin0nUVHnsGdnW4VG1M9e85GaCHB4ceVG juBjZGiEaqQ== X-Google-Smtp-Source: AGHT+IFOliTpraR15CWTkacKeBSUqf8FbRBDdkQpsEi0GIcWjSpwR0EViFfPxP8qN/+qIjSryFofPr/PtV4xXg== X-Received: from wmbhc12.prod.google.com ([2002:a05:600c:870c:b0:439:98ca:e39d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b26:b0:439:31e0:d9a5 with SMTP id 5b1f17b1804b1-43999dd1e1cmr69699445e9.22.1740063820541; Thu, 20 Feb 2025 07:03:40 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:13 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-1-9bbf57d64463@google.com> Subject: [PATCH 1/6] selftests/mm: Report errno when things fail From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 32 +++++++++++++++------------= ---- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/self= tests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..46a2139b3a646f6c050eb031a77= 0f615be76c433 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) int ret; =20 if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%d)\n", errno); return; } =20 if (fallocate(fd, 0, 0, size)) { if (size =3D=3D pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%d)\n", errno); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem =3D=3D MAP_FAILED) { if (size =3D=3D pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%d)\n", errno); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) */ ret =3D mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%d)\n", errno); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,18 @@ static void do_test(int fd, size_t size, enum test_ty= pe type, bool shared) args.flags |=3D rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret =3D ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno =3D=3D EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno =3D=3D EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%d)\n", errno); break; } =20 if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%d)\n", errno); =20 /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +202,7 @@ static void do_test(int fd, size_t size, enum test_type= type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret =3D io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%d)\n", errno); break; } /* @@ -215,13 +215,13 @@ static void do_test(int fd, size_t size, enum test_ty= pe type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno =3D=3D ENOSPC || errno =3D=3D EOPNOTSUPP || errno =3D=3D EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%d)\n", errno); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%d)\n", errn= o); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +249,7 @@ static void run_with_memfd(test_fn fn, const char *desc) =20 fd =3D memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%d)\n", errno); return; } =20 @@ -266,13 +266,13 @@ static void run_with_tmpfile(test_fn fn, const char *= desc) =20 file =3D tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%d)\n", errno); return; } =20 fd =3D fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%d)\n", errno); goto close; } =20 @@ -290,12 +290,12 @@ static void run_with_local_tmpfile(test_fn fn, const = char *desc) =20 fd =3D mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%d)\n", errno); return; } =20 if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%d)\n", errno); goto close; } =20 @@ -317,7 +317,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const ch= ar *desc, =20 fd =3D memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%d)\n", errno); return; } =20 --=20 2.48.1.601.g30ceb7b040-goog From nobody Tue Dec 16 11:09:24 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689761FF5F6 for ; Thu, 20 Feb 2025 15:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063826; cv=none; b=YPN6ybifgt+BK5n7GvMRAVYVlYFyFvj+zjORtazpnEJfFb4fhng8S1KoY/CszfQazDJUoBLx5hPPN0gTqTJVhfnNn+LfOf7bOry+BygwHR6XnNVNm4XOY7S+crztTfRWo4f+WT4/r2JFaplemWPZXpk8skgzVE/+cspX28y6lGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063826; c=relaxed/simple; bh=Ilk6+5tZclI1F7dj4D5Y8eYPtM9YM7Dc/fjaV8j1+O8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Iw5VAnY02addK4f1rOVwR10iC/A3WQmWjn/XAPaaJDIIahheH8CWiwCh08j9GLmrBA7GJOGhmA05vUfufDfoR909ipTaZnpHVElNICkroxiPM1mnn/+lMj1UMwECaN02obPY39Hy2Bnr15SQoi0rcwxtHP+Bnba3rYMlFOrcExc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OCjwY5vX; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OCjwY5vX" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-439a5c4dfb2so4158625e9.1 for ; Thu, 20 Feb 2025 07:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063823; x=1740668623; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=OCjwY5vXJ5IiNskY7194N8VukxN38ZP9SQkZ0aCCPWWOjjrFjDBZq2N6NeX/rV+Fyz 4HjM7oJD/nLmAJDGMGNVD+A4sCa0LN6Z3ConMghkgNHAhKe59DD1tiz9N1kR/bXl6pAT yxexElii3MaMJSFk2pBnPqijIRnwxDC0+eJ2gJeq9yuuI2gSwknv3L+0zejI4uKlHoNO VMEXAwcJ+QhwE01G9RcBgwHT5qelrTDSfS1ku9OVqqwoxZIIFn0Cg+MCJgPP6TFaDSR1 Q/M97tSm6VOJt2KXibC5MSosSuhkGCBRPiCdQdT5XJu1/aUyrSM5dgWD7fQ8bd0qN3HA ++uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063823; x=1740668623; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=qEMxcXLiL6fwZZ5cCA2r9BQbM/HZJEJETTb45bLD6f1B+g7W1y/fmNyq2CEZQiTC9+ CjVfSacQQ7qZ+kQ0Rb7wu3TWK0+R374XDwk2v/xotHgzn7KqHYZ1pY7+TQRau/npT4G/ EwUxdIQ2qb1K5OFw96KspC+/8zeN/Qt/RUHksOTfxsMWIUxOiiG1qFcJvr4AqKRYInzG gn0XWj71BH/mE7TcN0VbLvJSO01/aaWWSSoW+9vOWAw0++4ohY1Kq2TIA5Dgl3k1ZMrX Wy6Voa+wOTYwKJQk9/3v9uTxxr5AWQxqbKbirQOYlfw8C164VAZly/yYSBDhBqrdoJZD FS/A== X-Forwarded-Encrypted: i=1; AJvYcCWQBhSbN3rk9tOhEBnsnyRndMJlB2eSDCy6zkZX3i6JxcGOi0Yh6XRWxQ3Gdd8LpTC4+UMNcg97KG4h7Mc=@vger.kernel.org X-Gm-Message-State: AOJu0YxRQvS2VU8ri54sP2g768tBPKH8C7mJKmwTCJw7yZdIBilsILvu X6uAa564o98NkgJwokUl4aTV77KmDKqR9nU75Zr/EEZ2f/i7LSpOO+Wgzgs5gsuFTgKEplnIT5b c8vltC0MNZQ== X-Google-Smtp-Source: AGHT+IGMX6sUMZFB6kcF1FLDPNy7JKgv9mVpVnHmQkgAM/qSvu5gFbpVA6vpmtah98EUgiAhA5SqxJEjJc185A== X-Received: from wmbg23.prod.google.com ([2002:a05:600c:a417:b0:439:95b9:9200]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:450b:b0:439:9225:2f50 with SMTP id 5b1f17b1804b1-43999db0139mr80231185e9.16.1740063822867; Thu, 20 Feb 2025 07:03:42 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:14 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-2-9bbf57d64463@google.com> Subject: [PATCH 2/6] selftests/mm: Fix assumption that sudo is present From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable If we are root, sudo isn't needed. If we are not root, we need sudo, so skip the test if it isn't present. We already do this for on-fault-limit, but this uses separate infrastructure since that is specifically for sudo-ing to the nobody user. Note this ptrace_skip configuration still fails if that file doesn't exist, but in that case the test is still fine, so this just prints an error but doesn't break anything. I suspect that's probably deliberate. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/self= tests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..9c963f50927ab2b10c3f942cedd= 087087d4d0def 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -89,6 +89,17 @@ RUN_ALL=3Dfalse RUN_DESTRUCTIVE=3Dfalse TAP_PREFIX=3D"# " =20 +# We can do stuff as root either if we are already root, or if sudo exists. +if [ "$(id -u)" =3D=3D 0 ]; then + HAVE_SUDO_ROOT=3Dtrue + SUDO_ROOT=3D +elif command -v sudo >/dev/null 2>&1; then + HAVE_SUDO_ROOT=3Dtrue + SUDO_ROOT=3Dsudo +else + HAVE_SUDO_ROOT=3Dfalse +fi + while getopts "aht:n" OPT; do case ${OPT} in "a") RUN_ALL=3Dtrue ;; @@ -384,10 +395,13 @@ CATEGORY=3D"madv_guard" run_test ./guard-pages # MADV_POPULATE_READ and MADV_POPULATE_WRITE tests CATEGORY=3D"madv_populate" run_test ./madv_populate =20 -if [ -x ./memfd_secret ] -then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix -CATEGORY=3D"memfd_secret" run_test ./memfd_secret +if [ -x ./memfd_secret ]; then + if $HAVE_SUDO_ROOT; then + (echo 0 | $SUDO_ROOT tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_= prefix + CATEGORY=3D"memfd_secret" run_test ./memfd_secret + else + echo "# SKIP ./memfd_secret" + fi fi =20 # KSM KSM_MERGE_TIME_HUGE_PAGES test with size of 100 --=20 2.48.1.601.g30ceb7b040-goog From nobody Tue Dec 16 11:09:24 2025 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E03F1FFC4B for ; Thu, 20 Feb 2025 15:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063828; cv=none; b=oHLPtmEKfssOadj7KtCzcWd3MfQzD80KII/auITy4xvgDlWsQYIc+S0MV7NASTjrI+55PGsuW1Et3iq/mcrehwHJwW20xcR6FGfU3KHPJtAcgDCOJLCB5JiHmH0C+LSax+70Llbzh9rlmNbJZ/GIsL5uOVGjMLh0nrHi0VPZQ/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063828; c=relaxed/simple; bh=9/O8tij2wirjK4B8U/5x/9fVjzo452E6485tV+fUgJM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=mRMBEno9wBDeoiS5Y7dzzBwvds79FSOAeGUW2XKn2iWxI43IbECiNc3JwJEf7UVFecVVdlfi6H6JVthMlp2zbekkSW9n/2ao4OeXg/QxTe9s8aJJMv82AA1/aFdCymEkGIBwzorKdV/xmqN/NBuKGcb/hysK1T8kbTVPEL5Jdtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Mczp2c5g; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Mczp2c5g" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-38f39352f1dso391014f8f.0 for ; Thu, 20 Feb 2025 07:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063825; x=1740668625; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Pfnk8jRZQRXvEGJgMo7kX45MXuk74eHKcJOVD1/hcv8=; b=Mczp2c5gq4YUVpPbkFVijBQFGvOx33gKT8cYp+BPPXb1kY90V90DJkvU0ftxA4ECy4 djgXKcMO/CtK7m5c4chK/Ri5hiZn2qRTLsfPxzN1UpeLosy5mDA9aaJ1QT//4/yYY/Gm HQgfaeMIo0vSjYSuCaHhMvCmICaxe+GtRrwUdUXO8ilF8wZa1VE3XsRbCqah5rr198IS TZTQyIDrqglfCYwZkRw2MrfwxfJxYdGAMWeNkvGJ6h7xDzciLGwxrAd/WDjz2WfhNVZR Zi6fz8Txt9USUJRU9hyFFza/DfJT1BflfjgDCNJMKMSZqhp+Ys8V+kOHxm/2P4/cmsFJ gUnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063825; x=1740668625; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pfnk8jRZQRXvEGJgMo7kX45MXuk74eHKcJOVD1/hcv8=; b=u7hFreBdFf0R1GxN2X0U5jnYSfD6axQ186JV7TbpOiyTcEm7Ca1G+x4gnw1S4BKkmr p3Ln3yOTEWXzbUTxXZmuyipDrpbIdKEYufEIflJtmDDJkiFlawu2CHbcVPY8IRmINMjD dbwgF/ZSPN5obhu7TehfZWlnaaL494kvbaTCV+/NVFvga/yns65pzTdsBvgndoZ3+TRM +lg3ms3gpxSONsOOfBJVOer8Wh0uC/Iq9c5OTDEU+PhjxUnyw4gee+A3z1GmtBpTTat5 +Mc2x2hfm75K3yIVzh5dPuQPjgXmlhtWYtLFCH7Io6MtVIf+R5/FV46aIHcBJp2uCMKp MVog== X-Forwarded-Encrypted: i=1; AJvYcCXpvdDyYTxkxEV3slU4+Kyny0AJuk0YSLqQy0ZF0c0RWGeIh1W4riCGeg00jz9/mYg1j0p5H0cCyQjSAGM=@vger.kernel.org X-Gm-Message-State: AOJu0YyoWTO6mzl5twKo1Dyl4jzMgM1+0Xhe6JA57gz8dSCN6PcqKfhT jzuKj79or2etproNPhpziDTw0HU6btfKIqItpwCybG58Pi/q9tv3NOkJqPANUicng3L6+kCAefd 9pIvI0ycDPg== X-Google-Smtp-Source: AGHT+IEZkoGqvABvYTvvXiRtV+S/mpL0J7HYkw5xP36OjVJpS+4DgqAiy+8j1WNNFXzaMG5CNB+I1Lj8O+cs0A== X-Received: from wrbfu21.prod.google.com ([2002:a05:6000:25f5:b0:38f:3cf0:aac7]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2c6:b0:38f:3344:361e with SMTP id ffacd0b85a97d-38f33f2e954mr20711279f8f.23.1740063824704; Thu, 20 Feb 2025 07:03:44 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:15 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-3-9bbf57d64463@google.com> Subject: [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..db5366b4766e5bfa2d1150d2f3c= 2d32469a6e28b 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ =20 - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno =3D=3D ENOENT) + ksft_exit_skip("failed to get avialable features (%d)\n", errno); =20 test_uffdio_wp =3D test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); --=20 2.48.1.601.g30ceb7b040-goog From nobody Tue Dec 16 11:09:24 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416A9204849 for ; Thu, 20 Feb 2025 15:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063830; cv=none; b=CQ3dTb59kpZo11WIGQeFK17YzmsnpopMTcfizN7DVYeKsSvidUIpBOV2bOvqZc0uk9PiHPwIL7WqQhay5/4/5Vbo0ehLGvOL5xdDlpP0f100Chvrmu5kh9AhMJlCsLfYJmqPQTWRmkDgiIjzPvH5GAUXq1Wh0h3FGA7KmwIF0VY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063830; c=relaxed/simple; bh=Se/GydgHH9nLLIGfdGGZR9s2IiE5I/RUbIaLvfmjrag=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Pis3jzEjofF/354ZXrR/REJ1aX9YwGk2tyFkMaOEO4wlFHw1d1IRXf4U7JCM1mF0ylpU0A0Xkqzt60CaVHcxm7bOj1fe2kYAhHoBwXgf5yppHh3Tt3jfeqyIjaSu42vonQJ/eMhroMPcIe5bxSUoMZogisWJFOKgdj9rtdfWXZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qz2lb2jc; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qz2lb2jc" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-438e4e9a53fso7711175e9.1 for ; Thu, 20 Feb 2025 07:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063826; x=1740668626; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=qz2lb2jcxfwkhdfoOfo9B878dvkifMzWIFPKKRGP8cmDCdnz8WN1DSrdSwM8MEdzXt 4CTF+SxaF7CpeMY9yolDSYEfH2TY5H0s1QoKk1+roTraYawOhkddRlsmQhYehNfnf0x7 0pAq/Zi3ltCMA0W+WecLmyQQIjcXIKHY/5cm5Gj94SWVIf+mjIdX7y7+vvWcYlnnT2pu gs0w6jdtoU4lvrMrVF4AKHYlrNfLYcStyZM5RnnsAp9D1DLNyPhQ9Vy0s1oGlFR/Vlzr l7gdmCE0sKphXNOQXnAQp/E11WLP2/OXfn41kt2Tgaj3AsXQT38wJ9+vebM/IkPEMlQd MRkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063826; x=1740668626; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=h/PxDEI1q4nO6z8IHFSSIt+VpoehEke8fNjQzTn+oHno6jXSQUi2G08m4y9rlCPSHy WoBdBZCCIDRkqSdP6PXZn/iw8Bq9HaYsFr5iWOUxMMjml4Ofm9zZ+OT0ZnnT+f9uDycz +w+YVnWbF92dAz8+bgP5cIqn+AufV2geCrj92awICmrlLHUh/EHvxG3Lmi51qkmkfn0J f83P0PFWDrHKPu2DD9quss/VBNMguspgxSCwzWHKzN5A0Ll/tM2xnHkbx0xeMADPfWnr MTcs6Jv/lvigvFI3DXNbfeBGnh0D3IzwMy4r/epFOzgIdpd+BmDh5XDY/LUfetpsT79b ZtbQ== X-Forwarded-Encrypted: i=1; AJvYcCUmzJTQ3Z+pBkT8co/LwjNj9K7UQ3R6IKyt/9HF2MOgPUuLRmbjiIwC42IXLPg0lrFYvmdJPx0rBWHdr3E=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl6z33TJg9vPth/D+8INInJUt+pAG+jpHOrNaPWWSAcTs6wMUX WXvAX4T7ytohESDqaz8p18TZyPoz+ejN9Omv4keXXn6fV4/RM781KyilNrMxrhRn3jYo29aOFyS 7c/ZK0MPNWw== X-Google-Smtp-Source: AGHT+IFsGg82gKlzl8tWzntDHJFghDx2t08uXQ7P5idCDRgaVqvqc920eCUSioT9wAdKGGY50Zw9lE7MF0GKww== X-Received: from wmbez7.prod.google.com ([2002:a05:600c:83c7:b0:439:67c6:5642]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:47a7:0:b0:38f:4b15:32fc with SMTP id ffacd0b85a97d-38f4b153521mr12347926f8f.8.1740063826684; Thu, 20 Feb 2025 07:03:46 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:16 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-4-9bbf57d64463@google.com> Subject: [PATCH 4/6] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/se= lftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd= 148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, = bool swapout, bool hugetlb =20 /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno =3D=3D ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { --=20 2.48.1.601.g30ceb7b040-goog From nobody Tue Dec 16 11:09:24 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 502ED204877 for ; Thu, 20 Feb 2025 15:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063832; cv=none; b=fu+UK6WacmBPXuDHaLTicHF6o/Mh7MUrMF/XsMGkXJHOkHw4lbZ/8yO4iIF8rwDKnGzMcRouFOWak1+EkQakuiYmFqMtK5rCyFeeZPAXTBBuxS4a7/MCH9J6CNvmApgyLoePlQ8hu63oAbfX6oqdYXz+Wtml3XoFrW4D5l03usk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063832; c=relaxed/simple; bh=6us0OPPk/bMiyXUbfdqsVWAztptDhX3dd4CerV72Gpc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=YfNOVX6yNyI0howwy42BxsAhLJX40I++Pj3SlSYqdjaAS8ro3MGsA1zT8gwPD45XUwKSgoDJY9a8FYOSGyELI/jEotoq+Gys/uimdQ7XfErKVTTKNkHpw16PF1pche7ORnzoYjog8WZsHzsB4pXqh4g4zAUB5pmKo0sBunw1vBc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ilp8yF2m; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ilp8yF2m" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4393ed818ccso6792755e9.3 for ; Thu, 20 Feb 2025 07:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063828; x=1740668628; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=n5anIIX08DH7I1Pe1I+Cw11KP1w7s/U6PELcC7zyacQ=; b=Ilp8yF2mhlguBz/pE42gDVU1Yv/8+JSRN4l1WY/AAnGP4Zvv9c6sVxXWZh7iTWc8tU BP8ZaZYjDnamyCYu4jDggFLG9NR3oCX8gGbubvw95jehcPWodq7by1FFqhP1OeZsc4Fk md20EeZ1XdzV/tIakH6kWPPFyzxkH81I2DVU3DLBYCHyP/XBDB4/yU/iWqsWGLDLbHHH RmuyZFXDSR5M5KAZudeNQ1uMhRaE0P3OulnLdIWCLRKW6ZrDvYDesGEtmkmdjK6fepad oMCtXnFQFeN3MDpCmuHtdYal4irDfMDWGx7/nIehKlFLlJ9I6/GqDI/KQ1JhQb+oHnz5 FpBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063828; x=1740668628; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n5anIIX08DH7I1Pe1I+Cw11KP1w7s/U6PELcC7zyacQ=; b=cT8QKN7G011/2hDe8KsnHvCQQGpcURaNd6hl4DkF87VwPqBtXpkBbbzttVc5YT1ZnL JSfhz/TW4//heZJhIFuwpAEhN4SEPzQ+rh8retYcTIuA0Kq1ECGUBGeRb9hREslPHlyJ Sso4Y+ZjjcTlH87T8xHmhR7LojRDeBrLNX7ReEq1LiruY4mPLe9J178u9haEQ7VGXu6j lD18PG4SexWL6ODiUavW67DcAEzot3hvKGwEERKTswn3G7QAEmCjcvnbk74gBXh+uqik 6NYIoz4gn6UQqUG9y7pJ5f1u9xYNEjuAaTG58vdAsitDdTxfxASmieK2dsvW/RrASAlb R6XA== X-Forwarded-Encrypted: i=1; AJvYcCX2p0Hdc05odzOwYdWVZ32mS4OENeJg78Y9MQYb3PdPDsP9hElLIPBlvbHMDMjEYwto1ruWAInuxt/yoqM=@vger.kernel.org X-Gm-Message-State: AOJu0YzFFK2JuuQSDqXVYGWtmlvhDOhzK/PNCyg2sjDD9vHRcZxAKYHN CBa0kLIlWsWG0vhOmfgCxZgxq2MBVa4BPtecjZA0KJ520h3hfLUjJkVonsU4mGcluVvZuP/Ys1S Yi7REXlHiGA== X-Google-Smtp-Source: AGHT+IGIpi/Y/94IOaJbe0uGO6m//Yh2Wsky4Ip3Q/V6kyqLVCBH3J882rU0thH0J4Ub/her4q4G/B/xr6R6VQ== X-Received: from wmbfk5.prod.google.com ([2002:a05:600c:cc5:b0:439:89d1:bf88]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b26:b0:439:985b:17d6 with SMTP id 5b1f17b1804b1-43999ddaa0bmr75459345e9.27.1740063828632; Thu, 20 Feb 2025 07:03:48 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:17 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-5-9bbf57d64463@google.com> Subject: [PATCH 5/6] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index db5366b4766e5bfa2d1150d2f3c2d32469a6e28b..1facfb79e09aa4113e344d7d90d= ec06a37264058 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -456,7 +456,8 @@ int main(int argc, char **argv) =20 nr_pages_per_cpu =3D bytes / page_size / nr_cpus; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("invalid MiB %lu (%lu / %lu / %lu)", + nr_pages_per_cpu, bytes, page_size, nr_cpus); usage(); } =20 --=20 2.48.1.601.g30ceb7b040-goog From nobody Tue Dec 16 11:09:24 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A07120C034 for ; Thu, 20 Feb 2025 15:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063834; cv=none; b=jgWNZ78CYDTdhakAQX3shMTkW7P18vGd9WfXXmR3w2z/D3ps/m+cNXBq7f8QZUFpu0COBhqcNO0ndtK1fMCPDz6epRx6Y1qt2MLvTcKGWxC2F4NVRqcPeWoNd1P9EZ3Iev8x94hq5RITWk5nkoKwSkbFYzVtWkHTZwsZmWV1x7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740063834; c=relaxed/simple; bh=W4mj1z3uEq947HIkExuSIBSOsvPwRxwjgNUnGwTjvA4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=OY9L7Y3WEh+5cue//ok3JFQkKw62CcZeszU/7v8V2/0h2bo7q384NFDisRiuPa7K2YjB3u0Ma+NAYIpot0/2BVL02SRndef6+zikhEOHly6G8D/udSwLQbHY1vsl41nfmIl2DRcSr/m29w+vIYrjROix0OvhgLouMWt9+kuQYgk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KovFf0YR; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KovFf0YR" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4399c32efb4so8962485e9.1 for ; Thu, 20 Feb 2025 07:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740063831; x=1740668631; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xbBII2vXo7U0fvcYEVnofRQGig0kHut1fyAo0nfwDbE=; b=KovFf0YRRr+aSy7IFePApN2u1PY8usv/WOA7D13UUU4bpr3YH34guHZzP27VltJJ7f yfsxCyu5KZfu2gSWsTqyFkOAjrQjngVmkr64SwfWUze/Z02eabKZovhgD/5+9KKe1xeM y4tmGAJQ9T02CWWw1LerY4Lp8Gr7MksvV/fBT6IN0Zw2rAsKlyXkaAkOQeE3pWL7nHRy qMCBRDaEARV/wq96m8yKcTcI/XW3UotTA0ioSqFS1yE88wH0szgukNiE2IqFEwEXD8ni WGW2Bjqdm7I01kMFFzBiIXRs+LmJY0xgrNiDahSSA83yQgybN8wwJ+qaw/EpgnC/ZoEn pNMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740063831; x=1740668631; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xbBII2vXo7U0fvcYEVnofRQGig0kHut1fyAo0nfwDbE=; b=ErAiU0okSpfmRX4T6FbJ1iQgkd/w2mQckYurDePhKc8ffmVzlNZJCzoOdRf380lmzK huq+ly/ek419K2K+KVu1LWWvOy5ZDJhoyTmDsqmar2cL23HXZinbWunUnKdAQFRHa+Yi szaVS4yYWEmaP4cVb5va0nveAlKZ9/+75EGxBBNzXLjlhOoXIjHEB3UojGQUchRdfyhp SROk3RNd/476sc3WYcE0+saqyvn9ZLuWgiSJr5m4ETGiMHm6f7fQ9h6CMRtdIb1DBIlv VkSkzdO76NaxW1y4aKkfJe9mQsZnyGVdoMSw9HuoIcsnZIqdRucDZncldMhC9APg29gR dJkA== X-Forwarded-Encrypted: i=1; AJvYcCX0PwBe+/EGW98/WGYhYNguofgGhsrigKj2vv36HAHoGWv5mrwNLaXlJlNc5WUp6gvALeH7kl/qDclpo74=@vger.kernel.org X-Gm-Message-State: AOJu0YzEeJedfreHylubRUZnwM8Tblcfl6OT07aF/FJi+5FC71Ie9SIp k8EGcHptSxNye+p2TaRDDHp1BPttp7HTetjPl1Lwxt/6VRVEGPcEYVZCN1tR4oYcu3oikSn5H0b M81QlLJl07A== X-Google-Smtp-Source: AGHT+IE7Haql4kRMGhVIrFouZcnUmxPrPTorpBWL1U181AADTVynYOoCOjR/I6BHdrXJEH2hvn+bGdgYYdY0eQ== X-Received: from wmbay10.prod.google.com ([2002:a05:600c:1e0a:b0:439:8715:690e]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:1f8f:b0:38d:b8fd:591f with SMTP id ffacd0b85a97d-38f614991e7mr3002810f8f.5.1740063830609; Thu, 20 Feb 2025 07:03:50 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:18 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-6-9bbf57d64463@google.com> Subject: [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index 1facfb79e09aa4113e344d7d90dec06a37264058..f306accbef255c79bc3eeba8b9e= 42161a88fc10e 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -453,6 +453,10 @@ int main(int argc, char **argv) } =20 nr_cpus =3D sysconf(_SC_NPROCESSORS_ONLN); + if (nr_cpus > 32) { + /* Don't let calculation below go to zero. */ + nr_cpus =3D 32; + } =20 nr_pages_per_cpu =3D bytes / page_size / nr_cpus; if (!nr_pages_per_cpu) { --=20 2.48.1.601.g30ceb7b040-goog