From nobody Thu Dec 18 09:39:51 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA8E61F12EA for ; Thu, 20 Feb 2025 09:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740045445; cv=none; b=Jn+4+W837ZjToEt5CxaOfsE6E7ppGw+r+5b4wMrjhI2/bbCu2CvbHypvQo2pDq60dUtXha340DPYDNqKlzrwDnPn6vRZfxcH1OGRpR0Ma9wzyDZ2jVsdBrVYtB29h5bTQLf91/3JOARTe+aWWUX5WfrNuTlNdi9Ur3UPlDkhSp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740045445; c=relaxed/simple; bh=83jrys1E92DqV2B4yqQk7gfJqXMuRsuKUY+FCZWmHyM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tRoxJJ3qruNk18I5c8v+uKbGSBdf6u4ORtdlvK+P7drPN3qdWs59DCyDrN/CvoPOF8GxJQO0Iv7cThmhkuZdnf/x81u2WzDwuVKUpY5WJIfYKrlmbUwg25F99Ikz5sZo75WYXXz9jzhBrIOs4K17A9wQCbNGNTiG5d5V6tvqNeM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=UQrlWcYs; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="UQrlWcYs" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-38f2b7ce319so586283f8f.2 for ; Thu, 20 Feb 2025 01:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1740045441; x=1740650241; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2NO370y0/2ADG59Z7li535hI58C2lwDkCkUPq5uenvk=; b=UQrlWcYsI+ZytDoiIAyydO/4LhmfxWLAFldug1ohY4hgTQkU0oFjDOZDEMhkbzjLTP a6pusk1G7+G+n/eu1ZjrP7SAqIV90pif4vACZ5nKJgR+Tjx9LOPkW2Q2dSrlAgGS8A36 GYSHUv7OdmPNxDQeLDgEY3ydFeERnSR+h0R7ayYDM7lNHfE1fVg62iYdFtIX8ISx6rsi 7doC1sGNpRBj+wx0NU/gTJbg0utihCJ47rjuHjfUaWFLPfWWizwshvkzZd+mLOgOJ8Tc S/Cz7LqzmhvduwZwtHx4MXKVUYILfBf3Eh2S/05Q/4PJdnTUp6p6W3fCeTjnC3SS9uAI 7ukg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740045441; x=1740650241; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2NO370y0/2ADG59Z7li535hI58C2lwDkCkUPq5uenvk=; b=qKTG6Ve3l/SAO0oG0Qo7CcRe3CvaXL9LgL24E6GwzzxGgOrsKs8dcL3f8SZUgEzsZe KFJBOOPt+QN3eRgr+TLKSAIQr206ky4Sjmmrt9GVuce4hGY6eAnXMlZzUr3fwBzUZEkW 5EC/0D+ZD/bKMsjh3iw8qecMQ9hnGFayGKLaJbRpl+AW6vZulTNfDRr6zzc7Ev9QBzJ9 gGdtIPO9NIU0xQrx1BU+vlHM5pMbNqt+Eog6T5QIltc4zodcKnyR8irQIhz2UVVm6Qo0 JiPeEU//HfgQcWuCBXpyO7R16t3XBFQHgN/Z3Qy6xfyYUxZDbBU4HrD8SowN+tHLXJjc iybA== X-Forwarded-Encrypted: i=1; AJvYcCVeisD7P9aIjdPFPcSwjexhmYd1Jz7cYYq8+kA+cPi9FG2zXHqFnRP5tNdI2kRjqX//YlMSft//p7zOVjg=@vger.kernel.org X-Gm-Message-State: AOJu0YxqKh+cAz/YfA1kSjBBIycovXWTsrNyHENOLZP0MuTgKpXvXVnu 3gzmKB3xDsXCuxyzw/ji4yn7VDvXg2s6yx5G359U810P+DOLEJbXo46+jM6ydiM= X-Gm-Gg: ASbGnctSvobtpf9tjyZwKLd0hYzuhXBOlV49nJuyD3e2GFmwaicDzi416K1AmwrV1Do fpGZdjMWG46zxoPiB8ZZc+QAEZbNQ1Ily74EKKdm5gLF1gFrclbwchjLTR7q91Rja1PYcdFestl Fk8zTwz/7hz7yslJJlxpMWIm51jj2B7+0VGhtdbeNUExDQzXkgYy0WdTfST98q48WAGL689qFpF +nPNtMSNjWDz1ffEKVsPXNJWjjj0olazStaqrOrbIc8ErvhJmpNYfwfbZJgWFGjWhXhLzVLZjv5 QZCYZII= X-Google-Smtp-Source: AGHT+IEO825ZkHmQ8WbNulFejsXgznfD4+7SKpzDZn/YojbRukVDHPqQhfbjIfNIrmAwUbEE3pnONg== X-Received: by 2002:a5d:47a5:0:b0:38f:3914:c624 with SMTP id ffacd0b85a97d-38f58781f55mr5039562f8f.7.1740045440994; Thu, 20 Feb 2025 01:57:20 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:e2e4:418d:7462:9cf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259d65dfsm20509174f8f.64.2025.02.20.01.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 01:57:20 -0800 (PST) From: Bartosz Golaszewski Date: Thu, 20 Feb 2025 10:57:03 +0100 Subject: [PATCH v2 06/15] gpio: sim: use value returning setters Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250220-gpio-set-retval-v2-6-bc4cfd38dae3@linaro.org> References: <20250220-gpio-set-retval-v2-0-bc4cfd38dae3@linaro.org> In-Reply-To: <20250220-gpio-set-retval-v2-0-bc4cfd38dae3@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Michael Walle , Bamvor Jian Zhang , Geert Uytterhoeven , Keerthy , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2221; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=4rRdeo5YWk0LkDw22ljFe5PNudUuy3MdO7T7WRZ6ito=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBntvx3/w2vZ+VX+sZyEcAAzR8U8eEIF23h/R/rQ nJt8/qfdyqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ7b8dwAKCRARpy6gFHHX cqNrD/42nR+ZlDZgK/qtK+xulfHuQlHn1AY74smk8hxOmlX3ZsoB4nZolvlRRMsX+P0DfqwCDbG J5JYBjhHwqDP/c+YfLhY9SCtWfkdJuA1UdDQaAr7cwZ01DC9hXiy38tBblCKv44f5LcLfH8RfqX QfyiWuMJY6Ie5hQ2gsf/p9x27Elo/eGrSY2OAiJ7gvfSxYvzKA2cMWOSO59zjay+MkKmGy2RZ5n +GDDHubZbGBEal/fHOdUk1Q7sp2XUB8HUbJeIey7XL94Ekjk9yIbgiRQ9NTgWqNK4Nc8Tz8k2jo M8tiBY7EIli7uc8aicwuSGvXenO9Sp2ZBPmsK287HhSg5/7ozvfPCpl0gnnZnUYuy88GliCQm22 ETOIZqCr1SzgL0yJ44v4XBQmjRIH3KO2DbU3RtVTzD3aXzamxhlG7uftHefUbf1Z96NJtVLEM3U HrBKivK9Pk/DEOBBFe5yekduG7/zoCqcdYvddme29mgGBY+tdcW1doJ5X87NIQSmkcpzLR9yaaX A4fa9f6AD+VzjzOf7wk0+UbWQaZr/KU1wcIpghAZYueP5aWVaYfJbZFOMXxQ+siycBX5RwFxjWd pFSS1n0y2aoncd0L48jawQGiNmh77JnoR2ZnQShBVJ7P6Ma7xNM2dNfXIXk/noTkAvoa6J1iNo7 gFZa1YKr/EtsdqQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has additional variants of the set(_multiple) driver callbacks that return an integer to indicate success or failure. Convert the driver to using them. Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-sim.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index b6c230fab840..b3baa7e872bd 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -119,12 +119,14 @@ static int gpio_sim_get(struct gpio_chip *gc, unsigne= d int offset) return !!test_bit(offset, chip->value_map); } =20 -static void gpio_sim_set(struct gpio_chip *gc, unsigned int offset, int va= lue) +static int gpio_sim_set(struct gpio_chip *gc, unsigned int offset, int val= ue) { struct gpio_sim_chip *chip =3D gpiochip_get_data(gc); =20 scoped_guard(mutex, &chip->lock) __assign_bit(offset, chip->value_map, value); + + return 0; } =20 static int gpio_sim_get_multiple(struct gpio_chip *gc, @@ -138,14 +140,16 @@ static int gpio_sim_get_multiple(struct gpio_chip *gc, return 0; } =20 -static void gpio_sim_set_multiple(struct gpio_chip *gc, - unsigned long *mask, unsigned long *bits) +static int gpio_sim_set_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) { struct gpio_sim_chip *chip =3D gpiochip_get_data(gc); =20 scoped_guard(mutex, &chip->lock) bitmap_replace(chip->value_map, chip->value_map, bits, mask, gc->ngpio); + + return 0; } =20 static int gpio_sim_direction_output(struct gpio_chip *gc, @@ -481,9 +485,9 @@ static int gpio_sim_add_bank(struct fwnode_handle *swno= de, struct device *dev) gc->parent =3D dev; gc->fwnode =3D swnode; gc->get =3D gpio_sim_get; - gc->set =3D gpio_sim_set; + gc->set_rv =3D gpio_sim_set; gc->get_multiple =3D gpio_sim_get_multiple; - gc->set_multiple =3D gpio_sim_set_multiple; + gc->set_multiple_rv =3D gpio_sim_set_multiple; gc->direction_output =3D gpio_sim_direction_output; gc->direction_input =3D gpio_sim_direction_input; gc->get_direction =3D gpio_sim_get_direction; --=20 2.45.2