From nobody Thu Dec 18 23:42:16 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC90B25761 for ; Wed, 19 Feb 2025 01:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739927430; cv=none; b=HkwxRH4wNbPTj/KMmWtQ9kbwziO4Y9ydA28LSpSoSXD2rG/ZH4Ifm/NKUW4W16hziC8/XbF7F3R14nOOJxX00fGwFZPQZzEx6XN0vZdIGGFqidow9/VCQzIGTFWB4UVvRbaOY654tXmkFfjWKsKT1zRjoepS5f5WqQ4wF0QXp1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739927430; c=relaxed/simple; bh=bThHOLoDYNCT/c3Kd8PD/U/zp8na1Juu36KQmkq1IDg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aQMICSOrSNrAwmbc+B3uBUnUYYj46fxdFfnRHwm6uDrLD6Xg/kbFUkMBU3cmkM5EznA6o38uowQ2U6rpnLsxJLWDGiL4XnN9jgxfOKzNzEhsglBt6vR75EzJB7G15gR2rLxDS5MTLjC6LVFz6lB5qrxzJBD4geoccg1j97C1gSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nZzO8HcK; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nZzO8HcK" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-220ca204d04so84541985ad.0 for ; Tue, 18 Feb 2025 17:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739927428; x=1740532228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zeVTXMfIDDovR3x4Ig+1s3A5xB2XDG1KMxZlkZxO9T8=; b=nZzO8HcKTB8avZx0ONa3eIC3fxNWj5FYQrAOBvjGLXtNkVsTR6486GWMewwkTAbxgE Tryl0uN3JBzPlRSBkJ0cU/C2C5PwXAhKRMb4JpUu8sTu/VMsnznjqu8e6+ZF2nJWKZtx LYI5BGSHxAmT5UU1yLV1DeWqpDOJO5Oh9XQkMzCxAb+5k3g1p0l5WH7CEi9lqxrGqok5 7aAk03tTizBckDQoKKEC7/jXQH1x+36TyERs21ASQYqRM/ORQZodVpOhg7cVTSu0iM21 9NDDNT8Xr1wFI6CF2MwFY8lC/08kwXXRTrSh37fi5/4ty39qkCbC4EwvcfopF/bFtWla mKBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739927428; x=1740532228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zeVTXMfIDDovR3x4Ig+1s3A5xB2XDG1KMxZlkZxO9T8=; b=O4Nq1fZ5FmWW4hSaOJ7RACKR5LVNFi6an38zuHncOzB04LQJmxLnQH0Mc94WnMxCDp 1IeC0aYILGWVOVhOv/odKv2gSZMcq06LtheYmWH+Lal95oUVpgxTh4BrFVhLHyaMPKkX ClOxdkppWHbZd/v+KRzSdeiYdGUzUt4mLllasLzVsIAdMcL/9TDbez1Mj4ykda8a2Jcc YJ6dm2b9iDRCzevO6xOpWri6Ot8o82QQpvoxIoYbp/9Eu4eZzoiTTq3V2+Wy38b4pmaj eSvVIwMaXPWLKttmb9MHaa+WVLLK38Z3bB03awg55vodSVLdJ/I7+GGQX+dPOC54KZTd zQ7w== X-Gm-Message-State: AOJu0YxIsr4SOurPWMajEHro/1QoPywcTe1paFTj3XwFADORCYLjbKFS XzOkWySwIn7ShSsPEE8WXz1+Ws0fQRVDT2WAJBs7h3EZhz8o2AU3 X-Gm-Gg: ASbGncuH1hKhVTCApFW/kTlU0jipCRRqOTpRoY0hVgmYy3F/Ec0FIXPX3GgfTqZb0dJ bMcRMBm0Bf7jzVY0cDiRcizvDgRXmhK/NwlqROshzS0kRn+J/4kHCkKWNGD6jfnLuKsGdqrsqUT Spg1EN+F865gX7P9P5T+byvJimV7MDWFNXeYH0VN44cOMYF2DIJVzEVZQn9VqaN9agLBFhWJ9tW VOEZbZRYIXnH/8e7KgTC2jACuQQHIpz+19uo7ww6zznkQel6CyJwOItBSUJxfDGX7Y9CCiS4BDR UDh9FQ/rMp1BPhDoEbsWYIOzAA== X-Google-Smtp-Source: AGHT+IGEy3Kh6gL34D+bhWUQUiTH6OPIOsHN0rcxloy4L6e99McE1rH+dwDpAVZD6Ph9M3ku+CTBzQ== X-Received: by 2002:a17:903:2f8d:b0:21f:85af:4bbf with SMTP id d9443c01a7336-22170968d0amr22211755ad.20.1739927427950; Tue, 18 Feb 2025 17:10:27 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:dc0a:4fe5:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5348f05sm96080315ad.2.2025.02.18.17.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 17:10:27 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 1/3] i3c: master: svc: add support for Nuvoton npcm845 i3c Date: Wed, 19 Feb 2025 09:10:17 +0800 Message-Id: <20250219011019.1600058-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219011019.1600058-1-yschu@nuvoton.com> References: <20250219011019.1600058-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Add a new comptaible string to distinguish between different hardware versions. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d6057d8c7dec..813839498b2b 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1960,6 +1960,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops =3D { =20 static const struct of_device_id svc_i3c_master_of_match_tbl[] =3D { { .compatible =3D "silvaco,i3c-master-v1"}, + { .compatible =3D "nuvoton,npcm845-i3c" }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); --=20 2.34.1 From nobody Thu Dec 18 23:42:16 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F7F47081D for ; Wed, 19 Feb 2025 01:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739927432; cv=none; b=nz1sh5g6puAp9BwD66ZemMwFmr9vEx1dqVzfMaT2qMQBQlXZTd5CR218jr0d44TzvErS1gHJw1GU3HcVK5dA520CCndj/E1GZSrMtg+W0TuWW4ikhB+3Jd2fjH6ZHufpnKk0drby8VRwYVCAMmPml2kai61bEsU2bC6d+F4YQw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739927432; c=relaxed/simple; bh=RtQbQlItwsvYyAN+RFPRuN3sJ2hAVTgTiPu86K3Nfrs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QvRo1q9bqhMjt0kmiAnODjhVQ0eIYA3iA9JmtmrcHrBk2JmrC0S1trpm74JnC/HDQ65d/Dt6GmOjmQDWmfbqy29kISVpeVkcm3zTBY/FCnHsBFcjDBVw1WojDs4y+RcGqYfzhu8yYooGQJAUt6SHfdW6OWG7W0k8Oztkk7li8ic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WcfdCKoH; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WcfdCKoH" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2210d92292eso95930595ad.1 for ; Tue, 18 Feb 2025 17:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739927430; x=1740532230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQfECy+M8cSWsoOJoFSA8ondIMCqsdotHgkIf8xUcO0=; b=WcfdCKoH3c0J6jKriLelBkfg1y18gV235IbjB+u/wsczX4H+wkS1phu7ROjwBCUxyN hdkhv+ywJN9peDNT5542yd1JH4D74Wi03RKd/nK57mzPUjbjEJRyPjJftyZpLlrCgvW+ 9ENRqGSTSXeiIZGcQaBrRMUNFTUokabf0glzBWbD2No7IsPeH2cz8aebcS8YExWfCp9n VVHg8z3zp0p8W5qa8T0JfY53iQn82PJjNIGa6KUkWf9rRFtzweqtY/UGAlJKwTcxDKuc fPk2Bckl3/wmQ/7GP4ezAEhzeLHOoLr0+JS9EvkobaQvoRwhbbgfZDxjdwj76tz9V/ES 5lNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739927430; x=1740532230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQfECy+M8cSWsoOJoFSA8ondIMCqsdotHgkIf8xUcO0=; b=FfupWVwoBnar2PgnQjNJqGyBo5//hoyIqLGD/cHs/pnzL36WV3ExvEIlENFCEiMjwm qg19ZTrtNqWR4lOMPhRMVf4uS0N1guwyj2bbqJih6lzuzwoQs+YTK5+60+yNmCbn/Mm6 6lYw2JqlrngV39i5hnNJAXNu4R1p4ogFsxg9c8HMbPoRS8ZDLy7T2qnBr8yzGLZbypE7 CctPUhS4YFAP1r90mIKdNEnl5CLyfC3XWnyv6g5YPOH17Xb5GpY2KxbJbZ9DDZ+5jVCl SPyc0IMgxBOmEywGEEYm81huPToKMFsD8g0rky8EJFj3wpfGy4nKzc0NhLQxTfav4as9 V9/A== X-Gm-Message-State: AOJu0YwSQTKTbGPgWwcjGt9f1m71TXpqlt/Ynr9+TcRCAKdhKrRWcfgX 8ipW0WMvI0qwJksje+PRCTCp5dgxDIp0Rk9wm97BbEczhycGxWFH X-Gm-Gg: ASbGncvRnmkJhk2kKXsc8OnBSfrM5+oD+AoM7q6ZKOYe13ChC16aXbqi6tlEkCt6vbb yB8Pv9jQ69aYqJ57FjiqM3QJndz98bDqX+HAUeT40Fj1ZqC/0E5xqT7vf0+5j68qeGQ3cuFQYBx HtIrTPXxStx/1NLIoGkQg/KeXVkWl99P2Y8+buxE6fUmapbVA6JFTfJ4iOdOCndP2/3E6lq/bjX UefB5gKd71V83HWe/lc1ylT6t1rGOtq3VKto0aM+lOnQH0TcUoLx/E6ud8tFbhY1V9KeOFM4HpI DmZtl50wqAOZFdkKj1sOhFsyaw== X-Google-Smtp-Source: AGHT+IEjPOF9KSTzI2MsQxcir5evnluJM/uTeYqKNUB3AIj9hbsInSCZPHWIGW6siNdjzcinklyF0Q== X-Received: by 2002:a17:902:e84a:b0:220:f87d:9d5b with SMTP id d9443c01a7336-22170988bb4mr27863125ad.24.1739927430304; Tue, 18 Feb 2025 17:10:30 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:dc0a:4fe5:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5348f05sm96080315ad.2.2025.02.18.17.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 17:10:30 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 2/3] i3c: master: svc: fix npcm845 FIFO empty issue Date: Wed, 19 Feb 2025 09:10:18 +0800 Message-Id: <20250219011019.1600058-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219011019.1600058-1-yschu@nuvoton.com> References: <20250219011019.1600058-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" npcm845 HW issue: I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Workaround: Fill the FIFO in advance to prevent FIFO from becoming empty. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 58 ++++++++++++++++++++++++----- 1 file changed, 49 insertions(+), 9 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 813839498b2b..22cb1f1c1fdc 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -102,6 +102,7 @@ #define SVC_I3C_MDATACTRL_TXTRIG_FIFO_NOT_FULL GENMASK(5, 4) #define SVC_I3C_MDATACTRL_RXTRIG_FIFO_NOT_EMPTY 0 #define SVC_I3C_MDATACTRL_RXCOUNT(x) FIELD_GET(GENMASK(28, 24), (x)) +#define SVC_I3C_MDATACTRL_TXCOUNT(x) FIELD_GET(GENMASK(20, 16), (x)) #define SVC_I3C_MDATACTRL_TXFULL BIT(30) #define SVC_I3C_MDATACTRL_RXEMPTY BIT(31) =20 @@ -133,6 +134,16 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) =20 +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -216,6 +227,7 @@ struct svc_i3c_master { struct mutex lock; u32 enabled_events; u32 mctrl_config; + u32 quirks; }; =20 /** @@ -891,6 +903,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_= master *master, unsigned int dev_nb =3D 0, last_addr =3D 0; u32 reg; int ret, i; + u32 dyn_addr; =20 while (true) { /* clean SVC_I3C_MINT_IBIWON w1c bits */ @@ -931,6 +944,15 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c= _master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; =20 + /* + * SVC_I3C_QUIRK_FIFO_EMPTY fix: + * The TX FIFO should be ready before the TX transmission is starting. + */ + dyn_addr =3D i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return dyn_addr; + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1009,21 +1031,20 @@ static int svc_i3c_master_do_daa_locked(struct svc_= i3c_master *master, if (ret) break; =20 - /* Give the slave device a suitable dynamic address */ - ret =3D i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] =3D ret; + addrs[dev_nb] =3D dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr =3D addrs[dev_nb++]; } =20 /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + /* + * Dynamic address is written to FIFO in advance for SVC_I3C_QUIRK_FIFO_E= MPTY fix. + * Flush FIFO in the failed case. + */ + if (ret) + svc_i3c_master_flush_fifo(master); return ret; } =20 @@ -1210,7 +1231,6 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, /* clean SVC_I3C_MINT_IBIWON w1c bits */ writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); =20 - while (retry--) { writel(SVC_I3C_MCTRL_REQUEST_START_ADDR | xfer_type | @@ -1220,6 +1240,22 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); =20 + if ((master->quirks & SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len) { + int i, count, space; + + reg =3D readl(master->regs + SVC_I3C_MDATACTRL); + space =3D SVC_I3C_FIFO_SIZE - SVC_I3C_MDATACTRL_TXCOUNT(reg); + count =3D xfer_len > space ? space : xfer_len; + for (i =3D 0; i < count; i++) { + if (i =3D=3D xfer_len - 1) + writel(out[0], master->regs + SVC_I3C_MWDATABE); + else + writel(out[0], master->regs + SVC_I3C_MWDATAB); + out++; + } + xfer_len -=3D count; + } + ret =3D readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1308,6 +1344,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); =20 return ret; } @@ -1877,6 +1914,9 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) =20 svc_i3c_master_reset(master); =20 + if (device_is_compatible(master->dev, "nuvoton,npcm845-i3c")) + master->quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY; + /* Register the master */ ret =3D i3c_master_register(&master->base, &pdev->dev, &svc_i3c_master_ops, false); --=20 2.34.1 From nobody Thu Dec 18 23:42:16 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDCBC13CFB6 for ; Wed, 19 Feb 2025 01:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739927436; cv=none; b=r87e/oKooqQ1umRUDTtTRPkpvT9wPbH77CtoHEYDDUeolB5A9S320Ai8+bmLCHg/yoeIONMhJ1JLL+Xm9GZkuNdYpt8D5TcYQCLWl74pp/hQm/ZxHTGntiW/hv0XYQYe76nr4Q7sIOjjql6RGXNz5wU6764R/0JfnD4Z0BCgndw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739927436; c=relaxed/simple; bh=torwI9xzLIIK0HgPjCTxvzGxXal9Q+8FEMK+XHcTf10=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qQ+Q1O5sMT1ZAjms8cNq8bhgmrMie800fsOzO48ZayMDx9lxpiYEvnoRqMySAEJcy6xHL10D7XcxTHeMHa+fZ9SvWxezvaZbsC6XiXoGMniP/+kg7a01uAjNrU8oZfWwdDpVzKLa5u7tal2iGQfL3dwLBebEsyXps7gn4AxwjMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JdhYC/u5; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JdhYC/u5" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-220ca204d04so84542965ad.0 for ; Tue, 18 Feb 2025 17:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739927434; x=1740532234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m3mYC7ENmf6rcEpzheezEvM9BfeiOk2Z8ZQkMdJrj/8=; b=JdhYC/u5jTWkP0KBFgA1DXTVRmvLboKf66oG8TLBTQuyUba6euqkQS8Ca8Sda6LseY jIZtX6Fpz3qO1Gh+mKnqX3ifm1UbwSdnY0RFMRms3jJqw2t6Fypv+FzJzYvNj7Q5ADfl nwNls4sTl11hO2RhXKapMuQ9WigpkjHzX+zFmuIC6MO5T9F2SENw/Gyz9TBW1buciTRE CXbc/28sQq4S6lsohlENBIaDrZa3isWDYsylHcUxq50MDtrfsJBEwejF16ydJknqi+9w vFSSnmXN895uOIx5Te0ovGAdlQLOZ+KOZK2ZcjDD2Q33sWzsKT4WTOjry41SVoWmyO2N /aTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739927434; x=1740532234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m3mYC7ENmf6rcEpzheezEvM9BfeiOk2Z8ZQkMdJrj/8=; b=pL0K3kvTcOLGjXzFGmSdCZArfSNKytQcSPl6IY3drSYEEIy4G1OP5CA2nAbf3l8051 WFl404bv71OSUgGzpSG1lTO+RGQwzyPEGMHdEdW4FINxet4fnMY+mq/ztnj0I5U+RmCE Q+DZN6u6CrRUS3fqLBupRlP2FwylksNJyfiHXLDuyIwukTQwJJPXzXPzENwC7oSf/HWk yw8B3HTmdjO+YeFemiZASQ1LaDY5A0XyjEwcT6tA9cWBCn0tIIYviZVQw7RZtcb2m2uP 7XGC0sK0V3pcHaIWDaqRph+PzN6JeoXry2tux5/pS7TdPs+F8RS29SELjhkBuO0T7Rxk DHrw== X-Gm-Message-State: AOJu0YwxtnzGTJwk6GfWJkf+WIfasE0KXcVg1PK0/EoaYkMLAH5VIyyC 4VFCnCYgvEPAkmTe5QmF3D66/qPTNfycPeb3aoOgSPEp6DrHgub5 X-Gm-Gg: ASbGnctb8Ty8ZTgrsD9pknn5v/IB5n9c1vgfs7r6ZObMTrGwnZyCPXcWrcFc0PdQwlQ q8Hgh100oIWQUT4hYURp7UbbuRRx9ssBf3DykeLsFNy2ydFNnLOQZADNEt0q2gUsCdiVpWDP040 VG+5bvX7PCrCCJ6Ino+4tUF7YzUaEzTLEBYA6RyGNrfEGXHAtGe/loGjzIPv3fiucpYkMy7LJlm fWwIjspeNfTO4S1mfNs09W1desLxypjvLaMQCKl5EAlRoO+smVDOt8hrWhG7xGrkf4C2j5WyM/C TTy+IDBHrwfBfxAUE/R45dCf0w== X-Google-Smtp-Source: AGHT+IGXfY3WGuhGV/3mSu1e9ym7RxoJ3BskUzPfy/qOHknOlucPS8A+jBmMTZSyoS6Zh/ed/iN22g== X-Received: by 2002:a17:902:f550:b0:21f:7077:2aaf with SMTP id d9443c01a7336-221711c2a34mr23963485ad.44.1739927432623; Tue, 18 Feb 2025 17:10:32 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:dc0a:4fe5:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5348f05sm96080315ad.2.2025.02.18.17.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 17:10:32 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 3/3] i3c: master: svc: fix npcm845 invalid slvstart event Date: Wed, 19 Feb 2025 09:10:19 +0800 Message-Id: <20250219011019.1600058-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250219011019.1600058-1-yschu@nuvoton.com> References: <20250219011019.1600058-1-yschu@nuvoton.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state should be SLVREQ. Check the MSTATUS state to ignore the false event. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 22cb1f1c1fdc..14cedcb81c52 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -59,6 +59,7 @@ #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 5) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D 0) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) =3D=3D= 1) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) #define SVC_I3C_MSTATUS_IBITYPE(x) FIELD_GET(GENMASK(7, 6), (x)) @@ -143,6 +144,12 @@ * Fill the FIFO in advance to prevent FIFO from becoming empty. */ #define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state should be SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) =20 struct svc_i3c_cmd { u8 addr; @@ -576,6 +583,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq,= void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); =20 + /* Ignore the false event */ + if ((master->quirks & SVC_I3C_QUIRK_FIFO_EMPTY) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); =20 /* Handle the interrupt in a non atomic context */ @@ -1915,7 +1927,8 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) svc_i3c_master_reset(master); =20 if (device_is_compatible(master->dev, "nuvoton,npcm845-i3c")) - master->quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY; + master->quirks =3D SVC_I3C_QUIRK_FIFO_EMPTY | + SVC_I3C_QUIRK_FALSE_SLVSTART; =20 /* Register the master */ ret =3D i3c_master_register(&master->base, &pdev->dev, --=20 2.34.1