From nobody Mon Feb 9 10:56:24 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F13F1C07D8 for ; Wed, 19 Feb 2025 07:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739948875; cv=none; b=JJslgFwL+mr/Cb3l5PCwSiOnYfybnpXZRsRAkGzIlPSlOO8/ssdcBIbpIPXGGzK3h06LLwoQ/JQMwuQE8taL7LHZ0+Cs0gncFLd7Ch8NWy/+dcuHrpHuONixC605DpRv47GK7YO05MlBbZCI9sok8qd8HXLDiS7zDBKs53/9W/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739948875; c=relaxed/simple; bh=tRuwH6VxRqvMDaFXAUrYgi5POr3+De0fDLCYrpPVI5o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JbekybDWFVhqGZODJ5YlTiz5fVVocGp/JptXm0/m5tPdZpYdgOAVmgyKluyBxdxgkxcREd0VB5u6NN4Jq+FZM5/DN/h7mxiOdF4813LsY4rD/LTxyLoS0cgYNimRBLsaPvFt1HFJP6Ii1eweRQzAMNwqJP+mrS3OMJJVGWeWCHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=j04rs2L5; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="j04rs2L5" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-220c8eb195aso129354445ad.0 for ; Tue, 18 Feb 2025 23:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739948874; x=1740553674; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=JySMFlXLgdYY+/iNRAMB6CwpEhlF84xeDqxk+lfquv4=; b=j04rs2L5VjnYxKPG8Wv78XJaLmBflmAfIEhMy2mrfV0e29VC0R9TD3WsqTt0EzzPNv cgsAS8m+KV+e/VVnHu8UTiRXd7VIqw3VrirlQ5TQy2jHmJB1J+3m5zL7NPMg5zF/0J1J Zt15+tLNBSv3BMQKMOzetcLtUMy9a2PmvENoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739948874; x=1740553674; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JySMFlXLgdYY+/iNRAMB6CwpEhlF84xeDqxk+lfquv4=; b=nLDl6T66ADW4yL3NcFmzJOoVz8dt1n/sIZNbi/5PguOtHtXjHTxmqDjMFwwXbAMGfa cl4Ztto7H+1tEKLvgf5xgLBLFCyUdUci5YN1Itt5jMLz25tji8W0qG2CN+qMdJLf7RHN nmvYnqAjQ91d6ELzVXbpKLiV3o7KWkDSptpu7nVOthsmVAhdtYrwgY4odx+7eNiw5XU5 zTOWo8Yn9Ai9X/j0WRkmFdre+/KqSFJwqE1WO4Bg61NyhPFZnpJpLfOOkqwjLNnrzVBw HpfIImvpUUZoQpcRfy7p5qQLN+BVT4A5pNouRP2eCbXUc3ZTcEO9mU8NVxVptmdCSDKt 72xA== X-Forwarded-Encrypted: i=1; AJvYcCUSVuNhOENIYeBaUT0iOk2FcnOemn7+jJmbH0kaTlQ8Rl57QJDq7lzoMfZaVCBGenB86baDRevaVfYfyJY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4sR3lP8hFxempbSUFk33a4plA9AK6TH+wT8oGbvf4eNkgfntQ 619q+xi6ufmpUyep2/jEY1HLaaU+VBtH7MfKeIlSISaqraGdg4LTS+xzCaMIiA== X-Gm-Gg: ASbGncv7VbGIAKFge55gw61f3Xk8JjPIMdKhD6tBxJaujbLz2qFBGUaKY6OEqoKDlUg C2pkdnE7TQaT9DR7gPVbPYigFkbwp0qdN1Uikm1ipGxDz7+3/A8ThCNqmCCb9xfqSnwRIfh5UAf PEC/g9fA94o31rLi2vCqSB4LDaLu4Q0neg/Tb6htg1a9rwm6gjlsTmR+Lv/OYFJk6VLAc4VO/CR hl1zapY+JEUa2sJx4RgE32M8twX1S9KmRVzPtV7MPq8ds5i54n/zyVItrBkiFm1twO7v1hsSCok 2bGGaHG/RX0M88ZSiTFu6Cjq46msHjI0OCQ= X-Google-Smtp-Source: AGHT+IFNCLC327Tbgy3w8769F53bRAzhUse9206vwI6TMenlf9TyIK/Yx1MUEoN25QE8Ttyi6D3/xg== X-Received: by 2002:a17:902:e746:b0:216:69ca:770b with SMTP id d9443c01a7336-221707775a6mr40769815ad.12.1739948873793; Tue, 18 Feb 2025 23:07:53 -0800 (PST) Received: from giver-p620.tpe.corp.google.com ([2401:fa00:1:10:224f:3294:90fd:ad2d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d545d051sm97789835ad.108.2025.02.18.23.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 23:07:53 -0800 (PST) From: Yu-Che Cheng Date: Wed, 19 Feb 2025 15:07:48 +0800 Subject: [PATCH] thermal: gov_power_allocator: Fix incorrect calculation in divvy_up_power Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250219-fix-power-allocator-calc-v1-1-48b860291919@chromium.org> X-B4-Tracking: v=1; b=H4sIAESDtWcC/x2MQQqEMAwAvyI5G4hlFfEr4iHtRg0UK6moIP59y x4HZuaBLKaSYageMDk1a9oKNHUFYeVtEdRvYXDkWnJNj7PeuKdLDDnGFPhIhoFjwJnIf9h3LXm Gku8mxf2vx+l9f0Pr6xpqAAAA X-Change-ID: 20250218-fix-power-allocator-calc-f00b4ab650ba To: Lukasz Luba , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Yu-Che Cheng X-Mailer: b4 0.15-dev-42535 divvy_up_power should use weighted_req_power instead of req_power to calculate the granted_power. Otherwise, the granted_power may be unexpected as the denominator total_req_power is weighted sum. This is a mistake during the previous refactor. Replace the req_power with weighted_req_power in divvy_up_power calculation. Fixes: 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation = out of throttle()") Signed-off-by: Yu-Che Cheng Reviewed-by: Lukasz Luba --- drivers/thermal/gov_power_allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_po= wer_allocator.c index 3b644de3292e..3b626db55b2b 100644 --- a/drivers/thermal/gov_power_allocator.c +++ b/drivers/thermal/gov_power_allocator.c @@ -370,7 +370,7 @@ static void divvy_up_power(struct power_actor *power, i= nt num_actors, =20 for (i =3D 0; i < num_actors; i++) { struct power_actor *pa =3D &power[i]; - u64 req_range =3D (u64)pa->req_power * power_range; + u64 req_range =3D (u64)pa->weighted_req_power * power_range; =20 pa->granted_power =3D DIV_ROUND_CLOSEST_ULL(req_range, total_req_power); --- base-commit: 2408a807bfc3f738850ef5ad5e3fd59d66168996 change-id: 20250218-fix-power-allocator-calc-f00b4ab650ba Best regards, --=20 Yu-Che Cheng