From nobody Fri Dec 19 20:34:13 2025 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E2081E0DDF for ; Wed, 19 Feb 2025 13:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739970041; cv=none; b=KkWnqPjbIepFsSoV0Lq4WvT0o+qZFka+ElZG8Nrh44rhXaKG25oMHwllhXaTpZaVqMwLrQeUOpmu0HPTke6IJFEBnNOftfMQkxb/nPKG1l+gOXMF5366uyTso9sS0df+4tGKAE5NaxPeLAx5rmOUOoNNpciWqTVy8V0fdwXKt6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739970041; c=relaxed/simple; bh=5tKH69LPnXtw2g2lgp5pOEeBRn775Kcy79G0bglGhPo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hxxOUHXW2Fsk7N8MH9/Jor8gtsjpBWhbcK6v70D6DwNXiltZ9gpR6WfKwk2lmvaZhYI1ZLyMQI148v/OIP2YRazi+8HupJKln0YRX1TczOlfaFbIoLNJ9V1p6kc022QhssG8j20DrVIevcj++sOzEMqKsUJMOWMERTd9oxyVW+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GoO1vllZ; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GoO1vllZ" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5452efeb87aso5306329e87.3 for ; Wed, 19 Feb 2025 05:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739970037; x=1740574837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hyt2aJC9WtTbvDjyGKTp5US9Ym/jYLQQ/Fi2KJapvfQ=; b=GoO1vllZxPvYCww9gfs3dsQ7rXOfKkPxeXrPF/Ccc3nKJtfVTnLLLot5jbNfpre4l9 7DP/VCsyBv/mI4y3ykW5frAD/umzfGaanDW+qkv75B6TlP+4X/po851pfkpj64tKSv7A rzJVuuvCXklaEHTJrNzT7EFMxuvCya+qFSqVj0OYvmZ4kOUwjUKPyXQ4AElVXMcH7WlP q118TFcHpK2jnqucsKQnUbRNHXKf1Y4bogxEwlM2dh/ZwUlLuJEIlNRJqeLNhRAieEe3 36bbqvxqQjemGPFCH/Oau/Z2ZrVJ7GfF0KkYPcbBnpix/HPDpie2858isacNMt2p3etF Xx3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739970037; x=1740574837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hyt2aJC9WtTbvDjyGKTp5US9Ym/jYLQQ/Fi2KJapvfQ=; b=HSSgEGnL60/IyfAFVs8um4LtU6Vc08UGcWsuy1r7Y7TCSVD4vEAgwhQSV2zUv2giqn hJQYtAtde4XFqDPCEtZDAdIQUY85HgnWZ1ZRl5LCDSR5h9esmIn27GU6fh6Y4cbeRSUG SHZntq8ZZRuV1dmUyAL0IYk2CsA18Cfip+ovTwhErM/f97fxgOFOxdiGBVxva43hWGBZ /NhSc05a9LBNDUwbkIp+UbvV1WhfKguufBW8xssXSHd+sUywXD3V6Vf0nD+Ft1vZBcZh hmyAyE66fKHHc3tHLA6QVu49n5grE6RiSCHnEpBehQfMZJgQ4+KOo1ZbYi24MY22edYd 9r2g== X-Forwarded-Encrypted: i=1; AJvYcCXEgJhK0BafTY0HrEw3oexr797LtteSI1ZtAaj8TWnTB6XPAVDKKAKL4qhb47w+RHPF7WZulmx/eL3LhE4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+eeq6Bk9geQjBLBwsCY4gZ7f4aam0R6gUA2fMjEmp4g86xyII a7NAK/QbeQ7VpzZvJ25JITQHQftBp3gvUD9lqMUr2Il+nxJFvp0rK1fXeD0SuXY= X-Gm-Gg: ASbGncvZ6EhONu7FagxsPyoTlNm03bYSRQ5qry0Bq/FGMZ4QUDlrh1u5NtjeY7pglJJ /0VnKEkwsF6D560VqJ82qRsbZ8Nm7HlT+nu/ZKv+2/nPKBD1+2ymNJ+zrSB+pY7JUzgSryeUYlQ F55xcMDe3qqx6vuA2WKMjHdarEsynNACWkXOig9YwwhY7jkvVyZD3eGKBlIPcGqU7mt/VUy8RMg aV1uYwaQlRp1YgrbkXuZhjV8RweWvkUmK+vuYH9Rz8PCgVmmdHCWfEA5kofPvru6V4PMfE0VM6F t9aEv6zr0IRx3xBsWV6P1EQ= X-Google-Smtp-Source: AGHT+IFSjOqhEeeXiJV4CZUukFLud+LZ+cKhSxvBhcfJdaf32GIRFicOUEbicv7Ah7Zu6MZXOndIpw== X-Received: by 2002:a05:6512:2398:b0:545:ee3:f3c7 with SMTP id 2adb3069b0e04-5462eef4e56mr1422130e87.30.1739970037101; Wed, 19 Feb 2025 05:00:37 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f105a3dsm2179515e87.144.2025.02.19.05.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 05:00:35 -0800 (PST) From: Dmitry Baryshkov Date: Wed, 19 Feb 2025 15:00:30 +0200 Subject: [PATCH v3 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250219-dp-hdmi-audio-v3-1-42900f034b40@linaro.org> References: <20250219-dp-hdmi-audio-v3-0-42900f034b40@linaro.org> In-Reply-To: <20250219-dp-hdmi-audio-v3-0-42900f034b40@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Hermes Wu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=7153; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=5tKH69LPnXtw2g2lgp5pOEeBRn775Kcy79G0bglGhPo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBntdXx5Rfpjs7QrSW5Sqc27lyKyEYdNlobBgrno dH0zn3wNMGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ7XV8QAKCRCLPIo+Aiko 1faVCACwzQ+HmZRWj9pVGQ0FxDqNILIlaX1r5rQYmr/5OkHPuBlFez/H2reFj80/208eWC3Jt/F 4w/dszTC6Mavd98pVxDwG4uLrBN4WRB0vz01gg2HJ8A5HflmMSVkzyTKKi3zYgPdL7qbHdTjfKL 7CBu5YlwG2xFNiph1dNcADSY1oOjWZSXDKm5haeaxq6OMz/TLcuRa/72FlA27hrbopzWxhAydDh nP4mmhmTtUhD1ow/wTNud8BRWS7PJ5nLHJ7Gmz43lxg0uKcJ3vS+HorkhfSSmXT1J3rddFOOHpx aMrbBOlYFaZIm7QchyZUQ9R763/xbRGymttkFBrrrv8ir15h X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A As pointed out by Laurent, OP bits are supposed to describe operations. Split DRM_BRIDGE_OP_HDMI_AUDIO from DRM_BRIDGE_OP_HDMI instead of overloading DRM_BRIDGE_OP_HDMI. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- drivers/gpu/drm/display/drm_bridge_connector.c | 59 +++++++++++++++++-----= ---- include/drm/drm_bridge.h | 23 ++++++++-- 3 files changed, 59 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/brid= ge/lontium-lt9611.c index e650cd83fc8d880012edb8a85c69b2f1d378f64c..6cb9039ee7c4720b3512adb5a59= 1b1b84ee32107 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -1134,7 +1134,7 @@ static int lt9611_probe(struct i2c_client *client) lt9611->bridge.of_node =3D client->dev.of_node; lt9611->bridge.ops =3D DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_MODES | - DRM_BRIDGE_OP_HDMI; + DRM_BRIDGE_OP_HDMI | DRM_BRIDGE_OP_HDMI_AUDIO; lt9611->bridge.type =3D DRM_MODE_CONNECTOR_HDMIA; lt9611->bridge.vendor =3D "Lontium"; lt9611->bridge.product =3D "LT9611"; diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/d= rm/display/drm_bridge_connector.c index 30c736fc0067e31a97db242e5b16ea8a5b4cf359..030f98d454608a63154827c65d4= 822d378df3b4c 100644 --- a/drivers/gpu/drm/display/drm_bridge_connector.c +++ b/drivers/gpu/drm/display/drm_bridge_connector.c @@ -98,6 +98,13 @@ struct drm_bridge_connector { * HDMI connector infrastructure, if any (see &DRM_BRIDGE_OP_HDMI). */ struct drm_bridge *bridge_hdmi; + /** + * @bridge_hdmi_audio: + * + * The bridge in the chain that implements necessary support for the + * HDMI Audio infrastructure, if any (see &DRM_BRIDGE_OP_HDMI_AUDIO). + */ + struct drm_bridge *bridge_hdmi_audio; }; =20 #define to_drm_bridge_connector(x) \ @@ -433,7 +440,7 @@ static int drm_bridge_connector_audio_startup(struct dr= m_connector *connector) to_drm_bridge_connector(connector); struct drm_bridge *bridge; =20 - bridge =3D bridge_connector->bridge_hdmi; + bridge =3D bridge_connector->bridge_hdmi_audio; if (!bridge) return -EINVAL; =20 @@ -451,7 +458,7 @@ static int drm_bridge_connector_audio_prepare(struct dr= m_connector *connector, to_drm_bridge_connector(connector); struct drm_bridge *bridge; =20 - bridge =3D bridge_connector->bridge_hdmi; + bridge =3D bridge_connector->bridge_hdmi_audio; if (!bridge) return -EINVAL; =20 @@ -464,7 +471,7 @@ static void drm_bridge_connector_audio_shutdown(struct = drm_connector *connector) to_drm_bridge_connector(connector); struct drm_bridge *bridge; =20 - bridge =3D bridge_connector->bridge_hdmi; + bridge =3D bridge_connector->bridge_hdmi_audio; if (!bridge) return; =20 @@ -478,7 +485,7 @@ static int drm_bridge_connector_audio_mute_stream(struc= t drm_connector *connecto to_drm_bridge_connector(connector); struct drm_bridge *bridge; =20 - bridge =3D bridge_connector->bridge_hdmi; + bridge =3D bridge_connector->bridge_hdmi_audio; if (!bridge) return -EINVAL; =20 @@ -576,6 +583,21 @@ struct drm_connector *drm_bridge_connector_init(struct= drm_device *drm, max_bpc =3D bridge->max_bpc; } =20 + if (bridge->ops & DRM_BRIDGE_OP_HDMI_AUDIO) { + if (bridge_connector->bridge_hdmi_audio) + return ERR_PTR(-EBUSY); + + if (!bridge->hdmi_audio_max_i2s_playback_channels && + !bridge->hdmi_audio_spdif_playback) + return ERR_PTR(-EINVAL); + + if (!bridge->funcs->hdmi_audio_prepare || + !bridge->funcs->hdmi_audio_shutdown) + return ERR_PTR(-EINVAL); + + bridge_connector->bridge_hdmi_audio =3D bridge; + } + if (!drm_bridge_get_next_bridge(bridge)) connector_type =3D bridge->type; =20 @@ -611,22 +633,6 @@ struct drm_connector *drm_bridge_connector_init(struct= drm_device *drm, max_bpc); if (ret) return ERR_PTR(ret); - - if (bridge->hdmi_audio_max_i2s_playback_channels || - bridge->hdmi_audio_spdif_playback) { - if (!bridge->funcs->hdmi_audio_prepare || - !bridge->funcs->hdmi_audio_shutdown) - return ERR_PTR(-EINVAL); - - ret =3D drm_connector_hdmi_audio_init(connector, - bridge->hdmi_audio_dev, - &drm_bridge_connector_hdmi_audio_funcs, - bridge->hdmi_audio_max_i2s_playback_channels, - bridge->hdmi_audio_spdif_playback, - bridge->hdmi_audio_dai_port); - if (ret) - return ERR_PTR(ret); - } } else { ret =3D drmm_connector_init(drm, connector, &drm_bridge_connector_funcs, @@ -635,6 +641,19 @@ struct drm_connector *drm_bridge_connector_init(struct= drm_device *drm, return ERR_PTR(ret); } =20 + if (bridge_connector->bridge_hdmi_audio) { + bridge =3D bridge_connector->bridge_hdmi_audio; + + ret =3D drm_connector_hdmi_audio_init(connector, + bridge->hdmi_audio_dev, + &drm_bridge_connector_hdmi_audio_funcs, + bridge->hdmi_audio_max_i2s_playback_channels, + bridge->hdmi_audio_spdif_playback, + bridge->hdmi_audio_dai_port); + if (ret) + return ERR_PTR(ret); + } + drm_connector_helper_add(connector, &drm_bridge_connector_helper_funcs); =20 if (bridge_connector->bridge_hpd) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 496dbbd2ad7edff7f091adfbe62de1e33ef0cf07..90b7b8070748a104ffca021e669= f78e4d4b993e7 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -693,8 +693,10 @@ struct drm_bridge_funcs { /** * @hdmi_audio_prepare: * Configures HDMI-encoder for audio stream. Can be called multiple - * times for each setup. Mandatory if HDMI audio is enabled in the - * bridge's configuration. + * times for each setup. + * + * This callback is optional but it must be implemented by bridges that + * set the DRM_BRIDGE_OP_HDMI_AUDIO flag in their &drm_bridge->ops. * * Returns: * 0 on success, a negative error code otherwise @@ -707,8 +709,10 @@ struct drm_bridge_funcs { /** * @hdmi_audio_shutdown: * - * Shut down the audio stream. Mandatory if HDMI audio is enabled in - * the bridge's configuration. + * Shut down the audio stream. + * + * This callback is optional but it must be implemented by bridges that + * set the DRM_BRIDGE_OP_HDMI_AUDIO flag in their &drm_bridge->ops. * * Returns: * 0 on success, a negative error code otherwise @@ -814,6 +818,17 @@ enum drm_bridge_ops { * drivers. */ DRM_BRIDGE_OP_HDMI =3D BIT(4), + /** + * @DRM_BRIDGE_OP_HDMI_AUDIO: The bridge provides HDMI audio operations. + * Bridges that set this flag must implement the + * &drm_bridge_funcs->hdmi_audio_prepare and + * &drm_bridge_funcs->hdmi_audio_shutdown callbacks. + * + * Note: currently there can be at most one bridge in a chain that sets + * this bit. This is to simplify corresponding glue code in connector + * drivers. + */ + DRM_BRIDGE_OP_HDMI_AUDIO =3D BIT(5), }; =20 /** --=20 2.39.5 From nobody Fri Dec 19 20:34:13 2025 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADBDC1E51F5 for ; Wed, 19 Feb 2025 13:00:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739970044; cv=none; b=jgKOQdxaaEwjguJGi1l0yzFRjycU6+JLs+eMoe8vdLTOLg25Ir4eslw8gNuzDWXnLQr/wJGaXnnkeW/eeGI4vp7k4Y60sh9NYYa1rvFJX+cpIUv5EIl0ZKChfTchj6U0NMaRoOI3AH/YFI02SVFb2+Xmfa3UkQmJGEeKVRO2wmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739970044; c=relaxed/simple; bh=U/gNytEjj+Osi04cD23DBpgjdETaR5pcolmErPhzGiw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ib/6YHAzdxqHM9rODUD4vzCtsQwf+D5GwQknklScLLrU7H1k7yd6WiJryOOamDFyb5Kuj4kUB3Kw+xiDyDVHQak8ILqbm/q9WtmuiwUnRsoryBiZfREGl7NxAuvYiaoTp2y/mJSldTey21JvWT0IN/HbVOdDihwaR/S3EDworq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eX60bF+o; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eX60bF+o" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-546202d633dso3323746e87.2 for ; Wed, 19 Feb 2025 05:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739970040; x=1740574840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UA/ae65dJcijQfpxVUYtXz0WivRGDbHVcrFLsexPuM8=; b=eX60bF+o3lRoSfuA5in4861U8MhcFa1AElAye8ilWghhgHqe4TZvLY+EGGh2WfUkU3 XPDXT/BEqLAs3by9K5HCXjbGIbnQN+GlFq4iULJ/8M4ECTYM27JXeZOVKu9EZocsC8+T 3/0wrn40A+K+i9Do8PywJhZAGDmjR52LqtYjr3hYY7pMKE7V/EPkQI/m91OOQrdJcOhM VMbAK4EZHo2rE4SbTtyD1M8MWI1rePH+SDlYmuaiNsadWp0V008ZfHRaSfl+lYw5bB4C LkiY+OXvuXaMsmt+ah/m/Fzh0fYNyaAiO1Lvip6TyamCsfFzwkVWn3FlJugFPGBA2/2/ +6cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739970040; x=1740574840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UA/ae65dJcijQfpxVUYtXz0WivRGDbHVcrFLsexPuM8=; b=qzLOuERTfuRg/tWMLR6tN9LR56BNsvRw+c8p5YKYN+mbY7RXteKk6RpL6UGI59b2cu f6n3qAxGbOxEKkzCtGE4BYADic4s98Im5g27evKBVlMUob9wxgtjuINPpBei3q8mMYjK L5IAPdIhOEInnabQewmlZtJjMQQtFNof1w1FVck19WjaOzVMQD6V2G/dLZ1WGa833RjA /hWrIOplR+mqrYvHiXazwjol7C/XrdYT3K5Os7+ajm6B2dPOW0Qx9MsA2DmC7mKFL5+X NQoYuAU9XCmTFf4YfI0YBArvrV25shw5olzVUzKo11eyLpklGRUNPN3ghHlrcXlENswj p5XQ== X-Forwarded-Encrypted: i=1; AJvYcCXjgwxB3HnzFLjbKymtBPvBNMjGQ7lg3OuCksRVYH0V8BiU1Sy54/XfM+FCSGPDrUHVQ9Jo6RZ5ugfoNjw=@vger.kernel.org X-Gm-Message-State: AOJu0YwBOXKHPsqxvedNZ4n7OTgwrj0ArnkQjqKPeJYNIIj/HA7EZ0Pw blk+jLjOCEehXctUNl1cvtEqJkRC4SlC29eYwjABbKcAgDydfHsKALhvHOcDd3I= X-Gm-Gg: ASbGncvMMOlVLWDEiBrWKAe09V5sMgr7xtEhSRH5RjJcYxXnFm2KeKg9L8JlO2EkStD YkN8vJ6KP3XzEbD6McwZRh6gPYMMWTZEKFW7x5eYwVk/z3eiC4OMihY9RBtLpemIMxLIsf4lgff MOhKv4fL054hID/+tx5fSvNwIZ+/ehoq6vK+idNFnlsBfaMiv+QrnBG3HbNvVHATiGnmuw/17il NcjNRZlRZm6d1FB69jlVHKJgQ8WyeaNcDWV1TpOBB5HpVuWYRdq1bnH0HqmK6IiW6FPDAYhQv6A GrGAlqqtFFx2vyO2QJ2EI2U= X-Google-Smtp-Source: AGHT+IF0NxCRIqMiMjlIRg1cehA4e7YLydqlHY3l0rs4umckPwvvAbFoyKQ7w8Ep1YqYWgzRdvT5mA== X-Received: by 2002:a05:6512:a91:b0:545:2302:6835 with SMTP id 2adb3069b0e04-5452fe2e483mr5436482e87.2.1739970039631; Wed, 19 Feb 2025 05:00:39 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f105a3dsm2179515e87.144.2025.02.19.05.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 05:00:38 -0800 (PST) From: Dmitry Baryshkov Date: Wed, 19 Feb 2025 15:00:31 +0200 Subject: [PATCH v3 2/2] drm/msm/dp: reuse generic HDMI codec implementation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250219-dp-hdmi-audio-v3-2-42900f034b40@linaro.org> References: <20250219-dp-hdmi-audio-v3-0-42900f034b40@linaro.org> In-Reply-To: <20250219-dp-hdmi-audio-v3-0-42900f034b40@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Hermes Wu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=13527; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=U/gNytEjj+Osi04cD23DBpgjdETaR5pcolmErPhzGiw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBntdXxmOY9k7pp7KsmMotgjRJHDAeq4qCEyvQ1U PzprxNs3l+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ7XV8QAKCRCLPIo+Aiko 1RmpB/9wz/EEEsNLIjDapowu64y1zRUIiXM8VTH1G+ghO+WMMhuEDZlj/eA4VQ78NBsiFsvpU6T 9ggrfOS7+tQvxL/s37BS2FVi11tqal5WdCyqAiFBl2zN9VG4/gQnWWKlVX76oYZb+e+B4GyZ0+K jTsvoRYKqW8Ou97JMQw+yp/QTS4U5wxEpIek/zTpyGWaLNDZ0IMnd3DerUANjXp0VWylZXAY4yi nZpeu1R1uWYJ6/BTYEmP1H8gOJ7hCYpkRaYcy4szmZxpGqLq8G0BzyTKsx9qY7DhKi9RfREcB7u xcWnbtX2MmozqZ2dOPJzikbfzVhzO8J7UcHj5PEAzTRgtTiR X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The MSM DisplayPort driver implements several HDMI codec functions in the driver, e.g. it manually manages HDMI codec device registration, returning ELD and plugged_cb support. In order to reduce code duplication reuse drm_hdmi_audio_* helpers and drm_bridge_connector integration. As a part of this change, also drop the call to drm_connector_attach_dp_subconnector_property(), it is now being handled by the drm_bridge_connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/dp/dp_audio.c | 131 ++++----------------------------= ---- drivers/gpu/drm/msm/dp/dp_audio.h | 27 ++------ drivers/gpu/drm/msm/dp/dp_display.c | 28 ++------ drivers/gpu/drm/msm/dp/dp_display.h | 6 -- drivers/gpu/drm/msm/dp/dp_drm.c | 8 +++ 6 files changed, 31 insertions(+), 170 deletions(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 7ec833b6d8292f8cb26cfe5582812f2754cd4d35..fe36a3bcfe03994952d1b5e1b42= 3e923e3e3b014 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -104,6 +104,7 @@ config DRM_MSM_DPU config DRM_MSM_DP bool "Enable DisplayPort support in MSM DRM driver" depends on DRM_MSM + select DRM_DISPLAY_HDMI_AUDIO_HELPER select RATIONAL default y help diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c b/drivers/gpu/drm/msm/dp/dp_= audio.c index 70fdc9fe228a7149546accd8479a9e4397f3d5dd..f8bfb908f9b4bf93ad5480f0785= e3aed23dde160 100644 --- a/drivers/gpu/drm/msm/dp/dp_audio.c +++ b/drivers/gpu/drm/msm/dp/dp_audio.c @@ -13,13 +13,13 @@ =20 #include "dp_catalog.h" #include "dp_audio.h" +#include "dp_drm.h" #include "dp_panel.h" #include "dp_reg.h" #include "dp_display.h" #include "dp_utils.h" =20 struct msm_dp_audio_private { - struct platform_device *audio_pdev; struct platform_device *pdev; struct drm_device *drm_dev; struct msm_dp_catalog *catalog; @@ -160,24 +160,11 @@ static void msm_dp_audio_enable(struct msm_dp_audio_p= rivate *audio, bool enable) msm_dp_catalog_audio_enable(catalog, enable); } =20 -static struct msm_dp_audio_private *msm_dp_audio_get_data(struct platform_= device *pdev) +static struct msm_dp_audio_private *msm_dp_audio_get_data(struct msm_dp *m= sm_dp_display) { struct msm_dp_audio *msm_dp_audio; - struct msm_dp *msm_dp_display; - - if (!pdev) { - DRM_ERROR("invalid input\n"); - return ERR_PTR(-ENODEV); - } - - msm_dp_display =3D platform_get_drvdata(pdev); - if (!msm_dp_display) { - DRM_ERROR("invalid input\n"); - return ERR_PTR(-ENODEV); - } =20 msm_dp_audio =3D msm_dp_display->msm_dp_audio; - if (!msm_dp_audio) { DRM_ERROR("invalid msm_dp_audio data\n"); return ERR_PTR(-EINVAL); @@ -186,68 +173,16 @@ static struct msm_dp_audio_private *msm_dp_audio_get_= data(struct platform_device return container_of(msm_dp_audio, struct msm_dp_audio_private, msm_dp_aud= io); } =20 -static int msm_dp_audio_hook_plugged_cb(struct device *dev, void *data, - hdmi_codec_plugged_cb fn, - struct device *codec_dev) -{ - - struct platform_device *pdev; - struct msm_dp *msm_dp_display; - - pdev =3D to_platform_device(dev); - if (!pdev) { - pr_err("invalid input\n"); - return -ENODEV; - } - - msm_dp_display =3D platform_get_drvdata(pdev); - if (!msm_dp_display) { - pr_err("invalid input\n"); - return -ENODEV; - } - - return msm_dp_display_set_plugged_cb(msm_dp_display, fn, codec_dev); -} - -static int msm_dp_audio_get_eld(struct device *dev, - void *data, uint8_t *buf, size_t len) -{ - struct platform_device *pdev; - struct msm_dp *msm_dp_display; - - pdev =3D to_platform_device(dev); - - if (!pdev) { - DRM_ERROR("invalid input\n"); - return -ENODEV; - } - - msm_dp_display =3D platform_get_drvdata(pdev); - if (!msm_dp_display) { - DRM_ERROR("invalid input\n"); - return -ENODEV; - } - - mutex_lock(&msm_dp_display->connector->eld_mutex); - memcpy(buf, msm_dp_display->connector->eld, - min(sizeof(msm_dp_display->connector->eld), len)); - mutex_unlock(&msm_dp_display->connector->eld_mutex); - - return 0; -} - -int msm_dp_audio_hw_params(struct device *dev, - void *data, - struct hdmi_codec_daifmt *daifmt, - struct hdmi_codec_params *params) +int msm_dp_audio_prepare(struct drm_connector *connector, + struct drm_bridge *bridge, + struct hdmi_codec_daifmt *daifmt, + struct hdmi_codec_params *params) { int rc =3D 0; struct msm_dp_audio_private *audio; - struct platform_device *pdev; struct msm_dp *msm_dp_display; =20 - pdev =3D to_platform_device(dev); - msm_dp_display =3D platform_get_drvdata(pdev); + msm_dp_display =3D to_dp_bridge(bridge)->msm_dp_display; =20 /* * there could be cases where sound card can be opened even @@ -262,7 +197,7 @@ int msm_dp_audio_hw_params(struct device *dev, goto end; } =20 - audio =3D msm_dp_audio_get_data(pdev); + audio =3D msm_dp_audio_get_data(msm_dp_display); if (IS_ERR(audio)) { rc =3D PTR_ERR(audio); goto end; @@ -281,15 +216,14 @@ int msm_dp_audio_hw_params(struct device *dev, return rc; } =20 -static void msm_dp_audio_shutdown(struct device *dev, void *data) +void msm_dp_audio_shutdown(struct drm_connector *connector, + struct drm_bridge *bridge) { struct msm_dp_audio_private *audio; - struct platform_device *pdev; struct msm_dp *msm_dp_display; =20 - pdev =3D to_platform_device(dev); - msm_dp_display =3D platform_get_drvdata(pdev); - audio =3D msm_dp_audio_get_data(pdev); + msm_dp_display =3D to_dp_bridge(bridge)->msm_dp_display; + audio =3D msm_dp_audio_get_data(msm_dp_display); if (IS_ERR(audio)) { DRM_ERROR("failed to get audio data\n"); return; @@ -311,47 +245,6 @@ static void msm_dp_audio_shutdown(struct device *dev, = void *data) msm_dp_display_signal_audio_complete(msm_dp_display); } =20 -static const struct hdmi_codec_ops msm_dp_audio_codec_ops =3D { - .hw_params =3D msm_dp_audio_hw_params, - .audio_shutdown =3D msm_dp_audio_shutdown, - .get_eld =3D msm_dp_audio_get_eld, - .hook_plugged_cb =3D msm_dp_audio_hook_plugged_cb, -}; - -static struct hdmi_codec_pdata codec_data =3D { - .ops =3D &msm_dp_audio_codec_ops, - .max_i2s_channels =3D 8, - .i2s =3D 1, -}; - -void msm_dp_unregister_audio_driver(struct device *dev, struct msm_dp_audi= o *msm_dp_audio) -{ - struct msm_dp_audio_private *audio_priv; - - audio_priv =3D container_of(msm_dp_audio, struct msm_dp_audio_private, ms= m_dp_audio); - - if (audio_priv->audio_pdev) { - platform_device_unregister(audio_priv->audio_pdev); - audio_priv->audio_pdev =3D NULL; - } -} - -int msm_dp_register_audio_driver(struct device *dev, - struct msm_dp_audio *msm_dp_audio) -{ - struct msm_dp_audio_private *audio_priv; - - audio_priv =3D container_of(msm_dp_audio, - struct msm_dp_audio_private, msm_dp_audio); - - audio_priv->audio_pdev =3D platform_device_register_data(dev, - HDMI_CODEC_DRV_NAME, - PLATFORM_DEVID_AUTO, - &codec_data, - sizeof(codec_data)); - return PTR_ERR_OR_ZERO(audio_priv->audio_pdev); -} - struct msm_dp_audio *msm_dp_audio_get(struct platform_device *pdev, struct msm_dp_catalog *catalog) { diff --git a/drivers/gpu/drm/msm/dp/dp_audio.h b/drivers/gpu/drm/msm/dp/dp_= audio.h index beea34cbab77f31b33873297dc454a9cee446240..58fc14693e48bff2b57ef727898= 3e5f21ee80ac7 100644 --- a/drivers/gpu/drm/msm/dp/dp_audio.h +++ b/drivers/gpu/drm/msm/dp/dp_audio.h @@ -35,23 +35,6 @@ struct msm_dp_audio { struct msm_dp_audio *msm_dp_audio_get(struct platform_device *pdev, struct msm_dp_catalog *catalog); =20 -/** - * msm_dp_register_audio_driver() - * - * Registers DP device with hdmi_codec interface. - * - * @dev: DP device instance. - * @msm_dp_audio: an instance of msm_dp_audio module. - * - * - * Returns the error code in case of failure, otherwise - * zero on success. - */ -int msm_dp_register_audio_driver(struct device *dev, - struct msm_dp_audio *msm_dp_audio); - -void msm_dp_unregister_audio_driver(struct device *dev, struct msm_dp_audi= o *msm_dp_audio); - /** * msm_dp_audio_put() * @@ -61,10 +44,12 @@ void msm_dp_unregister_audio_driver(struct device *dev,= struct msm_dp_audio *msm */ void msm_dp_audio_put(struct msm_dp_audio *msm_dp_audio); =20 -int msm_dp_audio_hw_params(struct device *dev, - void *data, - struct hdmi_codec_daifmt *daifmt, - struct hdmi_codec_params *params); +int msm_dp_audio_prepare(struct drm_connector *connector, + struct drm_bridge *bridge, + struct hdmi_codec_daifmt *daifmt, + struct hdmi_codec_params *params); +void msm_dp_audio_shutdown(struct drm_connector *connector, + struct drm_bridge *bridge); =20 #endif /* _DP_AUDIO_H_ */ =20 diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 3898850739abb90a777bc94ede0fb0ceef5e5162..adeb9658fbefcd0645785c66031= 8d2325fd3e705 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -12,6 +12,7 @@ #include #include #include +#include #include =20 #include "msm_drv.h" @@ -287,13 +288,6 @@ static int msm_dp_display_bind(struct device *dev, str= uct device *master, goto end; } =20 - - rc =3D msm_dp_register_audio_driver(dev, dp->audio); - if (rc) { - DRM_ERROR("Audio registration Dp failed\n"); - goto end; - } - rc =3D msm_dp_hpd_event_thread_start(dp); if (rc) { DRM_ERROR("Event thread create failed\n"); @@ -315,7 +309,6 @@ static void msm_dp_display_unbind(struct device *dev, s= truct device *master, =20 of_dp_aux_depopulate_bus(dp->aux); =20 - msm_dp_unregister_audio_driver(dev, dp->audio); msm_dp_aux_unregister(dp->aux); dp->drm_dev =3D NULL; dp->aux->drm_dev =3D NULL; @@ -611,9 +604,9 @@ static void msm_dp_display_handle_plugged_change(struct= msm_dp *msm_dp_display, struct msm_dp_display_private, msm_dp_display); =20 /* notify audio subsystem only if sink supports audio */ - if (msm_dp_display->plugged_cb && msm_dp_display->codec_dev && - dp->audio_supported) - msm_dp_display->plugged_cb(msm_dp_display->codec_dev, plugged); + if (dp->audio_supported) + drm_connector_hdmi_audio_plugged_notify(msm_dp_display->connector, + plugged); } =20 static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32= data) @@ -892,19 +885,6 @@ static int msm_dp_display_disable(struct msm_dp_displa= y_private *dp) return 0; } =20 -int msm_dp_display_set_plugged_cb(struct msm_dp *msm_dp_display, - hdmi_codec_plugged_cb fn, struct device *codec_dev) -{ - bool plugged; - - msm_dp_display->plugged_cb =3D fn; - msm_dp_display->codec_dev =3D codec_dev; - plugged =3D msm_dp_display->link_ready; - msm_dp_display_handle_plugged_change(msm_dp_display, plugged); - - return 0; -} - /** * msm_dp_bridge_mode_valid - callback to determine if specified mode is v= alid * @bridge: Pointer to drm bridge structure diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/d= p_display.h index ecbc2d92f546a346ee53adcf1b060933e4f54317..cc6e2cab36e9c0b1527ff292e54= 7cbb4d69fd95c 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.h +++ b/drivers/gpu/drm/msm/dp/dp_display.h @@ -7,7 +7,6 @@ #define _DP_DISPLAY_H_ =20 #include "dp_panel.h" -#include #include "disp/msm_disp_snapshot.h" =20 #define DP_MAX_PIXEL_CLK_KHZ 675000 @@ -15,7 +14,6 @@ struct msm_dp { struct drm_device *drm_dev; struct platform_device *pdev; - struct device *codec_dev; struct drm_connector *connector; struct drm_bridge *next_bridge; bool link_ready; @@ -25,14 +23,10 @@ struct msm_dp { bool is_edp; bool internal_hpd; =20 - hdmi_codec_plugged_cb plugged_cb; - struct msm_dp_audio *msm_dp_audio; bool psr_supported; }; =20 -int msm_dp_display_set_plugged_cb(struct msm_dp *msm_dp_display, - hdmi_codec_plugged_cb fn, struct device *codec_dev); int msm_dp_display_get_modes(struct msm_dp *msm_dp_display); bool msm_dp_display_check_video_test(struct msm_dp *msm_dp_display); int msm_dp_display_get_test_bpp(struct msm_dp *msm_dp_display); diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_dr= m.c index 16b7913d1eefa8c2deb44df201a1977db23f4531..cf2a82c90e7d353757bd242524b= df9655935f5bd 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -11,6 +11,7 @@ =20 #include "msm_drv.h" #include "msm_kms.h" +#include "dp_audio.h" #include "dp_drm.h" =20 /** @@ -113,6 +114,9 @@ static const struct drm_bridge_funcs msm_dp_bridge_ops = =3D { .hpd_disable =3D msm_dp_bridge_hpd_disable, .hpd_notify =3D msm_dp_bridge_hpd_notify, .debugfs_init =3D msm_dp_bridge_debugfs_init, + + .hdmi_audio_prepare =3D msm_dp_audio_prepare, + .hdmi_audio_shutdown =3D msm_dp_audio_shutdown, }; =20 static int msm_edp_bridge_atomic_check(struct drm_bridge *drm_bridge, @@ -322,9 +326,13 @@ int msm_dp_bridge_init(struct msm_dp *msm_dp_display, = struct drm_device *dev, */ if (!msm_dp_display->is_edp) { bridge->ops =3D + DRM_BRIDGE_OP_HDMI_AUDIO | DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_MODES; + bridge->hdmi_audio_dev =3D &msm_dp_display->pdev->dev; + bridge->hdmi_audio_max_i2s_playback_channels =3D 8; + bridge->hdmi_audio_dai_port =3D -1; } =20 rc =3D devm_drm_bridge_add(dev->dev, bridge); --=20 2.39.5