From nobody Fri Dec 19 11:00:31 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 301C41AA78E; Tue, 18 Feb 2025 11:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739878279; cv=none; b=gCk3cQJ0DHiavZtHQLYOezDQUqvVUX6VR3TqqbHPUoA3KZyZajt9r6Qt/5kp10wgpgEZouysq4Sguiaz4xwJNIPYjbJfptI+vqxKRlKATig+bFD1//X56IJy8q8KpnPID8CHb5tx4G4g+7ia8d4pm3ulapE6gUerVN3uNPwo2zs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739878279; c=relaxed/simple; bh=Yj6beW6sKLkkAEK6vgyH9n469bB+jFZfP1IFJr/rjvo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jpiCST6L0lNpA8GQKoIHnzKl63uMtL1SWrr0LX4aKGna23TskPfTl4nJb8QKdCqklHNXGa0smCMujv16gZ5iL2REn8U4KRDjojjE6z2iSeE2EVcoRwXTLFwsAVceWNtFda31oL73HZ6d76bvtHE6CRn7WUSPsubOybO+gps9Y14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=OQv4z9WH; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="OQv4z9WH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=4FvOm NvXTI1y5cNIJEHJDIZaYnjl0e5T3+nNxyHVq0c=; b=OQv4z9WH+tSTkMu9/lOmA x+7K18jmw7bjdYk8/p9fhSOaGQvI51JXsV/kjlqWmleObHG9XmIQNvYcBbwTOZL6 gCsFIvSRCWOBaiZll3pzIptyDdkML25aU+iT4m6JDDoPVtVsPdP83RP75SdZcD1N 9sgPVPAsAlxPA5zbSH2htU= Received: from ProDesk.. (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wD333uybrRnLIPUMQ--.34107S9; Tue, 18 Feb 2025 19:27:57 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, krzk+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, detlev.casanova@collabora.com, daniel@fooishbar.org, robh@kernel.org, sebastian.reichel@collabora.com, Andy Yan , Michael Riesch Subject: [PATCH v15 07/13] drm/rockchip: vop2: Register the primary plane and overlay plane separately Date: Tue, 18 Feb 2025 19:27:34 +0800 Message-ID: <20250218112744.34433-8-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250218112744.34433-1-andyshrk@163.com> References: <20250218112744.34433-1-andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD333uybrRnLIPUMQ--.34107S9 X-Coremail-Antispam: 1Uf129KBjvJXoWxGFWxtw4kKr43tFyrKryxuFg_yoWrZrW3pa 13ta98tr47Wr42gry8JF4UAFWYyan2kay7Crn8Jw1a934Sgr93ur4UKF1DAF1ruFnrWFya kFW7K39Y9FWj9r7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jOgAwUUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbB0hb3Xme0ZO2u0gAAsL Content-Type: text/plain; charset="utf-8" From: Andy Yan In the upcoming VOP of rk3576, a Window cannot attach to all Video Ports, so make sure all VP find it's suitable primary plane, then register the remain windows as overlay plane will make code easier. Signed-off-by: Andy Yan Tested-by: Michael Riesch # on RK3568 Tested-by: Detlev Casanova --- (no changes since v3) Changes in v3: - Add comments for why we should treat rk3566 with special care. drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 100 +++++++++++-------- 1 file changed, 61 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.c index c8c8da63db0f..2c84bac9d88a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -2247,22 +2247,29 @@ static int vop2_plane_init(struct vop2 *vop2, struc= t vop2_win *win, return 0; } =20 -static struct vop2_video_port *find_vp_without_primary(struct vop2 *vop2) +/* + * On RK3566 these windows don't have an independent + * framebuffer. They can only share/mirror the framebuffer + * with smart0, esmart0 and cluster0 respectively. + * And RK3566 share the same vop version with Rk3568, so we + * need to use soc_id for identification here. + */ +static bool vop2_is_mirror_win(struct vop2_win *win) { - int i; - - for (i =3D 0; i < vop2->data->nr_vps; i++) { - struct vop2_video_port *vp =3D &vop2->vps[i]; - - if (!vp->crtc.port) - continue; - if (vp->primary_plane) - continue; + struct vop2 *vop2 =3D win->vop2; =20 - return vp; + if (vop2->data->soc_id =3D=3D 3566) { + switch (win->data->phys_id) { + case ROCKCHIP_VOP2_SMART1: + case ROCKCHIP_VOP2_ESMART1: + case ROCKCHIP_VOP2_CLUSTER1: + return true; + default: + return false; + } + } else { + return false; } - - return NULL; } =20 static int vop2_create_crtcs(struct vop2 *vop2) @@ -2273,7 +2280,9 @@ static int vop2_create_crtcs(struct vop2 *vop2) struct drm_plane *plane; struct device_node *port; struct vop2_video_port *vp; - int i, nvp, nvps =3D 0; + struct vop2_win *win; + u32 possible_crtcs; + int i, j, nvp, nvps =3D 0; int ret; =20 for (i =3D 0; i < vop2_data->nr_vps; i++) { @@ -2312,42 +2321,55 @@ static int vop2_create_crtcs(struct vop2 *vop2) } =20 nvp =3D 0; - for (i =3D 0; i < vop2->registered_num_wins; i++) { - struct vop2_win *win =3D &vop2->win[i]; - u32 possible_crtcs =3D 0; - - if (vop2->data->soc_id =3D=3D 3566) { - /* - * On RK3566 these windows don't have an independent - * framebuffer. They share the framebuffer with smart0, - * esmart0 and cluster0 respectively. - */ - switch (win->data->phys_id) { - case ROCKCHIP_VOP2_SMART1: - case ROCKCHIP_VOP2_ESMART1: - case ROCKCHIP_VOP2_CLUSTER1: + /* Register a primary plane for every crtc */ + for (i =3D 0; i < vop2_data->nr_vps; i++) { + vp =3D &vop2->vps[i]; + + if (!vp->crtc.port) + continue; + + for (j =3D 0; j < vop2->registered_num_wins; j++) { + win =3D &vop2->win[j]; + + /* Aready registered as primary plane */ + if (win->base.type =3D=3D DRM_PLANE_TYPE_PRIMARY) continue; - } - } =20 - if (win->type =3D=3D DRM_PLANE_TYPE_PRIMARY) { - vp =3D find_vp_without_primary(vop2); - if (vp) { + if (vop2_is_mirror_win(win)) + continue; + + if (win->type =3D=3D DRM_PLANE_TYPE_PRIMARY) { possible_crtcs =3D BIT(nvp); vp->primary_plane =3D win; + ret =3D vop2_plane_init(vop2, win, possible_crtcs); + if (ret) { + drm_err(vop2->drm, "failed to init primary plane %s: %d\n", + win->data->name, ret); + return ret; + } nvp++; - } else { - /* change the unused primary window to overlay window */ - win->type =3D DRM_PLANE_TYPE_OVERLAY; + break; } } + } + + /* Register all unused window as overlay plane */ + for (i =3D 0; i < vop2->registered_num_wins; i++) { + win =3D &vop2->win[i]; + + /* Aready registered as primary plane */ + if (win->base.type =3D=3D DRM_PLANE_TYPE_PRIMARY) + continue; + + if (vop2_is_mirror_win(win)) + continue; =20 - if (win->type =3D=3D DRM_PLANE_TYPE_OVERLAY) - possible_crtcs =3D (1 << nvps) - 1; + win->type =3D DRM_PLANE_TYPE_OVERLAY; =20 + possible_crtcs =3D (1 << nvps) - 1; ret =3D vop2_plane_init(vop2, win, possible_crtcs); if (ret) { - drm_err(vop2->drm, "failed to init plane %s: %d\n", + drm_err(vop2->drm, "failed to init overlay plane %s: %d\n", win->data->name, ret); return ret; } --=20 2.34.1