From nobody Fri Dec 19 12:15:01 2025 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 015D722688C for ; Mon, 17 Feb 2025 19:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739821867; cv=none; b=diIBvCwR5WLnHmKIzX+skrxJ66kn/Oj9pp/FHd5XgruCzPWIv7NQae7QHuA+Rqboyoie77m9XIFzDs/x0jQQCeLW7u1AN3lzgT4Mx1g4dVxISoiqgkPz5YpgZHvhphX8l6OWzufUO8wqwMCVoFz7/9eHL+JgoyEAKi+2JVIGG8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739821867; c=relaxed/simple; bh=fvxc2nA5l9IF9nEr97T0t174jPkXXoOp2oMvRCWYwHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kgmPxOd3VmaoCUZGCwBwDLROiLbs/FVaE524Pg2B0B6CeK/xD5q27N3SoRRHxPybY3Hzmnn05xLPUsRuXA+wzZfkBnQw58oLlL/74QMqDzoTL52CVP1Ivy5ejUNTKwcfuKatpc2NqSz5Tuc/nkCnEtM+Su2pZ4BFo1Z/3/DbTBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NW3BwZap; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NW3BwZap" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-220f4dd756eso56453365ad.3 for ; Mon, 17 Feb 2025 11:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739821865; x=1740426665; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yuS0adcc8Fxg+8m6s8u569Uh3Sx/1Cru69GJC1Yskkg=; b=NW3BwZapZkUPftrQYObvogQWDrNjL7pphGUmK+B5O9S8QKXQ6leCscpcYXlfdboJ6u 4ttL6N1W+SDdEwUKh7XGFc4USqleZB342pIbWBl6ODuysY+9x50ngNmBAEAwmNRsED7I XfPld9TOB08T8DjkTeb54WB8uaN+G2+IGURGGhA2UKqwYQQrWlusjntTx+jIDusPKS/K dyi+24OOyePp+tNLUJz5OYnp4cNpDsWH0AVOKKEEsALgaQo86ypd6Y3/IaTTqWkpClWl 0y6Er2ktdvEst5ajtfmwhE1zx8krrRoyGzfTcoBbSgwSTacjZMOfFaN0lju/QV0uH+1x Rdww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739821865; x=1740426665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yuS0adcc8Fxg+8m6s8u569Uh3Sx/1Cru69GJC1Yskkg=; b=Tz7yMowuhITJSEACauOivcgPtGNIHtpXtq1Q09VSaONJPgymHUkZq0S2IJhTKVzKHQ 1EhZUwRrWxosO4IsXiE6kTxNxvHNBIwciTXKc0Q8iUaaj1pFaQY0CmQPGDGFDUMCcET/ 4+CAarbqZPPUU78d+NT5eOuq1irLR5gVqLJeiyTE726e3NCecp89BvG3zXD0GPSY5wUe NJ08tr0M06X0jj5DMfJUFLgn79maRpfvV4EjlR1nEXim6mElP/lOOZl3STgz+5iGoHAl n8oTusDL369ShZ0GAJzx+a83IOELrxXfTSNr5Uj+C6BJMHwWXnPTUO+Ps+yfmh1dwLFr S1ig== X-Forwarded-Encrypted: i=1; AJvYcCWmSd+RVpmsy103VOmmC/mQTIQn+oGG5Hhdi7MTwEnP2NGBnfLiVJ5CvsTgbCxbNftPnwSPDD79pIT+NXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwSrT2fo5hlOpsvqTVzlECjMgYFmT6k86ZQfOlTBd6/rn2RKjqm vSdeI0quSIH6wCB1yXs7nL5PIkg3FF2BbZ4UJB413MlT200tM4aY X-Gm-Gg: ASbGnctOV+VaorirvUKKTsCIb0T5MGPjQ6TMHUbJh6/cmV7/IRWAG8YU328dpKz+C9X Xn0DN3RWbI3+yca7tJfqLLqvPVHZU7QZ3tXGeSPFSxjUcNxuNb8xea5NWYTaIn7fO90WEvKJTMx dL8RL34+oBxJsgviV5q7h7Bs8u2OIajsHd76ztAHbet6b3PoXHtEwTxZ7Q5Ri4QBiXDYQvrEmPB rdZwRp2BI25J+7a5f6l0e/tkXwCnc+jBG6KXy4PJ9AiTFhIwcHzzVyC854K+D4iGO3/UYYFIQOU o3Svp/ZwwRoiVWsyyESR X-Google-Smtp-Source: AGHT+IEZXTjLtFwTNfFx61i+LqglEKU3cBTh4eu1bK0kAaX4GJOeFlHPzDJQh4QCeI77CQd314ubaA== X-Received: by 2002:a17:902:c94d:b0:21f:5cd8:c52 with SMTP id d9443c01a7336-221040eb619mr150146455ad.53.1739821865173; Mon, 17 Feb 2025 11:51:05 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-220d536698fsm74948865ad.91.2025.02.17.11.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 11:51:04 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ravi Kumar Kairi Subject: [PATCH v5 1/3] staging:gpib:agilent_82350b.c: fixed a typo Date: Tue, 18 Feb 2025 01:20:48 +0530 Message-ID: <20250217195050.117167-2-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217195050.117167-1-kumarkairiravi@gmail.com> References: <20250217195050.117167-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi from havn't -> haven't Signed-off-by: Ravi Kumar Kairi Reviewed-by: Dan Carpenter --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 5c62ec24fc..5a74a22015 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -121,7 +121,7 @@ static int agilent_82350b_accel_read(gpib_board_t *boar= d, uint8_t *buffer, size_ writeb(DIRECTION_GPIB_TO_HOST, a_priv->gpib_base + SRAM_ACCESS_CONTROL_RE= G); if (retval < 0) return retval; - // read last bytes if we havn't received an END yet + // read last bytes if we haven't received an END yet if (*end =3D=3D 0) { size_t num_bytes; // try to make sure we holdoff after last byte read --=20 2.48.1 From nobody Fri Dec 19 12:15:01 2025 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A268B237700 for ; Mon, 17 Feb 2025 19:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739821873; cv=none; b=a+qyegakpJllpviThz4erNdGhpjCI84TQigMuh6WY4Ir1YBjs+W94RpetXbBcWxyX25jh1ygUsxEwQzZ5ASGDQngMI3ywV8NEed+m5Lx3mml47WPTg87RdyZNlje+cQQh7bORF9MmL1N5A1Jx2zyjywzVdlCyaQRuymjY0xyJzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739821873; c=relaxed/simple; bh=PYFHK2qhY4SY9e6RMO8PCovA0x+FEn7SE2lUoEUqdMU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eBoxKu+ke7FN1hiuALGdbEk6PlXcGLNbYVeUOrtNMiTbJ2tQYbxPWrK4JR+TCfYkwUCF4FDzFxBzlnnWRh6Nx9BdFBRkliqU0MyKuCBW7OyERW3PEsUP7G7P+wdW7yj4gpR1+uxlIy80+P1KEFv29TyWnNfya14ws6crbBhAJH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i6LoSIZN; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i6LoSIZN" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-220ca204d04so61873805ad.0 for ; Mon, 17 Feb 2025 11:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739821871; x=1740426671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ynx5vOs0fBAJhKdBzwWt5sfNWCPi33ItYttu879rqfI=; b=i6LoSIZNsYb/bzlKZskxtVgjyR40vmDuMedEhYBjW/IAWAL5EgtCHtcs4UxzCA6Bci 8ljO78+fbuzUvBxmOzG00mDtU+1gCWYtjtvcX9lI5uvWEFHd9HPOiJ57x3wRckU9INjU uSX/fZM+t6tuC7qKBPRRmKT1y5K0B8XG7/z9O7dTvehPENTctAu7F9ngeXFzghYvzSCD 0+PaZDxPvT8O8EJ8NsymPJ+B85yxPsDkCMuKbhDO1zt+TC05Qg97Sm0YThWAFOtfSmnZ 641z4k8pF/QMRHQf/B0+mpJj6bd3VZ4TF/pOz/PEEuCZcNQU4rtNzBK3C9ZqLnKVnaUc qpOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739821871; x=1740426671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ynx5vOs0fBAJhKdBzwWt5sfNWCPi33ItYttu879rqfI=; b=L1VFP4MbE8JJzoe0/pD7P0q8AnkqY2xleG+TCVxGfaSOLvMWqkJKd4i/hagTLcE23V 5aeXmB1oA1WXBzl0IAhFraKyXEqcOSdmSNNbzabdstg3kTRbCIH2U7fExUBLBeSpuJDY YXRUvZHsDCz2cKUWuEQNdWZn8OZF17/waXe9SYHz84W/SispLOfGUwjVtwojAZI727Er EXfVMVPxkpoSFceaiUl9aFcEfNweE6Cos1ZEEkG5g0bhj23wlqRl2Dos37b2kCnJk5tB svMHvk7aMn6zV4FORfoNoy+jPE97E3Lzel9xb22jFZaqYfn0TTXaBWDi5XnCxJAlEsGB 3EzQ== X-Forwarded-Encrypted: i=1; AJvYcCWnWw5LRGlj335pR1QiSS3ztBxeQ5zqF9L+twmA4DT4/WKXSZjFyPhUcBZLbjp2I+9Ipy28PAoVO5Z6/rY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkqsd8R1y6NWK19esSLmNLZo4lEWNBGVyDYEK7PZ0Oj+aCQhOL oORBjybzDkrwUUIHl2e5gIbwbSXlJ+mgvn06dmkKPouRj6PEqCyA X-Gm-Gg: ASbGnctMzs6ezSfnYRKOgO++VXOh1WnkrTHyWI0Te9Cagj8/mQIzJSkIvexGoJ1Y2vo VuoPkdGQUyERUyMYUqfXL65eDpJo0omqGHkp5NMFFkBr1nfxidPHgc1RW+T3gxTiAsVHPrITNwK vOw9QwmtDuPCxe2/vkozO2hZN6XfSrbsfewQnzhuJ4S0Yu2v6Xhrcm6VP3kl4NwkCrDy8pNSBxa aLsjqVeinsqIhlGnOSL+tzmfvgZ/CKIOLYqLzmWOLItAVdwi1QDzHRj/pj45udZSId57xOMhLXd l3SPAU+sG8rOxgTq6diR X-Google-Smtp-Source: AGHT+IE7lgYEIV78d38bBQCmeTFGzqO5NRmmXQ0QnMeEkI3+tmRum82E2pf3CSYAYaayIhh2GBM+wg== X-Received: by 2002:a05:6a00:2d9d:b0:730:f1b7:9bc4 with SMTP id d2e1a72fcca58-73261779914mr18081727b3a.4.1739821870715; Mon, 17 Feb 2025 11:51:10 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-7324275bd28sm8480793b3a.122.2025.02.17.11.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 11:51:10 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ravi Kumar Kairi Subject: [PATCH v5 2/3] staging:gpib:agilent_82350b.c: cleaned commented out code Date: Tue, 18 Feb 2025 01:20:49 +0530 Message-ID: <20250217195050.117167-3-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217195050.117167-1-kumarkairiravi@gmail.com> References: <20250217195050.117167-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi cleaned code that was commented out and cleaned blank line that resulted from cleaning out commented code Signed-off-by: Ravi Kumar Kairi Reviewed-by: Dan Carpenter --- .../staging/gpib/agilent_82350b/agilent_82350b.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 5a74a22015..af1bf6e893 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -176,8 +176,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size =20 event_status =3D read_and_clear_event_status(board); =20 - //pr_info("ag_ac_wr: event status 0x%x tms state 0x%lx\n", event_status, = tms_priv->state); - #ifdef EXPERIMENTAL pr_info("ag_ac_wr: wait for previous BO to complete if any\n"); retval =3D wait_event_interruptible(board->wait, @@ -190,14 +188,11 @@ static int agilent_82350b_accel_write(gpib_board_t *b= oard, uint8_t *buffer, size return retval; #endif =20 - //pr_info("ag_ac_wr: sending first byte\n"); retval =3D agilent_82350b_write(board, buffer, 1, 0, &num_bytes); *bytes_written +=3D num_bytes; if (retval < 0) return retval; =20 - //pr_info("ag_ac_wr: %ld bytes eoi %d tms state 0x%lx\n",length, send_eoi= , tms_priv->state); - write_byte(tms_priv, tms_priv->imr0_bits & ~HR_BOIE, IMR0); for (i =3D 1; i < fifotransferlength;) { clear_bit(WRITE_READY_BN, &tms_priv->state); @@ -210,12 +205,8 @@ static int agilent_82350b_accel_write(gpib_board_t *bo= ard, uint8_t *buffer, size } writeb(ENABLE_TI_TO_SRAM, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); =20 - //pr_info("ag_ac_wr: send block: %d bytes tms 0x%lx\n", block_size, - // tms_priv->state); - if (agilent_82350b_fifo_is_halted(a_priv)) { writeb(RESTART_STREAM_BIT, a_priv->gpib_base + STREAM_STATUS_REG); - // pr_info("ag_ac_wr: needed restart\n"); } =20 retval =3D wait_event_interruptible(board->wait, @@ -226,7 +217,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size test_bit(TIMO_NUM, &board->status)); writeb(0, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); num_bytes =3D block_size - read_transfer_counter(a_priv); - //pr_info("ag_ac_wr: sent %ld bytes tms 0x%lx\n", num_bytes, tms_priv->= state); =20 *bytes_written +=3D num_bytes; retval =3D translate_wait_return_value(board, retval); @@ -238,9 +228,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size return retval; =20 if (send_eoi) { - //pr_info("ag_ac_wr: sending last byte with eoi byte no: %d\n", - // fifotransferlength+1); - retval =3D agilent_82350b_write(board, buffer + fifotransferlength, 1, s= end_eoi, &num_bytes); *bytes_written +=3D num_bytes; @@ -284,7 +271,6 @@ static irqreturn_t agilent_82350b_interrupt(int irq, vo= id *arg) tms9914_interrupt_have_status(board, &a_priv->tms9914_priv, tms9914_stat= us1, tms9914_status2); } -//pr_info("event_status=3D0x%x s1 %x s2 %x\n", event_status,tms9914_status= 1,tms9914_status2); //write-clear status bits if (event_status & (BUFFER_END_STATUS_BIT | TERM_COUNT_STATUS_BIT)) { writeb(event_status & (BUFFER_END_STATUS_BIT | TERM_COUNT_STATUS_BIT), --=20 2.48.1 From nobody Fri Dec 19 12:15:01 2025 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E1E02376EA for ; Mon, 17 Feb 2025 19:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739821880; cv=none; b=VP1QQ3nqmeVEqbx+6lAZhdnNuHrI+hS4ORLcQuq/2MuydnCtJG5Oa6lW3CGy0vR1i+RuMKEFDdVw92kQjjqU+eYhnwrbYzkkcp6X2bGvDlgItuhcz1CH8tMfYFKHtSXlxKaCOmTO11satM3ryphbs3QUx2j61LigjDJQv7J1y5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739821880; c=relaxed/simple; bh=5JCtn3HaQ2Y42IOCz0vVF5B+3fj19u+R4j7L/gr3zkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qsRh8ROHUQcitVzKH9dIoqSRYW5oq4x7Bk6xaooQFho8Q6YZP2fDmyaQGh+knZrctMDCuJQQPa3t6uclrbtck6Lx1xih5yQtWWYtCinV6k5Tosaiwc+fAC/2KeL5M9+oSb9Onn8uwMH0dB2uznV2smqxU+s4u+ZGyouxpOWT51M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UBuFN/UL; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UBuFN/UL" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-21c2f1b610dso118812505ad.0 for ; Mon, 17 Feb 2025 11:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739821877; x=1740426677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x+OA47VmynX7pepNmjGGlDQZM/5yLns+ASpEva8XVu8=; b=UBuFN/ULn8me4XBC7IVnNisuhjVmJAZPiXgMT9RUww0JuZ6LN7iHryLuC09+f0Nz7P ZncgiEvjqlOrNNq4Epfme4Bowfbsc7ZR0xX2dTIen35DkRf+yffZhwO9dYXtNZvtBZdK qhbbZux6nEPBOk/87r52bs1TxwE2NVWddSlGxvI5ki1WPIMZwj6yo3DVz7RnVmPUEiv9 D7s1pa5E96+Oew0gaPDTXD4aTNIC9BfFtnmyGcCFM5kCJGRmcjcX2p+g9NgQpVYzCWMg T4IjpeQeUyracRzrNlr2I6H4RVhpeezyn2FtVR1UeCfdW5ft6UgOI1qgB28aZaUvUBtA fDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739821877; x=1740426677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x+OA47VmynX7pepNmjGGlDQZM/5yLns+ASpEva8XVu8=; b=Nsg3+w1TtnasXpS3GvAI7UUqEO94Y4DcvTLWF3AolSttMaDJJakYftbapTpP8VyFIu T+4gRbyiwmLkqWn5ZpP5iFBErQKJVmwlZWtgN1ZvfaAofWy6x8UswEeFEutrZ4vCguhy /y/B4AwDmSoo9nHUYGOSATXIJGUGhx4NOxAjGL6CmppgPsVaCp4vw2lY1ifNv6liqfIu ziWdKDzC9AM0Kc4X/AxsY4LNLBUtUwuzNdHdxr8xC9KXUlJhJ2IBVOHodFAU8coOSDSa 02Bi5z6hG487uH/pZjVRB9HIPp/A71e84YYkpYIxvYiZZkiTTdAswOkeTPKRWEIGN413 Fqxw== X-Forwarded-Encrypted: i=1; AJvYcCWFOxkj51uPcdNfSW4DCNAPxK/rtuUZeXS0d0CrtKan8HrljCmBtivqzWZ9C1AOJNxGTfPvtspDYEbjGN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv19YpHW6kblMIRUZJgSKVM9+ZXQFZ+YvlaB++/J1m+zOMJ445 6YTrIxdbOPFqCT5aVcW5dLlFglFAFvkhX6YVXhCkYmAbgUlld20A X-Gm-Gg: ASbGnctjaaQpV2lHuAscrwVNc9ehLnAllBMsRTvrY/B2nOjLGzD2Q3j9B+MeBqumR2I a5yk9YH2+C8omAhPHBOIMe6qOGXCSxg5sh5QFSV0zHszjhnDYAFyZSRnUv9i5TLK6OPxrjZ9T2z eESqhm01kp24i6OmmNpMQb1zb0APXj2yoxVfZcCY+b1IonHfTlaxXrP7eKmlegz1osMMlmBOR53 0rR3JY9jTx9ha65yq7na6DIKwIs4JMU8PhXjLZps2keXRZ/yYVyW55AbuZHWAFsGYXemUM5V6Iq YOzwuY+CP2HNhELup7Wp X-Google-Smtp-Source: AGHT+IGX/PqH4IdF45LylRY13MTSCdLLYKcQkYQNdNSp6Anjsr80DZAfOnbZoTKi4sYfhLlThW8VjA== X-Received: by 2002:a05:6a00:1256:b0:730:91fc:f9c9 with SMTP id d2e1a72fcca58-732618b0b1dmr18138986b3a.16.1739821876633; Mon, 17 Feb 2025 11:51:16 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-73278d09228sm2811898b3a.117.2025.02.17.11.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 11:51:16 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ravi Kumar Kairi Subject: [PATCH v5 3/3] staging:gpib:agilent_82350b.c: removed braces from a single if statement Date: Tue, 18 Feb 2025 01:20:50 +0530 Message-ID: <20250217195050.117167-4-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217195050.117167-1-kumarkairiravi@gmail.com> References: <20250217195050.117167-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi removed brances from a single line od 'if' block Signed-off-by: Ravi Kumar Kairi Reviewed-by: Dan Carpenter --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index af1bf6e893..0c07745649 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -205,9 +205,8 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size } writeb(ENABLE_TI_TO_SRAM, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); =20 - if (agilent_82350b_fifo_is_halted(a_priv)) { + if (agilent_82350b_fifo_is_halted(a_priv)) writeb(RESTART_STREAM_BIT, a_priv->gpib_base + STREAM_STATUS_REG); - } =20 retval =3D wait_event_interruptible(board->wait, ((event_status =3D --=20 2.48.1