From nobody Sun Feb 8 21:56:15 2026 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D6C101FF for ; Mon, 17 Feb 2025 10:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788268; cv=none; b=fHJu+LIFM4B/pvU9zL4S9K3iMGmw7gXtSXokv23wDsHpagQPXLj2sAJb5m9i0UqOy55XJjiB9rIzQA7AmDmMul2BIr9nQNJffzH98K3S33gepFVpgOh4XEHZN0cx9fstODvXH+ETksa4q8090iOVdMo3t3ePpaVtE7ETnKcqK4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788268; c=relaxed/simple; bh=Gazg7ITlPyeapShlUJWzCmzJ5JDneJIfQIfGTf7Y54c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LaOBDWb/JazSD+kX59i+WMTnWpsmmH2EN0Jhrks8Y2LEuvHMx0VLj6HNKyX8ZMFRd229GrM8n9qHqxvUfW83psddkAbQXnCcDKCluh50TgNJwcsqR9uybaEQ9pMbJ8vBo31SjaI1s/AxPbPYvJdfUBGTFRstvH1El9cI7hscigg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vl5sl5JN; arc=none smtp.client-ip=209.85.216.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vl5sl5JN" Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-2fbf5c2f72dso6384569a91.1 for ; Mon, 17 Feb 2025 02:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739788266; x=1740393066; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ydQlzBFDch5dE0pXTfWbgAH++noP+kxMcP8vl7mV8uY=; b=Vl5sl5JN1glPxn+PdaerernFNGuhzAJuTKAK1kilnIVyUu1ipaLE9DIP0MXoH8upAz +RpHa0nJ7a07e/KFtjc9eeEAz5huXTTUgMVH0Ir6SU4+6KnAAXpMElGF0is4lfmwTrOK RIM0UaVMmvc/5/2N806VhMAKDHBzjjvPHwblTSJb7RGW0Uk+EE29qc0zZ+ulatdbdKBr K/XaqcBkZiZ6Q8H9sQrl+ZYIL8nZtNsRwfiV/qoocZUJs6BTjhTvLq5PK9KEBdSJoNpp fbdp1q3CzFTSlXSzN5MuowlLulDp8cH3p4F+F0MwBWFbgs/yG0fomf1oMe5WqcwsQzgi XFrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739788266; x=1740393066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ydQlzBFDch5dE0pXTfWbgAH++noP+kxMcP8vl7mV8uY=; b=ouU8eGffHRLSIfAm35cLTJK0y18CJ2lyJMyfRWReV9K+LyAiFz/KKoUKnSgtNbfM/k m9t7d+ozKy8K1HOed3Cqd6a/v7l3r0lioj/ixgiFvC2HXQvVTYWHDsm8Y4P1T23K7i+6 gVvhFMxGFZtj6fTbzQO9j0HjQ9RC4TrqjJ7oSXLGKysDnugsFrWsdZe7Pwz284B7pYRm 4XOC5gChTIR1wf7EztWWtbUxOKGq3JN7jMXI3uZm6Q2YXsDSeNOVdBjg1QPfxz9gLPQ/ M5NnCuZB99GMCl9wvjt7/hNml/Fyyw2BoZL+nSpx8lZBQ3aVTWLM2uKYmSnEkOcEh5yk 5SBQ== X-Forwarded-Encrypted: i=1; AJvYcCWZF1RWMNr8oYsX/8VRQ89SX2+bdu6GPZS3p6qpHlBieYcTjWqm+bieStFFD2v0FEwXEvSRC9bsFT8WFFM=@vger.kernel.org X-Gm-Message-State: AOJu0YwANLk2SBcRSGfHqrxBc1AdiD6GHSBkLObt5y9oGn+CMjrBjjn0 tpCklmEVPi2p7DhgcbTjwxmnI25psj1s4s3zB0s6cyZGl2emMvWJiCEsAAOOfvw= X-Gm-Gg: ASbGncsxH9HwrHWrZPOpuyMqk0bfsjFWSfSkNCqCnop/bH1vn8pIhm0IixSrf2tWEih J3sCB+9Er3CC1mKPqzpVU97AlrKi/8pvJA17vtARk/amkyIbKWXao92GWJjz84iXKhTOIsF8ds4 t1NWre46Gj8tQYylFyfEs2GKbLwdoSvJBagR8zjPxqG7GkX6EWoLaBGPKmk/ypzpyylj9zcw7qP 6xRGuHN9/tlYcTS0Z2udwSzmYUJVLUPE6Z6ryvfLf3perAySKYVTkBXxh6KWa8XyvqJQ666dcmL tArRdW3Q1oo0QbPwqX+a X-Google-Smtp-Source: AGHT+IGriBuKKjdznmnIm3vXi8JBeA0sHMkbwBHu5PAMvpDBCNnAb8WFgeAwduFt/lnR9MKJSCHrig== X-Received: by 2002:a17:90b:4f46:b0:2fa:f8d:65e7 with SMTP id 98e67ed59e1d1-2fc40d1318cmr14500264a91.2.1739788266326; Mon, 17 Feb 2025 02:31:06 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2fc3281939asm3807378a91.0.2025.02.17.02.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 02:31:06 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, Ravi Kumar Kairi Subject: [PATCH v3 1/4] [PATCH V2 1/4] staging:gpib:agilent_82350b: Fixed spelling error Date: Mon, 17 Feb 2025 16:00:35 +0530 Message-ID: <20250217103046.54294-2-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217103046.54294-1-kumarkairiravi@gmail.com> References: <20250217103046.54294-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi fixed havn't -> haven't Signed-off-by: Ravi Kumar Kairi --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 5c62ec24fc..5a74a22015 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -121,7 +121,7 @@ static int agilent_82350b_accel_read(gpib_board_t *boar= d, uint8_t *buffer, size_ writeb(DIRECTION_GPIB_TO_HOST, a_priv->gpib_base + SRAM_ACCESS_CONTROL_RE= G); if (retval < 0) return retval; - // read last bytes if we havn't received an END yet + // read last bytes if we haven't received an END yet if (*end =3D=3D 0) { size_t num_bytes; // try to make sure we holdoff after last byte read --=20 2.48.1 From nobody Sun Feb 8 21:56:15 2026 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1134C101FF for ; Mon, 17 Feb 2025 10:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788278; cv=none; b=Ky9gdX4/tVsgXzEGLPcO4qaAqRmo9aZ9BG7ODElvBxDBES/GqIPCcG7hnn57ny0f0q+lk3q1Z3UXBBZwGQy4uhTo00ZO7zXdyOTkEylEz8geKqFOeG17COFljYusC69ftcttUqQp5Xl8wuWcsvZYvpN4v/cwireET89KChxtJ4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788278; c=relaxed/simple; bh=IAOgtSHPmVLoRJLg+8QXPPOSqnpbN/zZE8yNPOkZR4o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KcbSwBbXRLuthByNvFEgTIRblMviNEOw3RCsGejnnDF7nRzZGswoHM0utZ7SD3X3X/d5my3FqXnvbCIdXt0kdsWmdWEGLaz6U+AEMYhNC2HzfXgZxHqk+Tei5DVrm+aXuujfq9jDl4sCLsixPY9Tv3KoDEwYz1o/MxtspxaEFk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aKplP09c; arc=none smtp.client-ip=209.85.216.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aKplP09c" Received: by mail-pj1-f66.google.com with SMTP id 98e67ed59e1d1-2fc1c80cdc8so5603840a91.2 for ; Mon, 17 Feb 2025 02:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739788275; x=1740393075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gon5m/uHwX5/tX/GlOAqTznsXMi3PVn+WonV1pVvztk=; b=aKplP09ccwfxfHdUl/12FLtlfZo9wlaj/0+AXwqcWfZb2wcdmlLDldKH4BSaqpRVyr v0Rg8SCKmqR7+dCubz7vHXFhVRwwK6Hn70lNWqoURYOKgSHR9W7rdreeqngK6tn+GcuQ N8y2dOHrGVu1NyEGx7fea79ZHQrtVr5nABq05iB2doR0r9OmKQfM6Sfecw6uZwmfF6C7 jZLSGY0jU1m/KnYZ7xJl2Y/2vwL3Ng0GRD0sAT1Asl1JMGYpRKw0O9b8Kum1b62v4ugU hrCv93bM032sJqvRqHvLkXFtvr/AL6joqaOhaXkqUnAy+yoCcJC9io6ghQi0rait5uOe sm7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739788275; x=1740393075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gon5m/uHwX5/tX/GlOAqTznsXMi3PVn+WonV1pVvztk=; b=UvXHZQWdsOIE3iutmTwuahclVPCBoke3KAJh7zjpbT9moP8r60UURaPFjhpxcqB6VB XKE3iiFhCC8M4zvfe79LdblcrDeNs4WRtL8lWdnaMiUVJr5oLOZETCYCRnNr17FxofF8 RVAPH4CeQp8c+lOpoYJ0+0BwNUJBB5BvyPXcGXxImZdWpVjngfbycovOdx74aXao6Un8 NrPEkmRLIb6V+warDgoepcDIsaTFDFhTc/+9DZAAscjGGJ/eAmCxUMSSIQ9kQ5iLsec4 j8iuHCo2L3mbC3VUQTvzM7FUl1dwqXYm0FQn/BoWIon+tzeBauF8pLqqHWg1E/4GfG3P dRTQ== X-Forwarded-Encrypted: i=1; AJvYcCWKLD3p2q377Yx6f3VAjx0fDLuc5Fv3k2LEpUOa8sKfWB4AOdL6TezlViTbEm3A8UlpB9g1Cvpq7EkiZNU=@vger.kernel.org X-Gm-Message-State: AOJu0YxBNK1lwyzpC4hkfk0qV8x07hTKdzwXkjbfY2u8ZAybV9/MQvAC bl//XSKyQFxIcaBMwYoGDQE8k/oDiUOsMCIPPhHyJDDJRBTiXVvp X-Gm-Gg: ASbGncueW4qhNByxqMHcYINeg2U/l4D4sQp3ug9iDCH4C6U8zPw/7yuksQzreUNJjEN XwTFw2EVq547VfzTLf2pOkULmhbI+xM1XbfSWnu20G5sohbQx7XHSPSQ52RVdn0Pa5TEiXpWnoK WewV8fxYB5SHjg6tnNVdmKZSDF+Zj+/Yo5avxA8GZfbcjHJV5MdMQYb8kz/mFPXMBn0Lsxaaixr EeX7e/KoLQEg8PbtLLoqEycISOIyfvHw2EcZu3wg0J9rDGib8biOtSh4Ql0C+ciLD0k6HIKoFW+ 3sR7VemiLV1cZf14jyV5 X-Google-Smtp-Source: AGHT+IFmlIM3XT7JkRePyLttLZv7uBkqX4zHAjFsBgxNCqrkB/IRmq4oiv5CJ/mXXvBtEGAUOxSzxA== X-Received: by 2002:a17:90b:3ec5:b0:2ee:7698:e565 with SMTP id 98e67ed59e1d1-2fc40f0f503mr13083882a91.8.1739788273722; Mon, 17 Feb 2025 02:31:13 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2fc13b9125dsm7782624a91.38.2025.02.17.02.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 02:31:13 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, Ravi Kumar Kairi Subject: [PATCH v3 2/4] [PATCH V2 2/4] staging:gpib:agilent_82350b: Removed commented out code Date: Mon, 17 Feb 2025 16:00:36 +0530 Message-ID: <20250217103046.54294-3-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217103046.54294-1-kumarkairiravi@gmail.com> References: <20250217103046.54294-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi Removed commented out debugging code to make code look cleaner as spcified by TODO Signed-off-by: Ravi Kumar Kairi --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 5a74a22015..7936c7285d 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -176,7 +176,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size =20 event_status =3D read_and_clear_event_status(board); =20 - //pr_info("ag_ac_wr: event status 0x%x tms state 0x%lx\n", event_status, = tms_priv->state); =20 #ifdef EXPERIMENTAL pr_info("ag_ac_wr: wait for previous BO to complete if any\n"); @@ -190,13 +189,11 @@ static int agilent_82350b_accel_write(gpib_board_t *b= oard, uint8_t *buffer, size return retval; #endif =20 - //pr_info("ag_ac_wr: sending first byte\n"); retval =3D agilent_82350b_write(board, buffer, 1, 0, &num_bytes); *bytes_written +=3D num_bytes; if (retval < 0) return retval; =20 - //pr_info("ag_ac_wr: %ld bytes eoi %d tms state 0x%lx\n",length, send_eoi= , tms_priv->state); =20 write_byte(tms_priv, tms_priv->imr0_bits & ~HR_BOIE, IMR0); for (i =3D 1; i < fifotransferlength;) { @@ -210,8 +207,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size } writeb(ENABLE_TI_TO_SRAM, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); =20 - //pr_info("ag_ac_wr: send block: %d bytes tms 0x%lx\n", block_size, - // tms_priv->state); =20 if (agilent_82350b_fifo_is_halted(a_priv)) { writeb(RESTART_STREAM_BIT, a_priv->gpib_base + STREAM_STATUS_REG); @@ -226,7 +221,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size test_bit(TIMO_NUM, &board->status)); writeb(0, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); num_bytes =3D block_size - read_transfer_counter(a_priv); - //pr_info("ag_ac_wr: sent %ld bytes tms 0x%lx\n", num_bytes, tms_priv->= state); =20 *bytes_written +=3D num_bytes; retval =3D translate_wait_return_value(board, retval); @@ -238,8 +232,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size return retval; =20 if (send_eoi) { - //pr_info("ag_ac_wr: sending last byte with eoi byte no: %d\n", - // fifotransferlength+1); =20 retval =3D agilent_82350b_write(board, buffer + fifotransferlength, 1, s= end_eoi, &num_bytes); @@ -284,7 +276,6 @@ static irqreturn_t agilent_82350b_interrupt(int irq, vo= id *arg) tms9914_interrupt_have_status(board, &a_priv->tms9914_priv, tms9914_stat= us1, tms9914_status2); } -//pr_info("event_status=3D0x%x s1 %x s2 %x\n", event_status,tms9914_status= 1,tms9914_status2); //write-clear status bits if (event_status & (BUFFER_END_STATUS_BIT | TERM_COUNT_STATUS_BIT)) { writeb(event_status & (BUFFER_END_STATUS_BIT | TERM_COUNT_STATUS_BIT), --=20 2.48.1 From nobody Sun Feb 8 21:56:15 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0176C21770B for ; Mon, 17 Feb 2025 10:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788282; cv=none; b=YPKp2HdnuD2mSEI+TmN2JMJx99WRH4GYEOi3SCKNUrc9wrEHV84eSZ9+h5ZHkhIDiuxRE02P8ZrnDp/CTg82OgcJqEqHl0bRnrgRZcSbgip0jpTFgy96OM/x4L8qsbBkk/AqMG03nENlsdFOVXtkTW6jGE1/CwugppPx0JAYrrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788282; c=relaxed/simple; bh=XO6uPpFukGBucmrCA20btnJlN/3eEn2EL2uIuT8mRyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JUvFyVNMidlqSt0sLVBi6bBsodc05d0ifdBwbSoSb0TEJGVSIfJ6uzGEJYF8K3IU/0ZFTMbFPbSpN8aWs+j1mb5letcsDlsR+cOImqYJbbyh2cdsiZTS3aWqlncW12wJYz/XLGW9Kg35sKxWk/zKEOWAorr8Sg/R2NQUN6FM7dA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ngv0iyS0; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ngv0iyS0" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-220bfdfb3f4so86632385ad.2 for ; Mon, 17 Feb 2025 02:31:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739788280; x=1740393080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6ix2sWH7fK+O3pMFw+ar4SRdhAMLkYoHd95tZujCUw=; b=Ngv0iyS0s6R9QzQiwuBmXa82OnrKfZyCw4hLURJj6oX5K2A4NSR0t5NjluW6wTvYZR 0yfN45T7PX5jtorGidkj36Y3ML24SXdsz8ux1frb0RK+l12SWYZO00d+L3ATeZiIBOXe kaxdh+3IVygjqq5EGyeGl/4pF+2XxxD1u/nPzNmT+pL8NiBMEBFeqclLWXraJOj3CNwz JyBJ/QeclyfLp3cgDM0tJFvPvM3uptK1FLx67mcrN5wmcY+rYG1qCaLlKfHhX6T3q3Af qNzEorTdQ3VAicG8gdrpF0fyoYGVqe3cPuRNuChZGv3QiO82x+qNkm0Hr7Lx+/RWU9UK qmLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739788280; x=1740393080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g6ix2sWH7fK+O3pMFw+ar4SRdhAMLkYoHd95tZujCUw=; b=AyFm24H2Zf/UsgWaQCYRNnVh79PItDs0yDMFaMzuhU+YwwTKeiCibQkar331tbtTyC QV/TZfxFjQocsm1p2qzHMoOfNQieIVVxt5HdHJi0e3xniGWfvsdvpZTpjldvecKG3zdW GRfgYjJhzVLpw8AocBMLTuCKLGgPfokzj6wkPku+IDQ6/l5er0i1RAWWaq5n5oXKxWtp rSgKqiBVQuCdItPREWIitoRR534rcUF/lj7X78uiT9ICUn+S5QhzpZpoRpbMYGNvvAg5 i/xbyPlLADqbNrB5SaWpdP3VZCO/HWM4DwjFWX76h4BHdQzyqE4gn3lNH93xFauoQocN iD5A== X-Forwarded-Encrypted: i=1; AJvYcCUI6VNGyiVOT0Y763SY0aFIeoOwvVV7262woPi9mboo81aO/lACTQNOOA8LvEhB6p66Y9r4lUBrcYM9YGY=@vger.kernel.org X-Gm-Message-State: AOJu0YxBMtrxQSye7u/T/evj0f/l3nBRveNl5Skd9cRc8OknpIF23R1j j6wbG970d5iMmbLEmixsV68+/Yo3UnZyNvqpmkmMPQwpn8txi73Z X-Gm-Gg: ASbGnctfVpjNlHj2JaHJ8DU+KXxNGvI4KrTleJFRiZeBM3jWJDuX9AiHNdZq4QzMLIc wUaH/3yB5ky26qpLJuR1kuT6+Y2ryGA0xr02GZKsTQrLNTQEBZS/qrO6cwqMfpRTwtQl7jle4Zo Y5uROxQFoapwwA10KfrfAxemTdHJLj4mkmZuBUAaLi9SsoZpQKyv4DYyG0W982hOph3zwzA0Wzp CzdyFnbrFq1XakbjJBDKPI0vHmu6rngXIWZJeOm+ihMiNUtpppQSVCUXFJr0uKmqe68i652ru+P cI925XKKJNOfmhtUnBvW X-Google-Smtp-Source: AGHT+IEPOHcTF6hyyEmXMlteolNIm5KtdB7tzEBsHZ2kU7maGDRQ+x6WWVlf11YGDM9J+5Z0UGFesg== X-Received: by 2002:a17:903:41c6:b0:21d:dfae:300c with SMTP id d9443c01a7336-22103efc10cmr136496685ad.3.1739788280168; Mon, 17 Feb 2025 02:31:20 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-220d53491ecsm68412705ad.9.2025.02.17.02.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 02:31:19 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, Ravi Kumar Kairi Subject: [PATCH v3 3/4] [PATCH V2 3/4] staging:gpib:agilent_82350b:Removed blank line Date: Mon, 17 Feb 2025 16:00:37 +0530 Message-ID: <20250217103046.54294-4-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217103046.54294-1-kumarkairiravi@gmail.com> References: <20250217103046.54294-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi removed few empty lines that were causing checkpatch script warnings Signed-off-by: Ravi Kumar Kairi --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 7936c7285d..b6871eb3c8 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -176,7 +176,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size =20 event_status =3D read_and_clear_event_status(board); =20 - #ifdef EXPERIMENTAL pr_info("ag_ac_wr: wait for previous BO to complete if any\n"); retval =3D wait_event_interruptible(board->wait, @@ -193,8 +192,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size *bytes_written +=3D num_bytes; if (retval < 0) return retval; - - write_byte(tms_priv, tms_priv->imr0_bits & ~HR_BOIE, IMR0); for (i =3D 1; i < fifotransferlength;) { clear_bit(WRITE_READY_BN, &tms_priv->state); @@ -207,7 +204,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size } writeb(ENABLE_TI_TO_SRAM, a_priv->gpib_base + SRAM_ACCESS_CONTROL_REG); =20 - if (agilent_82350b_fifo_is_halted(a_priv)) { writeb(RESTART_STREAM_BIT, a_priv->gpib_base + STREAM_STATUS_REG); // pr_info("ag_ac_wr: needed restart\n"); --=20 2.48.1 From nobody Sun Feb 8 21:56:15 2026 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965C7217663 for ; Mon, 17 Feb 2025 10:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788288; cv=none; b=JEW+NnrcgQ4bTIyIKfbfPnqSdGz+CG5ZBEyJ2BU8Pu7rCLe28dDeAUzLH1tz5sgoMHXyuDUUBY4B6UYBfmCgEIlx855+1fgs451DcXAJNdkExZYtVZ6N9GNnY8FCvptVAfqI8oI1D4GhkzsPQyHw64m8YTRR7QrcgGSaefRyPFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788288; c=relaxed/simple; bh=eIbUoOIO/oPlM/ArywSv2GC++LTTbctguFEEFD+IOC8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IrWqzEUjeaKnZlJPPWeE9n7GAP7ME4EWndiJdW/NLXxJwyGqLXVgnTc3gFHR6sc7L9uxnK2DKLcu7Zh2+SRnT8D3tlEgycBdY1ql6rtxNoD+QBCTz5FH0nS/3e5AEprQHY4LzBQ/Y4uI1yeUA27f+Wd9Y1nDhTQ12nm6fir2qBw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OkOsv2HI; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OkOsv2HI" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-220ec47991aso38490395ad.1 for ; Mon, 17 Feb 2025 02:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739788286; x=1740393086; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uMj86FWLmYH9fJq/mESep7lKDCa0pYdVlxGvc/mylb8=; b=OkOsv2HIcuIVrYNm1lAbrdP0/kTznhcuP43iN1Nl3PvrlVdUmPFudwem5O/1/EkQd8 5mI6cVU0l0Z1bxXb2dFI0RxpudppmxI/0O4r5L5zSuLfcXZNrfCHTLAUafJ8Uhos30EP 6+fOuTmDbkgVF8BjECRymOSBZmcyzdAi30NkpwDISQvZpflX7AKmDzKks/VGJu2qf0jy tdbb/fqWWKJqkRneAe1OgF0MGQJg3YolxpyNXbNkTfOZtR4wmZsZC/VjqP37mAR8Sq1d KvHYhrc8JrW79YV4zSXFz4TyX0iac/py5684Lz2IBdfBAAy4QOXOpG6r7ENJd7GlPYhH 8sLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739788286; x=1740393086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uMj86FWLmYH9fJq/mESep7lKDCa0pYdVlxGvc/mylb8=; b=IjymlmUOkVEAku6jlGG33LxaaxLahMY6d3uSh/RrhLgwgaGnwWsr+e2vG9+skAvUEx cYWMAplWRFwyzqwEpbGqnKjX7PJJGPxrMjR6+ncU845q8lZEM+YGZjic/0v+9SGoRtis hF7naxhhuLne7aHO4Xjnme8j6yeX4EP5zIVHGdyMzwkBtLxI24KpjqvwYtr4nZYJmzCJ c8eiwqSjF87FHFh+m4BqoTRLKNuVCeGoQ0hvoghOwbVhZnBKKQbyd4vgQgnnlW7jEFTs GktVsz8w9cim5JI7osGrpQ1eN2WjhJ5eUsSaKenY3TJ3vmLN/CS1IlRnFeDwzMKPzu1a layQ== X-Forwarded-Encrypted: i=1; AJvYcCVsNOVo0B/DroM8pchmOPZYIfRkizRT/mwJNu49OKdX4Zw7rLV5BrbNTuEJK3YPAu5n9h0aFaezLcKyVTc=@vger.kernel.org X-Gm-Message-State: AOJu0YwzHTGLH7FZyljiQmxTNhU0BqvD6zpYEFiYS5USo7N0kyeGOLGE M5r3avMtuN3Iafv9XXNCuBuQgHn16llS5U1xzH0qeEXJFeyMMldx X-Gm-Gg: ASbGncs4HMyaOgri3WWiEavRBJock4p1L1qxp2tMVtKo5Gc+piCiA2eMCUIkTphXbXu XKC3OCuUQc2ltbeUA+o6q2uCFbgON5OawOjoDWx9oBwoJdDaVCOH+e9v2qPnQF6iy/Abmoopeeh /27r+SSz+gZkVm467pI5YZpEZgk5MApiBYMc1ZJrWretTKIfebWWxsshMnRXliQE/VgdGmt4JM0 QEaaj7SvExSyQEFvf2m8vhTr3XU/w0lKOvuUkdvZpOhPNn++SjOSJvcoWs5ryyMFZXnKnbFU93I LtX5LTm1+9XhpgCiHqpi X-Google-Smtp-Source: AGHT+IFxZBzg+LpprLkstU58txPBPKskJUnxyvWBmso/e3hDytAWFtcvj9yLj3ndKgM/HHa9AENsGw== X-Received: by 2002:a17:902:ed03:b0:21f:7077:2aaf with SMTP id d9443c01a7336-2210409d463mr112254205ad.44.1739788286087; Mon, 17 Feb 2025 02:31:26 -0800 (PST) Received: from localhost ([2409:4066:d04:319e:1d76:db25:b6bf:4f52]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-220d53491b3sm67938395ad.40.2025.02.17.02.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 02:31:25 -0800 (PST) From: Ravi Kumar kairi To: dpenkler@gmail.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kuba@kernel.org, dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk, Ravi Kumar Kairi Subject: [PATCH v3 4/4] [PATCH V2 4/4] staging:gpib:agilent_82350b: Fix Indent issue with block Date: Mon, 17 Feb 2025 16:00:38 +0530 Message-ID: <20250217103046.54294-5-kumarkairiravi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217103046.54294-1-kumarkairiravi@gmail.com> References: <20250217103046.54294-1-kumarkairiravi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ravi Kumar Kairi There was a empty line, which was causing the checkpatch script to think it's a single line statment, after removing the empty line it's no longer asking to check that line. Signed-off-by: Ravi Kumar Kairi --- drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index b6871eb3c8..1d644d000a 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -228,7 +228,6 @@ static int agilent_82350b_accel_write(gpib_board_t *boa= rd, uint8_t *buffer, size return retval; =20 if (send_eoi) { - retval =3D agilent_82350b_write(board, buffer + fifotransferlength, 1, s= end_eoi, &num_bytes); *bytes_written +=3D num_bytes; --=20 2.48.1