From nobody Fri Dec 19 06:04:09 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B6084D0E; Mon, 17 Feb 2025 02:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739759773; cv=none; b=jYjPxjS9axVVTAfWvRipVkhEH0vx5ogYU5juIVYirwFRY8EYelZwgWV0Qq8PP8/WuZkZTgDGx46mih8hqHmnnH5SkqummB8RQj06MpPR/hb06nrQCCyYw78e7NcM2cuLArHphmJHvgqb+rKzQB+WDi5nPdcJ5G1farFThmwRfrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739759773; c=relaxed/simple; bh=5Je1TcOPfL5lsh3I7rTPOoi/YIo85AytXCjFmzZDMeA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nBUnalOW/u3FY24pMgiUDhzzB30iiw2X5US+qQz2aSgquIMRGU+Y7Fdp5mKA+bl6/zsKga6tjr3VajJXEYvwc3sRci8Ge6NF03pKVzoGPKn0CfdW7kcrBt11LhQsib6+Gs4IrUh1Mc7jikreFxhudcBbe90pz7Vt/2RZyWglQJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by APP-01 (Coremail) with SMTP id qwCowACnrNCCoLJnHiEBDg--.38765S2; Mon, 17 Feb 2025 10:35:55 +0800 (CST) From: Ma Ke To: bhelgaas@google.com, arnd@arndb.de, treding@nvidia.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Ma Ke , stable@vger.kernel.org Subject: [PATCH v2] PCI: fix reference leak in pci_register_host_bridge() Date: Mon, 17 Feb 2025 10:35:45 +0800 Message-Id: <20250217023545.2248438-1-make24@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowACnrNCCoLJnHiEBDg--.38765S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GF13GrWUGF4kuFy3ZF43Jrb_yoWkArXEgr 109Fy7Zr48G3Zagr13ArnxZrn2k3ZrWrWfGr48tFZ7AayrXFZIg3ZxZryYyr17Can8Zr1D JF1UXr4DCr1I9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb3AFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r 4UJVWxJr1lnxkEFVAIw20F6cxK64vIFxWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG 64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r 1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAq YI8I648v4I1lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x 0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2 zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF 4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU CwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCT nIWIevJa73UjIFyTuYvjfUY3kuUUUUU X-CM-SenderInfo: ppdnvj2u6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" Once device_register() failed, we should call put_device() to decrement reference count for cleanup. Or it could cause memory leak. device_register() includes device_add(). As comment of device_add() says, 'if device_add() succeeds, you should call device_del() when you want to get rid of it. If device_add() has not succeeded, use only put_device() to drop the reference count'. Found by code review. Cc: stable@vger.kernel.org Fixes: 37d6a0a6f470 ("PCI: Add pci_register_host_bridge() interface") Signed-off-by: Ma Ke --- Changes in v2: - modified the patch description. --- drivers/pci/probe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index b6536ed599c3..03dc65cf48f1 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1017,8 +1017,10 @@ static int pci_register_host_bridge(struct pci_host_= bridge *bridge) name =3D dev_name(&bus->dev); =20 err =3D device_register(&bus->dev); - if (err) + if (err) { + put_device(&bus->dev); goto unregister; + } =20 pcibios_add_bus(bus); =20 --=20 2.25.1