From nobody Fri Dec 19 18:48:08 2025 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19C4268FD9 for ; Fri, 14 Feb 2025 17:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739554801; cv=none; b=jK+EHxXrKOiW8RH+iA1fpkYRkx3cm5BHZaRLXHVf9cqtZvdSOxltgPZqD1hL0vq+WJ1hRaMfSO5NV8v9G5MWZc/ojr5gpbr9301pqB8ZNxbgRrjsioOXqKdyYU6eLErp8azho7sDvL5OfmJbHtz+UCQ9PiFoxx6eiN2pTpI22dw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739554801; c=relaxed/simple; bh=XusFJlqd1Zppl59SKwtxO2YRR6ByM8N3PtB0xFQ1r28=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EtBcRmo9wR73OkKH1ivT8dd8coWbL7YD7iNH78wYnBI/SOkjLN55F4jBWihjPA8IKPEUN39wTplXI7yGRuzUrv3JmJdCTcizyynbGmW+K1DOWWLLLq/JdvmpMwMWEGZUKToXW8/Rd4nhL+2qYf7Kul6X82ejv8CW7trr5v0S5xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=aBAPG59F; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aBAPG59F" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7270c259104so545990a34.1 for ; Fri, 14 Feb 2025 09:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1739554799; x=1740159599; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jXbSVytevldhOW6yTI16BOZbfAnBjooyTrFkgreq94E=; b=aBAPG59FjBTI8KReZg3/NyNyh5Huh09xXsNN/x1FJUSy2SZmU4Yc3vpI0Ojht8BTfN ScELWebdlR6YLUrxEenS1m0TVIRRrPG6MUN6RpPygppYJ35ua4Vr6rbrGj8R9r3FWcQn WU1ih2XNqFK1HfNNGMuJZku5SyO6PRM2BTMwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739554799; x=1740159599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jXbSVytevldhOW6yTI16BOZbfAnBjooyTrFkgreq94E=; b=iA4h+r415nwkE/jUlsfs0T/NwidjSto4E7bxF3PdYQnQr+kG/US4xCFBo0j+0HQLBA 7S9+TGBqT9o9Nnpc73NMa0TPo1dqUAhQ3jakeaPfVw68ktA8qA7bs2mrCIILTF3ulbTT ID5cX16kmfqZXLwCrur2pqvuzc/aQUZPiFLfw47+U6m7qp5LR7oGgAT47FFgfVH299Jo HI+qrzZODRl8DoOaueRXKdPH77u5dfDghEc2lk3HZEZDa1F2dFeg6FKK/aP7ejTzf/bs ovDZLGSsoyCb96e8Fv3yJCzqGgUtQt2dNau9+3wyrA8oEaJShFFGIzMfhR5vz13P1U28 vYzg== X-Forwarded-Encrypted: i=1; AJvYcCUZANbM5CQFW/hXuqecMdBYnLua3NuX3D0xQA8JkCJzKgzpH9hWVhETfpvONaxKEt7mJQh5qF/6TN8hfdk=@vger.kernel.org X-Gm-Message-State: AOJu0YxDwOq37KJFe0ceaJNzJNcV+FP9oOALmljur7yHQtvkpOJ/rd7A k1zxweqWcl6e3WOTZzM7BoIjF4CRTa7v8TrOKEwDDhRORmvYBlR/429nIss10A== X-Gm-Gg: ASbGncucaJkHsjlhEBxVIZYoXSqBqE1xXYE4WbCZKSBoU83LN9Zx9mX9Ym+5x9YOdON rrqvelTuWNEK83uYCIWGl7XmqrAKu/I46YjgJKg4lmxCw5nWfuGa7QNs+40QTyvVaX1SlpqnAtD Zbz6P87vdjxGq+geESwMZnXvOWLwqkH+JHaVees9tAzaQrSwWChf4mgkpOovkMfr8IwkTEnJjWG HU2c4VJqYCXFiZ4YFBxwdag7tF8F1/aoO2QatN0snZC0ph1NH3LVK+qQ0yGxo1Ps3DaoOnS0oOl McN8mJO35JPxVIB6vaA0UJhicmO0eJ2I1+LM4+gvkC0vl7TiK2umvwHD3Z4KCwUhcDAEtRg= X-Google-Smtp-Source: AGHT+IHswiwCPm7v4tYhF6/KFpk1Gc9mqP45iu1cae5YdAzQ3o5pgDycSQ+Qw63bZd0jTXMIoI2SqQ== X-Received: by 2002:a05:6830:6e9a:b0:727:ec1:73ad with SMTP id 46e09a7af769-72712043690mr27736a34.11.1739554798795; Fri, 14 Feb 2025 09:39:58 -0800 (PST) Received: from stbsrv-and-02.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fcb17a4ca4sm1284073eaf.30.2025.02.14.09.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 09:39:58 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Andrew Murray , Jeremy Linton , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/8] PCI: brcmstb: Write to internal register to change link cap Date: Fri, 14 Feb 2025 12:39:30 -0500 Message-ID: <20250214173944.47506-3-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250214173944.47506-1-james.quinlan@broadcom.com> References: <20250214173944.47506-1-james.quinlan@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver was mistakenly writing to a RO config-space register (PCI_EXP_LNKCAP). Although harmless in this case, the proper destination is an internal RW register that is reflected by PCI_EXP_LNKCAP. Fixes: c0452137034bda8f686dd9a2e167949bfffd6776 ("PCI: brcmstb: Add Broadco= m STB PCIe host controller driver") Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli Reviewed-by: Manivannan Sadhasivam --- drivers/pci/controller/pcie-brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller= /pcie-brcmstb.c index 64a7511e66a8..98542e74aa16 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -413,10 +413,10 @@ static int brcm_pcie_set_ssc(struct brcm_pcie *pcie) static void brcm_pcie_set_gen(struct brcm_pcie *pcie, int gen) { u16 lnkctl2 =3D readw(pcie->base + BRCM_PCIE_CAP_REGS + PCI_EXP_LNKCTL2); - u32 lnkcap =3D readl(pcie->base + BRCM_PCIE_CAP_REGS + PCI_EXP_LNKCAP); + u32 lnkcap =3D readl(pcie->base + PCIE_RC_CFG_PRIV1_LINK_CAPABILITY); =20 lnkcap =3D (lnkcap & ~PCI_EXP_LNKCAP_SLS) | gen; - writel(lnkcap, pcie->base + BRCM_PCIE_CAP_REGS + PCI_EXP_LNKCAP); + writel(lnkcap, pcie->base + PCIE_RC_CFG_PRIV1_LINK_CAPABILITY); =20 lnkctl2 =3D (lnkctl2 & ~0xf) | gen; writew(lnkctl2, pcie->base + BRCM_PCIE_CAP_REGS + PCI_EXP_LNKCTL2); --=20 2.43.0