From nobody Thu Mar 13 22:54:22 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CA1B263C83 for ; Fri, 14 Feb 2025 11:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739533660; cv=none; b=eVi80Jy4kbyvuAcahH+6G/PRMDS1VKFc4x/VZW32H8qHAum8DEFdccv8De9/jqauYC2AVtmnD2u0HE8e5xbwkVgTVfGhXnksTr8jvUM7rnKANVSZRd20SknGlKg3JOQRw6+I9VHtO0n0lHKijWbwYXp4E4uiW7hImteQlZBe5UE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739533660; c=relaxed/simple; bh=X+nJhhbvM7TnzxSU0DL7DSyPTH6mocEcz+Fkw0E2sKY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KF1tR6imVMUhXKv5JOUbFKFubg16EFLZLjUZRsfupaN96RBMn2mYdcmIDLjMKj65I1srVPRe5OQjIhfx07YODndmoDZI+93jD8QNSPM9VarmQouaTcgDXVdgci2Q7PTndWq/KGKskOCWxtvTRbHJALaFUOHeLneiP0Ud7zJTioM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WZXIEqHb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WZXIEqHb" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43690d4605dso12618855e9.0 for ; Fri, 14 Feb 2025 03:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739533656; x=1740138456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4a7gByrXb25kpqHP6rNbVvJB6IRS3q8+97gsHt/ID/M=; b=WZXIEqHbewyZolapbisTWuqbOXbVr4qEYzGIoJ8zCPyLJLwOSKDShdK56VY12UgIO6 dG3lwkhM77Uukr8F5+eQkqKaLi3iaQIipl0vFfVpEbmQUkmfgofBMVllgMD/8ddKU9g2 WeN5I8lJngrsGDI+HXTAiQ2N4eREelv+N8zYLuNRKejzEWdkTiOcfTs1s11nXOQO6FIq cUSsOHbKqTAw77QgX+l27yKxemu7QrbqaQM6cv29LQQ1lLTxMqSaW2EhA0SpSXF3oyAY dtos/qzWK1RISJiR7IDk9PLOsG2efl8pWbWkMWKpNXywJeMTLhie5y8kTOC/jULtu6fH GkrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739533656; x=1740138456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4a7gByrXb25kpqHP6rNbVvJB6IRS3q8+97gsHt/ID/M=; b=v5SGxq5m1hNh8MxsSHMIiyKLoCP5POUFbIVRDHzE0J8tnj285MD5lfkgUX6jsnrGgU BnR1be4mvwNr0ZtKeNQPkKGA14x8Uk1tHz3zUG77JUuxj0tYOdJZXEbA1qsVzEthWzEP xpT4pn0qfZnwEcD1drrue5B+1mFavRJ4cnvKaabEy6X9/2PEMNmVsQU9ZIMTQeduJ4K0 lEsewmchJsNo0eBgmxtAizOK4pG95+L4gIITPT3IxwgmpQFBRbvva5cymyLIyQQSI2ao dS3c+Fen99luAvm/nQb3g+PQGQ0AvmMnNaT/4AyGKlAVM5xJWYWzbK3AACVHt/u8XM2p MBsA== X-Forwarded-Encrypted: i=1; AJvYcCXV/4kbvzi5a7hQeBOt2lmMLwMRnDHRdf/mrL7z8fx7luYM/MEoexSgeiHbHYns91LWOO4K87KafsPxQ9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzWEjrblj5a3w4ZUjrJWZ970o0F0r5sQOalQltyUj+0nRgfVN7P E2wmz2BWLTZKWxscoY0cnyRleYxF8typfKFfBXw+Pt8QLPnkLFeT X-Gm-Gg: ASbGncse5EwJfhwD8y72bnEeumHK6Zvn9Mb6q9CKmdH0ZgQbrq1gxD2Ic/VvV1BdpZG nfjJixOsgT+WM94M+zFfPmwInnTILvaB2xoBQAZoEwMmxZqi7ct99VBmz2M498pocONyrMd4CsA Q3JhjBzIbO1RDVXCoz5akBt/HfgAcMgQLkBmr8sIbwTV5SyDdKPLe2XkcBUADezJdfuDAYffrwR MYZWPM4VP/K/pcRRSnrCAY5/Am0N9Uq2zkCJxc47Q5/V4xkeaJJJYcoGPzY4xlXv0R64AIQz4os 57AnugVLxoSUYG+CE65RTOVGQHMcANoeXjpQTkmWkE6KATFyl+E= X-Google-Smtp-Source: AGHT+IE1AeZVoiLEXdqP4+VloGplXVda2AU8DFuNHD7oIH58wW4sEZXJ6ziiXtNQ7i7ywiZ4PpFKaA== X-Received: by 2002:a05:600c:34cc:b0:439:4376:cc0 with SMTP id 5b1f17b1804b1-439601a9011mr77141425e9.25.1739533656221; Fri, 14 Feb 2025 03:47:36 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439617fccfesm41945245e9.11.2025.02.14.03.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 03:47:35 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler Subject: [PATCH 03/17] staging: gpib: cb7210 console messaging cleanup Date: Fri, 14 Feb 2025 12:46:54 +0100 Message-ID: <20250214114708.28947-4-dpenkler@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250214114708.28947-1-dpenkler@gmail.com> References: <20250214114708.28947-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Enable module name to be printed in pr_xxx and dev_xxx Use DRV_NAME defined as KBUILD_MODNAME instead of hard coded string "cb7210" everywhere. Remove "cb7210:" string prefix in messages since module name printing is enabled. Change pr_err to dev_err where possible. Remove interrupt warnings. Return consistent error codes with error messages: -EBUSY when resources are busy -ENODEV when device is not present -EIO for others. Return -ENOMEM for failed kmalloc (no message in driver) Remove PCMCIA debug comments, PCMCIA_DEBUG conditional compilation symbol, the DEBUG macro definition and its uses. Change pr_warn to dev_warn and pr_err to dev_err where possible. Remove commented printk. Signed-off-by: Dave Penkler --- drivers/staging/gpib/cb7210/cb7210.c | 133 +++++++++++---------------- 1 file changed, 52 insertions(+), 81 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index cb0d8a721687..f2afd851682e 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -5,6 +5,10 @@ * copyright : (C) 2001, 2002 by Frank Mori Hess *************************************************************************= **/ =20 +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#define dev_fmt pr_fmt +#define DRV_NAME KBUILD_MODNAME + #include "cb7210.h" #include #include @@ -83,12 +87,12 @@ static int fifo_read(gpib_board_t *board, struct cb7210= _priv *cb_priv, uint8_t * =20 *bytes_read =3D 0; if (cb_priv->fifo_iobase =3D=3D 0) { - pr_err("cb7210: fifo iobase is zero!\n"); + dev_err(board->gpib_dev, "fifo iobase is zero!\n"); return -EIO; } *end =3D 0; if (length <=3D cb7210_fifo_size) { - pr_err("cb7210: bug! %s with length < fifo size\n", __func__); + dev_err(board->gpib_dev, " bug! fifo read length < fifo size\n"); return -EINVAL; } =20 @@ -103,7 +107,6 @@ static int fifo_read(gpib_board_t *board, struct cb7210= _priv *cb_priv, uint8_t * test_bit(RECEIVED_END_BN, &nec_priv->state) || test_bit(DEV_CLEAR_BN, &nec_priv->state) || test_bit(TIMO_NUM, &board->status))) { - pr_warn("cb7210: fifo half full wait interrupted\n"); retval =3D -ERESTARTSYS; nec7210_set_reg_bits(nec_priv, IMR2, HR_DMAI, 0); break; @@ -153,7 +156,6 @@ static int fifo_read(gpib_board_t *board, struct cb7210= _priv *cb_priv, uint8_t * test_bit(RECEIVED_END_BN, &nec_priv->state) || test_bit(DEV_CLEAR_BN, &nec_priv->state) || test_bit(TIMO_NUM, &board->status))) { - pr_warn("cb7210: fifo half full wait interrupted\n"); retval =3D -ERESTARTSYS; } if (test_bit(TIMO_NUM, &board->status)) @@ -188,7 +190,6 @@ static int cb7210_accel_read(gpib_board_t *board, uint8= _t *buffer, test_bit(READ_READY_BN, &nec_priv->state) || test_bit(DEV_CLEAR_BN, &nec_priv->state) || test_bit(TIMO_NUM, &board->status))) { - pr_warn("cb7210: read ready wait interrupted\n"); return -ERESTARTSYS; } if (test_bit(TIMO_NUM, &board->status)) @@ -274,7 +275,7 @@ static int fifo_write(gpib_board_t *board, uint8_t *buf= fer, size_t length, size_ =20 *bytes_written =3D 0; if (cb_priv->fifo_iobase =3D=3D 0) { - pr_err("cb7210: fifo iobase is zero!\n"); + dev_err(board->gpib_dev, "fifo iobase is zero!\n"); return -EINVAL; } if (length =3D=3D 0) @@ -293,7 +294,6 @@ static int fifo_write(gpib_board_t *board, uint8_t *buf= fer, size_t length, size_ test_bit(DEV_CLEAR_BN, &nec_priv->state) || test_bit(BUS_ERROR_BN, &nec_priv->state) || test_bit(TIMO_NUM, &board->status))) { - pr_warn("cb7210: fifo wait interrupted\n"); retval =3D -ERESTARTSYS; break; } @@ -309,7 +309,7 @@ static int fifo_write(gpib_board_t *board, uint8_t *buf= fer, size_t length, size_ if (num_bytes + count > length) num_bytes =3D length - count; if (num_bytes % cb7210_fifo_width) { - pr_err("cb7210: bug! %s with odd number of bytes\n", __func__); + dev_err(board->gpib_dev, " bug! fifo write with odd number of bytes\n"); retval =3D -EINVAL; break; } @@ -334,7 +334,6 @@ static int fifo_write(gpib_board_t *board, uint8_t *buf= fer, size_t length, size_ test_bit(DEV_CLEAR_BN, &nec_priv->state) || test_bit(BUS_ERROR_BN, &nec_priv->state) || test_bit(TIMO_NUM, &board->status))) { - pr_err("cb7210: wait for last byte interrupted\n"); retval =3D -ERESTARTSYS; } if (test_bit(TIMO_NUM, &board->status)) @@ -482,7 +481,7 @@ static irqreturn_t cb7210_internal_interrupt(gpib_board= _t *board) status2 =3D read_byte(nec_priv, ISR2); nec7210_interrupt_have_status(board, nec_priv, status1, status2); =20 - dev_dbg(board->gpib_dev, "cb7210: status 0x%x, mode 0x%x\n", hs_status, p= riv->hs_mode_bits); + dev_dbg(board->gpib_dev, "status 0x%x, mode 0x%x\n", hs_status, priv->hs_= mode_bits); =20 clear_bits =3D 0; =20 @@ -860,7 +859,7 @@ static int cb7210_allocate_private(gpib_board_t *board) =20 board->private_data =3D kmalloc(sizeof(struct cb7210_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; memset(priv, 0, sizeof(struct cb7210_priv)); init_nec7210_private(&priv->nec7210_priv); @@ -922,7 +921,7 @@ static int cb7210_init(struct cb7210_priv *cb_priv, gpi= b_board_t *board) =20 /* poll so we can detect assertion of ATN */ if (gpib_request_pseudo_irq(board, cb_pci_interrupt)) { - pr_err("pc2_gpib: failed to allocate pseudo_irq\n"); + pr_err("failed to allocate pseudo_irq\n"); return -1; } return 0; @@ -962,17 +961,17 @@ static int cb_pci_attach(gpib_board_t *board, const g= pib_board_config_t *config) } } if (!cb_priv->pci_device) { - pr_warn("cb7210: no supported boards found.\n"); - return -1; + dev_err(board->gpib_dev, "no supported boards found.\n"); + return -ENODEV; } =20 if (pci_enable_device(cb_priv->pci_device)) { - pr_err("cb7210: error enabling pci device\n"); - return -1; + dev_err(board->gpib_dev, "error enabling pci device\n"); + return -EIO; } =20 - if (pci_request_regions(cb_priv->pci_device, "cb7210")) - return -1; + if (pci_request_regions(cb_priv->pci_device, DRV_NAME)) + return -EBUSY; switch (cb_priv->pci_chip) { case PCI_CHIP_AMCC_S5933: cb_priv->amcc_iobase =3D pci_resource_start(cb_priv->pci_device, 0); @@ -984,13 +983,14 @@ static int cb_pci_attach(gpib_board_t *board, const g= pib_board_config_t *config) cb_priv->fifo_iobase =3D nec_priv->iobase; break; default: - pr_err("cb7210: bug! unhandled pci_chip=3D%i\n", cb_priv->pci_chip); + dev_err(board->gpib_dev, "bug! unhandled pci_chip=3D%i\n", cb_priv->pci_= chip); return -EIO; } isr_flags |=3D IRQF_SHARED; - if (request_irq(cb_priv->pci_device->irq, cb_pci_interrupt, isr_flags, "c= b7210", board)) { - pr_err("cb7210: can't request IRQ %d\n", cb_priv->pci_device->irq); - return -1; + if (request_irq(cb_priv->pci_device->irq, cb_pci_interrupt, isr_flags, DR= V_NAME, board)) { + dev_err(board->gpib_dev, "can't request IRQ %d\n", + cb_priv->pci_device->irq); + return -EBUSY; } cb_priv->irq =3D cb_priv->pci_device->irq; =20 @@ -1045,20 +1045,22 @@ static int cb_isa_attach(gpib_board_t *board, const= gpib_board_config_t *config) return retval; cb_priv =3D board->private_data; nec_priv =3D &cb_priv->nec7210_priv; - if (!request_region(config->ibbase, cb7210_iosize, "cb7210")) { - pr_err("gpib: ioports starting at 0x%x are already in use\n", config->ib= base); - return -EIO; + if (!request_region(config->ibbase, cb7210_iosize, DRV_NAME)) { + dev_err(board->gpib_dev, "ioports starting at 0x%x are already in use\n", + config->ibbase); + return -EBUSY; } nec_priv->iobase =3D config->ibbase; cb_priv->fifo_iobase =3D nec7210_iobase(cb_priv); =20 bits =3D irq_bits(config->ibirq); if (bits =3D=3D 0) - pr_err("board incapable of using irq %i, try 2-5, 7, 10, or 11\n", confi= g->ibirq); + dev_err(board->gpib_dev, "board incapable of using irq %i, try 2-5, 7, 1= 0, or 11\n", + config->ibirq); =20 // install interrupt handler - if (request_irq(config->ibirq, cb7210_interrupt, isr_flags, "cb7210", boa= rd)) { - pr_err("gpib: can't request IRQ %d\n", config->ibirq); + if (request_irq(config->ibirq, cb7210_interrupt, isr_flags, DRV_NAME, boa= rd)) { + dev_err(board->gpib_dev, "failed to obtain IRQ %d\n", config->ibirq); return -EBUSY; } cb_priv->irq =3D config->ibirq; @@ -1098,7 +1100,7 @@ static const struct pci_device_id cb7210_pci_table[] = =3D { MODULE_DEVICE_TABLE(pci, cb7210_pci_table); =20 static struct pci_driver cb7210_pci_driver =3D { - .name =3D "cb7210", + .name =3D DRV_NAME, .id_table =3D cb7210_pci_table, .probe =3D &cb7210_pci_probe }; @@ -1121,23 +1123,6 @@ static struct pci_driver cb7210_pci_driver =3D { #include #include =20 -/* - * All the PCMCIA modules use PCMCIA_DEBUG to control debugging. If - * you do not define PCMCIA_DEBUG at all, all the debug code will be - * left out. If you compile with PCMCIA_DEBUG=3D0, the debug code will - * be present but disabled -- but it can then be enabled for specific - * modules at load time with a 'pc_debug=3D#' option to insmod. - */ - -#define PCMCIA_DEBUG 1 - -#ifdef PCMCIA_DEBUG -static int pc_debug =3D PCMCIA_DEBUG; -#define DEBUG(n, args...) do {if (pc_debug > (n)) pr_debug(args); } while = (0) -#else -#define DEBUG(args...) -#endif - /* * The event() function is this driver's Card Services event handler. * It will be called by Card Services when an appropriate card status @@ -1202,8 +1187,6 @@ static int cb_gpib_probe(struct pcmcia_device *link) =20 // int ret, i; =20 - DEBUG(0, "%s(0x%p)\n", __func__, link); - /* Allocate space for private device-specific data */ info =3D kzalloc(sizeof(*info), GFP_KERNEL); if (!info) @@ -1243,8 +1226,6 @@ static void cb_gpib_remove(struct pcmcia_device *link) struct local_info *info =3D link->priv; //struct gpib_board_t *dev =3D info->dev; =20 - DEBUG(0, "%s(0x%p)\n", __func__, link); - if (info->dev) cb_pcmcia_detach(info->dev); cb_gpib_release(link); @@ -1272,7 +1253,6 @@ static int cb_gpib_config(struct pcmcia_device *link) =20 handle =3D link; dev =3D link->priv; - DEBUG(0, "%s(0x%p)\n", __func__, link); =20 retval =3D pcmcia_loop_config(link, &cb_gpib_config_iteration, NULL); if (retval) { @@ -1281,8 +1261,6 @@ static int cb_gpib_config(struct pcmcia_device *link) return -ENODEV; } =20 - DEBUG(0, "gpib_cs: manufacturer: 0x%x card: 0x%x\n", link->manf_id, link-= >card_id); - /* * This actually configures the PCMCIA socket -- setting up * the I/O windows and the interrupt mapping. @@ -1294,7 +1272,6 @@ static int cb_gpib_config(struct pcmcia_device *link) return -ENODEV; } =20 - pr_info("gpib device loaded\n"); return 0; } /* gpib_config */ =20 @@ -1306,7 +1283,6 @@ static int cb_gpib_config(struct pcmcia_device *link) =20 static void cb_gpib_release(struct pcmcia_device *link) { - DEBUG(0, "%s(0x%p)\n", __func__, link); pcmcia_disable_device(link); } =20 @@ -1314,10 +1290,9 @@ static int cb_gpib_suspend(struct pcmcia_device *lin= k) { //struct local_info *info =3D link->priv; //struct gpib_board_t *dev =3D info->dev; - DEBUG(0, "%s(0x%p)\n", __func__, link); =20 if (link->open) - pr_warn("Device still open ???\n"); + dev_warn(&link->dev, "Device still open\n"); //netif_device_detach(dev); =20 return 0; @@ -1327,11 +1302,9 @@ static int cb_gpib_resume(struct pcmcia_device *link) { //struct local_info *info =3D link->priv; //struct gpib_board_t *dev =3D info->dev; - DEBUG(0, "%s(0x%p)\n", __func__, link); =20 /*if (link->open) { * ni_gpib_probe(dev); / really? - * printk("Gpib resumed ???\n"); * //netif_device_attach(dev); * */ @@ -1358,7 +1331,6 @@ static struct pcmcia_driver cb_gpib_cs_driver =3D { =20 static void cb_pcmcia_cleanup_module(void) { - DEBUG(0, "cb_gpib_cs: unloading\n"); pcmcia_unregister_driver(&cb_gpib_cs_driver); } =20 @@ -1453,8 +1425,8 @@ static int cb_pcmcia_attach(gpib_board_t *board, cons= t gpib_board_config_t *conf int retval; =20 if (!curr_dev) { - pr_err("no cb pcmcia cards found\n"); - return -1; + dev_err(board->gpib_dev, "no cb pcmcia cards found\n"); + return -ENODEV; } =20 retval =3D cb7210_generic_attach(board); @@ -1465,18 +1437,17 @@ static int cb_pcmcia_attach(gpib_board_t *board, co= nst gpib_board_config_t *conf nec_priv =3D &cb_priv->nec7210_priv; =20 if (!request_region(curr_dev->resource[0]->start, resource_size(curr_dev-= >resource[0]), - "cb7210")) { - pr_err("gpib: ioports starting at 0x%lx are already in use\n", - (unsigned long)curr_dev->resource[0]->start); - return -EIO; + DRV_NAME)) { + dev_err(board->gpib_dev, "ioports starting at 0x%lx are already in use\n= ", + (unsigned long)curr_dev->resource[0]->start); + return -EBUSY; } nec_priv->iobase =3D curr_dev->resource[0]->start; cb_priv->fifo_iobase =3D curr_dev->resource[0]->start; =20 - if (request_irq(curr_dev->irq, cb7210_interrupt, IRQF_SHARED, - "cb7210", board)) { - pr_err("cb7210: failed to request IRQ %d\n", curr_dev->irq); - return -1; + if (request_irq(curr_dev->irq, cb7210_interrupt, IRQF_SHARED, DRV_NAME, b= oard)) { + dev_err(board->gpib_dev, "failed to request IRQ %d\n", curr_dev->irq); + return -EBUSY; } cb_priv->irq =3D curr_dev->irq; =20 @@ -1509,68 +1480,68 @@ static int __init cb7210_init_module(void) =20 ret =3D pci_register_driver(&cb7210_pci_driver); if (ret) { - pr_err("cb7210: pci_register_driver failed: error =3D %d\n", ret); + pr_err("pci_register_driver failed: error =3D %d\n", ret); return ret; } =20 ret =3D gpib_register_driver(&cb_pci_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_pci; } =20 ret =3D gpib_register_driver(&cb_isa_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_isa; } =20 ret =3D gpib_register_driver(&cb_pci_accel_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_pci_accel; } =20 ret =3D gpib_register_driver(&cb_pci_unaccel_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_pci_unaccel; } =20 ret =3D gpib_register_driver(&cb_isa_accel_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_isa_accel; } =20 ret =3D gpib_register_driver(&cb_isa_unaccel_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_isa_unaccel; } =20 #ifdef CONFIG_GPIB_PCMCIA ret =3D gpib_register_driver(&cb_pcmcia_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_pcmcia; } =20 ret =3D gpib_register_driver(&cb_pcmcia_accel_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_pcmcia_accel; } =20 ret =3D gpib_register_driver(&cb_pcmcia_unaccel_interface, THIS_MODULE); if (ret) { - pr_err("cb7210: gpib_register_driver failed: error =3D %d\n", ret); + pr_err("gpib_register_driver failed: error =3D %d\n", ret); goto err_pcmcia_unaccel; } =20 ret =3D pcmcia_register_driver(&cb_gpib_cs_driver); if (ret) { - pr_err("cb7210: pcmcia_register_driver failed: error =3D %d\n", ret); + pr_err("pcmcia_register_driver failed: error =3D %d\n", ret); goto err_pcmcia_driver; } #endif --=20 2.48.1