From nobody Fri Dec 19 20:54:50 2025 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47ADE227E90 for ; Thu, 13 Feb 2025 11:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739446091; cv=none; b=K+y0Ff9JwN5j/mq9l8jMaQrPOKUGhFr3cDoAIaOPAPagfEmrn0o7Px/m3eqLCuCOTsq2lj6i3xA563n/wdTd6x2RX6W5t8gZrcRFfgGzcEFsXUCzxV8Cs8PWKUU/HdNRYRSoUt/eS9W1sF2BEVU+SIBVFnH0VeVyFARE/ZpfmyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739446091; c=relaxed/simple; bh=X2bmPGoKkHuDg8cYWq8SnBf/6/7pmLUfnDFqPHvOZ0g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BDTN6ttImAUFQpHEfzIp9AB1tO8xwsuR7hcLol7sTaipY+L/17Ghem6e02j5xwaNQyIo7VEzHTMJ+y99EadEsaqCOzdxnRrZpH9m9fnYPDbNWpoQldyn19dJuxzNEizlm2Y7FK1D5WCRLiqqLyWXtXM3+OVJRsQG4qSZodeXNQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=UqyeZ25X; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="UqyeZ25X" Received: from ldvnode.intra.ispras.ru (unknown [10.10.2.153]) by mail.ispras.ru (Postfix) with ESMTPSA id 6F2844226E07; Thu, 13 Feb 2025 11:28:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 6F2844226E07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1739446086; bh=NBjVF3pUP7QFgRHJmaW5T9LW35eN83jOLIfzLRGqYek=; h=From:To:Cc:Subject:Date:From; b=UqyeZ25XgLnLDnU5lA+jWmuz+QkDotd96ydS7w70fCrpO/g+S12Xa9WCDAYTGQesA tYVmO3BlIuIIDN8KBWLT+6gwiiB4rA7MHRldSmA67QOjJJg6hYg8J2zwJAfxb6/VAy GsBKn00KMHboRsy4ofbrv7A9RhbIGZYc4gCbKgSU= From: Vitalii Mordan To: Andrzej Hajda Cc: Vitalii Mordan , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sui Jingfeng , Aleksandr Mishin , Al Viro , Tomi Valkeinen , Jyri Sarha , Quentin Schulz , Swapnil Jakhade , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Fedor Pchelkin , Alexey Khoroshilov , Vadim Mutilin , lvc-project@linuxtesting.org Subject: [PATCH v2] gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines Date: Thu, 13 Feb 2025 14:28:01 +0300 Message-Id: <20250213112801.1611525-1-mordan@ispras.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not be disabled in any path. Use the devm_clk_get_enabled() helper function to ensure proper call balance for mhdp->clk. Found by Linux Verification Center (linuxtesting.org) with Klever. Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP = bridge") Signed-off-by: Vitalii Mordan --- v2: Use devm_clk_get_enabled() helper function, as per Dmitry Baryshkov's request. drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index d081850e3c03..d4e4f484cbe5 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -2463,9 +2463,9 @@ static int cdns_mhdp_probe(struct platform_device *pd= ev) if (!mhdp) return -ENOMEM; =20 - clk =3D devm_clk_get(dev, NULL); + clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(clk)) { - dev_err(dev, "couldn't get clk: %ld\n", PTR_ERR(clk)); + dev_err(dev, "couldn't get and enable clk: %ld\n", PTR_ERR(clk)); return PTR_ERR(clk); } =20 @@ -2504,14 +2504,12 @@ static int cdns_mhdp_probe(struct platform_device *= pdev) =20 mhdp->info =3D of_device_get_match_data(dev); =20 - clk_prepare_enable(clk); - pm_runtime_enable(dev); ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { dev_err(dev, "pm_runtime_resume_and_get failed\n"); pm_runtime_disable(dev); - goto clk_disable; + return ret; } =20 if (mhdp->info && mhdp->info->ops && mhdp->info->ops->init) { @@ -2590,8 +2588,6 @@ static int cdns_mhdp_probe(struct platform_device *pd= ev) runtime_put: pm_runtime_put_sync(dev); pm_runtime_disable(dev); -clk_disable: - clk_disable_unprepare(mhdp->clk); =20 return ret; } @@ -2632,8 +2628,6 @@ static void cdns_mhdp_remove(struct platform_device *= pdev) cancel_work_sync(&mhdp->modeset_retry_work); flush_work(&mhdp->hpd_work); /* Ignoring mhdp->hdcp.check_work and mhdp->hdcp.prop_work here. */ - - clk_disable_unprepare(mhdp->clk); } =20 static const struct of_device_id mhdp_ids[] =3D { --=20 2.25.1