From nobody Sun Dec 14 11:56:54 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64D50266B72 for ; Thu, 13 Feb 2025 21:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739481157; cv=none; b=LQ59iFwWYFxEtmciGMIcaK9PiaQ6QrdgY3cGagmKSkCBbfBrL2x4o3loq3Qu8p1ORTWSF7z5RFnII216f17tb2KffKG1NY1aZ/y89UCnde/k5sOxKvUnMW6rXZj2jZpPE/urymbO22Df9nCDyLipnzBly1fXI2y+jPJJPgIsMhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739481157; c=relaxed/simple; bh=LaWY661hGGOsz8ab9A8tX3O52beRD/JORrirTIwPdYI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gqVzb09T3ARmxR2jHoe1Eet/TsTex7WeW72yGaxEQkiyLF5QO+RpilEUhH5QMaMeG26UyHfGT8ssch8/uSJYlckp3A2ic0dDBN7uv7TgdozozArFblwae344utW/iTIVcAnFGmWfz+M0qZZKea/P5YyCn4JIqOx0+cc5uh6TYOU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=PQgOjTPS; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="PQgOjTPS" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21f55fbb72bso25346805ad.2 for ; Thu, 13 Feb 2025 13:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739481155; x=1740085955; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7dCT5jcbY95du2Tjjq6rItJv9SEP2f87N9w5dx/eCvk=; b=PQgOjTPSZ018B7gXHtYTZ5cRL50oqDk9VjHlUmAM1ERVJShkmoz/p6hKEKzwtRjDNY po6iTqmYTlvXp98UsSVtAkMNSQ/MBAAbYVQycjTeVLKTtnVOtrT5IwJx0pp7bJW8yzRM zycNB69qQDWQLooo6hDzJfOC6QSax+5hV8oD04YhjuRF4dmcKVwW1ZnooFrXvHyLOnEJ TFypj/qjuk49tse64lXBXoEyp5453DjrsmfnDxc6Tij4a0XpLwBOS7iCIdQlF5ru8Ock Ueav0D4Msz4raWAfzewlOF1AGnZL0oQPiS4Es067DrW12AIveFAApfkEPV6L7S5W+Mwa tbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739481155; x=1740085955; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7dCT5jcbY95du2Tjjq6rItJv9SEP2f87N9w5dx/eCvk=; b=WKdSI0PwoL7BVoiRaLuVUW1nrxLUihsrIDoTElSCaI/2HCtpVyBgsErKpzcEK2afxm JVAz17LLtfr/LzcdGA+e7khK+05zGeOdN4Ijs9ZFV7vpZ7agqR7SarLo3SeksmQ8woJH YrEZ8m+dY/iBPlF7f7V87pIzReNGyeCA9HBFi5cEa5fB33uzq5qSfjSUgfscTL2Xt8ts G/PnmDz/0dSAAXTLvkHIq4fDLU681HJ4o6+XubCc7lzzGpeVrDl9hChJF0Uq+Dk057Gn hIGZ6TglOnTZH8/DRCvCYygfS8eF1IDBd0ckPA9qYAIdGBSSoy4CsIHb0D9WjUzQE1Kd 4agQ== X-Forwarded-Encrypted: i=1; AJvYcCXmSdegXqXJzwTIhOGhil3KorCZ9gvahbpm9NcQHtRwGJFEM68Q0BmhuCxfQeCY2QhV15rWOlhSaEfjXnE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRBAyrar+2FcCvtPa5GveQh6WuLjgptdseHihs0gnmsukOzDcs S4m3/hpd3w2OXZu2dQH0HucD23pJsDZDsGd78VH/MMatJRH/j2b4KPXgGYazvT4= X-Gm-Gg: ASbGncspILLJiv51J25pCvdC5elS9x89drEynyJeDSmV8YsHya94hlvHxdKKN4BD6QA Zib56U13/DEhH7O7s2dQUM3YcmMDN/NKCb18F4DSUSO7ZmhCzBfetESYHL1kX00RWBtp6tP/uC6 lJjZvW5iiDFGr8thUzv502SRAtNeWiVoy/3/PxgDArwqyIhFaVYHHpIvkE87F3qsjGTjCCTQLD9 7lCffEJxmhCVSCFVFoyEQFk1jammFSjhtd85M5s1yAipd7BEpWU7oC0lX7s1MaFhbUUQtsDv3Z7 jhsCP8rcTYrG73IcvoIanfFjMI40tF0= X-Google-Smtp-Source: AGHT+IHWMlGwUiWdsiNRbvm7dD8sEMzLzmRqwl/PU5Ys8fbVS90IAlTNhDD0UoMI3fOVabW+kAQ4WQ== X-Received: by 2002:a05:6a00:3e04:b0:730:9334:18f3 with SMTP id d2e1a72fcca58-7323c1bcde7mr7654326b3a.19.1739481154657; Thu, 13 Feb 2025 13:12:34 -0800 (PST) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7324257fdd6sm1758072b3a.76.2025.02.13.13.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 13:12:34 -0800 (PST) From: Charlie Jenkins Date: Thu, 13 Feb 2025 13:06:22 -0800 Subject: [PATCH v3 2/2] tools: Remove redundant quiet setup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250213-quiet_tools-v3-2-07de4482a581@rivosinc.com> References: <20250213-quiet_tools-v3-0-07de4482a581@rivosinc.com> In-Reply-To: <20250213-quiet_tools-v3-0-07de4482a581@rivosinc.com> To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , Quentin Monnet , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Josh Poimboeuf , Mykola Lysenko , Shuah Khan , Jiri Kosina , Benjamin Tissoires , Steven Rostedt Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-input@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Charlie Jenkins X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=10133; i=charlie@rivosinc.com; h=from:subject:message-id; bh=LaWY661hGGOsz8ab9A8tX3O52beRD/JORrirTIwPdYI=; b=owGbwMvMwCXWx5hUnlvL8Y3xtFoSQ/q6BGu5TUfqNyQ4drwoiJ+XWX7zwBmVfSudWRT0mS+9f 6jGzv6oo5SFQYyLQVZMkYXnWgNz6x39sqOiZRNg5rAygQxh4OIUgImsvszwz7bS6cPv4DW/n82q c1vDlz51t8ZH3vIlkd7+d8qjXp67tpThf3xtgqCr1zKtYgkrh/mW1rFZmbr1cr4pv1r89977OvU rMwA= X-Developer-Key: i=charlie@rivosinc.com; a=openpgp; fpr=7D834FF11B1D8387E61C776FFB10D1F27D6B1354 Q is exported from Makefile.include so it is not necessary to manually set it. Signed-off-by: Charlie Jenkins Acked-by: Quentin Monnet Acked-by: Steven Rostedt (Google) --- tools/arch/arm64/tools/Makefile | 6 ------ tools/bpf/Makefile | 6 ------ tools/bpf/bpftool/Documentation/Makefile | 6 ------ tools/bpf/bpftool/Makefile | 6 ------ tools/bpf/resolve_btfids/Makefile | 2 -- tools/bpf/runqslower/Makefile | 5 +---- tools/lib/bpf/Makefile | 13 ------------- tools/lib/perf/Makefile | 13 ------------- tools/lib/thermal/Makefile | 13 ------------- tools/objtool/Makefile | 6 ------ tools/testing/selftests/bpf/Makefile.docs | 6 ------ tools/testing/selftests/hid/Makefile | 2 -- tools/thermal/lib/Makefile | 13 ------------- tools/tracing/latency/Makefile | 6 ------ tools/tracing/rtla/Makefile | 6 ------ tools/verification/rv/Makefile | 6 ------ 16 files changed, 1 insertion(+), 114 deletions(-) diff --git a/tools/arch/arm64/tools/Makefile b/tools/arch/arm64/tools/Makef= ile index 7b42feedf647190ad498de0937e8fb557e40f39c..de4f1b66ef0148b7bfd0fd16655= ad854c7542240 100644 --- a/tools/arch/arm64/tools/Makefile +++ b/tools/arch/arm64/tools/Makefile @@ -13,12 +13,6 @@ AWK ?=3D awk MKDIR ?=3D mkdir RM ?=3D rm =20 -ifeq ($(V),1) -Q =3D -else -Q =3D @ -endif - arm64_tools_dir =3D $(top_srcdir)/arch/arm64/tools arm64_sysreg_tbl =3D $(arm64_tools_dir)/sysreg arm64_gen_sysreg =3D $(arm64_tools_dir)/gen-sysreg.awk diff --git a/tools/bpf/Makefile b/tools/bpf/Makefile index 243b79f2b451e52ca196f79dc46befd1b3dab458..062bbd6cd048e9e42f9bc8f9972= ec96594f3dbd2 100644 --- a/tools/bpf/Makefile +++ b/tools/bpf/Makefile @@ -27,12 +27,6 @@ srctree :=3D $(patsubst %/,%,$(dir $(CURDIR))) srctree :=3D $(patsubst %/,%,$(dir $(srctree))) endif =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - FEATURE_USER =3D .bpf FEATURE_TESTS =3D libbfd disassembler-four-args disassembler-init-styled FEATURE_DISPLAY =3D libbfd diff --git a/tools/bpf/bpftool/Documentation/Makefile b/tools/bpf/bpftool/D= ocumentation/Makefile index 4315652678b9f2e27e48b7815f3b9ddc70a57165..bf843f328812e10dd65a73f355f= 74e6825ad95b9 100644 --- a/tools/bpf/bpftool/Documentation/Makefile +++ b/tools/bpf/bpftool/Documentation/Makefile @@ -5,12 +5,6 @@ INSTALL ?=3D install RM ?=3D rm -f RMDIR ?=3D rmdir --ignore-fail-on-non-empty =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - prefix ?=3D /usr/local mandir ?=3D $(prefix)/man man8dir =3D $(mandir)/man8 diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile index dd9f3ec842017f1dd24054bf3a0986d546811dc4..6ea4823b770cbbe7fd9eb7da799= 56cc1dae1f204 100644 --- a/tools/bpf/bpftool/Makefile +++ b/tools/bpf/bpftool/Makefile @@ -7,12 +7,6 @@ srctree :=3D $(patsubst %/,%,$(dir $(srctree))) srctree :=3D $(patsubst %/,%,$(dir $(srctree))) endif =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - BPF_DIR =3D $(srctree)/tools/lib/bpf =20 ifneq ($(OUTPUT),) diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/M= akefile index 4b8079f294f65b284481e9a2bf6ff52594a4669a..afbddea3a39c64ffb2efc874a36= 37b6401791c5b 100644 --- a/tools/bpf/resolve_btfids/Makefile +++ b/tools/bpf/resolve_btfids/Makefile @@ -5,10 +5,8 @@ include ../../scripts/Makefile.arch srctree :=3D $(abspath $(CURDIR)/../../../) =20 ifeq ($(V),1) - Q =3D msg =3D else - Q =3D @ ifeq ($(silent),1) msg =3D else diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile index c4f1f1735af659c2e660a322dbf6912d9a5724bc..e49203ebd48c18607a6136a9e80= 5ccf16ee960d3 100644 --- a/tools/bpf/runqslower/Makefile +++ b/tools/bpf/runqslower/Makefile @@ -26,10 +26,7 @@ VMLINUX_BTF_PATHS :=3D $(if $(O),$(O)/vmlinux) \ VMLINUX_BTF_PATH :=3D $(or $(VMLINUX_BTF),$(firstword \ $(wildcard $(VMLINUX_BTF_PATHS)))) =20 -ifeq ($(V),1) -Q =3D -else -Q =3D @ +ifneq ($(V),1) MAKEFLAGS +=3D --no-print-directory submake_extras :=3D feature_display=3D0 endif diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index 857a5f7b413d6dc4cbe7bc4167496674dd08d875..168140f8e6461bd06db40e23d21= a3fb8847ccbf4 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -53,13 +53,6 @@ include $(srctree)/tools/scripts/Makefile.include =20 # copy a bit from Linux kbuild =20 -ifeq ("$(origin V)", "command line") - VERBOSE =3D $(V) -endif -ifndef VERBOSE - VERBOSE =3D 0 -endif - INCLUDES =3D -I$(or $(OUTPUT),.) \ -I$(srctree)/tools/include -I$(srctree)/tools/include/uapi \ -I$(srctree)/tools/arch/$(SRCARCH)/include @@ -96,12 +89,6 @@ override CFLAGS +=3D $(CLANG_CROSS_FLAGS) # flags specific for shared library SHLIB_FLAGS :=3D -DSHARED -fPIC =20 -ifeq ($(VERBOSE),1) - Q =3D -else - Q =3D @ -endif - # Disable command line variables (CFLAGS) override from top # level Makefile (perf), otherwise build Makefile will get # the same command line setup. diff --git a/tools/lib/perf/Makefile b/tools/lib/perf/Makefile index 3a9b2140aa048ea919c69ed2240bf0ea444dbf21..e9a7ac2c062e2b398c2f22af419= 07b62815ca07e 100644 --- a/tools/lib/perf/Makefile +++ b/tools/lib/perf/Makefile @@ -39,19 +39,6 @@ libdir =3D $(prefix)/$(libdir_relative) libdir_SQ =3D $(subst ','\'',$(libdir)) libdir_relative_SQ =3D $(subst ','\'',$(libdir_relative)) =20 -ifeq ("$(origin V)", "command line") - VERBOSE =3D $(V) -endif -ifndef VERBOSE - VERBOSE =3D 0 -endif - -ifeq ($(VERBOSE),1) - Q =3D -else - Q =3D @ -endif - TEST_ARGS :=3D $(if $(V),-v) =20 # Set compile option CFLAGS diff --git a/tools/lib/thermal/Makefile b/tools/lib/thermal/Makefile index 8890fd57b110ccc1a837d37624a5dead00f18656..a1f5e388644d31d36f973d3ddce= 48d036ee0a083 100644 --- a/tools/lib/thermal/Makefile +++ b/tools/lib/thermal/Makefile @@ -39,19 +39,6 @@ libdir =3D $(prefix)/$(libdir_relative) libdir_SQ =3D $(subst ','\'',$(libdir)) libdir_relative_SQ =3D $(subst ','\'',$(libdir_relative)) =20 -ifeq ("$(origin V)", "command line") - VERBOSE =3D $(V) -endif -ifndef VERBOSE - VERBOSE =3D 0 -endif - -ifeq ($(VERBOSE),1) - Q =3D -else - Q =3D @ -endif - # Set compile option CFLAGS ifdef EXTRA_CFLAGS CFLAGS :=3D $(EXTRA_CFLAGS) diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile index f56e2772753414ff8d3462bdebbc8e95e7667fcd..7a65948892e569cbe1d6e5a78db= 68bb35102cd26 100644 --- a/tools/objtool/Makefile +++ b/tools/objtool/Makefile @@ -46,12 +46,6 @@ HOST_OVERRIDES :=3D CC=3D"$(HOSTCC)" LD=3D"$(HOSTLD)" AR= =3D"$(HOSTAR)" AWK =3D awk MKDIR =3D mkdir =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - BUILD_ORC :=3D n =20 ifeq ($(SRCARCH),x86) diff --git a/tools/testing/selftests/bpf/Makefile.docs b/tools/testing/self= tests/bpf/Makefile.docs index eb6a4fea8c794d8354363ac8daa0baac3e3bd060..f7f9e7088bb38c7507282990fb6= 2921ca7a636d2 100644 --- a/tools/testing/selftests/bpf/Makefile.docs +++ b/tools/testing/selftests/bpf/Makefile.docs @@ -7,12 +7,6 @@ INSTALL ?=3D install RM ?=3D rm -f RMDIR ?=3D rmdir --ignore-fail-on-non-empty =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - prefix ?=3D /usr/local mandir ?=3D $(prefix)/man man2dir =3D $(mandir)/man2 diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests= /hid/Makefile index 0336353bd15f0d56dbed6c8fa02f53c234f949e1..2839d2612ce3a70f4332f8e8865= 86e9cca6f03cb 100644 --- a/tools/testing/selftests/hid/Makefile +++ b/tools/testing/selftests/hid/Makefile @@ -43,10 +43,8 @@ TEST_GEN_PROGS =3D hid_bpf hidraw # $3 - target (assumed to be file); only file name will be emitted; # $4 - optional extra arg, emitted as-is, if provided. ifeq ($(V),1) -Q =3D msg =3D else -Q =3D @ msg =3D @printf ' %-8s%s %s%s\n' "$(1)" "$(if $(2), [$(2)])" "$(notdir $(= 3))" "$(if $(4), $(4))"; MAKEFLAGS +=3D --no-print-directory submake_extras :=3D feature_display=3D0 diff --git a/tools/thermal/lib/Makefile b/tools/thermal/lib/Makefile index f2552f73a64c7eb1be24c27b3a1414617391315b..056d212f25cf51cd8c02260fbe2= ef28dda5e4acb 100644 --- a/tools/thermal/lib/Makefile +++ b/tools/thermal/lib/Makefile @@ -39,19 +39,6 @@ libdir =3D $(prefix)/$(libdir_relative) libdir_SQ =3D $(subst ','\'',$(libdir)) libdir_relative_SQ =3D $(subst ','\'',$(libdir_relative)) =20 -ifeq ("$(origin V)", "command line") - VERBOSE =3D $(V) -endif -ifndef VERBOSE - VERBOSE =3D 0 -endif - -ifeq ($(VERBOSE),1) - Q =3D -else - Q =3D @ -endif - # Set compile option CFLAGS ifdef EXTRA_CFLAGS CFLAGS :=3D $(EXTRA_CFLAGS) diff --git a/tools/tracing/latency/Makefile b/tools/tracing/latency/Makefile index 6518b03e05c71b4fa84498f9628adf81a38c9f56..257a56b1899f23837de533353e9= c2cebdb6035bd 100644 --- a/tools/tracing/latency/Makefile +++ b/tools/tracing/latency/Makefile @@ -37,12 +37,6 @@ FEATURE_TESTS +=3D libtracefs FEATURE_DISPLAY :=3D libtraceevent FEATURE_DISPLAY +=3D libtracefs =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - all: $(LATENCY-COLLECTOR) =20 include $(srctree)/tools/build/Makefile.include diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile index 8b5101457c70b48e9c720f1ba53293f1307c15a2..0b61208db604ec0754024c3007d= b6b2fe74a613c 100644 --- a/tools/tracing/rtla/Makefile +++ b/tools/tracing/rtla/Makefile @@ -37,12 +37,6 @@ FEATURE_DISPLAY :=3D libtraceevent FEATURE_DISPLAY +=3D libtracefs FEATURE_DISPLAY +=3D libcpupower =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - all: $(RTLA) =20 include $(srctree)/tools/build/Makefile.include diff --git a/tools/verification/rv/Makefile b/tools/verification/rv/Makefile index 411d62b3d8eb93abf85526ad33cafd783df86bc1..5b898360ba4818b12e8a16c27bd= 88c75d0076fb9 100644 --- a/tools/verification/rv/Makefile +++ b/tools/verification/rv/Makefile @@ -35,12 +35,6 @@ FEATURE_TESTS +=3D libtracefs FEATURE_DISPLAY :=3D libtraceevent FEATURE_DISPLAY +=3D libtracefs =20 -ifeq ($(V),1) - Q =3D -else - Q =3D @ -endif - all: $(RV) =20 include $(srctree)/tools/build/Makefile.include --=20 2.43.0