From nobody Fri Dec 19 04:49:42 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2245124292E for ; Thu, 13 Feb 2025 14:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739457858; cv=none; b=qo0bOTnsIMVZRRzvvCVhYkPRcZrvYlqjIehiWCuBk2eiyad10tQ31S0RPXSGH2ySohPDOSmskbYj9IDadh9zwX12t+0Fij6/y70bSRMcQVk+lKZZ/3ImifFMf/5If0CDSE3L3FmfrMzxVwNI4XZEcmThZYuRpxiJlG4go6KOiRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739457858; c=relaxed/simple; bh=VBPbKHLSvmMn3Amvc6nP0KWacSWl+aC0MG5g3q4s2SM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q3mPnSvE93mTovOrExRr9gCQSBWkBo1sSwCE3XFTCpHlp4q/PP3UHur6Wt5WpRkyNYh8J3haht045Hwbnr19S5C84vWJy+3ef/+ka7WqGkUMfa3/LRjsPBy+sr42xw+iPbaJJwCrf+hUq52CxYd3D6ungZA8BZgDt1f4wrZooP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KA7ys39B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KA7ys39B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A18FCC4CEE7; Thu, 13 Feb 2025 14:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739457858; bh=VBPbKHLSvmMn3Amvc6nP0KWacSWl+aC0MG5g3q4s2SM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KA7ys39BAwx9jAsYwn04zoiMA8wq6sqkMyQT2vsE8rra8EQJAGIZLCfQhXi3Eub5e TsNjaenYrEErAHClhombR5chMUa2qcCWB3SbIKJVdjY4ihYUJM1RNy4zG1FkJ+lphw tfr5FdgmdzjfzG0Z8Ui/lAmMSlwQyXEdzlvDxKEDZa/Xlv0dVU8kANKfRwk4mJMPNW btPhg3tlB7QIc5okLy8yNThK+aItMDcaM79LP8WA2CSsKPNFisOy3AUMC9APIW6yEY b61IXsPO0Eo2kqgdX4QvIFaDrHGNNmyh+7xyniujOYrQgcxNOF90bOe98x5vpWQQRD 497vP6unkuM4A== From: Maxime Ripard Date: Thu, 13 Feb 2025 15:43:27 +0100 Subject: [PATCH v3 08/37] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250213-bridge-connector-v3-8-e71598f49c8f@kernel.org> References: <20250213-bridge-connector-v3-0-e71598f49c8f@kernel.org> In-Reply-To: <20250213-bridge-connector-v3-0-e71598f49c8f@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2685; i=mripard@kernel.org; h=from:subject:message-id; bh=VBPbKHLSvmMn3Amvc6nP0KWacSWl+aC0MG5g3q4s2SM=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDOnrWCUt1718Nz1V/vmFI+pvHm9dqRO8h2lBznNL23nMd d98guoiO6ayMAhzMsiKKbI8kQk7vbx9cZWD/cofMHNYmUCGMHBxCsBEpK8wNvzhOvCKX821evf5 Yo/za6T+6zW+2P51ssL5WFZTrm1z3jtfst/oJht2b17oB97fy1urDjHWV6pxfRLNYY9/vuHyiaK GaxwLXC77Z+wqvSfldWunYr21VY79t92sS5Y+WS/NIzw15cZpAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D drm_atomic_helper_commit_tail() is the final part of an atomic commit, and is given a parameter with the drm_atomic_state being committed. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_helper.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atom= ic_helper.c index f859dae58a92d56ebed5a1fd7b2243a02b568297..fbff59f9c00e319a7649c6961c6= 0839dc302a44c 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1766,38 +1766,38 @@ void drm_atomic_helper_wait_for_flip_done(struct dr= m_device *dev, } EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done); =20 /** * drm_atomic_helper_commit_tail - commit atomic update to hardware - * @old_state: atomic state object with old state structures + * @state: atomic state object being committed * * This is the default implementation for the * &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers * that do not support runtime_pm or do not need the CRTC to be * enabled to perform a commit. Otherwise, see * drm_atomic_helper_commit_tail_rpm(). * * Note that the default ordering of how the various stages are called is = to * match the legacy modeset helper library closest. */ -void drm_atomic_helper_commit_tail(struct drm_atomic_state *old_state) +void drm_atomic_helper_commit_tail(struct drm_atomic_state *state) { - struct drm_device *dev =3D old_state->dev; + struct drm_device *dev =3D state->dev; =20 - drm_atomic_helper_commit_modeset_disables(dev, old_state); + drm_atomic_helper_commit_modeset_disables(dev, state); =20 - drm_atomic_helper_commit_planes(dev, old_state, 0); + drm_atomic_helper_commit_planes(dev, state, 0); =20 - drm_atomic_helper_commit_modeset_enables(dev, old_state); + drm_atomic_helper_commit_modeset_enables(dev, state); =20 - drm_atomic_helper_fake_vblank(old_state); + drm_atomic_helper_fake_vblank(state); =20 - drm_atomic_helper_commit_hw_done(old_state); + drm_atomic_helper_commit_hw_done(state); =20 - drm_atomic_helper_wait_for_vblanks(dev, old_state); + drm_atomic_helper_wait_for_vblanks(dev, state); =20 - drm_atomic_helper_cleanup_planes(dev, old_state); + drm_atomic_helper_cleanup_planes(dev, state); } EXPORT_SYMBOL(drm_atomic_helper_commit_tail); =20 /** * drm_atomic_helper_commit_tail_rpm - commit atomic update to hardware --=20 2.48.0