From nobody Fri Dec 19 20:34:13 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF6424CEDA; Wed, 12 Feb 2025 15:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739375301; cv=none; b=bPIz1PQ5y5OqYZk5s/YpsHoo+w3E5f5nuKx/OglKrHSwKvZy90bYnN1fUjGKnBfTXCNrvdVsv31mU3xMKqrrTxsq6CEcbqGIUbf4pWhmiFBF1mjQvXtgTBMT0fs5qyNPRDPV1f7CRcmz/Gh4oEMatDbSd8s1O0l7//m/Uma8ZrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739375301; c=relaxed/simple; bh=E1JSCgjVviBxxpgC3OgCVP2YBiwy9pc5amnOz8Sv1Do=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZfUE/oiSrP8G+dn70u6PsBFKzIKOsJtssTX5l7tphsBzVCChGzursS/i0JKjQiceXPx33BBOa2fEDzWUkppbNkk3bP0jxuQVE3VAPhJAxE26NhWLxKIDE7SlGusDhDkja5ANgfaZuR2jk63j7owTP7OgTXVOl7tdSdHjG+UFAss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sn30lqjk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sn30lqjk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF6FCC4CEE7; Wed, 12 Feb 2025 15:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739375300; bh=E1JSCgjVviBxxpgC3OgCVP2YBiwy9pc5amnOz8Sv1Do=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sn30lqjkFktFPbyPCuerQWmWuxoD2pojMAV7+VlEfStvMVGYKhZg/G+UxeUW9rYsg cIQGwD2znjX103mKqtB3Ed9LeANq7sJYLVu+uhKESktUk/EsRohgycYppx+nJdKfFi 1N584SuBXwz7pvwhdHMaAv538h2Yhk3etwrshqHD/T6/dPF6Q9eWuRjt9yPNW1f+p8 aS6pjsMoT7zoyiPatpu/NiXCR/Hx2CVgBYAsIQoU4XXmi3p75aq1aC9Afdr/zqkPpO KhUn6dQ0bm7RftAT6/70CC0kASx4R3SzW066atMJ9Xh3rwyPnxMBxKPzP34oqWRvRy 5Elz/s8rnmcOw== From: Eric Biggers To: fsverity@lists.linux.dev Cc: linux-crypto@vger.kernel.org, dm-devel@lists.linux.dev, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , Sami Tolvanen , Herbert Xu , Alasdair Kergon , Mike Snitzer , Linus Torvalds , Mikulas Patocka Subject: [PATCH v8 2/7] crypto: testmgr - add tests for finup_mb Date: Wed, 12 Feb 2025 07:47:13 -0800 Message-ID: <20250212154718.44255-3-ebiggers@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250212154718.44255-1-ebiggers@kernel.org> References: <20250212154718.44255-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Eric Biggers Update the shash self-tests to test the new finup_mb method when CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=3Dy. Reviewed-by: Sami Tolvanen Acked-by: Ard Biesheuvel Signed-off-by: Eric Biggers --- crypto/testmgr.c | 73 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 66 insertions(+), 7 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index e61490ba40958..6c8b4bd700a8a 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -234,10 +234,11 @@ enum flush_type { =20 /* finalization function for hash algorithms */ enum finalization_type { FINALIZATION_TYPE_FINAL, /* use final() */ FINALIZATION_TYPE_FINUP, /* use finup() */ + FINALIZATION_TYPE_FINUP_MB, /* use finup_mb() */ FINALIZATION_TYPE_DIGEST, /* use digest() */ }; =20 /* * Whether the crypto operation will occur in-place, and if so whether the @@ -297,10 +298,14 @@ struct test_sg_division { * the @iv_offset * @key_offset: misalignment of the key, where 0 is default alignment * @key_offset_relative_to_alignmask: if true, add the algorithm's alignma= sk to * the @key_offset * @finalization_type: what finalization function to use for hashes + * @multibuffer_index: random number used to generate the message index to= use + * for finup_mb (when finup_mb is used). + * @multibuffer_count: random number used to generate the num_msgs paramet= er to + * finup_mb (when finup_mb is used). * @nosimd: execute with SIMD disabled? Requires !CRYPTO_TFM_REQ_MAY_SLEE= P. * This applies to the parts of the operation that aren't controlled * individually by @nosimd_setkey or @src_divs[].nosimd. * @nosimd_setkey: set the key (if applicable) with SIMD disabled? Requir= es * !CRYPTO_TFM_REQ_MAY_SLEEP. @@ -314,10 +319,12 @@ struct testvec_config { unsigned int iv_offset; unsigned int key_offset; bool iv_offset_relative_to_alignmask; bool key_offset_relative_to_alignmask; enum finalization_type finalization_type; + unsigned int multibuffer_index; + unsigned int multibuffer_count; bool nosimd; bool nosimd_setkey; }; =20 #define TESTVEC_CONFIG_NAMELEN 192 @@ -1129,19 +1136,27 @@ static void generate_random_testvec_config(struct r= nd_state *rng, if (prandom_bool(rng)) { cfg->req_flags |=3D CRYPTO_TFM_REQ_MAY_SLEEP; p +=3D scnprintf(p, end - p, " may_sleep"); } =20 - switch (prandom_u32_below(rng, 4)) { + switch (prandom_u32_below(rng, 8)) { case 0: + case 1: cfg->finalization_type =3D FINALIZATION_TYPE_FINAL; p +=3D scnprintf(p, end - p, " use_final"); break; - case 1: + case 2: cfg->finalization_type =3D FINALIZATION_TYPE_FINUP; p +=3D scnprintf(p, end - p, " use_finup"); break; + case 3: + case 4: + cfg->finalization_type =3D FINALIZATION_TYPE_FINUP_MB; + cfg->multibuffer_index =3D prandom_u32_state(rng); + cfg->multibuffer_count =3D prandom_u32_state(rng); + p +=3D scnprintf(p, end - p, " use_finup_mb"); + break; default: cfg->finalization_type =3D FINALIZATION_TYPE_DIGEST; p +=3D scnprintf(p, end - p, " use_digest"); break; } @@ -1296,10 +1311,37 @@ static inline int check_shash_op(const char *op, in= t err, pr_err("alg: shash: %s %s() failed with err %d on test vector %s, cfg=3D= \"%s\"\n", driver, op, err, vec_name, cfg->name); return err; } =20 +static int do_finup_mb(struct shash_desc *desc, + const u8 *data, unsigned int len, u8 *result, + const struct testvec_config *cfg, + const struct test_sglist *tsgl) +{ + struct crypto_shash *tfm =3D desc->tfm; + const u8 *unused_data =3D tsgl->bufs[XBUFSIZE - 1]; + u8 unused_result[HASH_MAX_DIGESTSIZE]; + const u8 *datas[HASH_MAX_MB_MSGS]; + u8 *outs[HASH_MAX_MB_MSGS]; + unsigned int num_msgs; + unsigned int msg_idx; + unsigned int i; + + num_msgs =3D 1 + (cfg->multibuffer_count % crypto_shash_mb_max_msgs(tfm)); + if (WARN_ON_ONCE(num_msgs > HASH_MAX_MB_MSGS)) + return -EINVAL; + msg_idx =3D cfg->multibuffer_index % num_msgs; + for (i =3D 0; i < num_msgs; i++) { + datas[i] =3D unused_data; + outs[i] =3D unused_result; + } + datas[msg_idx] =3D data; + outs[msg_idx] =3D result; + return crypto_shash_finup_mb(desc, datas, len, outs, num_msgs); +} + /* Test one hash test vector in one configuration, using the shash API */ static int test_shash_vec_cfg(const struct hash_testvec *vec, const char *vec_name, const struct testvec_config *cfg, struct shash_desc *desc, @@ -1372,11 +1414,14 @@ static int test_shash_vec_cfg(const struct hash_tes= tvec *vec, return -EINVAL; } goto result_ready; } =20 - /* Using init(), zero or more update(), then final() or finup() */ + /* + * Using init(), zero or more update(), then either final(), finup(), or + * finup_mb(). + */ =20 if (cfg->nosimd) crypto_disable_simd_for_test(); err =3D crypto_shash_init(desc); if (cfg->nosimd) @@ -1384,28 +1429,42 @@ static int test_shash_vec_cfg(const struct hash_tes= tvec *vec, err =3D check_shash_op("init", err, driver, vec_name, cfg); if (err) return err; =20 for (i =3D 0; i < tsgl->nents; i++) { + const u8 *data =3D sg_virt(&tsgl->sgl[i]); + unsigned int len =3D tsgl->sgl[i].length; + if (i + 1 =3D=3D tsgl->nents && cfg->finalization_type =3D=3D FINALIZATION_TYPE_FINUP) { if (divs[i]->nosimd) crypto_disable_simd_for_test(); - err =3D crypto_shash_finup(desc, sg_virt(&tsgl->sgl[i]), - tsgl->sgl[i].length, result); + err =3D crypto_shash_finup(desc, data, len, result); if (divs[i]->nosimd) crypto_reenable_simd_for_test(); err =3D check_shash_op("finup", err, driver, vec_name, cfg); if (err) return err; goto result_ready; } + if (i + 1 =3D=3D tsgl->nents && + cfg->finalization_type =3D=3D FINALIZATION_TYPE_FINUP_MB) { + if (divs[i]->nosimd) + crypto_disable_simd_for_test(); + err =3D do_finup_mb(desc, data, len, result, cfg, tsgl); + if (divs[i]->nosimd) + crypto_reenable_simd_for_test(); + err =3D check_shash_op("finup_mb", err, driver, vec_name, + cfg); + if (err) + return err; + goto result_ready; + } if (divs[i]->nosimd) crypto_disable_simd_for_test(); - err =3D crypto_shash_update(desc, sg_virt(&tsgl->sgl[i]), - tsgl->sgl[i].length); + err =3D crypto_shash_update(desc, data, len); if (divs[i]->nosimd) crypto_reenable_simd_for_test(); err =3D check_shash_op("update", err, driver, vec_name, cfg); if (err) return err; --=20 2.48.1