From nobody Thu Dec 18 09:57:40 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C71F1DC9B0; Wed, 12 Feb 2025 03:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739331760; cv=none; b=I2vA89p2K2grUrK1yjJoWFPPivMG7pZyXoyABcgDb0jLQGcM83oc8vY2OjGJTlllfQ9Z3KAj6NhgI5v4ud6Da62uHXrDv2EOSH9XpVWjrqRrmsWAQM82P20U/eRcY03RcXCniOvvO2pnroj0s4uQTiKsCeyNrcawPiaHT6EREb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739331760; c=relaxed/simple; bh=65lmxrdzow8jpKLsELbK0O108xiut0TKg7mz63uj6YQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K3UflS66cZOpNiMZrtEPxUf7uaH5OxVFSmKd/DMgSw4L1i5yljWZlvuM0lP4xa2+NvcoV6nMCTNTQ29ziqEbqMCuPtxjMlAce+EBGPcMydKnNqNXDkPmWY2ajD5fhiDLn6zikzP1dqyY9APwznic8KHooznI7V7vHr3IArVJfm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ngQ13Q2P; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ngQ13Q2P" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21f5660c2fdso91564035ad.2; Tue, 11 Feb 2025 19:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739331758; x=1739936558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXXxScIwQFKN7LP5CI4QAzDFaxMA+7SppSQtl2ntzes=; b=ngQ13Q2PgtCheY56jcqlMcnHWq6qjjKl6bZAhgyC9F6HBCuM86inwukxqUbbU03aQD CXaB99ijJ8cHCglzfcjI/12M//bmTESBvn5abiJEp8RMZbRJdGM4ZMGeIkGiWvbIc8mR SDYK97W5s1PGW6Zbd3MI9/pO8UPbXf9CJ0z1VZ4BxlUlIM40iYafMtdWobwc9zA6vp6o VFIURmIcth24RjEkk7QJDk+gFrpS/MNxokH7I2N5W8ZdP0abREGb5LgK3/N5uxk7Ajgl P4jiAJ8Cr3xizIq6NgBnj5RA39KjyhxeUgXMQ2IOp3xd+4hpfnHz9vJ3A25NhpiEEaeh RQtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739331758; x=1739936558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eXXxScIwQFKN7LP5CI4QAzDFaxMA+7SppSQtl2ntzes=; b=O9NlKS8ubrH9pXF1ZHA9E3ixO6cOTAfxxyhyR2n2nKzaVTaOLLGo0NjZobYxTSxuS5 RO8UZKdBJQidml4i3ea6p1+6qKSTFZfGKNEu/ck7GBa2qpXXZ/h2wxlHQ4JljBj4tPuj MkTz7mpWObHFdrAm3D2KDBJkVP8asmt0ivibCxubgWotJgM42zaebDICo6RPNVNTFm1O hHvlKHISNGTTMqhGak11FHCp0+SDuREjBlmXV4i4H6dsWO2Cr06fntXyOBnfiiV0G/p5 IrAqotxYIyMjK4tQzRcHRV1a1keTTj7XCo3UZyAX9KIuDw5PdQa8Edi/o4XWolYajaMM pGnQ== X-Gm-Message-State: AOJu0YwizP+Y7O8R9Eju5NwdwwZE6VCaRUKeRpIfTpXfszagv9vImEOh HKmG7xXzL4AxGtW6v5PaUxRzg9gymPBBkJLfGMRlo39flUiDgrJuozHW3MuO X-Gm-Gg: ASbGncsIPYD9w20Tkid03cmDXhkOLIYxJynd3Ds9eJFfDUn6QcW2Bw9xKZyGT0Hyc3K 9HO+lQ4CFJdYrD0+lSPVWp19qekTiXHPHO+17HirPIhETrfG6dsEOgcBymxMrnVWe+npvMAwneU BNJa5UKzzKPdHy6nrD/XOb5tfT5gCeq98odybK92kw0J/Pii917oD8mjkMrSN48XAt7MpzVe+Zz Gvmx4Zslvn9hcrC5l8xX0P86hDH6YX+ILCMe7M2gPjkvb07QPdCjm8vWfoucq4HK20vdy5PH7fZ gsXyy/q1LmnstgfmZ760rnLwapE0hr9FHmiscw== X-Google-Smtp-Source: AGHT+IE/sGLa8XAKyqqGT3OXXewnXnEK8dcyr51RJTiO45dQm7hvJIMpjXgxvC+P2ISTAmv5et6NhQ== X-Received: by 2002:a05:6a20:b603:b0:1ee:1bc6:2341 with SMTP id adf61e73a8af0-1ee5c73abb6mr2784860637.15.1739331758406; Tue, 11 Feb 2025 19:42:38 -0800 (PST) Received: from localhost.localdomain ([66.119.214.127]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73218c206a6sm2304923b3a.49.2025.02.11.19.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 19:42:38 -0800 (PST) From: "James A. MacInnes" To: linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, "James A. MacInnes" Subject: [PATCH 1/2] drm/msm/dp: Disable wide bus support for SDM845 Date: Tue, 11 Feb 2025 19:42:24 -0800 Message-ID: <20250212034225.2565069-2-james.a.macinnes@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250212034225.2565069-1-james.a.macinnes@gmail.com> References: <20250212034225.2565069-1-james.a.macinnes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" SDM845 DPU hardware is rev 4.0.0 per hardware document. Incorrect setting caused inop displayport. Corrected by separating SDM845 to own descriptor. Fixes: c7c412202623 ("drm/msm/dp: enable widebus on all relevant chipsets") Signed-off-by: James A. MacInnes --- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index aff51bb973eb..2cbdbf85a85c 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -126,6 +126,11 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = =3D { {} }; =20 +static const struct msm_dp_desc msm_dp_desc_sdm845[] =3D { + { .io_start =3D 0x0ae90000, .id =3D MSM_DP_CONTROLLER_0, .wide_bus_suppor= ted =3D false }, + {} +}; + static const struct msm_dp_desc msm_dp_desc_sc7180[] =3D { { .io_start =3D 0x0ae90000, .id =3D MSM_DP_CONTROLLER_0, .wide_bus_suppor= ted =3D true }, {} @@ -178,7 +183,7 @@ static const struct of_device_id msm_dp_dt_match[] =3D { { .compatible =3D "qcom,sc8180x-edp", .data =3D &msm_dp_desc_sc8180x }, { .compatible =3D "qcom,sc8280xp-dp", .data =3D &msm_dp_desc_sc8280xp }, { .compatible =3D "qcom,sc8280xp-edp", .data =3D &msm_dp_desc_sc8280xp }, - { .compatible =3D "qcom,sdm845-dp", .data =3D &msm_dp_desc_sc7180 }, + { .compatible =3D "qcom,sdm845-dp", .data =3D &msm_dp_desc_sdm845 }, { .compatible =3D "qcom,sm8350-dp", .data =3D &msm_dp_desc_sc7180 }, { .compatible =3D "qcom,sm8650-dp", .data =3D &msm_dp_desc_sm8650 }, { .compatible =3D "qcom,x1e80100-dp", .data =3D &msm_dp_desc_x1e80100 }, --=20 2.43.0 From nobody Thu Dec 18 09:57:40 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3AE21E2838; Wed, 12 Feb 2025 03:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739331763; cv=none; b=hhMXv2o5LcuY7+Vgm5+KrmOnH0UOW2wbASMKNzL1IsSW9sAFUWDwRsqAQc9j+FVISJQYyuAHDLdVJnxqrs0rBmhiGo4ea+vOto4b604p9vqrUOeWxghzCzjOqwzOOrGz91URVh37/vrFKMZfOqIcYIiLTR6bhFDzxnuXkoNAmc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739331763; c=relaxed/simple; bh=N3T02SZh7OA4gWBfRQ4z09hnrpwD6/fc3bzKbL3pijE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uT33QsvMfGRYZNpDFaXAh9LC5pB/PZcgs8bFKIQOSgi2vMmofLAh9QaeTZQgF6ugGwmnN0QeE16r65MNRXnNJdXGby2go+SxKwY4N16YjkOKV9nBQLDx9FlyzsO2qIE06wARaJqsvrFoAvPiUGm+NmzrOBl7yHRpEXRptz2Cf/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LoXSpo1h; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LoXSpo1h" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21f6022c2c3so6654475ad.0; Tue, 11 Feb 2025 19:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739331760; x=1739936560; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ueKWrRxljHH7KriNyyANgoD1D2VXG9ivKWGBEdHlHoY=; b=LoXSpo1hTZpcC1yEKOTT59PlADY+ZhRCtKMFaNtq2mqVDeTlKNG8RbX0vMMTBUFE8j dw3HU6R2H69eU79flhGnKOvPNOpPwUfLT+2eS1ilWJmKfQZbZJwmzb4Ktkf6QHreIkZ/ OCnVYVqcSMZ+6HWkXZU+vv7AX2Y/U4KxnBi4k+7/BPNwbpIjmYuHC/SzyW0qTCraghfe A3dpgOWwJJgV50sIGeOjRtlj7prbicdVvUSBvVlXBbqJ6In7FbPhM4lQAbdyyachBnWg G13Ks+uyFjETib+qesRZ8Qyu3F26rwn9Y7F6PRdSnFtJN7W40QXoDfV0VRgHnruosxWK TQBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739331760; x=1739936560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ueKWrRxljHH7KriNyyANgoD1D2VXG9ivKWGBEdHlHoY=; b=J2pGIH8EdajDn/II0Hc12H2OdqcHg4xt9KzDV9xQmeKgPbOkdklZg0XAvh/7dZHFmN VWq8moC52SGLZH+3KFExxm92+9/MGB5Y1a8J7DMCtHWm1DC2eA43zyqzYVS4uOHGupvb lSZ8qmCZSHTw0akVj/wg1TyS61tjZOrq0SwjRJBn6TY9JlU6RqyGoO1VtBLWRxS1Ynq9 LbOBA/Emoyi6HOjMe1FAh6z6bB0aaU0TXaMIBUmCMTijxEQXmSeqBp/w3WyR4erU8Njx T58pP+61ZvLbuLiRyUjisP6xVXgW6VMgWNjWCB+c51RtQ7Xjmz45agtb5A517Te/nJsb cJpw== X-Gm-Message-State: AOJu0YzWELUYcWeopm55LYCNCeyPtYcX4yPjIlj3Ajoqi57XVfn1HK/7 2Ju/0eXQpwPt/Q3LhQ44Ub4FoEM9lHFjwuYgh04F5qh2O3dldgqsEPUTDouF X-Gm-Gg: ASbGncvzpLx83nNdvmw4TlPDm6I45ApezpCrhyxxixaUxgnX0Cy0VMQSfVlgqhU4zWe ZhaSLjBwLmqV95qXOK75dnjIhVXEv3NzPpbYiG1ZckK3r9e6fFpzv8h/2qgCHLx3KlLIwkACzju LCHLpu5l2YBlGidJ5Ostaxs+I1p8OXqUjm1UKGSbHbWucoaq9t8M31yA38JQB8aBYEedxHNVGND VZ/yXqrn3jOyBd4da8fz2DR2Vx2pkbSyiAd8/+uy2uKJwnLD1TzZT3O4LV50K37DZvNlQ9AJvwt SdaLCcyClUlziI73BHbwLyT9QrRh6wvZIoBoNA== X-Google-Smtp-Source: AGHT+IE3mvhAkVu/fqNqn9Ndl/Wy5AuF0bpcu6ed4bE/0j3gnwSdb4BDlMTgwupTG0T7FduAzFmLxQ== X-Received: by 2002:a05:6a20:2447:b0:1e1:a920:225d with SMTP id adf61e73a8af0-1ee5cf5e25fmr2710271637.19.1739331760573; Tue, 11 Feb 2025 19:42:40 -0800 (PST) Received: from localhost.localdomain ([66.119.214.127]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73218c206a6sm2304923b3a.49.2025.02.11.19.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 19:42:40 -0800 (PST) From: "James A. MacInnes" To: linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, "James A. MacInnes" Subject: [PATCH 2/2] drm/msm/disp: Correct porch timing for SDM845 Date: Tue, 11 Feb 2025 19:42:25 -0800 Message-ID: <20250212034225.2565069-3-james.a.macinnes@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250212034225.2565069-1-james.a.macinnes@gmail.com> References: <20250212034225.2565069-1-james.a.macinnes@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Type-C DisplayPort inop due to incorrect settings. SDM845 (DPU 4.0) lacks wide_bus support; porch shift removed. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: James A. MacInnes --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers= /gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c index abd6600046cb..3e0fef0955ce 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c @@ -94,17 +94,17 @@ static void drm_mode_to_intf_timing_params( timing->vsync_polarity =3D 0; } =20 + timing->wide_bus_en =3D dpu_encoder_is_widebus_enabled(phys_enc->parent); + timing->compression_en =3D dpu_encoder_is_dsc_enabled(phys_enc->parent); + /* for DP/EDP, Shift timings to align it to bottom right */ - if (phys_enc->hw_intf->cap->type =3D=3D INTF_DP) { + if (phys_enc->hw_intf->cap->type =3D=3D INTF_DP && timing->wide_bus_en) { timing->h_back_porch +=3D timing->h_front_porch; timing->h_front_porch =3D 0; timing->v_back_porch +=3D timing->v_front_porch; timing->v_front_porch =3D 0; } =20 - timing->wide_bus_en =3D dpu_encoder_is_widebus_enabled(phys_enc->parent); - timing->compression_en =3D dpu_encoder_is_dsc_enabled(phys_enc->parent); - /* * for DP, divide the horizonal parameters by 2 when * widebus is enabled --=20 2.43.0