From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5025F257422 for ; Wed, 12 Feb 2025 17:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379858; cv=none; b=dKNLUVeABhMbArC7JaG2F5ZY73DheZ44BCs3ZtAs3H+WEs7abho9e3xK1nQppfnsH0exlVRi7vzIstUUtvj7I1aPcObkVCGgmLJ/399uxd5usJRzpTax3w6vk+iy4eh1iBUg7PQ6xjaczdn+uETUZhnPeqNhDyIAKKiOtcmp/0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379858; c=relaxed/simple; bh=dZLTyL5Jo0WkWOgkozlRifcSGo0Fs8OvFcrqWNfJV38=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=InCglb/nj/25o/11tZ4brz605JFEQgSzJSNxH6HPMMT1ZL/2rO7DlwS0+cJjKOPg7Vwk+CVxqiFtpeTn6PLRTSIPEz0bmzbxYlgspZeWlT6euT2pUnxAcveAqXOXcvNkM3JelEWFm0umx5HdBt7i6DSOim51rcWzBPTmjLrqvtg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UgwFRpdV; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UgwFRpdV" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5dc89df7eccso13275127a12.3 for ; Wed, 12 Feb 2025 09:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379853; x=1739984653; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/ETufHHcSLBOiDs8I75mjKcj7p1SMnmX1pv07/8BkWg=; b=UgwFRpdVKXzwykkCaLhWewusSn8fdYBELWyhwcRhDY5nIn9PvPSlK/zhOqRo4oU9iR iyPqEQLgttcojQbcAjWRDFgfaBh9+R954FNkfK3mNzSOcQDs0MzHctj9jq6990hEb1mB cq6xOF9W9kKdXk5wHPQaz+Guizt937aG4m7fx21/4jS+Vg30tYm+wTYSzhPFhXo56Hsp nt5hJQdjFAGjMo8EziIzgni4dDaox/5yM+xMnRWVp95QNRgws/7P/XjeI8qvDFDI0vzU DyYQJhC2QVnBXcQ3DUtX0mcPEtqYyB8t2Hi8niMfoo4SKDOeJhLPO8SMvGHxPPZjX4TY HDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379853; x=1739984653; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ETufHHcSLBOiDs8I75mjKcj7p1SMnmX1pv07/8BkWg=; b=ww/wVAbSg552LqIvUbI9Zpyjm0uoO3g+4EOvZy6ipmEWR/HohsxLLv3FfgnWkE1X6m lokAiS2RQ5H4Vvlmt1M9gTGaTerA6TWYXtpN5EeRKlHLB1CTlCehzohBpZZE3ZlpxzRQ NSiki+VPPlQRN0uledfdNl/k5GmK6U31sVg7z9xDCB0JqhL3X1TT1l41Q/aGwloNALx+ SfFv+55GLQfQiZ8jSVsDf4pWeVqarSToN+om2vn6RjsO2E6zmUYS04KX5wnM2MhT1YXL yEhpo0E46HBg7plJ4vqkVYpyqguZ7+tBMOwv3zPisIbkfSZbTxf+PtD5wVhxyuCce2yh 5Mmw== X-Forwarded-Encrypted: i=1; AJvYcCXzLvgOUuqasoFW5OlvUJ5FAyvzRu8bOtWOTwFf7t4dcLNEKS8OrOZopYjqWcGYQUBjhLnt0a03H7Wcni8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+ECSf17cm0GBGgDC3dbNoeBuqclgCLUnc1kPBMCVPrcObgC1V pCrzzbCxqpjJdzljnzB3QHvyCYB3/zipnXkfjRjKDdUjXyTsrkbocU29y71loqs= X-Gm-Gg: ASbGnctRsq4YHnHzTqQlW+IE6P5SDphtGaLXe45yZMAYqIqR3yd/UeV0o5FRbR2N7RL 00U4xuQ9lSgOr8XOjXWx/cybnt6fBE9ypipmm8VK5N/RKaccs5HBMfjeUuaG9IgWAoWQLPHx85q dOWFR2j7YMYV2Xp4ry0eVXhb/YdnsxKcDVhY/n3g0HZdqZiIKv3NDA/PhdlZ7ad63sdCp6LkTFh rGi+ZISxaQl0uO2dQI1s9AiAFesoUJGx34aB6SU2+rnvUo5rlp5xNul78WmaZ8fqP7lfo5C45oy NBfHrl8nHGav9ZeB+1dHSGQqWLCU X-Google-Smtp-Source: AGHT+IFgv3L3zsor+TgyfP78cIeIu8na03bo/tdai+ppenHCk0PSZruKWml8PrAfOHPg+AysJiSwag== X-Received: by 2002:a05:6402:2089:b0:5dc:88fe:dcd1 with SMTP id 4fb4d7f45d1cf-5deadd7fdbbmr3639946a12.12.1739379853331; Wed, 12 Feb 2025 09:04:13 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:12 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:47 +0100 Subject: [PATCH 1/8] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-1-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 From: Luca Weiss When num-channels and qcom,num-ees is not provided in devicetree, the driver will try to read these values from the registers during probe but this fails if the interconnect is not on and then crashes the system. So we can provide these properties in devicetree (queried after patching BAM driver to enable the necessary interconnect) so we can probe cryptobam without reading registers and then also use the QCE as expected. Fixes: 4d29db204361 ("arm64: dts: qcom: sm8350: fix BAM DMA crash and reboo= t") Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support") Signed-off-by: Luca Weiss Signed-off-by: Stephan Gerhold --- Luca sent this patch before, but it was never applied: https://lore.kernel.org/linux-arm-msm/20240108-sm8350-qce-v1-1-b7d586ff38af= @fairphone.com/ --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qco= m/sm8350.dtsi index 69da30f35baaab67e51afcbca3486fb89c14f281..5f93cae01b060cf99c0de56f603= e860aeebc5f67 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1806,11 +1806,11 @@ cryptobam: dma-controller@1dc4000 { interrupts =3D ; #dma-cells =3D <1>; qcom,ee =3D <0>; + qcom,num-ees =3D <4>; + num-channels =3D <16>; qcom,controlled-remotely; iommus =3D <&apps_smmu 0x594 0x0011>, <&apps_smmu 0x596 0x0011>; - /* FIXME: Probing BAM DMA causes some abort and system hang */ - status =3D "fail"; }; =20 crypto: crypto@1dfa000 { @@ -1822,8 +1822,6 @@ crypto: crypto@1dfa000 { <&apps_smmu 0x596 0x0011>; interconnects =3D <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>; interconnect-names =3D "memory"; - /* FIXME: dependency BAM DMA is disabled */ - status =3D "disabled"; }; =20 ipa: ipa@1e40000 { --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF8F25A332 for ; Wed, 12 Feb 2025 17:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379859; cv=none; b=TwXr/O7/a5jyhmU9miHHkT+VBC/3h4TD95WPHuoDJeJWRk0BBO1bY/lPvEzUt1viv8N67hFWkeDBkozd0lfDawBHAvN4+3owNWMWJrNPogzQoStN4PEbr7OlmgapXHSic1p8EOACYSL2GBRjYaO/eFXQVcKwqWBhufI0T7Zreyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379859; c=relaxed/simple; bh=sItJi983hvl01AxWCTmMFX7g70a0Fg4QZpXz/Tz/yyA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C1bformVZHJh6uAHa6E7Ow3vsEk8Nex/FlUrnD+QAL2no+TovFaTCcs6WXaHTKgq95wFiI6CYwx8BoDxsfFNO9UXLRc5HNH2ZZwuEQ8nH5pQ/pCxoyEuPYvf+QjrhHBrNQiS1h8bB38JTdCXCwY7EPnTnj8SUO+dx8ks+oii6bM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fplOecLa; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fplOecLa" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5de64873d18so7968964a12.2 for ; Wed, 12 Feb 2025 09:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379856; x=1739984656; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S6w5okXU2Yu7jFnBUo43BoM84SGqbG4jaCw++xQVChE=; b=fplOecLazFKo5bPFXcwrIqQPAKwTv/hZFpxZ3qpbztC1+19mMbHK2yFc9WbbDYe6ET nVv2e+6D9DuF8iYMYSAxCSn/+K7FkrhohfbI8R1ZB09JmdhREq+uNQG6asRfeB5jYh/R J+/O33zB22fnrkfnKzU0nYNvaA4t5FsRiE7uN6r2KtUFu6E5ep0JGhidgUksXKaX3ooF +6HzAoeAOFLQ0qAFQ8YyuRiHkQTRm496czah6qCk9eTAO8m8wW1gI4sW4WJr1RwIP3Gx Sd3sHqk/+hdVd6wIigKkkemT2eCMZZfsWf5jPlJ6LBsfXRPK/k3/hJMUk3yD2IN/i7aP HHJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379856; x=1739984656; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S6w5okXU2Yu7jFnBUo43BoM84SGqbG4jaCw++xQVChE=; b=h8kBotKwclJrBAreQj3npttF1yKzsGMunGESJhtHvyuUAz3ctn5ZELYc/Jca4vOI7F 6zz0JdCV+gZq4isK8JShDy0jmg158x7A9rDy5bN+SZXQFr+GjujBMvxwORkPt0K5FKp6 mO1+aNpKSjdEsQ2dKvAAkw4N4PnzXGS3YViBnUlksL0BppifZfjNhiNSBF5U555HNEcr FiyfmalbWdmOtRY/IehLx0c2l1u9hr0XP7114xzJ4OHFV5Oa25C645s0ipPXjM2MXupK 4Mp/V34S3YtkceFdOPKpfkF02vEOGWItygzXEKfAnD4ywmVJ3YBdamXcBvpaFqVGIBbh NvDg== X-Forwarded-Encrypted: i=1; AJvYcCVRQoifG4Vwd5x9ivo1XX6OIN9JH0PNP/deub1fhOhGYZ/Sc/C60aiFXGBIOOzzDFpRHBwk2h9uLj16XjY=@vger.kernel.org X-Gm-Message-State: AOJu0YxubRX9Qrwei0nQ09VMepfXpDKydFvV0xLKF46dKk6CXPHkdp/9 u7ceLPgHzzOBzVhl5LB3gJ1TJmhteof2PY35UvxT6yEDpTkdJp7XQCMumdQIff0= X-Gm-Gg: ASbGncvYiqRhEypxmbk2kFBlqGoxV8xQrO5Jx/WywcaOJ1dkXgjSGkT4qIVVOiNOtXO F5TH7rQgllagOEPkE+tDozF9Q9k8auaiOU1gaJfzki9rASBDfU8hk7FrW7gNU4t9r20gCWq9+RZ uUGREFH9m3fXcqUJJ17OUV0uoadD/ma8GEdLk2/yjB//vKG3VnyE6q+QBB26tqijYpqCLhKATXH SJMiBgZwvQaRxMENfDgaj5rTfV2+gw3BmGfcoFD+l47DTG98xDkbmdbFlbSll4e5kDE4zW+u275 LSd2hiVsNmf2CKCu0bg0b/tfQdZ/ X-Google-Smtp-Source: AGHT+IEABcOOIELXz+JFdeOSsPBTKQScoxzR7QmtBueg1gF7h6+a32NeKWZuRnmzY2n57dt66bqjMQ== X-Received: by 2002:a05:6402:26cf:b0:5de:42f5:817b with SMTP id 4fb4d7f45d1cf-5deade15403mr3357122a12.31.1739379854662; Wed, 12 Feb 2025 09:04:14 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:14 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:48 +0100 Subject: [PATCH 2/8] arm64: dts: qcom: sm8450: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-2-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@= linaro.org/ Cc: stable@vger.kernel.org Fixes: b92b0d2f7582 ("arm64: dts: qcom: sm8450: add crypto nodes") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index 9c809fc5fa45a98ff5441a0b6809931588897243..419df72cd04b0c328756fdc484f= 4e46b6c325412 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5283,6 +5283,8 @@ cryptobam: dma-controller@1dc4000 { interrupts =3D ; #dma-cells =3D <1>; qcom,ee =3D <0>; + qcom,num-ees =3D <4>; + num-channels =3D <16>; qcom,controlled-remotely; iommus =3D <&apps_smmu 0x584 0x11>, <&apps_smmu 0x588 0x0>, --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B37B025E441 for ; Wed, 12 Feb 2025 17:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379862; cv=none; b=DqCmfIUei1UMS3PcKfUZlmJj32qhlFsBtNQedYUrmSaEGeobZoumOKs94Qq3/SQZIUaaCr7vVI8yOjPVjKB5esmlIY4SJ66A1blRL6+HI6zeYMH0/8ZW6QQoy+xUwS/m1rXUlXImGeyrE1vUzR4e2UPK/N2LkY8je67WIaEZG3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379862; c=relaxed/simple; bh=0qyK2u3z/NjnPLJ+3zpCNms4pKQWuPqdWHn9aOhe7T8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qiuaFulJvnpozZ6SkOIMhdjX/ozPak1M0vw4vDpZ3L47XRO9E5FQL+xtdp14MrCzVgp5ppowgkZXj8gGLrhMT/Y5cSOt8b0rnTW5TQ3o6PAl2FFHcuZOjDuhl7X7UkaVZgq3EtQyUggMH/L+kETPNFFShkdZ9l9ICJwYW2nlrBw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=flHOZUoS; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="flHOZUoS" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab7c6fc35b3so595740766b.2 for ; Wed, 12 Feb 2025 09:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379858; x=1739984658; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UyOxpDSL06VJYzsC7GVy/mIHwyNXFSDSkM/lCd+8REc=; b=flHOZUoSvyBajKJqvP+UiHgxPZziw91JOMSZ50wsveGAHG4eVZeYtB/rGOhA3x3725 ymQQL5plbzhXw/VtTsF+8a9ooqvK99kGMJDjFO/lkk3ptP4elqUTu7WmeWor8l3pioW8 fiWMOuHZRGwHMR2ucE5zHn+S3Qd7q4ayaGZRz7fj4bFzm7iwHaMVUCYC0VQ2UPrJHobo 8E9loQ3b8X6ODL5l2XdSAq+fZmJc0XCPUqwz+hLrTZtHF7CFtNBq0WMHD4XNHVBwEbE6 BknFTuZn/K/KFLzZu2sEcf1HzMrpML1QcN1PQY2O2T8kXTtY0h1PtspRO+71JgjeiEPI X/Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379858; x=1739984658; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UyOxpDSL06VJYzsC7GVy/mIHwyNXFSDSkM/lCd+8REc=; b=ILlnxARjvyyXrkW3T5SfFI+SsZUV4KhjTR0p4q2sUNUflWMQt/sd72G7/BoINxFygt DPgb0BtKGnbzd2pU7WiXk5pWmHt55zt13DhLDpS54UOKQWJ90RwQEnwOK0/r6+aMp4l/ 6zjiQeDkHMS6+sTRqyhmBJxBzoHzqSwuzT4qVsfuGuwg1aU9dC9Wex8OvSMENiHTTkyG /suRph4V1j9cTB4p6jaAk5klhPyZ7FlQipkwuTacABeEUNkIjdNA05ZkKiyNUhzu4dci D4GCg09kETGy/rGuEqg6hcnCld/PxrDqz59MANFQY+YQ2AZoSpB0H6jwNbazPC0MR9u6 WmvA== X-Forwarded-Encrypted: i=1; AJvYcCUukvD0b9gk1P9sKYOtM15px9UoAnaBkNPgurawdCr8nufOvHA7cbwLml3568lq04UsI83bp7bDL8CTy7I=@vger.kernel.org X-Gm-Message-State: AOJu0YxKD3wzGmUmCl2AHm/lwAwnMH5bSwk5yrrsFtSH2pD2yQTCmySE xI3RCTEUBV1/Lvv+sooTLQ5gcBNyO8us50t264PMUO9N0aja02QgUrEQM7PJDRc= X-Gm-Gg: ASbGnctKm595TeOZoRtV+E/ugm59eJD1pFPQPILz5uz1j0/SdVikGZXXHsDeIsczMKF uioxb6qqv01DOjUaFXAsiHtmR1vNUqyVcz1dC8EHnquV9ZAkhzYQN5qOxs6xlunNvKqok0g3yXd gjQkghSppmvqMqETgNNpBK6bLk9EmcF0kKXrKaWdYEY/Lf9Nw+l5kc6k+JZ6W2jBAf6wCCQoar8 8cYxRuu9Z4q8IvwLyF4ETjLpg//DFTMWjUAUQ8dQcwkqLrCeSl8dv994twI9vAiMtB1nbZMfC5X dcQ+dQaCPot2BbN7TeTIAsXHUhC+ X-Google-Smtp-Source: AGHT+IEfiTWbMpQQLn1RJXdfkKpVVIRE4eJH1Ib8zZn4l3QF/V96r1o6kde9pJJhsidNjbz7Sos45Q== X-Received: by 2002:a17:907:7249:b0:ab6:d0b9:8fd1 with SMTP id a640c23a62f3a-ab7f3787affmr361088666b.34.1739379857852; Wed, 12 Feb 2025 09:04:17 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:16 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:49 +0100 Subject: [PATCH 3/8] arm64: dts: qcom: sm8550: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-3-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@= linaro.org/ Cc: stable@vger.kernel.org Fixes: 433477c3bf0b ("arm64: dts: qcom: sm8550: add QCrypto nodes") Signed-off-by: Stephan Gerhold Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index eac8de4005d82f246bc50f64f09515631d895c99..ac3e00ad417719be2885d76d319= 7f96137848337 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -1957,6 +1957,8 @@ cryptobam: dma-controller@1dc4000 { interrupts =3D ; #dma-cells =3D <1>; qcom,ee =3D <0>; + qcom,num-ees =3D <4>; + num-channels =3D <20>; qcom,controlled-remotely; iommus =3D <&apps_smmu 0x480 0x0>, <&apps_smmu 0x481 0x0>; --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B9EF25EF89 for ; Wed, 12 Feb 2025 17:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379863; cv=none; b=O5Q6hXxx2kU6IeZ3CayYiKlBDsHuYSPS+IY9qZO/78pUzGzxX+2Nruj5bfp0Mv9x9bEmpGKKhKh/B5F4LSCkcy9Hs/jsAkJ+ANIblUEcyUDOK7+KouRpSKsLBQb0czKxuWWYXXNjw8zgwaK+kpw1PAVCLQdaHHJ1s0fmulqwMxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379863; c=relaxed/simple; bh=/NYZuVJ5CW8Pc7756jGUtf0Lv3irVG+gP3QhGB2cFMI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qZAn1bSvHVMeX5SF3SDMt6CyBx4kqAAlCxS0iiaTtWD2xCLjhod/9eCw9Po5KY1pJDnFB6MBOopRq+p4y/ejefSFqNTSsc2IM6BsSFeZQl50HkKozFDZ9/BfgrTvfDE0YK0pmAHursI0MJ4YCL1Jo5RQoLLArc6+BLd3sROfViI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PGxUY2on; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PGxUY2on" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so2111376a12.0 for ; Wed, 12 Feb 2025 09:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379860; x=1739984660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zYw0tG/nuWEvSbLScJnWGG2Q11zXbK7g2BHQcn5xcy0=; b=PGxUY2onQ7l/ynhXzdODhL+LJ84b/njUlAb0Qfc2wsoNq/3YrhAzm4R5yaGIUY7TOD J7mYNxdYBqbpL9kYY3Cw9M5Dt38OTiJdmuliWGbVGKFDoifnvU2MfyYj1qHDL2xR97TX Xtz0Zt8a94ML64LhZndC88WcnG4JFnO3RgnDroNATRZ/xzYFUKdKJyiy2M/aSsnQCbkc gaqEoab8HNblxbUHGmHGSVdH3tkwDiBQ3Fvxnh/L5T+FF9KGzJiEPahghjjQYFd/ChPI lRq8a8kLFlYNmI58PhtjUqt23Nh4jnoHHx/3z/ZOfsDBKfQMrkNsHxnIF2PRgllzSGQy INkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379860; x=1739984660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zYw0tG/nuWEvSbLScJnWGG2Q11zXbK7g2BHQcn5xcy0=; b=NV6dNS4bboQqjDH4tjJ1ZnSKREarM5FZBSc8Zrpbcf86Z90eEy5vwQR/RiLD9nduV2 DQ4Z4nNIkRdxt/AWbGPpq4LLHIuMYPLKaf31yUJTPs8aWNNjEGacbRVbDiM+8554mp0F /G4AHWRcIoOpPUGtYTJ4r4IAf87+N3kdg3sIKQHFEO/9lT8NTlc2FvHisVSFpMkikb+D EbCl5o6ZDPJY1R99L0Pnli8uUqhQOIZoxvhy3pKcs908Jeo91nHGY879j41f7ME8N1lG 8UPneODk3jiMxI5UCEuhwAxpcGxymGNXTbj9ntnNZ/cr9jiuvIMvGI/U5nYoRHpkoHem QjSA== X-Forwarded-Encrypted: i=1; AJvYcCWgxww4c9O+0A4oECfyC98j3QoirwOIlelR2K4XYhmN0d9L71AOMczsx5nHEB3JMXgQO/RslTdOApmC/zM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/dB0uUeL9BQ4UP96uuRx7ReqPPrVmep0y/fj/UI3yZrvLTlQy FFgyQHVznro2yV5uOpWmr1Z6v00OPHo1CTdbWb8Hh3DwsoUorXWwTwHsBtxSn3o= X-Gm-Gg: ASbGncuCtCCMbWU3GV4s/XILOvRzUOzldeHYBTUVmnmTvMeplciXrxPTLxOxcIMWAeV 4tzlA4aGIV9qSzwb/0dlG26it1xbEanvlrsXkoz40qCveAyokB69/GFYns79fB8r4hfjBY6EPWr MS6sQ4eHJkMSrtJG9zfVEjkjQkP8COGRVeC4ZuHGGwa4j1g2wSOAddDutJosrFvzrsqUL/PjidY pSUyOCmBKo8cxOOVTD6Uj+7kBqw/Qg5nNa4oXRIci7A7NdOigLH+iQ/kcwLfg7tucUHUsJley+Y 8OVSOWnRE+1qCWlDr/HFSwogqhv0 X-Google-Smtp-Source: AGHT+IGwS9pGhWIrn8y879zF3bgF1bakf9yBm5N5I3DRe/DsDY25Qv96woF2RY7pM8YiIFh7fSb+cg== X-Received: by 2002:a05:6402:27c9:b0:5dc:80ba:ddb1 with SMTP id 4fb4d7f45d1cf-5dec992221bmr34314a12.14.1739379860196; Wed, 12 Feb 2025 09:04:20 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:19 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:50 +0100 Subject: [PATCH 4/8] arm64: dts: qcom: sm8650: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-4-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@= linaro.org/ Cc: stable@vger.kernel.org Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent = device nodes") Signed-off-by: Stephan Gerhold Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 86684cb9a9325618ddb74458621cf4bbdc1cc0d1..c8a2a76a98f000610f33cd1ada8= 2eebd6ae95343 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -2533,6 +2533,8 @@ cryptobam: dma-controller@1dc4000 { <&apps_smmu 0x481 0>; =20 qcom,ee =3D <0>; + qcom,num-ees =3D <4>; + num-channels =3D <20>; qcom,controlled-remotely; }; =20 --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9498D260A2D for ; Wed, 12 Feb 2025 17:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379865; cv=none; b=un4A6S8NArjZTCrwDVTds6Dp2k5tJHU5OHWSS06sBXTdh+9f76t1cFDh0VeL2q/AuauWsHTNrMMfuF8RIklYJra4GgG6+1oNqMuXJqyazhYurL5D2+RhHhzB13tMPf/5XF4VhefO+xW5N8RnQhTZN+XLhmOBWNkGx0yIf2xa+Ag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379865; c=relaxed/simple; bh=4w44mTqF2bkyVc76fDw8rdR5cONqNjm0mBoDtJiF+zk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j6WLX+f+ZdJFhYR5pf0yJ56NmmN0YhIBcyxWV41C3ICiYeQPZfwCJPjETWk4d4SSHfPbjpgNPfRNnYWMrlKiryD7MOCEkI33iutuNB+UO9XDsQC9xxxwlNPZVsXVyU33IZrKXxC+SgPkcczqZPBHpOucu2/IqB0UTpwfg9pgJKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yoeZePFy; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yoeZePFy" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5de5a853090so9942832a12.3 for ; Wed, 12 Feb 2025 09:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379862; x=1739984662; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Now2NkxuPWvV2DBMpvY1YciTmYHo1FaB4LpFzdcs/7c=; b=yoeZePFyngUDYFlyXaXcVIXsoebUkK864jzr/WLOgZLCa9T5EgYxBQXi4kTrKMoCv9 ZuL9yasOSRjxWUKm4yMd2d+CAE0x7k629nMtIT0IY0mj3soFhlWZygOJVXrLYuvKY+Gu tNBV3UtYB+0xpGUbRkwd0HiDGSSA31403gvflaRhKEL13GxNxGnM42H9unEVKcX6TG/k +P+d4DiwztfoPJlz+ZCq5SF8vYhWWElOaFi+7UtL62OswWLAueghX0tZ/hixQVaFQNUc zgHtJ3Q/ho54SWRGzLT/NFTQzkTo9mIo8r1Ph7cEyvpiOfLt/jb0oHrM0gkxd5fnP72c zbbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379862; x=1739984662; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Now2NkxuPWvV2DBMpvY1YciTmYHo1FaB4LpFzdcs/7c=; b=At5iiwEdXa0DPZL2O5Yq/jhqMZPNqg+H/PM2tN7ujbQiZurmvVxVPsEFDg3ETCGJjk D1LR+rcCCKRhoLQReHSy67G1SMO408/bjGGrfnF2g0Br3ekndz73GBRbk7rsZvaTAv/X DdMgAHfwkQGDirq8SEbGTxWIN43CYVlk7lreo1xapSEyuu2FpGGELhZgLs4SGyTaHX5q OuT6Y6ZPUAmyYrlZvGhFAvhLpTrRodmJ6Ybejv6KZfyed2Lm3o2TZ/EydzS+DBYkK7cr OwkN9jljfHUSYIL/GFsQpMcHFe7EFcBCdmcGJuGN81GBy3wi7JCkSnClrF+brXDYZJSR NHaQ== X-Forwarded-Encrypted: i=1; AJvYcCXg8o/FuZVBjbHcIADEgWYgxck2lo6Nj0BhlG8W3cEu5JTCey1ckQwU4xSQ+5P3R6D1mfW1gM/AUUr7tHU=@vger.kernel.org X-Gm-Message-State: AOJu0YyukdYdUkDXv+G235m7hbzkBBGVqZsUAlk1lvrzMgIczFhpRtXe u+N+YELxduByH3eaf+dtCxnVoYItRJv2rS/7j646FAZ3Bq3NaL7f4fQOpJ4eKgs= X-Gm-Gg: ASbGncvmi4TCZ+PXvvCG7sf7XK5Rel1PPHA5ABjJ4dfllbU+KBQe64Cmgh3M5HJ6Uhe 35bT5UKh+s0h8RP2KYroMNULHuU4DECHkN7U2/onOPT6mw3qIgBUutdMVwXaHtAubh99ZOYdKHB j6eh58q0V4vK+PpTo9rWaDtGyFN9e5shhI23+uMObxeb1rIOMdFnV+u06HeW7V6ESb5mZxr3NSK PDiM8pjuzw9WxJHmv2+9H6l/Yg4DT/95wVcfTDZjFXaHUhP+nkEb9GLtOWngegHWz2taje+9nEQ MVo6SBFugeSGK6yd0lUJGz8xQG9i X-Google-Smtp-Source: AGHT+IF9uLV5BjL7W/hlLhRIgJ5kaxpUOWiXIwYcgEvXKhAZgDqquhFUvl+Ya9kh98It7qH6hh74Xg== X-Received: by 2002:a05:6402:40c1:b0:5dc:1289:7f1c with SMTP id 4fb4d7f45d1cf-5deade0a57fmr4072086a12.29.1739379861924; Wed, 12 Feb 2025 09:04:21 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:21 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:51 +0100 Subject: [PATCH 5/8] arm64: dts: qcom: sa8775p: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-5-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@= linaro.org/ Cc: stable@vger.kernel.org Fixes: 7ff3da43ef44 ("arm64: dts: qcom: sa8775p: add QCrypto nodes") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qc= om/sa8775p.dtsi index 3394ae2d13003417a15e64c9e47833725ec779e6..8d7d157ff2f56a31a97121c882e= 3e0336356eda0 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -2413,6 +2413,8 @@ cryptobam: dma-controller@1dc4000 { interrupts =3D ; #dma-cells =3D <1>; qcom,ee =3D <0>; + qcom,num-ees =3D <4>; + num-channels =3D <20>; qcom,controlled-remotely; iommus =3D <&apps_smmu 0x480 0x00>, <&apps_smmu 0x481 0x00>; --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38749256C99 for ; Wed, 12 Feb 2025 17:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379867; cv=none; b=jsPOedaQebrZjkK0qheNCjT5hFH39J+MdrvegM1H75YfIcj2eExSj0GwRl9KLsr6Zp3FtHkkmcVstB+XDn6g3UfVOE07cG5WaX1AbCbKgbDurE89RTP4koKJ+sZYhQ6FVKtt9pSqmeSN5gPgYQ6VQ6AAukriahWf3QuwP8goVfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379867; c=relaxed/simple; bh=75avUCDFzU7VeEjRm5mXzklFEoM13F5FbLiujKtYn8A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WPwZJpe/ymSj4/p2+dwEvk8w7yFMOPYossZN9+IbxUJVLoH7Ze2EdIj5b7uY07ehPd1zYSne3Uza7VWubHvJMPty+i1z2BK8nhxMG1mXdYnsU7wE/8HN426ZjHPIqPkvJnPZSBUIOG9sii04pw6CT1QXwLW/XfWa8HqI8RscWaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AK/CMOyD; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AK/CMOyD" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5de5a8a96abso7708301a12.3 for ; Wed, 12 Feb 2025 09:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379863; x=1739984663; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EdKs3PqjzG7VzXlZTliJiBHpYVpLmHoLigdOAH1jHUA=; b=AK/CMOyDspRGKpErBhsx0x9jrTAGA3yTTLt7nv3f+Fx2CyIPJ8DHxEoqmLc5K1hGKZ 7xM5cV+T1dpMq+lEh3xbbIJDdeBsBw98IBI7YElHf08W/M/gTDDBcZwPRZfCGPMqgwKS 5RWMre8Xn6+4kv6HflxGMaHOzPQAZdr+ZFOjVIarO1+dsjl2eT/KrMBwUfvNbXM8bhYp f5532u0xDJZrRL2tFFzo0qaTgT4tn381+/zK3aBfc1QTsRJzfxK6uhQLiTFZ9TRHV4Ge UTRpH41YuCwEiFoaHMdB3Hao8rfmhuzp7697rEOeP8LuVkiX0Q/6gC7DItrxry0BAnV1 QLeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379863; x=1739984663; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EdKs3PqjzG7VzXlZTliJiBHpYVpLmHoLigdOAH1jHUA=; b=kfvlwnukoXbEler+EOUzGapsk9UmIn5cp4Q148vzkopo/f7SBoRGraEFwu/6mfYU3m gombXglI+Vq0XTKC0Q9+G3PWcQ80eRv8V9ARs7gJVKcDit4pp7Cjj02LTww+GC7RdChp fGv2/hypkcy/CzVoJtGU9f7rtGdaFcNa/opASDVMbyYu7j4pVVnFmIa0QsHH/TXsdwg+ fyy9GzqbwUw7GHnsz76yE7T67qJyOw6dkI8dTjjKMjmYIqEEiZDya5O25jcKYtWfTdg6 CcbIGvLrqoP04QOgxc/ylJMKb0X/gr5HiltGW7XhKhDG6Tnfseu2VDTMjsg3qLtH4Zf5 tYvw== X-Forwarded-Encrypted: i=1; AJvYcCUcoH5TrsxoFlyL4vOKJpIbckUFDQ7TJj8KpxxQKm/kyB2eARKKGHTVRl7BxBfpnKW/+uPMmJow/N/ggpw=@vger.kernel.org X-Gm-Message-State: AOJu0YxNP3advraxTQaoQRiljZwAgo+vROd2VEoYlAwI/vMtUEiMyR58 3FmG64trt82rTAMDaBrBp1yKGKwnXsxiZkAfgmWh9kOY6JSzR+oBldBYLw2MMpU= X-Gm-Gg: ASbGncv9Bs5iRd2DA+0DqUh6xn4Z2/IAHznuxNXvDz7we/TldKclO04AKD8cRYIwJi0 PyvUkEewQ5/Fa2Xjr9Sq+lpevhXNqKj1E1wjlIm1q1dWZs9pq8XSoGATTTKPD93sd1uqpMLzUVb xYZ0T8dMjY+ntCnINus3S72V5caCOqInehBoDwt/ZiE8Qau9Y2l8qJrGsuBL1ygPNo3PB2Poe7V N9/NZbVe1ai6NRVgeOJLVukW+un+KxtJ3zPhMWq1AU3YczdRW/Oi2z9dvc/qcMvYvyqkmh95wYe Z89UkWd5UsNthHxqPOKblJyAcypD X-Google-Smtp-Source: AGHT+IEbKqXhYNAGULvZAeRYgXuqy5Tc0W6a9RU0CYtO1rrnjvygarfucO6BvycCtWQunp05lZe0WQ== X-Received: by 2002:a05:6402:518c:b0:5dc:d8d2:e38f with SMTP id 4fb4d7f45d1cf-5deadde71e1mr9275663a12.31.1739379863190; Wed, 12 Feb 2025 09:04:23 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:22 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:52 +0100 Subject: [PATCH 6/8] arm64: dts: qcom: ipq9574: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-6-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@= linaro.org/ Cc: stable@vger.kernel.org Tested-by: Md Sadre Alam Fixes: ffadc79ed99f ("arm64: dts: qcom: ipq9574: Enable crypto nodes") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qc= om/ipq9574.dtsi index 9422900289725774da8cfea9848529891038e57a..3c02351fbb156a314b7911def3c= aeff0c14b92e4 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi @@ -378,6 +378,8 @@ cryptobam: dma-controller@704000 { interrupts =3D ; #dma-cells =3D <1>; qcom,ee =3D <1>; + qcom,num-ees =3D <4>; + num-channels =3D <16>; qcom,controlled-remotely; }; =20 --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2951726156E for ; Wed, 12 Feb 2025 17:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379869; cv=none; b=eBYIjvSUlZSK5ZxVRI4VyIBpkZo8Z+OTTSFqEMWH1xz5Om3DWDPEHqKTqxO82xKpRIPK7ipHIQMdae6Rtj7MCWFvplxeKUAwY3mjIT3qQcFUOz7PSSY2phLrPyZ144bakRhJv6y1n4j68hjrbNN+jpLOhbQ1tRNrRfugYnK11W4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379869; c=relaxed/simple; bh=gm/du2YybA38W7YJqV/I0UhkP/ii9HBt6Lhq0K+G8zk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jkb4znKZOFnrXRmSartNZbZOC5gxgQffGOv9DQjfTptlBDPVvb3OYFN+EXHKhxwLZjJjmFQPvH8DI08clrVfsllSmsYU9mfWGW1vbGE6WbOd05y20jNQeTwxWWXOxPTQBieByncEP+WTcvN4HDLxFyJB6Rdvj1vde74vLOMEtcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FfwEZOHQ; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FfwEZOHQ" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5debbced002so943822a12.1 for ; Wed, 12 Feb 2025 09:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379865; x=1739984665; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ImRVu3AddUI/G7N8wE6yWqCv2pDeO8zZgPLOwwAUrbQ=; b=FfwEZOHQ5WfoIzMz/vMtt3jhfvrybbKssShql2Z4raVq2oeUWvBNQSNgbwv8X2DRot d8rWvrXbZXXdae5XZ54YlP/7cDZ5EZZ0Nh9vgbPYmML7xL/qj4NXuwOWzzePKX5HAQpb RGgGN2JILGHceifqelmt5Z8K5wMthd5g12gW9HpyLScSkrUp2FnNoizA/fMAfh8eVQx6 yeE4+bS9RsFDvYknZ9YB4lavp2FRqqWZvpABG4fWWUXMnn7IlfLGkkpiTV3kCL8y97Zn 08GiqlY526PhhQAY4nwig49fb3smD83/shfIaKAaZMxznC+WCFJvy4SPXL4F5PR5XjOk N+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379865; x=1739984665; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ImRVu3AddUI/G7N8wE6yWqCv2pDeO8zZgPLOwwAUrbQ=; b=X3EQjstTZABoRFxq23JneNreqFEs2IFA+CkqORko2od56/wW6qryXIGghfATuwQLzM PoBKki2f3s4SLOAFKsMckRtLYM8daoiX1kSMzMatouuJERESZZg8Cpnhdci7ROzWyHMb dg9+bS9OPUI/ICzk+5GX+PB5+BV3T28heTY1CYy2lzRI9jrVBp2vmkhAfGT1fbZNRGXT TPVCKxgPdLcUMdTLbONihLUB/uvmkXWJ5roC+U9uPbHEkn3kaqTE0IHiKvwUspUNgcnz GTMfLmT+8ednCJzo/TVa9XTP865YwwzUBS+0XU296ie5s/ekM7YpdLfjhngEMnAWwuds K8Wg== X-Forwarded-Encrypted: i=1; AJvYcCUwRuLvE56i2+v/YJWienYtxTBrqe3PATyxpyS95n7zF4WdfRFuIkZNkiqoe9aE6eGVwbphB6psmJF7Kus=@vger.kernel.org X-Gm-Message-State: AOJu0YxVG7g8cXDDppCQAtxYKTpykCM37MsMshQOLzttJzEC/nrHVEYQ ZicgNVFMsbHwCZT2R5RfjakkzDwUSAjH8PX84o5lA8zTC4NUVZ7KwYKEmBEjZBc= X-Gm-Gg: ASbGncuJt81EQh7ZHrezgzt6piHgo8JTKzy+bZdU76cjltR3Z7GKmVXcYUw38ndZuLq p/AvQhM5vACuU8fezF+Wga/wjH0P6OwcBg5zj5trtsvHCu8tQaH5BfuEmEGnfA97gT7XyL9baL2 gl4XnrA2pY5ixpLo5Ys8oDG6yzryG1X40e38TtNnXp+I+akSR0gLD+6P6vMfBcm9WcCTjnhQ4E2 b3dcqEwfWe7/Al1arGArycWIUOwBIfOIe0GxgZazLucWQoMf8LcLyqW8R4qXOB/UuwobBfuM+mE uvrYllzpOSPiQ+vrBrNudalMDve6 X-Google-Smtp-Source: AGHT+IHcYXuecofg3yiMP0NUjYpDinedFykVXcImtUN6fTzgyJOzlkYtZX415Z33x8WimpPahFb58w== X-Received: by 2002:a05:6402:2755:b0:5de:5939:6c34 with SMTP id 4fb4d7f45d1cf-5dec9950b77mr20409a12.15.1739379865117; Wed, 12 Feb 2025 09:04:25 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:24 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:53 +0100 Subject: [PATCH 7/8] dt-bindings: dma: qcom: bam-dma: Add missing required properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-7-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required when there are no clocks specified in the device tree, because we have no reliable way to read them from the hardware registers if we cannot ensure the BAM hardware is up when the device is being probed. This has often been forgotten when adding new SoC device trees, so make this clear by describing this requirement in the schema. Signed-off-by: Stephan Gerhold --- Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Docu= mentation/devicetree/bindings/dma/qcom,bam-dma.yaml index 3ad0d9b1fbc5e4f83dd316d1ad79773c288748ba..5f7e7763615578717651014cfd5= 2745ea2132115 100644 --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml @@ -90,8 +90,12 @@ required: anyOf: - required: - qcom,powered-remotely + - num-channels + - qcom,num-ees - required: - qcom,controlled-remotely + - num-channels + - qcom,num-ees - required: - clocks - clock-names --=20 2.47.2 From nobody Mon Feb 9 10:08:05 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1335D2627FB for ; Wed, 12 Feb 2025 17:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379871; cv=none; b=pUBnvp9Lyg32opNfzD+TNdPRtIL540CpIhXrf1ejeVrlS1CUofKPYdTHbIZkILIMzjObDuhPehpVzEOnhAKUT74IXuF+pRGSig/Lw4CserZo2LO6aMObH5qGpphsANoambnc0Cex6h5s2PevXfIQdrOjf2TS1EF7ZtbTXf+E5og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379871; c=relaxed/simple; bh=9GblvGNDG9q8+pnXs2ne763R+S7EoCxIKfwKsAhOSec=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q+MUGnF+OmuVp7y4qBUc3akmxHcNBkvnO6jZVbUICw3UzK8vAH+bVe0bja7IfSxpNNcyOEznr7RoXP/du4RkD7OvWVmbPtuxtTkp0kdFSvEYDu1oy9bqXDDjzUi7ICSE/AaRD7ou44C6G76L6oPWK4cABP+HrHRoUQjm3ihWnyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zCOJZoAk; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zCOJZoAk" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ab7430e27b2so1342305166b.3 for ; Wed, 12 Feb 2025 09:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379867; x=1739984667; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2u45ykvEMjVQISq5rnr9y3KabZa4tYoR1OiGAmXhk4I=; b=zCOJZoAkmZwNn/VaSbD0Kh5rRawMeIm8UJGZhx37Iy5x0RZ6Tv2IU5YaamE4o8YP3n W5kLzFlG6B1h+OxvZMDKg0q/Yp780eKg5d9Aa/7mDMvhfrvuUVQbjm2aAcgin4+36e9V r5ZNRwqtdIE33iVQISV+HxMKbXRJYbsAGl/7rk35zN1b2h3xp/Nl0FdCNr/dC2nPTAa9 CVCRsffpIGEW+z09RTkvuL9hu1BI2Q5+JTdwvz+HL/IylVqpptc8RfODS54hmIEU0RAt F06xoSmKwiZUN2mJMM6Cs3ct9WKCkj3hJyBP0jK7O/DzY5t3scb9ZbOvdkXn1IOBhinm xJWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379867; x=1739984667; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2u45ykvEMjVQISq5rnr9y3KabZa4tYoR1OiGAmXhk4I=; b=vVYOBfTB5K0X7HXWzbOM6GNOcXC6uHfNw0E8fEZCNt0JaBA+/pO0P/Ge3nxzdOt30X dNpp6Ra6c+8fLkFDs5aJR5paWIAbXLeci0QxD4joWcgA1qsjyV9ejx1SGwNRrOWOr1eQ WU1eH3gaWSwoqyiiwoQwwqw7e+/k+iwuNiMo0FpDb6vjK9kZjtLqTMe2ZyMD+QkgeNiC iW5YGqEAgvmoj2iIwSOVBHXLdncA1K3pb0ruw9hUFtTRis12NQGa75PuKi6z5edyDJM1 JUJ7hy39L7DmaujHjY5ney8ZHsDCODsbNXErjRs6OtGSuxseVqXVJuGNkoW80PGsCH9Q WwqQ== X-Forwarded-Encrypted: i=1; AJvYcCUNElPMliX2UMaB4Fw9VEPice8eHCYtXMh9ch+voR2uKMd+AKIZ7/s3zHhCjjPAVjOldMAv1ZkiHpNHjm8=@vger.kernel.org X-Gm-Message-State: AOJu0YzZO+lHCw6O29I3KKnvSeo+kyqnkM3X0p8aIGXrobiaiar5KM+y z3l2OKK4f9PNOVXKsjp9SxbKTkww6fA5b8lJ7G35itP8t35XKIuW+c92nbEdk4A= X-Gm-Gg: ASbGncunqbNB0MdykpkuvboNCsCeOsVGt/TEODSwOyrYkS1jHIDROiwdzqxfE1Wr9c/ UfbJLLeJV0smSlezY8qxS8KLHQhgrzKF0arpfdWzbURLQcGWa/gJqibG3BI8tUh7xeE9uhXy9Nf s+x9+B/EsXcPcflUiguek3YBl1RUBkD2Yqgw2uG2LM76nNUIv7mEpOR52OCxGe713pZ0ewWp4PO pEUqs+7PJK3HjGm19bT4HuvvV2Pt2bGfE3BSHY5XWWd6oTSqb3H0G3dDxnHg2qZji4ZJxTzcPF2 6JuzVPLis0oqX9VWvjv75GljQ7Bi X-Google-Smtp-Source: AGHT+IFU/2F6t8+fSl2upjgpc8WvZ1eQ0SNs2R3uJxgo7UkoEsUqfjjBa1zq+PYhAKq2aV9hNjVY/Q== X-Received: by 2002:a17:907:1c8c:b0:ab7:ee47:9928 with SMTP id a640c23a62f3a-ab7f334aa8amr340585366b.12.1739379866508; Wed, 12 Feb 2025 09:04:26 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:26 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:54 +0100 Subject: [PATCH 8/8] dmaengine: qcom: bam_dma: Fix DT error handling for num-channels/ees Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250212-bam-dma-fixes-v1-8-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 When we don't have a clock specified in the device tree, we have no way to ensure the BAM is on. This is often the case for remotely-controlled or remotely-powered BAM instances. In this case, we need to read num-channels from the DT to have all the necessary information to complete probing. However, at the moment invalid device trees without clock and without num-channels still continue probing, because the error handling is missing return statements. The driver will then later try to read the number of channels from the registers. This is unsafe, because it relies on boot firmware and lucky timing to succeed. Unfortunately, the lack of proper error handling here has been abused for several Qualcomm SoCs upstream, causing early boot crashes in several situations [1, 2]. Avoid these early crashes by erroring out when any of the required DT properties are missing. Note that this will break some of the existing DTs upstream (mainly BAM instances related to the crypto engine). However, clearly these DTs have never been tested properly, since the error in the kernel log was just ignored. It's safer to disable the crypto engine for these broken DTBs. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@= linaro.org/ Cc: stable@vger.kernel.org Fixes: 48d163b1aa6e ("dmaengine: qcom: bam_dma: get num-channels and num-ee= s from dt") Signed-off-by: Stephan Gerhold Reviewed-by: Konrad Dybcio --- drivers/dma/qcom/bam_dma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index c14557efd577046adc74fa83fd45eb239977b5fa..a2f1f8902c7f88398a5412e8673= e24b3c10bb86f 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -1291,13 +1291,17 @@ static int bam_dma_probe(struct platform_device *pd= ev) if (!bdev->bamclk) { ret =3D of_property_read_u32(pdev->dev.of_node, "num-channels", &bdev->num_channels); - if (ret) + if (ret) { dev_err(bdev->dev, "num-channels unspecified in dt\n"); + return ret; + } =20 ret =3D of_property_read_u32(pdev->dev.of_node, "qcom,num-ees", &bdev->num_ees); - if (ret) + if (ret) { dev_err(bdev->dev, "num-ees unspecified in dt\n"); + return ret; + } } =20 ret =3D clk_prepare_enable(bdev->bamclk); --=20 2.47.2