From nobody Thu Dec 18 20:43:11 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03BE41FE46F for ; Tue, 11 Feb 2025 12:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739275812; cv=none; b=FebXzwhzOwjqdpkdTzU/d5fB9wTKhSEEGCWv8zTgll8ISzKzwxZScCA4TRrkC5kvYpi9FvvgIA6rUSTDVj2xiYhLhCnkNS9j9+o07kqLbSgh0H4XC5BXHQbcJrFd4/TJRwHb5CcmpmlgezCuGQdAfR/64crVjdbtcvY8xLGOGDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739275812; c=relaxed/simple; bh=n7e1bRvIwDbJsC3TZV7mm+jegTR9TSB109s8PxAei5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZX2+biKBVJoCjLRkuAomvFVT8mSRX1f7Y3/ZYHYt9nezNk+5iujNnFPrWkZRgP+Rhzo6p7b9Qj+tI7XgQZmLFIO6gK2o39szPDqDV+5V6RRyWP2aAsK7VMeuGACiW7kR5n6PcBuABPPY9735bLegZd5rZqsLb0gDV68GVADEhBs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=VcCQe2g5; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="VcCQe2g5" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38dcf8009f0so1967393f8f.2 for ; Tue, 11 Feb 2025 04:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739275808; x=1739880608; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=quvfEdCC90sqn/TMYew/ubIOyPOJqPZJFKX/f1unqbw=; b=VcCQe2g5SVdGNzdqTRKQOsl+igwW0brDA8OGOwsapOnJwGP0CPmtnwT8Jk+GXoQYsT PmmrykH5gRph4PmIJ4go87EUwAQ/tQlQeHANoHo3lBIM60m2GstDGawfYbeRmr3ZB06S D4faRMv2SbHexs4Xrkk6Yru67886Q5XRZLRyEDSFZeQQWd+oEmOzwca1KjIGZ6sds5uh j7QVWiuMYWZDwNpGTbK4hzqvD1kIyS1djBM4SM6VSNSjy5qBF2dssbOtHPoL6k2l40x1 ML+YBK+Q24LEPIlhB9xpR2ZUsouJZYLyprgt+sKuToR4KOlcHlZc72kG1zdwwiw55ORA k99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739275808; x=1739880608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=quvfEdCC90sqn/TMYew/ubIOyPOJqPZJFKX/f1unqbw=; b=A1Xl0bQy8KhbJOv3/oRs998GlFEFiCdW6SWjKHVn+O0YaEh0d8RC8ijocql7AFVjkT HtZLESY/mQ53OD8eMulEPDtTfU4apUATSkd00HdTYO5KSoXGmIz7MuHqmFsp71SHDpNb g5UT3IRXvHYdUt13/9+JxIqD8LHDQKhIRDvWudPYfw8jggz8l9zxkOqEPZXpDOa5FGil JUMmkmit85LIwG4F9mhj0FtafxSw8rHD2JzeuT1DnyAB5SlYaIWjq1KZfDwoT/i3ZdZP VPoGNb9Gkb0GfDu5S95SNLcBZMq+bvuLkZmFtZZnUYWLdGo908ILpn5MzoQtyt+Z4AkV vudA== X-Forwarded-Encrypted: i=1; AJvYcCUw3VOySQl7Xku75EWuzs8JhbTVaM0Z5cHFXNNNXP1lQ3E7E7nXsu293i6oliuaswZdWqRj4j8DZ2yKhEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx1/RpmEhSpFkBFJZMRCpa/rmFvEs1SaBxyrDufWsVAHPQROt6 u85D/SXXkBPfXEreeEGkhJKpirHaIML/4kpHK99WrQe/DQPSGnLyPv+9nD5Ievk= X-Gm-Gg: ASbGnctS+QHghOPXGREF1S4t53NAv6Scm/Djpypf7Y+WnrZijBuTOFs5ldn6e2GGP4N Dx9gYeTqZy7SJWqaGbn24W3o6F5z30LQvgNKz00GBKORUVEFrpDmxFApHKEQ8lM+ox8zx2duVVu KKiWbnZhayxfaSrZ5htjG/Fkt40cNs48yPpZCKR1E0VCtzXACaWiQHijzRtGQK00LCaGPauWID/ vSrrLkFsZ2ZjWZcPiaXnaGadcGNA0h2QcUsJbJz8Bg+vkp04LzEdIALhzofFFH6UYeK5dOOSdNY vJHWpW0= X-Google-Smtp-Source: AGHT+IFFWsBDXUIhUnTK0Jc/gjJWtKAcXr7csTld6YJ7dLpzJy6WB9rdlWOzy1pJ6THp3Tu8nQYncA== X-Received: by 2002:a5d:64ef:0:b0:38d:e6f4:5a88 with SMTP id ffacd0b85a97d-38de6f45ebemr1250827f8f.12.1739275808376; Tue, 11 Feb 2025 04:10:08 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:561:8978:1d41:636a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd4342502sm9152327f8f.26.2025.02.11.04.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 04:10:07 -0800 (PST) From: Bartosz Golaszewski Date: Tue, 11 Feb 2025 13:09:41 +0100 Subject: [PATCH 07/14] gpio: pca953x: use value returning setters Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250211-gpio-set-retval-v1-7-52d3d613d7d3@linaro.org> References: <20250211-gpio-set-retval-v1-0-52d3d613d7d3@linaro.org> In-Reply-To: <20250211-gpio-set-retval-v1-0-52d3d613d7d3@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Michael Walle , Bamvor Jian Zhang , Geert Uytterhoeven , Keerthy , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2813; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=yTjxL9oj03YB8rj+0Yr3COMJxOa60Pm0eOul5x0rP3Y=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqz4Xxed/JiS9ru6Dza4dboG846bTEV9IzRV6m Ln9O4uXOsyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6s+FwAKCRARpy6gFHHX cszcD/9SlHyaBySPFpZFfk8U4HfZDjFSzdzmXpCWmAL6IePTYbDVbk1ESrU1nA5ENit5yAgv833 63xBCYyULqlZzBtIxvbJiLO7pG6K7peyNg50Sh2XAPF0AwcreWx6yI5/8UDqqfM7PUupNizmoEM 5fmvwHa3gVyos+YbzWaK9/eGh+k4ksY3LtvRupDyzN3h9uMZOpmviTMWeuW2H3TcLC7c/jSrMhn keMARfcvphGdpYcd+UOQD5G1DeaJZXKOpXLFTqQp/CyPOLChQLv8wrGwEkBYP5sNyPbdmmYlHIt SzhHuOBQP+xE+Oay7m04VvQBPSevtOgsp4RAIfmrNah5enDFpwM/kZWmCK45fbVJVYSfhxJ9wyQ bHB0HmOGacYFgaxfaoZUYqwxqA53DW8VlLDMKU5tQx8s0AsLEBkctsIJkj66rqH4P2PdnRE0tU8 7JHN1YNKfn9vrY2e1hrcMzD/b5ILCVWHk4O5XnllR0VAKNyDc5mD4ap992y9cLpCSm01pauVWfd H5S3f0R6OMPLU3+jL6Gb7wXIPMdpaQg4nmfWGaO1v1/hX6CoLbGawDcrZ14wn9jGEvMYfYTFrlR TwyOkcAzr1ue88ESJHyArhWgHDEn3e9Xw1+qwcraFIcz9XXK1VT27Y37Cr1/wHcYC4oMooOBJEp xdmwocXr8J58Qqw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has additional variants of the set(_multiple) driver callbacks that return an integer to indicate success or failure. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pca953x.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index d63c1030e6ac..442435ded020 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -570,7 +570,8 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc,= unsigned off) return !!(reg_val & bit); } =20 -static void pca953x_gpio_set_value(struct gpio_chip *gc, unsigned off, int= val) +static int pca953x_gpio_set_value(struct gpio_chip *gc, unsigned int off, + int val) { struct pca953x_chip *chip =3D gpiochip_get_data(gc); u8 outreg =3D chip->recalc_addr(chip, chip->regs->output, off); @@ -578,7 +579,7 @@ static void pca953x_gpio_set_value(struct gpio_chip *gc= , unsigned off, int val) =20 guard(mutex)(&chip->i2c_lock); =20 - regmap_write_bits(chip->regmap, outreg, bit, val ? bit : 0); + return regmap_write_bits(chip->regmap, outreg, bit, val ? bit : 0); } =20 static int pca953x_gpio_get_direction(struct gpio_chip *gc, unsigned off) @@ -616,8 +617,8 @@ static int pca953x_gpio_get_multiple(struct gpio_chip *= gc, return 0; } =20 -static void pca953x_gpio_set_multiple(struct gpio_chip *gc, - unsigned long *mask, unsigned long *bits) +static int pca953x_gpio_set_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) { struct pca953x_chip *chip =3D gpiochip_get_data(gc); DECLARE_BITMAP(reg_val, MAX_LINE); @@ -627,11 +628,11 @@ static void pca953x_gpio_set_multiple(struct gpio_chi= p *gc, =20 ret =3D pca953x_read_regs(chip, chip->regs->output, reg_val); if (ret) - return; + return ret; =20 bitmap_replace(reg_val, reg_val, bits, mask, gc->ngpio); =20 - pca953x_write_regs(chip, chip->regs->output, reg_val); + return pca953x_write_regs(chip, chip->regs->output, reg_val); } =20 static int pca953x_gpio_set_pull_up_down(struct pca953x_chip *chip, @@ -693,10 +694,10 @@ static void pca953x_setup_gpio(struct pca953x_chip *c= hip, int gpios) gc->direction_input =3D pca953x_gpio_direction_input; gc->direction_output =3D pca953x_gpio_direction_output; gc->get =3D pca953x_gpio_get_value; - gc->set =3D pca953x_gpio_set_value; + gc->set_rv =3D pca953x_gpio_set_value; gc->get_direction =3D pca953x_gpio_get_direction; gc->get_multiple =3D pca953x_gpio_get_multiple; - gc->set_multiple =3D pca953x_gpio_set_multiple; + gc->set_multiple_rv =3D pca953x_gpio_set_multiple; gc->set_config =3D pca953x_gpio_set_config; gc->can_sleep =3D true; =20 --=20 2.45.2