From nobody Mon Feb 9 13:58:45 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A78A24CEFD for ; Mon, 10 Feb 2025 21:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739223372; cv=none; b=ZiL51a/dFHEvM1tJ4Q2vreFZAN4a9sF8bHE4EFlxQau8hBHpFiuz2gXK8c+M1YxsnuUBMkNEPf0U2PzbRAQ0WCSM7b01MJDJMcYWLvz+WOuNi1u4C1aVpkpZEGyQQjH3gYUs57L+ceKxdJO6/nsfnZ/Uq9edIgxtxjBm3UPUBmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739223372; c=relaxed/simple; bh=nmg/tRsGZgOQ5im6SIQejK2wLO9bN5gz88yBNRwTF48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b5aVvZWEg61kQc1M42K5jDfbzTKikcCK1+qJ2zH75sM4fGrbo02Pyf7isfy38HLncJLYEZvLbLKjgAInHttWQkMOg1lqN+oL6MKq90oqSSBvvybynD+9CzjZZRO7aluMPUpbkLkzgJXxT7DKXmii8qL21tltDA3aCFLaEkhqd/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=OXhvIdIh; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="OXhvIdIh" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4394a823036so8302625e9.0 for ; Mon, 10 Feb 2025 13:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739223367; x=1739828167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CqCqeIVEP5nChfGSMKDAeePbRakW6SMa+hWr1pO6tWY=; b=OXhvIdIhIvM60e5fhqb4MpRxqD3XA22dRPmfUJqqQtiLTzCfQsWpVL6JJaMNGd7Flh h/pFPnXoILzdkAb4IWiptkkJIseZOb0zL5vCxzcHknjffB8eRywHHvIERTZd4RGV2Y7C K9gEqqp+wfrV3raFmoR3fvMab9hMBE3Bz7GiIjv5j11Wz4wMOWe1KCVlwWbtN+HhIoyr kzXrcdA/Hn+bWQffXA1b3KBuI3V4qwkx9nWSRUkKLxJWej9pO6fa7pvcfTHH4xLreMxD IXrjSAOp6elqPzNTabw+mtSWjx4AxnzMh++08bXUd0W02rVDJ4WpS2UdO7iLp1R/ZLq+ 6q9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223367; x=1739828167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CqCqeIVEP5nChfGSMKDAeePbRakW6SMa+hWr1pO6tWY=; b=swNU8B/rcB1mAzQAbOJ/C3o71FVBGIWkihLJmji7ebxbt3AtILkfckqeVRkZquIdCg BOvOVA3lp31HP/F0QNdwGKZltaiNnpPHMLhiokylWHvwjnqxfIsedx3q1mfaekhUTN9C Ge0kIBjGUPgFFe3DTT/QQbWl+1UiTqrAeJ0sWifj7qH5HC214IlNWq4yOjeQjGJGcEHs 6gm3MLq8+diJCI+cJBib7tciLbivtff/mQpZ++WXXOfAn1o9wr/EmHJG0l7IvpWSC8X7 CjTo8NaD9LrrzNwu2z7WxFHx4pQ0bPskXFF47Dg/VHm08HIsSIaGt3rrx/00jcQeSx85 z/jw== X-Forwarded-Encrypted: i=1; AJvYcCX5wRdTH1/yvw4Jww/DdpojBBwvlvwmLXiT+rM3ejTcA1fa4r8j5JLupZnGHVe4hxtvKJxVBxTGrRQwJjI=@vger.kernel.org X-Gm-Message-State: AOJu0YxNCLVJQbJyx56HYcMxz/FyU5FjmGrW3ZsaUu3taG49IVzhNnsX DRoLaGVbZpQ5duj8+9h+/QsNd5pOuvkNWe/1K/81e715lfoIo4OVOGa4uIUtWeA= X-Gm-Gg: ASbGncuV0+m2EMxV4qoFJ8Zkc8TCQzBHWjcZ7zNX7ElDiT6WB7WaqF3clDZVIhW+Sw1 WLHyQsSuPfK424XcpLz/l7Mna4N3WBUygrdCU2C5a5CYWt5POrUmrKXDIkatJyqcH3TNkJc7PBG ykQ7/Or5OHk9KYeNAwIh/KMze39Uqlpaet8I/Ectju+RGKesz529HKpFrDORzHGQIMWX5yVzabW 28fG9O363wfMvZvIGKJIo6PdBBmGGD0biJdk5MhffCJ6EgdwaQUgJeHKwHaFGkA3RyCkD6ewCMI tnoNJoGwQ6u54OU+ X-Google-Smtp-Source: AGHT+IEkB0P3P4E3SAwU66eF3MpeeDcKXRF+Ogw0CMtI0RkNe8VhwZ7hlSjtF2j0kGvBWRjmPkWfgw== X-Received: by 2002:a05:600c:4f05:b0:434:f297:8e78 with SMTP id 5b1f17b1804b1-4392498b6c2mr130517545e9.7.1739223367421; Mon, 10 Feb 2025 13:36:07 -0800 (PST) Received: from carbon-x1.. ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394376118esm47541515e9.40.2025.02.10.13.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 13:36:06 -0800 (PST) From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Samuel Holland Subject: [PATCH v2 03/15] riscv: misaligned: use on_each_cpu() for scalar misaligned access probing Date: Mon, 10 Feb 2025 22:35:36 +0100 Message-ID: <20250210213549.1867704-4-cleger@rivosinc.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250210213549.1867704-1-cleger@rivosinc.com> References: <20250210213549.1867704-1-cleger@rivosinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable schedule_on_each_cpu() was used without any good reason while documented as very slow. This call was in the boot path, so better use on_each_cpu() for scalar misaligned checking. Vector misaligned check still needs to use schedule_on_each_cpu() since it requires irqs to be enabled but that's less of a problem since this code is ran in a kthread. Add a comment to explicit that. Signed-off-by: Cl=C3=A9ment L=C3=A9ger --- arch/riscv/kernel/traps_misaligned.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps= _misaligned.c index 66eef398bad4..eb9157e3af73 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -616,6 +616,11 @@ bool check_vector_unaligned_access_emulated_all_cpus(v= oid) return false; } =20 + /* + * While being documented as very slow, schedule_on_each_cpu() is used + * since kernel_vector_begin() that is called inside the vector code + * expects irqs to be enabled or it will panic(). + */ schedule_on_each_cpu(check_vector_unaligned_access_emulated); =20 for_each_online_cpu(cpu) @@ -636,7 +641,7 @@ bool check_vector_unaligned_access_emulated_all_cpus(vo= id) =20 static bool unaligned_ctl __read_mostly; =20 -static void check_unaligned_access_emulated(struct work_struct *work __alw= ays_unused) +static void check_unaligned_access_emulated(void *arg __always_unused) { int cpu =3D smp_processor_id(); long *mas_ptr =3D per_cpu_ptr(&misaligned_access_speed, cpu); @@ -677,7 +682,7 @@ bool check_unaligned_access_emulated_all_cpus(void) * accesses emulated since tasks requesting such control can run on any * CPU. */ - schedule_on_each_cpu(check_unaligned_access_emulated); + on_each_cpu(check_unaligned_access_emulated, NULL, 1); =20 for_each_online_cpu(cpu) if (per_cpu(misaligned_access_speed, cpu) --=20 2.47.2