From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F18CD2512ED for ; Mon, 10 Feb 2025 22:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227056; cv=none; b=fyIhP7i2Y9SSFKlGf+1OuSdef+x1eIdOJ1bQgMdJtNmGVqLOwxYPoxDB68ULTR3yyD9RdKKhRmHRRmIazW7Dsc83+/fbAxEeXUfxpVZfyQqi/1Kq2+I+zmIDpcnLYnAZ/ruZGLQ9euLqae+aQ0rZcDq898O8bYMCDJcnpiVoohU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227056; c=relaxed/simple; bh=N0Em4RkHQUvBxoy2r74GZrWjDlivg7oqNPXmv4at8dI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bXiBJEmaFPAx/S7AvslEV8+8ij7jU/YChfdZFGASAzuFESFdIcLfCdq0890zKNP24OlNIKWfcb2MLMwWu12qFx7vjgaCRLVqPDeNyzqQHVUqQY4KalGK8lAIC07XwEPLI3jR+XvbSWImkvmw5XtFycyzM+WLdoQ7r7LhNCx0/ME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=UtsC4PU2; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="UtsC4PU2" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3f3ab407232so977775b6e.3 for ; Mon, 10 Feb 2025 14:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227053; x=1739831853; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=UtsC4PU2jEf6Iigi4rlnw6wcpWHJPn9dN1Y/ssJiTHPQO/CZtNRpsBzMfDZlyt/we0 RHuvVN+hHYkiWa+JZ9v2hwWgZBkL9x+SieJHP5Ac/9ymC+T0V6fuZ9mDkfZyOmRAwJne uPbi8Z4raeikVNmyPxq48ndMS9AY4DnshSuYZQXcVYZAxWB6CLw/5yRRn7eHlEkcFFnI cWRNaWQ/SNXQXB/fEk3gZ3NBilf2Ay0p8Z3tmcIGDHXh9atrJO+I7wOKX6b+rD/P9Tw9 bum8f285kxDjh+R4nDlD/oxghHe+83NmYNGeeyjmHMDgAXUxM9+gyp49TVcNafo13Xw1 0qXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227053; x=1739831853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=Gvc+Xh7S+nbSAnO3KvgyKG/LkY8LsvmJb/QBthwv+dqzyohNjCDZbWdXvFL3ZHdyAP rKG/teGMNL8PdvhRXhJzvyv6NpODEBrmcjP3Zmzzxa2UgRcMljds/yro0SpfDxxA+EPx OKmROUc0/xSbrIk8uiAdV78uNiIWk18Y5xWPBzutV1ruMbY4+iV2UFAcayb0CcxshLFV Ca4EtEuK2vNoS5zd/NoT0xPuAi52d58hRqZifpYreSEuo2XPb6cHZr/f3UwSINq8Gwkv sLotHl7ipXFCSgN8QYyOOO6JqxcD3UTtUInHQixb4eG/m2T+CrSBPR3Hctt9IDjJGoCA qm/w== X-Forwarded-Encrypted: i=1; AJvYcCXkMqOwfQO8gMmfkD9JD1RoxH7vYT5FrxVCKZ2dzr0/kGvwH4nvu4+4hu6fBuMttUszqc7GSU19HQyTBdc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7EESF+2hDsCxy+DL9iQ97TDpZUx7AJCowRsRaPdRj6L7gi9Xp hd/cVBvm5jAieP93BrR1M/KpeF6liX2ZHuyap+63aNSPpB5NVwbOTFOYE8sg9HA= X-Gm-Gg: ASbGncuM13qIgJtMu5TSphJBLCJbOx43MYXSatHE4ZIurqdXdvI9Jex5f3HDyTKsvhR 3p8MywapevNXx3y5GfS2mBzDLDCos38RM3MgC0X6YZHJ6ewXMCv5K0RifGhCY4o0o0urSdRT2Mi YPwmihRhOEk/m61x9Hmr8oGgs9Bfeow07JKljc4FXCdsUWBJb94bV1criSUuwlY1JnMgv5/cu2K 74ZDrxGkszGhOLLb64QgjZqBTcIH6OQ91cKobGRZhDOEMUtN96Jc9b1gS+pG+iRZN+7BVLeEg/A mcmFrTnU4PpU10nTHpo/3eyM2crN3/ZqY6YLPM/6xXdVC74= X-Google-Smtp-Source: AGHT+IHsM3QlE/6UGVvIOu1IlhPnETs+gBtT/fIeOJD2BqtDOh052hlxzN8ugWj1HusAxyIKgoI2uA== X-Received: by 2002:a05:6808:1590:b0:3f3:b8c5:4ff9 with SMTP id 5614622812f47-3f3b8c55799mr3309849b6e.28.1739227052973; Mon, 10 Feb 2025 14:37:32 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:31 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:27 -0600 Subject: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-1-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a new gpiod_multi_set_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Reviewed-by: Linus Walleij --- FYI, I dropped Linus' Reviewed-by: tag since adding the IS_ERR_OR_NULL() check isn't exactly trivial. --- include/linux/gpio/consumer.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..5cbd4afd78625367a761e224acc= 3f7336d310dd0 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -3,6 +3,7 @@ #define __LINUX_GPIO_CONSUMER_H =20 #include +#include #include =20 struct acpi_device; @@ -655,4 +656,14 @@ static inline void gpiod_unexport(struct gpio_desc *de= sc) =20 #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ =20 +static inline int gpiod_multi_set_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + if (IS_ERR_OR_NULL(descs)) + return PTR_ERR_OR_ZERO(descs); + + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57DD6254B08 for ; Mon, 10 Feb 2025 22:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227059; cv=none; b=Td1C+JoKlrjSfxc2Qx1GQ3fXU7fYAcMlg9aRgV2xlU8cj3NJN1nHNly/+6nJoL9rWP8j2Y2j1ASJ6bIB9y+2s6MoIIGTJ6Nx+/zCWEJa61SLaEjzPMdFstaokcIuN0D5s1mcQnOYSgw069gGBCBrt3Qdg44TQmrfyox61j+8mKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227059; c=relaxed/simple; bh=niyVa96MKYbn0/yX32i9Lb8f6xkttYKqAUie+rLFIpw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dd1h9OM21/6r2YYeygEdeS1Kk7066DB9znJNobZtDWXj53Vw/3OcqApG6DwsXaaZ+9b0KrsuQ4KGSuTCxdV20bR/vNwfj7pXUhEo2Prri3EZshjqo34y55EHU07ZmJXh+wGzQfDqseZy0Xd/YqoG0qMtNdHqP09/1M3dSTnT4lk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=NiddYB0j; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="NiddYB0j" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3f3b46db87eso881134b6e.0 for ; Mon, 10 Feb 2025 14:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227056; x=1739831856; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=NiddYB0jNhn//VaVWUzcWNGKWIeEyKfcIB2RGxGapk2Rsw7QuhJTHCJ4XwS/Nmfi0m wv4f2mthWm/UF4OJUKuECfl4tuSEVDfnuWTQkQpAWIZUaZxu8DMh3ph3evLpfuEw6IEK MoW9iB84yzBIHcsc2B7d9OBfcqiMCmZntNlfXoWvLZr9088w6ZY0uHXFK2r4TbQkUsq7 PmnmEn0pl488AdriFRaZasKhpgeY0kWGFDrR/+guatUWgoUhgFzt4Tjg4u3vnJXp99Ce JkzEaOo5JuUjNYlQmHr+6wYvDKwooRd/S0wbt7IVT6hFs7Fv49vWVBAb+RTYfcws6sHi o4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227056; x=1739831856; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=bods0GCou/eZBAyx2HPb9i38DXzp1wgWXqUOX9youKfVFlrwsbZedShUmA/w5UwvoJ +qtWplBiOpAih+xQI06V3u4Hkr3Rg2kqnMDxtmG6Xb9INIxHT34LIKDYlBM+UxiQ2jTG otL8LJI02mC8sF9l2EtjwaZ0s1XEC+CW643m/I9zIC48ayC7yyieYaM4CQANPZyne+AN WbDubBMKg32V7swv5olZ40iJIVQhtoUKuer+O++7URSGkAy3rmFLWk+P+k1mM/Xx85E5 npnCEFqq3a4bpHDVme9rF7/GYCtRWaEVXrh3pp6xNjgf7ZXWBw/GmdFZq42CL4kRWKdU csyA== X-Forwarded-Encrypted: i=1; AJvYcCXXARDhyllLSsZ0QNCpRi8G2UPIPw/MKOEdxlvRCvqECqORfHmIFZbhJ5mNj6n4lOZjj+0fXP8Zh+NbWDc=@vger.kernel.org X-Gm-Message-State: AOJu0YxjLvZlgvCU/p2JsO5wE2xhUDIfJSKVD0pyTEYlf/CAN1zxiCHY vJasQm8yFti5GaDzBLZpCb72spqJhCdD1gKXMyXJcJsnaf7z8AyyhiFP8an3/mI= X-Gm-Gg: ASbGncuAMjVSTBkbbpX+q/WsziW29tqgfJawJHt/wsB8smnzw34WFAy+580FEyOkxsg B3nHUzRlKmc0d9+/3P07gcnv3ybeDQMmYtNjTWVYpK6QcoDwn+BHjWJ8EQzWu6nGys5OB78g1xk Ul+pbPlkZzKGPyd+W1lk0a9I4vbh45vN9mCzMLwqHuE3f+t6XRvUrE0xV45hnKRKG4LX/gVm9SJ /MQ2qyPWBMG9a3Ss3CrADjYl792yzkuj+pqFlVuoT1gNbcFArkrhvHzVvQLyBTZrKjAlFzdxWuB eFBZOI6umIrNMVA3AD5SBsaVfunRTQjDYC5Rp+AhKQ16Ro8= X-Google-Smtp-Source: AGHT+IEaS15Bntym3mAt6zrku3a2Uko68yjmwMRgXiq6dPbA7MZZB8Aa64yOncDet1fFdEO8/9GX1g== X-Received: by 2002:a05:6808:198f:b0:3f3:b6c2:a29 with SMTP id 5614622812f47-3f3b6c2115dmr3804142b6e.7.1739227056176; Mon, 10 Feb 2025 14:37:36 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:34 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:28 -0600 Subject: [PATCH v3 02/15] auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-2-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Andy Shevchenko Reviewed-by: Linus Walleij Reviewed-by: Geert Uytterhoeven Signed-off-by: David Lechner --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led= -gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..dfb62e9ce9b407fe356c3a7d2d2= 5319b91a11a75 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) =20 bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), = 0); =20 - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment= _gpios->desc, - priv->segment_gpios->info, values); + gpiod_multi_set_value_cansleep(priv->segment_gpios, values); } =20 static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DB0125335E for ; Mon, 10 Feb 2025 22:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227062; cv=none; b=IlUgopTLP0/tHv4Yown5bSvP+/Ylsa3wmUP4TyZb1o8Qo2chHVAX4hLDgq/BKjL9Wli8ldKXegxzr4T4V3ELcS/zm/w1XYcEtOS9H68XXe3h/Q4rtuIXRwGtLErTFL+0OD63OqJQBTtg26VQ7UH6nMv8/0lAhbpvYbIEljFf1N4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227062; c=relaxed/simple; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LWkXVN8jXA5OTmQNWwKqzXs+OlkDlAAa/nCMgZmf8yqPtGMWOsmmpLofUzLffGFUBaNDs4SL8SShDIIzgw0GhBzRpTdBOj2AaKeDGL6DBcg6JzXAbTwDHMHPbyytOwHN0cRNOzJAZMk5Oc/8Q0pE68HzwC80Kl0JjR/I3ddNx0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DLi0qjsC; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DLi0qjsC" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3f3a6ee569cso483967b6e.0 for ; Mon, 10 Feb 2025 14:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227059; x=1739831859; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=DLi0qjsCM9M4kRFPV0vlUdPq+P6jLzFdtm9bQWFR9JOodzbMazE/Al5tiMqScDd179 pvG21zG8gsruYL+RhrsqoWBz2CLpUZri9iLyCTr7EfFSboiHU5ObQHmjPiv94bzGs53E nt1g1NTy78XMuXkKBbOf0kPO6fFpjjMdwAZ7VMQ3F7ugQGcgLb8RmgfYlP8lmvPZwaQk zw0ooUfpLst7YQwUGpU+N6/O9XahJdKy++vUMqsQD6CXFZq+HM9RC+6LGqNFjkH2gYTI ze3Re6J/b8pCBOJhbniQUGBkF0OSBApxd08j/OUhCH0VnLe0eDNsXPNekRiOmn9KWXTc zhVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227059; x=1739831859; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=UX8ayQr/Bs4qgEtj3G3et9NRupAMOPgLm9wguJe3oMbb++XzObE8/2Tczf1/VCf56Q PgLbBzJPrSXhGZjAKcmyreo+MqkcYjhGIoJOLt6Gx6J9202rgRg6JtcWjUtL8iQWZD25 3Czfyln5oIugN6dTQK4XN00qkfXKDmscXkUACO5QLP8h03nO6lqEOg6gs/bdbeP5mUXv ahQ9eO5ptCwkFozLLrKBSy7G6trSBjGzgfjNUESEdFK/KDyPH5+Z/dvypEQ3BpByGN5r ca0bu8tPBTDu8lz9/G0uFCB7SkUr2PJFSSfgQBb5unLEbJh9POFZKTUX9xZlkoCSjs0/ KGGQ== X-Forwarded-Encrypted: i=1; AJvYcCVNithj9hMyb5zX1MuKJkBvnPw1cjVE7E7zi0cNXAUjBv2DGIxrleBjggky3aQgEzbL17s3rgYTT0mdFKk=@vger.kernel.org X-Gm-Message-State: AOJu0YyHyyktaFr3dUxLbMVydb+H901/tVeC8+Rn8zeBSsX9mf7Df8Gc iY6STVTFaNnMWA82gQJ6r/9ywFhucrPIuM4PEUM0S6qM6CKZqAu6Cue06LbanZs= X-Gm-Gg: ASbGnctWYUssQpcA/8j+KylgpRaudEqFIxSVeCA2sP3EBbuRi69VSePRLHNanAlBL9G k4gaHSYp/aCOlx1JHGPk1QwUUmvGlv8tcAxDmSO7xlQYqqpHlGlCVypmmElpzn/lu98nfcvn75+ hBUtfTqJsiZqYVd7JI8RzSmSXk5sGB2mSHSlG2w4kr5xyXKUlA/+owUXI1eXIplABomhIeZxBRa U345xzjHgbAB9bc0XTSi9hGHIeHrEU1wnuULD4wXQwrrKMVVsUsSPOmsIdqYUdMrOb31VtmiT5j CKoMX6GwSSoe/lzCTuSiIi3pv4+RsD+bWg5PlDyh1xu2/os= X-Google-Smtp-Source: AGHT+IFW6c/bCwKZFJx1mUCSPW7GBmt4Y2h9+oGTyfDUlc4EaqeUGtPptBQHkkXiE7A01fG2q4Y7jw== X-Received: by 2002:a05:6808:3095:b0:3f3:c370:4d65 with SMTP id 5614622812f47-3f3c3704f3cmr548358b6e.20.1739227059360; Mon, 10 Feb 2025 14:37:39 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:37 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:29 -0600 Subject: [PATCH v3 03/15] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-3-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298= 821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pd= ev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); =20 + if (ts_nbus->data->ndescs !=3D 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn =3D devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B560625334D for ; Mon, 10 Feb 2025 22:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227065; cv=none; b=GhrJaju7X3qYceO7I3/SBaa8EGUFia9uClYCGh4A8zrUP29eqePtDlQz5Oc1R17bjAIdzNeFgoRX+u22aqhMBa9H8p5lEoX4Ybhr9tHozNVmJPGhPS4lDx/ZDyiFV+Ojs5FLN9lJtpOVx2A1NNOuM08NJERJ5b+/+n4e+MiK1G8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227065; c=relaxed/simple; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R4IAevGLES+AIBZIC4NB7vy4rnZTAS1fkpGVxbmzo4S2piEHJKw2nC0yFBgzRfUvDtDPVV0Gl4y70Tw/KmDTW4wCuoQo+TFB/NgektB/h7SpuxBmuzJuWED1bk+IDvWeX1mo7+6gd2mReCHnIKPHh9MT7gMZ7O/5xX5FcMUiUAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=z4odNCuW; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="z4odNCuW" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3f3ace3d30eso1142679b6e.3 for ; Mon, 10 Feb 2025 14:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227062; x=1739831862; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=z4odNCuWEIdXw6egWdAWzvkDfUm2yp9LCjnZQvBCOP3qcsaxfCXnX9ztT4tAzJgMaI oDzp3usrGdpGtWbm0FqUkKrpmWAEIq0wPRJUUbuLHncebfsQtZRIdXurTcE0coBezaot JCqwfqdc21V6HhF23eOTpr1Hv00Dk390SFpGVTMpKQAG5hTBVYYJCwcIsgcO9kiueCqz pcz1nbGaOl3KNFWRBj/DCKZxfPkD/u9KWoJF+RASmhfD3E5roTW7Q9RZbtvCdUfMt4C1 4t7qWk6gsXi17m+oWug7qVV/Df5lYt5w/9r/5UtGtJtXuARRfAjocCTg95E9CRvg5S42 AFPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227062; x=1739831862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=YAfr/Ha/L5Ke9ZlEh3Uj0/84/WGzdZLTkltcrgEkaWqo+HBdoNMmt4Dea7N2Rt5Hgl 3w5oQ51Gfw/9nNPqHMu3Zk+BPy8w+QiDjeo2PRgYsFLA+kokHPYtuCJODsgPeB+U2kpV XTREUGkQGaBTd3LknUp9hLBuVQLy8YYpqnv8GSy3/TNs2UrzUYGwJdzd3sK8Afw9IH29 1KAhkiTHlaPJI/bajwmHdo+p1Xjr1MtMO75sjbmqgVeGi6aaC89gp1L6wuvwMZu/dmyg rMTbCkBsM+9woUGit4C9bskEyYmd+vaZ4W2SzDRAHC01yK13VDigOcteD8gCTtwd4DL6 jpzQ== X-Forwarded-Encrypted: i=1; AJvYcCVBpJSDt0xF7B/qOVBORzES2cI8Xy8c3r+LJThCJ3yBrHVE9unTELTqQ+kuxbLw4SRm1CaWy2pogUerQR4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMaQsMQQ9mpQGBTZ0RpfeY72hynbFlzMb9xdizNmIfYoIZckd4 lC/N4VMeqLXmnevK7CzAgBtDMp7anAnL9pdr6lMBthuYjnMjT+ubk+VYBl8fXRw= X-Gm-Gg: ASbGnct+2Yr6gTD+H4NlxHaZ+sKPChh6vmk9nQBM4aLJ4XpUPUq1DvyHhh/VgqOM8b/ iOBzjqaynlObfzqoHSRNmqPTEOLa0qh74DVKGehnnKfCa85dc8OAMhq61ubp3/6hKjEHX/5W+/K 5elQPVRKasVz8MlIUrDBGLFDb1sm7f3BhNpu8FNRiA/9XAHJW4om123AmH9keJ9gsjQOlTu3ILD Tqk8uiH7AYiImhBhw0sZZZ9vnAErVfUEw5/OgUaHh83C1u24siAZLHFThODxpwGW4HtRyFpR1fa L+M/4YsbFa0RglD09iwjaxg85hYngCuVL32pTQtIMslysak= X-Google-Smtp-Source: AGHT+IGCum5h1AQwvUJNh3Kk51lVy6xq7QJ+B7z8EkY33CFant2nucCBaXwDqcXBpkDagMClSCsXTA== X-Received: by 2002:a05:6808:4099:b0:3f3:b0ae:7998 with SMTP id 5614622812f47-3f3b0ae7b3fmr3901508b6e.17.1739227062548; Mon, 10 Feb 2025 14:37:42 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:41 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:30 -0600 Subject: [PATCH v3 04/15] bus: ts-nbus: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-4-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527= fffce77784af2 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) =20 values[0] =3D 0; =20 - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus,= u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios =3D ts_nbus->data; DECLARE_BITMAP(values, 8); =20 values[0] =3D byte; =20 - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); } =20 /* --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C154725A32F for ; Mon, 10 Feb 2025 22:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227067; cv=none; b=Jc8zaC/Aols2PilFvG3eKgje5j2Snu4TiLfLiaWRXBMUhwJAO/b7cqpv5mI03liAzm4RmbX6HmnZbHQlRGa8rjivKJgCflJ5Cxrg7eTAswvN1QC9BXe6eL+YuR9X+Wqac8p0YCYTo62ySd0JSUv51o1rxuaa3rCzbkmDwK6ugYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227067; c=relaxed/simple; bh=h4/JkT/aieYSqhfnM9UnuUTJJW8FA5AwmbHA2f2Z3qI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lJgUWiDmvpkA7LG0P2gz5kTHIo1ORnFFlzo5nw9uL7zeTJ1Q7EL5ndgv7iY0tjOI/MeEhpoXAcmN6q7W1nUPGMerNx2LbGp2zLl/Y1d+3V7Zs3Av5a9M89fxGYKw+E2WtYxBFtIf1sD43WHyvzddTi8hIK7srCn6Qp7JfMheVa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TLOvJjDN; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TLOvJjDN" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3f3ac204922so1247706b6e.3 for ; Mon, 10 Feb 2025 14:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227065; x=1739831865; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=TLOvJjDNBxarUBELg7go/ZxX0zU+xs39riDy84aC4j2XbIyhm1pT74p/AGm39IqyRZ bknIVVrQU2LwEzznw9FCg4/I6+7S/onqBEXzcpR65VT172DkSyNa4b6zuoHcZwRcLORR yooOMj/CxF7agVXCqEErNuJBbNcNcreGO1y0qaCMTXz0qQzT3w7uMQD+kc2Q5ty9Dzm/ 3zF3qLHrKWV/Srh+kAZopRBiRZo7Nk9kUIIJ8dS4T6VUnaNj25a1ZNm3dcZ2WGQw+O5a qAtRg4iru5kNYEqyRzgAT3OoX/SGWZ5VwNlTo6iGuKGRzWMV5R4ptInabd4QfOB9yJqD zbng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227065; x=1739831865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=i4BWfKc0VQeeKYzDaJKCELhA1tNIc59E60j5WzcDSRS3GMl/1R6ZldSb1/6aDpUzWg z8AVeOXcnJfzu2bZvpSo8cbHXi4g3BDTI36iT2GOgNyeWPzQMEktazKXeNl6jvaj8sbW AjfiD8GM/KVBWmjSvJlV1+c8D8B0LSYSJvlhlIKmuJ0rBc53orH9iQhFmIn1lsspj/VD kb8AJ2dYrphv9h99AYSYKczp3HxJDaJCAhOYTWbH047zimQQ5sgpojG5d1zx3uK6LBB5 wInnuupLnW3V+mW7+/35APk7tWlknw8w8JXSoK6wWbisJ7wDcumm79dBXh+Wbv7lRCdD mJ5w== X-Forwarded-Encrypted: i=1; AJvYcCV7LR9gDFJ58BaQEbxlm3x/2k8g+n7GsMlN7HiKcW5eoLZ3XuAr2Aq/8laeQ/3QHWswDeidGwgDVQzRu9A=@vger.kernel.org X-Gm-Message-State: AOJu0YyGtUCeg3nlwChGVtStcqT1thlaldVup5FMhpFrPn+BEnyNdJkq QXQsdggRAjCgd2I94+mOmQ/5RAqLVGl59UTgts0NIYjrcKogTeBCRc33Vu+n7gk= X-Gm-Gg: ASbGnctLXAuqPMCauDn94hRPIKXPj+Ddu27CM4mGZIvmuQjKvwv88Oy003pRvG7WUCi BX8A3McORRTBgISelMI3fpIwoTHUSPZV3Gnbmy+fnDICDHV71XPKmafGUS1TG8QUWFjGxHrz5nX KZDzo6O2nG901wL35EzIeMfTHKfKs3029x9kC76KyozvjFIBq5E8mfoLdbcpxx9fujIotnSEPPa gZCa7QNalBLwPcn3FQJzJZ4FXkqbSPLBFS4Xr+4a3A8nJLb0AdXp0eAoiSGug3FPwgRSNiBKymG 5Bo2S79w/qz9A/jHqjuDG55kFVuEggbF6he8lpXWDszYUnE= X-Google-Smtp-Source: AGHT+IHioMIxu9VGnzXizdV46F3qMiFjs48WUo2oHZz5JGkXBH5C7gXq210bMR9McIstDGpa5KGthg== X-Received: by 2002:a05:6808:319a:b0:3f3:c1e0:c466 with SMTP id 5614622812f47-3f3c1e0c4edmr1094523b6e.5.1739227064928; Mon, 10 Feb 2025 14:37:44 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:43 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:31 -0600 Subject: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Andy Shevchenko , David Lechner X-Mailer: b4 0.14.2 Use bitmap_get_value8() instead of accessing the bitmap directly. Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it. Suggested-by: Andy Shevchenko Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index b4c9308caf0647a3261071d9527fffce77784af2..beac67f3b820377f8bb1fc4f4ee= 77e15ee240834 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -10,6 +10,7 @@ * TS-4600 SoM. */ =20 +#include #include #include #include @@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) { DECLARE_BITMAP(values, 8); =20 - values[0] =3D 0; + bitmap_set_value8(values, byte, 0); =20 gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); @@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus,= u8 byte) { DECLARE_BITMAP(values, 8); =20 - values[0] =3D byte; + bitmap_set_value8(values, byte, 8); =20 gpiod_multi_set_value_cansleep(ts_nbus->data, values); } --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E455D25B69B for ; Mon, 10 Feb 2025 22:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227071; cv=none; b=tyUxtjl498YhKdRJHnc4gqrj7tKfqC6hTsTmuAJP9oo4Bvf6dydicuuROOXm6LuHHg3Lx3sl6ub81h4NuGdGr5s28ZRRkeDRn5bwZKBb9d4lA/EWwkxtISMWVHyCVb2FznX4Sdq7hjJf8ouiUSnzQxmKvo31rhoseXrEYK2SBw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227071; c=relaxed/simple; bh=LctkGb8pv2p2rQX9wrZO/xPsAUNTTxqNczAZXgDu87c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pXrKuUclW1Xzh6s+Y8puntLCAGxkZAQtjOJl5oNCFdZ4EuAh6OlVF9Ds9m7nmH+1SxHOhSpaFB/CRhyfjqQbuB36ySNy0Ob8a6xnihJL+rKGNTb5kXPHr2CyiRHqfcm5Y9Cl5pA6ou0Kx8McU4tB1ZDpjDb50pLRX8QYw+N9Xz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JSuLsJIu; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JSuLsJIu" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3f3b1ebe6d9so847106b6e.2 for ; Mon, 10 Feb 2025 14:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227068; x=1739831868; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=JSuLsJIubHBSOQF3wLWj+iCM6/U9leKY2xdJrIXTYB/Ln+EEvCyBucdC3O7xK7+yjg +UXX9Xh8D+egCKgFE/HB4zzq14uH5zJKE8hzBMMEYKM8JPwsCk9NxqKuuAr2Bm7Ac25H zW9HtmlIp1YhAudqNG6vA2twyN7AwrZi7V4fW/s03pOnm5cQsfR8ETYqbh0u6mzK2V5h Ac7+R55B2wD/ne9vPaSiOU0sWD50XAUm6WcKFqmOCDglpSluMpvXz2+Mc7mCCbowvRP7 +FqWlSj8UETjcdjwyhYHUxb6orF7xrrDPf837dnQ0MsPCvwhDzBldHlffteYLRTmmIky bwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227068; x=1739831868; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=YYynkxx4ALkRr7XgIJ/Qh7e92/bk0J7KAQstGkPz14z5toc2osM+kqQB20KhyyxL4k srisZwKlyRpIdhUFXwql+zgjbDiMf5sGQR9sGfekoOmErrdwgRnjQL1SVesVkfocVVgx FzHeKPxIXsRxZq4a8+ZG5HVRoIiXGLtevh8DF365mrysX47KhyRK4lOdkifAjPO5rK07 1sMYEwLcIaPToTSA7hzCtLyMpyl5cxoy443SRNmrwFyTSWLVTi+sLbBYLXuvzv2qFQ4o 0MKlgVkU5BD0QQUxDPWyrnSfUqpt3bYJR+WxZLHr0Hr7U4hbhwHuQmVHcLXfjyD+fAb9 zt0Q== X-Forwarded-Encrypted: i=1; AJvYcCVM4wOCyiLY+6qOnCyVSIpcOAu3hivk9xgmPrbmDRRTHsHIymxH1A5OIWvGSxVGLsiX21BVhIoEjw2qWk0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/9E9qp63CHHKl9ZWIGRaBh9ziKPY+kPB4lSkkWL8q2iN32JfY fh0k6CHSmBuSP0TLVNaITPJVcNP5fK3Gm6Xxju3Hlsg7b7sU0ux/5l/j69u3FXg= X-Gm-Gg: ASbGncvoHNPQdnVLhgRZJbAv6e6jVHnEkyBh3p86o3bC3Ho3RCvYUrHBFiypJFzmXj3 YX9zXook0Ml59s/s2sI6xfahFbdLB+ZJ4/E2jQwGFjBcBINiIUMCi58/c5qsIUKHKNcfcZPUxrs kVBbn4/FW55amtWMfrGM29ezl/qEjdykuSTLF83Qcpkok8Pj217u0jPTIM91JNhSCeBhBS1g7vg w6RLIkpluqsZb2+S7AkvjaXYw/BSkCyqwvOzK2ZqNglMlI9/lI6wKNzF3LartNiUbeuYysa658/ c4Z2/XWwNWJ+WHeqopiXzwY7pFPPmDicNRebxMqvIUjlw/w= X-Google-Smtp-Source: AGHT+IFehF7HNx0K+6D6lVInKbCaf1fMxaCHCpkyg1GkxvFsa7pSUfnDQ2Sc+6Hc2oSsp+PH8uo0Jg== X-Received: by 2002:a05:6808:2f13:b0:3eb:8d22:b6ef with SMTP id 5614622812f47-3f3923b0208mr10855482b6e.37.1739227068102; Mon, 10 Feb 2025 14:37:48 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:46 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:32 -0600 Subject: [PATCH v3 06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-6-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Also add max3191x_ namespace prefix to the driver's helper function since we are changing the function signature anyway. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..fc0708ab5192bd518bb0e6362f7= 37bacbd549d61 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio= , unsigned int offset, return 0; } =20 -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void max3191x_gpiod_multi_set_single_value(struct gpio_descs *descs, int value) { unsigned long *values; =20 - values =3D bitmap_alloc(ndescs, GFP_KERNEL); + values =3D bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; =20 if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); =20 - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiod_multi_set_value_cansleep(descs, values); bitmap_free(values); } =20 @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode =3D device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + max3191x_gpiod_multi_set_single_value(max3191x->modesel_pins, + max3191x->mode); =20 max3191x->ignore_uv =3D device_property_read_bool(dev, "maxim,ignore-undervoltage"); --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22AB025D534 for ; Mon, 10 Feb 2025 22:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227074; cv=none; b=tbuBDqBNjJkuz2iu7vbQtUspGYY0Xlj45HdsnyfYCzbT0uVnPmqC0HngoQYyoBR8IGlLepHyU2oWecuHNYRC8fqd84EHReXpO9ER5H6HDmHzGuLrgab+eQ7tq73rOeKHJ2vv4bqgITfXWeoMXq4L5R2ofMrGlWXZbljlUmw+Hz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227074; c=relaxed/simple; bh=E+QxbL31Mk8vy8KiWcSsFLkHYNRVN/Q8L14IDdICZ60=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sqpkbc2YsdyuGalE80DnE0J8100TaD7muOazaFwUlIVvXV/z9suT30Ry2p0sGnzw6ppYb3D4xAH1VZZy6pLSeR2iVs87BPNfFnBY08YEtM5v6WrbmPsXcW2T+gh8+flkZxnV/KHvIGe8GqwJ7hKAmdqDkXGoNpv2g2qYhIAzIbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=IupX7MF5; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="IupX7MF5" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3f3bc69c8c6so548311b6e.3 for ; Mon, 10 Feb 2025 14:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227071; x=1739831871; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=IupX7MF5SYuuAqOP2Tfu9nnVp7KL3B6z/1ukgLgzjaYemPo7bXexCIkRSyozbc00NR GdPkTPZeY9fZk8PJuaFoh4pCx91s3v+mpg5oB46IbKVas1ngrtCjW3sp7ozhLe4+gqxy Pzh3uO3ycj0HHNNP3EGFkJ2DH1Zi4NcptaWW6DNAKiAz9kd5mINv/UnHcZYktdnoP35B ZwX7bGV4f+cGbF4kO0LBiWvSQiCx6r6VmlHPsN5QC0uQweVrMaxGueO6jSf9K7QvabNu 5c6h+li92oA9DXqLPxzQI0D6+xQun/37mTsHMRYRMBRX8CR0f/oN1JH2aR34Uwesz9JX Gk6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227071; x=1739831871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=pqezWVEY62Af7qV0rvyjPO7RtTZdo4dqVizBe392rSl1uUOnwtTy7utbdNWvOp7WI/ R1iWP7Ne06HKHVVPXkyM8m7Nsg1PmfLjF+vUaqo5RqD7HI7a7iL5rqpPXtltpefopjlG yQIX8ikLa7EvGijHcU66PGRSkR5vdriV+MLpqh/zXwvFMFS7ZqRGmd3y9ObJUwpTSkat 1bkeebIO+GPAE6aDOFsaKpqzLkm917P6hQC9xMp1wbLCigQTF9B0TYFe8DbvdDdhMvqE 8oeHYqKi0p7hEiaTO3puXIw/lXtrUzBJIxaEPJDaCjweqM65wRU/G5wh2vapZ/LUAYyU JsXg== X-Forwarded-Encrypted: i=1; AJvYcCWima25uld66ptCixoTPcLv8YAkPXL5+ZHi1h7Ct/glHMk6ZmNtkrGjQzyfHGykl23RJecqBK7Mjtl7oGQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxi5Vpm+xypzc6uzxJSv+hbuXa6s//z4H2A2XJfMSOfCLXvz52j FCxyRWI7CvMk0ULfSEGsXkR+o9OWN7wMEmCGxN8ZhWr+g0K4ma3M3xXBVzXjMA0= X-Gm-Gg: ASbGnctip5grJmJ08jC3SEjAofdQr7GIwAn8kEwa8/r556O8/ByaedduAvfhLLK3UUI +ZPaLfDS7jrUQV5EppdzYeQCOVUFylYXsu+VCo6ljijRHTqfgd4ou9vwTgik1Ai7CQkpmILo3zm dvad9VQMtevTXwBNK9aqHwDu+qBImkIObb3+/tdLgW1XP7OYuFZ9WR144q+pjzBhZCII90iOZdt aZugM9S+kLlHXmUpWBrrTnsk6nLeIIhuYlnlsnjuKhHe/mS9hI+NDqm4vC1QL7egPesbvgUbsJh dHRojPrBpXKiosHjQiMRa27+EDWe3D5aPUNQI27dfrOdACs= X-Google-Smtp-Source: AGHT+IEqlKxdcHtWmpci4BLtxbDP+p3ZildeCHTAvguDG8QvB4Ez48M4koY5bUOldTogYj+eiwGfHw== X-Received: by 2002:a05:6808:250a:b0:3f3:ba60:f889 with SMTP id 5614622812f47-3f3c2696ddbmr691568b6e.28.1739227071302; Mon, 10 Feb 2025 14:37:51 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:49 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:33 -0600 Subject: [PATCH v3 07/15] iio: adc: ad7606: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-7-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Also drop unnecessary braces while we are at it. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..9a124139924e4a4fbbbd234a851= 4eb77024442b3 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev= , int val) =20 values[0] =3D val & GENMASK(2, 0); =20 - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiod_multi_set_value_cansleep(st->gpio_os, values); =20 /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..091f31edb6604da3a8ec4d2d532= 8ac6550faa22c 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -296,10 +296,9 @@ static int ad7606B_sw_mode_config(struct iio_dev *indi= o_dev) * in the device tree, then they need to be set to high, * otherwise, they must be hardwired to VDD */ - if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); - } + if (st->gpio_os) + gpiod_multi_set_value_cansleep(st->gpio_os, os); + /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail =3D ad7606B_oversampling_avail; st->num_os_ratios =3D ARRAY_SIZE(ad7606B_oversampling_avail); --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF9C25B69B for ; Mon, 10 Feb 2025 22:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227077; cv=none; b=BcVuWH7B1bPeT5vKJjzj2DfMmqn0LraxfJsIBJNALvxcEahkS2pBclfutVFW0hrFCY5pjSeHZR0gUg4/nNthyNkDTO8+oi3PiV/eVdeRPpdzYK46rX59n9jb31duaWe9PAM6spGE3vlJB6NchZjCn9HTxW1Ugzc+uqSpBLEpuqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227077; c=relaxed/simple; bh=DEtDLgJv5UYwZaak4CnPj1ALmi7rrV6hWuddp/nLJio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BXYU28OZa19UtOKS6povsYxFE1b/sECzArbWDO8CfddkYAPyB1AZdPxpDJNdkaOy9FQrRdENa5DytKLkp1ibz6FPK1xJx3PRowoIof8ha5KHmNgSiaNjla9zzsXS5eV51CHH32pjXOC5TQdngD9Eum694MwH1vOoLwbh78F4Ekc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vujvn9q1; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vujvn9q1" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3ac204922so1247842b6e.3 for ; Mon, 10 Feb 2025 14:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227074; x=1739831874; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=vujvn9q16sHkCxjODesonUK7YfToaWCovqp1meHYAiAMGuxuvuxvtjgT7kb4u9Rr6V swRcw0YIojKyBSboU0wstCJdaRggX8BRWH4M6uBpGT8p1fBitXYbaydpvLWzCEQjAgyH NK8GDJF94FCeuET5MshCx5YbGjJaWqAgw3WdWfpWFRjlu/QtI/QggzM5FO97TiYmaxBz PAABk2lpH9oFI0pUI/2JkcpFJHdPWUeviNglFTcXNGwMqsgsZIHJYDsnSsc9LP95ZXSs ERAcFCFmZaDh5TkuKpoMUw8CZYx5ReOtYpGtHricMbLSB2JZJizhsvkfgo09Zkf0S9Pe pc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227074; x=1739831874; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=G2RuVDOpzHrnpyDr4bRKhszkVXnjkPhyqAsgGkG/CO3K5tTINvrUSDTxRziKrAYjrr vcDXm7cAqjyhogilLqRRZHpsXECguTfRvRXvZ0C0UoBZQ9vNocxeK7pj5jPgAHH/INeq CuAJv/QSMBVaitJAOaI2fxkwR+F8YEYQgjbboyQEXMYgszibTJ632KKcDHlPLJomkyp7 4o5Kb4A4MP8yExe7rOFn7eDMAoMa4ZEn5qjiI+Awfwz0ZnMka1H1wmEoYK8u4oLXwviK dDT12BaKB1ANlRz3rq73HRVqEkBT51Y9PIPFJpNbAaYf6/YBx0oTZFM1GuCFrSbJ6bux EIyA== X-Forwarded-Encrypted: i=1; AJvYcCUt75mD6kiJ4HfeZNtgABLjU6VuK/Imkf+XQ+oqz48mioWLRDEsYBXOkT0WBXbQmXbJoq2OZnrSzBQX73Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyWlc4PSRRTHS8njscvJUFe4EolJBlLbzzHvksvoSid5xssRd12 tE2ral9xR2FryNHyaYitFjAvvRmc08TG4f2JmlVqG6DnhxoG0b4Am71PMnB13a8= X-Gm-Gg: ASbGncvslS7sJoyX46JngOeROvEsZs3/TFVBcFHnbW0CQdqn3HRsLer4yU8h6I2Fh0F 6PsbeOIg/sE+8QbE04LikQQ4qBLJg7ilHGnEaFLYM/4GBUMfSKZOET5+ao+0/fPab1xjZioyD80 wzcAJgPwjHXEJoGuWp4okb6uYD13ndPY7lAc+AFG4L6zKeguzhHznXFVH5hJ1hY785RB9bLWWlE +q8vrF7IIQ4JSsIjPm3t2rEUwaSC14bmNaUxTZRTK90NH2AetLML84L3Wv//InZ58Eqqe71kLfe 1F8mtM92tP0o83Ww2Id/MwhLSpxz1fF4QL819wcV+NcVKcM= X-Google-Smtp-Source: AGHT+IHpQCMO/UtYCFM9csSv77tlAPoKshLmX0/bTL0+YDtp28Q6Z4e9EVZz3B9NbqVlL1P+vOnPrw== X-Received: by 2002:a05:6808:1a19:b0:3eb:39f5:de8b with SMTP id 5614622812f47-3f392362d24mr10975894b6e.32.1739227074492; Mon, 10 Feb 2025 14:37:54 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:53 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:34 -0600 Subject: [PATCH v3 08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-8-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc4= 25a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..d9a359e1388a0f3eb5909bf668f= f82102286542b 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32= value) =20 values[0] =3D value; =20 - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiod_multi_set_value_cansleep(st->gpios, values); return 0; } =20 --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6991E25EF97 for ; Mon, 10 Feb 2025 22:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227080; cv=none; b=Z9X9ey7A8CchJKaD8lxNR2UH1AJlZtai4kO6xanUnheYezt1SybuG0X0amuykt5/Wo/h3aOQNUCEdS4+qwWM1yUf/TA6EXe1kuyhHjCnPQRJZW9UtK9G4obIpfqU4yPsNexC35CZnFemANPL+jjkU1LqAwQsZDc63jT83j90OOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227080; c=relaxed/simple; bh=w2oc7RoPm/sb7RYTc8soBDQAfVbctsAzru+e/xVugio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f1CbTX15fnmoUFrurSOQQQCeoS6SpcWdxnLATR74lb0B41j+vNWYdcDZM8HZ9aPPa7erFus3N+bPbUK8A54efLcDTuQKHe2ONHZMV68kcIDqd9do4Gaq/UR/RBc5DymLta4MTOqRk/ZrRTHzyz3xHb6yQXS56kIp2dmOKid5CXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=EX6Geyr2; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="EX6Geyr2" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3b8f6ff68so698439b6e.3 for ; Mon, 10 Feb 2025 14:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227078; x=1739831878; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=EX6Geyr2f5PrlcFQSDLNi8nG/h2PCdswLOTbPl4cfWLsKNV2v0DyC90gNZ3HcnGcC7 WLFTD6vVne9vl9xZfLrI850yPkknlKXY+s9FoBjWe0o6kfDt05hvDX6Z4xPtx2twLoDu Gg5/75WgIukUpmgSmbfgiekGaK/Uz2lI3X3FXAvJDPj3bqjUqSCBLtBayYCCwiM+d6P7 8wFqrDDLd/EwGgjGGVqn1XWvp23Ng9elYqsFt7WQrjcFELX6uRC5J6xC+yKawGNvuLEN loDm8yXQayJvC4kj+QCMv0rbMw2wPJCXPEWGTqZgBHuVYhUPwJg1c1WoYlntxYKYpzUR 40sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227078; x=1739831878; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=X4xoGfm0hPZJg37+4K/PIzd1Bx8M2bULT1jDgugeNvS1t2zQROFNeiWvrnPnXAPI1H 0ofccFnmzHv3Qo77Hc6WtahhXHwleWX++M7yYTGxMdouAbkMVrLTISE3N6Ouwhn08afJ mFJzjDtQifcHNeS57yTOIGFPMiSczD66R15yD8nJ3bxK525NxWRFPlq3NHiR0ks3eaBF ddXwbcl9LqYtiCB7sF5Bm/XvDZot10okazHWREhqpmGg5BgZKssYAqNiM7MJZSCvpTsB wy2G1gMbL+CSbF+l2DNwSSTMZ48yLnqATA+0yNg0we77UlLJtw+PwMifNzlNbVgudGkc j8VQ== X-Forwarded-Encrypted: i=1; AJvYcCWr7+OgPV9COGIIYsZeENYY6nKjwj7NR/6w+qh7Juo3YQwXshyI68zJnbHNWBskHhHuUZtreGVeSZk111I=@vger.kernel.org X-Gm-Message-State: AOJu0YwOU2j9Ya3gx0fbcEaAnlLfz6fcfUFp9FMlnOqXnI4V26cCcZrv r/O0qF0M4RzUF65oVBVcH6OUS6I+gqRAPZO04hYDawQRLXzKrTI8BgUdScRGk4I= X-Gm-Gg: ASbGnctr7u0UijzcgRBJ5pwQMX/bAuAXqRKitI0IJSZ2CTjb222ZyEFUjBwjKRv/Cpv Iup92qipMGkpwIqNPsGwE+k8s9HgnM0MmrFtZjqbepzwEPHgl8bJb5Zk6RTnkxF7a7JYaZyPAIz SN8n0PidDDBVLC9ZtO8I3GxaQT/4IOmWmV7XhPWLnm5p7iqWDnAX3VMPWFXIWtTg2hW4AHmnxYx /VaGTsn9MMRM0HYZ22ZLK2RsalokXXf7Q9PBeZFyOjdeRbstGmbQlHtIanbaEiNx4QUqbZPkoAR CZTOBBaP7qtocn+/iG+eLRJjQKyZ4T37bHmh2PL3J+V1BaU= X-Google-Smtp-Source: AGHT+IG3DTzAWvVW4SJ21A/SRgFk31074gXMN9+oGlJqzs/MtMc8XsiOogFgKzSWDZ9AZ40PkdjrRg== X-Received: by 2002:a05:6808:3c8e:b0:3f3:bda5:5739 with SMTP id 5614622812f47-3f3bda570bamr2064722b6e.17.1739227077726; Mon, 10 Feb 2025 14:37:57 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:56 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:35 -0600 Subject: [PATCH v3 09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-9-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s121= 0.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..7f18df790157f1e411fb70de193= a49f0677c999f 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st,= enum ad2s1210_mode mode) =20 bitmap[0] =3D mode; =20 - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiod_multi_set_value_cansleep(gpios, bitmap); } =20 /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_stat= e *st) =20 bitmap[0] =3D st->resolution; =20 - ret =3D gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret =3D gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D86254AF6 for ; Mon, 10 Feb 2025 22:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227083; cv=none; b=lEyt7e9sP0b4FJbJ0S4ythE/blzrgF1fJRLQLqCO65O6blY7O56YcWphAhJvw27TC7QpBDmAXtSdowZjgmxmkxv1XpCJZcm+vVOORxkWcuHPLYo8Evhd8kPmoJeFS3V/DI/SytWjNCCnoiNot9O/kywf/b9OTJS5DB4PXc3wTbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227083; c=relaxed/simple; bh=0Dd/TwIMPTa1NXxF+RDclsVv0WgpIYcbyrIZrxifJTs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lLXkh1YPZEk+r+m2JA77kaTgP2LjcTFc7mMNPQYDmCRHm/jBESE8XR0qYCf+jebvSbJ+zmNQKGmaxf9E8B2rVU3FoCfw5CUP2xIQkKACHjlD7aMuOsLaOc/8QmrIeJSg/8eN41BqL0zy62y8RDqISsh7EtT1hXfJQJeRqKN2LwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=M3WvfM8y; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="M3WvfM8y" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3f3a6cb98a5so1662597b6e.0 for ; Mon, 10 Feb 2025 14:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227081; x=1739831881; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=M3WvfM8ymctecf7QYdHpg7RaqGEsSScrBBIP+Sm8JoWZiIhr1YQWZYm4I49UrOti0X 4XZ/AUUmkJVqIyITioaWP9A2CIByRnd15BMVkg+7lgnMkbw9e1PIV9+2Kt3Iu/s/YCiV dNixT0lIbp9WZ5zStWkZdKDOerMk4C+L9IdKdMBpUWGi0zEJMhewdOnwbmz6kNLOLWvk 8RTyGRZ8WMcsHMAyw99dkawyekVFF3t9u34sR/jrDW0m9l6Jw+N44mdF4HncsBbkQ75c jwxpbxNm8EbtpTyE3mfHY9oauY6l3DGauHoaF8WcpP0vnq5E/AxtLGqmSMospizOgeNA qAfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227081; x=1739831881; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=QTeNmOgZjl2bV5fUSokmh5gwdTeYkFygimLN5ZkwCdUAj7cSBenz+Du8GaPDWbl6wJ DPdgSk2xk9OOmLsJSV1T0nf81pkvbE13qV4ybVMNiaBiIsAzgiOXh0Xlo7DJSSNbu9CG eU54kK5adPn6tqvDS6bfOfMVUmWaiqc4iSob2ExHJfYDtD9y/7riTTQHfJw9fUAtXiCv tlI5l4Gcv740pdEJfMVf1BuQru9KFX5Rx4iiAj3mx+8IllRpLesiqeCaCJe7q0tyjy3l tKsuJzbE/PVVpMQERiEiMwiE91yoNUnR2mEySsbRKXbtUfIrTmjjZQxV4WgbSbcn+SL7 2g9A== X-Forwarded-Encrypted: i=1; AJvYcCVncMUEOzqi/D24zPWGtGZ1l7i9Z4d6PGxz0/AaponiLZv4btEW0caZEGNe6eytE6lzFOPXLj22tJHud6M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5LMnImkQhLqqHz4lqEBu76PzZ6dnSVmmYeFnGUg7MP+XuKT61 VWs88icsrUIRcGfGssJz1kIFs3NNJv2gW5tESbCExTUax6kaTh8ZGm5+Auvexeg= X-Gm-Gg: ASbGncuEtdDxbWIleQBixJEGt3qBIf46mNiaemQXZVmci9j8Aky8KjLcQjOMTftBPoj g5b8PTDovgARwjD12yqJTfv9PREdrN8BxP+CC5pGnVx57uZw8CorTkFndmIgDxHNYrbJMV0QxQz 5gfUF9JI/miWIqwaog3DdXQEIOevTZNvU+O/cV9GMsFaTAJO5GT5eZT6aen3bcYV2IZovJzzzYL Kf5qcRNmMjypOsmiD3za9LNlsXDG7nHBhqF0nePr27X4CfdKr6bzSlvkUncVZw+/oR/2sw+WhNA 4HSBBdEKCR/ky91cGRQ1H6U40dgUrbj+R8+ZP7uqy2IG/Qo= X-Google-Smtp-Source: AGHT+IGzPPZHWL9nm38yMUud0RRSbV/Ra+QmKEWIgQuJSF5KnPaRf3ayet85Wv9392Tvxy5qCKs2yQ== X-Received: by 2002:a05:6808:3c8a:b0:3eb:4681:a895 with SMTP id 5614622812f47-3f3921f0b9cmr10552910b6e.7.1739227080875; Mon, 10 Feb 2025 14:38:00 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:59 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:36 -0600 Subject: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-10-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Replace bitmap array access with bitmap_write. Accessing the bitmap array directly is not recommended and now there is a helper function that can be used. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Jonathan Cameron --- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s121= 0.c index 7f18df790157f1e411fb70de193a49f0677c999f..04879e6d538bce664469c5f6759= d8b1cedea16e9 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -46,6 +46,7 @@ */ =20 #include +#include #include #include #include @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st,= enum ad2s1210_mode mode) if (!gpios) return mode =3D=3D st->fixed_mode ? 0 : -EOPNOTSUPP; =20 - bitmap[0] =3D mode; + bitmap_write(bitmap, mode, 0, 2); =20 return gpiod_multi_set_value_cansleep(gpios, bitmap); } @@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state= *st) return dev_err_probe(dev, -EINVAL, "requires exactly 2 resolution-gpios\n"); =20 - bitmap[0] =3D st->resolution; + bitmap_write(bitmap, st->resolution, 0, 2); =20 ret =3D gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9E726136B for ; Mon, 10 Feb 2025 22:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227086; cv=none; b=BoXfAlPE+dodIW4Nlk1AhbuRg0dq/emixI+fpizjhAynZVvnuqkzcTIWhLYJbs6+ilzGsaqEfKEBKl78yx9aW71cHBWOe1VNtqLP6RufSVU10tU5nyzN00A2cfRu88NgKK3zPV9Jz+L6OX+svrT/BdNe0GcAlWLdGB/jyJJjrkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227086; c=relaxed/simple; bh=HaFWSgBdfXggpkPiEPQivtzXY7Xojib1tG2MzfPUdgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uOKbPH5VymE+TqCmCa7xTrAjq/e4bMSBfaa31DuvTcG9eEzHYR/v7afe8bpbSdW4Z78af4eHrR9sUqCfpdDWRfF4XHjQmaE37yxqC3YK7QzQhHp/Ed5VcCvo16zKGKC8DX4x4hbcFnb4ZhDcVdCbduph8FbC409ZyuDjMdBqs8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dvT7bBar; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dvT7bBar" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3b5894f8bso423169b6e.1 for ; Mon, 10 Feb 2025 14:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227084; x=1739831884; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=dvT7bBarIKuEWBzaSXQSY+SnArGsqGr/slLKnVFFZomy3o8Y7mA0cJYOeuqEF8ebQ5 EYjWEFTAsMlN8wUjpBXVRZJ4c+9sfmhTPhJARW0U9roz14XLV8uumAVN7Y4jQfNDt+Mx 4VsoXxl3N2f/veqPjFziqBFyN2fRoP9igA0vAQGZa9VpTK7akEoPfDtAOkq7aw1zoabj 3DXbgv9RD9VrFaEutLLzROGEcDyjB/5zKDPh/FwpDAlDAs8vmg4uISd+0qNZd0Z8E062 M5zOhNCFsU5ajmPnD42Xq9RfJsENLoSkUPInqDccieECrnEeZIN9EzBY+oXsOedDWPq+ qZ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227084; x=1739831884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=cg3/F4DLJ8ThhWpjq2D7P/KwvIJ16xDQSUwTiUqdLzsQg7d9Mq8u1VO56EstjfdJoA 1TpYXu72MEY1fk8bsvYHf8TFs1tHQMSSeg8h9+RTMdQpZ1slD0cRnPL9h4YsFZxAjgH8 AMHJ5lNqCT0+ylCHsMzM67xawAaDk2NwcL4HctNJfVdEzqy8ZH9whxrK8iI+8PHjx1JR bH9eULNGk3jOXxqUcv8QZFrsXElJh9W/1iWKnSJANXxeyCrheMN5KH/5v7uJNoGF9/a9 qu/z6dss+fIm3BLQdXn6fLDpFTLVYJcyTdlDKs1EHStRj8e9GyCwhOlZ14REeNHm+oIa MGHg== X-Forwarded-Encrypted: i=1; AJvYcCVQwHAkFsJQRZ+F9T4QJRtgDWeJI/3YvnZWASw5Wq3JlHPEMnnhJ1cX660C4lWL4qMc6gG078Eun97er9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ1PLj7aI51Nmps3DiHHJC2ligCD43waA9hKQjlD15V0OpZthu uDHjoYmysgNhV15udlWdSgQpaG+ScfYGS5jbWJyrhS/CHq0jCB7HxjRffgOpR7I= X-Gm-Gg: ASbGncuBsrDmqaI493rKzzmivjaJJP1OVctkCGEKJ7zOymcisT2d5uroGSfapcl5qC8 lRe/8fbE/mAaGiQ5KFfUtxhTDGhCHrg1Ef3jYGNnZNp0XKgp2PRR5wS3/HmIR34tqK6O3Yqghqr lBMFmACut8r021g/A0jkrPO7F4BEABfzO5zsGx4I1gfw6A43md9SuinGG8pgPNqrDrLs8za6wfv 5l9GO2lBHQLbG9btwSKlKhsOnN3upbJQhGBo125fHDWRXeOz7Xk6yTW1sjraZ1yAeFXTh5bwHT4 FLhCQkr8IVHSLLRA1yPDcYXs92r7ElviDFPxw92iDk7IJrA= X-Google-Smtp-Source: AGHT+IHyCAwDYiRcWVzrn7K/Vx60yNjdpFZhmlXwDMeVTAgENeKIRtjDdhXHEsiUOrCJ2abC/Ga6Zw== X-Received: by 2002:a05:6808:2209:b0:3f3:ba53:1e11 with SMTP id 5614622812f47-3f3ba53229amr2521701b6e.6.1739227084078; Mon, 10 Feb 2025 14:38:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:02 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:37 -0600 Subject: [PATCH v3 11/15] mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-11-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Ulf Hansson Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_sim= ple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..4b47e6c3b04b99dc328a8b06366= 5a76340a8e0d0 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_= pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); =20 - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiod_multi_set_value_cansleep(reset_gpios, values); =20 bitmap_free(values); } --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 349BC261399 for ; Mon, 10 Feb 2025 22:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227089; cv=none; b=kvDuBg/TFvev71sVT9cRIAEa67C3UtJBbHfq/0Ky3NPyaZUuaI7XTZMRXSyWuy6taEs0QyKmaHZEp14ZBN2Gxob2baabQt1EmHUkbromkw6YtV2B32rLqZ2N9py7fYnidic1acLhHiqBid7gXb/O1y5yJGVLdmSEasYtMgxPw1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227089; c=relaxed/simple; bh=DTPgNGmkXhUVKQ7XC6/DETbHbqjA5xVWJi+TJtvGAQA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ao5c3CObKbtGP1VbWDl5FXuW7VYod9ujfB8lmUQ57zS81C59L66f98gFiT0VohedaTtIXzHn5tf0UhDntPiOFGEdJE72iyAtkczBeAe8AHOf4LMYP/4ZPfmH4twceU9VtTG6aVWtQzR32fI+TX3nA0SXJCC9pxsk/7ghudtUj+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LTcJkq0b; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LTcJkq0b" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3f3a52134b5so732472b6e.0 for ; Mon, 10 Feb 2025 14:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227087; x=1739831887; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=LTcJkq0bR7PqP6F7wNnr7kEwpB4IF+ENhJyvzgS8fx9V1DHttG4+yB9aXdX2XtYqey ImnOvKF1kPCn+B+hvwptAIyqjFNAhCVoYf4R7MYlBP3TdUek2RvoXt9ei+lvtG1TpNZR ldm6VIh8HdBroOf+FV63AN3VmfB3IcIuE04PXtVLjGk/7zP69+7IGc8rwtxn8G0PW7LR 93iucsg1kEq8zsf/UOq2z0xlzl/mjinkGJli56pIiLAyo+aYgXx8EtjBhb+XdWAeo8b8 pNiGcAzR3dQcfld0oLNZt3rK+u/gbZ8n4OevvpuU/QoE7LeRXbkQSsHY2H3sg33vaU0C lNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227087; x=1739831887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=EFVRLKcFupymGvkZWjdW3TPwkQ9/1vfqDmhDnRLYW05gumlBPKBWFmvQWS2nvBJcPB 9KExQwZh//H2i5QAtMAbVeg6zroomRq/zDUOVi+qekwGahJwIUV4nGLjpZPetdW4tUl3 DEKHgVf0Iq9dQCed/9Y5m/XLuct6pcP9+Ht+TwSdBdOnpU/SuzRvUrlm0VUlEfOGjr2Y KsuzUCOgzz6kJEZiUyufK74YAvzK3DoKeEBrNxpKsCtslxecfYyOgsZSxO9X9FjLMFED s3TmvVhxq795YJUPSB2m8A1jr2UFQAUor1sv/qlExzq14SuBehOcZjBA491jNHc7s7VR YGCQ== X-Forwarded-Encrypted: i=1; AJvYcCXwgOMoRxd2pa4J64OA2LLovwsF2yjKVbv4yfEt86E5ONIADHMRnU4H5XxuUdRw7YLzhFeLCyE+uFYoViw=@vger.kernel.org X-Gm-Message-State: AOJu0YyVQeBj2Z6zYktGzTYPFgYqN16qNqyeV+uOM83h4X3+jgRvFr+W +ACwZPOFSOMlWQro1gMFTsFTDSG2Pqs4KwAKDARlhtIhY9BW+vOoiMi1xsSnPYc= X-Gm-Gg: ASbGncur61wIKQh5mDwqBfFIQTeDGCz8ZDK2gI2bVvQin6siFED03PBre6fmfcmRrdj F1JC6wmlTlB8u4L4aOv8ye+O18BZ1dTWD+MPsK0v6LyDxMNF49KbBs60MgXh6Kv8bISlHwNlpcw 3o6qieYkAocuS+5dW1dYcC12s6Z4OBu6a+Mv48TuMv4fu8X7iKlkxiHAhSQv7mjp78Z00au91Ef EFurko1j6Ad/uBwoku7ITCB4AOOxpCRAnxCXI3uFibVEpcVsbaoPQ5kSZg21h5AS0Yoz45pcpNO kErgaG36Sel8DLC/wF6j6vERGAcyJJazN2HNva9z9uLs9eY= X-Google-Smtp-Source: AGHT+IFodsa1xU/+j9iOyHK4zd5srfGLBws68RU1hOd0Hvn3EqSmNLjWe0xJTDgUwSiCbolk4Lse1g== X-Received: by 2002:a05:6808:23cb:b0:3eb:5f1a:d083 with SMTP id 5614622812f47-3f3c2633408mr767124b6e.20.1739227087286; Mon, 10 Feb 2025 14:38:07 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:05 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:38 -0600 Subject: [PATCH v3 12/15] mux: gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-12-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Peter Rosin Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..5710879cd47f89b6ef4458d6b44= 19a1fe9ad349f 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int stat= e) =20 bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); =20 - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiod_multi_set_value_cansleep(mux_gpio->gpios, values); =20 return 0; } --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC3B26216D for ; Mon, 10 Feb 2025 22:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227094; cv=none; b=m10bTOPnrnD2yLmCuXY20KMdTqeOiBgFz13YwWib4+cIv7UWrclzqIaMIX1tWn9331SQTZKRmu0e1msTgN6FGxCEeHyqSmojBj8GC1l0H4pfbyjzgv05nikJ+YC+BGw4f4kD2zSe9WWf4DBVRbf5aNWWE9Ceyfo0GBWx53z1wRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227094; c=relaxed/simple; bh=S7dgE3UPYoL2oEd02LPby/4FImzR8JSvqPwrh4K9qkM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FrMXLlgb/nGWw/zRwb7T2n4vvOK+7wXlWjhGQxBrtp0iM4txkqLccW4GH5UIJS2pESPntKspRGwTRFa8KhtGUUOpfd3ho0Ve0LzEU2wM8jd/LG/hKBUBchfjH9iGn/3C8DDWp63xAdN1MCfIUlYL/REXUQN88uPuftBAySC8irE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=BJ0usfEc; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="BJ0usfEc" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3f3b93e4e32so650349b6e.0 for ; Mon, 10 Feb 2025 14:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227090; x=1739831890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=BJ0usfEc8bq2iGaNqvnO+QrMUgXM4SZlUqy86xdWNruvIJewuF0mRFPLiTJrvKgBkD SjPXKAuhfZoCQlkwLVxSwPryGbpR7fHGwTcWaL8B8PpBUn+bjKC76ATM2e3VE9qQna6J B+5N59bxZXtcAONRrE4AThe7VNP4QoM3rAF43E3RumEFvj/I3GwobPkbndcTNDJqN+Wr kQOX41HS5dORLNUgDRg0VlhIa0xDaxRzpL3BEY9N3YGYpdQQE+zOUSIQsGC0QMOhrJbJ ilScfPVVtamPAZvcWVgMwsr4k0+HYngZSpXAKdfgPw0ott3VUMhIQcvo22BQqYhqlEfR 9mwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227090; x=1739831890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=SM62UrR7M6F8Hw9+2xhzSsEbNoUnRMa0HIoGUr69jgngmoa82Mnz49rjjaYIryMkfr nxtjplDvvS1Ed/yB0Xvuw1756KRI1I8KcRQBJPHkxHVflYTLUEboSKii0uvLStIyIF1L EBHtEoLuIRGRqpefTqcDx0r2NV38Iz4g6cCf/CCCY3a+G8AoZRlU8SjH1WzMwF1AT008 NBw25orWuT12JFD+0QTSQjg4UFXlxHG2/mZvdfoJN58BuiF3eB8R6ZtCvPzZ4HpnFt22 afynTQA197RH3hP+IrmH2pVp4CHlxj75k//gdYYfUzMxEZkm9mLOSuhP/foygO30Pt2e oOqA== X-Forwarded-Encrypted: i=1; AJvYcCW60jBNCo3dACkk0rH2syB1NqZbvisHquok1vjuyG5tJLM548+UeCMxR+YMfXe34fhBBhq0XElJV/lx6iA=@vger.kernel.org X-Gm-Message-State: AOJu0YzW+FVaWCTxzaHvTRTiP5XnUjepoIbtioyeJZyrDSn2UdyqDYZ+ EXFXICW4jLE8Zqe+basYZGWmRdbWbxkY43C3Aip+wBJ1z0PV70rv4Bb/enlvRkE= X-Gm-Gg: ASbGncv7Ze9oJhXzzbqO++gvo+WTK9QND+SkCDXkodqj3nI0Mg2u9Nq2ZjfliTqgb/S KLgC/b6tbgfhH95swjHT7CxPymxYtG2SCMUVYZMRsz2sxOFWf2nx8y0GIcquHgVvKkYrMv4A8YG n1oLk3Lp0ZsB53SXVs03Q+G/QBaF8Y+oencpJ75gpLxPbnazV2HLV81g9xy9EjypQX3QMf1CYLn +DUxi5KfNmEZMUJ+YtsMSLK1sJnFljwYGIGF6KiKeIN2jyS5wfi/BQYSzJ+m8bgyhg4o8PmMnOy JYxjDSI5tSr17L/3YwOf/YzSsVrgwMmRNGHSqBIAl/iuiPM= X-Google-Smtp-Source: AGHT+IExgIdSlhgQSDcOsxwx6WPuocJhwApgTGH7w9m44PNZh2BZdc/bphIdIFYjyr15eu6B7MhSQQ== X-Received: by 2002:a05:6808:308e:b0:3e6:54c8:fad3 with SMTP id 5614622812f47-3f3c2abf6c3mr690448b6e.19.1739227090579; Mon, 10 Feb 2025 14:38:10 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:09 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:39 -0600 Subject: [PATCH v3 13/15] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-13-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-g= pio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..fefa40ea5227c5a35d89ec2c6f9= 5c6668a2470f6 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int= desired_child, =20 values[0] =3D desired_child; =20 - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiod_multi_set_value_cansleep(s->gpios, values); =20 return 0; } --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DDFB262D0A for ; Mon, 10 Feb 2025 22:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227096; cv=none; b=KK8GtzsOEC5cAPctQjeZgG6w6HTuuNzstJsVV77BPryDQmg15VD11q9dfGCpb2mUbi5Lybz6a2SerSdMem5T8bb+jJ7pm/AFI7EK4RxFre98r0EuvpKbJrLo1RHXwpsARW1aay+5jTCMGNAV0vsyps3PqQ9cNnvkgJZJ0TQihi0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227096; c=relaxed/simple; bh=QtC6oLxmw2DvbNfS+XsWeQUt9WZBo54DTtz6cY2CdFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KINSs26QmYyKy9eOoyN3a3ZufL0hsLtPzgjb9GaUsQz/rdM3x8EAg4ldduWPKK3EVjG6mVGAcDtCeg3ouGy5b9ynQ+4O/nNldRBd8bQA9eZ4wtezJqRMjW9D8x/0TgpWn0YaNFJ5sEaPhFzdtwTlCfpToWGIOErAVuTReYo5JP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zEC5uXyi; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zEC5uXyi" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3eb6b16f1a0so1304153b6e.3 for ; Mon, 10 Feb 2025 14:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227094; x=1739831894; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=zEC5uXyiKhnWOqx5/A8Yv466JRMMJpfwQTn92/mpKZPcLRRpvvrtis3ZcZ8KXEs2bZ MYupPNSVfFZyhyW8mGDUXI7AkGkRPbwA5Ip8LRCzhWlJNwQ8JW1hHsZnwHNb90V0OYyN DyaeDXGZtV6R4og2AP/D+rqByz5AEqDCvkw+vDjbZOT/yDIPlpGbDsdU987VvJhNr3Rm LgUIQVTjmd6QOgHUUBpVWidY5H2scFqZbGYGkzFylqfteOf5Lui0VIZgYmrn9uwBVKfv iYI7mnqGc/V52O3qyFceLfV+fnXugHeokcmKk86QXw6q21/eBgjFmexD0j/GxKETOMKu KnJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227094; x=1739831894; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=rFLlXDwX4T2oZgIEmO7M2VKErEoUvr4jcMxJzbiO8OXv2KplhVezFNaE0EDZo39BB+ O+ayzlb2X0KueHN4HnqmGKLC9f347+IYkD6tLcZq7gP6Bq1Ic8YYbgLt+4H9BF6UMiVD kFZro3Ddr5LEi5fgwJgHQ0eqLa33kvYRB1BBCx7S26OW1lquTbKkw/SdUE6kgM8UlEMh JR+WjlRA7XlmYcjO5p+Hd2YvyEJd3nB6sweZ52RF71AbUyd91vWCYUjYIO6kLUVKBgnW cfyn1X1IUjClyTC2agswk0lTir6iHjPYVWat8wqgXql0wzQ4aO0DGJvgf1L+69WQ3P8w oHOw== X-Forwarded-Encrypted: i=1; AJvYcCW09I7gsEgiPH3B6xGU3V9XwDL4KSSVNVIGhBicEDLtCECGcw8Rk3vZQCJ//89bNp4mEOkA88YuL/lzF/w=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp4FsnK80TjpmIy/kcow7mvw+YsMzh1HqWIuqGJSHoOPtf8l2e CUD8+Jb+/tXEhDJYxJmQ2OkSjszcLAbzLSmxn7ebyDntHZDArRHd31vB7u/7pNo= X-Gm-Gg: ASbGncv0ogWihxSae6kzrZ+5GXIgZTpKhJh1BlLDQ/AszU+4xiakeI2BZkhkHwN9u/5 FZO/Yk4+zPPSprHkli6HEktHnwGb6SF5aAW7W6wSjRHB7WqUp0O6krSrdyhEO1xCAU9Q3Pg5LOs ODrvZiCjw6NViydZsyxR6ZtmUHnDk120kfpAekm9SYOtpsBS5dFpaLntSGY6F8yBfU/xtVqxAA3 mayIFCSRv2G5cz0ObPktgvL/47oXxNcEE7eLZzgwsH48wJvw//BwO9HAvbE+MiC/OL79V8fn4Ox 2mFh5Qo5ond3JfW19CyEl+wED3YIWQwpHpJG1EboRV6GxSQ= X-Google-Smtp-Source: AGHT+IEVAt15PQdS8DVNqyeJacSiAcXpbNeOp6OkG5/0y5b43SqHZC4XrUJm46YNpLSsnE3NWRVPBQ== X-Received: by 2002:a05:6808:150e:b0:3ea:519e:cc71 with SMTP id 5614622812f47-3f39242c9d0mr8056705b6e.39.1739227093792; Mon, 10 Feb 2025 14:38:13 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:12 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:40 -0600 Subject: [PATCH v3 14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-14-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Vinod Koul --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/moto= rola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..fd0e0cd1c1cfb10fb55ed271e47= b6a0bf857028e 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, = int val) =20 values[0] =3D val; =20 - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiod_multi_set_value_cansleep(ddata->cmd_gpios, values); } =20 /** --=20 2.43.0 From nobody Sat Feb 7 08:44:26 2026 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8C7263888 for ; Mon, 10 Feb 2025 22:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227099; cv=none; b=qLVGaXuPDJ+PfIUfBr8PxsYDSHUHI2vH/+GrXT0Pbd3Lcf8NGxUH4BZSpoKTYHlW7u/+sWd9PbWdYRjNJLjOd+41//54NPRaaVsJXtja7bkN+H4MzoNmbsL+UEg92nACt8QkUf6tr4eTEThlQn/0XT4KMgBErTarZQZmvF338o4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227099; c=relaxed/simple; bh=SREiuK3L9rZlfmn2CRPkgp1zixwI3ho4VDIygOej2Dw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hlX2wlmKJFre9gJAi2VjqjKV6NKU8Xyq2iWR8n1DsIh27qHXXwx4bjtMUOJ5geQ3qMJWfIl28j996fqyRnyxoAabxsxHnwkT040NufgnV/mLLS/xf7X9tKpf69LipMkXNQ3rxr2RiDfOvCgeT+5oTUa+nOVydU6c1191Dqhz7xY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sBoqBWii; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sBoqBWii" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3ee29277d44so2978290b6e.1 for ; Mon, 10 Feb 2025 14:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227097; x=1739831897; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=sBoqBWiilrg6G6DcKncG/QpD3XTif6KLjw4bVZEcVRfSe0hlXDRNldE9YF2PAWEulM /sVf3tX5SwJe89Lj9M3MIJaCSs/jc++FpF8/lBpSXw2Rh4aJABVWPzB+mAbwOIK7QYhN 6oPTUx7jplW5h1Q9Glmxas07OXMuPokCylYCVZrWgO1kbMVxEreyu7pT3Uos0DthgENZ qRm2huNp0aJC+MYKTFrjAeCcU0mMxdfCA6N5q8CvwJ9rjYFSF2MzzMa+Jy26pj/OKhJr 5eOr6oS8AUK89BLsnCV0I9YsOlDgM+6fh0+hziadoBBOWYFT53YLUukUBy7sBwFkSFVY JHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227097; x=1739831897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=DNT5ZeJpNFJd3wkw1M5SJJH9/mwXbP0SXnbwV6CT5v59OnGFFBf8QG3CnYfe2pOxYi 7LAHvOQ1PjmGIwBSCqPryk78Y93W5F8MxPQwnPJejq4xF2/EhQcGWLsYB6iQf8EjDqTd 9RVklyzTiQwq5vX25VeDFxhrDjeOdxvvE9e+7jjqmrf5eoUBGbXAMoxDGJEjOp2QZB6Z s5rJ25TmMDlJ0dtlid215XMgNMKDFlAS5z7GCTKwxFJHdpf5ELWn+xyZiztGV8oga8V1 sVO+4jGDtOjcUVt4Mk7uSu0r8/JYzMpDFvQMa7jYg98fZHPUccaHsMAVBYcmFrvAyzTN DKUQ== X-Forwarded-Encrypted: i=1; AJvYcCWNUG7cke9OqAv5yv8qXQrpqIcX+TvRqMEQFuhgFpI36OILM+M+BQMC6Ht72xMCkeWrbGlGTdjCXInhF6M=@vger.kernel.org X-Gm-Message-State: AOJu0YzYJ7BxE9cdimm5GkC49Yjb3gCX/dB2tyO38moFkVQF02qrvb40 Ayaj0/XG3LxMCK8/Kr1ZRCfvO3JhPMVFMsEfShgSPzTJFOR5nivgEx4vJxnK0qg= X-Gm-Gg: ASbGncuWIr3ug/jUjddYHZTXoGqjeR716h/g4pA9cG2YRIzrWs3hB1mwrlM7XfHhXo3 SyTKRnz1gERIb/szkVLw6fG/Dl5BfV8TrSTqM/LQDUaOH3XmUjKw+/vWebWud8I1Tgqwzz3llF6 UPuZYw5xtQvvpwKNAHlDlAqSOrZokN5LtSC6g9yy2KR0Z1/ESgbQxdjgs8YvOUI59zDDjZt5W0O lRxlJR5Kakv8u5IDNtC7w8+m+G6ksnph5lso2ByLAFT+4UHwUrCDolN/gbFtJ8B67tXhCmi4Ms4 oS/gBOeBQtEodvxcVWj3xNwMZBv264tyEc5PjJpUA5c4Tl0= X-Google-Smtp-Source: AGHT+IENohB4+Vdl15nvUdajyBJJbaG44s39TfMb4Zf97z1Hi7JTuCyMgAhZEnJb83znOkXtS3I7Kg== X-Received: by 2002:a05:6808:10c7:b0:3f3:be50:2a69 with SMTP id 5614622812f47-3f3be502d24mr1971166b6e.17.1739227097004; Mon, 10 Feb 2025 14:38:17 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:15 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:41 -0600 Subject: [PATCH v3 15/15] ASoC: adau1701: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-set-array-helper-v3-15-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Mark Brown Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..6876462d8bdbb41d551f776c2d7= fe6ed46115fa1 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *com= ponent, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiod_multi_set_value_cansleep(adau1701->gpio_pll_mode, values); } =20 adau1701->pll_clkdiv =3D clkdiv; --=20 2.43.0