From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C268B1C9B97 for ; Mon, 10 Feb 2025 10:52:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184730; cv=none; b=SXwLYPTri/7BT6THzWhDIJQ9LkP8seNogFA2pt93V5ACSKdQnzjdzuTPZ5gTWlW5plOvwPx95G1sntIljXY6I0Sbrnud2gY/kf3f5D7RHJRsiSDgP8mzdihu9deM/cbN0s9iQawuBL9650yRuxIECPSoUEMcIPE7AtXE3GD0u9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184730; c=relaxed/simple; bh=RfHBELWftEOI6aduadNpWSnZVyvCMZTRiybMbk/nsKY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n5NqBqzqs6V1t5fyyBfg6zU5mWrVrTE01Tcu2c2JNL+XGs4uDx79hPSxFvO7ftz8Us5W4Vg9Bfp3Ox83Hu3F59tGKQOvs5uHN5u4hNizVELBXOKApdfE7k5QvqkfN0jc3KaKD7lutnRB6A8aQDV1oVlhWy/r4X1HBT16AahpcE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wI3pd9px; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wI3pd9px" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4394829ef0fso2410705e9.0 for ; Mon, 10 Feb 2025 02:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184727; x=1739789527; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oe6RHeWjCutLo5iDZJ7f7rTUbrd3skJS2x0XvYoqI4M=; b=wI3pd9pxnebMqrq3eY4jY87tbCb9REOQW/vNTZc9FtYS1LToJxqwnhEtSxeF4C2QnR A+jwFiRgmUK3DQywWk//dqo+pOD1On08wVDLAwr8llvbbimo9G+9fxY4NjhdZUzChch7 KyD2WwgS/FpZqLcAAkjAIMzVuyk9Fy3FkRPIAGKUwSVoM4gHOaHuDSEk3KalEmYEo61m LbmlySyey2wnVyzshKUEfFKAeQ4Q9KmUlv/sOx/gLeADFzajwLk+SsbJwvTGeJTCO0DY 7el3Q3Uz90HBteyuNHDAaJXtAlzEqKcVJKoVcjfLTCXpikj0Xi9+yu2KJth7cRZjZESd FhfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184727; x=1739789527; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oe6RHeWjCutLo5iDZJ7f7rTUbrd3skJS2x0XvYoqI4M=; b=vG6UHnaez7hbmp5XouUxObM/z45HeAeaJ97Zq0BIAMcecxoEwpWdzrj9Q2bGnOKE/t eLk+XBSJOVdwZPp/Kv+m4kZ/msmhIl1sqSH/L2V1EuAwVezvxw53+2IZx05jtczyHcUO cz1Yd3L9qAlj05FxEvzhFXasstkQVzH26B0Jw24NpmQllxLMhSR1VLdL0b12tDV1ZEvX uB+3wZmJiz5Md+14FyUCEl9TqxuiFQetKdL+dUZkjwW3v5i4xZSmT7z/NHVlA+Qp9fYl PmiyivnFSyWd/ZFVLBFaW+a4waDL0fNOnUudbPocS91ioHU86j30xCqfqQ4Fhx9FW89j W4ug== X-Forwarded-Encrypted: i=1; AJvYcCUa+ZZo5MIj6/4AiZb10qFjjrEMLsHi3FqYsGK21wZdQntidHXkjL0OlBAqW7ti8xG9zy41T+n/FAkGaeg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6yac9wuKab8AMFcI8SEcf1D9Fc0sc0QHZoF47QG2lRUtotaoM zXIcqDth7LqADIGWTy/wa8V8hbyLdQY3K68W1yCgWRdIlreR/0x8WixIM+uZ43/T82HHTlj+UvJ eiXw= X-Gm-Gg: ASbGncuoX1F0nr1iOHr0PmNCIdiSP8FXcpNS4UIpj9cUZKAD8L4B8qG4Rk2ALFcxyve tGWspvPHTYd0+WU9qR4KZlR+SXkX77E58qv1lcHU9opxeuYsMiab9zKFHrAB5YBQVw5DPAxJv1E Lg+thh71l8VSgvfkbjC7xbzhicodr98BtBjDvYQFQ5b3P9Dir9p21oPAqEiU+j2mYz7jCAT/c/M LEQUk2siUkZLqfGNAnWib+nL1xnGSfilFarJAu4kiK2B+6mzdhlH12G9hA+LeSwnvY4ZFO+Qogf lUt2xmim X-Google-Smtp-Source: AGHT+IGBAZdBYR3TYPZOFingx6IDVarvNd1xtuG26gadPMUlJJHpUqSLxIS+6zs0KMce2R6DTrtQJg== X-Received: by 2002:a05:600c:3c96:b0:436:1b86:f05 with SMTP id 5b1f17b1804b1-439255b81e1mr94425715e9.11.1739184726533; Mon, 10 Feb 2025 02:52:06 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:05 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:51:55 +0100 Subject: [PATCH 1/8] gpiolib: check the return value of gpio_chip::get_direction() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-1-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2846; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=lpE55aITs3TR0edspV0JF4dj9P5jKU0BTQ+eUb+VBxg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpSfnhhEUo6hT94zgAJgM2xjsjhsYO1vA+T0 5EoGpZakeGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUgAKCRARpy6gFHHX cplCEAC9jg6cqsozxgAdfJBzUaYa+ZLzYNwuow+HZhV8fZDTTaaAyTUsXwiBvRP+WiPTHDehfMA GTEnGaHrEsFimr6T9IHElWUzybgmTrQRTW2MIfMUjxubcxckxHyPhJw97ErCdtUhfUll0OdXY+T ONyN3rJdZkz24OqcN422aTAdH4hKLyMfnv/w0s6x1K/gzsXlf6NyHmDDJh80JRkBMwzEsL6YbO9 B65JKmxa0gBdnI36HYvYDHPs9QZAMlae0WzAVFzHQRmrNj+pdk932spDIFUwyLCnZC1Ar23KCda nbCd0PS4/DgSK1OaEgMamD7jguHCwyF7LIzDou2alhSCWukW4KjO714XP9w7gBWN32YaIibeUyY BRX9blIl4eQGtj78PdDvri2lAVfEMT/4rutTNEruVsle+9EPDKf0RsqlnESe4ooJyD3qQZBgo1+ Gt1eRnBrGe64Id35RqFhIjNgeUroDx7+kGRocsobPWoonDCs9FzDKNiNEpqJEoK5VGlQrZq4+Kf 1ANNV39UumMhSktuLvFaYeAXjeDgn5ceL3WtGchzDRLIbkEhKuHrvn+PoKWQPGnnWcQG7uPH5xq j3SFVEy6JfpgAbpdwr1FHdgvOpP/3jLtNRQHVZ42v2G0mi29Z+9X5cPEDcgXYdwNsrZc1Y5hViP xYbtXvwIj1LkIIQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski As per the API contract - gpio_chip::get_direction() may fail and return a negative error number. However, we treat it as if it always returned 0 or 1. Check the return value of the callback and propagate the error number up the stack. Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 44 +++++++++++++++++++++++++++++--------------- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 679ed764cb14..5d3774dc748b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1057,8 +1057,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc,= void *data, desc->gdev =3D gdev; =20 if (gc->get_direction && gpiochip_line_is_valid(gc, desc_index)) { - assign_bit(FLAG_IS_OUT, - &desc->flags, !gc->get_direction(gc, desc_index)); + ret =3D gc->get_direction(gc, desc_index); + if (ret < 0) + goto err_cleanup_desc_srcu; + + assign_bit(FLAG_IS_OUT, &desc->flags, !ret); } else { assign_bit(FLAG_IS_OUT, &desc->flags, !gc->direction_input); @@ -2728,13 +2731,18 @@ int gpiod_direction_input_nonotify(struct gpio_desc= *desc) if (guard.gc->direction_input) { ret =3D guard.gc->direction_input(guard.gc, gpio_chip_hwgpio(desc)); - } else if (guard.gc->get_direction && - (guard.gc->get_direction(guard.gc, - gpio_chip_hwgpio(desc)) !=3D 1)) { - gpiod_warn(desc, - "%s: missing direction_input() operation and line is output\n", - __func__); - return -EIO; + } else if (guard.gc->get_direction) { + ret =3D guard.gc->get_direction(guard.gc, + gpio_chip_hwgpio(desc)); + if (ret < 0) + return ret; + + if (ret !=3D GPIO_LINE_DIRECTION_IN) { + gpiod_warn(desc, + "%s: missing direction_input() operation and line is output\n", + __func__); + return -EIO; + } } if (ret =3D=3D 0) { clear_bit(FLAG_IS_OUT, &desc->flags); @@ -2771,12 +2779,18 @@ static int gpiod_direction_output_raw_commit(struct= gpio_desc *desc, int value) gpio_chip_hwgpio(desc), val); } else { /* Check that we are in output mode if we can */ - if (guard.gc->get_direction && - guard.gc->get_direction(guard.gc, gpio_chip_hwgpio(desc))) { - gpiod_warn(desc, - "%s: missing direction_output() operation\n", - __func__); - return -EIO; + if (guard.gc->get_direction) { + ret =3D guard.gc->get_direction(guard.gc, + gpio_chip_hwgpio(desc)); + if (ret < 0) + return ret; + + if (ret !=3D GPIO_LINE_DIRECTION_OUT) { + gpiod_warn(desc, + "%s: missing direction_output() operation\n", + __func__); + return -EIO; + } } /* * If we can't actively set the direction, we are some --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC851DE4D2 for ; Mon, 10 Feb 2025 10:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184732; cv=none; b=nvVd2DXUBN+uSDE97z+lZNzGwi1kwUn1dAI9aiqh1ln/ane6l3FZPCROtv/j4QV9XzoSXaBkuLg2mCn01uy+i6Gs2E9/uXtL4tS3Gdr4FwcRSanhbbK2vAOrg8rfT5qFTT06fGSZoAoGk8lnYuxxTk40rPpwULNXyTyS/6m6s+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184732; c=relaxed/simple; bh=VEYyCI/WQWt7FUs1FcU8Tp3ZXokrKORavVAubjuZUu8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nUZu9c9MEsqb+QusgGjSTfwGaeC47AUgLk763CZ9Fqx3iICfaKPfC4PhjJQq6AAt/KKi8EJAz+HpKPKJtg7Rc6ol9ATD1aHt8DboR1lizVRWFmR75ADOuSxSLiAWwnAaag6Ch9mXIcNljP7K+gdzzq0GBBhVM2KGemMcl41ovS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=hlEyuhNk; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="hlEyuhNk" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4393f6a2c1bso5679995e9.1 for ; Mon, 10 Feb 2025 02:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184728; x=1739789528; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sO4RL0P3MsiqhqZaJGlhjjTXZ+rOkejLGclJdeKjOgk=; b=hlEyuhNkkSn+szlvX30e26u4pl5dtDJsgFq79gdyeP8LiSN8Mwy3EdQEL5FtYe5w2M kIfS9Xd5hgnIJ8Odax6F4J7LJ3CpZThBwTed0Jwx7z3/bRGORCEQDeACVuJsDzV6N6Rt Ro1PrBPv/6JYi71hi+XpZVwpDgXoT1CTmFSa6rjHX0ffR105u11wGJ0LuDkRSdDx9fCr OPjWhyxOhu86sGKd5TBpQntsZRoWLnUHdcx8Nj1alf8nPgzUYyXmyyqJLEKu75KvdhsF smCqW9OC6wJ8P8nEx6Kt3ZiXJw5WEpubNKV8fqEm2TX5yyAYC6nF7sM8Nc9TEh9EIwBm n5ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184728; x=1739789528; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sO4RL0P3MsiqhqZaJGlhjjTXZ+rOkejLGclJdeKjOgk=; b=X7hfCks8Z841RZ+ZUR08wYpWqHhaDZrjjRf2i60jRp0ViGjlYf51aJSNINHyDN68jr jrELlDszLnvt2kzpxXvS5H9A8jWfm8zzIZuxs+PE9ZEA4dCxKKvR0OiTs4kVwyT2GMIZ FkdtRzqYDDgxfnsSa0G6omiR6D6qzH5pKY4W7GbbREJHKMQwa1WKvjRzclQCl029j5j0 k4gIjKk8JX3qND9GQd8BRCg50prnUfQ6xGGcFS4S5v7EFO9L4XWJBYMSneyoBWMqLUpV Yygs5w+Nc4t9iWOUqPpro2VZGHJWocKWA244C66pcSeHMoBKwLaawhFATAiXTgnpE3cq HI+Q== X-Forwarded-Encrypted: i=1; AJvYcCXBP+l25pvNOTaLNHRokc1l60siLhwXKV9o5u3isE1uY6mWi1G3Cniv8oMomi+OwAjDddlWdUZsahTt3wk=@vger.kernel.org X-Gm-Message-State: AOJu0YzGeK7CO0Ib7PiM42JAJrjq+RxBAVkOCNLuJJ7U2SNmd6dQI5U0 SCNsGWStdNqXa4UXkSJw1tfKmoYA4M+tfJtjgKp6QTRSX3+AlJyLBM6/ikaR2d2spy3jzxr/Z+a muOQ= X-Gm-Gg: ASbGncuixKOrnspRbtK0JClWv0gGJDE6iziEpWdyMZKh6edFgFuj2/VqnQuktDKielF TcSiXBT+pwBW9RvUFXnGzvo3jnx1E7l7PG1G9zmgtS6lZCitMcVI87JQBySBX/299sk8DWrT8WA 6wXQm0ViJoUlVxospBlLhZcTn9xCzZkSltVLEt7FQEFLtivq7p4SyPsZsU7vChZ0nHgN3pZhc9U lOAvms8525dMJ+09JKzUXbChqozV++yXp6khPU1eu5Z7ebpPmf4tcRi45SS51FWB5XG5ewT7/UN be4AH40W X-Google-Smtp-Source: AGHT+IG9w8+Y2BmWt3Wy2zCugo1yyVPEoCM54U4nHTtttPaMyB9ZvLuV+Rm+5tQM3AD5nQFQQRIc0w== X-Received: by 2002:a05:600c:1e1c:b0:434:f1bd:1e40 with SMTP id 5b1f17b1804b1-439255514c0mr84862755e9.6.1739184727605; Mon, 10 Feb 2025 02:52:07 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:06 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:51:56 +0100 Subject: [PATCH 2/8] gpiolib: sanitize the return value of gpio_chip::request() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-2-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xkoYB7QevhvR3b+N2NNvGIdS2HFsaFzerPPF2/0s9uc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpSeBElLfXXQ84Z9WEjnwnVZFBwpXL6a3buq qxEtPp/EGGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUgAKCRARpy6gFHHX cttFD/9KMeATzvVcS8fkNWtmLZqCca0VOv3FIImFijcRAY1VSscZnpcKmcSFogZrPYFVPS3AwaT UmELIhw2EbSWGCN4YgmeuEcf++8V6C5MKxwU7qGmq+vPKUeySCdoc30XQuV1212EJCK2XEwDHu9 SDU5bB56HMMj0rZA43rwIUxps7o861ZL+8LPTAYakQEYQE/YhztjoYlncE7+iXlBLkfS+16eIh1 NBttreNhs0cRQS+/TfSXEBjlnMC1II6mYNCs4716Oh9jfylxLrPvdPQuwrjclzQvb9V5dHfQAtx rutAgVd/esaXieQjwPHHSGIwS8qAPQa9ZLHRE1Vsg2VfuCd9jhmjpiugDzpsZ7/LJOy1dYOuIB8 ga9X9D8Ft2x2LeBMQlTo7GYROzRXKLUjvMCrPHIsDfGXhgLOzqLCVtYHCqzMXjlWLIm7wEppYDf 1wXJg2IP4MnoCBnppWRe6wuN4UJaHMdkPJJvXLut2xzQ8Ql+uuCaIRabQdpBm0/1hYl2LTvMr5l JcOM7Z7KYcXYAI8Q/m9lDZINgILVtMZjZ00q6acCGrrGBreJ/yQofrY20Ag+MrgGQHlUhu9IX8D FN2SaOCoE4xPafKxDBKjJklp2p7UB7/YlyC87I0uLbLe81cP8LuZVRIyPxsN/t7OCY+SM8cibmv i+jiWfu5itVunew== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The return value of the request() callback may be propagated to user-space. If a bad driver returns a positive number, it may confuse user programs. Tighten the API contract and check for positive numbers returned by GPIO controllers. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 2 ++ include/linux/gpio/driver.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 5d3774dc748b..42625da7e797 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2331,6 +2331,8 @@ static int gpiod_request_commit(struct gpio_desc *des= c, const char *label) ret =3D guard.gc->request(guard.gc, offset); else ret =3D -EINVAL; + if (ret > 0) + ret =3D -EBADE; if (ret) goto out_clear_bit; } diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 2dd7cb9cc270..26fcddcb74b8 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -328,7 +328,8 @@ struct gpio_irq_chip { * @fwnode: optional fwnode providing this controller's properties * @owner: helps prevent removal of modules exporting active GPIOs * @request: optional hook for chip-specific activation, such as - * enabling module power and clock; may sleep + * enabling module power and clock; may sleep; must return 0 on success + * or negative error number on failure * @free: optional hook for chip-specific deactivation, such as * disabling module power and clock; may sleep * @get_direction: returns direction for signal "offset", 0=3Dout, 1=3Din, --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FDF21DE3CA for ; Mon, 10 Feb 2025 10:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184732; cv=none; b=mmJx/0WrmXd5VxoUukY8bCtJpOPc7yRzSIOBFDZyLFEwvk1XrJG5F9Da4pKproKBaUNv9Rilk/SXsW8JOc1KKWgjmpGjw7RHteddfmvNtwzGyT9ruxANAgwaPhdx9lptAA0ipD/ChJ4NM9uYlx/hgyQ5V8P7g+AYZKhOHilz1Nw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184732; c=relaxed/simple; bh=q+8h6LGXedGssIbDpk6doFlGaWnQknR2RXXNfrg5t/8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OtaRvAruizf+RKd9g6GlU7m9stu9P7euJPe1MPNLkN2D907zDvcZD3oDntDBgF4WkwlYXGhioNaOLR9pCteFsw01WSeagvsax5apDCpQiFkRPBcMx9iyal+hQvcB5UznYKMPD1+MNdmayGUsl0Vo7FQKlZItpeKvHbDTrAYKsCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=2Lh0H0hF; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="2Lh0H0hF" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-38dd91c313bso713046f8f.3 for ; Mon, 10 Feb 2025 02:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184728; x=1739789528; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m3TsbNFVHS/IC4iUVVEnnqOzTVBqUgDCo4J9C33YERY=; b=2Lh0H0hFqNsL+IsX4ev0uq8p3xK32oNhnIuqY0dHMMfo2xY3u0SgU9fa7W/Sgav9V+ rMYlLpM9R4ijkezIu8uRv3Lf/vl6SF5k7yc/ZIqg6GwuR9V+R3YHFm4ysqERDtQ6gBe9 y6hIfBc05kUfahH/cGv8ne42/6THsAjDEwPDAHKt4lb5p8QokzgiLrKz6MgJpQCxTqxg bn/RU7WaCqKoZoDhDwFps2P6dREovmuX+d344vx5+XsPABXmKFsz+ATRr6SBErGQklWE ogGAZD2Pqs4pbSq8u+MapS/j/Bkz1KQIIx7kHy/BQtZ7M8T8Ur4sH3mUlWsrK+cBbTN5 ZUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184728; x=1739789528; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m3TsbNFVHS/IC4iUVVEnnqOzTVBqUgDCo4J9C33YERY=; b=jj58HdfPHtwvZFSE3zgEiCejqpGOdqAIN2pFY2PFub49lAEzSok994oAjHcxZTypJE l1uhHJtj/c6eg53BlnZCT7fI8HGBdqyeGlQm4iOQnqoSqEdIFKekn7c6ESa9KhvuCvRM s/ikbEkDat9156F7ll4+WNN6FHHLo4QRbB5ObjQhx+RhL4JIHkoP8IsXPr03vL0mmOQ5 tHsBKyc1RVQavx/s7sdWzlhl73prpQxfNCpFviH8Hv5JMtME3beN4dkahnQEgCMBsCls ykEVVlpU4TvRHwz8x0ok5iQXrvj8lSTF/sflSTWRoZJLMwwEZw8vsQRpqCBQw32zh3kg 6gLg== X-Forwarded-Encrypted: i=1; AJvYcCWEOdrAc52iuozTeTXEDd+Ay2N87sG474PW583E61q8O/QB5RzErgw070ow+FIgRYFo5iqfrwpZqIXKQu4=@vger.kernel.org X-Gm-Message-State: AOJu0YznuYoaz8PwNWjWFW1/y6Wh95/R8Se5keoCgq31F7LYGvtnrJMK bpfHbxLiDgIjae+9AcpgXlN6VeZC31v+mhTshfKqFHshWA6E5nTPYGirhTvEhiwu+gF4nihYFuV DPrw= X-Gm-Gg: ASbGncsZnZ4eCuSAdGuA8N6srgtK2/l5vCfIzwE5kNL2ineZYFy2b2ZYyoaLVbIiPfD NPDeJSQ8oMGOIity/lfjj/ZpxH7wD8oBUnOGQTN23Y8Mw6PM1PkAJlcU/EzdI+kD6XQ18nQs7wY snV4m8N8WpOg64h6dfGs0lhLFHDHoUqvn7Bh+6UjUy9CikQ1XtV+9UXmV5u1OW9bwy7lIKuh61O vu2wA/fe5OrInW5pbZRPsojY4OeEvqWrntx+JCng3+pYJTStGlc9mumAzWrxcBRPQHcMviz1Zo/ lRi0fHff X-Google-Smtp-Source: AGHT+IFx774tEdrjGX+K2g7goOYqdE3lgbg6MjFHO4VWjKPEXooaMul9dyJFxepOkUugTJxkMdbmeQ== X-Received: by 2002:a05:6000:1448:b0:385:fd24:3303 with SMTP id ffacd0b85a97d-38dc8920858mr10829010f8f.0.1739184728588; Mon, 10 Feb 2025 02:52:08 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:07 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:51:57 +0100 Subject: [PATCH 3/8] gpiolib: sanitize the return value of gpio_chip::set_config() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-3-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1734; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=HDFuarshvnhtSITkzvfZTJ5ikvSyc/L6lYIYqosoVLU=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpSf217Wf1JeG6YPA/mU60jZhlxBYHM2RnXr T14M8fOvfyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUgAKCRARpy6gFHHX cj2JD/9L0JUUmq+8J51P5JZ0Rt3kj/bnafEDEzgrQ/gMTholFSRkpee9phHqoxAIAt1OoznT/mk uoWoc/iTpuUDZm2havuWGOmgrkJIuBFWMSko4N5oFTiTTRkmO/0GCFLqFXdu1uFxo3kpSIReBuk SwyZwypfcl0gu6/CB9xiec1858rYV/6dlHqIkPaPZAJjpMc49g93UEWvK9wQJgeGDF4U1UwV0Er +Oo/jNVyyqIbFyYiRMUetm06idm4R+wcPlBbJuU5kJUwAE2XYOKVIdXfGiegVcpcRQUOvuXTk+v 7rGsBk2RgVHWSQaJxWZJe/BLcIhZGKP8zb0HL+YN13Ph9YMtG1xzF1HICbHDJV+NNygAoCSjsxS cT7fCCmXo77ZyQnBpXTENmgzGzc8gn9WJWwsGd+GOoj70+nVxOCjv4QEjgnFo+3RfvvyXiYNEbR giG8wHb1JR2mhUxHuy4hD7LRgHLeQVQ7mOlPoiX8tg3oEk6M2UQ9btdzPgE3DMeBRqSnj9Am5+h FaASZH5TX81qcRHMwPNUSZiSuB3QTGL9kd1mlCH1fCD/K6ZtsveRso0PZaPkO7ikmNdC7sQeUnU RuS8Qbsvq26JW0rgI5bDBnTI4tlo3H16CgL/kuuOs3xlXD+deznNZxcFJjCa2JZFEtpAG42kahx cEzefhqzQ19HmmA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The return value of the set_config() callback may be propagated to user-space. If a bad driver returns a positive number, it may confuse user programs. Tighten the API contract and check for positive numbers returned by GPIO controllers. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 3 +++ include/linux/gpio/driver.h | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 42625da7e797..95ea300da109 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2575,6 +2575,9 @@ int gpio_do_set_config(struct gpio_desc *desc, unsign= ed long config) return -ENOTSUPP; =20 ret =3D guard.gc->set_config(guard.gc, gpio_chip_hwgpio(desc), config); + if (ret > 0) + ret =3D -EBADE; + #ifdef CONFIG_GPIO_CDEV /* * Special case - if we're setting debounce period, we need to store diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 26fcddcb74b8..81c06fc8dcda 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -348,7 +348,8 @@ struct gpio_irq_chip { * @set: assigns output value for signal "offset" * @set_multiple: assigns output values for multiple signals defined by "m= ask" * @set_config: optional hook for all kinds of settings. Uses the same - * packed config format as generic pinconf. + * packed config format as generic pinconf. Must return 0 on success and + * a negative error number on failure. * @to_irq: optional hook supporting non-static gpiod_to_irq() mappings; * implementation may not sleep * @dbg_show: optional routine to show contents in debugfs; default code --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B386D1DF251 for ; Mon, 10 Feb 2025 10:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184733; cv=none; b=a0YP3wzUTAz0tdo8xCDZATBbtv5kTMKjTFf6VXgivcVwbPnkeyDT4NqBweq19Q7zYo0z+5WvWWLk/8r/b7U4SEput5gg/dsP1eXRLlfzM/Ra7d5u3XBbyJQ+yD22Mj7mjIoGqBLYPupjETQVGUwwm0BGqi2IGqKEZSa7HxLPfEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184733; c=relaxed/simple; bh=Gx/ZBLRyHxi/oAJGICkvIOrL3DfPBNr8PZ8qnHSfnJI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XNnRoY66rd4JHL1GBh7PzdxjDXsK782N20fks5wt7VBYV3qrsJ/mRNhc6U6A1D2K+9ofT7rqo4r55mFvSA4NRQ1MeVuU82Y/Ff088Umyd7XbZwMZaKnEYaOSueKz6lukHwGNtXGdnzKZ3d3PYM4fG4btLhmrc/fIHPTHqlsXEuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Z/RujvIb; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Z/RujvIb" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38dd14c9a66so763711f8f.0 for ; Mon, 10 Feb 2025 02:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184730; x=1739789530; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t38FtLAfWg90q8K8cZGqF/lNiD/EaoI3sQrqeZGRCB0=; b=Z/RujvIbDFJ1PskZAr83IpNHwmet1cBQ/LePQl48cyJO8jrKSRMsv5YUxWsflwoPIQ WVa0j8IvfJrjEZCkursjtDBbs3FnuU2m0Ku4TzyNsNolh6TGJ7xL4ufKmza38YbqJ7QN 4QXz7bnRG3+PfEF4YR9HVdoGfKU07AssoQUCTONd8k9M2DDPIPWQTM8pZLCn3u/iNa22 pgrurZRm2RomTE6r6nv60tl0k5MLs562WqqOk8Z25TF5WeDUOFqzzmrFyz/8lS34m9Y9 FCeLnEJHDN1rcjP5z3BJ3789XgP8R/B18qCLF6JHW/l29xgRBHq5ei7i5FXVnOWn39kC lfYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184730; x=1739789530; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t38FtLAfWg90q8K8cZGqF/lNiD/EaoI3sQrqeZGRCB0=; b=nMaMqQoESR3qp5d8qWWAJKFI8RRgBVclm71Agm77UVA1pMMht9L2lxKjFF4GChUF42 W+YdF6CbCV171zin8uDrn5L2q38zDWu0/j5t2A+0svd1wIVCkw66WN3a/Fe+QdsgY0f/ 6/3vQ758e6knOa2vj3Nor1dKCZMukinlxjyYXM22S0wXkd/F36nrezdi8NFVpSoaDyZI uhQS98rDCtzK2Uj6ULTdksbFKQwcNYFxm3Q4y4qT3d8IF9AzHDjwIbXluMMABrkxQ0Sy XTXWeKVKxP3nkVq/F5AKNolP7uzQ/KaNgqcuG70YtF7K95rEqnhBgC5rOb8jB7QVIkaE XDHw== X-Forwarded-Encrypted: i=1; AJvYcCXPMn1pvysSVrQjxh01fOLFjSmZuUNqiFC46DTyekdhxQ9PVzE/vyx095AR/cGPr7t6UOXJixI7c5OQF0E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzjyi+7INO1CaNINa+pHgzgw7UWBpEMHfUqJ+90AVIo2ujNPadi QNoRpKH/dxeNK8ZIHsTIH+j/RYoLXu/WOIVpY9f1EkHERQUPdXB42V1BOqQMOjj4Gzd4qb6cGed xnGc= X-Gm-Gg: ASbGnct4tnr8bSrowGxEp2lcDrQeA8cQFeekpSSYhgFgTujvHIHELdrqfkD7EbcSlb1 O2U21IKuom0ZSBO2INf50NmJAmJVRsBBriSYEffuGD5s69QKdyQ5ZkZq+cibdf4LqR5Qy4fT1Qp CHT1X791AfZhy9Upld6O5xfNVw9mjhJnDTDJeP7+PtrSrzsIoyJLIfU/I+wr+HnAwo/OWXin5d4 EyWL+bo8uI4C3W7T2J8EF+WEuobnZSIygwhTGxRk9k6gZ39SKS4GXfCIwMsLOnWJHvrZ5yb+nEG 0rwF5jZ5 X-Google-Smtp-Source: AGHT+IF41u1Rc0MGEu0xC4rMreQdWbirY1mfHhVjlzZ3Y6T+bbpkH6lVhcVk1GsNexhAZl9QPKcjmw== X-Received: by 2002:a05:6000:402c:b0:385:d852:29ed with SMTP id ffacd0b85a97d-38dc9138a84mr8096702f8f.36.1739184729776; Mon, 10 Feb 2025 02:52:09 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:08 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:51:58 +0100 Subject: [PATCH 4/8] gpiolib: sanitize the return value of gpio_chip::get() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-4-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1494; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=9oAnPodPjMQXAB4r9yjDBYdm9AiwJTye+nOcbjeQucw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpT8Lz34Hyog+MximLfUUtQo58kNHUFpAlFi cLetkdMhFWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUwAKCRARpy6gFHHX cgUUEADCbShVCj0j1jH40nTMWKvrHuWMRwYEHR6WZi3MS6Q2v3k0bUFWz5+mLd1BQGJkldVarlu DcWAwfRb/iPEqVbG77GtNpwP7h5KD+mWjJg72KbB3TDT1WCG4o0rnP714j8bhliH+iAfNGrrrJp HXh/7axNvTZf0jQaZOXG8wMH5hS4tlP7yN3jXYz0z+mvjMJ+BuE2AAN7TRgX+y7N3EI+x3heI5w 8dSdvzTzD/KHqVyLcRH6Thrd6ozuLJ0kJCKQxNtauD+o99DXgmPvVSnfx4cMNejJu3n2Oiv06Wf GA9AZN2QO3g5LCzwXuYOEsgjfOGu/VFnMV7Xze90BaSnE9trpP2DcqrXQIzKn/Wn2Hf0/N2A+Mt H3XWCcH+PfeD3VG6LsE5KoluIp33RijuRp2OpLl65sXgj6MH6vCQopatps2ccugG218hgyGCV3Q ByPFFUjQYydPs3OBY+6Dqy/1t3j9ZGQbqD7NS1o/t8o75j6gK2P1MmHAUnf0Kb/BXoOziQhJhcM Y2C9EW3XRIq7CNRm/TsE4gMIIXX7TfczdJTeU+7UQF7MUv6zOhCI0vx+3bxP+jZIL4rQLletX6I d/djzKW9qhOTt1jhkEM1TXtE9l67kOhCNyYvF9IhkHA0bGg2Lc05F2DEoYDrwcyTRXStnmwOcvu J2GLd7vjEhj1olw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski As per the API contract, the get() callback is only allowed to return 0, 1 or a negative error number. Add a wrapper around the callback calls that filters out anything else. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 95ea300da109..7bc316154fdc 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3097,9 +3097,25 @@ void gpiod_toggle_active_low(struct gpio_desc *desc) } EXPORT_SYMBOL_GPL(gpiod_toggle_active_low); =20 +static int gpiochip_get(struct gpio_chip *gc, unsigned int offset) +{ + int ret; + + lockdep_assert_held(&gc->gpiodev->srcu); + + if (!gc->get) + return -EIO; + + ret =3D gc->get(gc, offset); + if (ret > 1) + ret =3D -EBADE; + + return ret; +} + static int gpio_chip_get_value(struct gpio_chip *gc, const struct gpio_des= c *desc) { - return gc->get ? gc->get(gc, gpio_chip_hwgpio(desc)) : -EIO; + return gpiochip_get(gc, gpio_chip_hwgpio(desc)); } =20 /* I/O calls are only valid after configuration completed; the relevant @@ -3154,7 +3170,7 @@ static int gpio_chip_get_multiple(struct gpio_chip *g= c, int i, value; =20 for_each_set_bit(i, mask, gc->ngpio) { - value =3D gc->get(gc, i); + value =3D gpiochip_get(gc, i); if (value < 0) return value; __assign_bit(i, bits, value); --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7411CEEBE for ; Mon, 10 Feb 2025 10:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184734; cv=none; b=GR0q4eFAiBOrqf8rWekkYfM6jkDu7axfdaf/SFgRl61CnbMgT54xV+vVDT5xc10OX8bd/hxsKpeTn+jnCWnk2vaROiSkAHG1HSX2p+p3WWsZqf9t/iXVRHZhGOGoJ8fNx6TJsD7TT+AWRXRNFJIvReByx5VZtpI+Twb4rQCvQpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184734; c=relaxed/simple; bh=HiD8MOfVO6NKeeMuA8BdD1R1bH1+rCekUjVkFE0Z6yA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lTjepC+RfxSrUJemb/nJAN/lVilx0M1+a9ce7frM9atI7t9pzFLcTfrlssAoOaWz8U/LPl5Z3zajajZAlflN8B0IqstKTx+YRo+pyTlbQa8N7in6R6OxCna+9s7ZcFg1fgJmZ2a0NciKEA6sZidgRVxeXavo2kuyDlV2qBczCgQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=0XCdfwVO; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="0XCdfwVO" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-439350f1a0bso9117375e9.0 for ; Mon, 10 Feb 2025 02:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184731; x=1739789531; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6P+XIrg3e48T+45SB7OV7xfhAg5zNW2nJdNfDkQWT08=; b=0XCdfwVONJ5jhKywk/IrdXsTjvFzUulwJeZAUDa5vnym9h4Fsk7Oj3jyMlcYfJOMRk sa/XNuv7B2a5KKFXBiCzZDxeBMUBaayFU+lH/AB9GG4E0CQUkB0iTSpq6ro6lPialrBi pADrnTzPxsSshmZ7mnNJtYMYcKaxTymZu9fJ4p8QJSbvgwTosE+eKQ/Lov1q0oH109nw xZDpkWFhlJpq1t7uDkUni8wCVpvmmCeKFN5V3kZ1hu0jL9MXaJEqsEsEeau9zBpoQkja ZqMX6bc9WDJdEQbmRsFdd6dwaWh0blqR9xuk6alH8lGiaIv6tkTgTmHiy2o194RvJGox OT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184731; x=1739789531; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6P+XIrg3e48T+45SB7OV7xfhAg5zNW2nJdNfDkQWT08=; b=blihcmLkC6MCMSYbAkq+EPE9Xb29B4JRvV/JwxpbJP+FinIF4NWL7Z4djMj6vsfE7h SOHZfq1QoN81snyVLJWS40otSeZnBjI3mlVwejF6M+YV48YmmxgvQTsjXC5CxyyUQKIQ HKyfcx2IbGjACAfG9HXMLGpp2VGPrkqfKynOl5o9mKT9kwMtNgdSDBM+vMgsnjXujGay XQHGbbND+TDK6syyzSZArkM3H9ldtpSj9bXZgi7eMA1kQqlzmuv1kdmI4ZAyl9MwNL4Y OHMpdPSGeysmIiOnpPkPnSrcq6AOnBwBV95RjKc/xu6JZSM4CUiwZWqTKY0lSqBSaCVB 3wzg== X-Forwarded-Encrypted: i=1; AJvYcCXbRRTRnn8ERhoPaUlLed0mwBIwXykxc6C2QmksjuQe+XxeEY7swaGgUxo35qAiHkaJqcBexJcmOLM6pDM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+qB+WfBApaw+VSOxZLfl1zn99uuMuRP/5hp/fn1xb8S+p3l0O Jc/jZ8bXJE4ysR+q6Dcro35Rci3rYF3A/AwUIHRyqfuVHtF9baaXeCh41obIqle6E44FHGIR637 8Fxc= X-Gm-Gg: ASbGncukkKpYKeOhEpJzK2u7J+hx9uyRnzGV5mXZDjhutE2zHr+l83NCy1DaQm1sNSv WSrQ9de16KgXTjkjJxo2VA80HCHUuj6z1oyaOPTijpNM4i6L7WiuwwSZPQKSGdH8SH3TcyDdquU JC0DilDiJpoeutntb/e0vGH2qzXuL0b7eDHUCE++grtaA4//dY4DS0jeGTdu7N73OseHbxVKS8h C2U6PHJHkeYMaoOSf4VwkIvN/g2HB+oPHYR/SlHkLTmQvwfObEpXhXrUyUU2WtJCzkC2EENjTBL SOxzTwRn X-Google-Smtp-Source: AGHT+IEzwSIHGoNewIvTLcEhxf/kvVRgtP5c2APQDYBcmqg0Byln/uiQ28OJCvQ+bKmommBuoCUsBg== X-Received: by 2002:a05:600c:348c:b0:434:ffb2:f9cf with SMTP id 5b1f17b1804b1-439255c10f7mr90135275e9.14.1739184731083; Mon, 10 Feb 2025 02:52:11 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:10 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:51:59 +0100 Subject: [PATCH 5/8] gpiolib: sanitize the return value of gpio_chip::get_multiple() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-5-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=923; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ooqgFTnKyGUq0xodNGxj0NJ5WHZ4siV0rPbv6X1n4l0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpTz03CtD1sSmlmUvJeBfmOF/PjBOFxKvIoT Fg3PrbKONmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUwAKCRARpy6gFHHX ckFvEACH52s6NAoQ/9TFvaFeQNcNnY9bdDsYFk5YCAehtc2TOoX8FTbmcOgWBnYOSdLNXCa9xB2 btHB15kbHII/rFCmPqGTcmLCqADxG4uGOR7vQY1kiQtQJdN4Sv0xyi2ZV7k+MZ3M+q+OtNa5yqh aeDNzr/NrRA3lo7FR+bHj+M2qC87j2tma/Ol/86klYc04X+GcXFSAfj3Ytfc2w5Scd7NI9XzymK POzvnT7Uz2usEUmRjClf70luwKH65GZ2l7nshpKsmMFQbsjXcT3noZFz4+rZQtZnGvUigEkxb/D AF9/lcpZfG7zF3TAYZcuVLzw6SWbYIMzqrzwximCZNy4cs0WRcQtHeCkMgkc9+v1S2sxYfqsZE4 UdBnNuc5wUxkjK9JAkisqdBZfzfuSaagsEo3OOlAtQEDDDtqqleMmdrLLL0Nke5PN2/T0tWKxCR HiF4hL4sYN0ZEFsqr3XG2wk+hdU/jAqUJtJ5yz5kPF5xF4vd+kH9opUE3v+A+UAv9Cj/q6atNiB uB4288uYuNG8ihkPygBRCYp4VH5tu6BdSC7mD8J5CqRscAXFmwTL8onelkGEdat3f/NSkTBX/Er Au30IbWiVEz7FQt2k4HJoUg6FHoO0BDamBgOANFiqOf1x7BtbXlC78oQkWXo0Ct8Wbk9nmAvh+K cREp2IAL7WYsr3Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski As per the API contract, the get_multiple() callback is only allowed to return 0 or a negative error number. Filter out anything else. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 7bc316154fdc..7255f4df6a8b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3164,8 +3164,13 @@ static int gpiod_get_raw_value_commit(const struct g= pio_desc *desc) static int gpio_chip_get_multiple(struct gpio_chip *gc, unsigned long *mask, unsigned long *bits) { - if (gc->get_multiple) - return gc->get_multiple(gc, mask, bits); + int ret; + + if (gc->get_multiple) { + ret =3D gc->get_multiple(gc, mask, bits); + if (ret > 0) + return -EBADE; + } if (gc->get) { int i, value; =20 --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570A91E1C26 for ; Mon, 10 Feb 2025 10:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184736; cv=none; b=JJhVHIbfMrDlD13PxJqRhteNdg4cU312n6ocydpgjfE21X3kmhrs0cG/73ZJw5ut14we2RR0I+vRuL05gkElqqyg2TuiFYfhXpQcP8r7lwSVM19yZyNAb6CmxizevpoyRd0bbZ7aMJn0AoOvQRQeSTt5d4Uostf6Ntr1cQ3/BM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184736; c=relaxed/simple; bh=V6WoqRuA4KI05FV1+v4Oy7g4HufVg8Bs8TaRncykJPI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pnLrw7/Rk6wzOOZJSzJmmbydOZwVrilPTnQ/uIFLDo81uicaFOvf/2HjLzmphR9dprxl4lSPGNmQHxe1B+NylmbIndKVwzGW15cN1/RkwTO+dN1dQ1VKAiPqBeyoyYZR8pA+4kEFrW4VSjIJdX16uqTTnr5AKocaqE9uaCc4g5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=VgIXrlWf; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="VgIXrlWf" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-38dc0cd94a6so1843415f8f.0 for ; Mon, 10 Feb 2025 02:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184732; x=1739789532; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LENKvGX4vcq9UheVuJ0AMEOpXRzUqJjB/uWgFb41XbQ=; b=VgIXrlWfT5IAZfuqHO8Tx74JYjImtjYpLJdAaL5kzcGpHR1jGE8Yw43LNgu0tiHqL7 R0tE/595Ae+JJ0ieIxU+lI867V8/wPDuQWuOu4tRBlSqOy69EjCJtYhVyGoWhyP4vqbg m+ETKwGHKmDhfbsniJ6LlHSihuhTFJXzGMEpjx0+ZtJecyHg2V/qu7DdDzgqvATXySdI 3oLKxZ5HBI/W/Yy+fGu4+SfLmgnt7j+YXirvJoldB6TDUh20oDozmKW+taVhTyaChG9Q /lP79wWkxbCATIRer8KXKepu2POP4MPT/vqpUsy0lbR7aMv0RcfWEqH+ujv0MIRg3pGG Mt9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184732; x=1739789532; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LENKvGX4vcq9UheVuJ0AMEOpXRzUqJjB/uWgFb41XbQ=; b=HJIBhDrOSZspDDKfggSvVxwB4bQIryaVjSaphwY/0zEU2SzADKf+OU+qRZ1DLmcTtW bXbijkk3ihplTRWJZl/6Sae2Une/EOKwEawqi0381DDydGibGpF+WDtsTl2P7MbhGWII 0NMW9/lNbdG3T6YnUA+pNymSHUCR7HOh38zbMsGmhC1PshNeyfyAE2DMPpqhjtVtvK/l 8sEa3IUGL5G/0H3hy1IiOUejW3yEagAAvyCgSN8FHpAmMTrZb07ZwRDCv5eFwK6VW6b5 UIjyCpLY2t9Ysl8grFec7m4b9jrJNtyIG+Gc2vdHgX6gk565qv680euoURtOS0mtksdz 9kqg== X-Forwarded-Encrypted: i=1; AJvYcCU+etHXJftJxToD9KmMoz8jBRqOoU7gFS6AQ9m2inPlo73AxT4BclzRVFwq/VMUl6XAWE7o7C0HimlSU5g=@vger.kernel.org X-Gm-Message-State: AOJu0YzO8L843vrAKNBLEyg9JLLVJbszQ3wlUpkvvnOuQnTY7+kyINaR D5JFELQjbvD0Z/J/1Efkdq+Y6qhztX3uGWuuzpx3ocEy/eb6UFX3/XH3ZxU1jtdLFTad4k1NS38 v6lE= X-Gm-Gg: ASbGnctb0+AjrudB/QsU01IUYs04wrWsNKWRircLyaHWta5WAOZJKmgKeiOqr6dHg11 8ViTLtk3xCvtvlXL14cJ51Op2qQTfvvgW8tFF31bsfdyCihpxs4MZ4TtleRjzP1rBGbRh6zSmRU Sq4ykezrWXBLJZcNIz3Y4Taca63GKtLq/8lEJDO8ur5IiFfRg9SqSLGeiZJ/q7mZuUqspQPxilF 4hoA8Ahz6PzwoMyG45n2shJvCDqLS1E1H/7Uu6di9oChTtV7xb1zL4y/eJWtO+VK6Ilms7uoEpT wCel+hdW X-Google-Smtp-Source: AGHT+IGcts0QLUB4a77mWTRAzfoRCt4VM8k7qsgfMeWESQ+XzkXt5a40ga/6FmpFrd0x0OUpy75nFQ== X-Received: by 2002:a05:6000:4012:b0:38d:e378:20f7 with SMTP id ffacd0b85a97d-38de37821c5mr46131f8f.41.1739184732183; Mon, 10 Feb 2025 02:52:12 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:11 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:52:00 +0100 Subject: [PATCH 6/8] gpiolib: sanitize the return value of gpio_chip::direction_output() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-6-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2266; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=v5PaGseLV+iX53DOub4sqpS1V3bIng/nrHtGLctVVdQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpT05VU7QlrO9fymh6SdG4wxJ+svHmCP6bdk bYTEogd8/6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUwAKCRARpy6gFHHX ciQAD/0Y/GW+31oLwGIVNlHfLMDdu64zc6BxN76j5jU+SUqFRhYTXjvnrhNEj8N6eYT83mfS0xI EUpIOfTnApVbqXF9er69IkYITWOrB7kdv8kdlk0KYSJEVVkthBYzgwHDppdNjcMRqrGzoO7/SOP Jfcjb6h1eFVONFj7XIvPRaBwMKVoZsp8f/eUHanFvdvZBnuOQkQspsyHRcZNNTI2gt3dEHi/Sr1 Ao+CAANEx8bc/t322NflWuhwEyL7hjV6juc4soB5MuAEvjL3rmri2mXfHG7Qqm0tcFmSfKMqGMY v2p7w0MH8lwpsyKh0EyUuFXx6LiB8lmTulv+5mSSBkZBOseUz2uSoNCT578EwS/GmJLGltrGCUd 12e79Jdzg/YHg1FR5PYRrj1N5/23swbeqRiQXUXI5ZXCEwHr21y6XRwvTfuX+fUbYkamZlSgJb3 R8dnGO5rJ1q7J6QARkgrZsu50cRgelpXBdxhp9Jdpvce2S5enJQK0VGDoew3c6a6Hf4FOc9wfGC vc9jIaUdd+xumNRLcl+N5ZM0elXqBSPYYGFxxmjt+bGyp+Ae1YMKthq4qkRTPsIFJGOIHPwsL8V EUrF3Flnm3EdT4yFKIcP10LQsbU3i2pgZWxugBzL7BXHOB2HtKlKmgIfcVsQCIZiW6dw2Wr+VtV cy7E2gz6ZN2Zb7Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The return value of the direction_output() callback may be propagated to user-space. As per the API contract it can only return 0 or a negative error number. Add a wrapper around the callback calls that filters out anything else. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 7255f4df6a8b..1f75ae6e208c 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2683,6 +2683,23 @@ int gpio_set_debounce_timeout(struct gpio_desc *desc= , unsigned int debounce) return ret; } =20 +static int gpiochip_direction_output(struct gpio_chip *gc, unsigned int of= fset, + int value) +{ + int ret; + + lockdep_assert_held(&gc->gpiodev->srcu); + + if (WARN_ON(!gc->direction_output)) + return -EOPNOTSUPP; + + ret =3D gc->direction_output(gc, offset, value); + if (ret > 0) + ret =3D -EBADE; + + return ret; +} + /** * gpiod_direction_input - set the GPIO direction to input * @desc: GPIO to set to input @@ -2780,8 +2797,8 @@ static int gpiod_direction_output_raw_commit(struct g= pio_desc *desc, int value) } =20 if (guard.gc->direction_output) { - ret =3D guard.gc->direction_output(guard.gc, - gpio_chip_hwgpio(desc), val); + ret =3D gpiochip_direction_output(guard.gc, + gpio_chip_hwgpio(desc), val); } else { /* Check that we are in output mode if we can */ if (guard.gc->get_direction) { @@ -3433,7 +3450,7 @@ static void gpio_set_open_drain_value_commit(struct g= pio_desc *desc, bool value) if (value) { ret =3D guard.gc->direction_input(guard.gc, offset); } else { - ret =3D guard.gc->direction_output(guard.gc, offset, 0); + ret =3D gpiochip_direction_output(guard.gc, offset, 0); if (!ret) set_bit(FLAG_IS_OUT, &desc->flags); } @@ -3458,7 +3475,7 @@ static void gpio_set_open_source_value_commit(struct = gpio_desc *desc, bool value return; =20 if (value) { - ret =3D guard.gc->direction_output(guard.gc, offset, 1); + ret =3D gpiochip_direction_output(guard.gc, offset, 1); if (!ret) set_bit(FLAG_IS_OUT, &desc->flags); } else { --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 442321E32CF for ; Mon, 10 Feb 2025 10:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184737; cv=none; b=fy0J0f/bsZZEJHNtv+osZmxtvH87ZMHTmGGIov+yf8ekDnq/ebeRbgyKMEyXvw/Grm3+nXsfOmwjXSa504hHInQDpwRM9VMio+WU06Tu2/gywqJwp+VWURGZwiBDlJBsM0BEQEyFUx+j1rvNi+zK5bRLnLiDTLk7c7lzx6rKpgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184737; c=relaxed/simple; bh=Tt49jpwzZ3ol8gmWUWuTAh+k9QZSdGkNwmYsZGaiOMY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SxJxK1/LrHksC9GSAbYCxmQn7JsvKCHV40IugPv55qRzYUhDdDigrEaP82T3HGOBK8EyCD376T+uAl1OXnOLf3pTRnMnSZCk63Gsptdjh9Y2BQ9n3g1IaMMhp+jXR7AQrGVudt+Q/hKI9ylyseHfopIKyXFatNI+li/MSyn+X6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=NtHDS7Jw; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="NtHDS7Jw" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-38dcac27bcbso1675556f8f.0 for ; Mon, 10 Feb 2025 02:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184733; x=1739789533; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H1+79In2bEjMxbwOZBK0mwGOJ1VVLwxcGp4ZvDTlgOY=; b=NtHDS7JwMrw0NbVU0WYyH+n8WEzZqx8yC3+SK3hxQDZXxmuAXH8Nrx9aYL8NGcxKAT k66EePqnotMhvvxRFeri4egfDLKS7P0QYgMsYUqTPlyBq7cWXYKY0iXFiS0RY3S1X56Q M35Yy390PdBtZwTG8TqShngd/9Nr9aBQ+SvrGq3P1YLXnMOLNdgN2oGEQgUjKDOOpLuN GdV47tZAHZM3uQ5rZ6+CKoeMo/yaGa6qQpwYi1C9Aw7zPl59z6CD5m6jW/uh2hLyjbew vkuC1XIikMDriOSzV2+lr8c6nfhnZoKx6ROSAHP646cwp4BRGTu+sXQniQ8YlFXFS8oG a9Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184733; x=1739789533; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1+79In2bEjMxbwOZBK0mwGOJ1VVLwxcGp4ZvDTlgOY=; b=HzHBgYH4LDBTf4FjiibwVW0UV8j+GqFLZ8G2fVWDnwOGyWmD9oBhn4Iuo3pWln29y4 Vqra+cEV5r5lc3DMEeWVds7a1PHyRSBDP+TqR4TKItLi/LEtvrVAkIUWIKpZTHeJpFWU 8OdHCUV/arP302sUaQf61Vhjspv18LLvrpELPZBeO1cCGgtvDk6CYHr41vUlIG22xRtA GqgipdllGWgD9joffMeoA0I+Sms6f2Dj38zsxmWpMG7V3K0tRwuORZtN0Bu4iOPAAMm4 t2MiYaoMmMLuApWLOGTfQhXGoWKyDld9hHJwH2lmA+y4G2CtL8+X8nbgGUSA24pMJTIs pqyw== X-Forwarded-Encrypted: i=1; AJvYcCUH4TfiXNn8ZQlVR+jfXOba6CIZ9aqCSxqEOV4nacPHQe/gpW99aGeM+M31CKTPWnBr/IHVDIAW8IuiW+8=@vger.kernel.org X-Gm-Message-State: AOJu0YzvDg+JVCDzK+GvmeE2AuLDCy3ROQ2dw+Pl+XG/LQq087EI9uES 12UFR/mgqbUEc8L3gx8I/WXQD0pweZ5EsMSn1tnS75mQGjvYnZ4ewZYSpa43yFdZxVeKKLPBTfb RbTI= X-Gm-Gg: ASbGncucdhHr2LyEqIkEpob8nmTRDLvawMhkkegDFu4woBD0ETQ0uzWOdFJyjomnGjM O7RZBw7Wcbcw2VZqqtWxZzYOsoedxqiVWZH6jRh+wQCotTCgpcvEszae1ZXdkUTPOT4T/zXoFNO Q4R93EjZfzbNyEpCXZ1C14GajQKwCj1YjwuDG3Zpe/+nFntI8KFyeiB14EXCJ3izmZDiBvn1Sar r1QKU/vFAwPtEcCHekhV9esXZNZIRUSlF9AE9F3y6aXyH/kjDBgJNV+qjNHsdnobi7eOhVKCzJ9 0LIQjGWU X-Google-Smtp-Source: AGHT+IEAPJaOIykPBZKf10WDEwpUc48jTfw5DdMg+WEP+fcubB4B1vmlbiOPLCgUcSlejxMiJ97MeA== X-Received: by 2002:a05:6000:402b:b0:38d:afc8:954e with SMTP id ffacd0b85a97d-38dbb251e08mr14592234f8f.11.1739184733273; Mon, 10 Feb 2025 02:52:13 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:12 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:52:01 +0100 Subject: [PATCH 7/8] gpiolib: sanitize the return value of gpio_chip::direction_input() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-7-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2283; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=LPsmymBhAWix2fPGJHIO52f9SJsvYZKGQf0Il6uLLSI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpT8oXiXz9TnBI1D2A6CzeHwMoqa/NdBW/TW 4K7Bj/U+4mJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUwAKCRARpy6gFHHX crh+EAC9LNr/MGK2bSbtPtqpnVNx1KGQ8xzgGhBILcBQg6u2n5w2cReBWOif7fVpn4TEEV3kqjZ 7HpF3DW/DbfyHCsVTtZVLhw6j8BXntb2UhDUUJSGnTBNK3vfW3MBESE72/PIuOZkCW0rVqVvPYa T+iXWydoCDKbPDpJVgzPcy0Bll2136Jeqi159psFDOrV/ggUQ2cO2IVmV+L7i9oJ+H6p4FjcPBK YJmjHcimq8oAx7mYShGy4YRQf39bssMIyjynccC/xki4cJ7uaqwfWY8umG2+NXSdQJP+k80Wp0D JmQmcsNHDVBiQbKfqnqHxUiq0x0sFDg042LghmXceMIrgVfRGSHpmfOu+aS97rCshyP6Uuk6oJ0 KX+Kw7YuBTqAumA6kH1Z4yYJgmOYoiBhC8t9wkB8aztwSlqEVWhZK/R1X/uYHOoYa4Ovz7AKLVx KmfQOEoI3/hLKRX3X7KmIw9GujO32FqOzFigBkFhYGSSfPnhDe+efIFTUgfIPujoYcKWKUEfC7z KjS1WwrlkuSSY4lzerZsU3EKKnYB8JRbuN6vYYHYvxe+yolnANFeWenny5+2Qhm7FHZE6Gxte4y iyTBXx5Q5rapDFGP+AxpxbktzdEHFaqN7+fIlirQiTYt+vpqkvkv/C+8AX57DL0+6XNcP3ViIjr xHfoFdPEJetQGRA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The return value of the direction_input() callback may be propagated to user-space. As per the API contract it can only return 0 or a negative error number. Add a wrapper around the callback calls that filters out anything else. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1f75ae6e208c..683a03d237c0 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2683,6 +2683,22 @@ int gpio_set_debounce_timeout(struct gpio_desc *desc= , unsigned int debounce) return ret; } =20 +static int gpiochip_direction_input(struct gpio_chip *gc, unsigned int off= set) +{ + int ret; + + lockdep_assert_held(&gc->gpiodev->srcu); + + if (WARN_ON(!gc->direction_input)) + return -EOPNOTSUPP; + + ret =3D gc->direction_input(gc, offset); + if (ret > 0) + ret =3D -EBADE; + + return ret; +} + static int gpiochip_direction_output(struct gpio_chip *gc, unsigned int of= fset, int value) { @@ -2751,8 +2767,8 @@ int gpiod_direction_input_nonotify(struct gpio_desc *= desc) * assume we are in input mode after this. */ if (guard.gc->direction_input) { - ret =3D guard.gc->direction_input(guard.gc, - gpio_chip_hwgpio(desc)); + ret =3D gpiochip_direction_input(guard.gc, + gpio_chip_hwgpio(desc)); } else if (guard.gc->get_direction) { ret =3D guard.gc->get_direction(guard.gc, gpio_chip_hwgpio(desc)); @@ -3448,7 +3464,7 @@ static void gpio_set_open_drain_value_commit(struct g= pio_desc *desc, bool value) return; =20 if (value) { - ret =3D guard.gc->direction_input(guard.gc, offset); + ret =3D gpiochip_direction_input(guard.gc, offset); } else { ret =3D gpiochip_direction_output(guard.gc, offset, 0); if (!ret) @@ -3479,7 +3495,7 @@ static void gpio_set_open_source_value_commit(struct = gpio_desc *desc, bool value if (!ret) set_bit(FLAG_IS_OUT, &desc->flags); } else { - ret =3D guard.gc->direction_input(guard.gc, offset); + ret =3D gpiochip_direction_input(guard.gc, offset); } trace_gpio_direction(desc_to_gpio(desc), !value, ret); if (ret < 0) --=20 2.45.2 From nobody Tue Dec 16 21:58:59 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0591E47B4 for ; Mon, 10 Feb 2025 10:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184739; cv=none; b=prIT5pAMeLJQ7y/8vhLNFAnErcARaGrS4xTNgIOzjNSHZ0IlCWBhKnTwMQMxupMKcHexLGADGjPBW2/EqFpQ0e+urfCFYYtK/m+etgm7RYhzt3zW8kdPrnr5/ei4nEUy+0dYMKj1Y0Sp2s1YtuzjHhh+0X9UFM9PbcIJk/UqgHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739184739; c=relaxed/simple; bh=COgSGy9olGzNPwhRD7Ivun1jBH1Om1X5+XQKQJmEmoc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lUXa/THukXp0PcpyooDxC54uOuxQrEZpjXdFPjtBCXPO5e3j0N7F3Q1ffNQMnRDdYAa1LSSUcGQKzeDTngBnXUvmTkvBO3mmAlLhrBENYfsJ4+qbH8hXFPJivSWwFQygwpLjHMqfpBOA0NqvAuEK9Kkex79ZKq0MXuNrQjSG5bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=nyFzsGLg; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="nyFzsGLg" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4394345e4d5so5732305e9.0 for ; Mon, 10 Feb 2025 02:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739184734; x=1739789534; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/0/sW6H/bmkXZigeRuuijEq0ngfaHSABgKK2stXVqho=; b=nyFzsGLgxQUyQzDJczAhpuVG7WCRyJpZOAsMUI4pMHFD1cUuabUett+RWYwqQ/Mdzq iHjfXwISkAAPIMCqiHZOlcoc46erkE6/yfcjyVqhNl/PKaC7dfI9wze/xc+/IpdvaTsd Bn4nw0j0DeIedCW4JgH+Go03yCgdCeEMXKpN4q70Ld5gQLdE54/rfCxKK7+aMAY8l6aW eYD/qo3LD3c0QnNyoLmeHt9SzYUwmsgCrm2DRavzCho/i5LhumLnnghVlX8XMsC/MXsq FXKVYP6HNdHIAfXxNPTxyWRaRZamSrLQEROre9kwJ0eVNeBqNGeVnsGFHk32fjUHVBZM SsKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739184734; x=1739789534; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/0/sW6H/bmkXZigeRuuijEq0ngfaHSABgKK2stXVqho=; b=ptkjNe2JCtUbcIa7ur4oQMI1LrE9BTVeKz5sT7Z0f4EDZQAD4KlS+bwoi1FOQHhrr6 Az2sqaQrngFo7YcDQDNTG7ZJfz28T7Cmc1icqk4SdY9yjQ+cpu/kjuYH/oPbm6rcdfku SC3WYb8Y+SrNoH9c4qsXZHLOQiJN8AH40SOBKoci2qjViHlpcrHIf+XdR+APZ0Dxi1Jc RzwwGxlVRyXwe1r1FwaCjKsCeJfAs7KLSJW+jjurUb2fE4c6o0o9PiUUTt17U8hjhPGV 10q5VCZabS6kxSOpZh+xJ6AqRt88ImSujm7R3ROLIMEQHG2Ku/3DjJaXloQSA79gRFUL Lhuw== X-Forwarded-Encrypted: i=1; AJvYcCXsJqQBeDF/4fUCoqg/7LGJkKJMX8plnfwdsPZdXvP+9hdMYT3wRBTfKoyqsXkcpAyVoPenJHsxqO4vaQI=@vger.kernel.org X-Gm-Message-State: AOJu0YzE9xuDtzDkGyYGUVQ31+Dt6RtbiNyuAzvcYVLdssv9URf/nc24 TNtpoNmRs4hs7Ax4GalvZ2pQo31/2hiN9el73e83CcCNwsPyN5+a3G47Y1oAbbBWflVsI/0MIvY 5QOA= X-Gm-Gg: ASbGnctUW5NdMHzkvi6WO/dNBpM7rXUoc7nZbmGVjI2Kiuh7Ou2pU7CZWXIHb1RW3+D g5AQeMSE+xkHYrkbalFju0H+PkjxwIqcyLJXgSmmT8WBHZZGYHAsiXMoAjlKqYPnogvAzlL0ukU C0s4GumA1WOFOvWAQ3t60kZcd/zDHKm7GdxXxUc800wkiYGglNeCRyuaVRUz2F3r5xM2z7PyRxC VNXIRi/JssWqCCI4cCFyaXMWTKODXJBXyZPggblmyLcRzlXmbgz53Jk4NI/t0pKq2ct7K5/FZZ7 t5CRbLuB X-Google-Smtp-Source: AGHT+IFBMafOIJZOhE6ova2QrfOmITLX2hGvdoIMAqytoVBhRb0mjwMuLoWCZbIRz9oCE1M0IxfgHA== X-Received: by 2002:a05:600c:4f90:b0:434:fd01:2e5f with SMTP id 5b1f17b1804b1-439249b2a77mr113896705e9.29.1739184734552; Mon, 10 Feb 2025 02:52:14 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3e9:47d0:94c6:777f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc53ae9c0sm10557919f8f.101.2025.02.10.02.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:52:13 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 10 Feb 2025 11:52:02 +0100 Subject: [PATCH 8/8] gpiolib: sanitize the return value of gpio_chip::get_direction() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250210-gpio-sanitize-retvals-v1-8-12ea88506cb2@linaro.org> References: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> In-Reply-To: <20250210-gpio-sanitize-retvals-v1-0-12ea88506cb2@linaro.org> To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2451; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=odzeSyQqR+d/IE3LqbI4s+DJaeStILeldUjQZftzBGo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBnqdpTAseynSVPGOyZXsIdGv+COuC2m4YKbY4VO v6aBvQju4CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ6naUwAKCRARpy6gFHHX cpIWD/9OFLX/Q3ohOtl8qp/j4xwAioTU/BcpGSOdamRbQPOjdB6zN5ZxNVr1WxMwn7lKbR7Sfv5 8oL7kx9oADBDK5Uv4i1b/JMYOqJqhWHa6wKjyYmIQiN8fmLrqViQXDVX5uxBASVRI31AlosbPyr s5wKhIc3HJKVgweR+nEilBYPLEVozG/EMl/DfQ+9oXZMzzDuTObO/2R/XntJWTJktl+A8AUo0M7 mh7rQOd2QhBCRV6rPGzcZD0oL7qtLTttzTH6u8i8cb0sW3QlQk+NyWqijkC0nKcrcXe0BzDI6Lr vPYyTsm0a/spZ4M1v/kTWgaYlGlAlTI0nVUpUzfCyQJ9Ct34BweM7gejjnqnWn+54NXh4MLAJsy A81zsE4XL7g7799J3Jlyahr5VhMALAgHZeG889f9HO5A+jhIKURQKcf+qnYcvPRxvs3tbh5c/Lp KuKy5HNOpPOzsX+n4Ai0wJUuXWRykiYKFWutj4NvlYdeU3pDqvASfqdeyTbZY/csTVt69nfgwlD A5HedZXqLIb941ECLj6oX4zoM05l6qsMIuJh0XkqEb47/wBq1YUsBWBm4d9t2+7eKwBDG4GKeoc aZj9krEwHJYCngnBWLnWiFm+VXstyosJUyaEmaw5NMZKBNHOobckgvX+TR5n16jywUIDvIoOy1q 2C0HJ6+h0+BXYkQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski As per the API contract, the get_direction() callback can only return 0, 1 or a negative error number. Add a wrapper around the callback calls that filters out anything else. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 683a03d237c0..7f2aca9f81a1 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -341,6 +341,22 @@ static int gpiochip_find_base_unlocked(u16 ngpio) } } =20 +static int gpiochip_get_direction(struct gpio_chip *gc, unsigned int offse= t) +{ + int ret; + + lockdep_assert_held(&gc->gpiodev->srcu); + + if (WARN_ON(!gc->get_direction)) + return -EOPNOTSUPP; + + ret =3D gc->get_direction(gc, offset); + if (ret > 1) + ret =3D -EBADE; + + return ret; +} + /** * gpiod_get_direction - return the current direction of a GPIO * @desc: GPIO to get the direction of @@ -381,7 +397,7 @@ int gpiod_get_direction(struct gpio_desc *desc) if (!guard.gc->get_direction) return -ENOTSUPP; =20 - ret =3D guard.gc->get_direction(guard.gc, offset); + ret =3D gpiochip_get_direction(guard.gc, offset); if (ret < 0) return ret; =20 @@ -1057,7 +1073,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, = void *data, desc->gdev =3D gdev; =20 if (gc->get_direction && gpiochip_line_is_valid(gc, desc_index)) { - ret =3D gc->get_direction(gc, desc_index); + ret =3D gpiochip_get_direction(gc, desc_index); if (ret < 0) goto err_cleanup_desc_srcu; =20 @@ -2770,8 +2786,7 @@ int gpiod_direction_input_nonotify(struct gpio_desc *= desc) ret =3D gpiochip_direction_input(guard.gc, gpio_chip_hwgpio(desc)); } else if (guard.gc->get_direction) { - ret =3D guard.gc->get_direction(guard.gc, - gpio_chip_hwgpio(desc)); + ret =3D gpiochip_get_direction(guard.gc, gpio_chip_hwgpio(desc)); if (ret < 0) return ret; =20 @@ -2818,8 +2833,8 @@ static int gpiod_direction_output_raw_commit(struct g= pio_desc *desc, int value) } else { /* Check that we are in output mode if we can */ if (guard.gc->get_direction) { - ret =3D guard.gc->get_direction(guard.gc, - gpio_chip_hwgpio(desc)); + ret =3D gpiochip_get_direction(guard.gc, + gpio_chip_hwgpio(desc)); if (ret < 0) return ret; =20 --=20 2.45.2