From nobody Sun Feb 8 23:54:14 2026 Received: from ssh247.corpemail.net (ssh247.corpemail.net [210.51.61.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3878D23C8D0 for ; Sat, 8 Feb 2025 10:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.51.61.247 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739009085; cv=none; b=kT7k2XY3YNDW0A37C9MZOAuV7KiIB1IUy1QyR4Duwrt7hQiUW4olwYAQuemKSNSrPUIwMeqJSogNCDmAkkredh2Qa9HWkgm+79bKTPZd8FH56fhnVFGJYJ1BVVXXL1TVDVpJSU6JqejJcbTE14HxxGM9Z/SqLWbQHxA6ZHqCKbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739009085; c=relaxed/simple; bh=PhL46KH19l0OPsZt5RjTxZOT9eh8M+pWgnO2NLkXWfs=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=nsYBW6atwOkN704J/hlC8WPFEPn31yFbsMm7Mhw6BiZh7gylDPpOjGrC1WzP1XMT9OM8Lh2+BhOnXGT+UJfonVFXi8NStvu1FDDSbk5XbgmPM4wPsQociSc8bO8I0jQigPqYCEt5Vwgwj59grplD9aagljxQDcUru/iPIUxN0kc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=inspur.com; spf=pass smtp.mailfrom=inspur.com; arc=none smtp.client-ip=210.51.61.247 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=inspur.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inspur.com Received: from ssh247.corpemail.net by ssh247.corpemail.net ((D)) with ASMTP (SSL) id GEM00027; Sat, 08 Feb 2025 18:03:27 +0800 Received: from jtjnmail201607.home.langchao.com (10.100.2.7) by jtjnmail201621.home.langchao.com (10.100.2.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sat, 8 Feb 2025 18:03:26 +0800 Received: from locahost.localdomain (10.94.15.112) by jtjnmail201607.home.langchao.com (10.100.2.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sat, 8 Feb 2025 18:03:26 +0800 From: Charles Han To: , , , , , , , , CC: , , , Charles Han Subject: [PATCH] drm: xlnx: zynqmp_dpsub: Add NULL check in zynqmp_audio_init Date: Sat, 8 Feb 2025 18:03:22 +0800 Message-ID: <20250208100323.11625-1-hanchunchao@inspur.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: Jtjnmail201618.home.langchao.com (10.100.2.18) To jtjnmail201607.home.langchao.com (10.100.2.7) tUid: 202520818032700b0aa2241bd3ab51cd75d7331f83a16 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Content-Type: text/plain; charset="utf-8" devm_kasprintf() can return a NULL pointer on failure,but this returned value in zynqmp_audio_init() is not checked. Add NULL check in zynqmp_audio_init(), to handle kernel NULL pointer dereference error. Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support") Signed-off-by: Charles Han Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/xlnx/zynqmp_dp_audio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c b/drivers/gpu/drm/xlnx/= zynqmp_dp_audio.c index fa5f0ace6084..f07ff4eb3a6d 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c @@ -323,12 +323,16 @@ int zynqmp_audio_init(struct zynqmp_dpsub *dpsub) =20 audio->dai_name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-dai", dev_name(dev)); + if (!audio->dai_name) + return -ENOMEM; =20 for (unsigned int i =3D 0; i < ZYNQMP_NUM_PCMS; ++i) { audio->link_names[i] =3D devm_kasprintf(dev, GFP_KERNEL, "%s-dp-%u", dev_name(dev), i); audio->pcm_names[i] =3D devm_kasprintf(dev, GFP_KERNEL, "%s-pcm-%u", dev_name(dev), i); + if (!audio->link_names[i] || !audio->pcm_names[i]) + return -ENOMEM; } =20 audio->base =3D devm_platform_ioremap_resource_byname(pdev, "aud"); --=20 2.43.0