From nobody Thu Dec 18 13:45:56 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 51E701FDA85; Thu, 6 Feb 2025 06:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738824348; cv=none; b=Acsd+BNlYp4RMmqraiS4hwGgxDvzIfUq/9ayKaP674fsiYCFdl7B6V2HgKdRQDxKhofvP5Ob5l7l4Av1vIDA0sXS0UT+mi15jI37YVgzcrsDMYb3hJF58vr5FOdorih5XDyuvdjvY2GWwHELqSAxPr/Aiiy7ydchcss9e28WRkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738824348; c=relaxed/simple; bh=5uskMgIsKSwAStIqZNp9YwUssuPirQ8Sfb04pO01u/I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IizAseAENELW/E3RH/KUaBxNFUHN65pkDTQ623NbXB/ItZ6VzLXy5UwHTQeTFbBhYH+4o7NY0Q3/GRq+Rcjl4JGJ/vBwRVx87AZXiy21xVolA2YCfJSNSzcH9Fd2wtJpg/DwkAwLmqIPM9Pp4ntSBZ6+3wHmeJ/TrsWoQDIwAsg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=CP3z5NKm; arc=none smtp.client-ip=220.197.31.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="CP3z5NKm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=RBIBi lYDxeWRgNlHC/vhx3XpCGxCxrSjnVrypHsJqyM=; b=CP3z5NKm+rRTGoKowWqvq V1rp3Cal7VMwUJaGm8awwygrQXBvO80MO7qap1ZOagWZeDkTIm9M/EHVZSjHYkSu 4EfmeReuKH06P+jT5Go0+mkOMgPoJ/8ZHYQKHGaqi0Mq0j9PqGQB1sroCrf01HGR 9r9wcmB/pJzSIXUGlG9avk= Received: from ProDesk.. (unknown []) by gzga-smtp-mtada-g1-0 (Coremail) with SMTP id _____wD3fyNsWqRnb3bDKQ--.52146S7; Thu, 06 Feb 2025 14:45:09 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, krzk+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, detlev.casanova@collabora.com, daniel@fooishbar.org, robh@kernel.org, sebastian.reichel@collabora.com, Andy Yan , Michael Riesch Subject: [PATCH v13 05/13] drm/rockchip: vop2: Support for different layer select configuration between VPs Date: Thu, 6 Feb 2025 14:44:33 +0800 Message-ID: <20250206064457.11396-6-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206064457.11396-1-andyshrk@163.com> References: <20250206064457.11396-1-andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3fyNsWqRnb3bDKQ--.52146S7 X-Coremail-Antispam: 1Uf129KBjvJXoWxtrW8JF4UZF47CF4UWFy8Zrb_yoWfJw4Upa yUursIg3W5Cr45tryUJayrZr4rGwn8tay3uan3Kw1xGFn5KrWDJF4ktF95A3Z8KF93ZryU Xw1YgryDZrW7tFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jx0eQUUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/1tbiqQrrXmekUdSn4wAAsU Content-Type: text/plain; charset="utf-8" From: Andy Yan In the upcoming VOP for rk3576, every VP has it's own LAYER_SEL register, and the configuration value of each VP for the same window maybe different, so extend the layer_sel_id to array, let it can descption the layer select configuration value for different VP. Signed-off-by: Andy Yan Tested-by: Michael Riesch # on RK3568 Tested-by: Detlev Casanova --- (no changes since v4) Changes in v4: - Typo fix: selet->select drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 4 +-- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 38 ++++++++++---------- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.h index 7cdef4c98bf6..37cdf0ed9455 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.h @@ -166,9 +166,9 @@ struct vop2_win_data { const unsigned int supported_rotations; =20 /** - * @layer_sel_id: defined by register OVERLAY_LAYER_SEL of VOP2 + * @layer_sel_id: defined by register OVERLAY_LAYER_SEL or PORTn_LAYER_SEL */ - unsigned int layer_sel_id; + unsigned int layer_sel_id[ROCKCHIP_MAX_CRTC]; uint64_t feature; =20 uint8_t axi_bus_id; diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm= /rockchip/rockchip_vop2_reg.c index 9e42251ee796..8160f76de995 100644 --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c @@ -350,7 +350,8 @@ static const struct vop2_win_data rk3568_vop_win_data[]= =3D { .formats =3D formats_smart, .nformats =3D ARRAY_SIZE(formats_smart), .format_modifiers =3D format_modifiers, - .layer_sel_id =3D 3, + /* 0xf means this layer can't attached to this VP */ + .layer_sel_id =3D { 3, 3, 3, 0xf }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, .max_upscale_factor =3D 8, @@ -363,7 +364,7 @@ static const struct vop2_win_data rk3568_vop_win_data[]= =3D { .nformats =3D ARRAY_SIZE(formats_smart), .format_modifiers =3D format_modifiers, .base =3D 0x1e00, - .layer_sel_id =3D 7, + .layer_sel_id =3D { 7, 7, 7, 0xf }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, .max_upscale_factor =3D 8, @@ -376,7 +377,7 @@ static const struct vop2_win_data rk3568_vop_win_data[]= =3D { .nformats =3D ARRAY_SIZE(formats_rk356x_esmart), .format_modifiers =3D format_modifiers, .base =3D 0x1a00, - .layer_sel_id =3D 6, + .layer_sel_id =3D { 6, 6, 6, 0xf }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, .max_upscale_factor =3D 8, @@ -389,7 +390,7 @@ static const struct vop2_win_data rk3568_vop_win_data[]= =3D { .nformats =3D ARRAY_SIZE(formats_rk356x_esmart), .format_modifiers =3D format_modifiers, .base =3D 0x1800, - .layer_sel_id =3D 2, + .layer_sel_id =3D { 2, 2, 2, 0xf }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, .max_upscale_factor =3D 8, @@ -402,7 +403,7 @@ static const struct vop2_win_data rk3568_vop_win_data[]= =3D { .formats =3D formats_cluster, .nformats =3D ARRAY_SIZE(formats_cluster), .format_modifiers =3D format_modifiers_afbc, - .layer_sel_id =3D 0, + .layer_sel_id =3D { 0, 0, 0, 0xf }, .supported_rotations =3D DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y, .max_upscale_factor =3D 4, @@ -417,7 +418,7 @@ static const struct vop2_win_data rk3568_vop_win_data[]= =3D { .formats =3D formats_cluster, .nformats =3D ARRAY_SIZE(formats_cluster), .format_modifiers =3D format_modifiers_afbc, - .layer_sel_id =3D 1, + .layer_sel_id =3D { 1, 1, 1, 0xf }, .supported_rotations =3D DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_OVERLAY, @@ -582,7 +583,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .formats =3D formats_cluster, .nformats =3D ARRAY_SIZE(formats_cluster), .format_modifiers =3D format_modifiers_afbc, - .layer_sel_id =3D 0, + .layer_sel_id =3D { 0, 0, 0, 0 }, .supported_rotations =3D DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y, .axi_bus_id =3D 0, @@ -600,7 +601,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .formats =3D formats_cluster, .nformats =3D ARRAY_SIZE(formats_cluster), .format_modifiers =3D format_modifiers_afbc, - .layer_sel_id =3D 1, + .layer_sel_id =3D { 1, 1, 1, 1 }, .supported_rotations =3D DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, @@ -618,7 +619,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .formats =3D formats_cluster, .nformats =3D ARRAY_SIZE(formats_cluster), .format_modifiers =3D format_modifiers_afbc, - .layer_sel_id =3D 4, + .layer_sel_id =3D { 4, 4, 4, 4 }, .supported_rotations =3D DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, @@ -636,7 +637,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .formats =3D formats_cluster, .nformats =3D ARRAY_SIZE(formats_cluster), .format_modifiers =3D format_modifiers_afbc, - .layer_sel_id =3D 5, + .layer_sel_id =3D { 5, 5, 5, 5 }, .supported_rotations =3D DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_PRIMARY, @@ -654,7 +655,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .nformats =3D ARRAY_SIZE(formats_esmart), .format_modifiers =3D format_modifiers, .base =3D 0x1800, - .layer_sel_id =3D 2, + .layer_sel_id =3D { 2, 2, 2, 2 }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_OVERLAY, .axi_bus_id =3D 0, @@ -670,7 +671,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .nformats =3D ARRAY_SIZE(formats_esmart), .format_modifiers =3D format_modifiers, .base =3D 0x1a00, - .layer_sel_id =3D 3, + .layer_sel_id =3D { 3, 3, 3, 3 }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_OVERLAY, .axi_bus_id =3D 0, @@ -686,7 +687,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .formats =3D formats_esmart, .nformats =3D ARRAY_SIZE(formats_esmart), .format_modifiers =3D format_modifiers, - .layer_sel_id =3D 6, + .layer_sel_id =3D { 6, 6, 6, 6 }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_OVERLAY, .axi_bus_id =3D 1, @@ -702,7 +703,7 @@ static const struct vop2_win_data rk3588_vop_win_data[]= =3D { .nformats =3D ARRAY_SIZE(formats_esmart), .format_modifiers =3D format_modifiers, .base =3D 0x1e00, - .layer_sel_id =3D 7, + .layer_sel_id =3D { 7, 7, 7, 7 }, .supported_rotations =3D DRM_MODE_REFLECT_Y, .type =3D DRM_PLANE_TYPE_OVERLAY, .axi_bus_id =3D 1, @@ -1454,7 +1455,7 @@ static void rk3568_vop2_setup_layer_mixer(struct vop2= _video_port *vp) */ for (old_layer_id =3D 0; old_layer_id < vop2->data->win_size; old_layer_= id++) { layer_sel_id =3D (layer_sel >> (4 * old_layer_id)) & 0xf; - if (layer_sel_id =3D=3D win->data->layer_sel_id) + if (layer_sel_id =3D=3D win->data->layer_sel_id[vp->id]) break; } =20 @@ -1464,7 +1465,7 @@ static void rk3568_vop2_setup_layer_mixer(struct vop2= _video_port *vp) for (i =3D 0; i < vop2->data->win_size; i++) { old_win =3D &vop2->win[i]; layer_sel_id =3D (layer_sel >> (4 * layer_id)) & 0xf; - if (layer_sel_id =3D=3D old_win->data->layer_sel_id) + if (layer_sel_id =3D=3D old_win->data->layer_sel_id[vp->id]) break; } =20 @@ -1512,13 +1513,14 @@ static void rk3568_vop2_setup_layer_mixer(struct vo= p2_video_port *vp) } =20 layer_sel &=3D ~RK3568_OVL_LAYER_SEL__LAYER(layer_id, 0x7); - layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(layer_id, win->data->layer_se= l_id); + layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(layer_id, win->data->layer_se= l_id[vp->id]); /* * When we bind a window from layerM to layerN, we also need to move the= old * window on layerN to layerM to avoid one window selected by two or mor= e layers. */ layer_sel &=3D ~RK3568_OVL_LAYER_SEL__LAYER(old_layer_id, 0x7); - layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(old_layer_id, old_win->data->= layer_sel_id); + layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(old_layer_id, + old_win->data->layer_sel_id[vp->id]); } =20 vop2_writel(vop2, RK3568_OVL_LAYER_SEL, layer_sel); --=20 2.34.1