From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D43E22FF5D for ; Thu, 6 Feb 2025 22:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882106; cv=none; b=Qv7nwbUAfQT4EDf7IkDsziIcIdmWJeeB70vrxCUQemhVnzqkKlZ3DYS2MYALJSy+NyNU18cvDj+Sb4PIO3TV7Uas9Yd4zxtH8s14hwOE6DIpp/Zp1QG9U9Yj3oFJPK/c79eAwaAooj35QDYcJvqCvlNks50ixeLdW2BGKI18eN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882106; c=relaxed/simple; bh=P5NoUCJg7G5qsRzfSkKNlCbJJziL6lLPrb5ko7sGuBM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CLAg2YE1LcogReEeeDJGEE44dbrHcaNWUq2u5O3iBFA+x0f3aOCKEjHeFnLeahnVebtOEEJlDAY1nGXqx8YX+degirh/hGMyJqo8equCWzoiSI5MMan514zBA/jHGm8edK9Jp/Q5dntIA4oe++cda1ecm9kATtQ12RxTWgaG1Mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=qRqu9P+K; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="qRqu9P+K" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-71fbb0d035dso905090a34.2 for ; Thu, 06 Feb 2025 14:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882102; x=1739486902; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kXql2LNKpg2iJS7/BXdVqEWK4gXiK1Iis7jUGxkm/8M=; b=qRqu9P+KKhJbgbm37JwvIZaxVM3wMe5XOKFyQ8SedXc2dh73bjTbZuIJjplQyFQ2Xc xtLcVaeY4quREaEpy3a9QYzVV5y0KJCVUoZHvwrfgJBZlAKVuyzIa9sqZ930jAcTcSMq ruf1yRKFyBxMFCVfHZLIpHFdykj37N2X7z9R9VaqJ8VJMNzg6/SDgY6LdCim1kJUYOr2 QF46YNItU38/81p4v748JYa9ir/KFX9dvfT/kHhRAXPaIB0coVzMFESFTHosPIiKbAPq nGUGkNxXBrsr4hl8IZ+V2058ZqJahSjXlaf/sYp+8gI8GsvGUt8PBgPjdFCJKgeGk7aU v7Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882102; x=1739486902; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kXql2LNKpg2iJS7/BXdVqEWK4gXiK1Iis7jUGxkm/8M=; b=t+P1S/LK9QJoguaPUJfmXQH3Q8Y7DRQXuB28QLdK+TpLuGUntvC38LCKGy2ENVv/GK ZQld4fGaH0XNPNcNEg+u2/gKmVKGt5aFhVSHGXqLFFfo2Gjy5mPcAC8+G6NKFO4+c1SX fjEVdV9A9F4rEE5QNdWaS0cXfb1w+3JsiBYaAKwJHCUEjUEcxrIT8uK/oTJjdBRonp35 KgJ+g/gDHzBrnJufQeWWOwiLgbGEkAos4IBgBoHscYj47/y9Jm7SQpfCUTJM1z94ONHZ 53LtyqAaZsus6Fju55Y7toQkaAYnLE6mIxmIQHl0coKMB4y+m1hpfgxKTTm1ds1m/JlC 2hPw== X-Forwarded-Encrypted: i=1; AJvYcCXSUcbZdrpeTqIylIW/alrQPjAPyYc3/lBQMbl64WJxC6RbkRy9MLIKZUbKDPXQ1iqS+NRAVNcVat9pkgc=@vger.kernel.org X-Gm-Message-State: AOJu0YwSoKnf5wDDqKf7ZS7crqCVaVmCJK2+OZ5k+UceNgRZnvDRJufB sW7znt8OZiML0NHZ1qhbk21Fxj76/gqO9cYprBGZSCerZJMS5koyDSCNjApcIAs= X-Gm-Gg: ASbGncsNaNA9waarXPhRfna8Y7Gr1SPglUP+Rnq/FqLc6BdniN3SdckGmB7usZ+/sFI QReLiIgHHrUx30Sm9mA4iRykoA9IkbYAdzm0X7pqKDJvnx68EBzPA1KQr7xv4DtwDf/3Yy2hsH5 lbV0ShTo8O8QZYQE94qRkISbyYnqWqxbZf583JyqDaNfAn4tSCQ8DitDOuxaRH55XtsuVNUmoEL Cg79Pp7hawnVUj4Xe37drtJjoivkqX5yUqBszXMOCumhhh9cg//Wpc8UHPkuExHO67IVCNBac60 0lFwrYaMspQ3JTEEEnF7BIIn6WdMdxrVEJsxG2mH59NHigU= X-Google-Smtp-Source: AGHT+IFiFjinAKAnXyIV7RGC3+Xe5Ny6G8kVNZ77hCnDk++KNDJly3JOvlipHi0kVubWlIsfK4Ezzw== X-Received: by 2002:a05:6830:6e0b:b0:71e:5a:f4f4 with SMTP id 46e09a7af769-726b88b89cemr713244a34.25.1738882102556; Thu, 06 Feb 2025 14:48:22 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:22 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:15 -0600 Subject: [PATCH v2 01/13] gpiolib: add gpiod_multi_set_value_cansleep() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-1-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a new gpiod_multi_set_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- include/linux/gpio/consumer.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..278a197a9deba11dadbff0b5850= 7df91be658f34 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -655,4 +655,11 @@ static inline void gpiod_unexport(struct gpio_desc *de= sc) =20 #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ =20 +static inline int gpiod_multi_set_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5E4239086 for ; Thu, 6 Feb 2025 22:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882108; cv=none; b=RpyqZ/JOQT/3Byc9wWGd/IeoVdvpNzcKTiEyK3+Jt/6+lb9kcawQRw/jnwZi3eNgHx7c7V10BecxptNuUCtf+5Sm0gRs+O9QUN3jZr3fFSiPQYRpJ5TRUaEjwnoDEwC1gLAmuqsj+2faualkq2j0XNN078POHBaIMpbFBxvdPwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882108; c=relaxed/simple; bh=BsYr8xPzy7+Clg3NB+2+t+eBy6Bnh8Cl10byN7syoc8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P1qPdktSINo2gUFFEO48EnZmdaFptsI0U0c/RH13PDHDpQvfCDa2VS7qgrm7EZjZYcsDAuiN79G/CwGSTf+ezjhpKsA6OxiAjBV/4HVVpK+3ABM6/7iWW8uw4gfXUZqq+9aCfozQaE+7Gu8OkjgAhT6zDWL3rCnPQYV1APg/wgc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FigD2OPo; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FigD2OPo" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-71e22b2387cso1145370a34.3 for ; Thu, 06 Feb 2025 14:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882104; x=1739486904; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GH3NKtPpRHESHp33nulC7OX1rB6L2Ayb/Aiy8rtkYPA=; b=FigD2OPo/EIvsE6z27uxyPhfFzqcY5jizhT1/mV0w7nlj//SVqEShe0y7JHpCEjYV8 Wo8WmclDkzxDFolPLke61nLi8IXFYAs3wbp+lxOIuCU+imc6DomBUZ97OlD0WKqmRWyF Ya6hAt01fKLpj/Z4nEjtE5ZqYXsqMfERWdgziQvNx5sOQ2+TxCYiwru3ljzKaJtCMZ04 0nb/kzqvacxwNK0aTjnxhO0Ht1C0JYHcH83D0o0Nq+aq9Bf3eyUiTBZQYcZrM0QAkqvo 5tPjxemt6x22Rz47n4Go5gqpfoOU5IGSuHeZXZ7Cqi1jb1pK3AleZKB7HI3a+3xS6xlD /6FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882104; x=1739486904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GH3NKtPpRHESHp33nulC7OX1rB6L2Ayb/Aiy8rtkYPA=; b=cAjfqkQ/ynrqCQgSDdbYmxMpbE+BpZHqwo/gbQB4k5JhFH7j7Ycn8YI63BguCQ13Jv vzTbbnbLori4jTIYc2XmBAxb4bckVzxhfKzBysziGBZLXF+cJAHE9f85W+LpUr1Mm7lq oJDazGj8O4ePM8Dcymf4pDKCqmNrDifuhHfDq1yqLQOSoMOOw279J7g1NJW/baOEKTGq qeeYvpc/Pe97cjQifuALdHbuBZNzJTs23PApKVb7vcrOxfk1d+Sy1sIP2xwRrmoXM1QN 4pHwVmoyyGwwf7w8cMGxm1/o9E3nOrkgOdJ/hnkraKu0E3uHCdT6Uux7nivDhB3B2Jul GGTw== X-Forwarded-Encrypted: i=1; AJvYcCViElOOZMpJlfIUK9jH3ZPOg0Ryb6tw5/3LKNrniOkGKVHxHs7UNALuCUG0c3NwkFM5cBViYeNvsebWax4=@vger.kernel.org X-Gm-Message-State: AOJu0YxXLknTGl8mdW/t5N62fiG/7U17lqYy+J0Kj4WCuveRyYMNUHvh Or9QW7rQWQf8G1lZvKvrEPeIn9C5ICC9OzCYShSWsRnpgE64BmIomW9VSrEomEI= X-Gm-Gg: ASbGnctVTTqO0b7wpLHMVP83zzjPY/3hMa+L5b1o80Cu7XRZ9iG5hapepNC0cJ0t1b9 Vq4N3Yg+o8g1gJVnJZTA5tHJ/OEWCqimqJZpBM4BoV2X5z2NJCigkGI0xAeB8kC0kjZT4T2Hv/E PTfrAExaMfmu/96HUPa53qtldTeAX2TJ0Il0xMWx9ZKIwuwgOHEgaogtwHH8XPbYDahm9MlkZiV Owo/fWeaQPHt+5s1E0WDecE1kZurmA8DThzkWumiogbTfVzXV6+VnrrJWxsCcP1HEwL5EvWNGjB yExHi3R7YfqPmrjOjz7UN8mGliqulDo+i2paF085RQYCXns= X-Google-Smtp-Source: AGHT+IHCjAZ/4mXxk1VXEbjQMmNTdXsRhhKdUtPACGbfwSRhNyt4nhKE9d5n5z8psMK5DgXY9qctNA== X-Received: by 2002:a05:6830:6c18:b0:71d:fb64:b601 with SMTP id 46e09a7af769-726b88c7282mr749926a34.27.1738882104636; Thu, 06 Feb 2025 14:48:24 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:24 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:16 -0600 Subject: [PATCH v2 02/13] auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-2-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Andy Shevchenko Reviewed-by: Linus Walleij Signed-off-by: David Lechner Reviewed-by: Geert Uytterhoeven --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led= -gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..dfb62e9ce9b407fe356c3a7d2d2= 5319b91a11a75 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) =20 bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), = 0); =20 - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment= _gpios->desc, - priv->segment_gpios->info, values); + gpiod_multi_set_value_cansleep(priv->segment_gpios, values); } =20 static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D728B23AE65 for ; Thu, 6 Feb 2025 22:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882108; cv=none; b=o+yzTJr0xqF7e0LzA89FRHgQVOyKhIWd6tAlbIAKaKKCLLwgCYZl/Ecvkcpo8tXwbFoAemY+Fw1RF/mYWSDwe5HfCvHvY/MmFxoTbm1stReiU/8vS0mR6u154CoBIOOrZg92ZAF7KKmFyrJ2luUxAYIcwdu4vYlAiIwIYQCwiUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882108; c=relaxed/simple; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KNsFFl4rdRBbzvjY7Ilfl67l8/MUd0La3uucdcsYPWAa3Q0efpAPw3U2Yqr+ABJ0qHvuz98i2FENbqMt9ScKYuiiF+W3yVNkQg6c3fo1XJwejNvRdd3G184MuM556JFUo57qIL+P0gA3XitBD6x9XCvfFgXn9TBQS1PS5y+ZGsI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=XdCajTEC; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="XdCajTEC" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-71e287897ceso1142119a34.0 for ; Thu, 06 Feb 2025 14:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882106; x=1739486906; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=XdCajTEC8miI59hIeNRWVqWyNKU0u/Pjm/gav4xIFSMuoO1mAKR6GN+q/DZ19uychX eIfu/ZSWQiT6qbbOk/9cp9BFlogm+o+4V5KyzwvRpRT09tAs5OUbblKy/AEd91PgNvbC zhkFCD8mZDF0PeoIA60IIHGpbisaDClqAd8H6NSGOWzAUvA/94mprp78uiuo3pEWE4lP B1pdVApYG4oRuTkSSPJU1hDsRqKzSLCD5SSGbWQpzhQRTffb3SVcjpqTYoJ9PF7V8hOF BHNufqWFqn04YSOkLa7WXqb8qtZBANCf4yCxwx0diDLosT5iVlSAoPrpRGWYWubdkTzP hjgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882106; x=1739486906; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=I+3jacOBKmFGXLwKfZ9Accj+j7yOWXlQOK5Yx3mWFPempxliyhpg6hygjJnd4cNTh9 pSxtdTX5J6TV4sycNZovamuRd5gW873bxAkTRwGp5I5QzagrZukexqFEAjgg0ABjea2f CPHupNLxOTELJTFuZkbNT16AOMGS0XuNo7dVA223RW71EYP76fQRzbSanoaLcqM8zXmU QtRzyN7jWVObdW8RaJlCXhtrdYjHLEhX1BTe7sOloUngQ8ZVCWv8QxqGrmmaYcZTP4IP LjmV3fqYW8SewXu+k3fgstfNA+ocqT8YicmW83opNHgx5DuPMU7696Hffya4zt4JXaWT Rmag== X-Forwarded-Encrypted: i=1; AJvYcCUMBUMNNCXvcBhTBUkJt8EEn/p6bBE9FLu1NBvt3vcezy8CBe8PuFQvMhiRbYLjaoFSEKXhH21Ps0Z+joo=@vger.kernel.org X-Gm-Message-State: AOJu0YxG2DwvlTzHJ1eGDR+kQeA0Yfa3pdYG8FgM0inRxaWXWaLXdgTR RewzC0rmJ5oWnxRDicvtmh4BhxgJBFNZ4GP+7Sjlro8/BXzz8J6OKajr9HH1VM0= X-Gm-Gg: ASbGncvN9+t/7jVRUoL4iSOtxSkn+1vgOALF2pM8Q2puEWAY0csUG6rV1+Mw1kK6WlD 0rszTjYLZCajRhq67F4zgXACj4SWYTOMzqWCTzQCQCHMMxMeQnmOFfZx/i5A4kJCeHkoD6bZuTx AwaKUG+ilVxsEllPO53qvdkC1ggzzWKZVolYUVNwVcLL08ItyMxMYQBKQJJv6Edt77jwLGh0Q/l Ln0jpyFFfvZyBJ0SJzbNJaE+Mot6EVxwiK/KdslrVf5Frj+kO/WITrjCAsYP5YvrzUXogEuzTo0 cE2Q0+klGALIY313OF4ydpZEUJmiuntxOA5AzARUqIzhCOU= X-Google-Smtp-Source: AGHT+IGju4AgrFHpgx+WkS4zNBcn38CgmaIyeMDkbsnAb4rmy84NG+uCyuhvFXnSaOB2zZt+BWiqyg== X-Received: by 2002:a05:6830:6e03:b0:71d:63fc:2ea6 with SMTP id 46e09a7af769-726b87db6c0mr918380a34.8.1738882105791; Thu, 06 Feb 2025 14:48:25 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:25 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:17 -0600 Subject: [PATCH v2 03/13] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-3-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298= 821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pd= ev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); =20 + if (ts_nbus->data->ndescs !=3D 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn =3D devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EFB246324 for ; Thu, 6 Feb 2025 22:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882112; cv=none; b=cj75CjNlGsEeN5UACaN3+Hco34NG0V2NItL9WeriaWhdpOtWuYIA/ohQ1ShGIQl7GJXg8xU++Sz25vaLCkQBtQykuqd8dglINebrXJ7kxb3SeSfUG3fWlDKBTi3pyfUzluiPnFMngE6RPHOxWF9yViYvmKKK1ZpdTNhDht9rAT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882112; c=relaxed/simple; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jT6bNVo2/vU7p876ldudeICNiSHaY43v6ShTKuB3Sqzlvfhmc6hsnhFMJ91rETDn4mO7XddcHC3kbEAsqG+OYV0Wc9Evdpy74Q+ThUSm2cC4B+QanTJfc7X+43ZAY1ehRI2iJ8EafMvNrfSCFMXbzhP+Dg0ZCS/4uU5RzxdgOo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vXsnwKxu; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vXsnwKxu" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3eba559611aso410796b6e.0 for ; Thu, 06 Feb 2025 14:48:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882108; x=1739486908; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=vXsnwKxuC71ZpjX0nbYzQvtqVo6OCEuNOXds+okgver7+eVdKXmmAWRZ54Thz+OlOv NuhCFxG1N01NsmMhVGyZpKW/y7TYPrahCu2+KpHU1wIFjLmeMweXSt2xh5hQ8PA5uwas lLw6la+v7QrTwYGmAEGIBRkIhjC+XJCb0A3aFKtH/aHHHqkb+CJ1jjM+LixP6ENvMH+x NIoHa+hlCWZxQBqKg/uZ5cYFgAVOuDWCpioO7yN4y83nOjgVt00GP6uyFJrhO/A1QVAd +Wo85rhB/AZSM5Sz/u89qYKqyITVswuV/ShwQ9dodVE1GHEFTtRaEB9AkSPiqZ6hsry0 pc0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882108; x=1739486908; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=HBe89Kmwi0wbXbpE2uc7lrvZxjdWvtPXJQIF72G5U/dHXZl+rSCdUN1LR+6IZvasus y1Qcawh791tP0/SOAEEzT2yYSVTrGoPrbilQMo3QFn0pOLG3ihmhf7GnXcBuWZYVqQLx vU+mwLiI8F8mKONbhGA34XviOiQlt56zPQ5JLCWEzKuyMgTp/w1tV54yDVYtqhwu5VIe zgNNIANLPK7iSJ1RUUvEzOcBUEcgI7P0VdDAtbv5Z3bQRirncDWTagPL/NzyuI2WIpXr A4vpq+kUIAz63FY6CIVKkiYzq0ozerlKd/LbbnI9hFHTvableGq+HClp9E2zZlDTGueJ L0+A== X-Forwarded-Encrypted: i=1; AJvYcCXe4PUZhh1oXyKq/A2kMjO0wtyjpQSU1Zd4Z2+P5W9bQ3t1bsJMvYOxmLw9FnFMGJtu7oy6xnbADKfihRM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8INbuJ9ZEcppMNqF/y3igDk+U9BNZdpRZsRlyJLZzK/B26+lF 6nmCR9wjJIPdCDco5dCY/B9ylANdorU88Dd+/zNyD2KS3RFSlzNoMo7jL//33Do= X-Gm-Gg: ASbGncu2NGeLBPx5nGNudQ3D75TRDRcTYYO1l+tCS9Rby7pip2tYNo3ERjwEyu+KA9n Z4bZ6hsIUBhL/CKCgDwLjbjqNOVtMc8HvunpBWvThI9dNc1oiwYg19A07x55k3jU8MHKoRPu5tq DUSO24bd9ng1BtGx+MIInBGwQQw0qVYW3ED34eOi6TZkSGVkjsEg4vJsAFWNY0hJDVO35VYienw ywb366STlLx5P6r9h/H18OkfW+Jkzx75u05jlH4LZhcwSJU7YqWPfNpwQp6H3ziU2LD3JzApy9Q Bv1uE1cs0dsIzCF32wPnyVo+pE7L3pHeTyNxj42+1a/ouLU= X-Google-Smtp-Source: AGHT+IHR3rdzOh31Bx2HFTQsJV0ppIelp4NfQddbrynjHIrf2JbNfAwcWx67zk6KGYi6B0FrKmfqwA== X-Received: by 2002:a05:6808:189d:b0:3e6:3a82:f790 with SMTP id 5614622812f47-3f3922a086amr707666b6e.6.1738882106950; Thu, 06 Feb 2025 14:48:26 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:26 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:18 -0600 Subject: [PATCH v2 04/13] bus: ts-nbus: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-4-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527= fffce77784af2 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) =20 values[0] =3D 0; =20 - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus,= u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios =3D ts_nbus->data; DECLARE_BITMAP(values, 8); =20 values[0] =3D byte; =20 - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); } =20 /* --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3812451EF for ; Thu, 6 Feb 2025 22:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882111; cv=none; b=jL61bBCA8IHn98Ywe11n2PfHdCL2SZi9YQkoDxcusLmoxDP1lvAo/4NwvoLL+2OvpdKS7A/dBjqf7H4S4CgoqccGJWlhOJ6XOQqY0zrYupMFwn1GDVEicSMBAE3PHuMFGKuWJR1rnk68BHh3XSTbO3dFWXLxMM+lxo+25rk9MCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882111; c=relaxed/simple; bh=0MHJjqUwgl86scGzhwXQmZbiZ1mEDsd1fWdD2VX9p+o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EVM/LPsQ0SVB6HpXBcXf1ickfWyl9jveSNiC+I9+mVwGXlRZFr+HOGqKlkIwSs1JPMTk5I1lu0dH1tv6pXSBuaDmUn3kMItU7/Ty/yaK0gTbF3cMe9SuYj4I4T8px1WtLyP1aIdh03cZK7RA/J46giFCsuOR1a3ts5D8pvvaw/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=aNwOUcLy; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="aNwOUcLy" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5f4ce54feb8so813324eaf.3 for ; Thu, 06 Feb 2025 14:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882108; x=1739486908; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1G+5KuhaA9Y/JWZMuBnNAEnz6cO9OcsXFwLiAeC3p1s=; b=aNwOUcLyH2Qi14xgvm61ESdvsbtDTjPEmqKUa5ANJYhgh5jcK27hZ4nIbcw0ajkcXI jJ5kQ2WZSdkyQwauR6oOgTNxrU7mfHhdSV4DzchNywzPlbQE2JCNKHacaiygpdNqQrcD mcPWSHElpji2WpGlhyRzuIHWhstDyv+8DFSk1FH7zC3jWYNMtBNPrQfhnqybFG7AHxpB oEjRzot3lwcHYVKGZxw0MftmUNR+4cKkDAix9D5zWtnTY23O70GUA8+tR6t/fFywUzYR 6wB9F8GINjxdkPYqTfCMqSBCu4TxIuiAB2ksAJ96ZRDFoRRarV0N36sNe2AyatBrIh5t airQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882108; x=1739486908; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1G+5KuhaA9Y/JWZMuBnNAEnz6cO9OcsXFwLiAeC3p1s=; b=t7lB1FwNL2H62uk/hHwU13iKA1pCTpwUoq7KnkEsfmqNlb9n8gj3K3t/umtU7+GDEZ So8g6f3pe+154qpR1QmgcQKkiFYkvyedsYzlswVfka6FH93z7yLf7edeuZOPlw3+3Ln4 5C1KAbCAIaN4nFTULaKIBVA65GwLd0nYdavO4ZQS8Q6vwCO9/QDu7RUWEbBcHdUCW0In GRVwP94uUkQMiO6XxxT8zDx6X+zrsU5ePkZWjkJzX+0JUaXstlN010Koj/0aJHMKhW2+ 372G3FOVpBn0xExavLn62s8IejNNW1tTX+67NEqQYjUUjIyiI+IGaTSkfg/UkV5u+Q+D vYMw== X-Forwarded-Encrypted: i=1; AJvYcCWHxmIOZtzHpMZyEKKaqKWRmU1J9yATRMSJmAi9re6v1Bi+SphR72257zIzqWOBVkSH4WwmTeKXvQRgN0Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yzjf+DXyQLLqVSyQ9B8HCn+Kt5YCSmz9sPZHEoITisC1s7Ilule rxnQuTt9VVyeCiLlInPu0p8Bt9DVsIUsV5Wn04Usx8Nqrcw9bmbrNk4BrSEoWjk= X-Gm-Gg: ASbGncsarJol3Vmm1MuohQm4AVdEiiaYnVVdQYj+cVbudXtT3b4vWH4Fpltg0h9r6zm vUQskbiTUzA6wGCNGl/xnIb/isY1zMLW36MxP3zc0XFafvSvNtVoEzIQKvHa9CjCwOBh7zEoHz8 WDP1sI9iokTBJi5yNpFaBdud1yYQu4nuiZi8NhUkSDrynY6i1woLG3v7JQ0z2pGpRVDOUSP2kTX ZH7Vu95bfaZDwxsIQmru58U0+Yy7Os5keRBedxH6v740sNVeHbxBYdkCgu9VCxbeHFPDZ0EqVKn 6u4t2RLfcY69NcI8S1JRPibK1wdXiTClRI+JLyBtyTeMONg= X-Google-Smtp-Source: AGHT+IHhS6xIbsoZ9Y9JyXWh4zSyrZ2jgd8SnPiV9tauY6RFNa0jyaYnEj0rYnfG1jHSP16xj2DPIg== X-Received: by 2002:a05:6871:70e:b0:29f:b7f1:d844 with SMTP id 586e51a60fabf-2b83eb6727cmr752453fac.2.1738882108087; Thu, 06 Feb 2025 14:48:28 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:27 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:19 -0600 Subject: [PATCH v2 05/13] gpio: max3191x: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-5-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..36ca07be3e1811fd3f0b27f41bf= d307de50ec5b4 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio= , unsigned int offset, return 0; } =20 -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void gpiod_set_array_single_value_cansleep(struct gpio_descs *descs, int value) { unsigned long *values; =20 - values =3D bitmap_alloc(ndescs, GFP_KERNEL); + values =3D bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; =20 if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); =20 - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiod_multi_set_value_cansleep(descs, values); bitmap_free(values); } =20 @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode =3D device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + gpiod_set_array_single_value_cansleep(max3191x->modesel_pins, + max3191x->mode); =20 max3191x->ignore_uv =3D device_property_read_bool(dev, "maxim,ignore-undervoltage"); --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BA0824635A for ; Thu, 6 Feb 2025 22:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882114; cv=none; b=qxyPcFT0oX+aWETNm7Fnv6HaAc4GME5e+UtJBYe6DcO+ft9dsUmv2bPuSPK5ite4FAgKdcU5V0b4WEhAqwdTW+Fb11Q9LGlyFpYMjYeKyvv01N0qGpOfqlQqDY09bxrPHnqzGQUL+ZXZwBrd0FUwJ0AqsvlqYyUeIa0sdQTxbjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882114; c=relaxed/simple; bh=Vy0Sg5/yfIQxGTiF+YsLYiZrGZGxLfxXhS+B2ZRsujg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bSJhxjZaCUxHB2J2RoNfdJ7gNPE5gZF6hRgtkZP8t+cHn2KVBJ7U+vY+HPLAOfmkERpK6hY7hi2aNyPOcnMCVqAV2swaQIizL+w+tIh9lpUI3VI3RW4ER14yWx61VkkQzchdByDwxTw3xXXschQ2VpMOKW0DnNYs9pNQkMG+DQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=hJqIGHmB; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="hJqIGHmB" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-71e15717a2dso763046a34.3 for ; Thu, 06 Feb 2025 14:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882110; x=1739486910; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b7U1tr86Bxzg8KMxqprTIoKXgh7O+YeZXgnU26M/an4=; b=hJqIGHmBbg7GV++307TnlCnNUt4Ks0z26mmVNcG695DwU2laOBo4AsjyyvvmokN3DK hBzsZrKDks/R/wdOemNM5x9MfD5eDe0Z78IjwGKy49AvJHPzFFrSHmWKAwdZmto95lWP JEoS3bOHyiGm0iNoIeWKKuY+g4Df9zQae1KUVqE8kYUR1/h605jEsaSoBQkS2FGDwYpz KucYjdgWEaPTVa9thJk49G/LcG/QGIkbiQQmAF+D1HapnieeGo4QkD55gjm+caNQcGHX YPev2CQCaCYMSG9IWw5LAOEkiZuVeej8qMjI00STsqmvsl38qosPDAUO+uXZMglyxcE1 UQqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882110; x=1739486910; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b7U1tr86Bxzg8KMxqprTIoKXgh7O+YeZXgnU26M/an4=; b=SudmMapyVX/PEvqU7+daldXplwIQxE9JyR/g3+UbskoUOjOFVG6FAEULVeIfhR6kna kJWxAs4NXWLCrnsvN20Ep8KIiRWRw0z3W9EQOnlg8xnaj2c8wLzMLFBMDeU6ZFceyfu2 LjM+VNYNF4YnmTDf05oQxiJQ93wKxqX4AxT+wav8BZ5xQL1FcDOfx/D9Gd/VI8OJtly2 4RRQPMo9X2LbKGbdReD5ihN82LAHGojgDGm9TKmhc4Xkr8IRDiu8BgWCltUwlN0K5NMr r8UX8DacaOiaNWwriE7Zi+ZSYHcc+nYY5ngzfnXGpU3A2P1JVMJH0e8l0ornqaZiO/2L DxPw== X-Forwarded-Encrypted: i=1; AJvYcCWPzvaR03vTI7RTYFLJT52SOp5zAuV/Yoo+SjdhgnCDS0+5f/6Hm8Sw3cxZXgMCthCjCCup3l3dFLrK1ac=@vger.kernel.org X-Gm-Message-State: AOJu0Yxry1Vre2dA7pm4n1GmRttvrer6/jOU/hTHWlKH33vOYsuw6TjP ZjPUz3b48+y9Z9tygsuNdgiMdtexy3y17HFCzawl4X1FXCQ0OmvId/uTI6N06DE= X-Gm-Gg: ASbGncuraHx5rVdqZKzxTRsCRp2qsOVVz4bCPdkOkNAAOngEkxh8JfNmM1AjKZsSCGz l2qdjuGVXAM0w2tQCpo4vLDfPvZd5iX1BcbuJ3m/olgCY5yA8fyUH9KZ49XYYh3EcKrN80IOLy6 65qA/EFhEazZ4RodhVJ03s900S2Xmrmh9Q/WN1Ls3chbO+MMw0fFOqrtQ/tNiFCxlR5Slgt/Jmg 3G0q8W9vY4u2xqLdYS2BHqDdjtc1lDZMfNkmGcDO4CrJy/vh6GM/Lp2NymDpuUvn7V11zJJ+3CA nD9T9mP8oG6cNJ6Q3sSo6GtIKeJjYQC7/bU+bDnsOck62tE= X-Google-Smtp-Source: AGHT+IH50vqJ+UKd/x8agnmRsrebnsoHILBPEML/hHVzdaMwyiH1jtZh+WCDNiEdIClFYG2pC1GB1g== X-Received: by 2002:a05:6830:6710:b0:715:3258:4ea9 with SMTP id 46e09a7af769-726b88023b4mr646049a34.16.1738882110277; Thu, 06 Feb 2025 14:48:30 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:28 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:20 -0600 Subject: [PATCH v2 06/13] iio: adc: ad7606: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-6-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Jonathan Cameron --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..9a124139924e4a4fbbbd234a851= 4eb77024442b3 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev= , int val) =20 values[0] =3D val & GENMASK(2, 0); =20 - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiod_multi_set_value_cansleep(st->gpio_os, values); =20 /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..0fc41275e79f3af282c0ee4f31e= 222bbe8d8c1d2 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -297,8 +297,7 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio= _dev) * otherwise, they must be hardwired to VDD */ if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); + gpiod_multi_set_value_cansleep(st->gpio_os, os); } /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail =3D ad7606B_oversampling_avail; --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 894CB3DAC15 for ; Thu, 6 Feb 2025 22:48:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882114; cv=none; b=fPJ1cHmg5YD9PafIPZYl7KqQhXc2hv/jR1RvuTllNA0+5cbkNXxqX1dsw6dMvAv7Ey9oeBARye/5Otix4njU1toUZ83RzaEBo8i6exfhviW//fqg5Xvs1gpemMfSuR6NO8C/DKSTnVJIdEAPTzGCCEVD8AhyWu0WEjdRpw3Wz30= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882114; c=relaxed/simple; bh=IH4g1d8UAtzwg8g1uq4cmWqDVZbX87ChiYlpGpKjpcs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zwrkm3y7YBFP+DER2iV9zf/zNm4rEBCNjHVqqvZazmE4VeeAewF2pvPLAwLBUX9Fe6V57gC2CZldyln6i2RaAkUqFP41pAeQeqQlh2eAqWr3u2gohX2e04xr2QoduQoINLPuuLFs9uPlzBX1kTV0rOPxa2mwRWYuT7Iqx6SjyBw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AnYjx7dv; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AnYjx7dv" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-71df1f45b0cso1308379a34.1 for ; Thu, 06 Feb 2025 14:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882111; x=1739486911; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+wznyorGz9Vd3pJ7hNo9c2JQSgu4MoX0a4PWBg4SPl0=; b=AnYjx7dv/fHT+RaED0QPGTL31FjQ8sPhaC9j6rFbYMIqV1bhjP7GNgroxDh2xTM8qE X3quFZWilB3KMjn4EFADZF9L+JrUvA3mcmJ0AeJ2ODcxjMSjwix5XgGmu9ttLKsFOWdX KnEzRgKY/TYZbPgQhK9gsmaKhaFHixmME7pXAwcdbr7R/6fWRAyHSoZFeahw6OZtohqL wm47wd5LlVjIKn0kaq4Sy3PRn3FguH5BqbXEWuvUFu48GWxy1niWvSh6G78pDnZYl5e0 D2/rKKaYEslnT5KZlOy0NdQAf+KtgZaqBuVg5lex0hkL3chwwd1hgWaNF2CBULDDY4EF mbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882111; x=1739486911; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+wznyorGz9Vd3pJ7hNo9c2JQSgu4MoX0a4PWBg4SPl0=; b=qwrX/GVdNWAVOckha0zU8q6xfw9kvvlqW02hHeIKAl8E6uYlbwsHSJJhIHi470EQiT ukVjfTuvpygGxrugjAhvMZxJ4X/45KOV4Lz0JT2Hjta8TxvPcNS6kkb5iUrA55COGvej Ej+iZXadr11w7U4QnQSrbx+5+LuJecOO/VCLKfCG/ZG/reSyFp5OkCRtcNwlH03plk6l k7k5AKzxbTgj8bpntNcanBe0q8MvGxjOFw5snzQDeu5zA3ZPUn7JUq71hnyLs7ztODYD WAmfpmu14iosEzU2LJW9L0E2S1sLW9L1YhCkpbFqjUlNwdMl1K4K0+9mX2NHSLRhULq6 ENRQ== X-Forwarded-Encrypted: i=1; AJvYcCXLJbrGnsXbqnMmMggU5xX2tu5vz+x6iyfqYNA+JU4ToliWxC5U7sPWGSihpPTDFuxe5mH+nAz2Z7z5GKk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvbv3t6cJFkOecRoOtn1VICsAvW5h3uiTUYIzVdcFHqhqPotZV 4Ehvdoge2QmPZolbpVKQcKd/u83BzvDegH6U26ojnPVlWQGydsCdYAbeDcGeu6w= X-Gm-Gg: ASbGnctVwv2MOujy1kMFOC3K8FvaMAIOhpKaPN9BuKEwEJsbt1DC5i6eXrBeTMawmy6 QF2/bYQ7+erfGTO3eFwpEg4zw3FqRL5RlDGjw/w4x6uAxPkH87xX17oCz8K7reu8pOXx2vB2q+9 CYFIhqHz0DkAZW9kEoaVnG+bGExyxXLICersJ1bMc0gCVUJ6cIj6iNwhMSyVjP4VW/7dHdOAzjJ 2FXZlhJVuJXYB6NF7vbXhCDhrmuwNdQxGb3UQtk9n9JigY8ACx1wKEG1YNpdoYCj45wK5c63s/0 u//73fmB+yBZAemAhSKrDd1pBgwNhsfE5YRN86KFlUszHi0= X-Google-Smtp-Source: AGHT+IFY5Ed96/KcKz8L7aoyZ9lE6qS5z+d/+9NsZ4rcpOBs9+vdKruwDq8O9FLpVqE3mmL4J2bJeg== X-Received: by 2002:a05:6830:3981:b0:70f:7375:e2b5 with SMTP id 46e09a7af769-726b8f3ab09mr416508a34.6.1738882111587; Thu, 06 Feb 2025 14:48:31 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:31 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:21 -0600 Subject: [PATCH v2 07/13] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-7-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Jonathan Cameron --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc4= 25a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..d9a359e1388a0f3eb5909bf668f= f82102286542b 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32= value) =20 values[0] =3D value; =20 - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiod_multi_set_value_cansleep(st->gpios, values); return 0; } =20 --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4213237713 for ; Thu, 6 Feb 2025 22:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882115; cv=none; b=B2pCt0xEMCmfMivFe1wpT/ozrNzVeA0MdBK3uz07gXgrjtu/QJ73SBCRj2yp1N0zqM0+IIo+i7dUS3okEARQ0E6usgcQCpbr4BISfgWcNZ2eG47X9yTMYq9TBv+IQqHe+wYrFpW38+hp3S8+nUt1iGkdSOaPvfNTMRcQVZFUi34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882115; c=relaxed/simple; bh=dVRjAU54tx+uhyYX3p8irPZ6yP65YxRfaFsbht8BOc0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IhYpC0OjDBzc3F2KPixzCw0RQ1x8tm6yO+eiC8thBfiQhOKOahE8LSqx1715l7jdXEm93Z0U1GvQs0STdfPdHqBFsOFXlUYpgr3jyNoaQhc4yREF5zTiyOZbhTTinsHE/On/WG4YJhbqwxP9tQ1/RPy/VdS988XmO4R/p7EjdPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=wjbvpfe1; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="wjbvpfe1" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-71e36b27b53so828581a34.1 for ; Thu, 06 Feb 2025 14:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882112; x=1739486912; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Qt9BcvBwXw7VI7drRQ9jRI7HoN4iY1rdT776+r9izwk=; b=wjbvpfe1y9vbu9WfWQNJOmobf4evI0a0DTqd05GYZWCD+pM1oc7n1Pr8t/K2ePbKwY 9h/gKre5OlfmXCw7nBB4j2zHdshTFR7WrNNDx9WEQpLUbvz+ozbm5/xTnZ66YBwvGIHa oo6Hzo40IoTI9+Py9Hxzi1zeyf1uIxrkfNnFGUE57jmPb80KqZkMBV5qek8E0x9MWsfa 3mT8OhurrwEVP1aUbipi6IJnyVVDFyfjBTA/ZTAE9GFG7r0iSLInyyxgOGvyKGVZKZc+ GRNIspbp8MyE7wOtYKSUf6v1a0tJzFDo39su0Cb+GCY+I5dnygCR+FzmQI4OpWEf6zeD Dn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882112; x=1739486912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qt9BcvBwXw7VI7drRQ9jRI7HoN4iY1rdT776+r9izwk=; b=X7lairKHz6J8Mb/wDI21hTHkn5f4XHObXPE0IuBf9HJIe9Bpno0btMoLAXWM/c4XfD PD0qDo6w5Or4ag3yuENgxzPlf/c85K3FSnhB1u9Yzf7Ghgia/kytbbGW+VRzOQa6V569 0jssyxx2uvDcKCRVyxAX/ZJn5YwjNNycUvsokTqICAVkwcUlFq908/7paykdk0M2TejZ 8ulTPxD834kMISysf1rWLdWBO3KNQY/Uw9eK/k9dloZQlybOwtYpA14KGWdqREo0Jx1N ad+22CuqFWaEIzKl4mJ7vOmxWno8Xqb548GVgUluTYJ1/6QwGgSfIFoT5TeidxAjaEVN 3BTA== X-Forwarded-Encrypted: i=1; AJvYcCVbjn8t0f6yf58MefGv6ezzF7zlfTNLOzudVpFHS/3TTTP6UHp3LKr6tSeNDB37hbhKEWx+D+P6FIkm4ns=@vger.kernel.org X-Gm-Message-State: AOJu0Yx90ORGOPwyYJGlSIxo6ZdQugPlB92K9Fgo2NhclzLyCAS9+gP5 jyjGe6IqdVykFA7t9+d5bSougH3bOnRB2kly3wvqlmbaeqWGmtO1eGpZMvqrtJA= X-Gm-Gg: ASbGncuklx8cS2m9y8PL3dDi/Yc1A8PutP7Rz9Wv+umEgC+q0weMNxeorsEq1HtYBZi j7tlUp/xyfzAOYTjBnkwxKIMhvGiSJUUybk15oE2sqDHCpxJIEs36sjJ3lWb9eF/zgBkm+X64+8 mqYwf9R//TmmmruWjY2e/0pid8qlKtFMiYoFtbuDWyj214Hk3y45xUK0hxh+4k1J9Uk5uEJWVmn 9SgUsEACw+/9UZttThkTQrGusiDDy/YfpwaD/Ko/Uj2IWPCLnOKbHfeDYslzQoVrXXrhG9jIjhw 6IXa7GtrP/R7ZSN8Ohybg/6i1owKZtaX4y/8jPiOlXt4yEI= X-Google-Smtp-Source: AGHT+IHXxKi2A/XYeV5UWyLNbvoQ8dEflCn5kPNBQNuzG5uM6VGTHdJPWbFF8OVEjlJC3/X0uqQhvA== X-Received: by 2002:a05:6830:668e:b0:71e:48b1:ad28 with SMTP id 46e09a7af769-726b87b3665mr815075a34.4.1738882112753; Thu, 06 Feb 2025 14:48:32 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:32 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:22 -0600 Subject: [PATCH v2 08/13] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-8-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Jonathan Cameron --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s121= 0.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..7f18df790157f1e411fb70de193= a49f0677c999f 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st,= enum ad2s1210_mode mode) =20 bitmap[0] =3D mode; =20 - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiod_multi_set_value_cansleep(gpios, bitmap); } =20 /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_stat= e *st) =20 bitmap[0] =3D st->resolution; =20 - ret =3D gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret =3D gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5B0723BF88 for ; Thu, 6 Feb 2025 22:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882117; cv=none; b=eWdRgmT8JpELSPkEQu3gw235euEms/Mzc2g+YEYfrLW3w64H74Ue14Jky+7O1WkMu37ysPke+4aUg8fUilq1kzZo9PZ8ETkOeKrakySwFvLQ2eeS10dqtXB6hEjJ4Jua0/8Hh0LNkqMvpkCqTLnDCwgrcfwF8ltctP8+8CB5Mo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882117; c=relaxed/simple; bh=HaFWSgBdfXggpkPiEPQivtzXY7Xojib1tG2MzfPUdgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HXGcb+WTHi4BSaCLQOK51+c5sGqDVEjkKjxN8DhWxWIQcMBtkVXJFJRBGKL5rYWyQp9xvyMdusuNK/YDeDJQ9Kw1QhqtInPsVpbpyHYNt6SObfqITn3wcUXHfi+qouq9sHmESKrklt3Fr3eqeaEmreOWa+G0+HVTCtbTxzS/uEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=cG9pwCnk; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="cG9pwCnk" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-724a5d04befso776550a34.1 for ; Thu, 06 Feb 2025 14:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882114; x=1739486914; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=cG9pwCnkAGhREeCpqTup5txOFp23jH8qzyvN/AXhPm+HsbSzH7nwbiISN9/J/pQjCT aRmMwKOEOaAH2ejG4ZtdJiNaTDSifLuDQRLdTOUVfGsHWnxRO1VUYIIVER9gzUJqTGoe zX+XAFX3q6RAYoScAzRqwFo2E7gjIhM4t7fzx3om1IKQ49qYCyGvgVsWmtMUjCPp3Abs E83O3ZRfdX3y3DWYApFxut4GWdUGhVZ3e4aBoGd8cyrqTO50Tt2elx+LSrqP/iQUh4w1 /G20RwOZDyTyPs0ERRJSW6FzBeqGR2ZhJWGXJyvp3aDhzsAS5U/VhRHlFK17JXQwHREj 5IRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882114; x=1739486914; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=D0POBXQDylLFYtX5hNUcZsd8boGnNsYplcqDpqk8E/LtezSIKn5NmL/QoeW8rCMWvx 7aNql0hd8Asg+75uPUzjBzEXYl8INHa6DLm8Zo/YC+HoHth32V63dnhiY3z2m0Ep4jBX dC6hXpZOSjIIXgM8/jisTnyx/d2ccoRO9pVTf5QMBM0wwhachN8t6+ZODKAeded2uFTG hrUkn6l2DbaAhLUrsQzppMtJ2AVn4rOen2w6dqAZ5QixZ5uWldNN4w5YhjhQTgjhyUtE biQ+cYiwvWzA82nHL9pXOb+k5Zk8LqW01uNwRbIehiF1mbTnq+/CLiDFOKOq9zZM9dVR zJNg== X-Forwarded-Encrypted: i=1; AJvYcCWj0JCrm15uQM1VxhnA5abOjRq4jE3OvtqGS0ZW0cLc/fe7f/Y/PW9oL4AZbtA3nmeDcMIqg9sem7n1oJw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8z38+bIB/l19Qn2LgCwDsSc8Gife4X/Y2AzXmjxbGPGNgq49/ 39JD7r9Dln0/2KZ12MrFcVucVXHj9k1t3jLH/2zvgdupCvn6UnM9wiLUvrqcyGU= X-Gm-Gg: ASbGncvICEiI+hli6cHGfiMYIeQexahOq0x6cR+pDkYYH+MsroJ9aWGC2NwBUqPWnCZ kjHahzbWs3XM2Nfj6ghLUGxYCpS5s54utOBZ86EpGlVm9PK87kp/xpgQkoZVpPO6wiYWAIM0Oep j6VI3D/2892XNCOIbQVhJXGduETZlvstSPWgDm/2Vl9iJa73td1N3KhAgqldOhj1tpvgtJM45vV Kx+oyZXXmFcwnOGeF2NtYyuKei2qhuLQTUb8ZI74V19RgI9zww4SDzeqDXExtafji80M5AI2cFy MtdzaJID30iLOGOfJYp0IP8nKe9vH75yCkEJR+8dBjrmPdQ= X-Google-Smtp-Source: AGHT+IEVknGonsegy5S/Aw+PLXi2TjO/wnkH/rmRbYYU8mAcrJGwZvntuKEgjA/jQ79DrZ7uQxsojw== X-Received: by 2002:a05:6830:3981:b0:70f:7375:e2b5 with SMTP id 46e09a7af769-726b8f3ab09mr416555a34.6.1738882113893; Thu, 06 Feb 2025 14:48:33 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:33 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:23 -0600 Subject: [PATCH v2 09/13] mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-9-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Ulf Hansson Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_sim= ple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..4b47e6c3b04b99dc328a8b06366= 5a76340a8e0d0 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_= pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); =20 - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiod_multi_set_value_cansleep(reset_gpios, values); =20 bitmap_free(values); } --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B9A23BFBE for ; Thu, 6 Feb 2025 22:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882118; cv=none; b=u1107NgzWQgxsSb4DGqZQsDgQNtVm8xLYqMKmzZ/DxYCxpA0EqDtGqTtWVgzZ2IacV3xJ12apV8cJ5UnpuIbCIwFROi6IlRCmD4+tc7n35DXUOQ9njuVcrgVnPMZ5fWuEIGanDNc9s7O3GksPQsc4HD6uJ5FSdLwlBzhANKxrFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882118; c=relaxed/simple; bh=DTPgNGmkXhUVKQ7XC6/DETbHbqjA5xVWJi+TJtvGAQA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WTlTNtm1ext8zyiC2wLSvuTjAbTB4z2848KcSPX7o7yWQ5tOCsLyVvUo1LMyhCeCiPa4BsQA3rUKgexcB8qbpJoEmCPvR9wMFQeVhUrnR9X3CJe/T+Mub9T3EaEu3gbZEGBMEzwPLK6e9PZtlT7rK+x67oRd0gOkUG1a966LkUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FUvAybKH; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FUvAybKH" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-71e1158fe3eso866550a34.1 for ; Thu, 06 Feb 2025 14:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882115; x=1739486915; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=FUvAybKH7qyx5T1F1PyRz0oSxcmZcJJYmbheZJIBhW49+S57dHaKqoULcX3dNUDYTa 6TQKB+ttrcz2kHWvUi/6UQBhUn7JjmC1jegHyuOAEMYUIlQjVGPbCnlACitchBv2ypSO fjQJAkihUEh59LAYOD0OcXrrHtL2P2pgQnn3YrMFYW3Pt1UVTZDdUzQ59z5lmUfEB3jZ gMHxxII3M6qe8xRyrhQXa/kzQTrNQgq1cXYZpitlxefzhAPRC3EGx7QGTxOfqpKy1QEF tJWg2A9B3QTE3dnopc5a9FoZuRkXl8/MPVkpw+MSqSzdVL4ZCxs8xOBZT4nMCAt62aqM /ZAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882115; x=1739486915; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=vVd1dwTnkL+UOmtt8dE1j4NzY5+43Z+nHfm3gJWjFWxkJ5yroo2bDY+TWvzkOKbYwA JvA+7SwDTUZdsSCEymtftOr4tDSRlLqloTWXSMNUZgsOsjlybUkHy0TrfErQXg73k1+j qQVLZNsUKvFXAI+B1LVsa6ZOUIVqRRXov8u63CXn53enkN6dtNwez2vAsaVHqgUswF4o 3oaf2cyYTuVXmOztgVIH3V96DJvljgd838tU04rHTAltYS9BYLQk1Mo28RJ8hUWib0BL kfh2/e3eZaesN2JRYoLc32X7Gz68q5oAtNtDstmicnidTRUNV+KLBf1yYkY7yVV1V8+i MulA== X-Forwarded-Encrypted: i=1; AJvYcCX0UAFegPW5GnfHiQmrhn/8VWoEfcumHhzZK89IvNEHEMXISwBxxduGgjujouz7tILK17/B5eWd1p1j1mI=@vger.kernel.org X-Gm-Message-State: AOJu0YyFMG9cE3K67t+eq5NguqRKKzuZfcpW3r+a/uHAX89r/i21gYaA fLxLiV9KfzSkB5y5pzBuMHdFD8AGF4dVqLF/aFKhoN5eJC4KSrZqWedNK7L3BME= X-Gm-Gg: ASbGnctyoY34ZRk4KTTtxV8JLuN8GqS3p2sZPiqUVfTi2TjJZuPTO+1baF1XqwIKY+g rRcnRlTyaN8v+avNAE15Da80FAxEAyomGCx8hfTf5kvxpXlx25bpvRWS7ajRl/q3DHXf4ylsFBz dMKUGwhTM1lwQNIQywOhViexGQaWhTUMYPuYZ/zCiySxXlqzqinNHZlZuXD+qp05lkBR4VnOZHY mFHaUtShmi/gvxwSnU4GZAfKzineyZIpqg16OMJI2oQu/DtpXSSu2GPBGA2MYAU8gwkKFM4DHeA 4fw6VOQEoKwbW5nmADocbigUDOJGch+hI0RK0PPiVc7OtvY= X-Google-Smtp-Source: AGHT+IFi5pOT04kq25kPl4tFke6cDrSG8LtrrGuNrjvHOS0CkDrwzGgg5qxvsBSG8EfBe8D1EHBqsg== X-Received: by 2002:a05:6830:d81:b0:71e:17c1:45e with SMTP id 46e09a7af769-726b88883famr823900a34.21.1738882115069; Thu, 06 Feb 2025 14:48:35 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:34 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:24 -0600 Subject: [PATCH v2 10/13] mux: gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-10-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Peter Rosin Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..5710879cd47f89b6ef4458d6b44= 19a1fe9ad349f 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int stat= e) =20 bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); =20 - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiod_multi_set_value_cansleep(mux_gpio->gpios, values); =20 return 0; } --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B372023E235 for ; Thu, 6 Feb 2025 22:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882120; cv=none; b=OjNPsCNYQhYlcQHbkH2vBy9bMOxZyhiEYaE7BjeOv5bFcgjcY6VnSsbnEbdqzbbaCZqXTAP+1Brn1OI1Z/pIwuj8zMFxgHePLaOkMdfrqys5oSsmi7q8RsYKh90sIRIO86Oazrl2F2gDwyLvNDOVlgnnyAdXIoD4zmHujtQupxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882120; c=relaxed/simple; bh=S7dgE3UPYoL2oEd02LPby/4FImzR8JSvqPwrh4K9qkM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NEFOA6IEYOQwgT7W81rjf6A3dwGlIOvUR/9qhI5K/SI2xRA1nfuGk88QDxPp6sGsjLBDxk3hfVWu2hZejfAT0B+8Plt11HCtLfzisVFS6t2kPtuh7zEJHPqKa2jK8DFxGXIS0SfTQ37umsMu/8O8O6+rHbFsM6PTkAuMUBdqX+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=nmQpRudM; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="nmQpRudM" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-726819aa3fcso912417a34.0 for ; Thu, 06 Feb 2025 14:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882117; x=1739486917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=nmQpRudM85WVm0WAajhyPCri4wbrbkW2/rkX+kWEO83z2na2RrrTq1VAypJCbI4y/E J0dDdrMS3wX4dUNHRc8C6zuFX5xPg6JjOTezCVTz5r2HPtJ7AWeCl4yxbdKe221AT/+5 exmydmLSy23eonQ5u8s8NccyD/CX5khqRVvhHvWerWL1WGwtqTcSVPFqvluM51DpaqXK Tf38tYJFzCqKvnYDgJW162G0c0slncdysTpZ38SdWtB+TNetJ5sLYjJeJpS4uEGqTx7Y UFQ/n0eD6rt2HXgq+5Hu9qxIvuH3XHrBalx/Y7ir5Rua5GsGZfYtSayoqu+dMpS6vACQ 0sfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882117; x=1739486917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=qk3KSabR4BQP2pu2Y0PJbBVX1hXdeH/ZDGdmSOMicjs27FjYICXzySEaEN7NyDathH FmCOQ9iqaCqEUn+U0k2gLB/W+H+Y6fP7Atml9R+gbECBrN0RJQqS2YBifmk+GBEZOCei dKoUoktccyXNRbF0e0uacsOpNmarqUf+l8HqgBkmBcMEiqx1gHYv++uHlmgfIh6SUaLr nQ43I5ji3sKYa79JhJ9a4Zlb/gjoBOM6QDv2nALa/gdy8fLqMUk847bsm9Y7oBRw6gvG FK0wsSAodxi9MtQinHxGXzlivRIRxGS9degilwUp5Xe66tVtHIb4dLb1uVvKulXI+7SD 9yTw== X-Forwarded-Encrypted: i=1; AJvYcCVkGuyJqP60NxhM/sJJZNdGbpSYcKFzuF06LKoU1Lmi+rsBYZY9/+Ndk/f6f4wtSj9t/dHoAmXElDjGh9E=@vger.kernel.org X-Gm-Message-State: AOJu0YyoSJ+NEMxIK4i69y9jgYOPb3WCzcnJJ5Q4TLcD+9W/KVcSzm/z +o7U7HaIwBp1083sY9Cra4YTZeqLyvwH7/co8XgnCwPNZbQ31WEtFxWeGwSQ6g0= X-Gm-Gg: ASbGncueRSrPFZMqEe/hanrqs2//VfoLnmDQjgst4hq/VaDnhk7+PWOmFA28C+1tsm0 n9owYow0gE2JNQRavs2EbCbpqOhNtz7ljRzT0ssK2V+Aucw71flvw88dLm08CEAD9kfPkFVDW33 S294iDuh8Xi3r9S9pa1kEMLIhY6m7NN3NQc7yVJJ6dvkyaOnlhtvQB0mBonyA4oMF0TdrKU6ld0 +j/IpJKUavll3DY1AWNxXCLmwc4lH22+KWrXZo1/Wk+XoUwQctAcstGCNoOK+CYbptFZhixg3X4 cCsmswkRHZXqL9PI2TOlCsbUfM8DmVwKkL/vruU0ulxaYRc= X-Google-Smtp-Source: AGHT+IH8zx5vDbhBOU+RiFLjmMV8uSugiz4ArRiuueUcFuxbcCISDHEvqYTZqWFApQPLnbiuZHKf3g== X-Received: by 2002:a05:6830:d08:b0:71d:b6a9:7489 with SMTP id 46e09a7af769-726b87dae1bmr640053a34.7.1738882117199; Thu, 06 Feb 2025 14:48:37 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:36 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:25 -0600 Subject: [PATCH v2 11/13] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-11-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-g= pio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..fefa40ea5227c5a35d89ec2c6f9= 5c6668a2470f6 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int= desired_child, =20 values[0] =3D desired_child; =20 - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiod_multi_set_value_cansleep(s->gpios, values); =20 return 0; } --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB9023E25E for ; Thu, 6 Feb 2025 22:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882121; cv=none; b=ZdtPYrx+0CDJgMkBeZ/aS/JpGCpYhzAXUyH5VyiZXKIp/iaRFeAGE1d+rUWlkd9tb+VVZq9jFhgwPcssJdN2C79MAqAtG74MYwTfO94h1LP/kDRgU/irYD6zjYwXrqxhDrUqa2psnbrv+Tjk832kNvNVyW5c31RWrwVKrMtKxxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882121; c=relaxed/simple; bh=QtC6oLxmw2DvbNfS+XsWeQUt9WZBo54DTtz6cY2CdFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XZqDCvv7lU0f7GqcKQmJuMwE+cW2yH2p/3fIGoi+bs+KmQM3Ju/CKQdTiZxKW1y2y6S21+29EK9BKXPPrgbAhtRdcs5e82UYuVqQ2ROTkrf/n4BgpEg04kSUPcPqoveVsPVYeidAFIBkq/QJ2jKa4kUyyPfHOz7ZSX3vc9EwJX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=1sEwRXSP; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="1sEwRXSP" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3eb790888c6so468131b6e.2 for ; Thu, 06 Feb 2025 14:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882118; x=1739486918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=1sEwRXSPntOwPL0HtxKu1P9TX7+3wpt5WQsiyHQORN94tjNVCzbYGJvmZZiPuRVJON LEJ9kzfwBTaJ85prxenb1UydBZpqGC9lSXKqyw160PqQweRLqvnijFB3uYdYw2lsnQmS 5sKotPh2YZK2VNWHK9TWNPYoUf7WwLhzknWMqCQ7RbbysDgucCyQLz7ZfUJWvMRCqt3A l9SQuE5ICQ+UhvT9g9Swjkd3gqz/31JuaM6vVNiGnODbxjGMUUKDDGienS5fG/F0kTsl E3iPtSor9mzm2ko7Lcmp+wKGqdl64Nhg6MAQlRzVogpQ1NczgfTiap67dK8vAQu5fwKi +Pig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882118; x=1739486918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=ki6MsjTfQQ9uKxgKZWOF94NNMm0bORWfrB/TatTUsENPmt/LaqfXIS5ovYEp5iDWqW W386UtBqBdheOouQ10qmGsX1W1H35k3RzOdGD3oSliqAE2lJE916keb8fyUd1a2gv5JK 2KFHkPr9G4oxYrbjPlu6ovZ0dCaOHr1OON6iBKBLmYJNUyf2D8nPBw9KFr02iavxTlA0 je5ILMvCZDwoFojNTiC2lt4XeQwnmDrU8FnOeot5Xjd4YuV2of/zihEfr0p4XFqoWNsa ewUz0wU4ZmgEhfBUo+thYYuLoj89dsQZb5iIKGJInKnUtaFHpaOMdc2bBZiys4pTCOCG 5cfw== X-Forwarded-Encrypted: i=1; AJvYcCXbPv+yck8XibXmbyUNjCrmZ6BPaQ6Wjo2AWV0rKUmIzQ3e1jf8xw+5lqGTE7VgnS23W7d954yRHU8jUKc=@vger.kernel.org X-Gm-Message-State: AOJu0YxGDxhZ+XV5cds4HIqOG+M/IZSbbeH7HXSUs8uEj2ViUVS+dNwI +XVUSdCpOCKsTFJEGOc9TukRRKHuW00I12VOAL1/qZ/lokaNeT5vya/tWBJT4Z0= X-Gm-Gg: ASbGncvWIr+/rPMi01QAjtUCiBvLe4/0nPX/D9P5/9k5AKqoj7K5SPpMsbp4+YJo/y6 6yf9RBTwNr4fcPqNiPZBQmgDNZREte/2WdE77Dx+nUJpvNwizEOvC/IbPgrQH/26a02YpYDF2u0 tFzvqbPl9jZF8pdSUhKOwMte/th5AMlf0KJ7fOubuKpxEi/KRm+hYX7V5LtNrAoHwYY88jY5fri kMxlLdwWwO63DwjxYGkElB9KLmxW3/O74as1mI3XFzm1TmaKXANkgFKD7wSa2vBHysynQ303fxA IL4JP9zMbxVLKJQ7AveDDGLwfiAeI/dQ6PL1HtbKXMjYXs8= X-Google-Smtp-Source: AGHT+IHg1dkR38vC+BOfsqdfTGHavmIhAar+M8vjgAZ97yt8yxkX/PgUDRgvY/W1hOK9akNHaGFBHA== X-Received: by 2002:a05:6808:2f09:b0:3e4:d4ca:2774 with SMTP id 5614622812f47-3f392318adamr932419b6e.20.1738882118361; Thu, 06 Feb 2025 14:48:38 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:37 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:26 -0600 Subject: [PATCH v2 12/13] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-12-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/moto= rola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..fd0e0cd1c1cfb10fb55ed271e47= b6a0bf857028e 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, = int val) =20 values[0] =3D val; =20 - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiod_multi_set_value_cansleep(ddata->cmd_gpios, values); } =20 /** --=20 2.43.0 From nobody Sat Feb 7 11:38:25 2026 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD3A23FC58 for ; Thu, 6 Feb 2025 22:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882122; cv=none; b=I5MN274oKAfNnh2MD7gUS0Bi5JthpLZwz87s/IKr8SbOzurLedM1s0wsAjvn2/GoL4VgqeDoirJZCIhYgCptnsymRJAouEmQqqvWOBWfmWKpcWLI/KF0Z4Ab6ym+zhfY4Nt5cJAElgx8XAPj9MVDzyt87nrBNkYSzLIfjpaB//E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738882122; c=relaxed/simple; bh=SREiuK3L9rZlfmn2CRPkgp1zixwI3ho4VDIygOej2Dw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=djSdRIriz5xqG7dGmT+HXZMGlylmdxajitBKXlyBZjCmYbeoQLLe/SZa8mCQsR9ZPc88xDwccoqS7Uq4mG1XJAdYWeXMnh52N+XTqFvX1ZaWK4ns2cGEa3jbTf5IxqvsE6DI5E5JdIf8hiJ+jJ0jJH871Sea+Jimo9h83K70gG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=3d8s6bOu; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="3d8s6bOu" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-71e10e6a1ceso461106a34.0 for ; Thu, 06 Feb 2025 14:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738882119; x=1739486919; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=3d8s6bOucWMdaoYvNt0o9ANhpGoZ8C427iKTKgI76bTHXp9+xlOcMknn6M9/irBoHV nksFkUy5g7dk2r+aT8r5Wx15FhnIPzzraKfbBSWHmfzbJ+eUY3B/pY56TQU2xouTA2LN Vr+dhX50lwrQrCydJKGi0eQuZXeXfCm5BYc3W/Cy4BvTMCozQ4iImUZ5VfL403WpkJmG +eUzou/GvavA8Zh2VtAQmAtBgduaJd9HFjMyCPE9Fm6iy4wic4oDzhZJC14LWYjdn/Qb JFVxWz21CfUGF6uZwXo0357IZHuLwyMGehza6M1gc5KXCv6L1kz+rrw+kJrP0vLjxP0Q 3TUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738882119; x=1739486919; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=obUss9TP9gawlK40/uqsE0NfroXYyQTPMNTbqsExp7IPs8Tk2khb/qRYx9zzv59heX oYkgAVeMRtkHafXYxHwopU3dZtkDUoK/hU6pJxfFr1KY2UgBpjPQvCfrwHFNyr21tcLH H2O0t8nltOutG6jVPfTDnGopz0XGt0DW3nVZgTbjvm2+htzzC2wvBnlu6iMSw2Z9AHdp OiGFTrVFYx2uaOK60vqzpxkjok/YUuI/OEpJ1C4Beg2uVZjU66Ah+g3y1fr9FmHpZimR Ih+FKlgPN3ONCyjnBpeBvm8ltQ0pOar9bs3M/r7kc8nQUnNJsj//gAXCsfWlsYLMhdRc vC4g== X-Forwarded-Encrypted: i=1; AJvYcCXsx+KEYm3RZWHkyKlY6qEmY95bvVymrJVsUH09lHFsOu0uJfmPYjrogov9IxPC5mjvJw7JHueSeqkZP7s=@vger.kernel.org X-Gm-Message-State: AOJu0YwwwPwYph12sCJEeMdoCmahyo5veZoCScsolS5O4Rip/oMDj1gx NjewyBahH/UnAzwnELywU53/LOMazL2c0swUk6c62NC/8IpMvswrpEqlgALnkkQ= X-Gm-Gg: ASbGncsU+VyYC/DlvxEZBufABn+9nhk3UNoCUOJQDu3Qn918JZHqiUpp1G6Gpt+8dlH gXMV1g++wOOOjcaZd2iuyRjmUMQH7SkNfuJBbdWn9/jZ4/+UC6z6CUbyMGK2SkgCABB2GxH1VyX UaAFknqY6vayrqmU461z4mAUk2HTrTKiPu2z8EZI9W5YmMUoxpeurLG6m0NwxPzf/F8l0PDkh/s 8+7/b2RCmUFxYuL1Q0KwSwmyEGRNb9zIf5qbmybM9FyNpaRQOi4G6uUogisrXPqGiFyG4dqe+K4 0R2Fx7LYWPIHt5j/O43Rg1Bs8p+UgY4/AEFZ58GEvlDjzm4= X-Google-Smtp-Source: AGHT+IF6EkhBBGtZyNdnec2UQucqxt5fakVdlz2IO8AnBCKVXc9lOTpKIIPxZD3f0MWNAAb4im2E5A== X-Received: by 2002:a05:6830:6819:b0:710:f38a:191c with SMTP id 46e09a7af769-726b87c732bmr566366a34.11.1738882119510; Thu, 06 Feb 2025 14:48:39 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726af95bbb5sm510986a34.41.2025.02.06.14.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:48:39 -0800 (PST) From: David Lechner Date: Thu, 06 Feb 2025 16:48:27 -0600 Subject: [PATCH v2 13/13] ASoC: adau1701: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-gpio-set-array-helper-v2-13-1c5f048f79c3@baylibre.com> References: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Mark Brown Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..6876462d8bdbb41d551f776c2d7= fe6ed46115fa1 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *com= ponent, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiod_multi_set_value_cansleep(adau1701->gpio_pll_mode, values); } =20 adau1701->pll_clkdiv =3D clkdiv; --=20 2.43.0