From nobody Sun Feb 8 19:55:32 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011047.outbound.protection.outlook.com [52.101.70.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17CB5227B9D; Wed, 5 Feb 2025 00:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717158; cv=fail; b=M/34/iNWGpbAgvUJIWMIXLvDH1OllPkf0M2zQicmGvvmIoR8mkJ+IbYcH1aycDW9xQr5TXlDDYop9DwR7D2ngBZizLNdYd5PTenDEHUZhPeO3jwM+w1gdRPYWzGnMFKOLXzaqAPaBOwWr3jHF3JWf4WzjuXylgUTEKeR18Wb5dQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717158; c=relaxed/simple; bh=tL4q6530H9Plp4QYXqVVA23ERiPbWu5moLORe5Q605w=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=JkBxGRXK6yE1/p3zaOxyHZtah8AafFYwlMyxjPJGVhXp+gmOK/T3+URZ42ibyTTNhq2gAIx7IZ8xZW49E/vUixSvkEPGRv4A3LgwcNsGHdgAs0MMMAgsoDgNUQd2oBNo27KCpz3jw4Vjl8+3D9/JeNnviVgkoexKtBEKEFD3dlk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=SSRj6NMI; arc=fail smtp.client-ip=52.101.70.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="SSRj6NMI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hgz+tF5bRZ5pi15daCNM+b9SL0SkV2QBZaSxWPz/DF9zkQ52mZCOWJgahUhf+vZeZ2FemrLT4ieIXElQpkW52bV7ySfwf2FCLyk0HcSjiu8M+55OyCkn/lk84cPOtUuGN7T2THhrlVo+cfDOjhYTXHEYNQM1J14+qbHfjCwggJDc1me/O82LqzLQKsWW2xIpgiuHk8kRfPQrmasWrDvVgHaUmWx7/ut/1tWlOfzhvGHBQcFpV4ebda9XBjtxG0xxZ2YUUDdHOQoRzBNa62qMEd+8fqj+rjNafq7rXP/loCZV9E8h3vdTC9Ni3lXQ8cmA6tMGUPltSWLX0RfeMKLLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=hRDcZlbQYgnPziO1TpwRtfNywnXZbvM7uZk1Z8ui0cGvS132Xb4j0PTIKE2eS1n+eXjEMha2HmCtoLCQkCxnTyJ6WMsCawj0vjZbMQ8gDbbW7S9z8gngYEG193MYtBlj+AUS/Akokjp+CN3whU1+i4HxGbYcqBZDl8dwk1HbKQ9pKwYkGZlbVLVFBTjsYnP0/za31xz79dz0vHCBtfnh+AdBZdrT2lNcc0InQ/KckJZThWAp2ZwmvpoHlnUeJcCAu3DGlPtizR3FlZNXJDQlIfz8ewgJQILp+GzlNepGjK6lsOnDi575+RAEFisIlX8U3kbd2j+B4vwIoqGgHOIFbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=SSRj6NMITme3BmCQyggX91rD+xXzcDvoYjOvKWZAREPcgnQNLeVXZNv5M+1lb0f4ag42srQcvcDdpMHjIAeHTiy+0lcwh1SVGz2+kN89LW+gzUK6p81EDi4t9KNl9QRss5b/L2jF9gM6tDmahATootyq9wfh1zgJ/gcIe8EXyHVC7uMiYOY/nmen101sYeRSgjfricu9C+f8y6UlyxqB7XHQIKafarnOBSNfpDyzV5F3IJP+V/IL1Hz58xWVvufxsxCJJEezTxM09CtMLwkDSwqdZQm8eann3dU2/c4UWywTU4sZz18TbYEkAB614lcHxbBq24ibzIOytzDKAYDxoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:14 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:13 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:19 +0800 Subject: [PATCH 1/7] rtc: stm32: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-1-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan , Antonio Borneo X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1587; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=mSTCl6oCfnAa45eZZ0ce81+vqGl5rBwE3yA3RKdgxSo=; b=Lk2a2rVgsQVbE64qePKxXCkNhWNVGlTJaj4JEupetcuunmnR/EErmB3/D3wwreSFhSh+WzdaX WTLr3G09U4QAFHak6Ng+ayGTwEopXQOaC+KXtjNT6urJ+uuLKBqHa1h X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 99d3215b-3ecc-4065-7f04-08dd45804ee1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N2p6VXpWUnQreTd1STV1bkxUZmc5Z2hGb0I3U1dNV0RYSUora0U0Wk5SWDg5?= =?utf-8?B?eGR5YVNRNXRKS0xqVVVITGZ2eGw4KzNQb3pDa3pTUW5XY0hKRG11Ylpqbjhu?= =?utf-8?B?QXpTWUlzTnh2bCt2K05vM0pMdDdpcEtma2didVp0dGxreS9Jb24zMUtBRVU2?= =?utf-8?B?QkI4aVRtUFdabm1FY25TUStjdmpaV3YzYmU2Y2REc0FjbkFjZm5MajkrQUI4?= =?utf-8?B?RVVtY0Vta3YwdEFVVU5DWDNHcFY1emdIOWFvUFFnbEdmUFdFUC8rdHg1Sk9x?= =?utf-8?B?eDdnWXNwME1qMEhDV3JQaERQM01RZFBLa3BXNjYxbWVlYm44ZXRWTkVVM09l?= =?utf-8?B?YXpHcit3UEtXRE9qVG5ISGVWM2xnZUdwck5CaDFqMzdhTXFXTEtYdGE3azdS?= =?utf-8?B?RjJxM3B1UTdHUTMzTkNRQUVQQ1NxS0gzZnpJaHoyUFFLM3BGemFxZVY4dEty?= =?utf-8?B?UXMrZDJtdnFhRkxNZ1dnWkR4b3VvMVliSkIxcjVDbXdUckVCRnRDa2lmYkFB?= =?utf-8?B?SG42NTVzck9EdGVNVXhtRlVYTklwL3NvWGJKbTZBazF1MmpGUnNOa2VPRjRB?= =?utf-8?B?MEdLOEhhcW1VaGpuNk4yVVQ3cWl1UjhwRkQrcGErT3R3K0tiYXlodm9pMm50?= =?utf-8?B?Ui9zWjBiemZoQzJKN1hLdGtDb203eUlXTFJVUkRrTWUydkhuUEEzYkkySkZ5?= =?utf-8?B?SDBnaHBkRTNhd0lBd1VoaWc1SVkzcCsvcXhxSXY2MS9aaU9QZTNIODdxQWRs?= =?utf-8?B?cnBoQzFxOThENXRFYkZoOThKWEFaQTZ4eFhrVTBmSnVBVmNQV2Ewc05HMjZD?= =?utf-8?B?OGdnMHg1Z0NUVEs4cUxEM1VyUi9weHM3YnU4U0pMQzFPVEJRRnNncWdKWVZK?= =?utf-8?B?cTZyLytEZmlkVUV6TzdIelNlcjdSaTBYQXRlSzhEZFN3bzlybm5oN0RKODhB?= =?utf-8?B?U28xN1A2SlJ3VUhGbDlGSXlvbWNTMnZkbmdPVDNMaWQxeS9jai9pY0dGZkEw?= =?utf-8?B?RVZGWS9VVC9UVnVNNklDOG83cGNjMjhTUENBOVo4UzFFWTBwLzBTeTJmUjJu?= =?utf-8?B?aXArNFM1UGJSb1I4Uit4dEZzdVRFWFRKZDNqUlpVdEFGaDVxdCtZNG5qb2pK?= =?utf-8?B?TE5GVTBUMFRIU0k0VVZqOFJ3ZDg1NlVrWEl6Q0dxZ3pMOStLK1RIR2JjZEY1?= =?utf-8?B?c2Y5TnFvZjRWQ0FpMm5GMit6NzB1YWkrb0JUbUUySVJpWmxEZUxLRjJsUHlq?= =?utf-8?B?MjFMRHhNQ1RHSjhGK0ZUSVlJa3BxdU9nd1JkeHQ4akdUMDNNaTVrUUFkSWhN?= =?utf-8?B?VnB3QVJMcUw2eG9pS21TSVNTU3NDenlFb2M5cWtacnVVQ0NNQlZXaDlkeEYz?= =?utf-8?B?Y3UyWVVJYnpqOE5HZ3FGN3loZ0prTGo5NDcyUkVjcmxSRi9iNnJ6NU44OWZ4?= =?utf-8?B?a0d1V21kQVk2NDVMUmloV2UwZzdoMEl4MElFa3BNY3lnYm1ERGFsSzNPQ3FC?= =?utf-8?B?TTRPeldmWjFQaTNQcS96bmt4VkZQdmxDdUEvdC9HbWM5SVVudnhCQ1BRNm5z?= =?utf-8?B?WEd3eWlseUZkeS92WGVzc0VwcThxTmFUb0VUbGk5dUdlZ05PR1U0UHhQNDkx?= =?utf-8?B?Y05COVlmVFdPZWE5RllWRGZWaUx6VllZT1RJSUFlWit5ZnRhbDNQM21oR29Z?= =?utf-8?B?UkdYN29GU1hjTUZ0VnExOS9pZmNmWFh4TWxSYjFDMnU3NTkwTGpjOGVld1dx?= =?utf-8?B?OFdMamJ5ZmZFWVZQRWhQaHRZSUZYSnFHdi9yaWRvem9zUjFBb041a1l6cjZR?= =?utf-8?B?TEZnUDhKQ1BLQm53TGM5WWQwZHVOVUtsMHJ4S3VwM0RWWnNzRmxiS2dXL091?= =?utf-8?B?NXUrU2V3dHM1VWM4NFUwNzlhYzlveUdQeGkrQzRmOXNaNUhlN3FTeTFzQXo5?= =?utf-8?Q?cHBcMcZeDAwlDCjRoNiLWLLmLDV+4R8O?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjhsNWR1c0xrSGx3TG96VnhFTGg0OTdvQ3QwaEJsbG5VZ3J2ZjBjcDRkOFRt?= =?utf-8?B?eGFvWWZzTTdyZnZKR1FuMTM1Q2ZLV2xuNDB4akpsTzE4Q2hsVDdGbGlHQ242?= =?utf-8?B?VXJ3cm1xRkswZWR2b1VURGhXVStDdnpPZnNuSXZybHNhRmgveVl4ajVDbXdt?= =?utf-8?B?YWZmZXV2UkVuRWtOREI3Z0RvSFBtakowRURPckcyYjc4eW5FMnA4TzBTNmpX?= =?utf-8?B?OGd0OFdjSDZTK1ZPdmZ6d3Y1L0V5S1NTZ3hFK2h5WGJUVHFUKzBmdHJTbXU2?= =?utf-8?B?dmpFZ28vTDdiUllId1pHcy8ydVAyWGc0NTJBL1dCVDVxQjVRdlpOVHBBQ2JD?= =?utf-8?B?UEg3Y1lyTjlRVDFZbDRMMjgvSXZCS1hpVUVjVHlHLzRwRTJFeWV3UXBMamRP?= =?utf-8?B?UFAzZFV2dFpyT3lncHhLM0EwanRXQzgzc2p4OTFqdVlmUUZHbGFob29Xcmcy?= =?utf-8?B?blBYbS80WHhFS2NqMHJYSDJCbTVpUGliSjFOUXM3N2ZrVVZiTS9CWlcrbjcw?= =?utf-8?B?UC91RnFVazYxMEZ2UVNFenBlUVBzWVFpT3N2c3IreW9ZN0RackpNUjF2NDRG?= =?utf-8?B?QmhjYTVsT25HMUxhREVtVlZpaS9FMkd6aTgzdHU5V0pMREdqZDNTeDRaYVdH?= =?utf-8?B?UldOczd0SUdCUG5ycERFd0duMjFZU0VNM1d2dklzN3dMOTc3OEVsY0htenE3?= =?utf-8?B?aUpKenA5MXdMNkRDM0pwQlBZS21LUGJOUUdybEtMRHlER2VUbFBrZHRNelNV?= =?utf-8?B?azJLMktBMzJObW5BNmNPN0IwNU5NZ2pBQXRINUVROHk5SWNxblVaajRmYlZ6?= =?utf-8?B?Q3VhQmtmSXNDaG54ZUQ2UDRIQmdtVFdlQ211aWU1aWtONVllTEhWRk1xSmdF?= =?utf-8?B?Z3Y4cFovVTVmdUg3QnRHWlJsdjdFdjBtVU10UE81RGxRQlBuaFBwYSthQ1o1?= =?utf-8?B?cHJGN3FndDZxMmtkTGg4K1NOcU9HbkZaSS85bC9NNy9aS2thRXFpZ2l2eDFx?= =?utf-8?B?eHNHaHVQZHY4OXIySFl4Z000d3ZxdTk4cWFkNlp3VUtmRkhPZ3J5c3ZKaDdL?= =?utf-8?B?aUJxNnU1ZjVzRThURWxjYy96MkNkWGMySzVUN3ZMbnB1YzcxN3Y5RnV1Vjhu?= =?utf-8?B?SHlyU3VZemFrZG16ckEvYVhQMlFlMHZ5bVR4RTVwNGF5d3IxSkFDYTk1QUhh?= =?utf-8?B?QkFKL2REMzQ4RFAxemo5U3NySWxKUGZmRjdCekNTaU9UQ2U5Z05XU1lVKzZV?= =?utf-8?B?Rk9XaVkrbjd3QnM1M3JEcUZrcVVHSDNGTG5BZ1VxVnJ4OWlyTEI1L1o1dm8r?= =?utf-8?B?bmNyR0JiRjBiaVg3bjhYNDk5WVBJMkdaSkxaVFhwZVpJTHlXZWoyWDEzWUxI?= =?utf-8?B?blF4c2JZN2xDYjIyTHFIbS9Ha2dMdTY0Wm9PTHBZU3F0Zm0ydDZsTitOUFB2?= =?utf-8?B?b2x3cTZtNHBWekpmOUdzcDFTayt1S3RpMkJrdU9jRW03QjJ4TENiN3FvbDgv?= =?utf-8?B?TFlNMjdyb3RLb1U4Unl0UGRsTmZmN0JVaVAxVzRKcHplSUtXdFhlSWdiTjBq?= =?utf-8?B?ZkVWcHltMlVPNTFsTUw4R2d5TTY5SzJmRnpGUDZnZHFwUi9VZXZHQzhPdHMz?= =?utf-8?B?YUVqNktocnNKZ1VZZ3pwamJBR2pLZUVFd1FCOVp4NVN4L2U3azFWaFFhVzhO?= =?utf-8?B?Mk1WZ2R6UWhRakVkZDFDaHo5M3YyRHFRSjNkY2UzK0daWTc1WGc1Y1Y3OG9R?= =?utf-8?B?VmU5NTVjQ0RwaDZJOUJyb3VWMlR6Zm5uTzlDMDg0dk16ZUJsQ3BnWXBvZFJC?= =?utf-8?B?NVJtMmJaRERnVlJBSkJoSVJXL0xaL0ZWVlQ3Nmplb3hLd0czd3RwUnorb0th?= =?utf-8?B?ZnJvZVc1SXIxc0JjWHBUdlplWTA5b1I0aVpvTGNTOWkvd0lndzR2dUxHa0dw?= =?utf-8?B?VDR4Y2NwZmlqeFR5aURDcytmd3gwN1QxZnAySVEvVXJsbFNITWUvL25xd3Vx?= =?utf-8?B?QlJmeUg1aVlPVkNMbVJGN3dwTmZ2WFcwQXNReHBlYWs5RTRreXhHZlEwZ0VV?= =?utf-8?B?ckY3aEtyL0JYOWRoTVlqTXE2UWxCSkc2bHhDRkhuSTlPS0pVcS9RUEtTZVZ2?= =?utf-8?Q?+bOyVNo4isvbz95kkhJIGfwDO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99d3215b-3ecc-4065-7f04-08dd45804ee1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:13.9092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WTsFcdg24zs4xgWICahUxvnqRyfWyXSnbjgdlbO+rRQYOfstAr6scDVt53Uot8pDjSAXBE0i2EWpdGRIET1T7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Antonio Borneo Signed-off-by: Peng Fan --- drivers/rtc/rtc-stm32.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index a0564d4435690313b86669893ec639af90fd6b68..1b715db47160158b3cfc79c437e= a956e301deeb5 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -1143,11 +1143,11 @@ static int stm32_rtc_probe(struct platform_device *= pdev) goto err; } =20 - ret =3D device_init_wakeup(&pdev->dev, true); + ret =3D devm_device_init_wakeup(&pdev->dev); if (ret) goto err; =20 - ret =3D dev_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); + ret =3D devm_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); if (ret) goto err; =20 @@ -1208,9 +1208,6 @@ static int stm32_rtc_probe(struct platform_device *pd= ev) if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); =20 - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; } =20 @@ -1237,9 +1234,6 @@ static void stm32_rtc_remove(struct platform_device *= pdev) /* Enable backup domain write protection if needed */ if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); } =20 static int stm32_rtc_suspend(struct device *dev) --=20 2.37.1 From nobody Sun Feb 8 19:55:32 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011046.outbound.protection.outlook.com [52.101.70.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9227B228393; Wed, 5 Feb 2025 00:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717162; cv=fail; b=ePSEMXqJJHWTYijjR6UXB1aB7NeN46iDX8t37FBov2g5gPCuQwiUF2/GAhGXJomAcsT5NUxDPFK8dPzRwetdNjFAceK5az5xWoBEz+6bUjDuOClOupB2sk/kOC2xRyEKnxI2qCAmckYabyw0ba2tlU9ukldbbal3F5UHWGLicYQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717162; c=relaxed/simple; bh=bGv4dF3gwaQ8/rybE3qOHzdzrW8kBSYtqBarBhutlJE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WOGo9t1mV8bjOJ6fINJCTT6t/jRe9FKyUw9zw0LpTqe4fKYubirgMOg9iouYWnZNZtIekiM91iyfh6iZ4QekpI6RSTRTcZIVcjmixnxB0fboOpuxTu9IPNc5hOKiiH2Zyw0YztKlAbi6og7+KOkt4c428Akb2Rd/eCDmesuE2ro= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=reSMyPCT; arc=fail smtp.client-ip=52.101.70.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="reSMyPCT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j8L4dTNQF6PB+2/V2rnCUUxlCPNbDxDGdJKaqqcC2CHW62cmQhbz2rMj1ZsIs6PicomqCVOLmt5zMDD9kYJPabiww1iufXVRy+UJtBr1hZkb6iTzVIXkulIWIE6EvNow8/d3ddiL+UO9WOm8dPAwbG4I+rkWDgag/nVi0AkRw0oLSPJakmlYszUW2bcWpb/1CJGwmFkeZAASpVvxnE2XAbU6b3xDUdG1vBpBRXl/Gsla0Z4FedhBbnTFt+vVkovBaRa3YHd89f+HN+cC30mYSRmMs+i8nVXCRje6MGS/XXzMmnUeYAL2vUK+ZoBEJl20h5BpSfjEN+7mIRa7fHZscA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=d8KEGfsBO+a/yMYt/8MeYmgHuHZrP8QIwEToVnW2SWnNsGhocloxslRHZurofmc70z60y+dhpw43WSbrr9Leu3f6J7XY5uVMrwee1m8STDuw9aFY5wHHmpeUXNQc/Dg+4kb2WhOKEDhq79hyv13udt+++xNHZ6igOe8P8Dri1AWviLsCeZUC+ExGWWguT51hNX6wh8MVkNY0Oryj5E1kWqtYPiUt+WvTRrc0BZHel0rNks0QSdDxx0RxF9jLZkYGP7Lv1Qd94jWqn8DHKfI13NZW94HTK8ecr4xdeUGTw3Jsm4X3BHB1yKYQNQ1o9o/8RUZWUzFR/4sRZEqYdHZx9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=reSMyPCT8VEPMYbX7GR6+couZPM6zsOs50mP9UrYUzI3Vv21jIraGrIZjG4Ph9DbvZ6lJYrZT+0U3JB9XIw39GRlybNSDG8xEMqUia7X57e0NiwzPQmVy96rS1bPCfFsoK97ToHm8hVLmdOdlGElEmRdQejeBV7S/+MDe/kWKifo5iD0nPvv9HKnFXz6yiNcCcvcTJPD+j6Jot4RSt5wGZ2Ba3hs5oKsmeWE5LfWgnzBnE2lno07pLJB4mbvnErVhVQ9u7rX+Ha3JHR52wLT2DAPNMzRbVjgqhjc4QEHCmT2v7fb6lf4uNpEtwnxFAVNkVuN+9FwOBOgO1txtj45XA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:17 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:17 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:20 +0800 Subject: [PATCH 2/7] rtc: nxp-bbnsm: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-2-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=2071; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=VAulaoWVPhHtzgpO1nG1u9VR+bogAGzfLBxhdt2/l0I=; b=ENdfDOGh0YGiORqM8nju1hwNzBEhXGkPtvmLmmrZH3kthYHpqDEz/bK2nIQJZOLHJyLNZiEJl KkNPuJQtFo7D3ncM4rUNGcWCBY7luJ/myGCOqhWy0nl6JsNPHZZfAKy X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 752ceb67-d20d-4efc-4cee-08dd45805124 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WnpUamthVzJFV1JPbzFIK1lGd28rdks2RVVxeVJZUXozc0Yrc3VuZXhXMERF?= =?utf-8?B?emIxK25JV0JmbGFURVZ1SFIvMmo5M0xkSmtvaXZkRWZpeS9Rd1RYWVF0LzAr?= =?utf-8?B?SCs0ZmYyUkpDMkZGMFYzcW4xdE9JVGlDM3EzTlE1NUtIYnI0WGdmUk00cVh0?= =?utf-8?B?U0RVRmRhc2xMWWM4bDJodmI1RHc5WGxoTlFreTRiaDA2WnZzYUliNDR0MWhL?= =?utf-8?B?MkpPdHJDdnZ0VVZVbEdyU05MaUtKK2JoRXBvRmtKTWEzaU9XYTVxOUJtTHpa?= =?utf-8?B?WDR4MTBVTEhKMzNFYVM2d0M4cTNKS2puWElxb0pDb2U2dTJNSEEzNWhxQ3BP?= =?utf-8?B?OGNycjM4clY1WVpoTWN3QTlDeld4ZTRLSk5PQUVjTm5QdkxnaVVRbTVVQ09n?= =?utf-8?B?QWpSSVBualArd29kNytRcllUVVJCVVkrQzRpYXBhM1ZqVmxDV2NtcXJ5dFNN?= =?utf-8?B?eDdTcjhIaitsa0UxU05UdkVqZWR2L1czOXZqN2VZR0lKdXhSQjRwSng5Z0ZO?= =?utf-8?B?djJ0VHhGZTJnNUhZSHBRdnRMeVFGZ1RmalJxYWhyN1YrcXRReHQ2bXlWYmp3?= =?utf-8?B?RmhMRGZBSE80NjcyMER4R0tyUC9TamFMUG9xK3pOaytLMGNDY0k4VVhaKzFG?= =?utf-8?B?L216MFluZXJjalFQZXB6eWRFZUZyNlpsNUNOVmdFZEtGWlZsVUJ0ZUdPOVdt?= =?utf-8?B?RE52d0dacFREZ2lZZFZzTk5hbExoYUdiL1RGSmtzWG1Hb0RUNGtXNlY5WTFM?= =?utf-8?B?dlp3REpWV3FTenJNWWlCeUlHR2lyNUZLZXkxWkozSE9WUDNSVFVnUHhoMW15?= =?utf-8?B?MEpKeTFPNUNudDdTZ2FCNUtZcnhVOGU5SDdBVGk1TnBJRitOeXdoOFNRVktt?= =?utf-8?B?Q3M1NnptZlhZaDIvSXM1U2o2eDhtQW0wNXpwc3c0WFdFN1huUnhYdEdKZUp5?= =?utf-8?B?Ui9WTURIbERiY0ZJZEc3akc2SjlTaDBCLy9EMlZ2Sk5BRUM5TjlwQURoUjho?= =?utf-8?B?ckdKSmpJbEVZOFFkY1lmd2dFOGRnend5Vk5HaGhyOExOOGlsVGZBQUptbTJJ?= =?utf-8?B?MDFLREo5SUQyZVJFZCtpeDY4QkIrb3N0ZStjWUgwM21qTWdub2xHSXVmK2cv?= =?utf-8?B?S3Zrc3N0ditqMmlRTVc0bjVHNFY1TFVCTDJ5WFBWM3NiRjZ5T1U0bndOdHk0?= =?utf-8?B?R1lZdGJnMmg1cExrWWkrc253aDRhelFxckN2OFlnZnVheW84MkMrTlBYYTZB?= =?utf-8?B?ODBzREphTnc5VHlxVFJnSmxtMEdwVTBhZ1d6dWRlYmFvaVFGZUtFaWs3LzAy?= =?utf-8?B?ekZDQ01Rb0RUSGNmZllUcERJY3A5LzZBSXBuZ2Y2c2RKaEVaRTc2SEdFN2M5?= =?utf-8?B?WFFhdmtTc2JTWDhnQ3pZUVdRSXlOU1U3OFhnWVNaeldGYkJ6NmQ1QUtLTEdq?= =?utf-8?B?NmI4cTg0cHZtNFlJVC9wbjlnYkxBZ2RXaFFRb1owOVFzWTNNZUJXRzQ0QXd0?= =?utf-8?B?MFBhT1ljalBxQkI5NTdZcy9Rd1hIcjdmQVczbWZndTkwZXg4R2RoYlN5TmFS?= =?utf-8?B?dnA2djNaak1KbmJSbGptb2tHQ0dRNTdlWkI0Mmp0dWsxTlpqMVBjbDJXT21r?= =?utf-8?B?cVNMNDNBVUFHazZ2bHZ0QWtocldJSDFzREVhR1hWdHB1d0Z0NGtsOUhTSDM1?= =?utf-8?B?di9QY2ZDYytkYzlueVd4WjN1SWl4d2c5b1NVQlQvRzc1YnRVcy90UXorZjZL?= =?utf-8?B?M05xVEdneUxNejdHaHVUWXNXYkQvRXZ5SHc5T3NjdmxBYXRyVjRXdStvdVdT?= =?utf-8?B?THJjYm8yS2wzS1FweHpGbTN2SFZVNGZwbm5vVWtoaWZ2K2dCdGNNdnF4WjJK?= =?utf-8?B?ZDhnVkdtWkVnVFg4d2FSTWxUUUNsSjYvRTFBUk04UmM1U3VmeWVyOFdPYXh2?= =?utf-8?Q?QO65M6vEU1Q=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3JGNU5GOWlTRnR6OVJYR2VBUXVNdmF0SmQyL0krdkk0aDlQVjhqR1U3SGFE?= =?utf-8?B?cXNuYitDUXphOWc1cnJNQWEzbTFVSGk4L3p2bG1rUjV5ZFF5RDBHb2RCVHFp?= =?utf-8?B?bXkwaXhwNVpNajNXZkUwOTl4YVpQb2lCVUpmOU56ak91MUtuNVd1Q1F2bkxp?= =?utf-8?B?NzVYTXZoNEZHUGFoZUNxcVQwZEl3TDBTSW9vZmMwMFphTEI5VzNHdFhYUmpN?= =?utf-8?B?ejhscnFxZmJ0VU9QczJoa1d2dUpwN1k1R2xFcTlRUGxDcDlhd2lWUit6aHV3?= =?utf-8?B?Y0QvTEZTRnJzK29PSGkwZkptWEN0RG1PVzZRYVRsTXhRdzBSbTdIQ0Z1Q09v?= =?utf-8?B?SmZDaDhmM2dEZ0Zzc280cTFhdm9Fc2IvZXd5cjZwZDFaMEhlcUJNYVloaHJE?= =?utf-8?B?NXpiUnVRbi9pYzlhdzhpQ01HWDFzNGE1aERBOHBYOEpkbUhaOCsvUDEwODlK?= =?utf-8?B?OS9UOGVyKzRWK0k2dWVvZFY4dnk0SktpM2lWQzJBbnovTG9RU2ZzdDNoUjdC?= =?utf-8?B?T3crRC91SG9adXdleWJ0YzBvRThwd0RWTDZGQ0hQRi9MaVJ3VTJDZUF1TlNy?= =?utf-8?B?V3o1QllKT3d3U005UmlqSjhwWGM4Y2plQWs5OEhTTDlBaVh2bWNFVWJ0N2Fm?= =?utf-8?B?N3BXYVMyM2JjcWhJdHRtNEtkQmdxd1Q4WDhBMGZvNFJvRzRGaTBkblZOTjFv?= =?utf-8?B?dGtvZGhsdEE5aEJvb0dQWkJPRWova2pBQzkzN2RobVJHY0tUemxoTVhGQmlP?= =?utf-8?B?aWtvbmJyZ3ZxWXlMQUxnZStkOW5rUTBNOStNdVN0VXdDY3Bqb3BjT0owWlZI?= =?utf-8?B?MkNBZmQyMks3Wm1iWXFURFpHNkUrNTBROGxISWUvSXNwZ0l3R0FNZE5ia29t?= =?utf-8?B?QWZQa0Y3cTdlVWN6Q2VCek4wamh2NC8ycGF5QS83M0wrb3VLQm56NTBEdjVP?= =?utf-8?B?enkxMGJqdll1b1hlYm1wN2cyL254azhPdmp3aTdJb3NSeHdoelYrb3Zzcy9x?= =?utf-8?B?UXFaTlZNUTZDay9kaUlicVdRK0dQV1QzZUVXbWpKM3NFVzV2Q0JhQ1JqUDRF?= =?utf-8?B?Y1kvbkJnSVFBUDJUcDJkZkdES3QrM1RkV0FJblFsYU13R1Y1a3V5eDNSZFQ4?= =?utf-8?B?UGNpZjBkMmhWRjFtTytPN1hoeFB5YzFZbVpaMGdtK3RXT0RXcEEveE94NDhK?= =?utf-8?B?elBScmJBYm5zeXpRNmtDdWY4eDVqU2pPd1QrM0diM3hOVXhZK2F3YlFwRDhL?= =?utf-8?B?WW5GdTlYcUErYnl6RWdaTTJ6RzNGS1FZSzhDdWEyeGZodXRRdUhYRytNYVhD?= =?utf-8?B?VjYrWk1UQko3L3VjNnFuWG1tT2pGanlsUEd2UnZaSHJ5MEsxc3dzaEwwWnEy?= =?utf-8?B?TktwSlRReTh0SGRkVnFoNldBaHdLNUIxWXZRL1ZtUTVvdVNrVkpSeS9iSTZk?= =?utf-8?B?UWpQMGtQYisvVkp6NUMrSlJHV3BQcWduVGtIaVN2V2ZwZmxCcitRMnJUVTRE?= =?utf-8?B?RWg0c1ppSHdSSDVvREJQZy9yemxsbzUxSzNuRGxKTTlKYndmMVFkSExqRVZJ?= =?utf-8?B?S0VsUE5tMXJtYTQ4MXc1M0w5QU1YSlJtTGRvQm5HTEY4TW1QRzM3TVBIV1Bi?= =?utf-8?B?WFBGOG0vUWtaeG13RjYvWjNVZHQrQ2ZMVDR6R1J4WG03S280VzZNZlRxOG9z?= =?utf-8?B?b1AxdG9zcTJuRGFJSkY2cVM5R2pqd1BscEJqZXpiM2hocDdlZ1lkbGpVNVMw?= =?utf-8?B?emZjclphQVA3RE0yZStVYkcxeDIrS2xrZXNWOUZTTlB0TDBEbGhTMnIxRDA3?= =?utf-8?B?aWROTlRjT2lOcy9oalB1U000ck0rMUNyWGNTanJlaExBMUFlNnB6QUxmdjBJ?= =?utf-8?B?bVdHOXZTQzJibm94Wkgwb0NqdlpOdjNVQUVLOHZCTEk4OU1TWnlJbklzQWZK?= =?utf-8?B?VmdJTWZhZ1RBZGkyaXdHRFJEdnIrWGV4Q3ZZT0RHQTloTVI4MFBHbHBla0Y3?= =?utf-8?B?RlNZNXhzdEdscU1ydnhQVC9zVFdkdjhNYWV4U29KeDM3NW9IUE9UeU5SOWk2?= =?utf-8?B?bnJXdDUvS3QvdkRFUVdWT1hzdVVhZXVIMWNuRUw3NXM4N3pzQTh0UGJJRDVG?= =?utf-8?Q?ML58PUlBW5XV+GcDKJfRWjDlE?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 752ceb67-d20d-4efc-4cee-08dd45805124 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:17.7282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zL6WspjqJXPS6S8IFRWl7g5LKLR+YmIKSG/ACkxKGdgE4A9yANxSIhX0yGmJzJLXrRg6ocm2PQPxDADRJnNYwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/rtc/rtc-nxp-bbnsm.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c index fa3b0328c7a255ff8a902a58d61a4b0e59eac493..d4fc9dc583d317d4852b7d897a6= c45cfff6961a2 100644 --- a/drivers/rtc/rtc-nxp-bbnsm.c +++ b/drivers/rtc/rtc-nxp-bbnsm.c @@ -189,36 +189,26 @@ static int bbnsm_rtc_probe(struct platform_device *pd= ev) /* clear all the pending events */ regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); =20 - device_init_wakeup(&pdev->dev, true); - dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + ret =3D devm_device_init_wakeup(&pdev->dev); + if (ret) + dev_err(&pdev->dev, "failed to init wakeup, %d\n", ret); + + ret =3D devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + if (ret) + dev_err(&pdev->dev, "failed to set wake irq, %d\n", ret); =20 ret =3D devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, IRQF_SHARED, "rtc alarm", &pdev->dev); if (ret) { dev_err(&pdev->dev, "failed to request irq %d: %d\n", bbnsm->irq, ret); - goto err; + return ret; } =20 bbnsm->rtc->ops =3D &bbnsm_rtc_ops; bbnsm->rtc->range_max =3D U32_MAX; =20 - ret =3D devm_rtc_register_device(bbnsm->rtc); - if (ret) - goto err; - - return 0; - -err: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; -} - -static void bbnsm_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); + return devm_rtc_register_device(bbnsm->rtc); } =20 static const struct of_device_id bbnsm_dt_ids[] =3D { @@ -233,7 +223,6 @@ static struct platform_driver bbnsm_rtc_driver =3D { .of_match_table =3D bbnsm_dt_ids, }, .probe =3D bbnsm_rtc_probe, - .remove =3D bbnsm_rtc_remove, }; module_platform_driver(bbnsm_rtc_driver); =20 --=20 2.37.1 From nobody Sun Feb 8 19:55:32 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011046.outbound.protection.outlook.com [52.101.70.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D632288CA; Wed, 5 Feb 2025 00:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717165; cv=fail; b=KcYqAiyFL6hKMQCr8XqfXnIBfxwi2aFJn6l09HHI0GOJv0gqbPx5jhIV9sxrDNNt3U99OpvRdtWjHsAJW8mq/ZJSE2fyhQxXD6a4HLdefCkZowPBqciLySUCes945dDkG55dtplzoS2ZlJgct1uHuGBta5ywwKW4RAsQFSw2rS8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717165; c=relaxed/simple; bh=BO8Hwal6yUEtmatjGxTeE8CGMKa+r4910TYtu1OW9Cw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bRrshoiE8X/bLmrWwshDyEE/Aciaf9k8dpf5N4QaQoZiuNqgxGd+078DTqcL1BvWO+HLd7wKZm21Wl+WR9Cb2oRtmZaTSpWz7MUHyloXIpFb0HSVK3GxOmDbnC+zG+wtFYuVGZtgflUr01hmxPqatg3XWSC6AXD7qXrtDehL4bM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jpP49Yi1; arc=fail smtp.client-ip=52.101.70.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jpP49Yi1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hF8jQHR1bHpGG7DBMWG4w3dibEjlI6xmYMtp9LizNLzqVEpVShVxsK/P7yi+jAMA+G1oEtckq4bUg6jsXubb7aB2UqT8LP6ghhRb9avIcyRrXuwa+myDF9Gj8PyD2LFPOFhT7ecdWodliU7C0BuKg0+r8duJEWKgtoHff+uz+HPtCwogkdY6QV5fHNKF+F9xRBN2am13k33Q1AIQKm7eT57pyigS0k8JSuZZnDcbwd98ehoQ4hnegB64IElKvtZFEJ66ezvJ2xC21au8t+1vFgfM9biMT6imqJTVXIHYEucRHzLQgbqtCre+whbfTDzfIPFkWu2EVDM7DPc11qVFSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=WMdWd50jrOVMQcKddw2nlMF8w4S+GQBYMZ/TvtYCfmtBvRiwYhoCPChfxOWmOe1+V0gM/K6nJUxy0CM1+MYRq1VsWeM2Ya6E51qZC3a83MjrzdIYAIGeiYIfujs+eozcvAQ8nqLNNVEJZ1dElO2Ocei/aHl697psv6Chi38iRy9tBcySN0VIUI3i+hm4yQWUXKPzf9GNcpWrTNwgUGi0Q8wqznJsytrcNWmEB/jptOLeUePEoDZY64PMvUk12xCum6UIGVA1fZDBqGedr4p/ZkBgGwUqZLklfnzK7gary5BQ4CMp8yqKZbYbni1cBPC0Uk17ihWwDI9TjFmEAIkRsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=jpP49Yi1f/uJKBF/HuCKyH1176JGLscSmnjV4HizVqOpDN3EYSVXdKRFhiOd347ukXPhRqPzRo4N48Udj3QDyXX2IfxTcpHcmBwU+qKfbeeD0OD4JQR1tUKUhTlMq/4JV1bp6foAm/TN1rQUpRZxznZvaEcN4/vpNY/uy0kSv1mtfQHV5m3c/X4J9Bv8G+iP7U0P1Gz8f6+xPLxrWTstKD7/UBTGpt1zV7U75HvO/FvplFj8mWIxsPOLnkF/ZFJjMK2uzbUOWwo6q4pB9Vmn7rIVI2TncRF2xfk5L9flIpL41JzP5zpGcNj/lYBlogLk9nG5ysSRzQT/FnCK+NFmjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:21 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:21 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:21 +0800 Subject: [PATCH 3/7] rtc: ds1343: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-3-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1119; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=yYeVC601Fmqm3h8IRsE1e0gqqkwuyZ6uKwkA4brZ+6s=; b=+jZfInCaWBrh1hOlNrO+2f2hgBbfBUBVT/+siBpwsFBqPZBBARXE+oQbSs2ZdbRSDvheP5xec 3EQXrX8A67WANLhoZl/HhnkDbpTNAaVHp4vwnuMDgWKmNZ+/5J+sQJ0 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 91fcd344-6bdf-4d9d-9292-08dd4580537a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VVZJaFBCSnRlM3BMMGhLL1JEajJKMEcwUFVpWUU1eFVGVVBHTGpONVhGaTht?= =?utf-8?B?OEJJK2lrMGlsOVh3YlVOQUxxTzQxSy9TZUFnV1dnQldIR3RLNjhnd09aL1o2?= =?utf-8?B?b1dYQWE2TjRobkpOZ3R4Qy9MUzJ3ZE01QUthemFjMGExb2pZdHAxamhxa1Ur?= =?utf-8?B?cVNDbTUyV1dReDVHNFJlRnZ2NjNFVU9qU0t0M3VSZklQVEFTV3Z3Ymt5bG5W?= =?utf-8?B?bmdRYUFUVFYzbDh2aFZTQzlwYjZyYXdPZUh5VE9NbXVUdUFZbXJLdXoybmJT?= =?utf-8?B?ODR4K0EwVU9Sb2pMcE5DckUxemlwRGZ5ZzJsS29JWTVjTEdwOE5mdmNGd3RZ?= =?utf-8?B?YS9CT25NaDdVVzBVQlZncVc4Z1RMd1dwKzkvWC9rai9pVFlOMVpwY051VjJ6?= =?utf-8?B?bUZZb0xIK1QzNnNOKzl6VWVOZ3dHakNVZDVUSG1tbHJGSktzaW14N0R0MmR4?= =?utf-8?B?aGlpdlJNYi9WNWMrSXNheTRyTEs5SlFOZTlzblFSdm45SnVUWVlvdXBTL0po?= =?utf-8?B?WW40MHBvUmQxbDlRMHNZeHJsaUZnT25OQUQ3OWljSm5HQjFkd2Q3d1Z4OTdU?= =?utf-8?B?emkyZC9sS2kyaEJEU1kzcTJZMFZJbG55LzhHWURxdHhOT2VDZm9iL3BVcm50?= =?utf-8?B?cEdOYkFjNGpSN1JTWmhGTFQyNGpJaUp6RDFBU0o5WEZjZW9HNXhPNkhKaXF2?= =?utf-8?B?cFhwSnQrcnoralErSGRZMXhsbjFKZDNDVEdnM1IzYm5MNHY2QTg3S0U5cjNT?= =?utf-8?B?OW5CM3BtWjVVU3pBakNHSXJwUHBiWjcva1FRQmpuQ3ZsMHlzMlQ5b0w4OUh5?= =?utf-8?B?ZE9aQ1BqbnVnY2tRbnhUK2FEUldSSjVUeG9mZjhWQ21WMllCdkYwaG5vdEg4?= =?utf-8?B?cmRkUU52VHhUSTErZy9iUW5BejZWekd6aHhWcnhUbXNvMjRwVSt2TW51L1h0?= =?utf-8?B?VHJSeFJGMUp0QlBVaE55MUh1dEFJbnB6UjUrMFlkdDF1WkE1cEM2bm96SFVa?= =?utf-8?B?YzUvaHhUc2xqdHZzZEdZM0ExaXFkUm90RHhxbGx5ME9Nc2tUOVNhUWRFL2hm?= =?utf-8?B?M2lXb3pzNUMxb1hkVy9Ebi9Cem9UTHlBTHZxNlltMkM3VVlibXVPblQxYmtF?= =?utf-8?B?eGc5dUVsZDBZV2JnNWgvc1FGOEZjSUlxcXAvNVFLWnQvVE1lL2RWem9GQkQ1?= =?utf-8?B?Zm9GTERoM28rN0YvU21WemdSRDFXYkJQZ2dkZGhNeDY5dzVqMWJJVWNUYWVE?= =?utf-8?B?SVRhYm9Md1l4NEV4VWxYT3NtQnpySzB6UFdRTDV1Z2hzM0o3cnB3YlVuKzhv?= =?utf-8?B?dnR3Y1BteGM5eEZkNTczdlM5VUllTHFJMmVxcHpMY210NGdTZDRIMWkvaXJx?= =?utf-8?B?RlUzdlUxdlRaakxRcVFDS3BIbGs2ajRSdGNlNnVMZ05uOUV4N3ExRDZTTXFY?= =?utf-8?B?THdNSEh5MlJ2QmxMZ25ESU5oazJDTDlyMEJiek1VbGd5Rm9ZeFJRekg0UlNG?= =?utf-8?B?UlExQ2xwaXdsTDRPVWVlVXdHd042ZEpuRjlXODFVUnkrZ0xnVms4ZVJ3eUJk?= =?utf-8?B?dms0cHBZVGFjU29CVDd2dXh6eElCLzh4ZTMyOWJOL1JZT1pkejY5dDNYN1lJ?= =?utf-8?B?SVpRbC9aOGpEOEt0LzFVTWMrTnZoM1NISlVNbEU0SWdjd09ScW1ObFp6ZVg3?= =?utf-8?B?WHNaVzcrOEsvNFoxMTZWekxOb0xKZ2VRc3BkM3dvcThVaGgvcnRlYTh5STZ2?= =?utf-8?B?aU5ZUHdIb3NJREoyUVZvVUR2LzFMM1F2eGdQa0dNamZmbXE4UHJIQWZEYWJx?= =?utf-8?B?NmUwd3dTOEhQWGUyeHRXMVRKd2h6c3hqNUx6RFZLc2hXWks2N2gxZ2taT0xs?= =?utf-8?B?K1JQcXFoWnVBWVpBbUJCOXZhdTlwUERPZkZKL240WmZyRmZxejM5L3oyS0px?= =?utf-8?Q?y/d5JVJWCMKJC9THhHtEPn3vzLQBF/FE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXF4RmlkTkpnRGpnL244akpmeCtXNi84N3ZpWEVLU24rNGdibmtBa2RTTE8r?= =?utf-8?B?emcrb3hVU1JGendWcEY1SG9OYU9ncFVYYTVhMFN3Q2F5bDUrUndOTzRhTHg3?= =?utf-8?B?cGdHNmdUL2NMRHFPYzRpdjArKzRyTElMd2VZdklrbzYrOHEzcDJxVXZyY2p1?= =?utf-8?B?L0tzRjh1VjRBY0ZQVWRZSXBNYm9qMG1zQ1NYRnpVNklVM1AzNTBVZm9JVXhD?= =?utf-8?B?SHNhOHpQYkJieHR2ZU1kQ24waTBJNThUUm1iRHN4dk9TbFRWWlJJTllpRS9F?= =?utf-8?B?em5keGdqWG9XNGd6eE45VUV0MjQ0eUpnMzhLQThjZnVrZ3NwbXArZVlVQ1NP?= =?utf-8?B?UUlncHZKeG1qL01tUFNOZzRpcXZqa3FCRGp5dHNOWkw4YSs5eTBHeHozanN2?= =?utf-8?B?Ull3V1ZoMkRZQVF2Um9nb2NjOUlDUmw1aUxlendGNUQxMUwxdG1JK212ZVZm?= =?utf-8?B?cGlvY3oydGNXWkZ6MlFsN3JiQ2dGUGhXUVZJNGdyTmdSLzk2TW5WT3hhdkp0?= =?utf-8?B?L0Ruc1pBaVZicVRDNm1id21uUnZqby9GRDV2OGJtc2VJN2I5UEY2YWNCaTM0?= =?utf-8?B?SkxxK1VWWWllbHBydU5nS0RTUXl3NnFZdXNOdmRvTURlZEhtQVJyOXRXcldp?= =?utf-8?B?MUxqTk1hVHE4dGtkWm1OSmdtRVlnakFwZ1JPODhTM3JXNEhGNlpmbDdId0sy?= =?utf-8?B?L1RtRlhXQUhFamo3Wlh4RXA1OHR2NWlDRE1IMjM2eVdZRld1RXdoS1RxRHlH?= =?utf-8?B?a1NCNGJYQmsrMGV4SzlialJpbzR4d0ZFNFptZHFPWXh0MkRaRVFncWdxaFFN?= =?utf-8?B?N2J1WXlNKzJsV0JWaUprSWFpSW9lbEFqU3c2TVVpMXl4WHN2YlNwWnhMTjl1?= =?utf-8?B?dTBQWmxhWndiN05idS8zV0xRQjBCOWNQUnRkWGRLa0dVVnBOa0hJckNrSmEy?= =?utf-8?B?RG51dnc3Si9JRWRRbGRTckRHUUt0MjlFU3BxRnMxZFdDZmFDZTZQdHVPV2dr?= =?utf-8?B?SXJRZ0J0Q0hnS1NJMWZkYTdhNTU0djk5eFFkS2lxQjdNbkt3MXhpTXVWTWtU?= =?utf-8?B?V09aTk1NSkNSWUUzWDJzV0VCQkZ6TktlMTZaeXRQb3BOak9QbHdkbjhOWTNF?= =?utf-8?B?bm5NMC9BUXVDcDVWUlRmdk9XZ0M2UmRqOE93bHovN3pYSi9IZDRGQit3cDJR?= =?utf-8?B?YVRDMEYvMGZjZXhuYVpLSTRlM2M5dkR5ZFVNQUdWQ2RpM1BnMHJDcm5ES05L?= =?utf-8?B?QVRJUVpqNnpGQk90dEZ5czh4eEcxc2IwVDFESTJlVDRoVmZqMGk4R1lIKyt3?= =?utf-8?B?MnZwbHJsN1VtRGRJelZIVDNLU2R6NXFtT0EvRkFUcnFWckdRNE5TaFdNZlVJ?= =?utf-8?B?MmdzcThaTy9yMkVOYlM3Q29MRUgrS2xRYjBvM1NwOUdZdG5wazQzcDVPaXZD?= =?utf-8?B?c0ZwU3ZqSUNua3FUVjhBcFJaRy9ES1VzOEZsMXZDVlBZN1FPTVZnem1WcktZ?= =?utf-8?B?bW1UbTdYVlZiK0hGdHJpYVhVU2FWam5iUmY4T3BqQUk1OHhuMmREb200Q3RH?= =?utf-8?B?ZHRXSWhmTHlZVWVNSE52YTBHb09YdkdXMXpPcE9KY3UxenBNdm00bkk0L1Ra?= =?utf-8?B?RnZlaXVGbHdsTWFLelQ5Z2JYdktIUFp1RkNmT2JZTkRwbWdqTm5EOTQxbDMw?= =?utf-8?B?dDRSZXlEV2U2Zk1ISUJ1TUlDYnowdUk1L2Y4T250dVVDdGt3V3U2cmNMOUhq?= =?utf-8?B?VVQ5L3UvcDdud1RBUFFNZkxPSHRYdE5Ecm13elFUSUg5Y0FGMFhrTnhzSzFQ?= =?utf-8?B?NG83S0RXYWpsWDAzQm9pRmJrQ0VJeXMzNlN1R3g1MEhKK1NobXlBa0FwSHoy?= =?utf-8?B?T0tSQ3ZFbW1IZXNjNHVISTBrNUFPR2hiU05sTm1ISnBlRU9RZENHN1NZbU9Q?= =?utf-8?B?QkdTUTJHUGQ1TTlmVUd1RkpSeXNOKzFYV0lheEFFWjBzV1liM000QkJYMVdr?= =?utf-8?B?bVNFdGNiTktFWGNPTWdmY0E3bnV0RjRGQ1JBWk0zK3l3dTdCbE9Uc3NFcndr?= =?utf-8?B?TVZaYkRsTUkrK28yc25lNkxMUFdEaFBkdTFYY3ZPQmNtWlFoVEZEeXExaUQr?= =?utf-8?Q?mtnIHzzSumwxQ01Fjf8o8xctj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91fcd344-6bdf-4d9d-9292-08dd4580537a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:21.6295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPliWJlOGwUsNudt58OJ3wpS0t9EwlWYAW3C9ombczuPWBe+NO0MXOqpoeeWMO6eSjaJO0D/+jY1Ac3M27AgVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-ds1343.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index ed5a6ba89a3eeb2a0b9d6dea3c8b3d40aa2cf317..aa9500791b7e0300b150bd654b6= 9c74f3e5e6e6b 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -427,18 +427,13 @@ static int ds1343_probe(struct spi_device *spi) "unable to request irq for rtc ds1343\n"); } else { device_init_wakeup(&spi->dev, true); - dev_pm_set_wake_irq(&spi->dev, spi->irq); + devm_pm_set_wake_irq(&spi->dev, spi->irq); } } =20 return 0; } =20 -static void ds1343_remove(struct spi_device *spi) -{ - dev_pm_clear_wake_irq(&spi->dev); -} - #ifdef CONFIG_PM_SLEEP =20 static int ds1343_suspend(struct device *dev) @@ -471,7 +466,6 @@ static struct spi_driver ds1343_driver =3D { .pm =3D &ds1343_pm, }, .probe =3D ds1343_probe, - .remove =3D ds1343_remove, .id_table =3D ds1343_id, }; =20 --=20 2.37.1 From nobody Sun Feb 8 19:55:32 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011031.outbound.protection.outlook.com [52.101.70.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C13A227BB0; Wed, 5 Feb 2025 00:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717170; cv=fail; b=KiPLZuUu2c0aaFZE7HRNA3awR8Zqaqr2gkfxyh8wkFYaqu/c83lrnLkE7NbZWphd4i8e/ZVKwzpg9O82VesYOU2w0t0CIAHfQF8FsIpytO/NKsSKKGIAzBEUxEaY2S8svoYBRUcuAYD+SJSckwQlUmlwp93LwSGU0PIcqMH8lJU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717170; c=relaxed/simple; bh=nnwym7ls06lSOY7oUmuOW06Md6pvJJ+wNUhTkfpi8pw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PRBUhZfNlTXmmCvsxfVQ0ayUO8fK3EwIH4hNo4zonpEKuhJvVryb5TyVCILd3Oy2F5Or2kuLPLWWrmRTpkdF9SU+lVjr0nXyWO9u2bG6WJjOeNt4TakSeo/jGMjA2XxmWmQmNVJjbqtIvqXewhxylD0jR6jNd1OFRNdCQ/bdsVg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=CfX5SlQy; arc=fail smtp.client-ip=52.101.70.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="CfX5SlQy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KuJ5UUIAo9d9+jYxjdXgOrcgHjlSWYNpIdz566YTDSQEtqIvPK5XXyqNIn6DztO4Ri3rdXQ9tBc+Nvt+udk2AchoQE/fd5mpog4jOlBH3NTRYl8hMJOCNefX2SO1Tx1jb3HshxZnft5DZzz5Xi/ELW9pbcmNYoRceMOMSAEZAKO4wMb8AWnLS1ZpRycEj4dgR7P2uuqvlR30f7dv5JW/duj1wPWMPzjKBI4Fphcd8gGT8XjQEKCL6rxmcw0a16tVpi2gzDJ4IOF9eVTSDfX818dGff9ElMkWqSVxb+wOG3idzSHvZS8QJBIdYAtokJbAYmAgnEaskWrFT80Fy6I/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ck/KyDLZ0Hdp7ue3uxbCp/8Bgg/pRY0hm93UPm01SY=; b=LG0nCpKnuu9PAogxFN2sajN9+JPaB5M6qRYwZhc47ollARBOam8LfJ6uCexkftir4TMFRheBed27KqYYuaHbJuJXje1TwV7Oc+0+OnWkWCZD248ghcwCT8l1Fs49fhaVNli98zlBN7BGnx1aYxLSahK6Nh93qehsH39YC5591eoWqSTbdo1Q6zB+N+lTXz9lBj9R1VQ4GT3bcXsvLRWghBtGdUjtvc2kBps0HOxflj35TZsv4FLg7+iY1Zpg28d7QZAgPnqk7h3oXWcHJgi5AQ/pmTRrxggNtxbn86JBugO237q5ikACFLfqmNbks7fuGp2XTDYsorw0VsWyv29aeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ck/KyDLZ0Hdp7ue3uxbCp/8Bgg/pRY0hm93UPm01SY=; b=CfX5SlQyCVmrqBHhShACJI/gw8vkwEFvqMlWlxPis+c+eqTxomSCD0FlNpCV6RXg6HykimPu9sOiorbmy9n/oO86Xjq+tlMzzDzOwLWLcjR8CtPGHReJKPI34B1oFbSLhk3R08qnUcvrH5djsjTxB6G/lRajAvt2ZB2ortv38dTsan5X5MKUtYseFViTi9XDYZ2N6z2N9P7NhvBuAo+aVoIEtGodAZvnpfwoH/GUR6ZUbI6UqWSnCD7bZLLLpf2BUMK+017pVJEIcX7cvVC/78CE1KlWihgkiJiWPfLvTVhHSV0qEqnVwtMTkfbEzJHRIrZFBk1iCR5TTbphHp4Tqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:25 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:25 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:22 +0800 Subject: [PATCH 4/7] rtc: pm8xxx: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-4-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1104; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=bSEqkb62Ag5Dw5Zs7cv9/9hd9K53rCnxW5QPy69d5F4=; b=L42mVUKdk2pIlYxrwXtM9UoydiBfMxcoLJG/qK507hD+NAO+hlBnrqcre2UHyB7TyVQhpASlf v1197RGA8YYDYNV5dTDNFTz5VDBwM/ZBvnjvFAQM2Y3RLB/Imv8CwYL X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 249bf700-da62-40a3-2051-08dd458055c5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmFSU0RCUitYSkZhbVYxbFFwbkpTT1g5ZjMwRndBTnZnUFdXanlZZy91U3da?= =?utf-8?B?WGRBZWxZT1dlZ3BrQ0tkZzNsbG5RUExkWldBWXhqL3JSZXRyQUd2VUczbDJ0?= =?utf-8?B?STlwd2tmY29TQTA5VDNISzF5REQrdTNuQXA1OEVab1kyOXhKdjgxWjMzL3Zu?= =?utf-8?B?N2RnQTVaMmdaK3VIM0ZzNzVTTk0zcTV0bW9kQzcyMWg2V3J6aXczRDlwdHVq?= =?utf-8?B?WmpZUkdMZ1ZhL3hYUkk5UnZneGhYaEtDaTF3OURKbEMrKytLV3poWXdKaEc0?= =?utf-8?B?VGltanBUREpKVVNaYURDRkQvb3l0U0J2TFBxTGc5ZUhudlBSS0ovQk04ZEx3?= =?utf-8?B?S2lzRkZQc2E0Mk5udG9xVmRYQjRGMnFFVzBqQ3QycEFGNjFycXdLTnhtK2du?= =?utf-8?B?ajRmUXlSQ2ozaXpoYzNVeVhWckRDb1VrZ0lJc1N3WFg4UFBHenRtdlVCWEZy?= =?utf-8?B?T0x0Zy9UaHVkLzhoVCtDTmFOWXVsWjByNWxEUXlUOUVBOU0zcXBOMDIveGVl?= =?utf-8?B?VFdPQlpvWjg3NXBVUmt1V2VGL0c5ME9NMEtSWExoVzdyeFFUSUJ1aEY4b2Vi?= =?utf-8?B?NUFaUFdCOG1HZCtMSjdwZTROWWcxc2NablFFbmVmTjQ2ekJpcG51TGNBNEtm?= =?utf-8?B?MEpGVmJvUkFRalYrVGFWNXN3WUVJdWpwMEpHWXVuRk85QjdxdmVMeXdWK1cz?= =?utf-8?B?UDRlUTBuWmZSb053SmUwak14QXpKeVBCQWErLzJjc3lHdkdGZDAwd0VKZFNQ?= =?utf-8?B?UVF1WmRTbVV0Q0xxRTRFdkhOQW03cTUzNE54VCttcDB4MXdWUVg5T3Z3Skky?= =?utf-8?B?R3A1enpzQU4rajBJRXBGcHJ6Tk1QeHdHeTZHdzRWeHNtRXlVZTN5YXJyc3or?= =?utf-8?B?ZXY1MzhQcGJGK2pEN052OHJjTmY0b2ViMEdOQlc4UVNQZW1MVEw3QW9JTlNQ?= =?utf-8?B?eU9OcUFyZzAxNS8yWlBIcDVSYklsSEU3N2VxZHN6cGpTaWx0bHlod2ZGemNO?= =?utf-8?B?NHBJb09CRkxGeWx5WjloY3kyWldrSGRVQ3BtVDRBSmpVSzBjQjIzWXFFZU1h?= =?utf-8?B?ZVdCTWpFTVI4NXpaaVFqRUJKY0UxRlNYR0pXNUVKeVF6V1B2RGtiNDhpYTBK?= =?utf-8?B?NGdPaE94VXkvZEdPeWJ3YlJXLzgrQXhBaHBxOE91WHVyeE0rOHVLTktYV3BW?= =?utf-8?B?L3YyejMrT2Vac2ptWGRON09pd2hnanlBVmJtNHVQdEYwd2VvbEFObFZMblFD?= =?utf-8?B?aWQwSXMvNjRGNEdvUVFNYUFYczJaSzhCTEl2cmVPQWlqUlZJS0dVTGY5TjFQ?= =?utf-8?B?a1BrTlJOVzgvd21MSlljMmdMN2ZEckNES2oyZVM5M1JKalRqVmRqR3pOODlV?= =?utf-8?B?dXpYUjVYVUszbTgyQm5HZUZSKzhudXJMRXQzd1VtTkxXMVRsQUtnWUl3VjVE?= =?utf-8?B?bWdndDVudnpsTzJYSVBpRTBTODdQV3k1Z2FOTk05RzE3YlZsaU9XY0k4a3ht?= =?utf-8?B?aXM0SERlNmJSQlpBV2FDNWRvUGgydWdUcTVnUkVqOEVxalg0aXRmQ3ZiM0dG?= =?utf-8?B?SUVTZ2F5WDZBZy9RWUF2d2ZCalBab2RTR09qNkZvbFZIOUpML3RZWUtucEY0?= =?utf-8?B?RTAxMlZRSU85YkhqbXZURXBjTWxhdVhUTlBIUVllRnBJT2FHS2dRNXE5dUtZ?= =?utf-8?B?SE0yQ21pcFg4ano3UXlhWnRKM0J1ZHE5eFFIZmlTeWY0SDZIY1lMdHFoWm5r?= =?utf-8?B?ZWoyRko4YklCUWY2aDFNbFd6cmtWNHdCblFqM1QxVFRudlEzR0EvZVVBMVND?= =?utf-8?B?bkRuYWtEaVM5VCtlbTFoVUN3N2xPMlJHZVJxNFBGcUxJQzlBcmNncXB3dWpE?= =?utf-8?B?S1Bvb0I1ei9xUzloQUhwT3BpRW03NUo2Qit1UURGTFN6dE5CeEdXbDdRMFdM?= =?utf-8?Q?F5VP8gU/oE+9l94uWiHOqFASozbW0YbJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azFUTlJtSy83NWJnTk1lKzBjaUt4d0g3WUEvc0hsN1Y2WWUzNzh2VjNSdXFa?= =?utf-8?B?QXFRMTFZcmZpSFk2SGtHWk45WHhOcThoLzdaWEpRRVRIQUFUNCtqdCtRN2Zz?= =?utf-8?B?M2h4eXFXTXdvY2J5Rm4ya29PNFhPVU9pdENoZ3lOTlRnQ1BWZVo2YnNNQStu?= =?utf-8?B?ZVE2YmNVU2lnSlRJdHN2Y1RiMzVFRmZOVGV6ODBUN0JtT1p5NWpvR2xMdExW?= =?utf-8?B?cVlRZG44azFoZ21GN3VvdFUwWUxnNEE4SVlXWjByeVRtbUJieno3MUpkTlB2?= =?utf-8?B?aGgvSi9UQVVRUER3NExYVjBpSXJSaE5jWlJkb0h3dkkxaDJ6LzI4OUxiVWdn?= =?utf-8?B?VXlxYThXZ2F4QVkxR3FSTjZlQ2NUTitLVy9EU0hoTUdMTFJ3WTlQdEY0M3kx?= =?utf-8?B?SmFCakZsRG03ZUhRbEh2d1hDeENTNU5TbFdocEZLSjRNWVZxMGRGZVhkcFlM?= =?utf-8?B?MHJ6SmZKMTNwT3ZBRDB6TXpCcUk5QWxSVWtNWWI2YU1Bci85d2o1TENoMkNp?= =?utf-8?B?ZW5TK2RYSnE2cEwvRGl2TjhRMFY3VnBURStGampHTlVoSkkwWEVtNkxtS2hF?= =?utf-8?B?UG43c0NWMmREQitvQUNWT3pVZjY0eFNUS29mWElQS0p0K1Z3WVRCdEp2WWM5?= =?utf-8?B?Y1o4aUJMclc1eG1Vc2ZmaW9DVjdTYWUxYkFaWm9oWGFjVEVndisxN2VpemVW?= =?utf-8?B?cVZ3ZWVaOGdUeFlzMWp1Y01LSWJ4a2J1a3JVbmpsb09peW9kbmNSWFZtMnMz?= =?utf-8?B?Qlpnck94b0dySW04TzlVKzNkZTNuc2pIakEzcy9ldjZhakk3YlRsOVllcFJh?= =?utf-8?B?eG5ESFR5OEszU25vSHdHMi91bGZLY0tLUlUrcTFiNEIrenpNOHhJbUdDdmlN?= =?utf-8?B?RXd4L0pDdHVBL1F1ak1ZL2xXNXNzUnQ2NUgxblZ4dTFHaEFucGwvUGJ0cllV?= =?utf-8?B?UGJtamlsSjFBd21IVEVhaXV0YVdxUm5MRFlTaHBTZzRybjB0bXZBaE1ETGJj?= =?utf-8?B?bUg3VHlqRGMrL2JxK2dvdmR6dGQ1WGZUR3d0L2FjNWlzS1o2MGdjdklpU2Z4?= =?utf-8?B?Y0RGRm44OHlaMjF1WVJmTE5lS1ZRTGwxZ014MklST3FyMWhTMTNhVFNGNDFO?= =?utf-8?B?N1NQYkdjekFOc2NjL1BKZ3NlSXBqKzhKTkdqa1pNeW53SVdKTjFEay9ON2Fa?= =?utf-8?B?ZWptUlMwTG1HaDFsNW5uSkNvd3k3OG5xR21ZNS9GdE9lc3VSZ29PNEpoL241?= =?utf-8?B?Y3QzNE1QU2hOSXIvTHNsYWZTdnlCdXJ6byt6T1pwdURvb1dja3lWODYxY2Fp?= =?utf-8?B?cmswcmxXdHNKblZHNXBLSEZGWkZST3pQM3JSNEEwWkJmZkxneVhyYzBzWUxQ?= =?utf-8?B?d1Nyd1dPdHBFSGVXTzNaRzJXdkthYzdSYm9lY1RvSFB3Q0ViVDVjTUEyc2Zj?= =?utf-8?B?S29uWFVjYjhyQ09lWFErd0NJdVRQMENBcUtQdjNqazg0QXF5WnlJZk9jUG5a?= =?utf-8?B?VHBFSWtTZTIyNjV3MGZKeFA2ZGhCWnhSRHdIMDJxbXBLQVlHaEY5bzBwQy9v?= =?utf-8?B?Y01GTHlDT3ZNK2VSM2piNngzZ1pMaVNoQUFRZ2tWdXhNUytSa1dsVGx0SnA5?= =?utf-8?B?UXFuU1ZHUDUzZGdwRldsQVA0eHBHRktvcm80SDhMbWNQUFhURzRCVVdKT3lC?= =?utf-8?B?cnpacm53WW5pVGpUKzArM0NYamhTdGoxTGNkMHR1TkdEYk1La1B5ODR4MGFh?= =?utf-8?B?OUVnWldIMDdTSVIvaHZSRWVKZTB2Mms5NjJLOTVXUzZqeFJoelZuMjVVUmZy?= =?utf-8?B?cUJLR0ZsaGNWTzl4dmVvd0FHQ2VnYnNtdjd1d3dIcGhkcGJmSVhVaGJmVEND?= =?utf-8?B?cWE4S3UzNHRUa3lBbnNNK2xhMndUelBPa1g4cGdHSHViczJUb3EwZmxvdXN1?= =?utf-8?B?ZEY2bzg0RGpTOXcrV0NqbldJaU5EUkdFU2t3eXJOM2dlRS9xalhMS0NESWwz?= =?utf-8?B?emV4bWUrbjdaY0hvd2w3QTF6S3picWJrTGlrM0h2c2drdGhzOHRINWVaUkI3?= =?utf-8?B?WnNZNWhQU0ZFQmorSnVkVHNUTm1IbG1jdmJSUkpMUEQydVBsdlU2Y3R5dldN?= =?utf-8?Q?Cod8PLPIEvrs7J38ZoKJOOf0v?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 249bf700-da62-40a3-2051-08dd458055c5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:25.5034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vhxnzHxEVq9spQJvNG2Oo/QkLYeSZzav4wympD+45yAGhqp9UA0cze5+E7h2XnnIFafMUUT+VLc3sSxVdQBIVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-pm8xxx.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index b2518aea4218f36ba24a5fb660ed11c1dd78940b..852d80188bd0b5e75882c7945f1= 66162fb039507 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -523,21 +523,11 @@ static int pm8xxx_rtc_probe(struct platform_device *p= dev) if (rc) return rc; =20 - rc =3D dev_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); - if (rc) - return rc; - - return 0; -} - -static void pm8xxx_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); + return devm_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); } =20 static struct platform_driver pm8xxx_rtc_driver =3D { .probe =3D pm8xxx_rtc_probe, - .remove =3D pm8xxx_remove, .driver =3D { .name =3D "rtc-pm8xxx", .of_match_table =3D pm8xxx_id_table, --=20 2.37.1 From nobody Sun Feb 8 19:55:32 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011031.outbound.protection.outlook.com [52.101.70.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31BF228C81; Wed, 5 Feb 2025 00:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717173; cv=fail; b=oxDY3hj1dibxw00JyZtRyQHD4cLT3IcvLYTJ57GPXwKP/3zDdgpdepMoBdUQjIzfWpRL6Zzlzp4J8D2eiHYA4UrREsy7ksYN7slYPGhr2FMTgaU/3zalQTpBMljGH0u/f0mWzGFyi9MqUxHlX7p9WWtnYea6UG/6myUdf6h2OB0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717173; c=relaxed/simple; bh=gHY2BHYvxVzRpPgRTgubI5fi64I6Ubu6MUDTYIfuE+U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lC9Ai4G13tBTGNONuJQTozEWYqjfxJezBct6SJ52bO4ldyy4ZCjiH9bUy+bLqAxy3DFgDWlY0dLu4rIgXrZ2WwxmVoQG3MQh+tTwce3bCfGnfCHjTCL4c8XaqKOnNLH5N2oLzJjzQXLcbydTRbEPXw/GFjTwVWPJfLSXBZ+HlWY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Z+fSu+gt; arc=fail smtp.client-ip=52.101.70.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Z+fSu+gt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cOrk6y517S4CC9KoI4JZc9PwIm2gfEnY3RUeF8R0QS/B3uNB+2ikdLE5PoU9V5v96R8YfsFSV1PGQXR2/mvCjVopadpp/G6GkSsWlIfEHGP9gNeuIbwLJ4+oKi+Mdjtt1ZeY2h2wog8pmKBAxVi5ecAxjVJtNCEQbyjJdDzC4R+f1nj+AgQbGdc1V/5aZbo8dJMMwaZP25oE01IambeDQWeGwnyk0u/Bql+wCzfookFGlG3tmWETzVn/Wplf0iOlkgoDwj5XrT6k0k7id9xLL9P7gyt4mYf6Mfczf/KLm5izvixsqbQk1W2P9UerDSzjzg8BF8+urf/G7A90kEoJ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=zCZlSoKSkEdKsdNMNDQnjgWHaeei49zm2FYwY9dbtq90TqBqUUZaqvMFOpYJ1nNea1J2xHnYb8LCaHfkbsoit4fFOEMnYFC1SXQGPh0G14EG2sF+aVRpTH0x+uszEGnTLqm4SyXlR9TCpKhaoy9xTWIEfjvJgSMwgmf6IB/4WLPN1lifBh5rz+tb9F+pZczM6uW+AOfnTdOobTMN9IYiX2qBukRGdB1MAN9X/ZhK5Kk49KyQsijCEg1WDaVJd9JMIFM2lE2w0UkJb8xyfnLgWOPRDhyvYCz1SqMJJqcql9QHQwoMk5BR6dLhEbOb2fJ78ucDZ2gW9VQw/t62EXA9MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=Z+fSu+gteDrotGKIgbOYNg+AygmbSlPGExKbLnBL8AEMimU2Mr2Z1E/B489yrs+7luKPrQF4nkDZRfV+R0AHK1k8k4ea3x6vVk+97pcZTwPODS37bcYLIrMtHrVueMn652LRrUN1gwpzmVAT8E/5epc6sKI6i255W3ad5nNvDgANEAHMD1hOQDtXjhOGzcDJXwC93ZhPMWPlxAJ72XtEOCYKz9o4G5H+dBVFoEuqEgrurdHYY2D35caL1DbDy6OIDdEQSaxZRbHJ/46LdZuWJRj+vIhFrkHrp0WIdgnCPIgOItHLyRuBTI9HAUMQEO0dsREhcAne1z1cyuSgeV/QdQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:29 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:29 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:23 +0800 Subject: [PATCH 5/7] rtc: ab8500: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-5-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1597; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=rISyYCuz8yJRuvtcynWqye8n/ybIJ7leHy6yEB7pHHU=; b=Tgu5l+wBrHYt6ouquPi1I0clsMFqBW3OGNogy3BMBCDUGJA8GxSwZLPzDzPbhZWJMga4JUl/G w8z4LMcp+qeD/T/P5cfUUm//g/NyGjV8k68wi/yTv036RlarYvDkDKZ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: d2c1cd7c-e9b2-4692-3dc2-08dd45805810 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RVdtY0dFdUIrbXR3aTlLRHdwcW1IZHcxd2NpdEdPVWQwUFV6TXJRREFZMWVN?= =?utf-8?B?clpPRk5rSDl5UlA1TFZuYjNXd2VWZkJ3aHl5VXJOc1dWa05PUWxjMEhpRUhj?= =?utf-8?B?SUtjTitqdkZiSDFyR1dOVnVnV3R4cUI1UTc2SEVNWFNUbldUSEVVbXRxaVRM?= =?utf-8?B?bm9qK1JHTVczSmtUdzltNC9CMGtObWt0NDhpaEM2QzA3Wng0cXI2cVZFR2FD?= =?utf-8?B?UXN3aWVVS1VsOXQ4ZDZCY2VLY1VCRlJXSDg4ZENQSldxSEJjUVkyVkE1ck91?= =?utf-8?B?d2wvOVBtOXQzTmpjb2xTTEZQTjVzVERUMm4xck1xU3JVN1hoSHFUMHlDd2Ra?= =?utf-8?B?bnAzSldJdU1US1BRR1dCWlUrTDlveHFnTTAvZkR6bS83U2Q5ZXlzTTNGaEpI?= =?utf-8?B?VFUzQVlSVmtrdzF2eXhiZ0hkbG54ODZGUFZJb2FhUU10RlpqTXhLM1g4NHdS?= =?utf-8?B?WlNQaXEyeUlvY3FpeG1sV0R3WHJuRUYrK1NqckNaUjNFMHZmZFAvYkpVcGdu?= =?utf-8?B?bzFyU1FyT1ViblkvR3BmR2NsZlRBWkRtc1J1NDFqWTZ2YkFkSmZ1MXFLMUlt?= =?utf-8?B?b1p6Q1B1MHF0NnhuZmZoRjJ0alI5SUViMEpybTU5QUd4VHc5NXd2c0VWUFFL?= =?utf-8?B?QmJ5YzhKZ3d1SmpiRVRlUzFkSi9QaWdna0pOMUJrY21XaGZuUmNPb2pwRzhS?= =?utf-8?B?L2FaN2pzYnc3bWRBVER3eWgyUW5ONHc3VVpNc3JWbXlIOU9TL21FRUJMdlJ3?= =?utf-8?B?WUhRM1JldmE1OHp2MUp0TXgxdXlBRkZBQlNXWGVZSXB3UHFxNy9XMWhZaVl4?= =?utf-8?B?THFWbDJ1YkRzVUpVckpkWWE1ZXo0Z0R4bWpROG04ZzZKa3dzZFJhWFlkdHJk?= =?utf-8?B?cjcrdTZQMmN3V1NXZGFGcW5BcFh0MHNYbC9Oc21qekV1KzdWNVFXdklkZzFI?= =?utf-8?B?dlBjZHlpNkJrbHpTbFFqSnhGaFJYRURlSGNqZ29XNTMwand2eHZNWFFtaFdQ?= =?utf-8?B?ak1RdnhOYTl6Z3JEUHlBNXJVV3REbFBqekhBTzBFNW1vazRXa0U1SVhPMzhT?= =?utf-8?B?b1REV0tVOGY1Q3NKZFNoZkNaUWhMaDRKS1JQTEJ4eWFLSlR6VDl3VzhuMmZj?= =?utf-8?B?dy9RRE0wSkJzOHgzeVpMWEttRG9NVEFsazd3MHhSUnRDTnVNczA0eFVGQmFC?= =?utf-8?B?SE5wUlNRUk9KcmV6ZDNOU1JORGlQZml6aG5RQ2hHTmxsd2FiREpvU3FyUVhB?= =?utf-8?B?aTZBenJVTEtlejJWR0I4K2ROMmNrWnEwM0EvQ0VydVBYTS9VN1pZekdvbFhN?= =?utf-8?B?VWlWR1E2RDVaMHZhUVJEWFRJVFd3NnBDODc1U3lFaWRyR2hPd0pOdTkwaDlu?= =?utf-8?B?VitpL3pLWGxnZFNkOXkyUTFab2RXRGRablh4c0QxNTMxY1VZTFdTNUEvR0xP?= =?utf-8?B?QVUzMGZ0cE1qNzNzaGErSlR4bzhBbmVsOTV4U3IwdGRSQUF6R3Bib21TbDgv?= =?utf-8?B?M1dlcmRUNXEzVmQySDBBVlF2T1Qza1F0b1FVUVFrdkp1c0U2RXRsWUJ2MlV3?= =?utf-8?B?UmFseTZaYTBudFMzRmx3UnNXVkFlODNhYzRCNmcrS0dvdFc3MGpIakdlRmpK?= =?utf-8?B?cmxOdENaS0o0eXBZVjNHUHNDUTB6OWRaZHhVcHFRS2VlTS9vMjdZRm9JVmpz?= =?utf-8?B?QmRVL0dzQnorWFZValp4RmZXa0hYemY3ditSemNUQzhLM2hwQXhWa1YxRG5h?= =?utf-8?B?dXVtVHU5cXNoUktyWURiaU1qdjAzUll3WTRBeFo2cVFzT3BxKzM3YkxYQlpw?= =?utf-8?B?d3JWdzdJOFdyWDZqeUkvTnoxbEJobG9mYXl3WVl6aUlNTVBRaUpYL1pLZWo5?= =?utf-8?B?M296cTlWUDZ1OFp5YXA3VnUraXFob2J2d1E3QU5DSmtpWk1TaUdTTEFBM3dG?= =?utf-8?Q?a+moCjntPTbMynp7R4nIULiyVeewMTUO?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmF1RURVK2pId1hOZ1BhQ040Nkk3MlhNN3FLcEtGdWFHT2Q4dytiajFNVlNn?= =?utf-8?B?aHRUMXp5ZEFSRnBrZ2RsanZBMnppakNVVTQ4UElVc3J0TTdXU1lZZFpzaTBr?= =?utf-8?B?TUxXTkh6V1BBQ21MT2V4YXF0ZzAxQUE1a081U1MyV3NtU1pmQ2xyUitVTGly?= =?utf-8?B?aVZzWHhWUFYrckM3SFlseGphRWJPUnFYV1FoZktOM202dnltdEErbnRzaERM?= =?utf-8?B?Rlc5VTVtSGtub3MvZURwc2hjUGhoN0lRUHpSVk8xOXhZenYzaUV5aDBHaHJ5?= =?utf-8?B?VWVUWHpjS1NhTXpzK0xWcU9KdkJsMGExSlhhZ21FdFhWc2dkRjQ0RUhibWhR?= =?utf-8?B?TFJpK1BkdGMrYW1Wb2xZM0FmSUhpZDdKYWlsWUVMQVFTSXFiWTlnUEdmRHdj?= =?utf-8?B?MjZlUTFpT2FSNVo5ZGliVmhweFh2cVZqcnUwUWJ4TVNrNUhIaVZSb0p2YzFX?= =?utf-8?B?QWE4M01qWkNGREhlTkFJRitjM1NRS2dGeUZHV1pjZUxOcXNUSVA1YW5kMXdU?= =?utf-8?B?emVvempja2oxNHRqdFlVUEtLUTJ0eEtFMjdLcnZzOHBGaEJtMGhrVTFuazBG?= =?utf-8?B?SGRGR0pOay9GeFlua0VxcjA3a2FlbTN3WWNpaW82cDU0amdCTGJ3ZWpDZzhq?= =?utf-8?B?TDNXbkdVU3pxNDUwS0VrTjcwQW1uZUsxS09tSDlUbTk3ang2WXFzWDV0RXVw?= =?utf-8?B?YW4weFJUdUZMVHNrUU5DN3JIaUdOMlJveWk5QWVCVnptWjB0QisvQks1UTBH?= =?utf-8?B?WGFGdUQ0cDdraVhablZDNHpMNGtrUlNYR2xvQlVIaGd4azdURGQ1L3JUWEpT?= =?utf-8?B?ZjRyZjdmRVJyTndEZmR0UmhJekhLaFZhNnZmOHBCMjc1MVdjL1BrL3NMSGhY?= =?utf-8?B?WnFISEpkMnVkYzVjR0FCcHl5UTBZSmNhVmlEL3dmZGZQbEhuU3g5Zm5ZaFBX?= =?utf-8?B?SzJ3MS9KL2d6d1VnN2UwbjlXR1lYd3hHL0s1OHdta2E5L1UybXdiRG9Odmhh?= =?utf-8?B?UWJzb3RTeWlZM2ZJQWJFUUtmNUVYaFVYdWdINVBRYk1lSzZaSXo5TUw1WFZh?= =?utf-8?B?VnFoL1RLVHhaR2ZIVXQ1Z0FGNFJBdkMycEJCSnpJZG1WK3drMkZvVG8zcTZ5?= =?utf-8?B?VE9sYUs5Y2tOSlRQdVlrQnpNY1l6Q2grbVB1a0dUb2dXWHpjME82aE9ybEtT?= =?utf-8?B?RzUxZXBFbWZtRldiZGF0Z1Eza2pDZXFPT0hyNGxPOXptcEZ5Q09EWTJnK3Ra?= =?utf-8?B?MmpET0srQ2xkNllrMzhLVXZUQ3ZYdTdDUTNzZVVrRVppQ1RpQ3ZsMUxUNVdV?= =?utf-8?B?VUVLT3hTWE1WWmEyZmZ6YWx5TUFQQmFqTmhTMVhjRXFjQUxNVTNibnJRa1RT?= =?utf-8?B?WUtEc1czRDMrRGNuN0pNQ1VqTTZyenRkL2lsYy94MGhMZ2VKYkhENFA2dTNw?= =?utf-8?B?dVFVU2wxV3NBS3RnNE1JcnJQQUtUdWd3SGZXdVFzWFdNYWhvRXBxbmY3c3p3?= =?utf-8?B?UGFaejN3ejhCOFoxb01DaEdtbTJhR0YwMGU4TUxsbGlJTDVtVUtFSkxiRGoz?= =?utf-8?B?SjVSc0ZNQkpuc20yVjRPekJsQ2lZUTdBUjg4L2pzZlUvODdaaFFlRFAzT3Vy?= =?utf-8?B?SzErTVUxRlFiSFJ5SHdvOHVXTTJWTitvZ1BzQ2RQYVBlTE9wMUVYcTlvNmNy?= =?utf-8?B?eUFVVVJkZDd0Z3JpS0FLVDZseGNTRmtJSTg5ekJXYVY4VHRuc0tnWnh1UU5t?= =?utf-8?B?NkR3TnNNWHgxZlRhSGlDOHJValJ6RkdOL0x2OVZVQzNGMGthMlliQThFcGxp?= =?utf-8?B?anFLWFJETG9pYmtMWVRoV09JdHU0Mm9mVUgzdnk4S3kyNlB6VWVQQUxrN2hs?= =?utf-8?B?YkhmdzZTSi9RMDJobkNJcWtHQUZpNkxsekRUWUsxeTgvSWl6OXZlUmNlUnZk?= =?utf-8?B?VGUyUzN5UFJqMThSZ1Uyb1VXeGFxbldENWN0a0xwT0pXaXpiR2tyVTBCYUlu?= =?utf-8?B?eHBWTVZlTS9OZjlXR0dvZENCNjRUMmxmODFISGdzSm81WFZPODM5RmZDMGFK?= =?utf-8?B?ajN6VzF5UFFYZnpZeTE4eUE2MDcydVVJc3hiUTZZYlBVK1pLUVZCaktDMjR1?= =?utf-8?Q?6LJ1IoPO/Ha9JPgJTFnjmlKgJ?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2c1cd7c-e9b2-4692-3dc2-08dd45805810 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:29.3212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ISb8CdZQG3+/X2XsvLujU+5uDymRp+r42Uxb7J9IFZzBYyNuZz1fXnjpdD/+X0uacbVNqMUq5NZGESYQukUPqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-ab8500.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 2dcda96f4a8ef727514c751322b84d8d2b382b75..ed2b6b8bb3bf8f99fef9f8bee96= 76f71f8a86d2a 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -361,7 +361,7 @@ static int ab8500_rtc_probe(struct platform_device *pde= v) return -ENODEV; } =20 - device_init_wakeup(&pdev->dev, true); + devm_device_init_wakeup(&pdev->dev); =20 rtc =3D devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(rtc)) @@ -375,7 +375,7 @@ static int ab8500_rtc_probe(struct platform_device *pde= v) if (err < 0) return err; =20 - dev_pm_set_wake_irq(&pdev->dev, irq); + devm_pm_set_wake_irq(&pdev->dev, irq); platform_set_drvdata(pdev, rtc); =20 set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); @@ -392,18 +392,11 @@ static int ab8500_rtc_probe(struct platform_device *p= dev) return devm_rtc_register_device(rtc); } =20 -static void ab8500_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static struct platform_driver ab8500_rtc_driver =3D { .driver =3D { .name =3D "ab8500-rtc", }, .probe =3D ab8500_rtc_probe, - .remove =3D ab8500_rtc_remove, .id_table =3D ab85xx_rtc_ids, }; =20 --=20 2.37.1 From nobody Sun Feb 8 19:55:32 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013017.outbound.protection.outlook.com [40.107.162.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13AFC228CB0; Wed, 5 Feb 2025 00:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717178; cv=fail; b=DKct8Nhwf6rLW9c1SbkDbPHu9kJ0J3bYbYhIWbNtzQ7BJCSlMpqDdQZbKM/J4uyvc/098y6lGzJNQwgMKLDeqpKDRPBIDU0wN6pB4oos+7/mR2vHYAbgS1xG0b/C2kIT1P7wCgNEpyXYxiPJcnstycgngX2UqV23As+oXJzcO8U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717178; c=relaxed/simple; bh=/EC8zCoNiyDgYUl3GWxR1c0E1R02p9BWvo/Wx1hJgus=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mi4VwE8MCXm9goNgmoaoPlWcwmNT3cvrajHgvb2xUTCS8IL80suogZuw+Yd+9IAoOLUOnOjyGYsf/GpN6Ej+NfdB5ZsL9lTDykkB6ZqWFWshRuKbrFM9qK92W5EmPz9ef9IRe30/c3PG4J3lW6kqCOcm/RsYFpOu6vxIXcLHVAg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=P+1OefZ0; arc=fail smtp.client-ip=40.107.162.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="P+1OefZ0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CfemhTSgeU4sGGfI8Re72cBatV8DGltV2OFSZUTR1hNrm6/d8+7z4I05zuAEnDH5FVRB/Wx2on+vY5bVCgpN1RJT1HYh/1vEOGhW/qvyasDVRIxi6UW448mJoaLa1vK2279LZpPXOuzL3pXZ5cIcGCGkT8sZGN+t6aWPzCMvOYHpwaJrQh9UBWNU0dOQU3VsjiXqDZhtDjsHy3CL8XNC6VXhc6lfmwtFCa1JC5JfuUvWa8tpfjsNl3k9Ds0MiNwQLxJBA2/ByldqksU142nLM0H3pBdcVGLkPSkjV5rUpM1EAA1RbK5AfhXCY2+zd7Ul0guHuApuEAMgs5kzYcd8IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=a9M2MvI2sQI6C/8/ygaNTEP4cSZE1O7z/DXxENYRagjXfLDk+pB7XJl33nku9GcfoZZKVOUKlEU9YVYDd/BXFolhPFAZkiM9mJc069mVzvHiCTXufxt41hFTfELJefTxCmhVRDI1IfnG2VwpkE6xHg/p2t0bswg1BbgdJ9BhrS7/PcuH5Mqem5SdO7W2dIizvS7jq7X34lUOoF+jeDehjNoVLPb96wBppj1/6/djlqv8FBg7ggoiR9KnpMTCbXs8Uu4Kw9XtcbgMhQTjk+XUBZ1l93HhU48yh24UFhQu/j8lIKQHPqXYJHCHY71p8V9fDtAaZndjjau4+4Ay3dHhhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=P+1OefZ0diM739yPeiRBD5qtteCmV56h99Rgxpn09M38AdX3GYtnLmmOi0EfOW1hyM9yHme1J3uUXbwbyoarJTHR0GPjVgbf16rJ+plO2H/mpUWacHr8JKadSgT/YmAmjbNeSxZGVY5jwOk9EypKz0NYF6q5F/+0cFGuBqDHYi3TQjI9w8i3/YXcA0PnSEux7/PEg5+YTF5UK4uyy7k+PeWyDEyM4h64Q1mLJVE5pQ7AAzAs9bk1dQbRy9RUH5G30ionlKJ5KOhcF+LRTYwXP92jBf/IgRsFPwbODE2XUiojen0B8SsfvV1z3x6g9374LvPVoHKdhTXdhpYBxrdgfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:33 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:33 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:24 +0800 Subject: [PATCH 6/7] rtc: mpfs: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-6-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1347; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7sZhYfT/a75JkuPsULgAYPAtV5pnc5lWQRqy0mNIenc=; b=ZZyJ6oBnd4ebUNNhIlVXgX+8rb9tbIafnXdCmfQxVegqmYR6Bau7iTLyWNEhAI0R91LFHHApT LE9qzTrd3U7BRiDAm+bXrNBCS4cu5UMLf523JpJJEsXVHDzxwY1rRzh X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 28d5cc0d-d4e7-48f0-0dbb-08dd45805a56 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cUN3VlFmUTl5TEtGcVozVFhWSkFvNVJLNUxjcm5BU0gzMGNhWEtnZ3JqdTJj?= =?utf-8?B?cE44enl2K0ZTTERQaXFjYjFFZFg3OEwyZGQ0QzBOVmozWWdKRzlZdTZiN25i?= =?utf-8?B?Z0RBWExZUVdJWEpuaFh0QzZwRVVIMWNYZGEvL0xwd2hGa2RxMzNnd0hWWnBK?= =?utf-8?B?VUxLRHl6ZXJQZlFjT0FjRkIxa0lyOHc2L1dkbjlrOVdYbmdxd0tBTURNbDlq?= =?utf-8?B?TWRMY1gxRmluYlg5YUNuaHBFc3QzMkY1eW82VG1jV2pEQmVvMEtIMFRmRW1i?= =?utf-8?B?MTFOSk4vWEV5UGRjSlpLT3IwVW5ERnFNNm8rbjRHYlJJOVNXTk93VlNId2ov?= =?utf-8?B?c0o3WEtNSUlHZVViRjgrcUNoV21tVTV3Smo1ekdReWVYNDBsb0xQY2NlamND?= =?utf-8?B?NTFzOXp0UjQ3VVFxMjdaa1F6emZTRVZQWis4QmkrbGlWMWRDQXRtb0NwZXlE?= =?utf-8?B?OGZOUWRMYzRkeVdHZlp2V3JyU1JGc2c2YTBiUzB3Rm1PWUFvR0FEVTE3UEhs?= =?utf-8?B?YmEvemRHY1Z5TllRZ2lMeTQ1c1dvdERyWDY2OUFlVzI5cW9SS2ExZnlXNWdI?= =?utf-8?B?OXVoMkJ4RitDRmRpdVoxUUJzZ1dGTDRiVVVWRW5SRnZMOXZnOHF5MlcrMDJS?= =?utf-8?B?MWFyTHFhQTlyY0FVa2xrUFNNbm42U2kwK3JManZaL2pZQk9TMVAva2tjSjBl?= =?utf-8?B?VE5ZZms1bEtWMzQxZmFURm5oT0J5aHlQT3pYY2I2aTkrcU1KWHh1czhlbG5l?= =?utf-8?B?UEp2WDR4TVVKMll0aDRmNm16L3dnRzNSd1VEZng2RXJ2YnNLUktTOTdaZkZZ?= =?utf-8?B?elU2YTBVbmFoRllIU0ZUeWZBSFJxZGNkS21FYzByZG5CUitHWGpYWXFmcCtj?= =?utf-8?B?VnB6Y09UUGwrSktaZ2Z3T1BGLzRKOFE4SHBUWHFoS1dpQWUyK0M5K1dvemk1?= =?utf-8?B?ZlpxMURlWVVZQ1NFcXBqbmxqcmJhRUhRQjVPd0d2WWRtRTNSRFpwdFUwbWdu?= =?utf-8?B?NWZ6eXB3d1h5a2t3TmsxMysvMW9XakVtbFZORnZ2VnJ2YUlXbFc1NnRMZGRu?= =?utf-8?B?SFBGWW9DNEVxaFY3bWw4RjlnK3pLYmIzbk1wKzB0TVc2NnhhVTN6c1hDNzdu?= =?utf-8?B?YlloWEdrZGJKUGF3d1VzeFdQUTB2OWtia0hIM25mOG5EUWVxUUtwa3FCTFBS?= =?utf-8?B?ejRIYWVVaDNZS0ZjZXNmUE1Oa1pxOXo5NnZMTW95bTdMUENFcEthc1VRRVJv?= =?utf-8?B?MjlGbnNrQTd3eWFzZitpcStJMHFIUTVVQ2ErdHFub2QvcWRScXVDR0pQVHBB?= =?utf-8?B?M3pLck9jMUhWb1RlOGxrRlQxQmhic1RWWENlbjVwU3AzWU8zSmZRd0trTzAz?= =?utf-8?B?dXZiQ0ZVSUZhc1IzZVBrUzhJNklmNXgzdWt1V0hIdERwdk1RNW1rNGdQVWR6?= =?utf-8?B?eGVqY2RYeDR6dzJwcEdxR1FEdmZud2tQQ1gyM0p4Y3dHbktlWmdLNzNVMDZG?= =?utf-8?B?aDhqeHE1akYvbGlkejhCd0o2NmtWYSt2dUlTZE11WVBySWlaQ0RnSW1rYnEw?= =?utf-8?B?WXIxUjhRdjJXU2hqd3drVHBzdDZIL1Z1UlZxeVU1bTdIRDFUdXlsNmIxWHY2?= =?utf-8?B?YzJ3M1VBNXUyd0t6bm1nbENFMDJVUktGTjV5REx4dkxVbGVLZUJ0SDFkOWsz?= =?utf-8?B?ZEdaS0s3ZlJhK1htTmx4UTJoZ08yd1R5d2NuVTN5OENpa0ZkVElxcUJmS28z?= =?utf-8?B?RUdRd1haT1MrMis0MFNJMklMaHRkbkFQcjRSZm9LUzYzbXVyczYvUGRHdDNG?= =?utf-8?B?b3BPN3RDby9QTEVYd3Jtb3R4MXdrZ3FHa0J2VlJnbVIwS0xJRENoYTF4RGZm?= =?utf-8?B?ZWl2YjN4N2d6ejZNbE9VZ05TT080S2tRYUZXeGdqbzBCUkk5eHdObGNGZkhr?= =?utf-8?Q?Hth0FHvZZkyXQIB2+MtZM5l1Vgl8gbBb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djBJU3k4NERYejJCNTROaXU0ZVdXVkFFVkVDdW1tT0NNN0kwU3JKWFBTbUx0?= =?utf-8?B?UWFpYUk3TDIyQzU1RW1ZUUNpQmFOMzBhYTNYSGlOTlo2cnFGY2dLQy9uSzFH?= =?utf-8?B?Qk1xNWVoOHExVVMzRWRpK2tDS2J1ZGVrbnVWdDl2VVd6MUdseGJIYVc3YytV?= =?utf-8?B?RElhRVBlbEhkdkF5OU85anNWdDZyY2k5c1E3Wm1nN3Q3aWFvWERpa0I5K1VC?= =?utf-8?B?MFlGZGF1MUxpZXI0R0V1ZTB4dERqbVp5dzZrQmhnTy8xMzU4d0h3RkZrNGlT?= =?utf-8?B?M1E5VFB2UlNSMk1HT2J5L01JUUo0ZUNGejJZN2VnN3AyMW0yd1lVZjQxZW1N?= =?utf-8?B?K2RwZ0xGTmVmQ0hVRVVXeXRnQzROby9RdnUvci9reDVTUmEyTnVtREtrQmxj?= =?utf-8?B?OTNlMXU3SloyWkhNY2ptMUxLVU8yMzNIRm43bnZhSWE2K3RNaXpuNjBMUGIz?= =?utf-8?B?WWVmbUltU0xWT0o0ZWdEMkQ0Y09HSUNibkJyTGkzK1hCam51VVg5c0RzQnBW?= =?utf-8?B?cXE4KzVNZlJxSEFRYnYzRUVzSElqd1JRN1NTQmIwQzN0K2NjNGVSTEI4c1Rt?= =?utf-8?B?MWhBdWV4SGtzQmxQS29JL3MwU0Z0OWprWE55UktEZnFadmczTTNlMWFucjFY?= =?utf-8?B?TlhEdmlWQ1JVNjQ1ZHQzRU9NWTgxcG16QVhxNVUrdHptTVpSUGxwQ1VoNnBn?= =?utf-8?B?YmtLTHVFS1I1L2pPU0Znay9JRXBwMXFyTkxrNHI5SlBETVl1blVpYWViKzZH?= =?utf-8?B?blY2YTVXeitOWm5UdUJqaFVRNGJXWXJuSXN5bzlnSnRKcFVLOFlna2UyWFFB?= =?utf-8?B?MHBIS3F3czJWTjh4ay9xUDRIOHlXQnRFQ25EYTkyZWRJMFVMalFPbnNLRm1l?= =?utf-8?B?eFp6Q1d5Y2dMQ0FIWTNZa1pua1lyQ3pnRTI5R09Mc0s5UXdKQWtjM25wb3Vv?= =?utf-8?B?N1l2ZVl5cHZ3anpBNVliU3MwZ1NwZzRnUk9YWHoydmdab0F4MGhDZFJYa2Jn?= =?utf-8?B?UUVJQmVCd2ZqUXNmNHVMeEo1L1RhVzRKTHA3RjNzZWowclpJUVQ0aVZTVkRU?= =?utf-8?B?Q0dtS1UrM1FlZEhZbFVYalJnRm1sSUtYYzRzaVA1alhiWEpPZU1Lek1jSkZF?= =?utf-8?B?enExWGxhQzJhWi9Gb3ZpajZFVVBCOC95UWdMRnpqMGJlZ0VCL1JzYlYyQW9H?= =?utf-8?B?cHl4MFEvMFJVaU1WaUhHTGcwT0FvMk5mN0F3TnhnY0M1eEt1Tko5WmYyZzlP?= =?utf-8?B?Rkx5OW9sQ2phblQ5S3pCR2sxVUNYZmlBSXU5NEJKNWE2YWRNdDRQakJPKzUy?= =?utf-8?B?cGFhOXNhaUQ1ZExYMjBZaS9HUFp0ajVqRVlFNHc3K2FjSzZxcU1NUnVHWlIr?= =?utf-8?B?VWpuT3V4WHp4bWkzRXdZUU1UVVQyYlAyUnlkaTdmbXg1SnFoZThSTVJDVlh5?= =?utf-8?B?ZGFFbGt1a2RqcG9IcW9FZThRVnh0c3VRUGJJTHlqZE41RER2czJleE5rc0do?= =?utf-8?B?L2daQU1WOHNqQWpqMVJVNk16eFlXaUg2a1hrQ3F6cVNGc01jS2M0SktTckZF?= =?utf-8?B?bWNMUVlCUkQ0b1cyY1pxQXkzUHY5UURLVWJOWkRta3NIa2h6MEo1dGdJWHlQ?= =?utf-8?B?RDhLR090Nno3MjVxOVgzSGZsUTJkcjZ6eTFNSXJkMjE5MldReHV5aXg0eHRV?= =?utf-8?B?MjFjMlR2em1iSFFuK09HRjY5U0Q2STJxc1QwRkRJaE5BUDRDSHdVNWgxeCtF?= =?utf-8?B?V2JvQ0FMaVFWdy94bk9hLzN5aFVPeDNFbHRUQ0U0WjlCbSsyQnJCYXRyZEdF?= =?utf-8?B?bTR5R04xTkkrUG9rdzB0ajRMTUY1czhuaVhCZmVJMGdVMnhUMTg5L2gzUldY?= =?utf-8?B?ZC8zcWRib3dsWXIyVXdMNXVLa2NuYkFSM1k2V1NjRzJxOU5iUUV5ZVhRMTlp?= =?utf-8?B?ZGFNMnBRdGNPL2NrUXpPWlZNN3c4Ym5Ec0I1NzlwdUR1VkwxVk9ZejE5YXNO?= =?utf-8?B?YWJOQWM4aGtzdVFhY1g1Y1ZsNXRHNjFtSFZBVUtwVDQzelQxZnVrTTgwaEtK?= =?utf-8?B?YTY2NzdiQS80MFliVFZ1VVNSNWFQcFQzeGQyQnJncGhVSVc5RjlXNnZpS3Fq?= =?utf-8?Q?jE5EktvWHsqZj7pMHo1gUvj9D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28d5cc0d-d4e7-48f0-0dbb-08dd45805a56 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:33.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Egsm4Fg8ym7JJhPoaUC7uTQB5XsKHT95YEQ9DBL8mwasmxKv8UcFlWZNkcobBKS6n+gxSveulntB2MmLZhgO9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-mpfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c index 3892b0f9917fa7bc4f732cfe2c2b2f548ba7429f..5a38649cbd43b3c6f2fec5db95c= 4f0013deb2a08 100644 --- a/drivers/rtc/rtc-mpfs.c +++ b/drivers/rtc/rtc-mpfs.c @@ -267,18 +267,13 @@ static int mpfs_rtc_probe(struct platform_device *pde= v) dev_info(&pdev->dev, "prescaler set to: %lu\n", prescaler); =20 device_init_wakeup(&pdev->dev, true); - ret =3D dev_pm_set_wake_irq(&pdev->dev, wakeup_irq); + ret =3D devm_pm_set_wake_irq(&pdev->dev, wakeup_irq); if (ret) dev_err(&pdev->dev, "failed to enable irq wake\n"); =20 return devm_rtc_register_device(rtcdev->rtc); } =20 -static void mpfs_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id mpfs_rtc_of_match[] =3D { { .compatible =3D "microchip,mpfs-rtc" }, { } @@ -288,7 +283,6 @@ MODULE_DEVICE_TABLE(of, mpfs_rtc_of_match); =20 static struct platform_driver mpfs_rtc_driver =3D { .probe =3D mpfs_rtc_probe, - .remove =3D mpfs_rtc_remove, .driver =3D { .name =3D "mpfs_rtc", .of_match_table =3D mpfs_rtc_of_match, --=20 2.37.1 From nobody Sun Feb 8 19:55:32 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013050.outbound.protection.outlook.com [40.107.162.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C83228385; Wed, 5 Feb 2025 00:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717182; cv=fail; b=O0myGGLfvVM+SBjZ82Bi9MbDzNqL8eYnBdsa2lel9FTK9cFlOoRzfbfFkaHKucYW9MfPNDusl6c/yaLgl5iGjXvSnVI+bVEKGDC8CiwRMGg7Lths+5eWUL6mrB2z4f5sdTqQ9HHhI2Sa763N+w2Pmn7vHS6Zn9QpLFIwj3RF2V4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717182; c=relaxed/simple; bh=AcWk+DTl4vJlEoX1Fz1L2UUCItL1uFcWaPK5Bz+U1lU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kv2FOJjOlXEqJT4KNPxkZtIx/D9PXL+lan8H/riTgSV2SCA/zeEoBO7YilMY3VV9UWMJFAa/7wB/OlKXWjJoQNPbzEQjJ/GG6wnsUb8P31c4AEY6vk4e/x/k5ci1JFKGUPATNLnCKuX/vdlcrQMs3FDzjAxZm0/yb+Za6Q56yFc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=xehDLvqm; arc=fail smtp.client-ip=40.107.162.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="xehDLvqm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NKAoflszZ7mlKl9PYHCgJY6OEDFp91cFt7//ipvC6nMo0K5WrAhVVg1db7OAjcqkHXHOjKSUGvxasdBoVi222Ff2tCoFnGZHR5LMeX+l1krQsXEfcwulh4v4sLlE2lA9wmchZdwZHHz/XkYADOILAdx5REpdtj5Nd9J5/oegjpChv8hZ7aXep8mileT31UmoovwSEGyqlCM3OA7++OQRpZ9YfplaaS7ioZp7WHImZAa+qS4nQ4rUpYLhRLikVivSkuuygs6dTEteacL8DTD2h2/0vSa3NZzWPyFQIP3TB9lUf3V54EcjikTIdknrKuvCJDZKPmR0I8S1IfVZgZROAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=Iu7LzleXyPFTpA9pxajroIpa81mSuuKH6SWK35k61tWXeuB06gTi7EMZnmwTmMwRf3JNIN958e9nkmKE6125GmRPoCIscg+Utttte2KR1qpNTQqK1u/Bmn4nFFG8pmmkrFlO8By2BTQS9PJwqGYD6NC2zm7ut5XRACSX4zFx0dA1wqNZDNHF2ZP5BYWlW9GsqQB0/c10rQmzmfh2SE+EYTRaTVY8T9VSbpy0WhxYn7StF32LvREuai7yuPaCAaQWFm8mwzoGVxLBIrKEOnYignuk+kUB9JJ7CYMcT9JbHw3J6/JAK1gFyf6p/KX5UH7uQw7wHP5fKAyCsqqulRLKEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=xehDLvqmOSYIWp59xODlz9s8xncr3v2CW4nz7PWrlcpSP0DgWSRC+d3PlXFADPlpLy7/v95oK4HJyVJcWE6gVcnAtICeYHhi6085fnpzX8E8g6gBDes9eV8F5wXDArdKR9TZsXkdIj4oyHu++ij20MbzOLRg4Dgp7aIgoUPBpJn4L4o9MVwrpTzxvwU9DYA+89DGSz+8YkhPeiLyZ2HSBb42ZNWFUYu38pdPN5sSdQHGV4lrbxG5pSYPUF83tEPWEuiHyU+K/qyn2g/4ayHojdEVXf3q2AZYaxBwRs3frS1WAvzr7UaoADYFisDxXrAcyzFhxsvYRDnMcIsPPyoe/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:37 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:37 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:25 +0800 Subject: [PATCH 7/7] rtc: pl031: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-rtc-cleanup-v1-7-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1457; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=836X+TA/l2wfm7yon8oTf/+NEC4So+0tkKKh8ZKoqD0=; b=8b+RiW38bzcj7vW9C3nT/sXnco85VHDgcMhjl+0oTU3U8lRGFu1FS0OqHTfe7FEm8pMc6TD6S CcnR0JtCPB9Bg8e17MVnczKMvC1sDBxLvXZuA57wbWLOBQLeV5v1DtW X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 793ddd20-9a38-46cc-7474-08dd45805c9e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dzkrWVRicW40SXlVOVZsM0Ixb1BMRkdNQnl1NEF1eWNteXJYWk9IeU15bkFG?= =?utf-8?B?WjNkMUlGbThMUVZXeEZGdEhzVzdlZ3JhaldvUXhjUWM1NHpzU0tETlk4M1dr?= =?utf-8?B?RWZ3K1cwNlF1eXlYV0RIamZCbnRDUFZ2K25reGtXQ095Rkw5RTEwTmxaRGYz?= =?utf-8?B?bGFUSmJ0Vlhzb2Z4U2JBcHZ2ajdRVkE0K0FSQzYzaWRlUHdiTkNuL3loakJU?= =?utf-8?B?V0pnUjdzV2VkdmdTZjJhN2hJK3ZjZ0ZIR1dtaWN5eFNWYmRGSGl1QnhVa2th?= =?utf-8?B?WXZ4NE1aakVNUFIvY2lremRsSHpHclFGMGNIU3ZORnpUekZBa2tiZ2ZzSDhD?= =?utf-8?B?bytLZVRqcUNCcXhpTzMyNUJMOURjL1NwdmdiMENUUE1qdWJwbUhJdGlZVEFr?= =?utf-8?B?dCsyRUN6cmljN2V3LzE3amVqZWhZYWpFTU9zb05GaTBNbGN3azk0SDlVbXRB?= =?utf-8?B?YU5LOXJyeEFkNzJxZkpJQXByNk1hbFVlaE9XSHpyRlZlOVRBOS9rR1JWcTNs?= =?utf-8?B?b3prc2Vxa0gzVFNreExOa0tFeENsZ005T1lPQ3NYcjZ6a0hyVjkwVDI4VkxC?= =?utf-8?B?R1I1YjBjTGxBR2pnL05kUitxcGNLNU1JRFh6QmoxT2x5cnVuczByWjk1Ui9U?= =?utf-8?B?V1hhUWR2TVppSFpQTHZCN0xxL0ZLN2lDTzV4NnZwUHlzRHFIN0VOOHhocjFK?= =?utf-8?B?cjNGcGJiR2ZmY2l5Q0ZHL0N1eHJ0bURsNDNwQk9iN2RSVW9oYUx4SHNhbkpE?= =?utf-8?B?MW5BSlRSMC8vN0daWnJPbHNmQVJuWml6ODAxTUxFTXBuQ3VjL1ZoUkxGNTVJ?= =?utf-8?B?a1JRYWNabFFSb2NGVnV5enFkKzdHZ2JVdnN6TUpMSWJmTnY3UEdGemNqRytn?= =?utf-8?B?M0k1KzNtSUQ2cmJRbTNWNVFDTEU4anhVaTRjdmMxQnRtTlZteHhuaW1wazJm?= =?utf-8?B?WEZMN2RZeUlRY2NXcitnVmo2c3VlendNVFJxNVpwM1Z5eG9NMDMvU0p4S1JR?= =?utf-8?B?aFIzNjFrMXlma1VsckhidndjclRnV0ZNWnJzdno5VkE5azczQysvcFlRZ2wv?= =?utf-8?B?b0QvZnF5dDZuU0dvemtha3d1Y3NPNE83b1l6NUpXVVNsTXcycTRJV21HYkhs?= =?utf-8?B?VGZZY0lDWHdsdGt6cTFDenAvNEZoaThUZWtGeTJxRGRHOGxqUndJL0JreEFG?= =?utf-8?B?ZEJRbDdCRlNJY0U0d1lCeTM2eXd0WTA2R29yTVRqYmJzMitEVWVXVklDeUNR?= =?utf-8?B?ZS9tZW11bi9zNGtDdWZPUmtZZ2FIeE5TRUVkbGJzcG5naFdBUmdzb2oycUsr?= =?utf-8?B?MVIvYmNLS1dWb3JNWCtkRmtHUW43ZFM2ZkVkcHZVa3oyQXliNGpLSUNNSC93?= =?utf-8?B?Q0FDSUNYbWNSbGhUWmZNSVFCY1VmSkRHLzRpYlluRzBKMFlqazNFVHNETGpa?= =?utf-8?B?WWpRT2g4YlEySkE1T2FDdC91aGs3VDUwRWcxbWcxQWtENWk5YmcyaWVvMVZL?= =?utf-8?B?eXAyU0tlM0Z3YjFPZ2xqdThzdS9FUzRnbGlsbDI4eUdBRkltdHE2c1N3Vko3?= =?utf-8?B?WkcrdDBlUkVRbkxZTXp3U2hnVm5CM2VNSGlDUnhhY2ZUZm80K1ZuM0RMVXlp?= =?utf-8?B?dTBkcDBFalh1YUlIS3RaYkc0VW9RWUUySUMwRFJsQVExMXpTU0M4RFFSQkFn?= =?utf-8?B?Y0MrR0hUdHA5SVc4YXd5dmJWbjI5SXdsamhvUlh6TTI0NEJsZ21hWlJKa2kv?= =?utf-8?B?YmUwUWRzb1gzSHVtYlpkYVZRcDRTaFRsVDhZV0RzYll3QnMwWHZjMmJjeC8x?= =?utf-8?B?KzQ3dTRXdnNZVzFVMTRqRWFsRVJjbXdidlREcThQa2hPTUxKTit5akZtc0Y5?= =?utf-8?B?dG53bFljUVByZGhFL0NYcFBQbHlDd0FEbmhJSlJHNW95SlE4RUlRUHhTOXU0?= =?utf-8?Q?AcjFsetIYdDDRfFzMgMVx2n6Y3cIW5bC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXJIODE3cjYvM0NRV1lGTWRac0NpS0dOUG9idGh1N3l3U3RKYmF6cEFBWU1Q?= =?utf-8?B?cTVSOTFwdUJ3L0pYcU1QSjBBYmFnVVZqMmdhd0tCeVhrZWNVVkYrTmtmRGlm?= =?utf-8?B?YmlUQTU2amJKRGNSeG81YlpWNDlXTmk3MlV1TGU0eEVaOUVEVmgzUzY1V0lh?= =?utf-8?B?bUpXWC92c1g1UUsvQ3NGT2hJT3MrZWR3MlpmT1djKzM5RGVMa2JOYlphWVgy?= =?utf-8?B?dEJpdjZ0VUVzdjZVSUtRaUVWTytjbVM5dUx1Ymc1NmR5a0JVMnNUOTRtQ2Iw?= =?utf-8?B?QUFobTdRdVZnMnhYeEVRbk1wdVZqaTRTdUZOVXhPZy92QjFaZVJrSzQ2aEZo?= =?utf-8?B?SEJ3VWw1MTUyMDYrTCtQTURURjhjdGREUlljSzQrSTFXRmdva3RDSHl4NG9v?= =?utf-8?B?VkxhdTZaOXB1Unl0VnpiVm51OGpmckkyKzkwNWZZS3Z4dHlGRDkzcllqa1Mv?= =?utf-8?B?ZEhhU3hRTmhJTTZodlRkMFRIRVRyUTdHQ21BN1IwQVZkbFVXc2NKM0NTMm5i?= =?utf-8?B?Q0FqRm9ja0FVaWFkcURkWDlrMUFPbWQxMEhleUphdVdxVCt6ajVDMVFFbmdC?= =?utf-8?B?UFZLV0paSTl6UnhFLzRDcENtQUk1NHJMN3krN1BubU1la01tSGJFTmVyU0Z5?= =?utf-8?B?UjJiZEFPbzVmQndvL1pXUWZRY3NzK2VDTFQ1cnZ2a1R4M25pK3grOFJqaXRr?= =?utf-8?B?WEZvdUw3RFFmdTVCSWFoOGoweVZERFdWRUJKRG1BRlh1VjZ4VkVERjB4OVl5?= =?utf-8?B?Y3BkRkNHMnl6WmJRU0JKZFpJM0gweTdHajlnY2w1d2RheFhLR2VJYzErNHda?= =?utf-8?B?NUo4Yk1TMnlpQ3hNQU81Vy9TOFdGQnhvTEpHcWZ6YUlkMW1NRFdLMkhDMjYr?= =?utf-8?B?bkFhdXp0SGtVRWl6QkFZZjFEQmUwRVN2Rm4vYjBhNWdhVFhkSHRRWXcwUzhE?= =?utf-8?B?cWZRNFRBMmNXYk5kODVjcDE1U29Mb3lWTlhpbW9ub3lhKzlabHBsWVRSb056?= =?utf-8?B?aStOZWd4ek90SEhjWEExQlAxNTVqdmhjRFhLRm5Nc21aL21VaVdZdjBIc2Jx?= =?utf-8?B?NVVjWWpFdHY1aERBRXNoL0NNWWhXMDhKY3NFMUZYaVJqc2VaODRmN3JPNE5V?= =?utf-8?B?NkM3S0R1Um5za2xmc3VRcmlEcjl5YzNWRVI3NFNtRGEvMk9wYzZQZHF5NUNw?= =?utf-8?B?Q09NNTM5UENYNFJ1Mjd5ektBQ2xacmpZNFk1MGlYTmRPSEo3VHVzOGpXMitu?= =?utf-8?B?dWtvSVEvYVlnTHFMeDVIZ2NMdnpNNjdmeXV5cjlDeml3SDZWS3hzSGtGWXB4?= =?utf-8?B?YnFhTDJpWTcrZnZQS2NFdm1KZ2gyMm1MeCszTElSdTYybW1VME9hQmtmeW1F?= =?utf-8?B?V2RialJTQWoyQVk1dCthbFJ6Wk1kMFp3S0I2RnZQeERkcTgySFVDSnE1ZGt0?= =?utf-8?B?M2hqNmlyRGZucUJIY1RrYnlwY3RQNXorcVp0SUtNSXRvV3l2QWtodm5tU2hz?= =?utf-8?B?bm9QaDJQK25ibElQUWNuQ1h2YU5Bd2Z2aGJrb0RJanZwRncwOUR5emoyVVd4?= =?utf-8?B?a0M0aDE2UlRYVUNYUy9JeHZYSHJaaEEwSHpnM1FTYUZDa2ZEYlptYjlMZnRC?= =?utf-8?B?YTVQTXh0UXJlSGFmRzRUMW1BZXFoeFkveEh3bjhVZUcwTmMyOWF5VlRCRFdH?= =?utf-8?B?cVRxemM0NW0vRGRIdXhHdDlJWUtvbitIVUtDNVoyOUNsSUg0UDVpMTlaUHZj?= =?utf-8?B?SWswT0pQVGZ6emVtcWhHV3FNb1ExVEN6YjVlaTRvRkVxK1R5ci9HRGZudUh2?= =?utf-8?B?UnNkVVZwY0tHVElSYm5mMDVJM2U4UENidzJIeitaRFQ5d0NEMGttdzUwdTF0?= =?utf-8?B?Q081bUJNbmpuSUVOOWlucUFzUnNsRGNXSGp0bTlNOUt6MU9FWHdUTnRWMHhF?= =?utf-8?B?Z2I3VlVNVkFOUmlNZVZDNHpxWFlXai9uZWJLMjhpUXUxV0F2Z1h6R2tKWDVx?= =?utf-8?B?TU9NTm9VZno0RXhXb0lsbjBEblMxZGpjNlkrMjRLQUJ3dXI3a3BzRmo5Ui9I?= =?utf-8?B?VjZUU0FKcUNsakUvUDJYbFliSGRHcFRnRjlVa1phaDdTbE5tVmd4UU0wN21m?= =?utf-8?Q?3e1JLy8xLZ/s2j1BI55eJsv7l?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 793ddd20-9a38-46cc-7474-08dd45805c9e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:36.9576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oPoxj+HRZgTo9C3XvebIy33LXIv+qsbQEPWs3oi2EnamYs+w73SWn3eqvWRDfveyM3wqXzBRRv4+6LlAn/9EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-pl031.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index bad6a5d9c6839ca70905e3d46286b9729c1fd435..47bfc5395e5908b7722b9827639= 9120f1ba65af0 100644 --- a/drivers/rtc/rtc-pl031.c +++ b/drivers/rtc/rtc-pl031.c @@ -284,8 +284,6 @@ static void pl031_remove(struct amba_device *adev) { struct pl031_local *ldata =3D dev_get_drvdata(&adev->dev); =20 - dev_pm_clear_wake_irq(&adev->dev); - device_init_wakeup(&adev->dev, false); if (adev->irq[0]) free_irq(adev->irq[0], ldata); amba_release_regions(adev); @@ -350,7 +348,7 @@ static int pl031_probe(struct amba_device *adev, const = struct amba_id *id) } } =20 - device_init_wakeup(&adev->dev, true); + devm_device_init_wakeup(&adev->dev); ldata->rtc =3D devm_rtc_allocate_device(&adev->dev); if (IS_ERR(ldata->rtc)) { ret =3D PTR_ERR(ldata->rtc); @@ -373,7 +371,7 @@ static int pl031_probe(struct amba_device *adev, const = struct amba_id *id) vendor->irqflags, "rtc-pl031", ldata); if (ret) goto out; - dev_pm_set_wake_irq(&adev->dev, adev->irq[0]); + devm_pm_set_wake_irq(&adev->dev, adev->irq[0]); } return 0; =20 --=20 2.37.1