From nobody Sun Dec 14 13:53:05 2025 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16B05227BB6; Wed, 5 Feb 2025 00:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716368; cv=fail; b=FxnAKaYUu/xnGilaGp6qKQ8iZMPK7sk178mHE6pXDCYupxvZCPBDoo6Glm5UGvBSoP3fROvDzByD/6DyeQdIc0+PZ+TO2jR2xiEN87n56K3x2PVCPSGkfFbFcIOuOU/IRhHX07EgLDY7Kf00fL8XZ9rjo8/jWvcCML7t8n8LSrw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716368; c=relaxed/simple; bh=f0XWM6xBggK2QfOcHzd3+B2023F378UQ/qXOqelOuSw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Z0QU7fy76r9g4DUMoazpn/fCSLoOGvhdoadnbs/5Y7VHMeMQhC/hdnuJVKvAuYUcTKhBt9b0cXElE6OfWXzTWoAyoXQAg8+kD9AlmKVxhRv/V0H72EdLblsuYhDYA2CXVcFafXZ1qt/HqhyGtHqmaLu0AMhuTCaTJJlF1egVNms= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=geFRxdle; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="geFRxdle" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jB7u4a6Zjh5aWhc/79HcbZURJBkQ9KsioXjOPqfthwvalAq+kYHNyfEtumib1leQS5DQx5n8iFPGauZWsxj2Tt5CSDZFtapS/IquMmJgbybEosmzRy+PhKzr3DqA0YgQdyDIKUuc6mfkPD8sPA4y9O1UYn3ksx5ep5Z2f2QyMexzreK1EviB0+O4iiD2tEkWdlncBGW5nP0uXYYj4+2ZHUm1BKnatcuEd4ALRvj/CeYPif0fTWEPZ7ZgmFz4bsOnUfBRHBZndUgz6l5KSiGSulnrDpyxDIMwI6GwGR3sdFZcBiq8UO5sEDKUkoRd2SD3XCrsBM4LHWf3uVgZXc2ALw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=qDydsRsO5Cfw3c2lKbkmnaG+7UihFE2gbyIY6tcDfN+3zHhjuGtwqQC8swd21HAEuwKdndtbaZEEap0qGm1ccOzgLDFAeZmJbJLFarcK7AGHQdTuM6FyrXp7wjQrITxJ4tPL8KRjaimdCaNfDmro7AfY3wLGSRoeyoRGlWLuEaPQH5TbnpPjN1O7yWgdNS7U/KHnuaQRPizL3PO9qR2TiXxUkE9p7MrjlZvilsPt6AnkmSG+LfKhKe7Kapw3qUmiJm+QojBjpXf+0TqOzn06i6yRpD+VPcvcSZApqmhoOxxtVl1EF7J8PFou4QBZFrcxcqJoS7xYG009zyw6iFqvuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=geFRxdleOnkCybpV4Z6Z8p4v3vzR7ioE0Sw4PRrYpkycTBaktIfDNJZtL7JHEidXmX9rjIwW1bg8TSFU7B5WOt1loDcttg++x1JbxXgvrZwxcSd6P0tyItGHxYdXuWogeNNpSHWSKVYFmQqGfMF0jeklzB8WIVnfwhsfXcI0/9Qf1oyt0qQyCY8ut2zVh0EmOskSAlIMVJ5LpGe28oH9LllmmQYV/SwSp4Iysd9KHFiB17z92TwSDSHfJiESLT7tHTfAY1mtBX0DDKYOsRmwkuK+syh+YsY343xBF2XiDQ3Vraf9zs0mmgJEY0wO8kPqToWksQ+sBHmD16IalZI3qA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:00 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:45:59 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:14 +0800 Subject: [PATCH 1/4] input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-input-cleanup-v1-1-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1402; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=lLk6bV9Q4qc+HUdwJdc/NyACnoatpwVUWdW9RwekWXs=; b=7zL7i+g9ZP1bfjG5cTwXQOi1Jqw3NcS0dh/V/mXAJHhl3OreOjEha2JCLQEuaWf1dNlcjcKUn C/WGQf1YU2oCY6Anm5IS3G7QGNuC8NoxtpvW5c2pzkeO94aFazjfUZb X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 179e77d8-108d-47e0-ef2c-08dd457e7596 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?M3NtazBCNkx0VnEyOFI1VzdyNGVBMFZ5OXV6WlVmbmNOQi9PeUkwcFo4RHg0?= =?utf-8?B?SUZNWFZlYm1sY203aDcwcE1iaklvaE82bmVrRDBRWnI4OUYyVUhmTDdQVlM3?= =?utf-8?B?MUwxUEFhYzBnVVhFMDhXRmJ0d3RrYXFlQWs0bFJvbEpOVk5pRUd6bXJaRTVo?= =?utf-8?B?YVFwbHBEeEMrK0Q1S2d1L3oxdmhqMGlacVlJMkhwb1hxaCtjQ2NOYjBocG85?= =?utf-8?B?bm9HTkpKRldWOHZPWlY2QW5aT2NScCs2MmFlZW45NU5TOGtLS3VwUVhaK05a?= =?utf-8?B?NlRuNGtSbjBPSWtrWkVqSVJBbWI0Zm9CWTZtS2FlZ0RWU1FjMlVhcU9SL3dq?= =?utf-8?B?MUZ2ZmlmUFFsODU1NXFDRDNwengzdlBOSVhFNCtsZXVXeXZKMEJVTkt5TnVz?= =?utf-8?B?ZUNRdDFtN3JtZWRGVDNFSWQ0R0tSNXltUno2V2tsU0NLQ0NCTDl0SjJyMkR2?= =?utf-8?B?WVJ0WFU3L1piRU5oZTc4YXNPV1FyU2ZZVyt0ZWxSUUdaczJWNmJrUTUrK0pH?= =?utf-8?B?VGMxSDU5cGdFdERRZE5ZVEluY2F5RXJxY21JRkpHSVg5d1lNcGMyamdvL0R1?= =?utf-8?B?SXR2VkpzWG5WZjc1WjhxQ0JLemRpdTdHMUV2VUQ1TXdSaEZocFdweXFjeDdj?= =?utf-8?B?MVF1L0hGa2d0ZnhmUFRHelZOcERpT3hQMmxPYkgySFVtMStsdnJTMHBabk0r?= =?utf-8?B?VU5ISlIxZ2JlK2pTc3NhTCtZc2o0OU5rczNkZ0RHMGJ2WUo1Yy9QckczdUhF?= =?utf-8?B?S2pteEVEYW05TFpzbVorRUpZWkRWUFp1MUFPSTdnRVFiN29ybWQwb0U5b2NX?= =?utf-8?B?R1dUSENqK0RWaU1KSGI2TUIxUVBTc2J3M1BCOC9hL3RUTTBlZTFMSnJPNFl4?= =?utf-8?B?SUt1RGFlMmVIUzBlRUdvS05PTEdYdE1SZUU3QlJzZk9EVzR5citNZ1JzcVdR?= =?utf-8?B?b0I0QXNFOEhacmFLT1NMZTJtN3l2bC84UWpQMVFhR0duOUJEREYyZ01KSDdI?= =?utf-8?B?YUdUUkYxblRFS3E5YmJsRlhXVXBoVnA5dVBmU1VmcWNyc3R2eGs3VGVKTTFx?= =?utf-8?B?WmtociswVVRMeUNkVmNDU3dqTU5wRnZjc1JGQTNsQ3dyWWNyNzhDdDMyTzNu?= =?utf-8?B?UExrZXFjN2hzRy8rRndUdHQzZ3EyLzZ3TnRFOXFPRi9tT1hGOVRyRHZ1Zi9T?= =?utf-8?B?K0hUMGYrc2x5a0FDYzc0bFFYcDYvOFErbHdMM252b04yaHJOQmFENkFwaHc5?= =?utf-8?B?NUtSTnVhbS9ZQVZPWGNhYnJOcXV2Q0M3Y1hjUGYwemFTRHZoQ2VQOWRvWnBi?= =?utf-8?B?aGpxNUpHcmd3SnVNRzB4eW1ZOVpUQ09Zem1TRmlVRDFHREJBbG1wZ2dSNmJn?= =?utf-8?B?NVcvRnVSLzN6YVdXdEsrZXYzYVI0UU5TaGpVMm1kLzh0cDRkWDFQTUNQN2pK?= =?utf-8?B?d2xCMExzNk5ZUGJXNk5IVkVTcVo1Ym5JMWVyRlBrbGhyTEllRlBqb0RIc0Z1?= =?utf-8?B?YU1IK2NaazU0ZWlOOXZjMkFCUWlSbGNnZUJOcll5R3NCaGRBazQ0ZGYrenpy?= =?utf-8?B?bUN6UzE0cFF5UXQ4WlY0UkJFUkpCZU9FdDd1aG4rSlhrTG16cThaVkh2VnNx?= =?utf-8?B?VHBhWFo3SlFlNHJuTGRSZ2VpbFlNSW5kVzJFQmx6YUk4czdIV094ZDE2d1JV?= =?utf-8?B?bDlkSzdVOWRhRlNjdWpZK0tVNzZiaXplYnE1TkN3Zk5KM3NIUVNBY3BRRERj?= =?utf-8?B?c3RxOGMvaFFNc2VOdTRzdSt6dnlSd2xrQ3BQU2d4MWtHemxycldYQVdKRXR0?= =?utf-8?B?anlvZ3dZcUdLMmt6TVZ4STBjY2NDRzgyUzRpWUk5Vmo3bEFQd3RWNHlwa0pI?= =?utf-8?B?SkU5a3lBT1pkL1ZjbERYMCtzeWRDQTYwWFF4R1EwcUtiODFwdlM0bUlrUDZ0?= =?utf-8?Q?7vIjEJ0yaaVt+D46JCIiX8daBG2bWKFF?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGtVM0VIZDZheTJodVFFSktxWXhHRjZyLzY0bWl3d2MyaFYvNWVTMEZsYUN4?= =?utf-8?B?d0IyVm1xMkpsMEU4SWZLZnhlaWFuRDJGZmRXZHJ4OXZ6V3gxWkp1dmFjRHNk?= =?utf-8?B?bVZzN3ZUaWZQeTU1bFluaitaNjdUMHlFODBZMXVBTmFIajYwS2oyd1FSRmJl?= =?utf-8?B?V204Wm9ncWNXT0dMRVpxNGk5S093WmQ2TXB6Njd5L1R1bkJkQ0xvZkZRTGd6?= =?utf-8?B?V1piNDJsUUR3RDE2aHdDdTVMRUUvOU9lcVU5UDhuSmtrVCtYT3k4ZHBzYlhJ?= =?utf-8?B?SmRjMFk1Q0tURVNZcWFpdzhRTE1Da0g1Q21FYWtSWGRDaGI2K1hJRDU3UHI0?= =?utf-8?B?NUZGS0NSTExDM2JKUWkzRUdpKzgwdEQwbUNDQW03RmpzaHByc25MRVBrYkJX?= =?utf-8?B?ZElwV0dubzRQZkZYNFl5TjYrY285NjFTVUVvRWRuT3gvR0lMbnl3K0IvSmJG?= =?utf-8?B?NGpvdE9KTUx1ZGlLS2hEMnI0L25teTdFWlU3cDZhb05QZ2d2N3lQN2c2MnZY?= =?utf-8?B?QW44RDhGM3VWU2MwL0pTVVRZZXA5enRpZlNFWXJwLzJadi9yS2Y4STUvVVg0?= =?utf-8?B?eVY1RUxyejUwUHdpUzltTGxyNEZEUVM3Wk4vblV3M2x2QUdLY1U2ZmdPcTJB?= =?utf-8?B?VVg1NlJhUUZaZjBITi8zREE5c3Y3NnBqMEdSdFJEMUNJUVl6eGkxNUpEUUd5?= =?utf-8?B?b1ZFY1JNK3Z0Q1g2UFlWWVlVZkJkVDNZVVQzYlZYRXlMWEdScnBVNUNYNmVY?= =?utf-8?B?UEpIYnhaWG5LR3RpQzZOR0E3bTBRczdDS3E3Vk9UVmZmbEg3eFh2dE5Xcm9K?= =?utf-8?B?cXJQd1VSZnZWeDhxazgveDdGWndtWlNkWUpGeXVCMW1GKzI4WFdCMkNnekZI?= =?utf-8?B?MTZEWW5HeHNVMGowN0g0QjV3eXhaS1Z3SkJacGN1bHpPLzVid2JPY2FKNk5F?= =?utf-8?B?Z3UyQ3UzYkhxd09yV2JkeFA4THFlUWl0SnV1azA4dExNaGsvbnQrMlZ5ZStS?= =?utf-8?B?a1ZGMGxuMUhUb3VMbDZQUTB6RWhLNHNXRUxIVGZOM0RjT3ZReExKdkZ2dUk2?= =?utf-8?B?cUVObjNWSkFFRTU2R3MvQVhveWRIS2xmckZWQytyaitrNUNNRlltd3IrYTky?= =?utf-8?B?eGJScm5yMXNlZ3EvZGZJSEJNUkI1ZlVDTE5Fd1IwSnZLTnlvdEVQcGZMNzR2?= =?utf-8?B?OXEzNDhlNHlmRndabWh5VEZZdDh2WkFxd01QM0txRkdlMzh4MXRyMkVBeG9y?= =?utf-8?B?VTJ3djBtTGxpZDJxbDVqck5mZnhEc3d1RDk0VERGSVJ6dElPaVE2M3BpVVht?= =?utf-8?B?czVzb1VycERENWhlUEQ1MzkyN1dKL09NbmZaMXQ1R0FWWk1vOTQ2T3RDM21V?= =?utf-8?B?THQ0ZElOSkRaa1ZSd2xiTTIvSVM4Z2NFREo1dkNPdmtNUHhXQnFDZmJPbS9r?= =?utf-8?B?NFhQUmt4WjkvVzJhNVg3MFpoeDIxMVV3NXpTdVdzMlFoV0dzQXRxcXpDaHkw?= =?utf-8?B?Wk4xNzFYaGJHTkNXUHFQM1ptRHdqZlBybnF1bHhUdHJOZ2VOWlJxN3FycHlx?= =?utf-8?B?blJhM0tDSnQ2WnUwQUdaejZlTElhN3I1U1FSSS9BMXRqYm9OWStuUGJESnhp?= =?utf-8?B?a0RDV01OaXZyVm9tblJBMHB5N3o5U1kvL3Y4eFVrSGFYcjJPanhWb3p4MElD?= =?utf-8?B?OStCc2lvSGYxOUs0eDM0OFRtazV6TG53dm9MMnIxOEZPemk2WGdQc3piZUpH?= =?utf-8?B?bXNNN2p3dVVKT01jMnd4OFMyL2xTYWpVVW9BbnAvbjI0OE1nZDBPN21QTlFG?= =?utf-8?B?L2NwaHcxb01rWlE1M0hSbmRMYm05MGVvbUFHOUphcVA3RFdIRm05SFQxODJY?= =?utf-8?B?MG14aTN3K1Nka2JsSUllT2o4MkROeHRLajFjVVIvYXpkQ3ZMcmZtNkdlZWh4?= =?utf-8?B?UDdUODB5NFR0NXhFQThsd0VicS9pd05jakIyUzJPeU5vcHV5eVZPZDgrK3Bm?= =?utf-8?B?SXUyN0ROdlpXWGxJR1FUUlNhN2sxRGNId1VyL1VONnFsdkhsMEthaVhjV2Ey?= =?utf-8?B?MWcyMVVTcVNhZ2tUaW5JeTYzVk1ucytzYjR5VFhSeXo0UzdXY2RlUnZJS3V6?= =?utf-8?Q?tUSaGYi7P3NpN6+LdsqzMbTMO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 179e77d8-108d-47e0-ef2c-08dd457e7596 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:45:59.9217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WGQINNCJDYs2ROk4RU6kG3+w4hZtZa6FykF7gGSn0TbHSxskcz6ky/kcvLLO2CTPpgi0mPczcvM72DRPZjUjsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/ep93xx_keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboar= d/ep93xx_keypad.c index 817c23438f6e5176431e1f736bb511f9919b67de..6e3cbe3ca72dbd43485c23f6042= b4fba007ff5e6 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -260,18 +260,13 @@ static int ep93xx_keypad_probe(struct platform_device= *pdev) platform_set_drvdata(pdev, keypad); =20 device_init_wakeup(&pdev->dev, 1); - err =3D dev_pm_set_wake_irq(&pdev->dev, keypad->irq); + err =3D devm_pm_set_wake_irq(&pdev->dev, keypad->irq); if (err) dev_warn(&pdev->dev, "failed to set up wakeup irq: %d\n", err); =20 return 0; } =20 -static void ep93xx_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id ep93xx_keypad_of_ids[] =3D { { .compatible =3D "cirrus,ep9307-keypad" }, { /* sentinel */ } @@ -285,7 +280,6 @@ static struct platform_driver ep93xx_keypad_driver =3D { .of_match_table =3D ep93xx_keypad_of_ids, }, .probe =3D ep93xx_keypad_probe, - .remove =3D ep93xx_keypad_remove, }; module_platform_driver(ep93xx_keypad_driver); =20 --=20 2.37.1 From nobody Sun Dec 14 13:53:05 2025 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DA50228375; Wed, 5 Feb 2025 00:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716370; cv=fail; b=i34yTaCM2dxuNyHCCPalT1PnVTUGdqseEG6Sb+pK39x7oYDwGB3iBjFpu+vhz+IvdVHKBX6VlPMa8ZLIwNWApPOcTMlfIDo2VWdCdIYimewZvNF9y69T3g5a4EqNBZH8iUyiNZOpoyJJcACWxWF4cJ7og/OP0Rz4HoyhRedcOnU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716370; c=relaxed/simple; bh=DNmSM/zlaiHe7y+SpoUtP9k7yyKM9LouOCBuhZSkcWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WIVfNp75u+L2jQiDhml2tqmJPmTJTHZbrWSo8e7fEsRF7El+UmelFIEm0G6qPTdsR3ow+5DBsoSjjzSiUlj9rA3CWR29QfEB+aAPcmMRlu7ZzIg4M84R5kdVEY96d2t0TBX4Ejq1RkfQBS++5S6Bme5CyrWcsg62Ku6/vn2703I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KLPD0tet; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KLPD0tet" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gVTEEGNvXF3weDr/u+3fSYMi9f/zMXGF/kjwJs0bnev7HG7nHnDVWbIuRggWj3Mc0aIWPZuDGrF/Te3JPuS8dlCVg4qy7rCxhHZshsIxQcPnAQJwJ1tq6XMxLEOkMdOKwk1/7+3axbT1Vjl7ZER8STZeJvXYQrEdert3Dhija6wsD+rsAMJllv0fwI2rqrIXXxWQy3OClPi48tvC1fE0L5JN9eI6FJ93NCNFnSRVdr7PqKylIMgiWErwgpPUA6LFAMLoIe+TpsLDXb0ZC2c+A1/wx1BQNZ+/12vDjIbeJmJ6vs/1MGaEX8SXxlMlGi+nI8XaeeWIuon/AMQQTrTRWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=uEg9El4vtReCGxZ2C/l8vlw5wUtnyLJJllGLQMxjfO9+MLaebusvm7O45D3sQfsZuzFZytjIKjHBXlTKJHzORed6gM+/MHz0f2hcqYeJQn4hElW9+7IdqAaTV3l+zFSYwonKO3rca3ShMIGVvL94EX4KkikFNqzgg8bCeVWWPRxNzw2wC+YCo2ddbp4TUOe6LH8TekO4pnawbAIuf6xWTy2Pv/fKO02c3NPgOtZsUuQoPCSWe2dkcPAHrKznmGCaoOixOTNWHiHbvXBLfBukISAK/SwKiqKXQ0JQI6nzCSthAjx8UitXSuwgylRCD3c9M9Zr3L0x6ADw6Y6/Mm2PWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=KLPD0tetSmCYuHWkpXKWL/XiL7E2aKZYDsywG1RR0R5gEjm7jMmnrnSXQEFPDzb6TJmgozE7Tkz0uiAOOaZ8Q3d2seTJbU3h14V+FdW0hyademstOxu0oBEu4J3H9PIAup72lL87Q175SvlsCfuk8aL1e1vOUNPiAMIjoJGtBx8j5839V/+WqZovsWbOlGS8nQGDZJBJDa1ohJtk369HGDIkjnZsWv4fIovmlbPfkbHklH7d9uXT6oWrgWqqxmKOR9hnsJW8+f9ygTK9AYyGLW/ifV4OdG1Fa2Cplv0pNx+Srs1IfOz8hvsDExyzYoR6FJesnvnAA24YKCAKGCswFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:01 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:01 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:15 +0800 Subject: [PATCH 2/4] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-input-cleanup-v1-2-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1365; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=IYFb5BcVnaCb3uUN830r92UAprUHpPfeHJSpQKDJq+A=; b=FfkYBrhoOBQaCtvD5SyQDwaRuLemJLrepWna3F/0nCmeMU9mbPq96bTN33pKCeGNsqqeEMzDF fyuOAEcGZDCCyq69PqXu4/di7aztPtnrUpRibv+9witGdOSQmQBRn33 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fc5f90e-cb6e-44a7-ebc9-08dd457e76b3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Sis3Vi9mN1NxYk5CS01PRjNuRVpyREtqbEU4VHYzaVdjc25VZmNQWHJLZFJo?= =?utf-8?B?dGZDb3QrZk1LYXlxYitQSjlCZDU5WUZCdjBzeVBTSFJOcVZ4OTJBYSt3dU4w?= =?utf-8?B?Qk5tQ3NMRCtMb1d6clFZR1ZpbWFSdDJXMzVZVXlrSXQzbFNWRWVQYnJWREVG?= =?utf-8?B?TEc2RU9EL25TR3RsWlNoZHBkVEJ5dEpoTzFiMFo1QUpXbURqNmdxaXpVeXlk?= =?utf-8?B?SmQ3ZURidnpjelFzL3RSOHAxdFg4Q2xnN2UrazBoVjBiWjU3aXpXaWVyZ0xI?= =?utf-8?B?d1ZxM0hvYnk4TzcwR1JQOG04NU92VUFYTHJBUkFkSXFYKzcxNnlFUk1kdXdU?= =?utf-8?B?KzNoWmpGVnRtZCtHNlVuMUlOVjlWWnFBWWc0R0JGMnJybU8ya2xEVmtQMEJq?= =?utf-8?B?NFVVbzZPRm52REwzQzd5cTJGbTEvSXBKTUlJUk1pclQwQlk1cEIvMDlPU2d1?= =?utf-8?B?MFc1STFSN0IySG8vdW9PVWtvRm1rRGwrZSs5ek8yREVxNDNxeTh5VVNRS1NF?= =?utf-8?B?bC9hQmhIYS9pMGx2aEVHZEJ0T3Z2RmFLenpOQlFZR3hRZkZ6MW1vU2V1MlNB?= =?utf-8?B?Z0tjV3JXWTU4VW9WL0FydG4wYW1TTFpRTmVuQ0VuNDVxM3pSclRPa3Q1QXpS?= =?utf-8?B?aDhHd3lmUkpCOU1RdVQwTmpiaXorS2RZL28yWktIM01teENRZnFjWnA5VFFB?= =?utf-8?B?SjNsc3A1NlFZQnN2OU9LU21COUFHZ2N5STQramxxbWtLZWZLMFVvWTNaalRC?= =?utf-8?B?V2kwNDJFNk5FdHdJMTRsbVlpd1lPeTJxaDQ4YmIzcTA2Z3U1RHRPTU4vSzAw?= =?utf-8?B?eXZDR2hmTTFPdTNjWTUvSk1tYTBFNzhaeGdZNVhzbStBMDg3bjMzWm53d0xO?= =?utf-8?B?WlZXcGUveFJQbDBPL0xTdmxieElKb1dlcFUrNkdIWTdYS1VrS045ZlBacTV5?= =?utf-8?B?bGNZUDhmeUpkV3paOHBTQUpZWU0xK0x5WW5FL0htcDZDeVc0Y2V4ODNwSUIz?= =?utf-8?B?SExva25KZUNDVDVZQ1AyL2F6ZmlLcWkrQkpnZWFUeWwzSlBpT0hJMFFLT1BD?= =?utf-8?B?TmRBWTQ2VW1HNENIR1hhTTFBUE9FV0tMemljeER1b0luRmpmVDJGNlBjRFBK?= =?utf-8?B?L1NKNExCeDZzOFJIVzlIWjg2LzIrbHk4bzAxLzdWZ29qMmc0bGFCOHZzejRK?= =?utf-8?B?a0JCRWtVdnVwZWozRVBnelNjNmR3SHdNei9HU2FmSHYwdnc3UUxVdTlCeExD?= =?utf-8?B?aVU5UmVIRUFPc0MyT2wwMnVuM2Myb0NBZkR5U0FSRXZBVXRQYjhYcEhRbXdy?= =?utf-8?B?NWtLdUVWOFdHYjJOLzF3aUx6US83QVNPejl4MDVnbGRyaWVCV3NBZGRKWVNx?= =?utf-8?B?aUt0eVJCR29qM3pMdjdSeHFQTHRvb0xhVXBCTGJXRm9CNldLdVpyVnVaMVht?= =?utf-8?B?WVh4Qk9RV1RRSW5mSG1GSXlPaThCTDc1eFZ4Tkk5RzA2QmFOQlpiZ3dYbDZ0?= =?utf-8?B?MGRnWDNPc1NQYjF1TXFyT2t4WXRlUnVnZ0RXV2dpdWM2UlQ0TVl4MXBzRURl?= =?utf-8?B?dk5WZ0I3VEhhemFDTnJ6MnRXa2pvSjF5TTFYdm1PakFiZTFYKy9JdmVxc1NW?= =?utf-8?B?VmNNeWQzckFqMkZjTTRsdE0wNXRPUVBVaDRzUUdoYmlZNzBrMUIzQjEvVUpH?= =?utf-8?B?MXk2VzdBTkJLMlVQRGY3QkRwYXBtMHgwQXU0dW54TmlmekFhREh1WEp1aUFW?= =?utf-8?B?Z3FDRzZyODJlenVhN0o0SzMrNytOS0M4c2NXNmtFTDl4NzBqNWhCUUVMY010?= =?utf-8?B?OStUcEczNFRscUdqZFN4bWRFYlNxRUYvTWdLY1kvcExqdlFLTnVabDRVNkI5?= =?utf-8?B?aUxVckZvbHI1K01sb3dURU5lU2RzME5CQnpnWkU4M1g5ZTBsUStPOUxqN2px?= =?utf-8?Q?/3RSVTs9Y0E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2NnUUVLSkhVNk9TTURTL3FTK3J6K3R4UHV5Z1U4NTNlOXdGVVVTWkFGUnk2?= =?utf-8?B?bjQ3RDdzK1BaSEhjaU9OUXcyakJaZ29rLzhaMVg0NjZ5UHA5T2lKYUJsWHRq?= =?utf-8?B?TG9uVEhaRXlhQ0s0aTVzcjF2UHdlNWl5YmlIaEVnYkdjeEhVKys4Rld0c20r?= =?utf-8?B?Qmxpdnd5dDhzaWpQRFhYcFdoZnpDRlVYdWp1V0F0bGU1VkIxWllGWUVRdFZJ?= =?utf-8?B?bE9XVkJONDI2eVIyMVB5Nzh0ajU5bkhydEtMYXlMQ3dPY0Jwc2IySGl1bW5R?= =?utf-8?B?b1BEMjJNZmV2YjlUL1FuYkowcnVsR1lpb3VndHJnc2lMU25ZdGViSmcvVjRq?= =?utf-8?B?d2gwZjdSTTFjUGNrb01CZG9tU3ErZzNKQ3dpRDhtSFF2aXVnL3hoVkxSTkhM?= =?utf-8?B?bnZuZWZNZ2crZ1dWTHJEeWd4QzFHV1M2cTBIazlXOTIzV0VYNXA3dDRDTThD?= =?utf-8?B?NVNsbVlVdWlZb2VLR1RUYlc1Z2x3TFRUeE9mMjNKWXZiYjBxVEx4TjBENS9k?= =?utf-8?B?R0p4RUtoOE96L1hKUjM2RktNelBMWmRORFl3aUc5VldYK3IwT3NwZDJBQTBD?= =?utf-8?B?MW5ncWo0a0JieUFibldvVFozNnErY0l2NmhSRmJoeFhBMDlIZmx4SDhBM0Vo?= =?utf-8?B?QmRHV1grRWhrM1FwL3BaZmFNY0ViWU1lcXVLbTVCUTBaekFHNk5YSzBFOGVk?= =?utf-8?B?bjNEQW1rU1dCV2xYNjFvdWs2YUkwREttSFN2SDJtV2JnRTBNV0w2enhUNlp5?= =?utf-8?B?QlZwaXVhMS9sR2J2NXNmS2liYmZBL2VtbFNJTXRrcEpjYWFiaGd4QWhXQ0h2?= =?utf-8?B?RXdWbHRxT1d2Q1ljVEs2akhNMzQ4NnJaL243dE41U0JTQ1Q4NVdZYWp2L21j?= =?utf-8?B?ZWxoUU5xSWh3djgrMFQ3WkFsRXlRTkNlcy82cDFTWmttYjk1cWo2U2FMcm9X?= =?utf-8?B?bjVPaVlFeUFkWGxxMjVYV1lnOW5CazhyM2VuemFqM0NkMFNRYWs5M1BMUFpQ?= =?utf-8?B?U1J3SjJEaUx5ZEtxa0pwdlNpR0lwZFZmdWpxNmJNMXJqY3ZwZjN1UHV6TWZo?= =?utf-8?B?eGw3M2JOeWM2ZDZueHBnMmFKY1VKSURraTVESzE3YnN3V2g0aUlqdHY3TVAx?= =?utf-8?B?azNETGZLSFBRUDcrR1NwemJ2ZGhUMFEvK1hwMnRza0FoK0tEOWRocGplZ0ll?= =?utf-8?B?VlB0dzRXOWJZU21tNXQxNFN6aUdoUC9lS2RFeDNnWXoxLzBqM1Y4dEJNZzFP?= =?utf-8?B?ZXErUGpZN1cxcFQ5ZTYwK1lwZDduU1lRNHBXY0paRHR5S2huWlltby9GWUUr?= =?utf-8?B?VUtxQWF5ZGZVWkVrZDBmdlEzMFptMTRpTE8yMExFcXBMV2J2cERtekFpRXQr?= =?utf-8?B?dmQ4MEdBeEovSFBlT0gzTzJEK0VKRVZVSWpoOXJIZnY4U3EyTXpCNUMwZHIx?= =?utf-8?B?a2c1SDkySVg5ajNibnJia0dWbWYxQ3VLcnAxeXJlcFpGZ2NBNjRPWjFITXNw?= =?utf-8?B?d01HRlNXWDUxaTEzbys4eThFZlh6OUMzWTkyV2ZjWlhFTURVa1duNGNIUnhW?= =?utf-8?B?UWVCM2JQRW5yN2FjQjRMcmQvQTFEUnVBYnRqSFB0aUFyZkxMcStZUCtvOTB4?= =?utf-8?B?RFZsZjVGNGlRdG43UWlLZEh5RnUvWU1Bckt6OVgvU21MY1VCelVVb3dxVnFi?= =?utf-8?B?d0NyMnU3M0VmTm1sY09OR3B4MjZDOE52WDJTSytIU2VxanNYb1JCNXQwbFZK?= =?utf-8?B?QWtsY2M3b3k2VUkwZDl0ODVNM3ViNm8wTFpQWjJDZ1U4VTBMMm55MXRQTTFT?= =?utf-8?B?dlY5Y2JIRUc1T1FSajg4SDVnWlluYlBEaU83TEdoZ3R3SHVZSGNGMUp2dEdo?= =?utf-8?B?NWZEdmYwbFlsQWxPcTZkMzI2amI4UTdUbzB4T2M5N1NuZXdvNW83Q1JGQ0tR?= =?utf-8?B?VHlCaUs5cFlDTmVOZUNRTm9tU3JUdlRMY3hsS2VHSU1zcW5Jb1ZqV2tiK2xM?= =?utf-8?B?ck1GS3BVVzh3WkNCNk9XVWFTUFcvTlR3ZGxqaCs1eklkdG9yOHE3R0NOTjhy?= =?utf-8?B?L3hyUjVTcnhpWVdRdW03WUE4RmdGWU9GT0tNYWt6RzFOcGF3KzlZRXlzS2xQ?= =?utf-8?Q?J4KXlMihulMcdCaaNX3NkyycK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc5f90e-cb6e-44a7-ebc9-08dd457e76b3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:01.8567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQ6HVuj0Tl1Dq8CWznKXPz2yBYYCKcUzAa2dLggL9PApg8DxlrLY8NMIsCFYiyX9Sk2c6VEpDMEvQm9qFBbAKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/omap4-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard= /omap4-keypad.c index bffe89c0717adf9ebe5b33892efa4dc30b158f83..b7bd649d1628a6bf10db4135f73= 778f62db92647 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -465,18 +465,13 @@ static int omap4_keypad_probe(struct platform_device = *pdev) } =20 device_init_wakeup(dev, true); - error =3D dev_pm_set_wake_irq(dev, keypad_data->irq); + error =3D devm_pm_set_wake_irq(dev, keypad_data->irq); if (error) dev_warn(dev, "failed to set up wakeup irq: %d\n", error); =20 return 0; } =20 -static void omap4_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id omap_keypad_dt_match[] =3D { { .compatible =3D "ti,omap4-keypad" }, {}, @@ -485,7 +480,6 @@ MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); =20 static struct platform_driver omap4_keypad_driver =3D { .probe =3D omap4_keypad_probe, - .remove =3D omap4_keypad_remove, .driver =3D { .name =3D "omap4-keypad", .of_match_table =3D omap_keypad_dt_match, --=20 2.37.1 From nobody Sun Dec 14 13:53:05 2025 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01AE42288C9; Wed, 5 Feb 2025 00:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716373; cv=fail; b=hECi5EhYDhGOA5L4s2XrPQfnhPrfpeSYZ1hbqdDPuNUmXfYTTaPe8v3OqOwHZY2UPa1ZzNfmt1a4oPB4hhqbgE8oEFYDx86G4eGbr0VOSlfvLQlI1729Oin7Jow5U6idyI4yGo77t55FQYtisQg25wMKcpqmPF/dl8MDGol2Aaw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716373; c=relaxed/simple; bh=zQeVfeCxLWPp1ta82McHGDfqjkgW42mBMCjsal6VJxQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g88kimO2GRj66gkvcRqbm2BovTZAd6V9kIbLPY0jY0xtxf83KNg06vXaYDqC+Ks3z2aI4IjDl2P2aQm2jZpspHFgIfm79eBSlPPRD4PMZITtfES4wnfvTvpgUHJf+Y8XYezaX3K4LLQpnzKJRHb+kVBb13p3DsIyr5UgnNOXZxg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aDog5Bet; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aDog5Bet" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t+XEhXwMEz9LBE4IeSxNDxk1Q63lNO7H3R7FY2nzc4Tm4fz5cdOym0BoGpbLat1SVvX0dQKzg06Q0ks6zCSW7QNhhUMwziZGbCwHlNDN8RLGWbo4Cky2ktcvdXahJgrfhoUMT/zepXeeZ6VFV64vT5PTdf5YkYDPxahBa+22UBFjXE2sIJbKSD85ecHahng+A8m4dq2bIbTzeWgt2Cz+pomWB/iHQpnPq+M7orb2WjShlDFvyXOcbPO+RxJzPT5rUM1oRzX7ZFeQqsWRkP5tN5c7jKg2W7+CmD+2axp3gxaoAATaRZQDrGxaoI+vZ4YmcpM9CbgdkJ4DDGSdg3GLqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=KvEumd7WbmkOmFknrAYbPoQ0d4eRVDHwG7DR/UuEv6yGlcMfq22q8mgJZB0GOlWz8YoqrSLkMQotrwEWYco2P4IxAxwj/C8PVT9+lbWG5cQQpZTDBS0q95d+GDcBZkNInbM2hi2yhAWgFaq2wXF53LtEw8AjD4QatWS/WHUP2lkakvd/hPAsESGLh1bpVupahv5Zsnh09BlaPBNcTgaQjBX6pWl8CYW5CHYGAYf5oDpBWZhvJKXNRlT20uDTwEN+iRrTtUWcN8b+Q4bDT61JA3QWAostqflx5mpVHI/eb+cRGtfWlpF8tXuGLy31h4ZOMAg5fcqn04sgQJ5+WBRXnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=aDog5Betj8yK/B8AI8pqhiNQUWP1xym92WwWlVNds9jNgMTknsLoB5wePLPwwk7RmayqJCG2es74UjwiWTWs1mbCR7f2HRohImiYJduMQeTOM/rBOxzrHKiX5qhfljHI2FC9kIHjH7kjv4QKMaFata2gs1n/caJm56JuTLV7oTPhrRH2cuzz8esWZ7XwfDbWaxlLSJiZibJsG5k+p33rUrcOPU+v5RpaVY0GdJgsol50PD+YGp3vy22yeQd4TBivR64QiTZPQBf+ks3qbNp1UCoZZ8jC00FAEpyhW8efNoJAjLkySdV4ztmG7Q4q5ZZkati3vF3fu55fOKnaIVCZMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:03 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:03 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:16 +0800 Subject: [PATCH 3/4] input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-input-cleanup-v1-3-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1523; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=g2vZhAdAlG59tJHA7zmPtBw4oLxwHW1tSbJmlo9rLyg=; b=F9TW25kz+xXABLmaH6yb/mMDlaYy4cTOAR+MsjSq1CZdIy+avdAjWxqBxOZoHtxMnrQ2Lhb2q acT9Dtv/0ZyAuKqEhKwCvPI0c5nPy6DaSGUprEh9IIX90MOqwuh/i6r X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 19780e12-73a2-43c7-62d5-08dd457e77e7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SEZITTRBYndYU0ltcHd1S2VMcmpTdFZUWEVwZXZwTVhBeDZLSlRDUVdGWEt2?= =?utf-8?B?c2RDNVNqaVRycVRBdjVRN0VEYm95eFdXQmFoVWs2N2xxNlhLTjFmSXc5ZFZ1?= =?utf-8?B?aENQTFJ6OGdENFphZ2dQQ0lpU3RsMFd4Vlk4dEw3Rm5iam91UXNiOXdNN0Rw?= =?utf-8?B?TEZyQ0lSUVFZcnRxUHNPWWNQTCtEL2tqY3VpNG9GZkZQTmJtZUtmUWpsYjgz?= =?utf-8?B?bmllY0dCaEFMeWtNdHdJMzZKTUtUREw0bzJDZWdMR01QOVJhU0Y3TGhDc3VR?= =?utf-8?B?TzlXakx0d1JrREdiT0YxT0dTcjlUcFBYbnl5eGVRZnVqRHpQNEVsbXpJeTl3?= =?utf-8?B?aVNMWjJzN0NFRnNzSkIxUHRGa3dDMGtPbGNaaUtxa0VRa2c0bTVwVXVWaHJy?= =?utf-8?B?R242WUxCMkZ1MlRaa3NKNFhpY0FnMi9iSFBwV3F4UEdiQ1NmTnZPcTY1SDR6?= =?utf-8?B?Nml6bWRsbWc0WlY1bWxPR0U0VE9CT2Y2bE9QaE5KTnUzclJUT2xTdVdMa01x?= =?utf-8?B?L3FsR2NVVHZPTG5LcUkvdVI2QlQrZkVxS3o0ZjBlZUNaRkg2aEhvMkd2OVVU?= =?utf-8?B?Vm5HU0VQWmgyOHNwaU5jMGY1VWFncW4rcGRUN25aMzN2ZmpMTmhOeFVOYnU4?= =?utf-8?B?ZTJBRFE4ekZxRzkxOC9nbzVDU3NENzAzNEhzNVlQeDRla0xSWHVzZW9mU0FR?= =?utf-8?B?SGVTRXRTcCtPY29EamtqSXNNcm9DaFVYQ3pLWmhLQldiV0lWTlUyTFZuWnZM?= =?utf-8?B?VTkwRm5KWDV5dTdyN2VkU3V1QUkzL25aalFKN2lDTEtYN2V5cksxenFuSDl4?= =?utf-8?B?bWVwU1VrUk8xQzVHU0VvS08zbVovbEVkdUdiLzRiNDZ4c0ZZTitZcXdTWTZO?= =?utf-8?B?M2w2YXpRKzFmZW1NL0NmblBCZS9qdUFuT2toT0lwL1I2UVYzVGVNMWUwQnZE?= =?utf-8?B?b1dXZkIwdzZtekpESVZLTVBURWpnaEplZWJDd0hkRE9sWG1semFrbjd3Yk9j?= =?utf-8?B?TnhoUHpadm1SdE9yQzFON1NPSU1TTkMwSEZZNmt1c0QvVlV3ZlZYT3p1WExP?= =?utf-8?B?dFlpaDBjaU5sbXJYSzJXa1VUZDZSOHU4anpVai9BbDBkblVESlVsOW1IOE1t?= =?utf-8?B?dmIyKzZ2eU96dVFuZy9yRUQyemduZXoxVm1ZUERsQmhZbDlXS3RXU09rQy9G?= =?utf-8?B?ZzJzRjNVeXlHS3d2TjZxOE41Z1JDNm0wYk5sSUhyTnEveTlVN0lCWWNDNjYw?= =?utf-8?B?YTZUa1ZzRTJ5OW5VQUFMUE1DY2dDcStkTDYyQTFvemNINGk2M29ZdWtucnNh?= =?utf-8?B?cHdlMi9BU01lK1N6UVhYYnhwWDVHL3VJUS9FSjd4NTF1b0xuUy9VNkxxcWlh?= =?utf-8?B?UFl3L0sxa3lBSGdVOWs0cVpubi8yU0FyQm1EWDNSRHlvM3NMaWZxYjh5Q0VN?= =?utf-8?B?R1p6Yzl1dXY2WVJTNTcyL2FKYzF5dC95Z1BGMXNlV01KUHh5SUM1Q29WVzVq?= =?utf-8?B?aThKbXpKU3ZHWDgzUkRMNFBjSTRFYVZ5SnFIaGlnbXRCRzFmYUViNGIxZ2la?= =?utf-8?B?dGFINm9IWElYc0Ewc2pBdWRRdVp1eEZ5UDRzMkRPRUV3WlpUS3RYZ0hNdnFY?= =?utf-8?B?aGpuMFljWEszNHN2aUhCNWk0WEErNUNpSE1mdUdWLzdtWEgrQ1NiUE9zVjZW?= =?utf-8?B?VHducERrdzlIWkdJUEFreXhxNU9RcDd2aUZMaUlkOW16NWN5WlRHQUdnOVZY?= =?utf-8?B?NmpLRGcrUVRFREFhZWlvRmd3MTZmZGJSRDgxelJtNWpWalNwWENzdURwZXZU?= =?utf-8?B?VUZsbjdtNlRrV0VnYk9rdjUxaTFsV0xrbTY0UVpadUV4dXQxRmwyTmRJckJx?= =?utf-8?B?WnQ0STBJVWZZMFV2MjdPK2FRamN1VFZ3ckc5VjUxWHpQZlJGNFdJTXJMZlZW?= =?utf-8?Q?ZFvrdOA1ams=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTBENHBCZkNMRlQ0a1FLTzJzbEU2Z3NFLzVHY3UzcUtaZDJxWWIrYytFb1NX?= =?utf-8?B?QVpHeHFJcE0relRBdGV2cEFEMVU4ZkVjL0Y2SXcyM0FLeVlVSHVZcE5Rc0Qx?= =?utf-8?B?dytlYmMwdmplby9GSGd1aEFnbnBSanduRnl0ZHdRMXdtWkpZUmZBUkoyKzdy?= =?utf-8?B?VXNocG9DV2xIK0pQcTZURHFydEJ5NWVMN0hvbU8yMTNMQWRjNlp0UlpxSGJk?= =?utf-8?B?THl2OENVbmFScmtQSU5QdjJTWUg1emE1Wm5YclhkVVpLUTdrTWRTOXFpOTJS?= =?utf-8?B?ZTBURDNWZGRQdUF6d0VrcURES1NLalRlZTZacFNxZ2pyUXlXTEcwckxsa2hp?= =?utf-8?B?M3YwWm15R25CRG42bm9Ra2dlMDhEb3pmMnBLQzNIV1cyL3hxSjdMS0ZPWW9J?= =?utf-8?B?NVRwNjZOYzNyWlZCOE5HaTh5SUZFamV1bkFUbVdrOXJDU2hKNnpuU1BqWVN5?= =?utf-8?B?VGx0dk5kbTlqUUJEdXFVK0tJb2l0QmoxSlFZcm5taFh3RGJ6WG1iVlk1S29F?= =?utf-8?B?SnJNWGhrWm1aZ1ZFb3NQTmNvZExYUU9rc2d0VWtVZjdNTytvNkhEUU1ZUnhF?= =?utf-8?B?dnhkU0x3Ymg4YlNZN1c0SEJteHVOekUzckZOcVd4azJUQUNQQXJ0MGkyR09V?= =?utf-8?B?TVp4ZTNGTkpuUk9TRUxOT1pvUEZFaUZWNnNOOVUyNGg5T1BVcGJMSkI0Zmox?= =?utf-8?B?bHFIVkNQTGNsVXFpV3p5cW1NM3BnZHlSTVZNQXp2S0RqR2RtQTkwTmJiM0pU?= =?utf-8?B?MUdxZ096UXpWazV2b0NjdGdpZVE5UHlodWQ5eHBJSVdDSGJBRHN5VUxaSmNK?= =?utf-8?B?T1NtTzlZUDZQVXZ2N3c5Tk5HQlZTdlR3ZTM0TzVwSnBVYStPeWVacGFzSEZv?= =?utf-8?B?UkI4eHBQQy85ZzA5M2ZSVnpTeFM1RE9ZcUkyTnpUMFViVlBEQzRJcXloWDBh?= =?utf-8?B?SVhQZU1aTmFRdWxkYmN1VnVjNFZZQXRFcm1GV0UrcG1ESTlreEpIVjhPMFBn?= =?utf-8?B?K1pjQzI3Z0l1QmF0VTZwcW5qeXl5Wk9NODgrcG11Rm9sS1RlQUtPblRTVFJ1?= =?utf-8?B?ZVpkMUlEd01aQkE1Nm92b3lqNHZheVFUT3U2dzVKRnlrZ2hNMkVibHI5NVoz?= =?utf-8?B?TjZLdkduNWdxOXp6akNGWlltelZVaDVlZnZidzBuN1V6dmVvMUI1N1krVVIr?= =?utf-8?B?bk5tY25ld3VQNmh3M0ZqYTVzTC95em42U1N6YUJNWC9wWW11SlZMNmlRSWJv?= =?utf-8?B?N0RhSzlLT2lUMFIrWEdNZDdxWU1SK0YwSDFJMjZZaEJlS1kzakRIdkpqV2lV?= =?utf-8?B?SVR0ZXhoWDVhRnFjUDFCUDNVZlFETUtTb0ZkYVg0SE92SUFWZVB5dmt4Wi9S?= =?utf-8?B?ZnB4cHhVaHFWYm8ydlBickIwL2l1eSt4MHZxKy9ybmFWMkxUbzNxWGJYdG5T?= =?utf-8?B?ZHA5S0R0ZTV5aHdNNUZNYmVJaDJHb0RuWG9sREFabWVnUThNOWliVi83VVRQ?= =?utf-8?B?TFcxS3FWeStKZlJBUVFTSEhTczBrQmtiQWp1Wkl6NzByU2I4Z0ZaeS9PejdF?= =?utf-8?B?amt3a0FHVitSQnk1TjVYcEkwN1AwU2pRZTJhTnJTNWozT01tWnZXR3ROd1Fu?= =?utf-8?B?cjh6Qkd3SzM1dkVzRHBON0NPSy9ldlRLRVk0cmhjS2lVbjB4WXhORDIvSThE?= =?utf-8?B?Q0FrRWdtMTJkRjlQN016QmsrN2FpTkx3ZkltYWF3Sm1sRi8xZXc0K2J6VWJz?= =?utf-8?B?RXY1RU9jMmVwY05GMGcyOEtvZ0NWaW8yNG43SHhXd3B0bHpRblhDWGk0eW9i?= =?utf-8?B?WklFditwbytlbmZPeDJoK3EyandnWXNyNGY5anpjL1NjTVNCRUpBWm5INlAz?= =?utf-8?B?VlNmZytsYzMxUnoxUU1ua29NbmIwT21icDhIVzREdGY3OUFQWnBMbi9HUlZY?= =?utf-8?B?UWlDc056eFRxRytpQmh1cWUrYzJUWktWTlFhTnlHbDlnWDJRNzVyRWFYaTVu?= =?utf-8?B?TkNZK3pZaTFvcEIvai85TjZTbGs5a0YzLy8rTzVPWU9pNE1EUXRobWM0T2JW?= =?utf-8?B?VXRWZHZuYWwwem5XVzFZVlZySnBZR25KaWpYMm9YcWJ0QWZPcll4V0tNMWIx?= =?utf-8?Q?EVQ3JliCfy2BxxgMxMHaet3PD?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19780e12-73a2-43c7-62d5-08dd457e77e7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:03.7305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LTogL04aT/TcN3D8hrCrH8ArsIBecNVAoGOLgiF2uAgqBZoSBpNfsx9ZIlTJH0iNi4kYlX1YpwYo1Kz5rRg/sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/input/misc/nxp-bbnsm-pwrkey.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/input/misc/nxp-bbnsm-pwrkey.c b/drivers/input/misc/nxp= -bbnsm-pwrkey.c index 7ba8d166d68c18b396e616f6f9074ae98c4629b7..5faad2c98af35c52dcacbf25728= dbaf2cbb3c625 100644 --- a/drivers/input/misc/nxp-bbnsm-pwrkey.c +++ b/drivers/input/misc/nxp-bbnsm-pwrkey.c @@ -179,20 +179,17 @@ static int bbnsm_pwrkey_probe(struct platform_device = *pdev) return error; } =20 - device_init_wakeup(&pdev->dev, true); - error =3D dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + error =3D devm_device_init_wakeup(&pdev->dev); + if (error) + return error; + + error =3D devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); if (error) dev_warn(&pdev->dev, "irq wake enable failed.\n"); =20 return 0; } =20 -static void bbnsm_pwrkey_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static int __maybe_unused bbnsm_pwrkey_suspend(struct device *dev) { struct platform_device *pdev =3D to_platform_device(dev); @@ -229,8 +226,6 @@ static struct platform_driver bbnsm_pwrkey_driver =3D { .of_match_table =3D bbnsm_pwrkey_ids, }, .probe =3D bbnsm_pwrkey_probe, - .remove =3D bbnsm_pwrkey_remove, - }; module_platform_driver(bbnsm_pwrkey_driver); =20 --=20 2.37.1 From nobody Sun Dec 14 13:53:05 2025 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577E82288E0; Wed, 5 Feb 2025 00:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716375; cv=fail; b=I794mPEKdV/IGk70i+t1KK7O3EGkWr1ZVU1mkPdY5RNslkSc9kF8I382KVKZGcMru98QI9Kbl+5ckLVI1FnljVUw71EVJ/jnf3FdlyjsKc2aPfBcBJdgBH4s3fN+HAMKunNMXElY+vS9wwvhwPHAxIho5kY7cNzCpD6SAqvn5V8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716375; c=relaxed/simple; bh=yGvaO4CE8KR0YjpwnelDEdIH1YkR2FTo1uOdpptvhd8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mKGco8nVoBaoNvwPXqP2yCpU85sDhS6EwpmdVhAXucFenYFEolkxyACcYhfCaRkR2E/cQII+v8NpKtNPfxnZ2HOvO52wurHkg7DqDsuJCVVBBV74eo8aSnEIPRkXA6eBubkt3FMCN2dbp9pdTF/z9MSkxVqRJiHc/lv4y5jpSes= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=nNqVRm8M; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="nNqVRm8M" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R8IS78PrAn1chKKm/8pa8WXCgJeJSynvFnpDRrOJUTaSh0MW8SmYvtKSe2hZ8lIdlcv4v/QmtzHaPUUgQ7mfe3e2BQ+RpYtKRxrbae0Tm30b7Zk9q1XmdH3U77nQ7agmw+IM0GsqolPvUuJouKNZQm6gaxhF11S/PUsGVAu0dyQSziHXBqouSPpo90UhrPBe0GDWpZiihzZf5YthdptfwVuupMyQ05fZNGpEEZ48JVcrTad/tO4Rvm7sTFhGxfdviLc154esIMV8Q0NksUDr5T+8oo+9Fl6hL0ILyNCovUDymo+Y0LSoihNGpW9m+OZFJZSf2n3xpAWug8OLBD+Kpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=H99EvhV+zhswqkMBOAlx3mEFapU/CIAC9RScVt4wQ7mqIwi4P37o3E8lKsYKobjiD7rZUAQzisMwqwj3MMB44eIB+z6jBexG4GhxcN826U36J8J/nnv4TTxjKHuIUV7EHeysar6i4RCJxr4RmVDBIV78a+BnWchSHFrKNig4QjCEb8p2gCtE6NqFxULrdyB4Ur4e4IMHtq8rDtUUiQUgAC9kBxOY6jFOIOpRxc6iMgqPsnHH7QtskNKNdj+BeouPtc/m9+nXI0KS15xFIU6tFbG8UwvjAwE95Ue2K+UVPgmbAIpmGVjWH9r5LTUsrqDpnQ/dxWM6SGmGNw/js1m88g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=nNqVRm8MiFmcLLehNIEGjmyEVThQKuPAN1vhKjPhVbfbZ67NRLQALqfCVrLYcaccdwIMhLVS8N5b+mdChiG/JDNnMvlRsUYrPg4ir00pItlwaMjEBe0/0s7GDa1zLXZClEzRRT0JtVWb+NH2JZXxWqvPgvIK29VB+3n5Xa/vcNXcqOSlsJqeDJ/oBPrpalTSjU5hERAsBZzgmtSkx5j7sVIpIpcFxvX95Th6xgoCoSs70YzlUbHDfVhgqxjRHTeS1wqdZBKrubDwXpL1NW4/LKioqE8WqTIIlYn9/69D0ZhVSsLbVReMGrU7Yt2kUi2oN9KgZn7qHz2Usd4hdXa28A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:05 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:05 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:17 +0800 Subject: [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250205-input-cleanup-v1-4-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=3411; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1lZmp/EoQtZDgK9cRNpEHi0IbcGjqZ+/tYP3nl5MGB4=; b=DgvMfxudnP8VmAR/dqhrCBmy8vN9qi34oTNOmcn54WRJFI9MBo2hO2FeA2MYMam2VkZenkwyT ZVqSCnZ4D0IA1QHZoEyl0kTFw12bjlwPBCWwiGjxZy8uNXD9E0mrguM X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: d267fe25-30a6-4da5-8362-08dd457e78f7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFE5WlVjRWtxbHNBV2Z3RkxkU3duc1lyUWtNSVBRSDlBTkxGSlVNK00zYndj?= =?utf-8?B?SWlkanRYOSt4aTNLbUp2YzI5UUJmRGh3S2FEVFZEdnEvYlhQcGNTYmRnN29v?= =?utf-8?B?bzZ6S1U4TGRWc2JaQmcySVRrSzloU3J6Ym82UVI4ZU5rNVVHRHFWWno3TUpm?= =?utf-8?B?MHR6Q3lNYk5YNlMrVU9jRXBEKy9kQXAzaWk4bVVJdWZyUnZtbUtNQ1ZzOGwz?= =?utf-8?B?bFFFcVRrUmUwOUJuVk1qZXMxc1Q1d3FYRGU3aGZZUXFyRy9PaGtHMEpPaEpq?= =?utf-8?B?Ukc1ZjlkaUMzK1VhV21GWEFTa1VQaDNFcjM2K29hTm1OL0RYUFZnUWhnd0VN?= =?utf-8?B?NXhxMGZGSnh3NDJPcC9DQmZoRHhORXhjRHdPandGZzlzb3BOczk3cXpiWnV0?= =?utf-8?B?VnVQQXRoc1V3b29uRzUzL1BtcTl4SUtQQ1I5MzJQZVBiM0U1bWNzV1pDNGtC?= =?utf-8?B?VGd1UnpBcStQd05jR2VHYmVuMDAyVUJadk1XYmZIQ2xPZXZ0UkZBaFU3a2V4?= =?utf-8?B?K3dUSG5mdVhGTUY4dTIwUmlmR1IwNW1oWVVPZEJxaSszOXZmYWY5anJaZFcw?= =?utf-8?B?dDdSN2kvVG40MklvdXlhNFlxaFBYSVVWYmVHSzVBcmFkY0U1TTV6TDBxbFhR?= =?utf-8?B?dlppanUrd3dabHlhdGhIaE9mS0pUWFZ6cjZmSDEwSW40WFVJQ2J6M3U0VEto?= =?utf-8?B?Y2VTZ2EvdER3SXppalZSUDFKaDdld0tuMEJOZzFpcSszbUh6NUFncy9qZ0Ix?= =?utf-8?B?NXMvRm9hWkZKUXZ4dEZvK1YrY2tjaEsvNW5tZTMxUDlVd2kyZ1MyaXJ1TkdT?= =?utf-8?B?di9ENHNGemNGV09URjBNUm11R0h1T1NPNUZkNnlrbWdnN0ZGL0Rjc3FiNmZW?= =?utf-8?B?T1lXK2YvZDZYN0RFdG80SVhIbTJ1eXgxaktTcGVhMjYyRkt6ang1eWw1L3NI?= =?utf-8?B?R0VUYm5Uc1J4VEd0MXUrZllKVkVwUEZBZGlvNUVGLzg1dzlxTklHZHhCNjIx?= =?utf-8?B?NnhWbU9kbTZrNXFNV0l5ZS9NNGNUa1pvRmF2ZDZBdkpIdWt5WHVKekh6UjUz?= =?utf-8?B?b0d6Q0c0VnlXTjhIT2pGZlRjdTg2S3I3N0ZpVkk5N25QNFNpKzlKb3g1V3NB?= =?utf-8?B?VEJ5aUEyM1hlR1p6TVNPbnk2YmhUMGZMTTZad1QyYURJelNmSGVFK1ZYQW5J?= =?utf-8?B?Z2xwS2pXaXQ1YUNncURiaHpqUW56VHhWSHBzbUQwdjEreDNzOVdtclI2b2hu?= =?utf-8?B?VGpvQkpQTXlwZ0Z2Z1AzZ0hzakhvTWU1WEh4andidlJ1UDY0ZkU3R0Mxelp3?= =?utf-8?B?RURCeGhyZUhxYzR3L2t6U0tLUlpSY09UVm04MXN4bk53V2MvMGx0enJPbHVS?= =?utf-8?B?UndvMkozNVBra241TkxxSkZCQUJiZkdZNmw3K1V1WmQ1VjJ4YVdNa0JzYkM0?= =?utf-8?B?d1ZYaFRIUjkzTkovR01yWlpiZEdncXZ2SmMwcnQxUzhUTnIrZzFmQUVuTWpq?= =?utf-8?B?ZDlzZERYTzRXWEtsUkttSlZmS3Bkemcyb3NxZ1U5NGJUVkFOMEQwcDN1SWhT?= =?utf-8?B?MWNacE1IY2NnSkZZQU5RYkVITy9EZ1cvNjBXamtiTjhLeGw1dE1yejFpMVJo?= =?utf-8?B?a05ma2xybG9teTNtQkNKK29KVEZsQ3kwZ1lER1hLeDBGTjZldWJRcVJuZ0hT?= =?utf-8?B?UTZOaVFBMzZvaWVUdGkxWVUxUXFHNFh1SThLUGxQaFhGM2x4TWZybDZHTHQ4?= =?utf-8?B?U1hkYkZFclZpMVYyblVWb2tFdGw2a2xQbzRwMG4xazlPdU0zM09Zcndhc2hF?= =?utf-8?B?ZUd3SWNyYjZvTG9YYkc2VlQzTGlQTnN1SUpWd1lyZHFuZkRUaDUwVW5FZXJI?= =?utf-8?B?N1Z2RENRQ1dEUFBOQVhEb1Zpc092MjFtbUtocUx4bHgwN0lVbmpuUkRwRlFY?= =?utf-8?Q?Oe2k3YJhfeI2eU7lDgYtqrTbL6k4W9vV?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUV5MEMrL2ZqZmYvejdhalk5Tyttei9Vdkw4TXBDRmU1UHE1Rk16M0F6RWM5?= =?utf-8?B?UWFpazFwOGt3YW5FRUFJcW9VdnBBUExsMW1GeWtwTXROWlQrRWUrSWRXT29y?= =?utf-8?B?Q1dUaU5EZDRSbENueG15MCtETlk0SlhyVnhaaVhqbHhrZnU0Q2ZmaVdIL1NX?= =?utf-8?B?RGdTMmFhQmdvMDRqejZxd1J2TmtyNmxDZXNhRDdzVzZQR0pwejAyaEN4Q3Mz?= =?utf-8?B?d2hlbjM3M09pN2djU0NRM09hRmMreGl5S0Job0x0Z2N3Y1Fwc3FjWW45bGdX?= =?utf-8?B?bzJQT0dleGpsdnhHM0Y1cUg2S3FIOHpaSnZ5TlBEbk5MYm1CVysyNWNwNnhs?= =?utf-8?B?QkpsMTF3TElPNWtTYmlaUng4bkZZWWM3M3JycEUxUloyVkVHSENvdDVBSVFt?= =?utf-8?B?N3FvSVdkeG5ZN1o4Ym1jRGZaMHB1OHE2RU5OSTNyNFEvcVdwR3dXVDdhcnpH?= =?utf-8?B?OVRLemgvY3E3YmthS3VtRjhFOThhQTBCZURib3JsbFZpOWZjcHJ5eEhIbU9F?= =?utf-8?B?V1hidWMvN0llMWwrOHMxdTduLzVqYzB0enhERVBZRDlqOTk4dnFoaHJCK05q?= =?utf-8?B?azVWd1FVZ1dzSlgvU3dXak1aYUtwV3BaUk9FZndwcFRwc3ZaZkhyWC9qbmhm?= =?utf-8?B?clV5elVkaHRCV0NjOHUvb2ZSUE9MQ212VC9HUFZybExzVFdRdkE5OTlyTVJi?= =?utf-8?B?aWoyS3JKdk95WFdJZWtTWEwzSkt0dWdadFJHVjdZREdsWVhPM0dOUDY3UWUr?= =?utf-8?B?SEVyd2NobWxQanRTdit2ZTB6SVZ3ZEM5K3Uxa25kMHpuV2ZPS1hGS1JmZFJ6?= =?utf-8?B?T2U3VTdVa3FINGxEQXhYM3ZUTUQ3VHRNK0lCMVlhL1hmSnkzV2R6RDJxYTBX?= =?utf-8?B?Q2FXVjBoMWxidFhIbDNScklNY0h3dTF2STIwUHh6eXdzdTNwVC8rd0o1WmpI?= =?utf-8?B?MCtOMTJVVE8zdnRPTGFuZ3kzaEZzWS8rdHZoSHZLcUV0QkFvdUpQQUdCUTky?= =?utf-8?B?T0FSejB1SzBjVEtMbHNGZ0dlTzdkbWVZNlUrYWtBeXhsY1A2M0pMY3JxMDhk?= =?utf-8?B?Um15UXF0eFlPQ3A5TFVvVXJma1k2TUJXVmtSS2F1a1BLMWJBT1FURVdHNmVD?= =?utf-8?B?RmZZY1NNNUk5b2tSRVc2eWpUdXZGek9pSmVwdzJMNEU0YlI4SlZacjYvTDk3?= =?utf-8?B?SU54WW5uV2ovdmNIZjRZN3Jta3pKS3BlNDh5WXEvQ05sUXRWeVRJZ1M2KzVI?= =?utf-8?B?bEZUTk1yeHlMNGNka3dOSkEvK3JVaUlONHlYVmhpdVhrdVRCMmFseVI3TUNZ?= =?utf-8?B?Z3JNT09SMjdsTHhmb252alk1NXFadlA2QmZYaDBldDBmQVcybzZQTmdNcEhS?= =?utf-8?B?QXkzQzVsVEhIVTMvRmI4S3FmZytuYWQzOXVyajlzU0dXNWlXbVlQVTQ4T0dL?= =?utf-8?B?UUpoTXFyOEhQdWVoMHZINlgzZ1QrTUw5U250cmZKL3RIU0pRYy83SG03TS9K?= =?utf-8?B?elZSWmhhNDJYNllXRW03dUM3SGJLRXJNcEpUa2xVZ29ZS3NzcVQ1RUVzNlh1?= =?utf-8?B?Sy9hN1JFZFdQUHdkZHJpbmtEa1d3MW5ieTJVb3hxaXVoSUxsQ1FoS0M4NXlJ?= =?utf-8?B?Zk1YVWJ5dldvVWQ2VHl2Z2VEbVFRNzFuVFZlVi9kNTBzdEVMNUFLT2d4WjZ0?= =?utf-8?B?QjVxNnBMRlFtR2x3U0dGRTE1RURhSUpWc1pqdWFwV0o3MWg2UFBXNzhhMDh2?= =?utf-8?B?NXAxT2puNHdPSkErcmVjeExnek9MSW5FR3ZvSnZudHdzSyszbDFEYWRJcURE?= =?utf-8?B?Q0dIZEZTeFFjSmtpbE1zWVZvb3NKcTZ0akFtQXlBdzRXOFg3ZDdGMTJ4Rmxv?= =?utf-8?B?Njc3aGdScXBRTEpxaUJnMDNiKzdtZ210enpicXF4aTUzWCtqRVVIbzdVYlNp?= =?utf-8?B?MGlZRmcrYmVaNEo2UTVlUnF3bXA2K0xqQlh1Sk9rRFU1Wk9hK2c4WWRQbzZP?= =?utf-8?B?bUt4VnhIT2UvMktlall4QjAxalBBd055YWlyanV5WEZhRGlHYXdNaEtIR2FK?= =?utf-8?B?a0gwQUloRURlejgwM01pYXk4OW0xQzJETjd0Ym1TKzYzODhoYWt0Z2M0R2ha?= =?utf-8?Q?imFqi547GLqGchUBDC1EqfYfj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d267fe25-30a6-4da5-8362-08dd457e78f7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:05.5394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mSV1+6dVHybSwQjniLqegs1LKiSrgk61RRfNdaUhyIFTRFxv4a3O1autGDDp9pN0Cw19TwjbWwws+0yGuGi+8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_input_allocate_device/devm_kzalloc/devm_request_irq to simplify code Signed-off-by: Peng Fan --- drivers/input/touchscreen/ti_am335x_tsc.c | 43 ++++++++++-----------------= ---- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touc= hscreen/ti_am335x_tsc.c index 93d659ff90aa94ecbd7000fe05e0eef8ab3546ba..aef38b2e4e464e3b76395de5991= a0f41b4f852f4 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -418,12 +418,11 @@ static int titsc_probe(struct platform_device *pdev) int err; =20 /* Allocate memory for device */ - ts_dev =3D kzalloc(sizeof(*ts_dev), GFP_KERNEL); - input_dev =3D input_allocate_device(); + ts_dev =3D devm_kzalloc(&pdev->dev, sizeof(*ts_dev), GFP_KERNEL); + input_dev =3D devm_input_allocate_device(&pdev->dev); if (!ts_dev || !input_dev) { dev_err(&pdev->dev, "failed to allocate memory.\n"); - err =3D -ENOMEM; - goto err_free_mem; + return -ENOMEM; } =20 tscadc_dev->tsc =3D ts_dev; @@ -435,18 +434,21 @@ static int titsc_probe(struct platform_device *pdev) err =3D titsc_parse_dt(pdev, ts_dev); if (err) { dev_err(&pdev->dev, "Could not find valid DT data.\n"); - goto err_free_mem; + return err; } =20 - err =3D request_irq(ts_dev->irq, titsc_irq, - IRQF_SHARED, pdev->dev.driver->name, ts_dev); + err =3D devm_request_irq(&pdev->dev, ts_dev->irq, titsc_irq, IRQF_SHARED, + pdev->dev.driver->name, ts_dev); if (err) { dev_err(&pdev->dev, "failed to allocate irq.\n"); - goto err_free_mem; + return err; } =20 - device_init_wakeup(&pdev->dev, true); - err =3D dev_pm_set_wake_irq(&pdev->dev, ts_dev->irq); + err =3D devm_device_init_wakeup(&pdev->dev); + if (err) + dev_err(&pdev->dev, "device init wakeup failed.\n"); + + err =3D devm_pm_set_wake_irq(&pdev->dev, ts_dev->irq); if (err) dev_err(&pdev->dev, "irq wake enable failed.\n"); =20 @@ -456,7 +458,7 @@ static int titsc_probe(struct platform_device *pdev) err =3D titsc_config_wires(ts_dev); if (err) { dev_err(&pdev->dev, "wrong i/p wire configuration\n"); - goto err_free_irq; + return err; } titsc_step_config(ts_dev); titsc_writel(ts_dev, REG_FIFO0THR, @@ -475,19 +477,10 @@ static int titsc_probe(struct platform_device *pdev) /* register to the input system */ err =3D input_register_device(input_dev); if (err) - goto err_free_irq; + return err; =20 platform_set_drvdata(pdev, ts_dev); return 0; - -err_free_irq: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); -err_free_mem: - input_free_device(input_dev); - kfree(ts_dev); - return err; } =20 static void titsc_remove(struct platform_device *pdev) @@ -495,18 +488,10 @@ static void titsc_remove(struct platform_device *pdev) struct titsc *ts_dev =3D platform_get_drvdata(pdev); u32 steps; =20 - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); - /* total steps followed by the enable mask */ steps =3D 2 * ts_dev->coordinate_readouts + 2; steps =3D (1 << steps) - 1; am335x_tsc_se_clr(ts_dev->mfd_tscadc, steps); - - input_unregister_device(ts_dev->input); - - kfree(ts_dev); } =20 static int titsc_suspend(struct device *dev) --=20 2.37.1