From nobody Sun Dec 14 14:13:22 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B489D215F7C for ; Tue, 4 Feb 2025 17:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738688727; cv=none; b=YmKegkGhh1ZsWoyVT1FLw10uH8Ml8BhtfUqd7QeMlOCTaSwAN+ytpY+EJDtLsulsGi0hrfTts25GPKkt3pnGMgZDaidRgUVGuF2Gysh9Bcp5QXnd7W2/jeqbGEgqKRPkUmD6UCWjPF1+75PzLbNhwF5QnJNfhK8HAt8gnIyNQBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738688727; c=relaxed/simple; bh=2zaqtMLmaEiFWQIT21mk66I0QwlyJgIFFDVjO5lJIGE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jWK70w+UckktH4/imK2jn2lfd/N8MK4X7Yk6F62KAuM4e240172T/s1AT/p2DK4pQwJwXa1JFdRzVKKR04353nbuGQlwfj6GNxeRT1UnHR5+6JWVoBsS2BJX+vdsh+To+r3z5Riraqa9bADliJ0gG9JpImCpnwxgJ0NdXF+riUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=molv57UD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="molv57UD" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 514EWWLU016940 for ; Tue, 4 Feb 2025 17:05:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hBnMagGnfmOlAsemSbgdCgpnsrubY8Yw3Y2FnZmojeU=; b=molv57UDlDd9WkLo 8+qC7qFNNgf0wJw6FWgrscoHiGd7NMQM0zYffu+zBU91gM+o+FKpl1/rgRTQkG7J 7dN5ghgdKcp90NFnsx/LjT/xigoGt2nY8isNfzEcLdg4nnx++RpNLzMnCINKOI6O rOPxij9vONyloAgdaT8CtwKmyt1rt2U0RLdEDsYhZaWMcV5kifbpTPYB4wiprEEn CiMPfSHJTTgvbcbz7q2iUH9LDkHbsTUVnuTkvv8TadS5s+XT+AN7HfRoYbkajz1q vUbr+9Hy1+4/I9hHLvzvSK3/AS9WZDgslcDtFjSFepQy8TAQ1G2YrRugJpYslZsU tlf/LQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44kmre0ck8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 04 Feb 2025 17:05:25 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2ef6ef9ba3fso11260335a91.2 for ; Tue, 04 Feb 2025 09:05:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738688724; x=1739293524; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hBnMagGnfmOlAsemSbgdCgpnsrubY8Yw3Y2FnZmojeU=; b=ExOi6THiCgMaE8kLb/18W3W6PqxuGqxOT620ER35VXVyg/cZfwRTDUoNN9OOGe+iwc AArjbCLgBsVi34O5JmkPFC6l5HA38xBKYUXpS0hXKQV7uhFQc9NxLFSoC8i37W9K1F06 TPMbidJuza9RELZbRxIT7HuyGdct3H3XVHm87llYX0aDa9uvSPoyzaFiaPVujZB1Gsx2 0JtZLoG4n93CSGE5FIJPT3BNzYP893UYm/1rGiuBW8c+8FtmoJUp0z52C+SxhaTYdsbK 2ZOamukq1OfMiHAMWHKRstYR2JFLGaCUM6OBSLZyFG2ruaJ5f6ihus5ewrZSEvxsyvRP Cjpg== X-Forwarded-Encrypted: i=1; AJvYcCUQb3sjGrU2VGmRBd9Umwf+/h/PrGVcWbZ1RdkkA3LBc+jT+i8vGzk+Lgq2U5Gpgg7y7d0eYX8eEXXkHMI=@vger.kernel.org X-Gm-Message-State: AOJu0YxvAoyuxQecI2wMBtZ5w2NTqkvIH1gshwvh1nY5xfAQG71603NL IJ25K21oBWWs7tGRGT20Ni5QKfYS6qP+48bAzftB9x2C2efNHiOsQ8wPo6D9HcRaJUDbos+GuuH FvnpoaI/UvFVllOieIbDsCdqFf5BR5J6QAYR6V0uPoTHOB5Lp9CjjlojQ2npRv71JCdIw8dM= X-Gm-Gg: ASbGncvVjRTzwu0BIZADKDhwmVtt9hyUQQJ8oE4oJga523aogBCaiF5kT6wMYnoBP8B yHaMGfybER06mrJwswXD9GfZiCsNxveAQ+WAqu1rQFxn5206oqEYqSxy3waMM3OlAUiNpcRT++f 0Sg0igu16bCgyM1IWJ9Fkxd0nthzM4qMuB+794H07jrWJl22m88vs7EIeXN5Y7Mier0UGt4vhJu Om/gattkvDN+B1CEC1LDUuXXfUymu6dIvSiXdpLWDq7fJZDbS6DxOAbnnQ5B00chutLfbsGIYJx FC9WwyGaAftwNLryhV6pFYPbXQ9YYKS5hFOOOAc4yw43LmVAZDxSL7Wr55evN99iTuSugLKKZoN WH30sBqY2p1/AmKhkCKTKyj4QPlLLCQ== X-Received: by 2002:a05:6a00:b4b:b0:729:1b8f:9645 with SMTP id d2e1a72fcca58-72fd0c7f7camr40884088b3a.24.1738688722381; Tue, 04 Feb 2025 09:05:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/o0PDFYKduJ/WFg5MTpCskunjYwzsD7hxpDVDXG2wzp3GnoR6788Fy5nXVsJL9b4i/RBxvg== X-Received: by 2002:a05:6a00:b4b:b0:729:1b8f:9645 with SMTP id d2e1a72fcca58-72fd0c7f7camr40883896b3a.24.1738688720498; Tue, 04 Feb 2025 09:05:20 -0800 (PST) Received: from hu-adisi-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72fe69cddbbsm10772788b3a.125.2025.02.04.09.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 09:05:20 -0800 (PST) From: Aditya Kumar Singh Date: Tue, 04 Feb 2025 22:35:07 +0530 Subject: [PATCH v2 1/8] wifi: ath12k: eliminate redundant debug mask check in ath12k_dbg() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250204-unlink_link_arvif_from_chanctx-v2-1-764fb5973c1a@oss.qualcomm.com> References: <20250204-unlink_link_arvif_from_chanctx-v2-0-764fb5973c1a@oss.qualcomm.com> In-Reply-To: <20250204-unlink_link_arvif_from_chanctx-v2-0-764fb5973c1a@oss.qualcomm.com> To: Kalle Valo , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, Vasanthakumar Thiagarajan , Aditya Kumar Singh X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: h8S4H9GPLN0tnSKyVSGtLBwM0RHYrotM X-Proofpoint-GUID: h8S4H9GPLN0tnSKyVSGtLBwM0RHYrotM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-04_08,2025-02-04_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502040132 The current implementation includes a debug mask check both in the macro expansion and in the function __ath12k_dbg(), which is unnecessary. Simplify the code by removing the redundant check from the helper function __ath12k_dbg(). While at this, rename the first argument in macro from ar to ab since the first argument name in the function __ath12k_dbg() is ab. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Reviewed-by: Vasanthakumar Thiagarajan Signed-off-by: Aditya Kumar Singh --- drivers/net/wireless/ath/ath12k/debug.c | 5 ++--- drivers/net/wireless/ath/ath12k/debug.h | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/debug.c b/drivers/net/wireless= /ath/ath12k/debug.c index ff6eaeafa092cd12e572430ed0f1c7aa21b78377..fd9796b5ad3b9feea5c7e78e8a8= 8d361049e08df 100644 --- a/drivers/net/wireless/ath/ath12k/debug.c +++ b/drivers/net/wireless/ath/ath12k/debug.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: BSD-3-Clause-Clear /* * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved. - * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights res= erved. + * Copyright (c) 2021-2025 Qualcomm Innovation Center, Inc. All rights res= erved. */ =20 #include @@ -63,8 +63,7 @@ void __ath12k_dbg(struct ath12k_base *ab, enum ath12k_deb= ug_mask mask, vaf.fmt =3D fmt; vaf.va =3D &args; =20 - if (ath12k_debug_mask & mask) - dev_printk(KERN_DEBUG, ab->dev, "%pV", &vaf); + dev_printk(KERN_DEBUG, ab->dev, "%pV", &vaf); =20 /* TODO: trace log */ =20 diff --git a/drivers/net/wireless/ath/ath12k/debug.h b/drivers/net/wireless= /ath/ath12k/debug.h index 0aa7c8ccb14ccb9de28a78ca3d2b2a7bf6e481c1..ba0e4da3bb761a49fb81e3efcb6= 1557df8ad1942 100644 --- a/drivers/net/wireless/ath/ath12k/debug.h +++ b/drivers/net/wireless/ath/ath12k/debug.h @@ -62,11 +62,11 @@ static inline void ath12k_dbg_dump(struct ath12k_base *= ab, } #endif /* CONFIG_ATH12K_DEBUG */ =20 -#define ath12k_dbg(ar, dbg_mask, fmt, ...) \ +#define ath12k_dbg(ab, dbg_mask, fmt, ...) \ do { \ typeof(dbg_mask) mask =3D (dbg_mask); \ if (ath12k_debug_mask & mask) \ - __ath12k_dbg(ar, mask, fmt, ##__VA_ARGS__); \ + __ath12k_dbg(ab, mask, fmt, ##__VA_ARGS__); \ } while (0) =20 #endif /* _ATH12K_DEBUG_H_ */ --=20 2.34.1