From nobody Wed Feb 5 20:02:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93ABA217655 for ; Tue, 4 Feb 2025 14:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738681189; cv=none; b=p/WB9vjhJVOtMd0somBmvde16kNElta1lRjMR4+jFvw4lMFHq0uYERf8rz0sLebAf7rlsufYL2f9jpF645ayzst2OiEm/BPi9gDWrygi5RGs846GiGJERd9pdXeVHaWVO7LhhP+EiVNS4GsDSsd3agd8YiZh7YRO7hmId/fULjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738681189; c=relaxed/simple; bh=Ln3xQNtypHh6CSFXfBuZpufWLNToI4kD0XuPctFd5Oo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AQiWoyROBZKKXo2l8KHZooPWo2eM3b7hWjRUVHS8VeiL3rlBm4Cu+Neo55iXoT63h6wPwgyDG0XEwy3LQYqMM/DPp705fQ+ZzrYbNd97VyvjjVTRQOVyW9ldXcaeZW5cwL5nV00BsLW2YsOiDN4e3usYwfqPb0EjH5lRccKYzw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=POftEWL8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="POftEWL8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA776C4CEDF; Tue, 4 Feb 2025 14:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738681189; bh=Ln3xQNtypHh6CSFXfBuZpufWLNToI4kD0XuPctFd5Oo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=POftEWL80k69QJnsQmakNsehgSEsDIqNu9A4yqs/HLy0Q1k3rgsdVPHDrhO9Tk/Sa 5xPzveI0361QSdvq50t4+F/54L/FWXEsc/Lk5Sw3JNr7A5ODsjZT4Tq2oo97CPaBCO ZlPRLiFGirpDW/mNYhfIQ9BNeb9gW3tb3UQ3EVjT4Hq7udLaZuw+pbdaDPqYsmukBa Pn2nR6dBSOEokHPh3bhqDi4etEFOFtI+Y2h/RZXHTabg6wPiH5XQACWuOZco/y/ceQ eQ/aCe1oaWdOJ3lOzXkkdmtkH8G4+vQIVyLF0HPJXQ0SvAlsVdLVgr6NPB1+cuhKbA feJOXfLR3bwtA== From: Maxime Ripard Date: Tue, 04 Feb 2025 15:57:49 +0100 Subject: [PATCH v2 21/35] drm/atomic-helper: Change parameter name of drm_atomic_helper_fake_vblank() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250204-bridge-connector-v2-21-35dd6c834e08@kernel.org> References: <20250204-bridge-connector-v2-0-35dd6c834e08@kernel.org> In-Reply-To: <20250204-bridge-connector-v2-0-35dd6c834e08@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2558; i=mripard@kernel.org; h=from:subject:message-id; bh=Ln3xQNtypHh6CSFXfBuZpufWLNToI4kD0XuPctFd5Oo=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDOmLtD6tdhNVmvNGbd1D3/RQroMWrwXXvnN9GOwv9Tl5/ t5Q1j0bO6ayMAhzMsiKKbI8kQk7vbx9cZWD/cofMHNYmUCGMHBxCsBE/oky1scxiGxZ8j11yx7L uQpKrs8WH4tMUzUQ+b8995jZn9eGj4+Wt9hcjPm4ycTm+fFiZ/WWJMaGJR9N2zQ2yLy0ORR7qcb BQnK9/IRnK7vqeH7PrasWlnx4nYMvxDZaaU62zrU290lK4UwA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D drm_atomic_helper_fake_vblank() fake a vblank event if needed when a new commit is being applied. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atom= ic_helper.c index cf859fa0110ad1154021e970dc262387cf3eb0c8..78bc540158b7c64129eb728d8f8= d67a6797bd0b3 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2460,11 +2460,11 @@ void drm_atomic_helper_wait_for_dependencies(struct= drm_atomic_state *state) } EXPORT_SYMBOL(drm_atomic_helper_wait_for_dependencies); =20 /** * drm_atomic_helper_fake_vblank - fake VBLANK events if needed - * @old_state: atomic state object with old state structures + * @state: atomic state object being committed * * This function walks all CRTCs and fakes VBLANK events on those with * &drm_crtc_state.no_vblank set to true and &drm_crtc_state.event !=3D NU= LL. * The primary use of this function is writeback connectors working in one= shot * mode and faking VBLANK events. In this case they only fake the VBLANK e= vent @@ -2476,29 +2476,29 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_dependenci= es); * VBLANK interrupt. * * This is part of the atomic helper support for nonblocking commits, see * drm_atomic_helper_setup_commit() for an overview. */ -void drm_atomic_helper_fake_vblank(struct drm_atomic_state *old_state) +void drm_atomic_helper_fake_vblank(struct drm_atomic_state *state) { struct drm_crtc_state *new_crtc_state; struct drm_crtc *crtc; int i; =20 - for_each_new_crtc_in_state(old_state, crtc, new_crtc_state, i) { + for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) { unsigned long flags; =20 if (!new_crtc_state->no_vblank) continue; =20 - spin_lock_irqsave(&old_state->dev->event_lock, flags); + spin_lock_irqsave(&state->dev->event_lock, flags); if (new_crtc_state->event) { drm_crtc_send_vblank_event(crtc, new_crtc_state->event); new_crtc_state->event =3D NULL; } - spin_unlock_irqrestore(&old_state->dev->event_lock, flags); + spin_unlock_irqrestore(&state->dev->event_lock, flags); } } EXPORT_SYMBOL(drm_atomic_helper_fake_vblank); =20 /** --=20 2.48.0