From nobody Sun Feb 8 23:27:12 2026 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288AE204C29 for ; Mon, 3 Feb 2025 13:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738587635; cv=none; b=KIyLH/D4NjK+5VetwKlC4OBKOidGTKFIdbLzkgx6BSy2YKQ3dFSNPMeAXsL3ZSAW4WrTsH2vWaGj/+44YB2woxTLkxy5VP6eeIVBmaNSQ41WLYamDkHbNXT5aDNQIecHpNQidKhUprUthYKZBS3KNYdjnqAKok2NCA2IbvEH4DM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738587635; c=relaxed/simple; bh=DSN06IxcdIfuGR/BXO1SLB8Tt7tDFehbwoTUfPgr4vU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=grSgOCSiw07aJXjcYlRt2VGq3RPAwa3r2fD/RFAz4428rolP5SNxtGwkV7O0iTi2bB/cYPqil260yxOG+FU3hc99P6BFmgDCqdzYj/t3eVXukjUeoZV3am4BK7ya2zYpOKfMQY61eplVzbuxy6hmrAEDTcTFtSqKlkrpCAkW9hI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dZVnWPqj; arc=none smtp.client-ip=209.85.208.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dZVnWPqj" Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-5d9837f201aso10136117a12.0 for ; Mon, 03 Feb 2025 05:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738587631; x=1739192431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eMTIp+RZ6kEe92QzkrU5leVcNbLxPqPNP9qaL/EdXKI=; b=dZVnWPqjhX1GYEHzZnZ0eCuhyqHBdFXeThVi8p8ul2i62fiMXQgk3ELvH4lyhF5Hdj elBaQyJ9bvmE0MmNQMFtd1f5aebwbCHY0zFybPgsB1zYl1NVmA3tazdQiiFYudP0e/h7 jYTI3seP3q3xB/aL1GcIt6jfp5KO5BXee8MkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738587631; x=1739192431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eMTIp+RZ6kEe92QzkrU5leVcNbLxPqPNP9qaL/EdXKI=; b=TU2qSmBXCwHD3G9ZcX5hi9oTJyYY47uwssrPGBfeg1zqRYff0444xZewnErONBc6bA TyV2Jn31m8pHOQdz1+A2CTmq3KNSlRV1z2gcLVWjBwGs2l7FUnTt5fQGKfqk7hl6cmL2 wrxWV0Kk8sfe/XtoA1Wj/PluOT4baWOUtM4Hq+cvksm4JXoIXV5WIB9jRkt7Pq5OoIv0 kj1kUa9mzEItUAXhFazFHvSSjUGYk6PvLX4d0yZGQoRsHjJEZEDBxAxb4iKiogW6Hvvu 5g3e0TmWEwf9LAWMNZg8Z0eWiYjhecN68zytRPfXhd8589bkYMYDRQmWXwqjNF+y8E7e 6+KA== X-Forwarded-Encrypted: i=1; AJvYcCUr1VHu0g6obpwxOPZohI0erIEBXZowrLWJ2KLlVJSEX6ZjkvkW/IGjifcCaMdCyt2yvDjIu5+l3w7TTps=@vger.kernel.org X-Gm-Message-State: AOJu0YyigjSm8DJdQpYTUf3Gvyr3hgX+Q2nd+w/8wUkk3r2eo6nxsPgv beGcTO2h3XaqhOqMhEW9NKl2QrfW62gcXJyWnGYY82ttag4CJ31l7g2gIuAKmQ== X-Gm-Gg: ASbGncv1vO/+f1CpcGfMw0ofqnXPtgQnJri/4e2/xHGPukR+8H+se0Kf2WCj3fL5reD jwqWPhOIoAQb+Tq3ueewtIDWWYaVPHu8eHWI5zDqHOyCBCaDusJfLloN8Nz+0fxizN3Wtsh1SyH jO0O9lN1tKT0akxnx4iJo1Wnm+gKw5vTmXvCPNh73EqnPmZYL3omh1D+5v9QkRzoi3Itd422JMG ENXcekFd1JJ2tztBVGBdDp2MdhnbQKM2btpuLUElq5xHXkZpK0bEw+aSMpgCZbfS9GYTgm+K6Ll cG6j+h+UEHCB63jZJtyrpQqLJhVV/g6QMp6yzuxq2be6/vL4aFYQihNO72onhmMO4P7w10xXSMu vjD0egg== X-Google-Smtp-Source: AGHT+IFaj+AVyjD4nCvMckB54qr4raahN5XXtSLRYqzScx5HMHiza/xh72eb8PU+j3YTB77VuX/Qdw== X-Received: by 2002:a05:6402:2746:b0:5dc:5c18:6cb with SMTP id 4fb4d7f45d1cf-5dc7fd26d74mr16090641a12.13.1738587629849; Mon, 03 Feb 2025 05:00:29 -0800 (PST) Received: from akuchynski.c.googlers.com.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dc87f2e5easm5319055a12.57.2025.02.03.05.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 05:00:29 -0800 (PST) From: Andrei Kuchynski To: Benson Leung , Tzung-Bi Shih , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Abhishek Pandit-Subedi , Jameson Thies , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Andrei Kuchynski Subject: [PATCH 1/2] platform/chrome: cros_ec_typec: Expose PD mux status via sysfs Date: Mon, 3 Feb 2025 12:59:46 +0000 Message-ID: <20250203125947.2701106-2-akuchynski@chromium.org> X-Mailer: git-send-email 2.48.1.362.g079036d154-goog In-Reply-To: <20250203125947.2701106-1-akuchynski@chromium.org> References: <20250203125947.2701106-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This adds sysfs attribute /sys/class/chromeos/cros_ec/usbpdmuxinfo to expose the PD mux status for each Type-C port. This allows user-space applications to easily determine the current mux state without using ioctls. Signed-off-by: Andrei Kuchynski --- .../ABI/testing/sysfs-class-chromeos | 13 +++++ drivers/platform/chrome/cros_ec_sysfs.c | 58 +++++++++++++++++++ 2 files changed, 71 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-chromeos b/Documentation= /ABI/testing/sysfs-class-chromeos index 74ece942722e..e067dbdab170 100644 --- a/Documentation/ABI/testing/sysfs-class-chromeos +++ b/Documentation/ABI/testing/sysfs-class-chromeos @@ -31,3 +31,16 @@ Date: August 2015 KernelVersion: 4.2 Description: Show the information about the EC software and hardware. + +What: /sys/class/chromeos/cros_ec/usbpdmuxinfo +Date: February 2025 +Description: + Show PD mux status for each typec port with following flags: + - "USB": USB connected + - "DP": DP connected + - "POLARITY": CC line Polarity inverted + - "HPD_IRQ": Hot Plug Detect interrupt is asserted + - "HPD_LVL": Hot Plug Detect level is asserted + - "SAFE": DP is in safe mode + - "TBT": TBT enabled + - "USB4": USB4 enabled diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chr= ome/cros_ec_sysfs.c index bc1a5ba09528..93e9ed87249c 100644 --- a/drivers/platform/chrome/cros_ec_sysfs.c +++ b/drivers/platform/chrome/cros_ec_sysfs.c @@ -296,18 +296,69 @@ static ssize_t kb_wake_angle_store(struct device *dev, return count; } =20 +static ssize_t usbpdmuxinfo_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct cros_ec_dev *ec =3D to_cros_ec_dev(dev); + ssize_t count =3D 0; + struct ec_response_usb_pd_ports resp_pd_ports; + int ret; + int i; + + ret =3D cros_ec_cmd(ec->ec_dev, 0, EC_CMD_USB_PD_PORTS, NULL, 0, + &resp_pd_ports, sizeof(resp_pd_ports)); + if (ret < 0) + return -EIO; + + for (i =3D 0; i < resp_pd_ports.num_ports; i++) { + struct ec_response_usb_pd_mux_info resp_mux; + struct ec_params_usb_pd_mux_info req =3D { + .port =3D i, + }; + + ret =3D cros_ec_cmd(ec->ec_dev, 0, EC_CMD_USB_PD_MUX_INFO, + &req, sizeof(req), &resp_mux, sizeof(resp_mux)); + + if (ret >=3D 0) { + count +=3D sysfs_emit_at(buf, count, "Port %d:", i); + count +=3D sysfs_emit_at(buf, count, " USB=3D%d", + !!(resp_mux.flags & USB_PD_MUX_USB_ENABLED)); + count +=3D sysfs_emit_at(buf, count, " DP=3D%d", + !!(resp_mux.flags & USB_PD_MUX_DP_ENABLED)); + count +=3D sysfs_emit_at(buf, count, " POLARITY=3D%s", + (resp_mux.flags & USB_PD_MUX_POLARITY_INVERTED) ? + "INVERTED" : "NORMAL"); + count +=3D sysfs_emit_at(buf, count, " HPD_IRQ=3D%d", + !!(resp_mux.flags & USB_PD_MUX_HPD_IRQ)); + count +=3D sysfs_emit_at(buf, count, " HPD_LVL=3D%d", + !!(resp_mux.flags & USB_PD_MUX_HPD_LVL)); + count +=3D sysfs_emit_at(buf, count, " SAFE=3D%d", + !!(resp_mux.flags & USB_PD_MUX_SAFE_MODE)); + count +=3D sysfs_emit_at(buf, count, " TBT=3D%d", + !!(resp_mux.flags & USB_PD_MUX_TBT_COMPAT_ENABLED)); + count +=3D sysfs_emit_at(buf, count, " USB4=3D%d\n", + !!(resp_mux.flags & USB_PD_MUX_USB4_ENABLED)); + } + } + + return count ? : -EIO; +} + /* Module initialization */ =20 static DEVICE_ATTR_RW(reboot); static DEVICE_ATTR_RO(version); static DEVICE_ATTR_RO(flashinfo); static DEVICE_ATTR_RW(kb_wake_angle); +static DEVICE_ATTR_RO(usbpdmuxinfo); =20 static struct attribute *__ec_attrs[] =3D { &dev_attr_kb_wake_angle.attr, &dev_attr_reboot.attr, &dev_attr_version.attr, &dev_attr_flashinfo.attr, + &dev_attr_usbpdmuxinfo.attr, NULL, }; =20 @@ -320,6 +371,13 @@ static umode_t cros_ec_ctrl_visible(struct kobject *ko= bj, if (a =3D=3D &dev_attr_kb_wake_angle.attr && !ec->has_kb_wake_angle) return 0; =20 + if (a =3D=3D &dev_attr_usbpdmuxinfo.attr) { + struct cros_ec_platform *ec_platform =3D dev_get_platdata(ec->dev); + + if (strcmp(ec_platform->ec_name, CROS_EC_DEV_NAME)) + return 0; + } + return a->mode; } =20 --=20 2.48.1.362.g079036d154-goog From nobody Sun Feb 8 23:27:12 2026 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 437E7204C35 for ; Mon, 3 Feb 2025 13:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738587635; cv=none; b=uSaZmu4qixRXv+Cuxz1ihMvx4S9+jMdgPLHr74D6ivtSPRVh50sm/uow82mbXwvSrJnyrGNYXPWGy5LhlwKwJl7JTLWZKhZ8x+bT+xOP+KBMIhnSJY10RWH8rjj69KHV9xvcvWHs6/rbEpQP/yz/gxcfOfrzIENiuv6q/80YyzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738587635; c=relaxed/simple; bh=LL6gfAu8GwnRNpsGn6atA+r1enD/inePC+cNmAhJO/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eGFxgEBUujfFVIRUMpxooBEYGM+Mffa69X9sqV/Ti4oiQszGIRkGRbgx41onXg9abHi76eaWri02UgJ7TXlVtrTmP/2yTtKVIchSUtuwwJsvSA63DkM8J0Zj2Yn5mtYSHlEh1c/hw3Qvm+ZjbArfxGBrAGrk6BvVnMIth0J85Os= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=lTXwR5Jy; arc=none smtp.client-ip=209.85.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lTXwR5Jy" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-5d0ac27b412so5451406a12.1 for ; Mon, 03 Feb 2025 05:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738587631; x=1739192431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bZhQYJbonnYHiLNkHwoRDr/jemZOEPe4uCcAwPoPSx0=; b=lTXwR5JyDTA/i3k6za0LEITMyDbuoM+wGLAV+IxHEWiE525nTXPl6chl5G7xX3rDGa fmm+PnNObd2AMU9UrdeGMkDOosyvnHdYX3aSO40D6g5YAhZ8K0aUtlb/EJrTDeL21uve MNtWiSI67/FZgCKMl66vn4RW07gtF0mfs4daM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738587631; x=1739192431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bZhQYJbonnYHiLNkHwoRDr/jemZOEPe4uCcAwPoPSx0=; b=LVRwW6o8w4iiNgJOSbXm8gCmxMIIr8xIk+xmVWJmefv2a2r8DgU7gIa9irPiyZ7W1h gnT/m4I+oHa68JibIOq8r8X0RcGSy8PTAaYrPkTge8hOceuB5aJ0SM+urhMXMXt6Gscf EeUDr2HOeVZkosOReO5hHUE0lJxbSIQz+mHTsyWHYspF0W3BQ4fPcPMY+WKtElUxaXDp TbfQusdQL4QE1d4vXDFqQTVhLGnVZnhSWxeSGoDUBkgNF/7rMS22B1xKWFN0RZi1G36v y+oFHZ6kJczC+pAQlCeXjM1mpeXF433GRRdxFqJpTtfpbsF0P+YrcLHsooOa1sxqgceg l3dQ== X-Forwarded-Encrypted: i=1; AJvYcCUCoo8LvAN2SBjgpmL0ID5Ca7gS4oZ4pzwX9A6SUDhhDjVi8CTqlrx2uKkpY5zHtzaw3mnCupuXW/IfRPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yywb9tHss31H8wjLLu6Cl4c2f8p5TnkeeLh2AH6CDzW+W7MEIB1 mveepxAViBmlXWzSereAM7nk3Hyp5Oo08Ni0YvumySULFHW0rzRS8rwgDViEiw== X-Gm-Gg: ASbGncso4FicE0blK15Y9gCdgOHHhpw4vzzzrWoooBe8iwUq2LJXGu7nBkOY3X3CCBt a1GlV14rN97UcwZ1688SvzajyMUGovrUxqqMwU9Bx2fRi56GoJO4PgTFBiC2bFWJtiEcNVbFjdg +aUcCwRigtDPcLasO9O7XK7lvg9Iq47aY/GumcWgR2YITKJ1D0S0LiwOYvHJHo2CXpQrlSzAawN x2USe4p29SVsyyIWnR5GrFJK0XTt7My2z5XdO214LThkuIliOJpOCJHaCu3zTN7QSxRsQeTH+47 GOGq7ViXIrFtsFQ/eeKXdvgVyvYRhMccZKOi3HsKa2sZ1rpcliEo5xY05dsoNpONjjq2xzE0+3c hf2xbSA== X-Google-Smtp-Source: AGHT+IFJF/DQR6k7nfEEy53STh5XvsowIkt/i+SapQ5k4Q193ae8NMu0h8hg2QV8k19bzUGlnfEhJw== X-Received: by 2002:a05:6402:4313:b0:5dc:7fbe:7313 with SMTP id 4fb4d7f45d1cf-5dc7fcdb660mr16771564a12.6.1738587631436; Mon, 03 Feb 2025 05:00:31 -0800 (PST) Received: from akuchynski.c.googlers.com.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dc87f2e5easm5319055a12.57.2025.02.03.05.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 05:00:31 -0800 (PST) From: Andrei Kuchynski To: Benson Leung , Tzung-Bi Shih , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Abhishek Pandit-Subedi , Jameson Thies , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Andrei Kuchynski Subject: [PATCH 2/2] platform/chrome: cros_ec_typec: Expose AP_MODE_ENTRY feature state via sysfs Date: Mon, 3 Feb 2025 12:59:47 +0000 Message-ID: <20250203125947.2701106-3-akuchynski@chromium.org> X-Mailer: git-send-email 2.48.1.362.g079036d154-goog In-Reply-To: <20250203125947.2701106-1-akuchynski@chromium.org> References: <20250203125947.2701106-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This adds sysfs attribute /sys/class/chromeos/cros_ec/ap_mode_entry to expose the status of the AP_MODE_ENTRY feature. This attribute indicate whether the EC requires direction from the Application Processor (AP) before entering Type-C alternate modes or USB4 mode. This allows user-space applications to easily determine if the AP needs to be involved in mode entry. Signed-off-by: Andrei Kuchynski --- Documentation/ABI/testing/sysfs-class-chromeos | 7 +++++++ drivers/platform/chrome/cros_ec_sysfs.c | 15 ++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-class-chromeos b/Documentation= /ABI/testing/sysfs-class-chromeos index e067dbdab170..7fa5be6cc774 100644 --- a/Documentation/ABI/testing/sysfs-class-chromeos +++ b/Documentation/ABI/testing/sysfs-class-chromeos @@ -44,3 +44,10 @@ Description: - "SAFE": DP is in safe mode - "TBT": TBT enabled - "USB4": USB4 enabled + +What: /sys/class/chromeos/cros_ec/ap_mode_entry +Date: February 2025 +Description: + Show if the AP mode entry EC feature is supported. + It indicates whether the EC waits for direction from the AP + to enter Type-C altmodes or USB4 mode. diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chr= ome/cros_ec_sysfs.c index 93e9ed87249c..f22e9523da3e 100644 --- a/drivers/platform/chrome/cros_ec_sysfs.c +++ b/drivers/platform/chrome/cros_ec_sysfs.c @@ -345,6 +345,16 @@ static ssize_t usbpdmuxinfo_show(struct device *dev, return count ? : -EIO; } =20 +static ssize_t ap_mode_entry_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct cros_ec_dev *ec =3D to_cros_ec_dev(dev); + const bool ap_driven_altmode =3D cros_ec_check_features( + ec, EC_FEATURE_TYPEC_REQUIRE_AP_MODE_ENTRY); + + return sysfs_emit(buf, "%s\n", ap_driven_altmode ? "yes" : "no"); +} + /* Module initialization */ =20 static DEVICE_ATTR_RW(reboot); @@ -352,6 +362,7 @@ static DEVICE_ATTR_RO(version); static DEVICE_ATTR_RO(flashinfo); static DEVICE_ATTR_RW(kb_wake_angle); static DEVICE_ATTR_RO(usbpdmuxinfo); +static DEVICE_ATTR_RO(ap_mode_entry); =20 static struct attribute *__ec_attrs[] =3D { &dev_attr_kb_wake_angle.attr, @@ -359,6 +370,7 @@ static struct attribute *__ec_attrs[] =3D { &dev_attr_version.attr, &dev_attr_flashinfo.attr, &dev_attr_usbpdmuxinfo.attr, + &dev_attr_ap_mode_entry.attr, NULL, }; =20 @@ -371,7 +383,8 @@ static umode_t cros_ec_ctrl_visible(struct kobject *kob= j, if (a =3D=3D &dev_attr_kb_wake_angle.attr && !ec->has_kb_wake_angle) return 0; =20 - if (a =3D=3D &dev_attr_usbpdmuxinfo.attr) { + if (a =3D=3D &dev_attr_usbpdmuxinfo.attr || + a =3D=3D &dev_attr_ap_mode_entry.attr) { struct cros_ec_platform *ec_platform =3D dev_get_platdata(ec->dev); =20 if (strcmp(ec_platform->ec_name, CROS_EC_DEV_NAME)) --=20 2.48.1.362.g079036d154-goog