From nobody Sun Dec 14 21:34:14 2025 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5751204F84 for ; Mon, 3 Feb 2025 11:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583759; cv=none; b=ZFcxpivhQKjZyIhZyfjK7hL174G4NsWrwXU+OTVMWB6x1Rw9IFkBajUnWwtj/Q3IfztqJ9SBWeen85hYnjko0MOEeycoEFrsryZ/Nhfgd6gSVbJQZhgpZIM3InChgn6PDqkIk+YyaG6/NmNdDM1VidK+mtUm3JAqLga0R76V4jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583759; c=relaxed/simple; bh=MAIrdEevNn7N12nkJ1J1RhnEvLIu/5K6r/M3d+E6MoQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uhmfbWoyVzb6MCenMHifE8wXeKcPCxnr5pYwY6KyrYzxvEif/dGGPffp3DwaUp48QVWRmCO5Wsh70MwDpiXXNpg2CDTkMR6JcIDBetod11mTifXHxpZ8fYRIj9yO68RBGtx5GKs8EQUyLeA1IX99PMTM1EsiC0bhN65HEEqbDxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CsEJXWYg; arc=none smtp.client-ip=209.85.217.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CsEJXWYg" Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-4afefc876c6so1212925137.2 for ; Mon, 03 Feb 2025 03:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738583756; x=1739188556; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hxX88IJj+cJJK7Q7MEUbEa8fVnW5ArFeBowg00h7XKs=; b=CsEJXWYgldD2LqG72HuJmn8hlXYa+GsEfoU4bcfGOYHIknaTvOPvr0e+ye3N9WtitD ORI38yqoKz8YPikCRgxvE74Y2as/mEtnDyVWMqtZhVP1Hk1N+3bElHjodbRUCEr7YJ5q O9PSEqikjveK3UpikZE5DgyH1ymnD2oblG7GQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583756; x=1739188556; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hxX88IJj+cJJK7Q7MEUbEa8fVnW5ArFeBowg00h7XKs=; b=plsnTjZJKzmCqXfWdiPX6ElWuo63bRydocQfrO3E6mbdRtaA9+1MNAlUaMl+7Z7gpm u99NFSnty10WwzzSoGNgrlD7Vs+VNB29H7vOYhdkAssqBIvmvsfUHGun+zeQKAvfqll6 7LMzU43pnL9b9PtmR4+Y9M3pdppUz9jkZkJUrC8adnid8bvdFmpxufkBnVJjXUIVpTW4 AyCVFFW2IZNmusWElAd9CO2yzeFaR+TNPYCHJhhNEGEo6/sGCQIa68f6MxDS2Uwtj+Zl Dtw6QwYS2vscfoBhwPxjBXQYx3AvP9quBD+m+qGDn3LJW2RAbryqvkonhnQTARiHGnai 0sGw== X-Forwarded-Encrypted: i=1; AJvYcCUpVWT1jqngt96CcGiB+guX+Aw76XN5mb3wa0SJAsBe2OjKps4If2gZmeTS2WJpSOtW9b9xIevdlx6p/Q8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7gFaygKbagElFMtHTfi0K6z0aycNF1BXzN9ZOEwXpdIaTUWRx kM9e3CO3CaW/d19mbWjWIxNMcf4WG6qmvAQ9L/fgLYIHNlT31sGFJu5LHa6VQw== X-Gm-Gg: ASbGncvtk5VMPZKno04iGaNg+cX0atX9dsSHRwFU2lJDoyliyIDqsTkasjMznLrszng 7eFJ+cQY50n+/wSR7/42fnAhFUYhATKGYjnFbeHeDEfyW6tiVbea/Tl5S44QK7vsLwO4ZOU9LUL 1o/KaJlZV14sboMs9CR0T+/62PE7Enl98FnPnQcYmCS8zsS4GodefQbDxDA6fOfEMkkATHhOzB3 FTqrRAVvOoprosjChOgPH8dAyADWFF81i7bgD5AP6wZr+H5lV4lImu/uoG71b8mGIqMTlTEWbh+ PYPxmXqrGVSyOSJHAbmdXBamPFtr9RMnN+u+EhkRR/0Ve7sl9VlHfKokCRJH8FOZGw== X-Google-Smtp-Source: AGHT+IEK9q1tPQQgkuLEv6EU9rWEmJulUzWiAbWq4EJZ+pG8GCm2x+nnTJsHB8Vnf7iHLALMqu2m9A== X-Received: by 2002:a05:6102:2c0f:b0:4b2:bc6b:c845 with SMTP id ada2fe7eead31-4b9a4f0da6emr14805180137.6.1738583756605; Mon, 03 Feb 2025 03:55:56 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4b9baa9aefcsm1592770137.12.2025.02.03.03.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:55:55 -0800 (PST) From: Ricardo Ribalda Date: Mon, 03 Feb 2025 11:55:43 +0000 Subject: [PATCH v17 07/17] media: uvcvideo: uvc_ioctl_(g|s)_ext_ctrls: handle NoP case Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250203-uvc-roi-v17-7-5900a9fed613@chromium.org> References: <20250203-uvc-roi-v17-0-5900a9fed613@chromium.org> In-Reply-To: <20250203-uvc-roi-v17-0-5900a9fed613@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 If nothing needs to be done. Exit early. Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 9493ab375f07..4025811fb9e7 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1030,6 +1030,9 @@ static int uvc_ioctl_g_ext_ctrls(struct file *file, v= oid *fh, u32 which; int ret; =20 + if (!ctrls->count) + return 0; + switch (ctrls->which) { case V4L2_CTRL_WHICH_DEF_VAL: case V4L2_CTRL_WHICH_CUR_VAL: @@ -1070,6 +1073,9 @@ static int uvc_ioctl_s_try_ext_ctrls(struct uvc_fh *h= andle, unsigned int i; int ret; =20 + if (!ctrls->count) + return 0; + ret =3D uvc_ctrl_check_access(chain, ctrls, ioctl); if (ret < 0) return ret; --=20 2.48.1.362.g079036d154-goog