From nobody Sun Dec 14 21:34:14 2025 Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10EAD2040A8 for ; Mon, 3 Feb 2025 11:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583750; cv=none; b=g2WSY+zOmnHV7kZDwGU0pY4N+PUNuTy1rhFk99AhNhBKB6HtY4ioxL1EdF4M1p865OPWEOH1Ycrql4M7a95Dvt8P42g79i2nBcgghUSxoKmKRt7sYhR/RZKr9u1UAQaaQy1pj1tt+WPfC+hSLO2Sj+sKWL4BlW0WO74v1Jmt5i0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583750; c=relaxed/simple; bh=52pAZ6jK2x7Q0D1wUZ//wBDW0oHRaJoKihhdh/P6naY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gc03yOUAQrH2Ang9h7b2SmuziJ44xMVTuwnkgPu1cAz8udUweu9wefiNxjX8vpWoDHEJ2R2pEl1n9fmU/6eAfQ458slU+em2dL83YjrHI1pQgWV5qVW0Xb0l3XS4/I2JRZYqHrp/BHjLtgndHdAttt0GIAnMEbJhu/vpVDyEMV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JNNtWTMq; arc=none smtp.client-ip=209.85.222.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JNNtWTMq" Received: by mail-ua1-f50.google.com with SMTP id a1e0cc1a2514c-85c5eb83a7fso2187055241.2 for ; Mon, 03 Feb 2025 03:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738583748; x=1739188548; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dGF1p9h/lUEbgH8GNkApjRtx1wLKFzqXbBITVRxG3W4=; b=JNNtWTMqDPKN4ayKfM/UqUEXFZJ0JcI7lkX+zkPwob9MD/CJ5vIgoqSuLXHfBlA2FH hQW/FuoL8M2quHpdAeUNk33Y37oJZhvD01V4Hl5elV2pVlQPn/sRr36a+IiEkFretCvY EnAqkeD+tyTsaPYcv5IaDOKMMu9dYYbzFnTtE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583748; x=1739188548; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dGF1p9h/lUEbgH8GNkApjRtx1wLKFzqXbBITVRxG3W4=; b=kqIDFqOJETgp0ZpTGWs08Ihgg5EPsJgh+2jFCyV79DsZzLm/VaJ/bih7QoENxVnPQI heSmI7NasROg6PhfWPJvYlv6XuxXi9FM6WKHGeXJtJeIC6Qu+JSWcLeH/v+RtmUuwxn+ 2MG39sEtqCtzsqcD42TfEhWBVU3qZ6c+pC+z5KBAhwzzHVkdAAMXh6kiIcyK+qAkjLMr hgzPUbM8KZvQcxCsHKw5UNAnlRNLs/K1h1vbGvgn6+ucc4Eq7mGdy84prdV19JxDkQ14 EC5Kx82zCR9s6A7Zy58/0DZPyq3hm3ZmEbmXBqvIeexwJRgLJXJMhxO3z/j7/4MJQGBC JVUw== X-Forwarded-Encrypted: i=1; AJvYcCWu5rrYUYDOmKvZmSRoLmiM3weY1DrypV0vJnLBiW41S4NoTQXfoYKVD4YPCA0RmGGUg4XWgtssKD7TUMw=@vger.kernel.org X-Gm-Message-State: AOJu0YwVTq7OkeECyGtkgYMZkN9DzCjs1TmwWT4Vv6mo28aa2/EI8ndS GUxZZgkMv+mBsWfLAwlY9zSiJyCJley0eDNH3nJXdJCBFRvNzNyEoml/07NOIA== X-Gm-Gg: ASbGnctJkvH4qZYSL1Nn/L7q1O5M5p5wIS8u+NNslklXvHX3C4yyzBbAMyG+xRBqD3g AxZPpaxGdz3tto+cMP5zzmUditUJLkoBZzpvQertgnlAX/Od41dSlXfmwJRQJkVZot//kueyErI pWlcqzeq8BS0BLQcf8fYg/LZAkeyBB0DBG5Gwr6cDHGsPJQyE/essdVV9QLO9TXu2QW4n6fiD9c SSkTVS5j2CjI4HQs1qqFjzSjE3wQidO9pOj8dtTqD1wRz9ckQn6vafMql7J4dpZAa4KDYMNmt1n S/E5t1BdvLRlg3CYkfaTZL0EnguGGqmGI8C+oOGb4oKkLK7k+EPmZbxqhk5VgEXoag== X-Google-Smtp-Source: AGHT+IGnHlpYhWPf2xuJvuKNgHsRB2A6Y8fI7OQq+908vpzT+JKkZbPfDi7QBsgqZbmFX9K/QZT/6w== X-Received: by 2002:a05:6102:5045:b0:4b2:5ca3:f82a with SMTP id ada2fe7eead31-4b9a4f5dc62mr14553199137.7.1738583748017; Mon, 03 Feb 2025 03:55:48 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4b9baa9aefcsm1592770137.12.2025.02.03.03.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:55:46 -0800 (PST) From: Ricardo Ribalda Date: Mon, 03 Feb 2025 11:55:39 +0000 Subject: [PATCH v17 03/17] media: vivid: Add a rectangle control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250203-uvc-roi-v17-3-5900a9fed613@chromium.org> References: <20250203-uvc-roi-v17-0-5900a9fed613@chromium.org> In-Reply-To: <20250203-uvc-roi-v17-0-5900a9fed613@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao , Hans Verkuil X-Mailer: b4 0.13.0 From: Yunke Cao This control represents a generic read/write rectangle. It supports V4L2_CTRL_WHICH_MIN/MAX_VAL. Signed-off-by: Yunke Cao Reviewed-by: Hans Verkuil Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/test-drivers/vivid/vivid-ctrls.c | 34 ++++++++++++++++++++++= ++++ 1 file changed, 34 insertions(+) diff --git a/drivers/media/test-drivers/vivid/vivid-ctrls.c b/drivers/media= /test-drivers/vivid/vivid-ctrls.c index 2b5c8fbcd0a2..57346b714534 100644 --- a/drivers/media/test-drivers/vivid/vivid-ctrls.c +++ b/drivers/media/test-drivers/vivid/vivid-ctrls.c @@ -37,6 +37,7 @@ #define VIVID_CID_U8_PIXEL_ARRAY (VIVID_CID_CUSTOM_BASE + 14) #define VIVID_CID_S32_ARRAY (VIVID_CID_CUSTOM_BASE + 15) #define VIVID_CID_S64_ARRAY (VIVID_CID_CUSTOM_BASE + 16) +#define VIVID_CID_RECT (VIVID_CID_CUSTOM_BASE + 17) =20 #define VIVID_CID_VIVID_BASE (0x00f00000 | 0xf000) #define VIVID_CID_VIVID_CLASS (0x00f00000 | 1) @@ -360,6 +361,38 @@ static const struct v4l2_ctrl_config vivid_ctrl_ro_int= 32 =3D { .step =3D 1, }; =20 +static const struct v4l2_rect rect_def =3D { + .top =3D 100, + .left =3D 200, + .width =3D 300, + .height =3D 400, +}; + +static const struct v4l2_rect rect_min =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1, + .height =3D 1, +}; + +static const struct v4l2_rect rect_max =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1000, + .height =3D 2000, +}; + +static const struct v4l2_ctrl_config vivid_ctrl_rect =3D { + .ops =3D &vivid_user_gen_ctrl_ops, + .id =3D VIVID_CID_RECT, + .name =3D "Rect", + .type =3D V4L2_CTRL_TYPE_RECT, + .flags =3D V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX, + .p_def.p_const =3D &rect_def, + .p_min.p_const =3D &rect_min, + .p_max.p_const =3D &rect_max, +}; + /* Framebuffer Controls */ =20 static int vivid_fb_s_ctrl(struct v4l2_ctrl *ctrl) @@ -1685,6 +1718,7 @@ int vivid_create_controls(struct vivid_dev *dev, bool= show_ccs_cap, dev->int_menu =3D v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_int_menu= , NULL); dev->ro_int32 =3D v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_ro_int32= , NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_area, NULL); + v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_rect, NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_array, NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_dyn_array, NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u16_matrix, NULL); --=20 2.48.1.362.g079036d154-goog