From nobody Mon Feb 9 11:45:20 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 129461D90DD for ; Wed, 29 Jan 2025 11:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738151710; cv=none; b=kJzdjVJHat1bVngRTGqbJxOTTGcc4/hVvzOvUuP5Lr43ymd0mzEYhZkZZwa/xpoeE+ue3fjxnu3npLWs2dmhhAJ7Gl+rVq/JNly6UpZeN+cHJ0w2yhdPjAFaYaHQ484MXyVsk89A4QtiGXfeHz4meHmmCrh2xO4ZE3nAiy0YkVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738151710; c=relaxed/simple; bh=xVZ7mZHQdQEjUG890k/QM9ETHklqFmRmqwx3bqz7wfo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KISS/Z2iSwrwruP3lTJTEI8e1kD+tt330NE6srvXJBDXo/IAlVGuHSGY1zP3jGwe2Q17JFzM7lxnpa1Y8pHyOw+RFCNFotvB78m/WmgSrrbIGWe0+L9Ris8NS10NbdXWjSpFVOkz7KkVyhIbnE+vlrws60LEtTP5OUnoMTESw1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nPHSjNHl; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nPHSjNHl" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-aa680fafb3eso77548266b.3 for ; Wed, 29 Jan 2025 03:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738151707; x=1738756507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZoxYub/fGhny5IvUZRt39jPFGsJ2Xpyd6lgEIHUfGX0=; b=nPHSjNHlHsl3dDt4F7w+Pk4YLfDLa8SwzuHJtL7WeT/M9ZbtpuSzL/WpN4JzlwWYzk G+3D5hH8KFzRlaws8KDJD9syBfVmR6ePmrVLOQC3DqSVCLaxq1aXiWFxXeUeTpiXQbJC dGUKiE9DEV2M7lfn0JqArkoLbHx5n8esnCdVFFMRSaVMOg+87rdra8bkCTXABooZ0Z7Y BV8neYQJTCl8mnwAyHxRLpmP8iU8d84AySpWlJg4uIABMKl7UrvRpndVdmHUG2lTSuS3 pUE/br9wRRo4oPYPhAdppoHIKi54Wf63uaPT0G7+dIOPMGXSKCW20zt+ihmP/nEMVaEK 6F+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738151707; x=1738756507; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZoxYub/fGhny5IvUZRt39jPFGsJ2Xpyd6lgEIHUfGX0=; b=wqwBWoe+9Pe77WXAIprKkUIm+JIrWRJAGSr3JR4efcBQ1LyAZFerTmeOe34o/RisEb 1gpNwO2GXeXpMiu9PGuRUvohz2DqVCcugLK0XucblAvXSIJfwj+5UaTH1LRpjldqP9ey rE0eceQxC4zT1PPd5fEus/ovUjnDm6HeCzCNYRT1oBuI89rOoA5qOX05Fw3EzNlLGwAD H4+l5AkeH/YoB1STDplX3mPvbihko1oBx27k1YG2O5lqkQDLqZxgS2PKOPgfgBa9AT2Y WrNnJjCqFHyxVs8jo0rzRs/c7MDKdICdYlWabo9fRfXkPxM+02tAmm9t37rfFeglh9lW D8tw== X-Forwarded-Encrypted: i=1; AJvYcCVNvI0/vMsE84+zskMjli8xfIkKri/10PYVIy3F6ajcHQDYM+XIGj1GYNLfBX4SW4RFxh3AS/PN/jPLkpg=@vger.kernel.org X-Gm-Message-State: AOJu0YxNOguu3bZgbIqS+2w63AUIVP/APfP5j4npcn8tj24IAvb6i7oE ymq7mqeGmtRf3yoOuCpdZxgcSBgJGfppP2LDAdQDCGZKlpudm6JC7fBM8GZtiw8= X-Gm-Gg: ASbGncsZRf9aBlc4ekAPRdfQySP7uoKPxuTaY1OIOvamsb1Jdyqyuta+2v1+Hs7fPKo 6DEuSHl+n9FpZjhIGbnMJI/TNFqqILfSjwAFRpB6Ozrjr6GY0abVKZW6l4RakXklp2kPhC43wpY eX2AIe1MKX9bU9E6c4ry8Is3NDIJiPdJqJi8xRi1SFfmaF2p0COuOKIqMqaoXp+vRILo1WJdwRa y7Z+p/ttUyAVVBj/1NkscAHwA9Nhdgcc812j+O5enfN4n4HxskOfhODPJij0/PZPmbdc8hCfORr edpvsjd+3DoWKPEQzKM7349v656/ X-Google-Smtp-Source: AGHT+IFjZKfgMNqMS3717CUskta9AgMI7HC+LrfGMh5w6tDILVjhok1zF479wv7ce8XTERnEEpq/Tg== X-Received: by 2002:a17:906:b2d6:b0:ab6:db64:b040 with SMTP id a640c23a62f3a-ab6db64b2d7mr7832066b.12.1738151707153; Wed, 29 Jan 2025 03:55:07 -0800 (PST) Received: from krzk-bin.. ([178.197.218.98]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760ab26asm949981866b.111.2025.01.29.03.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 03:55:06 -0800 (PST) From: Krzysztof Kozlowski To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFC] drm/msm/dsi/phy: Program clock inverters in correct register Date: Wed, 29 Jan 2025 12:55:04 +0100 Message-ID: <20250129115504.40080-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since SM8250 all downstream sources program clock inverters in PLL_CLOCK_INVERTERS_1 register and leave the PLL_CLOCK_INVERTERS as reset value (0x0). The most recent Hardware Programming Guide for 3 nm, 4 nm, 5 nm and 7 nm PHYs also mention PLL_CLOCK_INVERTERS_1. Signed-off-by: Krzysztof Kozlowski Reported-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- Not tested except my work-in-progress oon SM8750. Not sure what is the impact, so also no Fixes tag. --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/ms= m/dsi/phy/dsi_phy_7nm.c index 7f6fb2a840d2..6646f8dbe457 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -326,7 +326,7 @@ static void dsi_pll_commit(struct dsi_pll_7nm *pll, str= uct dsi_pll_config *confi writel(pll->phy->cphy_mode ? 0x00 : 0x10, base + REG_DSI_7nm_PHY_PLL_CMODE_1); writel(config->pll_clock_inverters, - base + REG_DSI_7nm_PHY_PLL_CLOCK_INVERTERS); + base + REG_DSI_7nm_PHY_PLL_CLOCK_INVERTERS_1); } =20 static int dsi_pll_7nm_vco_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.43.0