From nobody Mon Feb 9 16:45:50 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D905E1D5CC6 for ; Wed, 29 Jan 2025 11:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738148475; cv=none; b=i8EosJ2rRT7RmFeUIacTbITBj8OT2Q4orKjID66euRPn0JRTUHrO5zt4XxzR6WtwBj6gTuTvauxtFa532HBa89hnkjmnVnil4s5jSxz+ChrypFRpfZ2RAd72XWmw4rTcZmSKjVQt1nq+L9iOYI/1HbBmiaHJwRE7CaQ48N4H/mM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738148475; c=relaxed/simple; bh=XFnNDeHiwz9uXy0C4eKOF7Z1i2GXBUm3LTRHYxbjzpE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s+sDbm5ZtCmKzE9Ri6ed3bZkZRI5vM5WA74kdDzt9aTxGb1syJAUbMGPrkGjfi6ASs2uazMKeoM/HxZYh2uD39Yu7teA3FHDkhh0RUMehBdM6MXiIsEB1PnzQ8SXxf/1OZQoPT1XVrsscjC/TTZRe0boX/aP4OlghSuDVSYmBg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jm0B0cZv; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jm0B0cZv" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso7486113f8f.2 for ; Wed, 29 Jan 2025 03:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738148472; x=1738753272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vcLgxm3SUTsLjkaczvOfL6Bm5o46S9pgFwtVrMuPL9A=; b=Jm0B0cZvs9eglHPhitHnoF5yPTKCk16KR9U8/O5HeIMlJKBrTLk5jkkS0k08sUEMP5 UfHbUmf06UZ8MsonRvlDnHNtUX247qjSdsEg2fzexxW8uvDH4Y93tQlW0dMyHGZt4qxn AX4kFPpMaEUWh0zS7aENcddxOxkmDpJtGRAc2m8cg2W6IWb/Tz4hVAYIBC0Iz0ZDwGqF fIaYAWe1UwbsyQ3QmLPFDvBSIa5Xhzt9zw+fM/d7Vi+ZQexVNjJvjAzMnLOtcLsOlLjA bZ2M/BFI7b2Sh1yvAzfJLG/qFOXjJh5KF0IpE7wjx/Y/eUpejHJcgwQJstd2cpTgD2Og 9nKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738148472; x=1738753272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vcLgxm3SUTsLjkaczvOfL6Bm5o46S9pgFwtVrMuPL9A=; b=iV+GWDFC53ie5qc65Z0sbtJlXisB39YX61WOOQV+FETmdy0+f+/KiIJ4fmXp6xGLRD 6hqhLjV60Je0Lc0TJPwDuj80/U/pPJPEfsuSsNRVqCMrCHtXfUNxQGavBcpoF5hgYC+c UcnYHCljBlidJwLnx/jskmsg2JociRn+xn9sL4ufS81v34brTUcDDIT4LBq1zYwxCa/M H8HtH7iMhsRu313FmoTuqGtahPfz1dYf9T1pdX/0L2sRZC90KP46y1sobfLX10XmrobE TYCJ6N73dqsxpAwNHUQ1ytJc03oh/fuCqCdMk7iRhxTz1e/UfrlB0cdjsALB4g95QJhL ELLA== X-Forwarded-Encrypted: i=1; AJvYcCWgeMmCCQAH3rDoTUtsjfywkFOlcKJWQD6kRKrSKnFk81CI6MHABC8NAZG/74xGATPmFN7te/uCXJJyKYk=@vger.kernel.org X-Gm-Message-State: AOJu0YyVbJ91swoamneEGJ5HmzoNiz2RP8bbh+6bq1YTDAjI9oGTPMm4 0FZpV/nBFbjBnP5gfmvBL3e/t2pbv3SFKilX39VYseJY+T8twtZc X-Gm-Gg: ASbGncutIv/YEhr66nwWyWJRiW2he0bLZZzEjTeDRml6pa1wKHtSzKTQU4tArL3yhxV fypp/RVXFsFii8oHrMTjX/RqEOu/QbQAOzpHWiKJczR3zuCI2hMHFcy8Uru+88Ovsm4K+XruSW4 XBU/AelhQBcqFQe5rA77sPA73fVMyesM7xMPblR9w0ysEiANWLl05pRI+/7zH1AgnwPUxqCVrIO Z/enMVzwlxgdiFIRcng+uoH5n9Wb3CAywH1ZpE6+SyS7kUx44rfWXZ5mKKXcrTp/1zSOSSdlRtg 0E2BddxoD2up5K7T X-Google-Smtp-Source: AGHT+IGJkECaHDdVMqpyu56d/KRmlF5eI3OFpcFDGpoPoyaY9mw51GmEv0T/B7Cfz1VL8PGPqNskXA== X-Received: by 2002:a5d:6d88:0:b0:38a:418e:1179 with SMTP id ffacd0b85a97d-38c519380afmr2274027f8f.2.1738148472073; Wed, 29 Jan 2025 03:01:12 -0800 (PST) Received: from fedora.. ([94.73.37.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a176434sm16947113f8f.13.2025.01.29.03.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 03:01:11 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: louis.chauvet@bootlin.com Cc: hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH 06/13] drm/vkms: Add a validation function for VKMS configuration Date: Wed, 29 Jan 2025 12:00:52 +0100 Message-ID: <20250129110059.12199-7-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250129110059.12199-1-jose.exposito89@gmail.com> References: <20250129110059.12199-1-jose.exposito89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Louis Chauvet As the configuration will be used by userspace, add a validator to avoid creating a broken DRM device. For the moment, the function always returns true, but rules will be added in future patches. Signed-off-by: Jos=C3=A9 Exp=C3=B3sito Signed-off-by: Louis Chauvet Reviewed-by: Louis Chauvet --- drivers/gpu/drm/vkms/tests/vkms_config_test.c | 2 ++ drivers/gpu/drm/vkms/vkms_config.c | 5 +++++ drivers/gpu/drm/vkms/vkms_config.h | 10 ++++++++++ 3 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/vkms/tests/vkms_config_test.c b/drivers/gpu/dr= m/vkms/tests/vkms_config_test.c index 526800b1afb4..66c2c6cb4a0e 100644 --- a/drivers/gpu/drm/vkms/tests/vkms_config_test.c +++ b/drivers/gpu/drm/vkms/tests/vkms_config_test.c @@ -54,6 +54,8 @@ static void vkms_config_test_default_config(struct kunit = *test) KUNIT_EXPECT_EQ(test, config->writeback, params->enable_writeback); KUNIT_EXPECT_EQ(test, config->overlay, params->enable_overlay); =20 + KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config)); + vkms_config_destroy(config); } =20 diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms= _config.c index 11b0e539920b..67f71d29596e 100644 --- a/drivers/gpu/drm/vkms/vkms_config.c +++ b/drivers/gpu/drm/vkms/vkms_config.c @@ -47,6 +47,11 @@ void vkms_config_destroy(struct vkms_config *config) kfree(config); } =20 +bool vkms_config_is_valid(struct vkms_config *config) +{ + return true; +} + static int vkms_config_show(struct seq_file *m, void *data) { struct drm_debugfs_entry *entry =3D m->private; diff --git a/drivers/gpu/drm/vkms/vkms_config.h b/drivers/gpu/drm/vkms/vkms= _config.h index 3e4f39cbe2e2..963f22b9b4bd 100644 --- a/drivers/gpu/drm/vkms/vkms_config.h +++ b/drivers/gpu/drm/vkms/vkms_config.h @@ -64,6 +64,16 @@ vkms_config_get_device_name(struct vkms_config *config) return config->dev_name; } =20 +/** + * vkms_config_is_valid() - Validate a configuration + * @config: Configuration to validate + * + * Returns: + * Whether the configuration is valid or not. + * For example, a configuration without primary planes is not valid. + */ +bool vkms_config_is_valid(struct vkms_config *config); + /** * vkms_config_register_debugfs() - Register a debugfs file to show the de= vice's * configuration --=20 2.48.1