From nobody Wed Feb 11 10:02:34 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489051990AB for ; Wed, 29 Jan 2025 06:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738133373; cv=none; b=NAOClE+3nYGmG7PYIlO8RThVfYjpat7BgA0bkORVrygLhDhLXrBYmATHiNDVRQ38lcyGHuAbq8X5Ww2h65ASwgfbc+LJo/xCf3/iMK986Na6D9POczrkrTmqxtcVNnsB1cN3/XTz3+TxcKdAVI4zDywkBFCJ8/l580sOvkdbJ98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738133373; c=relaxed/simple; bh=b8wby6Mnz0jOlZOj4F5r8wWAxtOJ93uxJ6l+SPSOOYI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qikDaXQK6at6wlTYAo7wVVpKC3uANL9i1WIeiIOleyaZHU2CGPBRFe/W84mm6AG/26/WZ2qKWv2CepTZ3xgxSUgY2Ti3TU9RcMofYC0g8SGm/sxaS84lIBGs+tUhd4+1rB6IzwV7pCIAVT/9J2E954vd+LuRlkKy0e8WAgZqEYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=j8UWXpz5; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="j8UWXpz5" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21634338cfdso48330805ad.2 for ; Tue, 28 Jan 2025 22:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738133371; x=1738738171; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jm+b3R/xkgu1u5aIyHjEy9+3hXzV4kVBwpygpgrob3Q=; b=j8UWXpz54tv05J41Pj9jDH+oCoWAjjvUrXTeHlJzpMwrtcmb5VMms7PaNEa3BPy78F kLF59kxOwlDj/Jv/yvGrYBbPFuTazDmPvANXR04/DZnibkEEigdRszDy1kU6yk0rlUp0 qF2fUHEfsoA12vcsaXRtxRIZYd5j24LOdauXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738133371; x=1738738171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jm+b3R/xkgu1u5aIyHjEy9+3hXzV4kVBwpygpgrob3Q=; b=g3SOzqpeEOdQkxlkGRjI+ZW/ypnu+g3m1HE1dIakn4+iahXhfkOQ4vKRjLoJ88gd/C EzU/k8Ka2c3c0SNgwFbTd7IrYMhmveFbi7XgnAJRHw/5GWOGB+q/vBQ8d8nxoN45xJeU rHLx7yeP4oRl7d/3Pms3VSnsDa1BhS7xxIo4nQoJ6rtlWwb0ZhqQdrgvuHbaG7f91TEl h3uiwdJy+AM3uSQPsRR1T87F9xkTlVK45CbFFe1g8lebY/Prl0JVNmfJ9J9Qr+1tqcNF KMw7HroVW3CB6IR8+DiUU91NB4yfw6hBGTBA2UP+E8BhTC7VA69fztZiAiYmthjNW2TR VwxQ== X-Forwarded-Encrypted: i=1; AJvYcCXQH8cIOSmhH84/y6jssn3wIDoRcoteKo+/NfhI3BiBDWHNHkPJ3Jeon5JQJhaH8QTk7DKpC53GkR8LWeM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywum1OicpuOVGDfnj/QF1FRsUIJwoBYreuqd5o3ViIPTIh4RjaF 2OXLkWeEh0JVOIdXbjQtlvdwcVmnb0OeflY2latAnqZoCUZzL2RWs+NF3mXzBw== X-Gm-Gg: ASbGncuSqq/4VHaudgx/PqdRkq8tApqtyHgYAYf3HALK/RKR/DbTh55pl60QpOAsPwu or+pfD3aX30PdMyS5fww1sbWfyeJLfOuw8mA4HUcTKiB/Sht/LW5LaqUeEcOzvDnPsQqYe1+9Hg 9NC0V+01Koh9H+6wPenoZXsHcAw5YR5fEZ37pdPR3o+vrIK3VttI2BSrT1qXk+FOfYOgCbzO+h2 4L5/igQTARUi9Srv+XBQUzBS1y1U9VJD2ydVzwu4vbbKswkfleZQyStldziKYxcdY9vTWEf3Wwy ivxsZWrUUUnhvhT1eQ== X-Google-Smtp-Source: AGHT+IEK5agvR4qJHKICT0NvwP5kGDqjZ0/0rvwL4OJXcfuzB8y1QaZ9wi33U86Y9zDYeiv8HE16ww== X-Received: by 2002:a05:6a00:2406:b0:72d:9cbc:730d with SMTP id d2e1a72fcca58-72fd0c2246cmr2931620b3a.11.1738133371409; Tue, 28 Jan 2025 22:49:31 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:b323:d70b:a1b8:1683]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-72f8a7608b1sm10312341b3a.116.2025.01.28.22.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 22:49:31 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim , Johannes Weiner , Yosry Ahmed , Nhat Pham Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv1 5/6] zram: switch to new zsmalloc object mapping API Date: Wed, 29 Jan 2025 15:43:51 +0900 Message-ID: <20250129064853.2210753-6-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog In-Reply-To: <20250129064853.2210753-1-senozhatsky@chromium.org> References: <20250129064853.2210753-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use new read/write zsmalloc object API. For cases when RO mapped object spans two physical pages (requires temp buffer) compression streams now carry around one extra physical page. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zcomp.c | 4 +++- drivers/block/zram/zcomp.h | 2 ++ drivers/block/zram/zram_drv.c | 28 ++++++++++------------------ 3 files changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c index efd5919808d9..675f2a51ad5f 100644 --- a/drivers/block/zram/zcomp.c +++ b/drivers/block/zram/zcomp.c @@ -45,6 +45,7 @@ static const struct zcomp_ops *backends[] =3D { static void zcomp_strm_free(struct zcomp *comp, struct zcomp_strm *strm) { comp->ops->destroy_ctx(&strm->ctx); + vfree(strm->local_copy); vfree(strm->buffer); kfree(strm); } @@ -66,12 +67,13 @@ static struct zcomp_strm *zcomp_strm_alloc(struct zcomp= *comp) return NULL; } =20 + strm->local_copy =3D vzalloc(PAGE_SIZE); /* * allocate 2 pages. 1 for compressed data, plus 1 extra in case if * compressed data is larger than the original one. */ strm->buffer =3D vzalloc(2 * PAGE_SIZE); - if (!strm->buffer) { + if (!strm->buffer || !strm->local_copy) { zcomp_strm_free(comp, strm); return NULL; } diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h index 62330829db3f..9683d4aa822d 100644 --- a/drivers/block/zram/zcomp.h +++ b/drivers/block/zram/zcomp.h @@ -34,6 +34,8 @@ struct zcomp_strm { struct list_head entry; /* compression buffer */ void *buffer; + /* local copy of handle memory */ + void *local_copy; struct zcomp_ctx ctx; }; =20 diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index ad3e8885b0d2..d73e8374e9cc 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1562,11 +1562,11 @@ static int read_incompressible_page(struct zram *zr= am, struct page *page, void *src, *dst; =20 handle =3D zram_get_handle(zram, index); - src =3D zs_map_object(zram->mem_pool, handle, ZS_MM_RO); + src =3D zs_obj_read_begin(zram->mem_pool, handle, NULL); dst =3D kmap_local_page(page); copy_page(dst, src); kunmap_local(dst); - zs_unmap_object(zram->mem_pool, handle); + zs_obj_read_end(zram->mem_pool, handle, src); =20 return 0; } @@ -1584,11 +1584,11 @@ static int read_compressed_page(struct zram *zram, = struct page *page, u32 index) prio =3D zram_get_priority(zram, index); =20 zstrm =3D zcomp_stream_get(zram->comps[prio]); - src =3D zs_map_object(zram->mem_pool, handle, ZS_MM_RO); + src =3D zs_obj_read_begin(zram->mem_pool, handle, zstrm->local_copy); dst =3D kmap_local_page(page); ret =3D zcomp_decompress(zram->comps[prio], zstrm, src, size, dst); kunmap_local(dst); - zs_unmap_object(zram->mem_pool, handle); + zs_obj_read_end(zram->mem_pool, handle, src); zcomp_stream_put(zram->comps[prio], zstrm); =20 return ret; @@ -1684,7 +1684,7 @@ static int write_incompressible_page(struct zram *zra= m, struct page *page, u32 index) { unsigned long handle; - void *src, *dst; + void *src; =20 /* * This function is called from preemptible context so we don't need @@ -1701,11 +1701,9 @@ static int write_incompressible_page(struct zram *zr= am, struct page *page, return -ENOMEM; } =20 - dst =3D zs_map_object(zram->mem_pool, handle, ZS_MM_WO); src =3D kmap_local_page(page); - memcpy(dst, src, PAGE_SIZE); + zs_obj_write(zram->mem_pool, handle, src, PAGE_SIZE); kunmap_local(src); - zs_unmap_object(zram->mem_pool, handle); =20 zram_slot_write_lock(zram, index); zram_set_flag(zram, index, ZRAM_HUGE); @@ -1726,7 +1724,7 @@ static int zram_write_page(struct zram *zram, struct = page *page, u32 index) int ret =3D 0; unsigned long handle; unsigned int comp_len; - void *dst, *mem; + void *mem; struct zcomp_strm *zstrm; unsigned long element; bool same_filled; @@ -1769,11 +1767,8 @@ static int zram_write_page(struct zram *zram, struct= page *page, u32 index) return -ENOMEM; } =20 - dst =3D zs_map_object(zram->mem_pool, handle, ZS_MM_WO); - - memcpy(dst, zstrm->buffer, comp_len); + zs_obj_write(zram->mem_pool, handle, zstrm->buffer, comp_len); zcomp_stream_put(zram->comps[ZRAM_PRIMARY_COMP], zstrm); - zs_unmap_object(zram->mem_pool, handle); =20 zram_slot_write_lock(zram, index); zram_set_handle(zram, index, handle); @@ -1882,7 +1877,7 @@ static int recompress_slot(struct zram *zram, u32 ind= ex, struct page *page, unsigned int class_index_old; unsigned int class_index_new; u32 num_recomps =3D 0; - void *src, *dst; + void *src; int ret; =20 handle_old =3D zram_get_handle(zram, index); @@ -2020,12 +2015,9 @@ static int recompress_slot(struct zram *zram, u32 in= dex, struct page *page, return 0; } =20 - dst =3D zs_map_object(zram->mem_pool, handle_new, ZS_MM_WO); - memcpy(dst, zstrm->buffer, comp_len_new); + zs_obj_write(zram->mem_pool, handle_new, zstrm->buffer, comp_len_new); zcomp_stream_put(zram->comps[prio], zstrm); =20 - zs_unmap_object(zram->mem_pool, handle_new); - zram_free_page(zram, index); zram_set_handle(zram, index, handle_new); zram_set_obj_size(zram, index, comp_len_new); --=20 2.48.1.262.g85cc9f2d1e-goog