From nobody Mon Feb 9 19:31:00 2026 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A20AF1AA1C8 for ; Tue, 28 Jan 2025 16:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738082816; cv=none; b=ABlG87J+SlyDaTXs3ZynRfbDraiRHPNOMRB2/y/Nsh+0eDuKL0JyYqINNxvU0ZGSwdbbWkh2eXTji2s8iimCW0GlEDVullBxPtKeVL609llsY4yt7uNoqU/X3njTq+mM7jGkO/jAPiam3BPxXCyf0er7b1PyVJ1BwVIvdLXAHHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738082816; c=relaxed/simple; bh=+Zwsfy6YH5CS10fTclDUEdCV+0IQUSu1rzL9TeANRqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rvUjRkpxp7PgiRg+AL7mhVr9ODPzd3/c5FYk91mvWQKpi2xSO1ArsQt6WNCbI0fNT5/2Sh5w9n8j73RL+HyHUXRx93Mr7h8k8qXCkSRw6TxrEJnfolD+jmbZe+v1nxUyrkHobDu63cHr+SLH+e/Sm3jGgv3CSrCla5zA14Qa4C4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ak8i1Pza; arc=none smtp.client-ip=209.85.219.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ak8i1Pza" Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-e455bf1f4d3so8131898276.2 for ; Tue, 28 Jan 2025 08:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738082813; x=1738687613; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubvhjam4awIBMi5vwHaqj7zTIr7vOK16Tu3+fo0j/yY=; b=Ak8i1Pza5/6U1LQJHc9ubKn7Jqgd2aqyfTOHbRnpXMoMuuSRqObgXkJWPVaPOtlvFS AWcXfPVFofxFMxdAv+FK07rZnAv3VTASATAIP3wCvclgJOnLsM1S+D2yJg8LRDQz0FS+ EnjKPH7o6i6/an8CIXNlt/tFSSIzL9bA89r/xEq+PK1kcCEZvIeDQq/XHi5P+yd4KAyW md+v2zdaTjS80muH0kbl+yZrGiWgfiBxDMTY9JEwTFz4soppBla3U8N2aCJlxMs7rE4e KYuIcZzozqvgme/M74AxfXWb6vPvjWk8K8ONZbYHdyPBzyL0cl3Hv9i/+G9hO0jj1LJS sjEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738082813; x=1738687613; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubvhjam4awIBMi5vwHaqj7zTIr7vOK16Tu3+fo0j/yY=; b=BhqXfDWOfyHiqBTqIfphPGnERlGoaJJOpfjZ8DOwX0Lt56MiIlu17zL3AE2pjBYAZh 0BhsIlnShKLNEMNSUDOOWeTN8hnWix9HJve55FG/dmUCv5/PkxPJPSH8ku1aEfQXuzGI mOO5YuueFgJTC2fmsuIr4tZJGueuTtBV2qp4QPzMLXkD5tLycuSx8HzuhCMfmCrZ3iNr rY3b4CMmyLgqavuVA8U7LMvqIApsMxBfnf4ICPry1KkVjxnfNZZfWbfRAfy8R7mpP9Ou lxJSLUtYgpx40K2MCzXE/E2JhZDGtHzwMHT4WPl6pRpNYm4PHNoQ52logd1IKBcfJbgS n7vQ== X-Gm-Message-State: AOJu0YzDIeAlsZenjCwchukYLVcl6/bF53KIxhnwXQjlVOD+5Vvozfkd oaP6tMfhcSvhJusEtVLdPwpnZKVgJzXaC0xZ7diMKOczMn8wdAT+z+tZ9b1o X-Gm-Gg: ASbGncu3ByXxQ1Hokb8cDTuNfXlG+bjDpcpLNbwTlORb8mEDKZ2WD65fhEYTKTksaSm 2FUv0Hly6cVVLZmN3iQHAEfaJBgYSZoOOXMOYEn9Hue7JmOlFvlQadjIUymbsqczb/Qnzn8/7tX if2lUqPvQ0HecCBYcGQ8eaoXXloeKWjXUALE/Jsl2h3k93HodnPzyIzpSF2QuKvhvpqpIubCJeb QT7RJe7FLIg6n2K167unAx8Nj5J2u8PPwX34Ba5R0Bc6sjxqo6OTSxSKDZ3u0mOdd+4jbKNO43c zv66KU5aCbWhcZZAZYK76ICoCr5XhYwU6oiVV39iOeZ2c6QoCek= X-Google-Smtp-Source: AGHT+IH6j9shcJ9rz0ZSXPJ917anHAEr6LynnE0p1DB4RkfPXA/+ARi2JU6kn+s0gpJOA9+f9089jg== X-Received: by 2002:a05:690c:7345:b0:6ef:6536:bb96 with SMTP id 00721157ae682-6f6eb677215mr382050477b3.10.1738082813372; Tue, 28 Jan 2025 08:46:53 -0800 (PST) Received: from localhost (c-73-224-175-84.hsd1.fl.comcast.net. [73.224.175.84]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6f75787729asm19282057b3.19.2025.01.28.08.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 08:46:53 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, Matt Wu Cc: Yury Norov , Christoph Hellwig , Rasmus Villemoes Subject: [PATCH v2 01/13] objpool: rework objpool_pop() Date: Tue, 28 Jan 2025 11:46:30 -0500 Message-ID: <20250128164646.4009-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250128164646.4009-1-yury.norov@gmail.com> References: <20250128164646.4009-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function has to track number of iterations to prevent an infinite loop. for_each_cpu_wrap() macro takes care of it, which simplifies user code. Similarly to for_each_possible_cpu() flavor, this patch introduces for_each_possible_cpu_wrap() version of iterator to keep usage of the API simple and coherent. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 6 ++++++ include/linux/objpool.h | 7 +++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index 9278a50d514f..5cf69a110c1c 100644 --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -1033,11 +1033,17 @@ extern const DECLARE_BITMAP(cpu_all_bits, NR_CPUS); #define for_each_possible_cpu(cpu) for ((cpu) =3D 0; (cpu) < 1; (cpu)++) #define for_each_online_cpu(cpu) for ((cpu) =3D 0; (cpu) < 1; (cpu)++) #define for_each_present_cpu(cpu) for ((cpu) =3D 0; (cpu) < 1; (cpu)++) + +#define for_each_possible_cpu_wrap(cpu, start) \ + for ((void)(start), (cpu) =3D 0; (cpu) < 1; (cpu)++) #else #define for_each_possible_cpu(cpu) for_each_cpu((cpu), cpu_possible_mask) #define for_each_online_cpu(cpu) for_each_cpu((cpu), cpu_online_mask) #define for_each_enabled_cpu(cpu) for_each_cpu((cpu), cpu_enabled_mask) #define for_each_present_cpu(cpu) for_each_cpu((cpu), cpu_present_mask) + +#define for_each_possible_cpu_wrap(cpu, start) \ + for_each_cpu_wrap((cpu), cpu_possible_mask, (start)) #endif =20 /* Wrappers for arch boot code to manipulate normally-constant masks */ diff --git a/include/linux/objpool.h b/include/linux/objpool.h index cb1758eaa2d3..b713a1fe7521 100644 --- a/include/linux/objpool.h +++ b/include/linux/objpool.h @@ -170,17 +170,16 @@ static inline void *objpool_pop(struct objpool_head *= pool) { void *obj =3D NULL; unsigned long flags; - int i, cpu; + int start, cpu; =20 /* disable local irq to avoid preemption & interruption */ raw_local_irq_save(flags); =20 - cpu =3D raw_smp_processor_id(); - for (i =3D 0; i < pool->nr_possible_cpus; i++) { + start =3D raw_smp_processor_id(); + for_each_possible_cpu_wrap(cpu, start) { obj =3D __objpool_try_get_slot(pool, cpu); if (obj) break; - cpu =3D cpumask_next_wrap(cpu, cpu_possible_mask, -1, 1); } raw_local_irq_restore(flags); =20 --=20 2.43.0