From nobody Mon Feb 9 07:23:52 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F039D1DE3BF for ; Tue, 28 Jan 2025 16:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738081852; cv=none; b=MW9IrFBuzLErNBVpgnr/XGcoMyflZh9ESlgGePW8jL27mCBT8AbqelSFR7U17LcRbSHGFN41QIfJUuxfwP1nu366/w2CiEMmQ7FFETEotO8Hqw7JSCKkX6HGiYfJCBZ6ifbqpL99LAs7fhfxSJf9kTzLHWEjmlrn4/7aTU7FnS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738081852; c=relaxed/simple; bh=u5O791YdxIpS8aoD45P7jv082v8LlinLwr77M4V6kdk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=oGCKgpqFgt3wnBRmiexFP2mKPBrENIBNX49dKzqzkJdtYCUumTGsfMXe109g0ZpvL3yLHetBa5ic7kZILXZxFdVCPahcgAsf2wJMWC0okOW+O8lzpG3p1L9dFUDL4VICBCKrgPwJ1seIKh3kItrUkywKkXJ4GBSMVwxjcFvBghc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=PhU9Pn52; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="PhU9Pn52" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-216634dd574so71204915ad.2 for ; Tue, 28 Jan 2025 08:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1738081850; x=1738686650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LX1jGIIkfllcVoAdPxK+2jAwohid6/STTjw8AE9goHI=; b=PhU9Pn52Nhcdh8hUwoiPWhrn4XkO7ifq3byXC8m+ySnEkClz20K2dTh0V7mbpS0To4 X3ojx5TQO558YgIhEP/J3ADb5Anbh9w7knNg4oaONZUz8NZblOdeDfRyc1yM0SF4USIL r8HWqLcdNNslMg1egK6ymkFIDPYcRf7C+DkLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738081850; x=1738686650; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LX1jGIIkfllcVoAdPxK+2jAwohid6/STTjw8AE9goHI=; b=a2fULRHWp7N/ZxbUqYeu3KVg4rUT5n9QpR9cdNZMlYE6sa8jWDZ1WMi0o1KVcSQgfL 1PU16PBUobxshW2l5KQfiLcZRj5CMU286lpwmqW8+05UuAhDuxVLEfnErdEyh4TKjp8c 5rDWPCscpJeDdIzt4h0n5UdzHPjfryt441XaOi10g4pJhMtnlF3efWuGOpPyd/qJf62a Fc+3OP6o/KMq2Z11LcKvN7G806+Ks+R0DyQTqtcNJTvEri/dfFlmV5DaKmGoIKf1QjvP ezLoR6/DMgvozSNedXNXu9Bxc5+haamYowLhbwN2IdZ2jhTDdteZHG9pfXfqqUWatvsx vFIg== X-Forwarded-Encrypted: i=1; AJvYcCUuv72mIJRRtnwmo/d85hDQouy6tnrBw9/PR1ELWHC21fr9/BgXxPKCTs77SiaXfFwYPTOyvkXvhJjl8uU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9isTCoCJ7RhuxICvfo8y6hPj1q5LbtKj8KriqYt9IP8p6a9zd XONoWMunpARIKLKSJZtdpG4PmrWrGtSh1Unc1gVb3kXpoAFadMiuDvoxMOA/xfA= X-Gm-Gg: ASbGncv+7lf3/85q2YIXSihOxEZG2mPYWeta0SyeMKygagym3HwNLPFxNqb9J45fNmU hX9gDAZ9kUTKFP/YQ+ZpI7puSTvbuLp3nRgrP2CzQoq6GtaVVhwap+j5QGvAqkWxXhry3J5gpG1 T4ZxbeWlb6hO56gWA2EeJTLJJZA82KFxKzsxdyAbj4gjNLb6KUNymTdwQsxWurg2g9JewdqN3VI QjHJGCx3UaUGW4EbDCiKxqsE2oTyvqHXa7XI+JhrA6iYAfpzDzOXyns32Gjtj+OlMjZVVRmazx/ v8OpOwLf/bPuZMNVzvwIEPc= X-Google-Smtp-Source: AGHT+IEAl/Zi42GFgnT8NQz6rfBEjd3C3YnMh7rFy+I613HyXYnDjSd+uiXcdCJPwy5Jeu918ctDNA== X-Received: by 2002:a17:902:f64b:b0:215:b087:5d62 with SMTP id d9443c01a7336-21c355b5684mr738165195ad.36.1738081848738; Tue, 28 Jan 2025 08:30:48 -0800 (PST) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da4141302sm83759335ad.154.2025.01.28.08.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 08:30:48 -0800 (PST) From: Joe Damato To: netdev@vger.kernel.org Cc: sridhar.samudrala@intel.com, Joe Damato , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stanislav Fomichev , Mina Almasry , linux-kernel@vger.kernel.org (open list) Subject: [RFC net-next] netdev-genl: Elide napi_id for TX-only NAPIs Date: Tue, 28 Jan 2025 16:30:37 +0000 Message-Id: <20250128163038.429864-1-jdamato@fastly.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" TX-only NAPIs currently do not have NAPI IDs. If a TX queue happens to be linked with a TX-only NAPI, elide the NAPI ID from the netlink output as a NAPI ID of 0 is not useful for users. Signed-off-by: Joe Damato --- net/core/netdev-genl.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index 715f85c6b62e..3116e683e516 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -397,9 +397,12 @@ netdev_nl_queue_fill_one(struct sk_buff *rsp, struct n= et_device *netdev, break; case NETDEV_QUEUE_TYPE_TX: txq =3D netdev_get_tx_queue(netdev, q_idx); - if (txq->napi && nla_put_u32(rsp, NETDEV_A_QUEUE_NAPI_ID, - txq->napi->napi_id)) + if (!txq->napi) goto nla_put_failure; + if (txq->napi->napi_id >=3D MIN_NAPI_ID) + if (nla_put_u32(rsp, NETDEV_A_QUEUE_NAPI_ID, + txq->napi->napi_id)) + goto nla_put_failure; } =20 genlmsg_end(rsp, hdr); base-commit: 0ad9617c78acbc71373fb341a6f75d4012b01d69 --=20 2.25.1