From nobody Mon Feb 9 10:26:34 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5CFF19D89E for ; Tue, 28 Jan 2025 11:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738063195; cv=none; b=dilEWZ/LLBp7E0zxgPTy7YvlKVyo32eAomXTh3grMcACQRUIr3L5hI0S3MzovOvTKuol1rMdTvGhvoJlknANgOGqD/o6+y8XC98kKUfv9UZsqS56PbQuLJHcCRZF8kWC8DR1z4cYmO3m50NXNQ4Sq9Zl4z8HwLFnawaAVh4ORIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738063195; c=relaxed/simple; bh=JniHcGAvnt8DXzw5ROzdFmRwdCcds2G6y2PelLRKYcg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bJqPCFVNQ2NH2oMjAqmbJKbu2AuS/3O3BB/0nr5mkpfqmHW667TnqH4sTW4Ql7rnMlXosOft2+fpZu8EOIX/s+v8ucdx75pzYZXW2KaFH0MtvrxK1bKoSjP3S/2Ep/aVuv6qcBaVaNdn4NsqKWfhKcjq9AvkYjhT8buHcS6QvGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iFFWU6MX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iFFWU6MX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738063192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DgODQwACdIA74cHoET43eABvQJ3HScrz4Yv4f+hZQ7U=; b=iFFWU6MXdm3qIjvBTwSO9Tzl1TvBZYHmfuHPT1X6+99xtbZ41wEo1MOTWEVhgZUt4333ki CFXsUdRVnIhIV3J47wadTzCitN3aT38Z2Ht637il2lrSgJRYtlMtTsWlphUx9KdqNcyJlo /+SFnXeM5nS0RrFVXyYfRf0eODZfBQ8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-GTxJklr4MS2oJmWaLNseeA-1; Tue, 28 Jan 2025 06:19:49 -0500 X-MC-Unique: GTxJklr4MS2oJmWaLNseeA-1 X-Mimecast-MFC-AGG-ID: GTxJklr4MS2oJmWaLNseeA Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 131251801F1B; Tue, 28 Jan 2025 11:19:48 +0000 (UTC) Received: from gmonaco-thinkpadt14gen3.rmtit.com (unknown [10.39.193.107]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 95E221800358; Tue, 28 Jan 2025 11:19:44 +0000 (UTC) From: Gabriele Monaco To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Gabriele Monaco Subject: [PATCH] tracing: Fix DECLARE_TRACE_CONDITION Date: Tue, 28 Jan 2025 12:19:26 +0100 Message-ID: <20250128111926.303093-1-gmonaco@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" Commit 287050d39026 ("tracing: Add TRACE_EVENT_CONDITIONAL()") adds macros to define conditional trace events (TRACE_EVENT_CONDITIONAL) and tracepoints (DECLARE_TRACE_CONDITION), but sets up functionality for direct use only for the former. Any attempt to use DECLARE_TRACE_CONDITION fails the build. Add preprocessor bits in define_trace.h to allow usage of DECLARE_TRACE_CONDITION just like DECLARE_TRACE. Fixes: 287050d39026 ("tracing: Add TRACE_EVENT_CONDITIONAL()") Signed-off-by: Gabriele Monaco Reviewed-by: Masami Hiramatsu (Google) --- include/trace/define_trace.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h index e1c1079f8c8d..ed52d0506c69 100644 --- a/include/trace/define_trace.h +++ b/include/trace/define_trace.h @@ -76,6 +76,10 @@ #define DECLARE_TRACE(name, proto, args) \ DEFINE_TRACE(name, PARAMS(proto), PARAMS(args)) =20 +#undef DECLARE_TRACE_CONDITION +#define DECLARE_TRACE_CONDITION(name, proto, args, cond) \ + DEFINE_TRACE(name, PARAMS(proto), PARAMS(args)) + /* If requested, create helpers for calling these tracepoints from Rust. */ #ifdef CREATE_RUST_TRACE_POINTS #undef DEFINE_RUST_DO_TRACE @@ -108,6 +112,8 @@ /* Make all open coded DECLARE_TRACE nops */ #undef DECLARE_TRACE #define DECLARE_TRACE(name, proto, args) +#undef DECLARE_TRACE_CONDITION +#define DECLARE_TRACE_CONDITION(name, proto, args, cond) =20 #ifdef TRACEPOINTS_ENABLED #include @@ -129,6 +135,7 @@ #undef DEFINE_EVENT_CONDITION #undef TRACE_HEADER_MULTI_READ #undef DECLARE_TRACE +#undef DECLARE_TRACE_CONDITION =20 /* Only undef what we defined in this file */ #ifdef UNDEF_TRACE_INCLUDE_FILE base-commit: 9c5968db9e625019a0ee5226c7eebef5519d366a --=20 2.48.1