From nobody Mon Feb 9 23:16:19 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB20194C6A for ; Tue, 28 Jan 2025 09:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738055766; cv=none; b=Gv1tF0L34UG1/+67iow7gw7tPudD46+cvdJNhpcNyoQPQChSkIiHMatUrA1PKt1hHlmGr29Tggp6QIrzXcbKm7vhkXnPBXdJUW9mY66sFhBPp4WsBXlBuzRIVM6gyv2w84McuogwGhpDJJXBzCl5NkWWc1nsN8cDYzdNYArn78k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738055766; c=relaxed/simple; bh=Cvr4uQcWG+OFwSlzG7QQgXzDWMzHG8QrA4n3shGfTDM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SFZHv0cnN3MS2b7NilFLDfbyQ7bfmpeaJqN8PlRcyp0ch0bGhmvIQ8ZZeHS0aKCawSMDEkFWnw8QODTDLVq5sq+Z0POvsyb7xe+EgjdaYn9XzS/Kqpt7dvkc9TaqdEQpV4Hz4naJ8m/r0XUxQfLQb9ufuHCRebkfF+U8O+beawc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VJ0ZIIau; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VJ0ZIIau" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-436341f575fso58857975e9.1 for ; Tue, 28 Jan 2025 01:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738055762; x=1738660562; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DCBBhRfrf1i+0amWmGIPe+VXXa83PVcgdkafwK7ozwg=; b=VJ0ZIIauNEox9j91C6h604JHiSAVv00dDO5dNJLJsK+M07CS+qdHpJe4fCXy5Th8ih PzjXCNF5kSZV0kWLpLc5LYl9NFPDoAyAMyDJYBMnkcaKXBNNZM60YT4/UtyTQhJcQbT3 e4XTr0fuCIZZhqQrsCJTJb9J8AtvFr1mNXBhocnanf0BFyN84QyvCG5Hij1PAlsKnwFQ HM5L4F/U2VuNIhlQdKvCurfd/ziCR8Xh+WRYdFXZhvlboP6U724YaNjBMlHuGtvqhPKz LKFIvRJ4jDEbM4x85/1igSq9JREc2iW4mPbjcZxJvJW+ijfusM1HGfqxh9erEk5XePGl 2R8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738055762; x=1738660562; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DCBBhRfrf1i+0amWmGIPe+VXXa83PVcgdkafwK7ozwg=; b=rFYikrGbKTQEorLDjTdYrZveHPnH0njeirX7Su72U4hcUw96W/bzQpXrxwNs1gwjqm p7OOQoNF/Sf9VXbY5joxtD/hAdqnubHVhdZlNwljnYpFd3W3Y11UZdJ+vK7L5WGOARJw iiVz7SIIOFTLM4iFyHCXbzvhIRy07I58uWEA80Axsi0UGf6G+VP8UPpKn0F5mq2qSpNg icaSmVE4CAJUXq6ko1VEYqc3vL4gee8UGWUsUdY+Oc7xvSRKpdMKji/J8IHFblFxdPzJ Tr6vupjUg0mFrBORYFcyl1oVcmS1Hv3tp6zvav/fJFfidFoA5xF3PxCkrFBnqc+3mGzE aBqQ== X-Gm-Message-State: AOJu0Yyk7akZ9/S9668EZQVgCcBb/FOfEscisqeEEyg4/Ncw+isPYMml 34yjTWOZOEVnOuVXaMG05nhK9QaZ6KXrSzMdGyR8iuNddYZjkzn7qfvSQnojsUyTZwqdfgbPrmr D X-Gm-Gg: ASbGncuWvOOSulKXjRpQwbxMIpEfzdXMFbLJH8kYoCkCH69ItUBBmDIknQLj/wlEj36 KkRgrUt5T1zYlRrloWQVeksIfzqbuo9tubURL/ymtadriLD2lYvPd5/yy8SC0Zuj042BDz69DqJ LIyeXcUakIFLbZ2tHBgKnhXWs3KryH/r9/JgaVDJptwcDklJIZVnAIJTlX5OcpxIftviRTkSuSG sPOXjU/uMJdkvgkNqrQdXkyr8/zAUxuLQ5lZfe0ox0rQvoLxHpptVmMWPWQVgPXzwCpemQxIOQx sQAJY+yHFwr68GLkBBIwMhoryUBS1s1aZdTLdXwt5mP8EE1cdgWLMMASv37cd2lh2it1GkQ= X-Google-Smtp-Source: AGHT+IGz32dqlyb4iPhToExu/VkawQd8PiO3Di/Rg3Bso/rDoVM/9MjugQ23vA0YfQKBDwIwFTIPKA== X-Received: by 2002:a05:600c:524f:b0:436:1baa:de1c with SMTP id 5b1f17b1804b1-438913e6f88mr416304205e9.13.1738055762135; Tue, 28 Jan 2025 01:16:02 -0800 (PST) Received: from ta2.c.googlers.com (169.178.77.34.bc.googleusercontent.com. [34.77.178.169]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd54c0d1sm164577105e9.26.2025.01.28.01.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 01:16:01 -0800 (PST) From: Tudor Ambarus Date: Tue, 28 Jan 2025 09:15:46 +0000 Subject: [PATCH 1/6] mailbox: use error ret code of of_parse_phandle_with_args() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250128-mbox-mutex-v1-1-1f0169ca5f61@linaro.org> References: <20250128-mbox-mutex-v1-0-1f0169ca5f61@linaro.org> In-Reply-To: <20250128-mbox-mutex-v1-0-1f0169ca5f61@linaro.org> To: Jassi Brar Cc: linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, willmcvicker@google.com, kernel-team@android.com, Tudor Ambarus X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738055760; l=1202; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=Cvr4uQcWG+OFwSlzG7QQgXzDWMzHG8QrA4n3shGfTDM=; b=hsR2KaoHFJ+0PmnYrbokQGCPwAh83LDa7Mrtb0xKzeahMvUCA0SeZe1+KGkSYn1NJTLqvRRcV NiyBi2ednccBZWd3TrL1sdc6b3sUJD60gjKT9+o79WZ+Q2vN1c6tkoP X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= In case of error, of_parse_phandle_with_args() returns -EINVAL when the passed index is negative, or -ENOENT when the index is for an empty phandle. The mailbox core overwrote the error return code with a less precise -ENODEV. Use the error returned code from of_parse_phandle_with_args(). Signed-off-by: Tudor Ambarus --- drivers/mailbox/mailbox.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index d3d26a2c9895..cb174e788a96 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -415,11 +415,12 @@ struct mbox_chan *mbox_request_channel(struct mbox_cl= ient *cl, int index) =20 mutex_lock(&con_mutex); =20 - if (of_parse_phandle_with_args(dev->of_node, "mboxes", - "#mbox-cells", index, &spec)) { + ret =3D of_parse_phandle_with_args(dev->of_node, "mboxes", "#mbox-cells", + index, &spec); + if (ret) { dev_dbg(dev, "%s: can't parse \"mboxes\" property\n", __func__); mutex_unlock(&con_mutex); - return ERR_PTR(-ENODEV); + return ERR_PTR(ret); } =20 chan =3D ERR_PTR(-EPROBE_DEFER); --=20 2.48.1.262.g85cc9f2d1e-goog