From nobody Mon Feb 9 16:45:57 2026 Received: from mail-ej1-f73.google.com (mail-ej1-f73.google.com [209.85.218.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E9281DAC92 for ; Mon, 27 Jan 2025 21:50:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738014633; cv=none; b=PHJGG9a95bSmjtIgVx0aokROQWseW+TLQb2eomrRyQCjwM3x6iNrd8NxoMfxzEO5kFxR5cQTPu843xALSA4gXS0Sia35KRa0QH7SFKTLzAjYCtWholmExAoohO98UjOhJTonke/ppnP3ZRCF0ReNazbwFA6NJrrt+aGv6M/ULr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738014633; c=relaxed/simple; bh=2teDC77wBdkx/l9SEkD300ISryVWr/cnRxpiSxLEc2U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=WPF8SEw8CgC4sykcuvC54sLC7D9GbAOTVAjm/0ocU651Jw5iIkhflsnS2Ame6L1IvZhizVglqpRFGrWwp9xZIvDZMtqr9QOpWHWduuLocBUagxTx16o+zIeB0HkX8yfS6f2YkysDJ1uxhH1k39wgDFq1NJxig2PwYtkqoPTADSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=N3SA8zCX; arc=none smtp.client-ip=209.85.218.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N3SA8zCX" Received: by mail-ej1-f73.google.com with SMTP id a640c23a62f3a-ab2e44dc9b8so623252566b.1 for ; Mon, 27 Jan 2025 13:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738014629; x=1738619429; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MTdaJMw+GE/ToWZXQwf98N8OcNSfcH4MlIjaDI1DCcU=; b=N3SA8zCX84BJi/20T1uGCcovEVxJuPM4mInvutRGiHc6SwgFyulDOCCi3yedCXYIWR FyCOvqxS1qQ5ayN5fRQ1X3VrxvgUK9rnQ426FP4jPhoPTOF3gqzfxf+O5Q4W3v5Z/vcF ctH2lkCKVVK1NMrsTZil4HFD19/hYa/U1kUNDunkjcEjuLWs3PAs/mfV8u+GNgqfA7vi 3h9+seIDdgYyX+xLGM92MiVsT9f5W6xNGNYBNJ+APq0R2Df6l2MtD0XOMePT3hE/sU+j dHtrdj1QIrSm+Bl0TZQdp6Dh6fuRG2NFZ8jnd/DSaLzwSzIF+FK9PvKqfwbG2e9+3Ey6 9KDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738014629; x=1738619429; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MTdaJMw+GE/ToWZXQwf98N8OcNSfcH4MlIjaDI1DCcU=; b=aCtjctA2eHqvZf589lM3SAn8BEsgA+3AQKvVhVdTmc4QjdksDZeCP9fQVezACG3WUx X822+UerSCJkxjZK09AYbajADzTqMWJ2Rn6J+BtZEHstD9OqP2Zc4QHjYW4pkopqsqxy exR/MPexxKnuxe0REtDAtnnHWcwaa1DcfFI985S/99ooy7BdgStOy+RlJXh1tff8FEdo I0s2XY9Kd2yPVI5WLBmywkZUoQtxS3y0+PtlIolEolg3zsyzYJT0LbUd2E2qjAEerwA/ 0dQ/YjpQs6rIiWCNjRId6bT6tZJp1Wors4PpQptZonTfnhD7OCUEYcoUpG31pWHWCjic sqYA== X-Forwarded-Encrypted: i=1; AJvYcCV3Q9YAwyHFKPfze0RDTP+AWmgC3zmjbwJiyBrO4A5XzZFRnz7rKk7doIPe1qSR8/kdMgQ/slJXqHCHCYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwJau7u2E5T+KBQoMottFxijiL4TIw6/Kto1sLeNiugaenbixRh qNvmIzYBsvTX5BcwFs+egw1x8J+r7HyTZCHBN6wdKynQREMJSBqRA91P/h1HdVP6JNSeWJBVUFE 22z6QQo2I9BQ4Y24FWA== X-Google-Smtp-Source: AGHT+IEZ97Jrd+XbhDMk2Rlpya1DB4YXBpa+0gMNH2ryXyYrsEg4Wyx9e7mEhh9FRPyIxeIP94pTyP8woXLmR7rg X-Received: from ejrv14.prod.google.com ([2002:a17:906:564e:b0:aa6:7b6b:b0c8]) (user=mclapinski job=prod-delivery.src-stubby-dispatcher) by 2002:a17:906:1e57:b0:ab3:a352:eb0f with SMTP id a640c23a62f3a-ab6bbb6be69mr81943166b.30.1738014629505; Mon, 27 Jan 2025 13:50:29 -0800 (PST) Date: Mon, 27 Jan 2025 22:50:19 +0100 In-Reply-To: <20250127215020.4023545-1-mclapinski@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250127215020.4023545-1-mclapinski@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Message-ID: <20250127215020.4023545-2-mclapinski@google.com> Subject: [PATCH v3 1/2] mm/compaction: remove low watermark cap for proactive compaction From: Michal Clapinski To: Andrew Morton , Vlastimil Babka , Pasha Tatashin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Clapinski Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously a min cap of 5 has been set in the commit introducing proactive compaction. This was to make sure users don't hurt themselves by setting the proactiveness to 100 and making their system unresponsive. But the compaction mechanism has a backoff mechanism that will sleep for 30s if no progress is made, so I don't see a significant risk here. My system (20GB of memory) has been perfectly fine with proactiveness set to 100 and leeway set to 0. Signed-off-by: Michal Clapinski --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index a2b16b08cbbff..29524242a16ef 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2253,7 +2253,7 @@ static unsigned int fragmentation_score_wmark(bool lo= w) * activity in case a user sets the proactiveness tunable * close to 100 (maximum). */ - wmark_low =3D max(100U - sysctl_compaction_proactiveness, 5U); + wmark_low =3D 100U - sysctl_compaction_proactiveness; return low ? wmark_low : min(wmark_low + 10, 100U); } =20 --=20 2.48.1.262.g85cc9f2d1e-goog