From nobody Fri Dec 19 17:54:49 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19EE1DC04A for ; Mon, 27 Jan 2025 21:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738013619; cv=none; b=klMT5unNYPyckU5GrZHLl3c/abYc2vJFmZ+H6RpNhgeB7NBAw/H9xgtxBQq8tMvQPajrvUydAXWvnjLHt3x7ISaIf5MdMNwOwjJnNAbmdxGswW8tajEupIGqp/u9xGq2ldEycwfFTgPYRyNHajzprGu6AZEaX7zY1wcMbS2otgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738013619; c=relaxed/simple; bh=0ubT0xAtIOtmf4+xnpRjnjYol+CqTrZ8xAjo8nvcNvM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FL9rX4xiZVFtZ69j7YZ+lq0OB8r7MFjbFPwOfFYQOg+GO0GfJ++p3hVWRmW/brtxNPyb932hpRAQSe1hRSpQB2TMiw9cR75xntZuXM+kwlsBYBC5SvoeBeg/YwUtH8Poy9i/qAS2KYzp+tOTEpU8oRxq7+NPhlQyfMyZmE4GKt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=byKFvHqx; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="byKFvHqx" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2163dc0f689so144572365ad.1 for ; Mon, 27 Jan 2025 13:33:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738013617; x=1738618417; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mFZXsTdloa5FzORw/CsOyUNbSmbFrEPnylJyQFApTRk=; b=byKFvHqxa6uwtj1PpyusG9Crc0EIWmJqd+MM6iNb6/8i/imykVkJFRzl1jJ45smEf1 Ys7kiBwq3XxjKlAxy9wtxYbuVnO7oq6VD5ZgTxDjiZpwbeeC2xNohSkBC+LxSiaN0571 mLieTnpf2OipXafKJ6YeVdGQHu+ganUmCuNqc4J379Rww5KTX54Yk0GsGG0XG+rLhgmE Xwi5p/ZsaJMr/T72e9oXQApap9CMB2BoFDKthZOxpvIaWVgppvp2Lh5fNQXCAuG8ydoM swRUg8/q19FL0G3te1MgYdX5SU4+bXHU9jHHQYE4YhJqzuafiKHonOxcBZg1p2CedG/7 P4vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738013617; x=1738618417; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mFZXsTdloa5FzORw/CsOyUNbSmbFrEPnylJyQFApTRk=; b=sNI5cT9ISzy3j/UqtfNTI1M9fdL4EAOiK2C2VC8EHqBkjg1b4N5IDyZ/+y0Dlh9Zgv iCyk0EuJAwMxHrgoRu7WBnRY13UXbI1znv6r4KxBkdu4FQnnpTWXqvwuK0TGfXzpdCOG Kh63wFrmUG8MsjQdod3gDAMXSP7YqV6YHofelZgM19zjyQ7NKwXO2GVx+hWx1MH4HCkH 4pzTw+wAbJeVqBDrlAEH9nSoRrhZHZzX6sYA7vgriRvlE868vf5o/uZ5ztXAPTKrvliG yixdpf6TJLMW9IxGNo40EAtay/J7ru2TDXpalYlKkJU1m9yhBGcraNxwwgVY/5eAQteE q73A== X-Forwarded-Encrypted: i=1; AJvYcCXFOkNulgCEA1nkjlZ/G6o/cV3wbALdFCDLZJ1ens1ey//RC+BPM86J909i7n8Wq5ejMYX72ZogErM1V0I=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnmvhv841LVk7kWBMixVLkQwMOh+sHtx1tmxOQqSVuTn9trMi4 APREyp4sx2+jRlb5TaYmi8hxUt3LegjJKr2UiIFox8dnIJCfG98SWGfoi1tcXFTSss1ZGSKorQ= = X-Google-Smtp-Source: AGHT+IENha76YNN6DTFkO6aZG4PVMEo+T4QLkeiQTYtMA7zB4aNyty+JXRxi3cxPQYVRs4yLEbvYOf/KmQ== X-Received: from pfbbx20.prod.google.com ([2002:a05:6a00:4294:b0:729:14f9:2f50]) (user=wnliu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:12c6:b0:1e0:e000:ca60 with SMTP id adf61e73a8af0-1eb215ec22fmr70877628637.28.1738013617138; Mon, 27 Jan 2025 13:33:37 -0800 (PST) Date: Mon, 27 Jan 2025 21:33:07 +0000 In-Reply-To: <20250127213310.2496133-1-wnliu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250127213310.2496133-1-wnliu@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Message-ID: <20250127213310.2496133-6-wnliu@google.com> Subject: [PATCH 5/8] unwind: arm64: Add sframe unwinder on arm64 From: Weinan Liu To: Josh Poimboeuf , Steven Rostedt , Indu Bhagat , Peter Zijlstra Cc: Mark Rutland , roman.gushchin@linux.dev, Will Deacon , Ian Rogers , linux-toolchains@vger.kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, joe.lawrence@redhat.com, linux-arm-kernel@lists.infradead.org, Weinan Liu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add unwind_next_frame_sframe() function to unwind by sframe info. Built with GNU Binutils 2.42 to verify that this sframe unwinder can backtrace correctly on arm64. Signed-off-by: Weinan Liu Reviewed-by: Prasanna Kumar T S M . --- arch/arm64/include/asm/stacktrace/common.h | 4 ++ arch/arm64/kernel/setup.c | 2 + arch/arm64/kernel/stacktrace.c | 59 ++++++++++++++++++++++ 3 files changed, 65 insertions(+) diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/includ= e/asm/stacktrace/common.h index 821a8fdd31af..19edae8a5b1a 100644 --- a/arch/arm64/include/asm/stacktrace/common.h +++ b/arch/arm64/include/asm/stacktrace/common.h @@ -25,6 +25,7 @@ struct stack_info { * @stack: The stack currently being unwound. * @stacks: An array of stacks which can be unwound. * @nr_stacks: The number of stacks in @stacks. + * @cfa: The sp value at the call site of the current function. */ struct unwind_state { unsigned long fp; @@ -33,6 +34,9 @@ struct unwind_state { struct stack_info stack; struct stack_info *stacks; int nr_stacks; +#ifdef CONFIG_SFRAME_UNWINDER + unsigned long cfa; +#endif }; =20 static inline struct stack_info stackinfo_get_unknown(void) diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 4f613e8e0745..d3ac92b624f3 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -32,6 +32,7 @@ #include #include #include +#include =20 #include #include @@ -377,6 +378,7 @@ void __init __no_sanitize_address setup_arch(char **cmd= line_p) "This indicates a broken bootloader or old kernel\n", boot_args[1], boot_args[2], boot_args[3]); } + init_sframe_table(); } =20 static inline bool cpu_can_disable(unsigned int cpu) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 1d9d51d7627f..c035adb8fe8a 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -14,6 +14,7 @@ #include #include #include +#include =20 #include #include @@ -242,6 +243,53 @@ kunwind_next_frame_record(struct kunwind_state *state) return 0; } =20 +#ifdef CONFIG_SFRAME_UNWINDER +/* + * Unwind to the next frame according to sframe. + */ +static __always_inline int +unwind_next_frame_sframe(struct unwind_state *state) +{ + unsigned long fp =3D state->fp, ip =3D state->pc; + unsigned long base_reg, cfa; + unsigned long pc_addr, fp_addr; + struct sframe_ip_entry entry; + struct stack_info *info; + struct frame_record *record =3D (struct frame_record *)fp; + + int err; + + /* frame record alignment 8 bytes */ + if (fp & 0x7) + return -EINVAL; + + info =3D unwind_find_stack(state, fp, sizeof(*record)); + if (!info) + return -EINVAL; + + err =3D sframe_find_pc(ip, &entry); + if (err) + return -EINVAL; + + unwind_consume_stack(state, info, fp, sizeof(*record)); + + base_reg =3D entry.use_fp ? fp : state->cfa; + + /* Set up the initial CFA using fp based info if CFA is not set */ + if (!state->cfa) + cfa =3D fp - entry.fp_offset; + else + cfa =3D base_reg + entry.cfa_offset; + fp_addr =3D cfa + entry.fp_offset; + pc_addr =3D cfa + entry.ra_offset; + state->cfa =3D cfa; + state->fp =3D READ_ONCE(*(unsigned long *)(fp_addr)); + state->pc =3D READ_ONCE(*(unsigned long *)(pc_addr)); + + return 0; +} +#endif + /* * Unwind from one frame record (A) to the next frame record (B). * @@ -261,7 +309,15 @@ kunwind_next(struct kunwind_state *state) case KUNWIND_SOURCE_CALLER: case KUNWIND_SOURCE_TASK: case KUNWIND_SOURCE_REGS_PC: +#ifdef CONFIG_SFRAME_UNWINDER + err =3D unwind_next_frame_sframe(&state->common); + + /* Fallback to FP based unwinder */ + if (err) err =3D kunwind_next_frame_record(state); +#else + err =3D kunwind_next_frame_record(state); +#endif break; default: err =3D -EINVAL; @@ -347,6 +403,9 @@ kunwind_stack_walk(kunwind_consume_fn consume_state, .common =3D { .stacks =3D stacks, .nr_stacks =3D ARRAY_SIZE(stacks), +#ifdef CONFIG_SFRAME_UNWINDER + .cfa =3D 0, +#endif }, }; =20 --=20 2.48.1.262.g85cc9f2d1e-goog