From nobody Mon Feb 9 13:36:34 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC4B188CB1 for ; Mon, 27 Jan 2025 17:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737997388; cv=fail; b=HTCwDC7GA9OUppTqzPe9ZViBP7/3xBsefEFaGgJ1r9c8GICiVTu6OgbLoXKgIrPFdxPsKljK/9DMLRe1hLfw2bESBmOpZqsytfE4DjgwpivkgbmW39HCVX9J7wcqdMAQUUIGX89ZgTtFF4a/XLBlUbthVxV2WppCeT+O6PqiiWM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737997388; c=relaxed/simple; bh=cFqn20WVtMbPMYxLSF/JOgNXlNeoz/RBM0MgwMCH2XQ=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=Da259hcCJ99ZGw6vuSaX0EMmqZvE/KlaSR1iBPgrRWiQhKB7Iz+4mrM9mW81h8MIgrNgvKND5oM0/slYxY023C/X0TM08rKZAb8317f2PxFMT41Ft9a8dlSxiWneRv0PhYDQcMbI9UrfE0HUtB/Nx2z8srdwUCrB3Gio2fX1MBE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=D4wNiIZq; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=cE4gV5zh; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="D4wNiIZq"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="cE4gV5zh" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50RGJwaS006156; Mon, 27 Jan 2025 17:02:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=corp-2023-11-20; bh=zPwkTcDr0B0g7m+E rT2GtgG3Q+LXyE5e0Md0oPBEYd0=; b=D4wNiIZqEv8FodA4AykvNBkmXBgUlaa5 76ctAb8NWp+M2iNLu3DEU/gYqHxs63JCmkVfrudHEHpXWbE/SDS8O+yzxYQ25w+S 7ts55DB6LgmuVF2alLdCoMM4+STmLfJI8IZNgLf+5yhmJzJeT2CH+/F6mcRtTCgo 45dnbE7upa8U5X0/PxX14Spv6S5vfpEygsYdHsmJX2/VP7K23SoTq+NVduukhHa3 TKgCz9mDDBlhIS/QZ3Qtopqn6WjDPVwgNWljf3mSdvD5pUZRss+Hi+lF59FZITYB 7WAPheA/vV9wtBfe6bylN4hqx1658eJT/V6QYU6jRMq/9jyWihQrXA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44edj804bp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 17:02:36 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50RGKKwS015953; Mon, 27 Jan 2025 17:02:35 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2040.outbound.protection.outlook.com [104.47.55.40]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd6yh6r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 17:02:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E9Mr8xx6cJQIDkQwCXZtJiBgFKcjH6YC9WlfHpMxPz/RAOoQRGUsL9QLcx0D9+2c+r6Cl4Esiqbelsq7fXxWZ8/62Z1uOpGYPh4HzjsHXy6C+1kurPe6/VajqkCrE6g/PZBA/kuO/srRNOp4Ovn8Zn1cxtdrt93bCn1GibzMqmgRPyIVdp2u5L+kU00MO/euRgHlLSEJAw3uC7jAN+s380eSRo3WD9K4FreSizifwVTjKSGYMEvTFH+NRDB3tWwpnMphX6xhoLtc7/CuoAElHcxuYnTT3ziCI0kG5tox8mhsF2cb0P6yulL73W8Hu3KT84qOjsWa1oK7EdgTZkzlWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zPwkTcDr0B0g7m+ErT2GtgG3Q+LXyE5e0Md0oPBEYd0=; b=LeSHBaW++2ktMgpEBWpIKQ5QrK8S1WFR/5Bs3HQ6r4EFbMcX2nl+WVv6DZC01ST8+RBZ3n+f+m6jTrDBDkKrUmt8q+HFrNHm7rQ3UjrI47ANfbHBnS/df96VPJjjUFLiA1TAkHLD79ErPTfDQkXgIXWyVyBkslTkpAgz+CDdWVRhAoo11dIUTxiWRYP1wlORzbkiEZ6SO3yxJUqmjCN49w2yf9KHU0sb+wJCvU4Qb9ckjIG1vTrIKf0y/BKYcWIEKuk5lh96MTv2TuBJQ4+u0Ltc1MYltZW5KqZFFDdgiikQul+0meef1bwwZkU/jjxRxtLFIk244XKVeL6GVML/Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zPwkTcDr0B0g7m+ErT2GtgG3Q+LXyE5e0Md0oPBEYd0=; b=cE4gV5zhYiRa64lrFVD9DxtmcNO0Dh1JBwxELtYv0lpV9gEx4wiEvV7sjcPo6OTNiTZ/SwyNTqowJRJFVUfYqgI4oHvDzw4W7NXfJrvSoSvf8vSJzZSfQap0QsrTXJ+uuIhmy+KcW4nX6qnEa7jQmhfZGJx8K/nJErRBaoGn56M= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by SA1PR10MB7663.namprd10.prod.outlook.com (2603:10b6:806:38e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Mon, 27 Jan 2025 17:02:33 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%4]) with mapi id 15.20.8377.021; Mon, 27 Jan 2025 17:02:33 +0000 From: "Liam R. Howlett" To: Andrew Morton Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Liam R. Howlett" , Oleg Nesterov , Masami Hiramatsu , Jann Horn , Lorenzo Stoakes , Peter Zijlstra , Michal Hocko , Peng Zhang Subject: [PATCH v2] kernel: Be more careful about dup_mmap() failures and uprobe registering Date: Mon, 27 Jan 2025 12:02:21 -0500 Message-ID: <20250127170221.1761366-1-Liam.Howlett@oracle.com> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: YT4PR01CA0286.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:109::6) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|SA1PR10MB7663:EE_ X-MS-Office365-Filtering-Correlation-Id: cdb620fc-4e3e-4b08-6542-08dd3ef46416 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8gm4bKiyVfs8Hs7lGGGYhqf34Otu1ajR3ikZepjfcKpkgX7BSB2yb9v6rroA?= =?us-ascii?Q?bI++s09IoHP6fGRYhbLeo6l1Wf8JE2A77eDoV64bjVDwzk4rfuB+u1SI5Twx?= =?us-ascii?Q?Ey9YFjonnEW+HQVj6ef6FOEEJ2hIZBWqmsufwJ7/S/2j+sMH14Bj9vaHotxb?= =?us-ascii?Q?x6TxtQ2HYWBsK3HluM8dQd9Q9L6AMiesUug7XLnijQOqrBVXU8giCObTdV0o?= =?us-ascii?Q?AMbsps1esAKCDibCzDHwaMuNBJs7w3AELxn5U5i5CefWik9G6WMzUVCaI7fF?= =?us-ascii?Q?bJpGBidlK37N1ntZtOdImQldeaCUp1WTl3X9B0x3eMd0gnHl7xOcu03xlxCj?= =?us-ascii?Q?eGShgiG07WD+N40R88ltCjJAU2WPtKNmaw123xGpPED8bnJbW3vhJBsZxciK?= =?us-ascii?Q?SuovYVgwTihFN1gsddLvBDTReY6Jl7L6u05keJo3B3fTx4COUrKw/0Tb6Dfu?= =?us-ascii?Q?CbYRtqTFYqykyVGCjnRXE+BpatQysuZIm2ceSrlRaEsI1i8k47vXQAt7mbkQ?= =?us-ascii?Q?YMHzTULI/+MdJ2r3P450vRdSfMvDhlX61EXDZGigQCmHMLZKBCqSeKX66Utx?= =?us-ascii?Q?RYHXpaMkSGrUNmLOIf19lQH7tLqPL6l8OuhoUZWSsh0C+Cp7Ts/NkHzrC79p?= =?us-ascii?Q?SAMzcA5cKkvMJIGm6ieCAkN0md8Rh/IFuQwtxJokASFgvt5kghFxXoht1/ei?= =?us-ascii?Q?kZgMTOquN0PVy8h10c9PdcvbtDJGnrJbqB4KH/AnZ4UKJom+/ccLuKdSpUyx?= =?us-ascii?Q?q0W4DcOHKqDoFjbZwuT9Yl44/gn6fBSt00y2HZ+Gpo+kbOB7RemAU8hU8A3L?= =?us-ascii?Q?T23FYDrCntYZa18TAvYjv3cfAIcXpL8LLrUE2Q4gLml24tCMM7dwTS1rSHMf?= =?us-ascii?Q?j5SxZ533UHbljvQm5FV/GXRNNOKmLsMCuPJn8twGebAz0XInhCudvtoVaaUT?= =?us-ascii?Q?BuT68oAOZTGpCSK9vam3QVQrecnquuj1aNVSbItG5U+H6f4L09LLXIxD8v6o?= =?us-ascii?Q?n9VZtey0VGlThJbkdWI2mZJUFuPcFWaOXs3zgvHapWrhHw9jEqWE1uYiig65?= =?us-ascii?Q?7HR4w5+XtQ99NbLMOqJI0oNOT5AIcx5i8fNW5wHn/HOn/ZkD2TV8S2SI+tbs?= =?us-ascii?Q?xOqifBG9TVaJ540+w3C8OcWWhVIsGN2/iOR9tkuYgiChcqahKM3I4wbS7NTK?= =?us-ascii?Q?aXJ4z7G8KWF6flwAH+MP5Fjjoi4PnoLQIZ4Eoo9u1YtIReecEFOFrO1fZBhJ?= =?us-ascii?Q?EX9QiPgK1BHbiVDOOuGJ68twK1rzM/UKKe1XI3M2+XPAhN/s9NNem1KSR1kn?= =?us-ascii?Q?1CP+xQSs+B8MWz5mTS57nn7elNmJV43uBvKytwlspMnjTg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Ub6I3Z/4qOM5Sz9TveEsgSUTVqdGpGFBMxP9u2YDvn+mp0BrBaJaDjGd0f6?= =?us-ascii?Q?0pPHBxAEscfYplCbsFSMxC1ChLu4QO3EepDt2816+qMmnGQtgEm3qJfzoiH/?= =?us-ascii?Q?wC4E3AHJ6WicmH+Pxd2a2MAuOjCGPmRR83P7j+X5CtkBZ6Pe8m6yXG4Ak28c?= =?us-ascii?Q?vS+v8jY9Yvw7cCvkWrBizEMyAiOz7JPFjn1jCbAta2ZZFf8Apjtoqf1bI+yd?= =?us-ascii?Q?uP2QiSpJd6KdkHqN7qUP1IjunBUO+tsCVkppfU9kUTYRjk4idr+HcKTeC79z?= =?us-ascii?Q?GaVHkhVCg7zDoTjsJJZmF3dQV4IUXtbDiaxQpKHx3R8ed7n935psiVkjHKeY?= =?us-ascii?Q?hkeKDosDio+gXaBklhw3LOXARhVgMtTe5UCCqL+WX42GJdRTKBkNQzockGtd?= =?us-ascii?Q?7vvy+oDkIQ7/h1jGWRTnyQKW+gJnBtmgJUnUeQW3qbKMrU5dwNDk9GrDPzbW?= =?us-ascii?Q?MgnsMrspprgkF4pPrBd8c8RgH6EVCkEXfojRyrl66nvFjwq/8t9m7Xwt+F/6?= =?us-ascii?Q?Bw5c4j6oxOgUOYcYaSAuxoWuziNz//Q+e7pfqo8FpWfxgxrTMCuPGuYQBiyS?= =?us-ascii?Q?5yya6DdSrw5KWnVolP3p8QANwxfec+0LQOlDk6UzkQ4bBvMwAm0rqp8cwQy1?= =?us-ascii?Q?5R2ORNSymHMoHVTxt+oTct59JY5EZBX+halef6ptkIOjzTIXetswDpESiK5L?= =?us-ascii?Q?BaCvfXIzuVQAmz4vX1oG1eNzBkC72SE0h0LhBHe4Llu3qKqGagVUnhrR34KJ?= =?us-ascii?Q?6XDt3OlIk7X+9s8f/s6/2KjSJMgi+5+YzRymlyX0J8YVRbSAjdn/LjQx0AxJ?= =?us-ascii?Q?OqYEUisqQNUjwUjMM8mVMG5UJyqLqy2DITtnQAyC+kg6EyfC1hCPFlKlkIbD?= =?us-ascii?Q?zZTMa6hKocd11dmWJBB4mxmWlDvTJT8bZbs/noPIjw3nxjg2L64Hvem/0MKn?= =?us-ascii?Q?Mjx+O9RGGZmUk4Y7G2Q62e7T0l4j1RJYtpWDRyPi2JHJBE+cW6xp2DJidBW7?= =?us-ascii?Q?wnNMVsT4nT08WqCHmGNQdt587J6+Z/enjIFV6lmxMWwgd+clv6/3lNS9Gr0H?= =?us-ascii?Q?7VDOVbXA8AuvNagRPA2/jSJgB466kttd0E9ELmJcxrzzPHEl2V5MyJbk2m+L?= =?us-ascii?Q?seVWqYD+pk6ihnCwgBGh5tkUdv88XRg5BBoHV2Np8JwF9E2JRu45Ozk2wsJK?= =?us-ascii?Q?XvnFMN4Ve+DTnTIDud+VZmphMrhkV92Xalm9oUxcHyG40jd8Jwz4TbDvDOdA?= =?us-ascii?Q?/QKI7g96rO88Dwrp0L6UQOdzBPF4/UnGH93tEdcIxwKXMdL5nkzYjmXZ9Hgx?= =?us-ascii?Q?loApMJPRaEl5OUfIMMxUalzjNfcP3+IStCZOHJnEJFT/qYYokkj9qrwRajbN?= =?us-ascii?Q?TiIXU7FHmFrVEndnKfEB37juUbaO69qj54me/PmCsBla0T9d8g8w2I7+nQpm?= =?us-ascii?Q?afhnNElmmqOv/MNWhovR7u/kDjMiJRCYOCY8c+zqk8/7jpBYdajTZnbWnVFC?= =?us-ascii?Q?XwGH4tZGe/8F8GMxrp6o1s/lv/pptHxP1V7NvHloaWx0WdeK/TaamopHfnAb?= =?us-ascii?Q?Y1q4xlFSHfOutEcsu1+RBqtqeBvZ0WA3NDKR+tqu?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ln1UVpRwEjLIwF/Vzh9fOFChIY+3T+ywbQjRT8TJI4i8T4aF2Im2PbYy6tUOpgQCeRUSRFe3GudoLRFxlwVEE40X751F56rE0SZF2ho0YK5Z2oeNIgYi5IAFbV502ANMCx/Iyb0aeELQAMR4SaZkIiwMReCS4/pxzrPAOoaWGOZ5lYbZCCu+WPGn5PQuCPaQVXnaBZewzD15mGEa/FPCpphtNucv67kpa0DTyM4iduXkSq6K5MFBnpd4W/GzjArmWB6Ny3auickjPheEmEqL/zHVNNVK+d5LRlVZjT8A4+FhajTe79DrYlBw9JQr5N/xfYNz+ClkXZEs6jLvOwYPO5hqNSESU83lhbkjMwCTVbiYS2E9Ok+3/jiPTdVUFfDvaz12Hkqa0XZtZndAL26yOaCPaRZfBRGyX09WC6WeS6MB9TY9MPg7Ad4Lnrk06ieMCSdXkY4U1p+QwYdOJ5yrlWLYhnSKANvBox1DwvXY4E9nswzbO4fh41h3sWPn2hkMpzCPJOcjfTx1YOQrLZlHvgob1DkYhwLGPyWJym7VHEJrB7Z5KZwx9NLLQ/uhgKgwXOZejNCDrvHkqHpcRaQIBYZnz72Do2EpGG5Qqx6TlS8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdb620fc-4e3e-4b08-6542-08dd3ef46416 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2025 17:02:33.0196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3gj0YXsXxUW8zdVtzZ9oZdmFJ6Fxwu5QZeijYuO2Y8dVgu/S9yb/AKHuoqXi/vkcz0CcH+h17Bfxgw4czNwhjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7663 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_08,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501270135 X-Proofpoint-GUID: APE5dvJO_P3tUhu1eq-zJrXZRPfFyU8C X-Proofpoint-ORIG-GUID: APE5dvJO_P3tUhu1eq-zJrXZRPfFyU8C Content-Type: text/plain; charset="utf-8" From: "Liam R. Howlett" In the even that there is a failure during dup_mmap(), the maple tree can be left in an unsafe state for other iterators besides the exit path. All the locks are dropped before the exit_mmap() call (in mm/mmap.c), but the incomplete mm_struct can be reached through (at least) the rmap finding the vmas which have a pointer back to the mm_struct. Up to this point, there have been no issues with being able to find an mm_struct that was only partially initialised. Syzbot was able to make the incomplete mm_struct fail with recent forking changes, so it has been proven unsafe to use the mm_struct that hasn't been initialised, as referenced in the link below. Although 8ac662f5da19f ("fork: avoid inappropriate uprobe access to invalid mm") fixed the uprobe access, it does not completely remove the race. This patch sets the MMF_OOM_SKIP to avoid the iteration of the vmas on the oom side (even though this is extremely unlikely to be selected as an oom victim in the race window), and sets MMF_UNSTABLE to avoid other potential users from using a partially initialised mm_struct. When registering vmas for uprobe, skip the vmas in an mm that is marked unstable. Modifying a vma in an unstable mm may cause issues if the mm isn't fully initialised. Link: https://lore.kernel.org/all/6756d273.050a0220.2477f.003d.GAE@google.c= om/ Fixes: d240629148377 ("fork: use __mt_dup() to duplicate maple tree in dup_= mmap()") Cc: Oleg Nesterov Cc: Masami Hiramatsu Cc: Jann Horn Cc: Lorenzo Stoakes Cc: Peter Zijlstra Cc: Michal Hocko Cc: Peng Zhang Signed-off-by: Liam R. Howlett Reviewed-by: Lorenzo Stoakes --- v1: https://lore.kernel.org/all/20250123205849.793810-1-Liam.Howlett@oracle= .com/ Changes since: v1 - Added check_stable_address_space() to uprobe code - Thanks Lorenzo - Added Oleg & Masami to Cc list. kernel/events/uprobes.c | 4 ++++ kernel/fork.c | 17 ++++++++++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index fa04b14a7d723..90ebcdbad05ca 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -28,6 +28,7 @@ #include #include #include +#include /* check_stable_address_space */ =20 #include =20 @@ -1260,6 +1261,9 @@ register_for_each_vma(struct uprobe *uprobe, struct u= probe_consumer *new) * returns NULL in find_active_uprobe_rcu(). */ mmap_write_lock(mm); + if (check_stable_address_space(mm)) + goto unlock; + vma =3D find_vma(mm, info->vaddr); if (!vma || !valid_vma(vma, is_register) || file_inode(vma->vm_file) !=3D uprobe->inode) diff --git a/kernel/fork.c b/kernel/fork.c index ded49f18cd95c..20b2120f019ca 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -760,7 +760,8 @@ static __latent_entropy int dup_mmap(struct mm_struct *= mm, mt_set_in_rcu(vmi.mas.tree); ksm_fork(mm, oldmm); khugepaged_fork(mm, oldmm); - } else if (mpnt) { + } else { + /* * The entire maple tree has already been duplicated. If the * mmap duplication fails, mark the failure point with @@ -768,8 +769,18 @@ static __latent_entropy int dup_mmap(struct mm_struct = *mm, * stop releasing VMAs that have not been duplicated after this * point. */ - mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); - mas_store(&vmi.mas, XA_ZERO_ENTRY); + if (mpnt) { + mas_set_range(&vmi.mas, mpnt->vm_start, mpnt->vm_end - 1); + mas_store(&vmi.mas, XA_ZERO_ENTRY); + /* Avoid OOM iterating a broken tree */ + set_bit(MMF_OOM_SKIP, &mm->flags); + } + /* + * The mm_struct is going to exit, but the locks will be dropped + * first. Set the mm_struct as unstable is advisable as it is + * not fully initialised. + */ + set_bit(MMF_UNSTABLE, &mm->flags); } out: mmap_write_unlock(mm); --=20 2.43.0