From nobody Fri Jan 31 00:03:20 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14361FCFC5 for ; Mon, 27 Jan 2025 07:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737963024; cv=none; b=Zn339Ey4GfRU+KYbWT+9x2LyS4SabaUWvd1KRYa3gU0/os+9Zr9XYGsA+cxnFD+rxbQCTB2+VoPko+oItBvA9zg98YG612qe9Z4X2P3zex4zu1AX2OaRO6CLrbYg5d+X54hPsyjMEbLgmMc8OZ+RWIWrzPse0KfHur62/YxtEfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737963024; c=relaxed/simple; bh=w+0wtoJXs9TQghSdq1RJa54Xow/458AcjfD3CArrsgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q6/skX3xjTRtLpajC8F7C5CS/4xBcDBx9jdo3GuAT7P2blSF4L+Be3IllIXqUcfNeNIn7KPKWPJ7Zo+wHHKoO7u0Dx9eQvIUwLGcbYPYrN4745Wdx0bHqoxfrCu0jualRohOv783GJkoCYVk9YEJFnHExU2LE5nGInOYr6k9LHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PqV5lKWx; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PqV5lKWx" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2164b662090so77453095ad.1 for ; Sun, 26 Jan 2025 23:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737963022; x=1738567822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kSgdSt89nTEWoMlDHQC4zKaDJjnbZfjCeF+nCuROQ6c=; b=PqV5lKWxgQZNnFgnyxe0eYfh3iXv+BOIGlQxHw4xDUCgLA7EICE+zDlyC7/NYeg7Zq qB/yQmJINhfTBYjkJFAwlrs6ANNeyXC1EdkAW0OPFqQeMeh7j4LRWTQWxifaeWNxwaKA GpZDC5GVNbC/KCBd7TDbdUxg2bmTyxP12V0QU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737963022; x=1738567822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kSgdSt89nTEWoMlDHQC4zKaDJjnbZfjCeF+nCuROQ6c=; b=ccF+60ImW3uPkIgOJtRRLnV/4SfbvZonZu/P0UBrI0cCQ9WHzJL8UPhx/MxkpGnMzw JWzVDcGsX9+rL4VtoYQYBon6khhGICxS2+h6K8QwuBz8M/Ex0BLVvypmAiJhY+dIm2NX kuMowmyEU9EiCkDS/l0X+CmxDoEisC1WJd8XLS1ani2inewhkSbWwLM/I7o/KtNFFD9X /HW2c07u8vDTSW45NJYE1ZKl3mUfeABEDNz+8FU4W/MfHvvu47XzFe0iIhR1kmB9vGn3 1QZ/MaSEdSKHECa6yQsNFLxvSM6APu0ZUcZ3i8vSUInK48tEpQTFQp7RO4n2c1OEkZMr EwHg== X-Forwarded-Encrypted: i=1; AJvYcCWD1RP1uUSIvf0srOwhp0MqzqHQUC7HFcZieJCMl95rgPG2KyK98qm5UsqRNPVGHRiLg8YSSjWFKpXOfNs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7TbNvuR0Qe5Qee0ZMW3xNBaP21+Z/0ku63/YZGzglyARBGPxO N7VXy6VN3qL2mtTXKd80dEUm6Ipm5pOaZe0fuVqlT8yEm7Rnrr29syRQ+r5X4Q== X-Gm-Gg: ASbGncsNFxT54ER+hDsj3xOJJHc9ZlyPy0ONcSQ7WwahVgVQMw3/Q56vKlYR/bVZAdv rbDpuRTMFVksgxPVoglXmB08H+E4BcBe2WsG59iVRCs2+4SGcxPCK0aE+HuRnCCexKkCDWofODi vFDAkEZq0EmD+vdkmUdE9wx60OGXKLVRmKHlGnJUq1ev3k7Wez4w9iIniDqzmrUQn1kBkkDGDi2 Cj5oiisk+VubRuQIjdfkMhXBw3vmAz1NKmi5xbhn+ryFcOuXka7xY04chsdO5u/NhQwOng37dQ4 vRGEJnY= X-Google-Smtp-Source: AGHT+IFJkNEfxxGm9e2mhZinKXdaG+6TaYhwskg1qiYEq63JEXJ/MVr0HkgBllV11tnfS2o+XZnVNQ== X-Received: by 2002:a17:902:cf0b:b0:216:2af7:a2a3 with SMTP id d9443c01a7336-21c3560726cmr685117125ad.53.1737963022243; Sun, 26 Jan 2025 23:30:22 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:566d:6152:c049:8d3a]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21da3d9e092sm56864765ad.28.2025.01.26.23.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2025 23:30:21 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv2 8/9] zram: remove writestall zram_stats member Date: Mon, 27 Jan 2025 16:29:19 +0900 Message-ID: <20250127072932.1289973-9-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog In-Reply-To: <20250127072932.1289973-1-senozhatsky@chromium.org> References: <20250127072932.1289973-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 10e4c6a7735c..07cae8fe9b66 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1437,9 +1437,8 @@ static ssize_t debug_stat_show(struct device *dev, =20 down_read(&zram->init_lock); ret =3D scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); =20 diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 045032acb22f..b7e250d6fa02 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -78,7 +78,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */ --=20 2.48.1.262.g85cc9f2d1e-goog