From nobody Thu Jan 30 19:14:17 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92BB7158D8B for ; Mon, 27 Jan 2025 07:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737961868; cv=none; b=PWSRSsvoPgHRuNIFkpjBHT2tymwBmGn1cspxSzGSCngVu7nPd/SBXUk/I878+V7BhQaxs642XwgATEXopFdw4MIREYoDrWV8EgtjiJoQn+BorO6vd7lE6vohFRyURJ7Rp6ArqwXCWP9NKlDpWaAwxaqOalSCoxe0a604lSjpU5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737961868; c=relaxed/simple; bh=jbkElb41o2w2SgRe5NYxjMlK/n+hh4hoG0XCEvONDAM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r1QOeNBw7aB5/4WewWd2Hwo4cDoaqBpHohT95U5tzPB4es/i74aD1Zpy3eAraf914ULT3jg/h5x5lDGd/O3PGalkrM7uWj9n6Jb0yXtWpc5SsJlOsiIPnqeymTcFyvfTcGLDqqPJB9+njrvz4J4/V4G3Q2SYu5O2a3VHlRbAPxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F6oRl9wP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F6oRl9wP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26554C4CED2; Mon, 27 Jan 2025 07:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737961868; bh=jbkElb41o2w2SgRe5NYxjMlK/n+hh4hoG0XCEvONDAM=; h=From:To:Cc:Subject:Date:From; b=F6oRl9wP89kPQeMRFuTaBziV7+Jsk1lIrGW7359vj32IsgNEVOWb4e065UCtIovJj 44fhprrhyJZaaQ7jICFLivbD1Cj6V4U6V1zAsb9Y9FSnzxJUV/5EfEjsyfbeIbmZuL DjSLyekX7NpIRUNSNtMsn2Aa52yGu7sHGHbAOkUAmoavj54vL6jM9S+SRIP2jvRiv/ L3OWcqxUUe6c4bIB2sMnWpoTSZjvkOuYhNE9OvPsNqrP4hRmbfVk24KLKrjCmeyXol WX+mXTk7JtmelYLTUBJH6FIgzTgsVqfdNOOD8EXHcVk4ArMtlBmSEfvlV4rVXBFDeS KGrGYInEo5clg== From: Arnd Bergmann To: Xinliang Liu , Tian Tao Cc: Arnd Bergmann , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/hisilicon/hibmc: select CONFIG_DRM_DISPLAY_DP_HELPER Date: Mon, 27 Jan 2025 08:10:02 +0100 Message-Id: <20250127071059.617567-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Without the DP helper code, the newly added displayport support causes a link failure: x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function `= hibmc_dp_aux_init': dp_aux.c:(.text+0x37e): undefined reference to `drm_dp_aux_init' x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function = `hibmc_dp_link_set_pattern': dp_link.c:(.text+0xae): undefined reference to `drm_dp_dpcd_write' x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function = `hibmc_dp_link_get_adjust_train': dp_link.c:(.text+0x121): undefined reference to `drm_dp_get_adjust_request_= voltage' x86_64-linux-ld: dp_link.c:(.text+0x12e): undefined reference to `drm_dp_ge= t_adjust_request_pre_emphasis' x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.o: in function = `hibmc_dp_link_training': dp_link.c:(.text+0x2b0): undefined reference to `drm_dp_dpcd_write' x86_64-linux-ld: dp_link.c:(.text+0x2e3): undefined reference to `drm_dp_dp= cd_write' Add both DRM_DISPLAY_DP_HELPER and DRM_DISPLAY_HELPER, which is in turn required by the former. Fixes: 0ab6ea261c1f ("drm/hisilicon/hibmc: add dp module in hibmc") Signed-off-by: Arnd Bergmann Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisi= licon/hibmc/Kconfig index 93b8d32e3be1..98d77d74999d 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig @@ -4,6 +4,8 @@ config DRM_HISI_HIBMC depends on DRM && PCI depends on MMU select DRM_CLIENT_SELECTION + select DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPER select DRM_KMS_HELPER select DRM_VRAM_HELPER select DRM_TTM --=20 2.39.5