From nobody Mon Feb 9 17:56:12 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC57718FDDE for ; Sun, 26 Jan 2025 19:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737919055; cv=none; b=Nuyfa+quGI6FnqaeY0iVOWFQ8sE4DRcEXd++OKBAOkv+q2zxTfkP0xGTMFw7o3UADTHdjXgadOcqVa95bQAAClL3lUQ/gotNXI9aeYK333syTVJrq0ASmqcZjj1p09byosC4jvXCQTwJcfF6FAockLu2QGwels45zhMx/buGrLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737919055; c=relaxed/simple; bh=d3DmvJs8PzCLRMa4hPv+bA8qc2fFhFDX51wBdIILi34=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T8NMF45lxm61PKRBW+nVTxOsekVsGyWMGPT+LvbI/pcG7CXrEIZUSrsx3ApYrlpmgjOJZ6NxyAVZqc5mqg9yn6WbE357Qai0xjTBmQE7V/Y3NzZpz/cuybYGMQQevM9JohIsIs90xwJ1p9aitm9YYZgllmOUU8MQHm2+LF7n2cA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WXX+3uh+; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WXX+3uh+" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737919050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QkzIyejqKXs8iGV/TUA2tE6gFfZTg3tleF4YymSrjSw=; b=WXX+3uh+XjkmO6KNZZA0FZGwxL4im4Jb+ZZT2bfPNearLKJYyNkqlfMyqjPmCKCjCCw6Rr HhZSf5/0G6zSb3HkhYHdsHy6Cb44Wu3ySErg/tH7OhCrF4K7Z7DmlH6L09UVqSPc6Pv+P6 517hQms9f0rcc412HXy3q8NQ9sSQzHY= From: Aradhya Bhatia To: Tomi Valkeinen , Dmitry Baryshkov , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , Praneeth Bajjuri , Udit Kumar , Jayesh Choudhary , DRI Development List , Linux Kernel List , Aradhya Bhatia Subject: [PATCH v8 10/13] drm/atomic-helper: Refactor crtc & encoder-bridge op loops into separate functions Date: Mon, 27 Jan 2025 00:45:48 +0530 Message-Id: <20250126191551.741957-11-aradhya.bhatia@linux.dev> In-Reply-To: <20250126191551.741957-1-aradhya.bhatia@linux.dev> References: <20250126191551.741957-1-aradhya.bhatia@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Aradhya Bhatia The way any singular display pipeline, in need of a modeset, gets enabled is as follows - crtc enable (all) bridge pre-enable encoder enable (all) bridge enable - and the disable sequence is exactly the reverse of this. The crtc operations occur by looping over the old and new crtc states, while the encoder and bridge operations occur together, by looping over the connector states of the display pipelines. Refactor these operations - crtc enable/disable, and encoder & bridge (pre/post) enable/disable - into separate functions each, to make way for the re-ordering of the enable/disable sequences. This patch doesn't alter the sequence of crtc/encoder/bridge operations in any way, but helps to cleanly pave the way for the next two patches, by maintaining logical bisectability. Signed-off-by: Aradhya Bhatia Signed-off-by: Aradhya Bhatia Reviewed-by: Dmitry Baryshkov Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/drm_atomic_helper.c | 69 ++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atom= ic_helper.c index 5186d2114a50..e805fd0a54c5 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1122,11 +1122,10 @@ crtc_needs_disable(struct drm_crtc_state *old_state, } =20 static void -disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state) +encoder_bridge_disable(struct drm_device *dev, struct drm_atomic_state *ol= d_state) { struct drm_connector *connector; struct drm_connector_state *old_conn_state, *new_conn_state; - struct drm_crtc *crtc; struct drm_crtc_state *old_crtc_state, *new_crtc_state; int i; =20 @@ -1189,6 +1188,14 @@ disable_outputs(struct drm_device *dev, struct drm_a= tomic_state *old_state) =20 drm_atomic_bridge_chain_post_disable(bridge, old_state); } +} + +static void +crtc_disable(struct drm_device *dev, struct drm_atomic_state *old_state) +{ + struct drm_crtc *crtc; + struct drm_crtc_state *old_crtc_state, *new_crtc_state; + int i; =20 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_s= tate, i) { const struct drm_crtc_helper_funcs *funcs; @@ -1236,6 +1243,14 @@ disable_outputs(struct drm_device *dev, struct drm_a= tomic_state *old_state) } } =20 +static void +disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state) +{ + encoder_bridge_disable(dev, old_state); + + crtc_disable(dev, old_state); +} + /** * drm_atomic_helper_update_legacy_modeset_state - update legacy modeset s= tate * @dev: DRM device @@ -1445,28 +1460,12 @@ static void drm_atomic_helper_commit_writebacks(str= uct drm_device *dev, } } =20 -/** - * drm_atomic_helper_commit_modeset_enables - modeset commit to enable out= puts - * @dev: DRM device - * @old_state: atomic state object with old state structures - * - * This function enables all the outputs with the new configuration which = had to - * be turned off for the update. - * - * For compatibility with legacy CRTC helpers this should be called after - * drm_atomic_helper_commit_planes(), which is what the default commit fun= ction - * does. But drivers with different needs can group the modeset commits to= gether - * and do the plane commits at the end. This is useful for drivers doing r= untime - * PM since planes updates then only happen when the CRTC is actually enab= led. - */ -void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev, - struct drm_atomic_state *old_state) +static void +crtc_enable(struct drm_device *dev, struct drm_atomic_state *old_state) { struct drm_crtc *crtc; struct drm_crtc_state *old_crtc_state; struct drm_crtc_state *new_crtc_state; - struct drm_connector *connector; - struct drm_connector_state *new_conn_state; int i; =20 for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_s= tate, i) { @@ -1490,6 +1489,14 @@ void drm_atomic_helper_commit_modeset_enables(struct= drm_device *dev, funcs->commit(crtc); } } +} + +static void +encoder_bridge_enable(struct drm_device *dev, struct drm_atomic_state *old= _state) +{ + struct drm_connector *connector; + struct drm_connector_state *new_conn_state; + int i; =20 for_each_new_connector_in_state(old_state, connector, new_conn_state, i) { const struct drm_encoder_helper_funcs *funcs; @@ -1527,6 +1534,28 @@ void drm_atomic_helper_commit_modeset_enables(struct= drm_device *dev, =20 drm_atomic_bridge_chain_enable(bridge, old_state); } +} + +/** + * drm_atomic_helper_commit_modeset_enables - modeset commit to enable out= puts + * @dev: DRM device + * @old_state: atomic state object with old state structures + * + * This function enables all the outputs with the new configuration which = had to + * be turned off for the update. + * + * For compatibility with legacy CRTC helpers this should be called after + * drm_atomic_helper_commit_planes(), which is what the default commit fun= ction + * does. But drivers with different needs can group the modeset commits to= gether + * and do the plane commits at the end. This is useful for drivers doing r= untime + * PM since planes updates then only happen when the CRTC is actually enab= led. + */ +void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev, + struct drm_atomic_state *old_state) +{ + crtc_enable(dev, old_state); + + encoder_bridge_enable(dev, old_state); =20 drm_atomic_helper_commit_writebacks(dev, old_state); } --=20 2.34.1