From nobody Mon Feb 9 19:30:56 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39271F9ED2; Sun, 26 Jan 2025 15:09:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737904184; cv=none; b=iIi4BVP+A1Q+WIduaoCL7IoMVxuc24MLqbiFdQwPxNat/AxhEuApYZdPCADzkpLof8F1xM+yhM5wW8Ky9CmNu724D0dAEPjLT9DDb88uWNWTFMcl4OQj5M5IZ32F3Av/o9Q/O9pNJcSVEMq3vuRCblU8n1GhHXNOvqSAIKoiemQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737904184; c=relaxed/simple; bh=BZGlsnxeNApjpF03VXP/1Ncr9dS05h2pelrNYV2ZRJw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=D7p8Bh8lg3PggYDJsrfop7enrAQb/PVmYoREVt9e05tMqJBSM45nL4QA+YW65x1k/vOPfRTBw+BWX/ZiMd1S9UXTJGUy1cZnB971QHA73jtsxMjRhzB4DJ1ZeUVIsQduBeZqfxhfKMGUK0sqa3xAl2G44oZ1NJdaugNJl91R9I8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=izU8Q5ql; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="izU8Q5ql" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF126C4CED3; Sun, 26 Jan 2025 15:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737904183; bh=BZGlsnxeNApjpF03VXP/1Ncr9dS05h2pelrNYV2ZRJw=; h=From:To:Cc:Subject:Date:From; b=izU8Q5qlQ9PKH1IHnxg25kPUIuEdV28jhY4yKZEtR1pjUo5oFLp1kzkPmvU3vnQ6O 9MbeRG9n9Y2snxW3QRQzP68ZV1Ch1hvEDiEnU8pYYhtYf3kxRiXgCP5uuSI37CaZRw Yhcrp8+Cl01BdoFWptaInJPNUzFqUadTShgY15jzd4M8odd1tmSMbtGRTPJ6rOz5kH zaG7DTxDGmNZs2/DfcmGlYSrYnUHPG06yIf6jcdavYyL6pinb+Sqx0k4n7CSw/ttKD 0IEvsXI5LBqgyIpuZeceW9RgVDXPq16Hi7v48PPuKG0dwEBrlit1HjmHMeO0a2c/fN O/YokDDoNH7Jg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ian Rogers , Namhyung Kim , Arnaldo Carvalho de Melo , Adrian Hunter , Alexander Shishkin , Andi Kleen , Athira Rajeev , Ben Gainey , Colin Ian King , Dominique Martinet , Ilkka Koskinen , Ingo Molnar , James Clark , Jiri Olsa , Kan Liang , Mark Rutland , Oliver Upton , Paran Lee , Peter Zijlstra , "Steinar H . Gunderson" , Steven Rostedt , Thomas Falcon , Weilin Wang , Yang Jihong , Yang Li , Ze Gao , Zixian Cai , zhaimingbing , Sasha Levin Subject: [PATCH AUTOSEL 5.4] tool api fs: Correctly encode errno for read/write open failures Date: Sun, 26 Jan 2025 10:09:38 -0500 Message-Id: <20250126150939.963056-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.289 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ian Rogers [ Upstream commit 05be17eed774aaf56f6b1e12714325ca3a266c04 ] Switch from returning -1 to -errno so that callers can determine types of failure. Reviewed-by: Namhyung Kim Signed-off-by: Ian Rogers Acked-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Athira Rajeev Cc: Ben Gainey Cc: Colin Ian King Cc: Dominique Martinet Cc: Ilkka Koskinen Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Mark Rutland Cc: Oliver Upton Cc: Paran Lee Cc: Peter Zijlstra Cc: Steinar H. Gunderson Cc: Steven Rostedt (VMware) Cc: Thomas Falcon Cc: Weilin Wang Cc: Yang Jihong Cc: Yang Li Cc: Ze Gao Cc: Zixian Cai Cc: zhaimingbing Link: https://lore.kernel.org/r/20241118225345.889810-3-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/lib/api/fs/fs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index 4cc69675c2a9a..234c882f9029c 100644 --- a/tools/lib/api/fs/fs.c +++ b/tools/lib/api/fs/fs.c @@ -323,7 +323,7 @@ int filename__read_int(const char *filename, int *value) int fd =3D open(filename, O_RDONLY), err =3D -1; =20 if (fd < 0) - return -1; + return -errno; =20 if (read(fd, line, sizeof(line)) > 0) { *value =3D atoi(line); @@ -341,7 +341,7 @@ static int filename__read_ull_base(const char *filename, int fd =3D open(filename, O_RDONLY), err =3D -1; =20 if (fd < 0) - return -1; + return -errno; =20 if (read(fd, line, sizeof(line)) > 0) { *value =3D strtoull(line, NULL, base); @@ -428,7 +428,7 @@ int filename__write_int(const char *filename, int value) char buf[64]; =20 if (fd < 0) - return err; + return -errno; =20 sprintf(buf, "%d", value); if (write(fd, buf, sizeof(buf)) =3D=3D sizeof(buf)) --=20 2.39.5